From nobody Mon Jun 8 05:25:28 2026 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 266794DD6C8 for ; Fri, 5 Jun 2026 12:54:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780664067; cv=none; b=RUr9XiVp3U5kGT2eBWejD5Ii7eMbZUZPrm7V8pMQDxngkm3sIhJfJUisWFRMKuO4XMirvW4L610AQ0VUENETynLm/5gk5Upd/QjyWCuN0pS08yU42QMYtxUI6HV13/uh3bFA46EXq7sgkXuWs19P8+0/W+uQEHdnvVjPLjle5AQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780664067; c=relaxed/simple; bh=FIIHe24uc7O4CBDOKLXoeJY2JexSRAuF6oL7yVzo8Zg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LwtxF+ikpZpqtuI7xvvmzDocBfo7YuntdstjV/SJYA4aRf2vF+2w8BqdSjsJqvkFokdfA0XNifxNeTGoPmd/dX0IzwMVPXEAYTbEGREyscHCrm5nu+3tECDrJjcaW63A8DaO+kKqlt7GmCbNCL3tDNGx38MMRkTAdiCr9Y0eFp8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PaSgCD73; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PaSgCD73" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-8ccf181a52bso16602596d6.3 for ; Fri, 05 Jun 2026 05:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780664064; x=1781268864; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=shO4CEuYdjm6KH0/u78uU6qowwMulzIyxJQ1MR7e7A8=; b=PaSgCD73iSsVOjsUrQ7zKNaAc95R/kxpvdGyEIVNDhp0/x6IT4ZeFzK5qt5+iBnz1A /fF2ZnKJbTzL2QwUPepv6XnoDQ3F1gUdBspKnCJaLBSctfETWsQmuSgEIiMC/d/LI3JL BCv2MoQErCUKTlJ6zJiG9MTycZz90YqQWW7kFBbsPiNJqDdZvw3n87VCL5bd3Mu27ula VI3542DqQW9d58xnc69STl68rOGiEm+SlSsdyANfL8/hQ3DWSJzzf7j8kACBR51Frw4C wSBfOHkCuiwpxV60OibU5I7ecUuxc2OyebAl38/awv2ES8AwWlA7pr8ddxLfZq3LB8y4 xqrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780664064; x=1781268864; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=shO4CEuYdjm6KH0/u78uU6qowwMulzIyxJQ1MR7e7A8=; b=VcilEIWh6c1c8gHcHD3A4Zawjd6ExLEua0sq+sdUj3+5TyIQk2gVZzlIL7essKpBwD remFWRTWRjjMzsymPRsLi/hENV9h5YE7FQ/TPW0j8w7FMUBz5wWc6cwGrgq0/Cejnoaz esR07hzBwnFKkeKQ7DUoXNWyrJUTHhA1EvV3jOPqIzEeLXzOUiWHAv8SlS2UR3iDfvTD KsX14tGup9hS4/R091UJtAB6Sl6yPftr8OpSZWJ0hraQe7ra7RWlh0YpXT/kXmYGVRfP cCznVKTn1mxjiIqcBUxOBiariPqXY/eka8ak1YF93q3O6Yqll9IXAY3tbDl91wto8pVn 3Y1w== X-Forwarded-Encrypted: i=1; AFNElJ9uTKiw6h6bJH+ZWtM+b2b1d84oCaNsDXwLVDpNiJVvd0mBbEtQk4G+27LWzSbTznukQdqljkSWjAcCmIc=@vger.kernel.org X-Gm-Message-State: AOJu0YwEQsLoMzpxDl6dmTSzCmb8Bdbv0WpmUreCpozxSvurCWpgZNwu 4AW8sQsBSLy6j/c34+pncpgGKorryDLCq/z1uED0tmTH0nS2/2pjRGEr X-Gm-Gg: Acq92OGzHgFbId9TH18BbGtib+4SCQm04BCbuER98PCRki2uJT8VLcLe/YO/c/CZ0Jn 1wAArf//d+YiKIbSjiNQmctpK2T3wzbLABxTvLwbr9sGrmfEORqRU5GWMRV9HUW4XSuZf8dHIsQ fSwcw6UEb0xfIuHxkF3oQ6aPrtut0BspvZkIogwgfxB37K9kwKDKkovze2euPP0Jvb4DmpdgnAi OjtQpHD8dLmozUTTc14n/BQXWjx+qzz6KcYmucgF6tb6eJ09ke/s+KhYCgPfCprmuT9j2WndSuK wMpbNiByhT5fCVbYfUq+kxL58g9vRkYlmD2oYi8QaOpU2pMJULLBZIBoUpWmAEREyXJ+Oc4iSd3 cSmvYH6fGuZlbziD8FC/47llVoUHm3wRV+uKLy3I1XepENZ8oFsA9jKNNHH9l90jjS3y+z3FLD4 d5LP9v1RQnzgXSYBsz/QRJSYN11sN6WgMa6MQlB1G8YD4yhxBFH1qrI5KjUGo5/Q== X-Received: by 2002:a0c:eb09:0:b0:8cc:15e4:1208 with SMTP id 6a1803df08f44-8cee6156373mr46026746d6.32.1780664063708; Fri, 05 Jun 2026 05:54:23 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cecd0535b0sm81783306d6.28.2026.06.05.05.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 05:54:23 -0700 (PDT) From: Yuho Choi To: Borislav Petkov , Tony Luck , Michal Simek Cc: linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v2] EDAC/synopsys: Fix cleanup on injection sysfs failure Date: Fri, 5 Jun 2026 08:54:17 -0400 Message-ID: <20260605125417.2348115-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" edac_create_sysfs_attributes() creates inject_data_error before inject_data_poison. If the second file creation fails, the first file is left behind. The same failure path runs after edac_mc_add_mc() has registered the memory controller with the EDAC core. Jumping directly to edac_mc_free() skips edac_mc_del_mc() and leaves the registered controller state unwound incorrectly. Remove inject_data_error when inject_data_poison creation fails, and route the probe failure through edac_mc_del_mc() before freeing mci. Fixes: 1a81361f75d8 ("EDAC, synopsys: Add Error Injection support for ZynqM= P DDR controller") Signed-off-by: Yuho Choi Acked-by: Michal Simek --- Changes in v2: - Remove the CONFIG_EDAC_DEBUG-guarded del_mc label. - Call edac_mc_del_mc() inline before jumping to free_edac_mc when edac_create_sysfs_attributes() fails. drivers/edac/synopsys_edac.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 51143b3257de..9ca2a842612e 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -1120,8 +1120,10 @@ static int edac_create_sysfs_attributes(struct mem_c= tl_info *mci) if (rc < 0) return rc; rc =3D device_create_file(&mci->dev, &dev_attr_inject_data_poison); - if (rc < 0) + if (rc < 0) { + device_remove_file(&mci->dev, &dev_attr_inject_data_error); return rc; + } return 0; } =20 @@ -1431,6 +1433,7 @@ static int mc_probe(struct platform_device *pdev) if (rc) { edac_printk(KERN_ERR, EDAC_MC, "Failed to create sysfs entries\n"); + edac_mc_del_mc(&pdev->dev); goto free_edac_mc; } } --=20 2.43.0