From nobody Mon Jun 8 06:38:59 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013002.outbound.protection.outlook.com [40.107.201.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4B864B8DF0; Fri, 5 Jun 2026 09:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780650082; cv=fail; b=NFm+srTVg/i2mdZGq3gM8DplW+cyRa3zDUotWp1XKwcowzLkB7RaR6g0UxNj5BgbI7FIfCdT5zzYy69z+1i9/+0KZEXIr4k70fJFrRcpSpfUtodea0fhKbOORVXgwpQWe5OR+jchj0kVjbSeGVahG7LGC+T4vA47c/oHUNR0jVE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780650082; c=relaxed/simple; bh=j1tjeByXeIHinLjHoJARApYbtqw5FLZrQo/H1IVDTic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=VSY6OQNCoIGsk+WeQOevAGkwv10stQVeVZqTzk9qLgsv5/UtIsmJ0z5TFHqoi8j53ThM9GKi6qzTrYm16RmvAq/VtnclT/C8VnouxVoPLaXpKMa4Tiu1pHmoVg8hlZsnO5QnN2UnFUwLtLBHs/LS/F2F1zffq6tbIKdZu3aiMz8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=Qt/jZc9Y; arc=fail smtp.client-ip=40.107.201.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="Qt/jZc9Y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YEDroIJplxRpFWjqM57lElh1Yaqy2M28HaPYumN+f+RgUtmD8wMnx+FmVaBzty9rvgMbo06ei9L1/ZIfgrHnhs9kTNkzqaVmMG1qRvCou5qshmmYawmHvItlUzp7+Eiw2JMSzK1HtbOI0TAlEmKoB7O6AGPQfbZ0vsNdne7SM1kwUVGgqqQ4hVDMX2Uz/B9DMlh/LwcSbRn/U/IocHGYyt7PDpKhQI8/hzUfVFS9h2UWuowJHTTFmFf98130IC5bw0uU63DzazmBLEjn2OCV7s0wAMEvn4IOZ+KPe7KUpX5jv+gFqCZEY3YIYZT/bSRpSm0ME1pCXQPCKvx4U+5chg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R6OgbckISqAtzhoezk8E1ClROdhN3BCX2f8lIC8DmhQ=; b=td+kIW4Ka04jL1Gvf/U6zGzfcIX44TYRoFobx2NUE8+TwZ24EeoBn+MD8uKGN1i1ltasi4FgF+SMQV4gA4aLBDix6Ni8vscGIs3IVenPP2P6QHQFKL89cnT4C6CGGiOPwKDZr0gak5RN1fcJW/pnxhFWVrKf5oIhy2pIt1aXFv3IsXXSjKvxjumdVxP2yO0Gt+VCRvn5QZa2ozmV7NpqkmNYhF9KwI6d0n5Jm0RwZ2z3o4KFP9Gokbgf44kdxEuketSwq0U9rwiYuPmUFR0tLc3t4MgYvp9Wuvl2e75XMUh73vhUv8B48QC8uxHfS0bYr4TC+/hBIMixEEmtkJ/JXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R6OgbckISqAtzhoezk8E1ClROdhN3BCX2f8lIC8DmhQ=; b=Qt/jZc9YR/zneBdEu/MUX/vnHZnBIqHbj6CThU82Q7WEyTPugAUr/bIyo3xw7Yw/AhQNCFLguHA7/kPy/7oEOUEvUkNBO0SAhhaxQyTbVcyfNj+VPLagTwePlQPKO+Lkwoq6Ig3+4xQ4cJX8cwtAOil2QUdl0BlgmsSU2k3Tf4An5/nEqUD/7VISomYQPc6JCM6hc+jWK1fN0vG8x8ayWTMKPoA2mT0oDIaJ6vrW97nHpf8Cwp+vO6XV72afOd7DZvyRPKUcRkuadyt4saojayRQ7xOnoUuEdzQfHYdSkcrNt5x1MoZnZFFCbffTv2Z6q6X7b640ffsejAM3DMwP4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) by DS4PR03MB8472.namprd03.prod.outlook.com (2603:10b6:8:323::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.9; Fri, 5 Jun 2026 09:01:17 +0000 Received: from SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775]) by SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775%6]) with mapi id 15.21.0092.006; Fri, 5 Jun 2026 09:01:17 +0000 From: muhammad.nazim.amirul.nazle.asmade@altera.com To: netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rmk+kernel@armlinux.org.uk, maxime.chevallier@bootlin.com, Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] net: stmmac: xgmac: fix l4 filter port overwrite on register update Date: Fri, 5 Jun 2026 02:01:12 -0700 Message-ID: <20260605090114.16028-2-muhammad.nazim.amirul.nazle.asmade@altera.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260605090114.16028-1-muhammad.nazim.amirul.nazle.asmade@altera.com> References: <20260605090114.16028-1-muhammad.nazim.amirul.nazle.asmade@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0026.namprd05.prod.outlook.com (2603:10b6:a03:254::31) To SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6964:EE_|DS4PR03MB8472:EE_ X-MS-Office365-Filtering-Correlation-Id: f1c24ace-0e65-41e1-bc19-08dec2e1009d X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|22082099003|18002099003|55112099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: tJQhpQKit6Cx/9iS82k4L9gIhfO5dCdf5BBiPIO+SbAU6j5EY+8ZYHOjd+Fi0TnHDqt/BPmXRXdOW+YWVBNc+N/XNWXF8brVzgINld2Kybp1cSmKE/HxLkKHqlI6cn+6iYV8VWT3/joPocRNCbPQhTnfIn1GI+wnH63/1/Jwe+Wi3ny0DfS3JFqlEeiFF1GakRiUtBPvUaezQXBp6csuqmv6PbfzNZmOaapbPUYUU0+f/cgFlmTj0MmxUq6fDmBgA+ehpMyZ1x07VWhEZvKRRwQEv3qIqLsSazrVhmsqc+f+buMTQVJgNAXxhshHbGBR2GB3OZnHJu16v9S0W4F2KKMx6BiBOUKLF9lP2ZPZKgvk91kaKbv0HEphuvczKwI2kcCWC94loZcwvUhvKXnrgv/+u0+v+xj3cq8zv91sUgLeS+GrSSgm80O8QcYHVDRP45rNa+SsspmjqS/gFjCAJyYorjwp/53ZXKf6pVQV3dN9AlJ4/CEVpoRHXafCqcum+tLW2XiIMYu6IejMNUYANk7Fh8PCx+20HdqtOBdZi8twmJ8Q/ekOF/iS5bpf8uCsBpZ0IV8gMBhicsJviA7E6PaTGsCScnoqoCo0qfecLkmyqa8XETaZEHZTjDYE6YLN4nl2eUDjzGP+hZDASibbLIDZsPlcegwU8eA9XcFCEpFqaYmmFn5p0x4+jvIFDTPW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6964.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(22082099003)(18002099003)(55112099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aFDHRFQRsaxcrXFqX+M696IcqQYsdM2eZ5C5E7tx0Fi0XArx2GfOyrYW7aAt?= =?us-ascii?Q?T8bIYBJNbUa4YHsRS+YXSgtROPjUE3p29BcM7UzxNwfHIIX7hvKsT6VTDMY5?= =?us-ascii?Q?fjhcREvkc2W0myZeBfFvHsobD7lI84QQqGQ2iuIWPumwJYhEEQL/mr6xEkh3?= =?us-ascii?Q?CBMsVFBF3XILfQ9gJCjKOKQqpWtbTPW2VmIsF23XXTPLlpx1l4Y6ZzWMIK0R?= =?us-ascii?Q?zghOpWtgMKfYCWF27LrY/x+fCR+w51EG6kdg1f+TnSw9BA7EcvJndJhL2yLf?= =?us-ascii?Q?wkeVc8YXB+xvhY55tDN1UhMJqDzVbCjTwUIbu15xWk3IiofngxdbsrcjxnLS?= =?us-ascii?Q?y/dH+6k6MsG0HHQ32xP/iKNcsnC4BrukV1WJPybGUn/E1l21rBmy7BYvrV38?= =?us-ascii?Q?F56/fm3m7I/ODl17eVflysIrnBNfhcFpVMMIJbv/Z6aHD4Nyyd13Hi0p2mku?= =?us-ascii?Q?x6/UrgX2j+GqO2wzkozcbGyz3IEtp8cxKFIrMgro5pJ42IwYsCO8yFpK+PM8?= =?us-ascii?Q?dr7imB/sDDt9q6N6Li2b7HYqFtNi+6Zf4mVW4TsAOTjPowWDzGRIpOqRCTc2?= =?us-ascii?Q?rT5BgrLACBGfoTShq/el50htfOusNDVYilSexE/q5G2/2gTwQ/ENi/VNp0cL?= =?us-ascii?Q?ry8svrfsEYI57ZVclh7S6p9tHvYhUNgjIvd2UFdMwE8CuZTkMBPDSp5GH9bY?= =?us-ascii?Q?1HUgRWGytCZFc7S6HDjvEVyAaiIcDiqJv+Vv8cbv0Y+MJ3HB5djK5B5rdGF9?= =?us-ascii?Q?4rB+RbvtfuOXZ8ErIbgxytaCbFqlXVzDInO3QGdm4mfrASdXw1gkNa6H7Z9t?= =?us-ascii?Q?laTNwCbWbjoDfzqfudB/6KmsDYUsjgd02KcDbA0zKImUjBZyavJBTdGbvqNA?= =?us-ascii?Q?xQ5YxnViIgm3lkPXFbifbwSxvup1MXjAeKs8KzNp/o2ktwwTTagWzSYpTVhq?= =?us-ascii?Q?TTgdNU2XnsM0oFanH9ppWujEovemNpOr6sYAuvQEEY+b/5JoZfET7sZiPb6o?= =?us-ascii?Q?6/0Ew016LW1MfZO4gtjiYT3mxnJmZkQSnVvZG6xuuboPoC9Pbn/pPh2yfQ5r?= =?us-ascii?Q?PD0+sKcD45CDJnha4FHElwquqvimirHzsiRli6GjHVMqo16CtA6PfSkBmPGV?= =?us-ascii?Q?hApZVzddgOq8rxseNh6uxLUEK4suDbjQpyOCnHhvRN5gTJKNMEJzVot9DcNE?= =?us-ascii?Q?lwjjjzJwMgqgulaG72qlPMRH4/nUw6sKxrJXhf9MrHL5I5x/Qfof0G1EqNrc?= =?us-ascii?Q?ICmaJun+i4AFCR5J/j64Q+v6t/92NTAo5g4SA8mqVg1ueibRC2L2U/rmTlaD?= =?us-ascii?Q?byLVrHIJK101cM5hCUooQ5970ohSTdNiovC69IBXsb1VwRq5bGulG3V6ghvG?= =?us-ascii?Q?vE0H9IZ9xbVM5FP1k9GxVR4qCKfMHqH5UuJJlTVGshrtXTL6wFj++5xYBYKV?= =?us-ascii?Q?I5vgMePzx5nnNzi9BVxYAsCpEzXMA3DxD/4FYyl+s87mf6uq0AfHOkm/cUOK?= =?us-ascii?Q?61UpBSNMVdxe/TyYW6yct8QraCpeDV6ZneIuCRhsxKU5pTFV0d1LYbzB6mqj?= =?us-ascii?Q?w+R1zvuhZ19xtlv1ZnXM6dwdcGn9KgVYDiseozT9TPt0lv+c56q8gMgDnrSm?= =?us-ascii?Q?p6KYjlZnasR3fN0xYOzppeztE2DRQeexGw0ogKlq0fGEsj5wARlkIFh3/6rs?= =?us-ascii?Q?xxko7u1IKSJ3xdjWXzNFDuzg26vhRVcajmHy/lgpdG9SQNY2cSdnMV7/+vmR?= =?us-ascii?Q?7MJQV2/xaszzUk6z9eIfSKTeFX1Yk1SS7ozpdDRH2H6Ntl2dOYPM0Q+8se63?= X-MS-Exchange-AntiSpam-MessageData-1: EpMFsJK1zwV86w== X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1c24ace-0e65-41e1-bc19-08dec2e1009d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6964.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 09:01:16.9396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FK24GGP1xsbnj2Dcu1o3mAi8eWnHz/Dnmx3ox9Guf3ySqh0CJcP6WdPLAthWAQdqJ+82FBrSZzt0YGr0/pswag2ITjxPQKGgSSiLiMylH1yTapvHDlQS9s5M10HHtZw8dKy6ba/Pb2hKea3LguhbDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR03MB8472 Content-Type: text/plain; charset="utf-8" From: Nazim Amirul The XGMAC_L4_ADDR register holds both source and destination port match values. The current implementation overwrites the entire register when configuring either port, so setting one silently erases the other. Fix this by reading the register first, then masking and updating only the relevant field before writing back. Fixes: 425eabddaf0f ("net: stmmac: Implement L3/L4 Filters using TC Flower") Signed-off-by: Rohan G Thomas Signed-off-by: Nazim Amirul --- .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 28 +++++++++++-------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/= net/ethernet/stmicro/stmmac/dwxgmac2_core.c index f02b434bbd50..52054f31376d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c @@ -1370,36 +1370,40 @@ static int dwxgmac2_config_l4_filter(struct mac_dev= ice_info *hw, u32 filter_no, value &=3D ~XGMAC_L4PEN0; } =20 - value &=3D ~(XGMAC_L4SPM0 | XGMAC_L4SPIM0); - value &=3D ~(XGMAC_L4DPM0 | XGMAC_L4DPIM0); if (sa) { value |=3D XGMAC_L4SPM0; if (inv) value |=3D XGMAC_L4SPIM0; + else + value &=3D ~XGMAC_L4SPIM0; } else { value |=3D XGMAC_L4DPM0; if (inv) value |=3D XGMAC_L4DPIM0; + else + value &=3D ~XGMAC_L4DPIM0; } =20 ret =3D dwxgmac2_filter_write(hw, filter_no, XGMAC_L3L4_CTRL, value); if (ret) return ret; =20 - if (sa) { - value =3D FIELD_PREP(XGMAC_L4SP0, match); + ret =3D dwxgmac2_filter_read(hw, filter_no, XGMAC_L4_ADDR, &value); + if (ret) + return ret; =20 - ret =3D dwxgmac2_filter_write(hw, filter_no, XGMAC_L4_ADDR, value); - if (ret) - return ret; + if (sa) { + value &=3D ~XGMAC_L4SP0; + value |=3D FIELD_PREP(XGMAC_L4SP0, match); } else { - value =3D FIELD_PREP(XGMAC_L4DP0, match); - - ret =3D dwxgmac2_filter_write(hw, filter_no, XGMAC_L4_ADDR, value); - if (ret) - return ret; + value &=3D ~XGMAC_L4DP0; + value |=3D FIELD_PREP(XGMAC_L4DP0, match); } =20 + ret =3D dwxgmac2_filter_write(hw, filter_no, XGMAC_L4_ADDR, value); + if (ret) + return ret; + if (!en) return dwxgmac2_filter_write(hw, filter_no, XGMAC_L3L4_CTRL, 0); =20 --=20 2.43.7 From nobody Mon Jun 8 06:38:59 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013002.outbound.protection.outlook.com [40.107.201.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 436174BC00E; Fri, 5 Jun 2026 09:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780650083; cv=fail; b=ShmG3OUEEfPKM499idHzAKteQM8N75jar/F6ZDkQEOmxo2ckEWb71Ym7jWcoO1Uv6IR4NRLxpu3AJkgpuY9iDmgORmfUL46Wmj78pucqfEZRLw0w6exHoE2KPI9XVMnKCRwlPYQ52PlfhSFhX8+uWYjUFLPXd9T51CgGZj5f6pQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780650083; c=relaxed/simple; bh=aPn/8lSIhemSZzwOo8z8Etet9Med20jwY+CbdBMFOdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=rCd3gsFdtdT8//cf2yUiLGzJsanCWTtRop6Z8O3cLfMF6B4bz/GX/I8LXME4YBqsU76pv4mA9v6c7fBjdsQJmM98jy2iWuLju+TS2zaZk8WUSVTsWHfSzASBIg5C5cTtM4XvXvW9AUNXSK/UpeT+jDnMnsEDUEp5JYTYe4P6H3U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=jpqhNFKs; arc=fail smtp.client-ip=40.107.201.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="jpqhNFKs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d0R7KMoTBrAXKhKkOHVEWw3Oa/x03mW1qbxnLvVVoVx0tnuKmg442u3xLmgoQ2+nABUmC3b1v0pe7QqDA+ggTAx5JOm2Q7RcAq/5QJaPtoqQt4HLxKhBrWJ1LnAk62+xbwfHs/Nv9yITtYx7BYeHIm9RVt9wrtRusmcwhqbIv/SJOrIFWD8kl+ZrtNDypLM1t8nB3vawvDu/47OGgEeyMOd7iSOO7r6IMwdKFhs+YU6WV1xcLLl+QqTz/eS0ZfY/FfqE3RXm2P1vvZF75gmkzcG95W7l6oeXjV/VjTXYB+h5hdH78MG9GvcxT4k+xLYaGAXIiB8lIqWtj6fgkh3Bmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dNSBByl0f5m3bkbjfxqX4mfNAWXpKVD66R9cmM81gMY=; b=tk9B8abogXpbw7tajAIPbAuLn2W6o9XpZ3Ad3o6Qgas6NcXQ8yPVvyYNCYPMDuAUROVfsvbFErnXHcdeZxg3RGoJ+/aOgEobC5FQaXshsgZ6SE9Aa7Rbw+jtFox5GPFInD4MiDGVk7eXqmBvhjutcc1s6c4MkagfZz8SpVbaivPyN+FJFnkCHWHGBmYm6jZbz0vn3uXN/SKw7i8rpUEx/CgVcnINmhc/JxlChlAerS5u1gpFPNyJbNFWYg/Fj1oDWwrs1fsDZ/fekeJ1tWZCdoNRVQCoJOmpuwWiLPftN3sqFsjeEhV3Gdc/LxCrRdHE/9UVv5YsXSNcvG7WgdGeww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dNSBByl0f5m3bkbjfxqX4mfNAWXpKVD66R9cmM81gMY=; b=jpqhNFKsmIRej2o3EFgrpykGOhd9SWUoO0g0Qo71Ugt9dGrIyx6fubGdqsHaO5czk5fBp+evC6uJlBllLJjmStkGlUvh3bW1uLmjGAAcR6gcLqonzr8IirJbQ+/wARYmWPWonJ4EOo4Wecn+56RyzajuujPnMS/x31vIwiWnWzmCNaN8rJuOpjrGyD9YMc5rQwJubdwx266VyNWX+Fr5+d6JYEo9tVZrB5mphRdY4XhTkTmZwX/CgF3xeigF3QBMjmbLJMc90icJYaUdMUpoPCXDQpWyE7XDzlQJIl2EXmgF2HRjHRd8RYAbIm6o4b5Vafwg2lsG5c0J1L9Y7PSrmA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) by DS4PR03MB8472.namprd03.prod.outlook.com (2603:10b6:8:323::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.9; Fri, 5 Jun 2026 09:01:18 +0000 Received: from SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775]) by SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775%6]) with mapi id 15.21.0092.006; Fri, 5 Jun 2026 09:01:18 +0000 From: muhammad.nazim.amirul.nazle.asmade@altera.com To: netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rmk+kernel@armlinux.org.uk, maxime.chevallier@bootlin.com, Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] net: stmmac: fix l3l4 filter rejecting unsupported offload requests Date: Fri, 5 Jun 2026 02:01:13 -0700 Message-ID: <20260605090114.16028-3-muhammad.nazim.amirul.nazle.asmade@altera.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260605090114.16028-1-muhammad.nazim.amirul.nazle.asmade@altera.com> References: <20260605090114.16028-1-muhammad.nazim.amirul.nazle.asmade@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0026.namprd05.prod.outlook.com (2603:10b6:a03:254::31) To SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6964:EE_|DS4PR03MB8472:EE_ X-MS-Office365-Filtering-Correlation-Id: b8dcb526-7ef3-4a37-29c8-08dec2e10116 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|22082099003|18002099003|6133799003|55112099003|11063799006|56012099006|3023799007; X-Microsoft-Antispam-Message-Info: 8YMa+0mXOkU2a27JmmYaoTYJQNiLmhwiIY6w+ZvtHu8clE6wiWn2RyLRK3e7lNLgPvxnYiMMLQn9zpU6HaFb5YY4l2IvUdjlH293hq6+PjgRj4uOqleCUvhnH3yCL6nly44I0ApZGOUbzS16py5O1IhW1Lm2C64s/B/FwbAaZeqo1A84pVba5WaNzsVIPquQqNFgfPMf9U3WfeMIk72lCIDBWEynQM3yuuu5ABIxBMuFzw6czdeKGyqWAYlYSp526hvooGG0XZrBggvZ1VTiwC1S0ujwL9JAQ0jscADlwax8mRzXCgs2lR1uMyANhqbHUE9Q85B+kyadujJlnPdaXEa5JPjZFmT8t54RTqgB4k1RENivZ/NjZ6jFXY5GZbs9r02geekIVpK7ZU8TdwxkSfQp6JgTB9iSpJjLnXD+jhTtbQ4KvI5efN95zGLBhBKlHoNPu/ZDz4tP7u+CuTNrel27g3df4unl0U5RyFAiQC8d0wABFN49vZwXxJa8DUWxrMCf3g3Wr16zjLRN5j25ctu4blEw4CNOfoVM/RAvyWylKfu+1sX531ZS2yMxYqv8N+CmlgteyQCKuwRjIV5ICWzqdhBn11DK2UIyNtej760AHR1RJMjJQ4cfLe26zS+I69fbHPa6Njp8BExVr7nI7D8yP42N540OZO3gk+4DIfbRtZ2LgoImYgIhCLfrs5Tv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6964.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(22082099003)(18002099003)(6133799003)(55112099003)(11063799006)(56012099006)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fpn9rvQT5HRYFzwNlOkvxKEnZXSu7CaVw1cePAXBjnyvF8Ne2T9/3NwsuEPI?= =?us-ascii?Q?tNEhHHBzAZroO4pzQCMLQ7/sM9g3IxcRMswidUuK0gv02deO7ZV8T0lqcaZb?= =?us-ascii?Q?ePVewcaNq9ERV0hlRwRiMkH+ZjrcaOn038vhsFalq4dVZbcpsV2CZVv4/e1A?= =?us-ascii?Q?AR8wvJxYOhA6CoEBgSuXbEx5As259aYRTeYHNsvTABV3tgUY655KeCjnmcpw?= =?us-ascii?Q?PThkVDFrVo8pzGg7602GBnhcpcRzSok9DgOSjrCbqguz4ymb9G2tUKFhdu+I?= =?us-ascii?Q?Z6xA9t4PhOSyaUjEOAHOLzK3jafhp31dJkBYDF/dQbxrObOpsL+QV0nc7sN2?= =?us-ascii?Q?gTPbwtRZikzmn15Bncd9tWwQBgrlR7g/dmiIKthAdoVnrJqAzCambGMmRq97?= =?us-ascii?Q?AwGKHFVfiEJahaoEwknvHlsEKlezVhnsrWQXLFDXvL6uCvP9hhy3/CSOc8kJ?= =?us-ascii?Q?gwQnz5VB8NsJW2BfqwyYj6apmbcWMCmlRLQfT/RIhvYhg5V9VcRJe2NwDgA6?= =?us-ascii?Q?WyDPV390MZX43MPWcn+eUP7U2mXvB3T+lO972qps+nvHn3DA1KouXUqceGzL?= =?us-ascii?Q?uocFyQtuNvFHKvyNL8iq5LVLIsBqnc4dkJijW/W+LTGFBDFQmaeaxY97qaEQ?= =?us-ascii?Q?kNdnxOV3H8A2ucwKFqANIU3zKF5DCJuONbM6yKRzkNLBuRwc6iL4PCpuoGkl?= =?us-ascii?Q?TyAddlmN/SJE3qmh4d6zA/6yu5lpS6icBMT35ZevX1FTH6gllwem4d/EF990?= =?us-ascii?Q?cXQNJ3PChX0zmkQzwOgbITgePmbXH7yfnjUrFU5ohvPH7Oowmfi2RKDykBDz?= =?us-ascii?Q?go6Zr/fbXAxCoZSjg4BuVV1ChJzgV8nyUbWqwwuu4VjTNogYbluzleVDyTWY?= =?us-ascii?Q?pDZaj34jggQlg6omN5sXtkQ18bvfq/SV+jv96XYXW7qrxiM9TL0ijOl1QQ6E?= =?us-ascii?Q?LSwCi2gWnwOLjqqWdlsEMZ9yIuHriM4F7KKrnq74cVeoX4axCzv7n7mfVNMf?= =?us-ascii?Q?drpSK8rGVrZq0j9KOqQouIk4OzAIotNlcZ2MVDfwx9XnvhT1cJpJ0T9SS7H8?= =?us-ascii?Q?vmg5oxdHkf7LUydx+uMvEVc1e9frs0HkgLjNHnaSe1SJfkm6MyvA+CnkKq+F?= =?us-ascii?Q?2/BwrzEmzoI64UYTYxXfwh09O1HjUwzs+/7DZUiZHUZ4iKgIVkOkZvRxqdWr?= =?us-ascii?Q?XYT/cIq2Dmka1zOJDWGwv6ZB45KAAxiFjTleT4vQyTlqM+hVyYLSZcOYX5hD?= =?us-ascii?Q?6rVU6lVeX6XHUyL8B4nnTN9GcyrLv/voZR7ACdK6PUjpv8BjZ1sl1RmCBDeD?= =?us-ascii?Q?EITZY2fXL2ifzasjmaqH4Jz8PEegyVa62m7hTBzNriKfqQyyx27WFx3P04bi?= =?us-ascii?Q?bE1Wc9YL0rtT87v6IsXknn3zKoYmmaSk9OGcgcM8x3kqkaDMFPXZl4+Zqq88?= =?us-ascii?Q?eMqKwYtiTIEdFwtrvvQrIQuSm/Vn7i2IFxrNjD4i1j3KYRv6DI7Tz01nVW3g?= =?us-ascii?Q?fIbs3Azhxsohdp8vOXzLeRMhZgTR3F6wgiiVNmKSx5poD80pNU465D1kpJIK?= =?us-ascii?Q?D8vZzMb7dDj3Qh+0oT/QE63hk5Qd6XEuFPQj0nfyQ4Ox9mGlH0znm5fDF8O1?= =?us-ascii?Q?B+SxzKFku0LsMtwc9JyrPG0LDKfEGRs4j7Gv3mjBfxfUGUES2VxOhMcHDUEU?= =?us-ascii?Q?8/IPViKbmcqG8ubUPQM9Svf1li6D05POA94yet4YjUOwZTbYlulSJ5LPq5Ko?= =?us-ascii?Q?XcQ/7L7R5YypvQ8G17qgMvZW54AKezyYPjoZswRaeehNOVX+otRx29Ym9+x3?= X-MS-Exchange-AntiSpam-MessageData-1: o/ctdFpmyQrXMQ== X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8dcb526-7ef3-4a37-29c8-08dec2e10116 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6964.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 09:01:17.6647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4mF38YkZh7+aqOBiX2S/hPG2eZnGeMiCS5jCoqTVawf2Qc/JuwsoWc3ZlGJ/mtCYYBJgPw9QU18XwpSqw5hM448X1SVPdMgyxOQRbaEGtNSwwshyw/gEl7DgClWMcy1C7Ec5mrrhTb+0CIRp82C/AA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR03MB8472 Content-Type: text/plain; charset="utf-8" From: Nazim Amirul The basic flow parser in tc_add_basic_flow() does not validate match keys before proceeding. Unsupported offload configurations such as partial protocol masks, non-IPv4 network proto, or non-TCP/UDP transport proto are silently accepted instead of returning -EOPNOTSUPP. Add validation to return -EOPNOTSUPP early for: - No network or transport proto present in the key - Partial protocol mask (only full mask supported) - Network proto is not IPv4 - Transport proto is not TCP or UDP Also propagate -EOPNOTSUPP from the basic flow parser in tc_add_flow() to fail early rather than continue with subsequent parsers. Fixes: 425eabddaf0f ("net: stmmac: Implement L3/L4 Filters using TC Flower") Signed-off-by: Rohan G Thomas Signed-off-by: Nazim Amirul --- .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/= ethernet/stmicro/stmmac/stmmac_tc.c index d78652718599..869f84756ca5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -446,6 +446,7 @@ static int tc_parse_flow_actions(struct stmmac_priv *pr= iv, } =20 #define ETHER_TYPE_FULL_MASK cpu_to_be16(~0) +#define IP_PROTO_FULL_MASK 0xFF =20 static int tc_add_basic_flow(struct stmmac_priv *priv, struct flow_cls_offload *cls, @@ -461,6 +462,25 @@ static int tc_add_basic_flow(struct stmmac_priv *priv, =20 flow_rule_match_basic(rule, &match); =20 + /* Both network proto and transport proto not present in the key */ + if (!match.mask || !(match.mask->n_proto || match.mask->ip_proto)) + return -EOPNOTSUPP; + + /* If the proto is present in the key and is not full mask */ + if ((match.mask->n_proto && match.mask->n_proto !=3D ETHER_TYPE_FULL_MASK= ) || + (match.mask->ip_proto && match.mask->ip_proto !=3D IP_PROTO_FULL_MASK= )) + return -EOPNOTSUPP; + + /* Network proto is present in the key and is not IPv4 */ + if (match.mask->n_proto && match.key->n_proto !=3D cpu_to_be16(ETH_P_IP)) + return -EOPNOTSUPP; + + /* Transport proto is present in the key and is not TCP or UDP */ + if (match.mask->ip_proto && + match.key->ip_proto !=3D IPPROTO_TCP && + match.key->ip_proto !=3D IPPROTO_UDP) + return -EOPNOTSUPP; + entry->ip_proto =3D match.key->ip_proto; return 0; } @@ -598,6 +618,12 @@ static int tc_add_flow(struct stmmac_priv *priv, ret =3D tc_flow_parsers[i].fn(priv, cls, entry); if (!ret) entry->in_use =3D true; + else if (ret =3D=3D -EOPNOTSUPP) + /* The basic flow parser will return EOPNOTSUPP, if a + * requested offload not fully supported by the hw. And + * in that case fail early. + */ + break; } =20 if (!entry->in_use) --=20 2.43.7 From nobody Mon Jun 8 06:38:59 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013002.outbound.protection.outlook.com [40.107.201.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D124F4BC02E; Fri, 5 Jun 2026 09:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780650085; cv=fail; b=TU92HiHpJtKYJhl+de1LGKmu+9m+fmpGFyCA1RXXdptyoFxSkKldA3G1dUJvaFV4rABHvgiupLw1fxB0q0EE+vdRnu1y2YA6vUYa77bnAfChBMdIJQufab0GVpR6Rmpk/s5JsXkG38xaz/Jne9tIOAsvk5rtXVt0DK2f/JGLrxI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780650085; c=relaxed/simple; bh=v9dxslsTPqb3WtvX0rHFQRbfj3DDkbQiXwf6feW8Nbw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Iy+W4oroypleyL8u7srffWzhn8MdTKeOsS1IvjVS6UtIM54Z6UFWdZzwns47aL0HQMANeAszonGqToRIgraHGl2pDhPmUeetI5u4EdHWsHuWHeOshDyhXpXnbbJjJ8LNitRJG/zPisGS1f6R+MJYEeBVxLBAtZsZw023wXA6l8Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=wibbTZjh; arc=fail smtp.client-ip=40.107.201.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="wibbTZjh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kh1VunW0oL7g0XPr1KSn99nGDpav3XI3yy/vit1COvJu5I7sErH2tJAONdkdNTET97MCQdAB1i12edC0WG3JXHSvoYEOKlJM9gjc9XmNzegGL1fj2TdSlY/yHOlUQB17pXPK93lfU66/SB3HyNat82ufxUJJXGtNZL0pn31CEBTcnyNOLaaP7JXoEbjbt9NRkSKsHWQGVxRiE6pFcTVjtMdbn/ch6MzhRMd/BUO1eQredjziJ4K+8bFYSfMpZUbvDdeIWwW5AmKulXZXZpH8Lam8k5OiXXTG4FBOvSH1YJDTvWnkCRR74CUryuo4RfbKx7YZDII0DhJf6xLwvDdfPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=flVCSC3XhnE/xZQW47yl0FUFr3syt3vux5Zpr+2qRc8=; b=L2ZBKHB5CDgVm5hnXjyZs0AK0eZBCjGKnqrUnznAakdHnyvK3K7lvflyNwJmXJX9RvIqWWL2DHHh9XwOs/uXlXGgBFqe6VTwYigaGGSx4eFy0Jff5AvIJsYvecYdTxZgg3fZEp0UW4ut5HGDzSD2GbGI6QMYJv7nDyhYuq89wuPB3VWup/UuJ8oSE1PK0RsA0g3gmftc/9yVDrjQtzECdFqK72an0vzel2jctmP6Wulk1k3YOuZcvKIASKUxo2fnGwEz3lnM/xZOyhjktAFDsVpgk8wGrC6w0VVaiQZXQEhickTDoalJSS1wCuTiajWVpibocEAxy9lTHy3WYFTQDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=flVCSC3XhnE/xZQW47yl0FUFr3syt3vux5Zpr+2qRc8=; b=wibbTZjh7OmeSFcmPC3H5mOmSh2Qcay6vMOtTM7Go+3bNo3YphzVMsSTwQ8Ho1tV17nF4AZRvPOJIXzdCUHEGzVyyHB8zsN+C9lvN9C/8mUcQZgIdhDpTQbOI752ir+1wse0BJr+a/mZP+tTagBnIBk5J0DkEhJ+yme1b999M/6ezV4mmguG/MoyE2+SqRY9lLaPBTyU9v8HdE1zCqiwGSgdU8lEUCCpK2idVp6nM9a8+e+QgXOeKUFemegmu9SzcZOSCph6z+i6kYWwRWMWXruISI7qbeXt2yGqRG0YtD/kr6mpypQxBfF30qSp3Ve4LBEqO/40+fWw5DBgy9DBqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) by DS4PR03MB8472.namprd03.prod.outlook.com (2603:10b6:8:323::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.9; Fri, 5 Jun 2026 09:01:18 +0000 Received: from SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775]) by SJ0PR03MB6964.namprd03.prod.outlook.com ([fe80::b965:bfa8:58fb:e775%6]) with mapi id 15.21.0092.006; Fri, 5 Jun 2026 09:01:18 +0000 From: muhammad.nazim.amirul.nazle.asmade@altera.com To: netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rmk+kernel@armlinux.org.uk, maxime.chevallier@bootlin.com, Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] net: stmmac: reset residual action in L3L4 filters on delete Date: Fri, 5 Jun 2026 02:01:14 -0700 Message-ID: <20260605090114.16028-4-muhammad.nazim.amirul.nazle.asmade@altera.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260605090114.16028-1-muhammad.nazim.amirul.nazle.asmade@altera.com> References: <20260605090114.16028-1-muhammad.nazim.amirul.nazle.asmade@altera.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0026.namprd05.prod.outlook.com (2603:10b6:a03:254::31) To SJ0PR03MB6964.namprd03.prod.outlook.com (2603:10b6:a03:432::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB6964:EE_|DS4PR03MB8472:EE_ X-MS-Office365-Filtering-Correlation-Id: 41c5b3c8-c71f-4f98-e01e-08dec2e10184 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|22082099003|18002099003|6133799003|55112099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: 2+0T6rctBPibPJK1p5Yv8+coQaOFVnFmXqEHMCCXE/LQlf5F2UbO0RPwBVSNnzHg1AF9xU9zyGeOs4qms+iQh/AY7A11qMqPU9b1bMbC16T2aA+OTC7N2nsqGizl4/zCadmo3qVDI0ZQBIw2IJR8Ibig/AiQ0jSqyh0EwnNIaeX2XMiOoGs1Gd5AmrO+UVcwHBg6GKGfmby05nT6stMIvnTJiDFVBha9aovP05p5EgZN8UAWrvy81AkVKSNY25kZ8A9sTQmfGe69/4KnOwFuSwuuhk+Nd7U5wU3uGfkCgljOM7XpoK4Trao3RxuVpY3N0np6MLhBhQXgyIHk39eP7OlH0xVLUZYY9NpLMedu0EwHkP/snbWadCy9s8k1Z536ZAaRKCqfyja+yquY0pqEn6NaE0GZzNkBD+XlrpGbgMJejU8xK5FmytgTKJc+2qxd3rVG/C4mdcoKLHSYTtrkawZpXho06loCAoZ05j85DDY5m+ATQjw+os9nTz9tjoLLnJ/rlrZZGAmojrXPltVJIBIc/8CIpnr5893E5QusHHj/FCuMMpR2KcduQoSmslkZerxiuNG9zfdycDmMGXcL5dkm5f9UlIa5wt4Hl30C05Z9XLWks1hoTHjWUYDw9aH3tqRLh2Yg3bRl1zGNtvuaL8fL3ayCUXKUXem4DT33J6QSeRwNcWqw0aXezgUQg+39 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB6964.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(22082099003)(18002099003)(6133799003)(55112099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YBH1bw2js+oPKpmKXI3IiU3ld5KpM4Z3wji/ykRqZAX3mHdtD6sL+XW6Owaq?= =?us-ascii?Q?9PaLNNgNxpucl4jU4tGwKUCNgSDu3j3zI5YAtzEaNx5TkT62gjMktWHXv9qQ?= =?us-ascii?Q?czbKLV2rshYHDX28tZD+4R/igh1+/ZhVnlhA17f3yoOwood5yxg6RsC41tbU?= =?us-ascii?Q?v0X2b7isoCg34ehJiBAq9CuMWMNSC6OkKrB9Lrfz2KIR49RKqNQIm2Q03uAV?= =?us-ascii?Q?qEBW2y8S9EZP0B8sIaPq7LXAjSpHgCw75XndsTrWFTyAnNpfVCP//14W2IGb?= =?us-ascii?Q?pdL2X5D6g/n5aiOyfPL/9+Eqrey8foZrbycnaUCwQ3gd2a+n1pkIC92Mx0o8?= =?us-ascii?Q?Lo3ubT1Qe/bdBSaXT7dp2Tpip0UG1v0cTexKKKAQakNER1mQnjfZCdtrtRUG?= =?us-ascii?Q?za5SzJ61w6OJ1NMdpLIc0NPUTbso3kR3TZ6m2euy+ef0g1Bd2Zg4w09NYlcg?= =?us-ascii?Q?ZjGPWc0ehM+xdn6mHBuW5qy4zTc2Twyzbg0kckwlNzmyn+L/YIK3M3/3Yj6h?= =?us-ascii?Q?KunHY/F8uav6oG8hjUYeIOcMFmBpwVzjT6FXzjX8Swl5FwxRX7JX+e3TRbRB?= =?us-ascii?Q?P58GGd1HdArpzr7/WE7IBqHB1+tkBf5ZgSmwfKYkT2BxQyp7ifdwkvkuAlYT?= =?us-ascii?Q?Y4p/OYKNY475OE5BR1ZS6cHUHlkuukC/XqxIlujN7J4dU59iW/eOvWfD9pCN?= =?us-ascii?Q?Lm7U7154m/AWEuAXkY6gX2EHcrM1j+r//KK6EPUFjWeVpycYDsNEyXXDda3C?= =?us-ascii?Q?YX9Xt2fyl1G24uWlcWdSt0Z2Ud/bQQY9JI++FEgDq6zWL85I+V9LBE85k7PA?= =?us-ascii?Q?KrUkdN495kZ79cMuFNF+FMsxv5IWaVRqccRGV/7NzLlSVyb6l6Rb+lN4+bqL?= =?us-ascii?Q?/7qYbMm6FkoPmtl2DE5vnkVaIBtUiFhEsVZdNh+sbIeUlBRG/T2WtKElE5eU?= =?us-ascii?Q?QAnwRwkkG7JczxUpKSH08y7RMzdVU9xHjbnawZOd6npIoIF1ZgQPiv4W7rH4?= =?us-ascii?Q?YwIoznK2ZNxACsCk3gUeLU8+L6DSzvRiPvg5T/Lvd1LW4+2kP6JiZKnh2UTe?= =?us-ascii?Q?vmGq5kNTwxHkNDRRhqGRTmCsEIDRS+261fGyxixGv9nZo2cfBQXvOMLQPVpm?= =?us-ascii?Q?m3eA42eGTuZ/54rdIIAOMTnag8JfZ6AZ0Fu3J6Pl4DiB5JMq3HxgyiXognmQ?= =?us-ascii?Q?fVvzr1oHXK9aY/vpGIfRk8sWMYlCGDvqZqKSahk80vZMELjbCsI2cx/Nk6Sl?= =?us-ascii?Q?Q9ZKyMMC7QZvHHwOKjuHvpmpYQlJ3jRzlS/POgiQWtJ1/1FgC1qc0iGluVLZ?= =?us-ascii?Q?l6gv3gmSfPVDoGVapr3MsJ5b7KB4U8O4LvDPbQwcA69DB3WrBlwo11W9aUlh?= =?us-ascii?Q?rNBQNMnvK6FOV8xNZDr8j3kH8TuO0lCBLsKha9rGAotje7dKXOq3PPIiWP/K?= =?us-ascii?Q?CzgCqLNzpKPBhPpiGWH8envKbD5GL+X1qythxqwpmk/sgcAI6yPJAVfuNbWn?= =?us-ascii?Q?odLItNnp8fH11BXTcqsRfPDNuIFCQp2DNgHNRROb/ssYGNZLNDgu58Wc2eSk?= =?us-ascii?Q?MgUQxnKNGnAQXj2AnFrXDRisfWzooeUC+mLujqLrJP7xFOPCqHNxxmsJjyF+?= =?us-ascii?Q?nH4MEl9q/MDGOV955a/9ngMWOZqOCLnja/5ee1CYx8on124Ms5/vEpmVKWTq?= =?us-ascii?Q?3u/PZngrqaR1cgtxQ2allbWI2OyLnU3XJcDYrLpPpf7L1x7sY5v2619iO51B?= =?us-ascii?Q?fkXPbJ8gVf4q7hN4ltuabcuxTdqaQVIxRpesg303eaz9mVOaa2a6ikeejs+P?= X-MS-Exchange-AntiSpam-MessageData-1: 7LzJQoe2I9hPPg== X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41c5b3c8-c71f-4f98-e01e-08dec2e10184 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6964.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 09:01:18.4742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yXelpaCIzAF7SubCjtyqMeS7AMnqo7fOyYiDeCuc5KFUEjLhR6D8Fmpd6OmlLyMa3+2k+bAUdy5Ra5Vx8MOLLDPB6skep+tV3CKTbs/nwwGwVCDIVndAHeHGT2FWITmPaF8cqjLRlF99V7oaHBzVsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR03MB8472 Content-Type: text/plain; charset="utf-8" From: Nazim Amirul When deleting an L3/L4 flower filter entry, the action field is not reset. If a filter was previously configured with a drop action, that action may persist and affect subsequent filter configurations unintentionally. Clear the action field when the filter entry is deleted. Fixes: 425eabddaf0f ("net: stmmac: Implement L3/L4 Filters using TC Flower") Signed-off-by: Rohan G Thomas Signed-off-by: Nazim Amirul --- drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/= ethernet/stmicro/stmmac/stmmac_tc.c index 869f84756ca5..4f9758eeb86f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -653,6 +653,7 @@ static int tc_del_flow(struct stmmac_priv *priv, entry->in_use =3D false; entry->cookie =3D 0; entry->is_l4 =3D false; + entry->action =3D 0; return ret; } =20 --=20 2.43.7