From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 133564A3418; Fri, 5 Jun 2026 08:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649351; cv=fail; b=XjlKUCbM+3R7fNQGaw3D2OTfWsD5ZVmls4rql1sBMXMDnIENim9m53LWf1Fr5OVI09Ilj6ZRg99VB83MPa7xlL8evMDhpMYCuBv8X99QecwspK9L3vUWfXOLSxIaD3jS6UBn6TdEkyZcPZVfBWstQUIEgZomF+WrEaDe2Z2ePaA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649351; c=relaxed/simple; bh=WeYloHecK86rS7EgekxtTbk4BsrNpgrpXk6WJdLYcvU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i5TF0TrzxsL5zYdLCgRu6GYoJgqa3BMi+qj2oezlRiSU8T84iBPZG0XGA0R1tu3EYV3Edyg9HzdgYhd402p00IyD3znHAOEbIC+iFMe6sMJkLjWSzdm/Hxr342J++X8IKr2RryUKFMqNL5HDA1XpISW2jyCn1aoQXHa18AH+wnU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=krG2CL7m; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=lYqBPWoS; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="krG2CL7m"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="lYqBPWoS" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65558seC900358; Fri, 5 Jun 2026 03:48:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=SoteH7zwztxoQCOcXbQ9mX/taF8yCJWf5OoC5nrOSzE=; b= krG2CL7mClPiu0mdL0mp0PhMyXVHRgzRfHEvqVcQHFRWTwjfmnS6sPye4sfc7Pcs whVAqQKPfD6x1FqjNFFuaIqiWyYwZIZmN31mI6tqcoYFj+/UbWK9YnLPEQb9RS+3 LindFaIg1yH3UHDVfVM5FLye1Wm2uPV0CQKWTfpTnsBXJzeFHubNZz6xsO31V0ct nJnoHd+Z9W4wrSUZG2hItIoFwiN70Yjtg931F2CHHYJFhfACLB2fuaHA+8zSdEKa 7Vx/QRk7I9E81TjrIeS29lajOlRlTdu0mzrSYK9lTE7VtNzhE6/44CpveYVTayOb lrPnHRNJ/mOziai0ViR3UA== Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11020072.outbound.protection.outlook.com [52.101.56.72]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa192j6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:21 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nuUrXC8vwHsO7zkEGpck8T6nUXmNLXWMnD8lWtAp0NFyTvrakBrAFNuBdDmMDuEC1jIEJcbinlJwCNBP2jdEV2dov97FyLH1WmzSBQoGSPt6a9fXNILFeaWVpo95sVDKB0EQST0/7UZeSHQQbUdEfYhz17J/Qr0+dnK++YbgIhKYHBjDWFqElzTnPRjGNAwGULa8eab1p39sQ4i9sxDoLJgidqGCDjKeJAS8CACH2q7WZB5ApH4HNt29Z8Zv3+VeUkk93M6B5XpFmoAjHu0uX3PB9ni6Dgmao9CVO9lJ14G3kK32fieYuYKlQw+yp/ZZs/RxoS6NhvRroo7Xl+cwGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SoteH7zwztxoQCOcXbQ9mX/taF8yCJWf5OoC5nrOSzE=; b=kxmZ3qqDyrErnnPq0ymo7KiG3cjWVq3Z5NfQr57osSejyANjmLUu56qrbix6nAkEuE7pzmW2uzDi94nfTTXYRlZeIv1IpiSKQgyQQ3ueZg1LzLR6ZdpNVv8GXXIpDWRzn1E4oAHyrur6GCihiLGslCeZixGpIafOUoT3QA0d4mgFAvXtYDQmce5s2FknHUezYJvzsUIGdayhGwK/w0+PWldVDmCF4whgvnQwQwLlInX9KyaI0cfZnKH+czUiV87vdTByewzLc9a4pgDXyTxPbFZl5lehYnHGnfQXGdlYsr9LJbwpzWPY8ZmfLUOpWso+fyL/mwOmdAO+PFO+x+9GIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SoteH7zwztxoQCOcXbQ9mX/taF8yCJWf5OoC5nrOSzE=; b=lYqBPWoSllLkwAIdZ/wPoXrqlexWu7yisaVfm8j1zHS2plcYlPQnew9wD0vLYdiLtPkN8zfX28mw3RDPvN66xVUqw8tdnzlXxwr2OsBSiM3ps/omsE31lETEyG/YTbXrYP99eGYsAiq7ZqOqTrO6PdQij7BNtRNkFZcK62JO6+A= Received: from BY3PR05CA0047.namprd05.prod.outlook.com (2603:10b6:a03:39b::22) by PH7PR19MB6807.namprd19.prod.outlook.com (2603:10b6:510:1b9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.9; Fri, 5 Jun 2026 08:48:16 +0000 Received: from SJ1PEPF00002321.namprd03.prod.outlook.com (2603:10b6:a03:39b:cafe::82) by BY3PR05CA0047.outlook.office365.com (2603:10b6:a03:39b::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.8 via Frontend Transport; Fri, 5 Jun 2026 08:48:16 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ1PEPF00002321.mail.protection.outlook.com (10.167.242.91) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:15 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 3247B40654F; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 027AC82025A; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 01/10] soundwire: Always wait for initialisation of unattached devices Date: Fri, 5 Jun 2026 09:48:01 +0100 Message-ID: <20260605084810.1575539-2-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002321:EE_|PH7PR19MB6807:EE_ X-MS-Office365-Filtering-Correlation-Id: fdd8dd01-2188-44ef-e3db-08dec2df2f30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|61400799027|7416014|376014|82310400026|11063799006|56012099006|3023799007|6133799003|16102099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: IC7kS0P1tDgFHUDT1ZQW9IW+XpZVIxfsMYAbM/qj2sVE3Gc/CwVWZW/QA460gBug98vLHxj2CuY/2lZwuMKVGaTPXUZOkudhg/k6/7XZNHRS5UXuQdiGQH6e/BDrotR7HGZtZIYQ3WbhNn/kNLQH1rtHnG/k2FakXP3sGIzRKYUeoiGRF9piOCvcW2aaKVTy2KVgCAQ7AOJc6O31ALD4D1RIWJJdEApuP9YrlhS+L63RZP9SeolkFGBhU6yDNLO+cefIQcHPZLYUYyZcfn3elybPm1mCHcYSakGKwYzacCrDYGtyFzBM3L+fANCJgGeQga9x04lTLLx28LURMna4PVevqhe7K0kdJT38/xwiZMnCJx8o68M9hL4HtW/WHHA64BfELC8rcH1RW6lPMmBgM4VumgFGA1n0Dgk4Wie3pAJoUM/GLJaL+vJc8KVVXI8zNXxbC5JAAJtun0dW6zBxjfrsF6Hz+TP7zLqU/kZsPwg0UxEneEpAqsVtX7XwzYyrrqMj3ZOjveoIxdaMIL+6/AYsXXVBb1GfFcBK85nrMTl0TQstIsNS0fYSPytG2/jnq+zvxB3hO8mbwFp6+XS5MXsynIPQcyxO7vTMAeMda6/j9nvuqXfFywrUw8Zz1wu0kisviaObpuwUNoOpMt/xBXFVZKUYhqlcN9texiTr6JzkYh5qIOBRuFivzQTWTGdcx0vTCfgn/qc6/l+bh3zm6gHojtbcGzQWiRkHJqHBxL4= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(61400799027)(7416014)(376014)(82310400026)(11063799006)(56012099006)(3023799007)(6133799003)(16102099003)(18002099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gxhcOKKekKWyVI5mPnsGEyl+XPpGoawFv4n1F4lt1gMWFyScgFbDjoiDrz1dAl8PuIht8IhVMHXUOwfU2RO8Y8+bBtwP1Z4tlpLTc6VW/aJIJVGMGnD3uNp5FGNNahRDoFWVh/bLJJ7prhvRivFQZU88M33p9HbKtQ++K8H1tuV28RLEDQwzB0jELHUfCNp72nm7tchmwygzNrCADrWy8BSz9pAPwI/QwUT7G6ZloC/ffnd2fawLztEGCPlzm/DhrjJ4KRH2Q9eeUc4vzzTQXwVmCD1KM3oCslujvjXPTwKEByYvm5qKxdhgBYYnadnE7LDHHEf8PgwwS16TaTqJbCcBXTgdTG+2HYXReaPhNzVUfija68obm9EJ49FoB/G54rEJH48fTyInmXOufbKftpv2WEFrNFiNGWsC6bMaYDLY0ymQcNxHGYhm7k6IL1XP X-Exchange-RoutingPolicyChecked: OpM+4ib08dSXikkA4tFKA3rAMUcAGFYMuJFUtSnvocLWi2pB3EflNHg7nhPbfxwzjue9+y/ekL5O3o2F53F+dBA8iV36+0vAaB4rP67UdoWoxjK6oqFkFn+rIZxQnrGPMLX0p3xD/YKRk8APa42SUbk+b3Eaxv2/XZlFFcHNMl1UMv5dpuYz1jctNGkt3MV4UzBmN01Cv6z0S6bBGZsULfBVpzvHuZriE6YOTGTOq2DQo44wzho339mKKfS6QNoVBCRkOMGt7Gb7iZdji7cLvzYZiV2OJT0Secqy1pEc+ds0bCAiQLLZg7sW6WGtDMnzKXRRTsY8pswDr+N4tH6SJA== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:15.5195 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fdd8dd01-2188-44ef-e3db-08dec2df2f30 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SJ1PEPF00002321.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR19MB6807 X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a228d55 cx=c_pps a=EuzLu2ZwJ/NCzAOim5xawA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=VwQbUJbxAAAA:8 a=w1d2syhTAAAA:8 a=CWTouP-59cMm0TkFMMwA:9 X-Proofpoint-GUID: 8rrwUUK7ZmQ8hzDeizG1YgaNxcteZYep X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfX/OJ12W5jFogN QnaLmmWDk0RSM+WJiqY4m7Yx/qc5wam+vsRI7PAoVk/j3hZfbnFmFOS6ex1sDJDqlszvk6N1CNT Zpza9tiyZCGtNs5GNPcXOVaDY0ZOrs0Ru1r+Q4bHpnBSlB6UQHj97pbnbhjxaIhJQrvX1uoZ7jf IbVsmyNQtzPOd+NHguqjyKdrHsu8loOFfUAdZ7ebu5t/mQiVqcf0Lo4ErArTWcXbYu9ocrCUJKx ASTZV3GrvO3uvJi9JQvEKhYFwmYuXSUELtFVsX2EIr0SB2jI9LzaBYai2lYLE235UCOdN9/+5YG oGyyfXe6iQnWREaIOByThx1LacyX86QJY71VyWIz/3w+yFDEw9WMDV6jaSJ47VTHQzRIvAG/9R1 sgzf5ecyy1/zo7Xo9KCpg3TlTLY8ZnsG8Z7GZxeBpKM9PG07K657NkKC957s9sK1weTTLslf9B2 SwxI2xK+HdFs3aqc9dQ== X-Proofpoint-ORIG-GUID: 8rrwUUK7ZmQ8hzDeizG1YgaNxcteZYep X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Currently in sdw_slave_wait_for_init() the waiting can be skipped if unattach_request is not set. Doing so was added in [1] likely because the core used to do a complete() on the completion so waiting in the case an unattach hadn't actually happened would block for the full timeout. However patch [2] updated the core to use complete_all() which means that the wait_for_completion() will now simply return if the device is already attached skipping the completion doesn't add much. Additionally, unatttach_request is only set if the host initiates a bus reset. However, the host doing a bus reset is not the only reason a device may be unattached from the bus. Other options could include the driver probing before the device enumerates, a sync-loss, or the device itself powering down. Removing the skip using unattached_request, doesn't cost much in terms of efficiency and allows the sdw_slave_wiat_for_init() helper to be used outside of runtime resume. [1] b2bd75f806c4 ("soundwire: sdw_slave: track unattach_request to handle a= ll init sequences") [2] c40d6b3249b1 ("soundwire: fix enumeration completion") Acked-by: Vinod Koul Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- No change since v1. drivers/soundwire/bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index ea3a24f805c00..b7bdf19ebb42e 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1386,9 +1386,6 @@ int sdw_slave_wait_for_init(struct sdw_slave *slave, = int timeout_ms) { unsigned long time; =20 - if (!slave->unattach_request) - return 0; - time =3D wait_for_completion_timeout(&slave->initialization_complete, msecs_to_jiffies(timeout_ms)); if (!time) { --=20 2.47.3 From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3669E3CD8CA; Fri, 5 Jun 2026 08:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649339; cv=fail; b=cBlsauTux899Zoie9MDkvVCrpHhs7M6Eu5IKx5obTZNhhwawMWMKBkDL4ExPY9fCr5/Ut6oQ9i1ToGwpEpUQ41J6ii7UHELz59UXhLQZCKStfEUNibfnyvrsC1Qo4TcIVFw+g/snpJyDHYPfhSrdMAmUI2lz0YwabKwnJwV5Xqw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649339; c=relaxed/simple; bh=m+pVVozAyaw13VD+66YARJZRh/MDkaeoff4lQGBflG4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WznnBy/kMB2+hBX6QVzpQqXfkPAUpCNhf1SZ8xUPWqCGxA9E4MQ2vmBdfrnR7CV4OLb0QqCs34I62StIVLrr37QvfJ9jZzSC8b/tZOOYp/3jHmmKpP3wIUQ83hM9W2cTXfwzXH950pugbwFe38R6cQ/NHMcssCrZzLNj2IdNjD4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=UCvELVHX; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=Cw5/xlGF; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="UCvELVHX"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="Cw5/xlGF" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6550wlZg2165677; Fri, 5 Jun 2026 03:48:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=WvZ0zXUwPmlzIpwnHxGNEmeY3cMFcMlpqfWb/SuPqYA=; b= UCvELVHXlxYmP1SUvM9FbtvbWHz30lxVnPQdTOrc9uwo07ePTQ30XZ0x+paFIlcN i1A1/jafFa3SgR85bRSYQOMV6xMLBXcMi92RXKhv8idViVn6tfwOh3bArGFyyLDP OepY3fZtZ4isCYUikHjHEFIPx8HM8KFM7rbH8dUTENVCDETyE37pVUguX9UkNu1b 7v7BIXps9iFtoIlT61IAciDZ0UzrEilOBHcLPpeomPNAKMXZFrfc5uLt0jhCiSHo KJzKZsXRxst5T8kFvCbo94bq5iuHWZY08IutZP0JTDI7QUMbVIPHHZ60JOj1HWoR 8Fkz4wxCZVs/h4ArfAQLUA== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021104.outbound.protection.outlook.com [52.101.52.104]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4ejrbram9h-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:19 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oB6Cx6RJljT7eHUIlYTCWwoKSYEUf6QHTJ2zaq5QaqeHJWSMwPPs4gRnJqPgpOO9DoHRPHu8Sx2FM09BqUWk6V3cDV2/bFbUAktemmRTsVjjQoevOgZeSNgtGqnpxUDXIfMNkY9f96mDBDBjB4W61JuNI4Eq4rlY5u5Xa7WKPZEHP+wq98C0RJuJARSd8VWnW5hKjy4HHPQF0baH+ILUr9maGlLTA9hQJgU62t6wXrUEsqH71R6UA+HEAbXl9A3RN/IDXLU5d5FzvsSwm3AlcDATLjeJhwfcyFIjrhBthMa5Zr6aY1StfDqXJY3Nx0HdNZgisROOH47jB+7AHsv1PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WvZ0zXUwPmlzIpwnHxGNEmeY3cMFcMlpqfWb/SuPqYA=; b=hlYYXcWqFcVeR6c3rd6z+/Hk3jfDCMZAjhGvgkkzQlyM+IjgmNMPCu5xqxgQBciVUyOOg04xRXAhlBzoOBoSrwufCPyc3yjOR6SAWZmSiPUwpgWFBxOZF0kghatyCk+iqv6/wP8dvDd6p1NNkLH1qsEORhlyIPBkzX7KQm/E5uVohuz0+Gezm/KIUFO4G3jzgrFHuqKgQeiN0813Y58y3gRONj1VOurpNITQjZuLFvNUWgozFj5/yz8i0bnGBb9Yf25vdjkhnhjMdIiVHoQRr/Dhbhuppcki0IlLroCIB6VK6qGQ/wfVcYZAIWUmKUQ/++wMCYf3vakZtE1ne6TU2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WvZ0zXUwPmlzIpwnHxGNEmeY3cMFcMlpqfWb/SuPqYA=; b=Cw5/xlGFl5eVv5Dk5f7ok+NY9FkTrjRjfKszT95dNa3V1G+AAHZcUlguvMHoJU7XnoiHSSY37PnAvJhEg257wXgG4r1XpRNB+vMOVhhPfns5an2ikjJxwBc6nSf0xv1vPTpbrCnHyIeLapSM9btZHBDG88bGZ6paBzuUs0l3XuU= Received: from SJ0PR13CA0040.namprd13.prod.outlook.com (2603:10b6:a03:2c2::15) by DS3PR19MB9246.namprd19.prod.outlook.com (2603:10b6:8:2de::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.8; Fri, 5 Jun 2026 08:48:16 +0000 Received: from SJ1PEPF00002322.namprd03.prod.outlook.com (2603:10b6:a03:2c2:cafe::8e) by SJ0PR13CA0040.outlook.office365.com (2603:10b6:a03:2c2::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.9 via Frontend Transport; Fri, 5 Jun 2026 08:48:16 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ1PEPF00002322.mail.protection.outlook.com (10.167.242.84) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:15 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 36088406555; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 07C6F82026C; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 02/10] ASoC: wsa881x: Use new SoundWire enumeration helper Date: Fri, 5 Jun 2026 09:48:02 +0100 Message-ID: <20260605084810.1575539-3-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002322:EE_|DS3PR19MB9246:EE_ X-MS-Office365-Filtering-Correlation-Id: 06077ca7-7426-4066-1184-08dec2df2f37 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|376014|7416014|82310400026|36860700016|16102099003|22082099003|18002099003|6133799003|56012099006|11063799006|3023799007; X-Microsoft-Antispam-Message-Info: shIhWsLro33qhq1b1cz7b3yxi/EXZhYgJHfGbEFJEGA+WoOaEufau4EwhBJ2uzRX0OeSUcDYlpJXBSceG5UtAQwn1Fgk7nxJHEgroMDKPDZU7MIt6WCCc4O2tWsO8hFwT1/Hsuv2zmHLx/miP7dSscq1N8ZNOH0vqyGf9TOS5QeOTsoqhc9z2TqQA0+GWZKQ4aFa5RN3/uXeQRws67S349iJj6YwH1tfEhCb2S1ZK4ssS/QbO9BRnnjy13nz1yliDnRf6YY5jFGsWUpxjimn1lXLGR8FfKXT8SuywiqrxfhoFV6axMrpd2wG5jl0/wTj8XdXDqcckiZTu5ktMkyAClNMePvYXKGHHTDxMAL9iX6cqg82jlCq/2CGc87AMtHaeavkjgs2AFJnhewj5dVf7R6KX+kgEM8DVFkjD/a0IbTAAE5N0/oPmuZv55IsQ58teqsHANea8++syawpRjO9TXZrQ8YcGlw95THHdcf1TPMziIY1UNSLo5kFGtli0CBFBpXEvvcQYm5d5CNtlqdmv6NCqbukog1hm/MIgH6xBF2wUa6obR27XpSUGPMHwfurkduGoE8tG93KZsLG3XI/WVRIYY4Be1GWAG6WqB0FmOT2etbMKJthUjc1rzswWrDfIhynXAq06urRZ7XKvVwmsuThFCrIaaJ51h6pqcibz6rrCyRLdGlwnLZzmbIv0BK0ig1VkCARmjZN+UeSu9dBp1CwNnoE+8J9P8y2YdA6QaU= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(376014)(7416014)(82310400026)(36860700016)(16102099003)(22082099003)(18002099003)(6133799003)(56012099006)(11063799006)(3023799007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: V5ciNWs9uFvzLDrzMe1zYTFaYa8N4rvzfSfY5cpJFZFNDUnPPGOgE+B7lgfGh7ty5p+b8X2DD2XVTY/qsrSMrwgu0R3ByNzJ8u11HK8tFbti3YcZpPYVzOQoNEiskeFm1BGN5rKkoZKeuE6ORpcvZEE7MREErqhPERFkkEbgJYhI3/GjToZjv55XdO1zdvQPeZQd0qfZeVxhps/JLzwUF20vc5exLueUKj2ehHYYuoAnC2NOymz+qTrM/KPinpny9ZA+9J7wZWvUg9Ps2beWFcg+Ke5NqLdFpY0ALxiSHV7MTH9V1ll3T02gWh14goxXe2AQoVWKxrWk6rwB+yUHb1ujxGzLuuq0YO4XapfWEwQ8CwPDiwADrYcbOGxRtbA80pSXsX9wkND+ej9l+KEr5D9XlTC4bb4CoD6g/uaMqla8fJ2sBgs7EzjGM3cufpR+ X-Exchange-RoutingPolicyChecked: YPHef2egwlN9txXmQWTMl6o5UEvCoB5L7WuAidQx1+pvUTqIpyuNEmBkG9bp4t93TA0RdhzH91acREjr50o1r4gJj9eFwX5aDHs9uMPOpWVOawPAZ3Zvi61BJbu6Ovvx0YNq4At52laVZKjcdwFJJ1vXNE0NIeYPsqSxZYLKwNd1cM/Ofw+ysLUwhxxt5ajJPx5wWFx15pC+1UndCH2zwfX3qqrK2rV9/snBE7+GvNj0RQqLKD70vo6ZGoGrfYAQvAbmky9FZ7g9XB4QMsVQmAgRydC4rJi4AU+XZ8pier5WA4cGpj9wOBfOzlduxp/PPuAKSgC8mxFICL1bVMqMaw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:15.5512 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06077ca7-7426-4066-1184-08dec2df2f37 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SJ1PEPF00002322.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS3PR19MB9246 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfX4Sgrkr2gvW9n zJtFISXZ5JhLdremXWm8JNdFuooGYcWHLwciV5Pjp1SFQA+5fhJ70CoEfhE1rw/hXOs4Bvf6tXB wV6GwvPYZ9uJsVQ9cuf03+LVOa536rNpwyQlJyScWT2JEZXAYJ1QjDJ5iyAmcj6Df3MMHXssttF 46DkSfkMU2QZgXeXQnrEl6BWisV03wc+9mZS6lcMJCV3MK3sqN7wVpm53IsXreXJmB0TwyXNeHk bCJDsqJuYtY6BNg9Bk14LHjUXjNkScrkrzTmElS2cFJXwuX6Ylzh3ZINBPlJJRTkHHkp6f+YDKP GayA3qa42JqFABVBmLq220+ta6JpUMhGmVUy9bZSKjJcjkG3VNdlIV3FuCkfdoVlfvqns5M3E8j 8ho/+FfRcHyPBMeUHrcufIfRGUxPeeDJVI+Mc6YaGTYRK4m42XxCGs/vTU77VAoaCX3hQ0py0/m qtKPUc7enx/k8oyhJWw== X-Authority-Analysis: v=2.4 cv=TZimcxQh c=1 sm=1 tr=0 ts=6a228d53 cx=c_pps a=l/exgBlJIAx+5Sipbyuv7Q==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=BxSnUCk73ilfYBohU2oA:9 X-Proofpoint-GUID: rigIEMM5oLqM00-ji-Ujlj7X0X64TChU X-Proofpoint-ORIG-GUID: rigIEMM5oLqM00-ji-Ujlj7X0X64TChU X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it can be used for code that also doesn't check this flag. Update the driver to use the new core helper. Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- No change since v1. sound/soc/codecs/wsa881x.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index d15fda648dada..5174614c3e837 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -1167,16 +1167,14 @@ static int wsa881x_runtime_resume(struct device *de= v) struct sdw_slave *slave =3D dev_to_sdw_dev(dev); struct regmap *regmap =3D dev_get_regmap(dev, NULL); struct wsa881x_priv *wsa881x =3D dev_get_drvdata(dev); - unsigned long time; + int ret; =20 gpiod_direction_output(wsa881x->sd_n, 0); =20 - time =3D wait_for_completion_timeout(&slave->initialization_complete, - msecs_to_jiffies(WSA881X_PROBE_TIMEOUT)); - if (!time) { - dev_err(dev, "Initialization not complete, timed out\n"); + ret =3D sdw_slave_wait_for_init(slave, WSA881X_PROBE_TIMEOUT); + if (ret) { gpiod_direction_output(wsa881x->sd_n, 1); - return -ETIMEDOUT; + return ret; } =20 regcache_cache_only(regmap, false); --=20 2.47.3 From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732D94ADDB3; Fri, 5 Jun 2026 08:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649344; cv=fail; b=kvoE/7r8tmiqGvsvnQHnGd2z2t9vxv6N0d61SdE04kW2Kiq2O7YrgJeXhkZBfW/Vv+fcCSalMBHUr3UarBJ1nNX95EOOrje0we9Gn/+eccPjh1f2Ol0Ybqcgg0qGT3XiWCTJCeztQUwOhjLMDsCbyxqiyEblEh1Q+peYRSz+QPU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649344; c=relaxed/simple; bh=+NZj8rZ/B0GswszZQcjwF/9p0gNJp1fUaQeAJwxhExM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Vux9XJ5uXYuuCZ/M3kaOZIa5maCpYbwGZUJCkhpYcLSh3zJ2hU3GFhaqitRJWOMhZTETbkalCYuaATCV5XHdlEXsN2Sc0zRENUCSK/dH8pKEL2BWF/dLFjw+x7YNJ0R2mwOWNA7QE+tu3AVETyumDJJPjpPzlXkKYThgRx3gVpQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=kKQmuxVw; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=yWkWHvOW; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="kKQmuxVw"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="yWkWHvOW" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6550JRiX429440; Fri, 5 Jun 2026 03:48:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=h46n4PFyS6ThGKumlkzykJv2RMKXyDlHbPUot7Q7AkY=; b= kKQmuxVwXHSNPIYCDHR6Qmd+OidmsqpK6C+NgQbR62VUnMP/6MuQNFuOP6g8ZFnH LlRJQyWfNo49cOFw+hIlMh5m2YhBMlfO8GOIcOE5tK2gqY36pUcjfU8K07Ht87o4 bWnHjQIV9HJhPVFrIorIsueey+ESdkbl9D/9RgPFiCeUaQxrJITbD2jjrscIe1XV 8EJob9cs0Nr7VPD11mUipFK4T5EC+hPLjlQgU15CtCn2JrM6dFK1HF8dfNBB4aMF CEbCW8dpMj8egHZEcumvaeV+ri2wOlN9sfOX0RjS6Gss/8TeiEIDS5Li3g/637ML PUPFySFQ5+0FO+gdO4rGZg== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11022087.outbound.protection.outlook.com [40.107.209.87]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa192j3-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:19 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fSRjGxCOu+aQNHdRhu3iGTlYRAwh0u+/rO/LPOxXGhtuFIYh89B7ZZsAtnGj9y4Ntda0hQoYy0XKpCuNuqnPhxd7BNM5juOtmXrAA4ATTPJ3YeQko7lAJF+9iGjjsYAlFLRKKvLm/ttwr3a74mODHXTCi5kHDIUB1M5s0r6NOgIbCxoOwTJPqmUg9ZpLODYSQ8S00G0MhPVxX2OzFqZ64BBC1ck3TQzG4YhyG4VjDBUy+IKzgmseE/jMDyroAxUIAm6kJ1OdlN21hSudeD/NRE8k1KGuB18S7q2r0c6uYBgF5m3XFW0AFTz1doRlaVaypv4QQGTHZJrOtPhgFHIjvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h46n4PFyS6ThGKumlkzykJv2RMKXyDlHbPUot7Q7AkY=; b=sLrZMlN38uEc/st+J3PSBOu35zDTYdHDE3rWNwPmcyPtU4XJj+SGifpuNGDwkS5ZOqJRP7btxZAOS7KEINIDbrUnfnOdZgOkJRsrJ1Y3lIm8M0qK0BgfLgKvrl449+D/DJOYb4zlsXCs0ESovx+S7wP76eih+7wEVuc6Mwm6aZpCitdsxNHKNQluGs+8TSJCZ4Ea2rN/3U3vufSHXVC4JBTVkfDFUiXw0gcgB8Ky0GLJY5grmvL1R4X0DNSrDUty3yosNAfx8SRywdk2yOK4E02d2WYUiP/1x3D7JsTeE4w2PVLoG7AYUnK63VuRxyYDBjbd1m0WnJwpJN00f6T1aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h46n4PFyS6ThGKumlkzykJv2RMKXyDlHbPUot7Q7AkY=; b=yWkWHvOWpUzRiaxjePkszDJLgfmMMhLr3RNtBGZ7ewYh9pKf0oAZekipl80kC2ean5TpDyHxLFum3SUIn6t+Wh575KcWAz9hUp8uDmJco6xduBDNz5g8s0okcA9MREl45ozSnvE74SV5BCOIgHcuLE9ddo3yJwClFAB1pFs4PLw= Received: from SJ0PR03CA0382.namprd03.prod.outlook.com (2603:10b6:a03:3a1::27) by DM3PPF95B66400C.namprd19.prod.outlook.com (2603:10b6:f:fc00::748) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.8; Fri, 5 Jun 2026 08:48:16 +0000 Received: from SJ5PEPF00000208.namprd05.prod.outlook.com (2603:10b6:a03:3a1:cafe::9) by SJ0PR03CA0382.outlook.office365.com (2603:10b6:a03:3a1::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.9 via Frontend Transport; Fri, 5 Jun 2026 08:48:16 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ5PEPF00000208.mail.protection.outlook.com (10.167.244.41) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:15 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 36E1B406556; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 0B4BD822542; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 03/10] mfd: cs42l43: Use new SoundWire enumeration helper Date: Fri, 5 Jun 2026 09:48:03 +0100 Message-ID: <20260605084810.1575539-4-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000208:EE_|DM3PPF95B66400C:EE_ X-MS-Office365-Filtering-Correlation-Id: 7959d8d7-9cac-4c58-2193-08dec2df2f37 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|7416014|61400799027|82310400026|376014|22082099003|16102099003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: i9B3e7g2K+hkoQlVdCN9R84vxx0WCJpDhBshSeJ66LL0cMBgddgd/tINsIVSgR2iwAGPx7Xbjt1Ke6R1szq5qhTOjfVDWN9Ymfad2Ftox3ClCneAPjAyItd25AyKl11dhsCxACR4Dm5cOLaTgh2NV0UlXou/td045XNqFAnbMjDAMvPAb+iRsLOMtP1CqcjjnbYApY9U5gM7J6axutUqPs0/x+eyC5KiBTxsaXhvyr1sHPXDdd6VJDVdUroBvPpjTpbqtn3kGbAqebL8zh01DWNQTrhniJe5uctN7mhuj0zc/zlGoi8s3dWNNhnBBv4QAXdQrODXsMug2mS0fKOBnvm4Hpylof3roA2hvqef0mI97rXW244rFKu3JC8O4CbnT2SVYB3AnvU9hHCfko4ProI+xK8VDMDkdYKNYFssSDAjTil5EL8h3n9SKYkUdZ8ZIcA5dlHXSrALZSC4t+ymXFAI/nkI3PIshTDsVKcKaLpjphq66eM77rqCZUuUxWwPKkeDlVodUd9jd6FUC/WzNrg+rwtiuSC+gPCXI6q2U5EX7dMKPOIZStkf+198h4SxbHiIyCid6TMW4xVORG2n3RaAcCuz9n8EnMgNPBsIllprTZJMTSOH7qIr2w/5taT/6+gmnJpLxXd8b1aeebH6t4WtuzhTH/GdrDRkardr5N7fTLH4H1QmAKVzO5MsaiVzusEkrgDBjtEw9GVHeUuJi5t1jP3yXXXZMZJUyelA2gc= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(7416014)(61400799027)(82310400026)(376014)(22082099003)(16102099003)(18002099003)(56012099006)(11063799006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vBfrWIjMQdOw4pLelpSF6q57kM7lwUAO7INHpdK9IzFoLB1nfMKLjwTgMNyPdHU2b3EfnIRMyhcVO2ShBYro5KI9JaSv4/zijAQiiVr/4wlHheTaDjI8ws4H+sYspMNqigvkxqOIXltfUDw2Hapk1ZrpgtyoehKvT46OPVfv2iZOgotGywkAUUWliCoxSXdVhlO5c+CX3oZnHMy3k5mKFWZgOiVBht/5d0nulmqDeQf0nqV7kQKfj5oyVGeV0E2Q7Df2g/fp3a0/snugcl/8KybE8qiMvL4rmEl2FHKscgCwLn9NifLjJGitE66w8ONioz5IhgRPmjIh1kFf8+/+Iwfihzm50+pmo9Od89z2q7jZv+Z9OWMnP0Q5PYHuauKxmCtenVUr9vHLSBr4eAuTbnC2gnZIC2g4kjYcS8aowDpQ8jFoTogu9ElJamaF57IJ X-Exchange-RoutingPolicyChecked: Y5AhRWRMOKVh0PB8Z6JqJhVbS4Gxzwn2G5IfoMAFaRaucn7m/4Ye4ZnVOqaeCjObr1t/2Qmrk92ZskQOULURkkE8VijHAUr0pOoIUWyhaoj8KUMOjUFSVuPmMvFGdJ+nM6w0VCazdty7a9WJozU1fz+zeLcO9CttYRf4jiv/nGD0JNUrRvfZfAgnek9GC9TDzN501Th4k6sy5bvAaBvQzovLC3xYQmBgcE9XsIEA/t2byYRtkMcOXwc14hTxdsKPeODU+Onmhlqu26YuUBGfy6JmEajf7E5++WCEvAiJDyUUEJJ+PC9BkoNyFJTX65UxD5tsithEMomW7tIiKF29CA== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:15.5561 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7959d8d7-9cac-4c58-2193-08dec2df2f37 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SJ5PEPF00000208.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF95B66400C X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a228d53 cx=c_pps a=W3l6ozmAkfr7SACE5S5a5w==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=zWJqKzWmD0Dw3pFQfkwA:9 X-Proofpoint-GUID: 2LaO720nVPbRAQH-rtJfNSS-p_r7M8JS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfXxgAZVfgz4wAu oAscRWa54S34bx4l/COzCBaKmYOECoD1bBt01Q6JfbMsrO7j9Al66wdjyINe2JnYFtxzXhW4o7g h3Zvvf+N6ezoXk38WNZad8LbtKNdDlOyAFEV44RVYgohZwJOilVpP1Jfj7e/brE9oMCUh0zaWCL c62kRd01zJp2nEAwF36qss25fdfxGl2r2b3LKMOpXyPeyNduMgNYUHzC3f+nBUs5ozc8oCs5OFI JelRBI4O4zn/YraIB9NL1Uriq5KimvMV2IOH7MogcTEwICvnhy/BueivqXpo+jLqBSIaaB3LkBz +aYKrFloJgMP7G9lmlft6YboUT8dhLQ3mTUpWqgAeu0zexPvr0FP7PqWEsCQbx24IDjFkteo0PX c4Y8jxIwKYh8+9DYzuJboxeZAK8lVfnlXOiifHh8E/5dwHASqf/EAwci/aFjEdECmJHZcUWtJ93 LCtmetsTMmcVzFuVb6w== X-Proofpoint-ORIG-GUID: 2LaO720nVPbRAQH-rtJfNSS-p_r7M8JS X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- Changes since v1: - Completely remove attached variable since it was now unused. drivers/mfd/cs42l43-i2c.c | 2 -- drivers/mfd/cs42l43-sdw.c | 7 ------- drivers/mfd/cs42l43.c | 15 ++++++--------- include/linux/mfd/cs42l43.h | 2 -- 4 files changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/mfd/cs42l43-i2c.c b/drivers/mfd/cs42l43-i2c.c index 0a0ab5e549a5a..4db452b41220d 100644 --- a/drivers/mfd/cs42l43-i2c.c +++ b/drivers/mfd/cs42l43-i2c.c @@ -45,8 +45,6 @@ static int cs42l43_i2c_probe(struct i2c_client *i2c) =20 cs42l43->dev =3D &i2c->dev; cs42l43->irq =3D i2c->irq; - /* A device on an I2C is always attached by definition. */ - cs42l43->attached =3D true; cs42l43->variant_id =3D (long)device_get_match_data(cs42l43->dev); =20 cs42l43->regmap =3D devm_regmap_init_i2c(i2c, &cs42l43_i2c_regmap); diff --git a/drivers/mfd/cs42l43-sdw.c b/drivers/mfd/cs42l43-sdw.c index 794c983781750..2b87ae2d79c51 100644 --- a/drivers/mfd/cs42l43-sdw.c +++ b/drivers/mfd/cs42l43-sdw.c @@ -100,17 +100,10 @@ static int cs42l43_sdw_update_status(struct sdw_slave= *sdw, enum sdw_slave_statu =20 sdw_write_no_pm(sdw, CS42L43_GEN_INT_MASK_1, CS42L43_INT_STAT_GEN1_MASK); - - cs42l43->attached =3D true; - - complete(&cs42l43->device_attach); break; case SDW_SLAVE_UNATTACHED: dev_dbg(cs42l43->dev, "Device detach\n"); =20 - cs42l43->attached =3D false; - - reinit_completion(&cs42l43->device_attach); complete(&cs42l43->device_detach); break; default: diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 166881751e698..cb1e175586bd1 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -586,15 +586,13 @@ static int cs42l43_soft_reset(struct cs42l43 *cs42l43) */ static int cs42l43_wait_for_attach(struct cs42l43 *cs42l43) { - if (!cs42l43->attached) { - unsigned long timeout =3D msecs_to_jiffies(CS42L43_SDW_ATTACH_TIMEOUT_MS= ); - unsigned long time; + int ret; =20 - time =3D wait_for_completion_timeout(&cs42l43->device_attach, timeout); - if (!time) { - dev_err(cs42l43->dev, "Timed out waiting for device re-attach\n"); - return -ETIMEDOUT; - } + if (cs42l43->sdw) { + ret =3D sdw_slave_wait_for_init(cs42l43->sdw, + CS42L43_SDW_ATTACH_TIMEOUT_MS); + if (ret) + return ret; } =20 regcache_cache_only(cs42l43->regmap, false); @@ -1120,7 +1118,6 @@ int cs42l43_dev_probe(struct cs42l43 *cs42l43) dev_set_drvdata(cs42l43->dev, cs42l43); =20 mutex_init(&cs42l43->pll_lock); - init_completion(&cs42l43->device_attach); init_completion(&cs42l43->device_detach); init_completion(&cs42l43->firmware_download); INIT_WORK(&cs42l43->boot_work, cs42l43_boot_work); diff --git a/include/linux/mfd/cs42l43.h b/include/linux/mfd/cs42l43.h index ff0f7e365a19f..8e993fb535e68 100644 --- a/include/linux/mfd/cs42l43.h +++ b/include/linux/mfd/cs42l43.h @@ -86,7 +86,6 @@ struct cs42l43 { struct regmap_irq_chip_data *irq_data; =20 struct work_struct boot_work; - struct completion device_attach; struct completion device_detach; struct completion firmware_download; int firmware_error; @@ -96,7 +95,6 @@ struct cs42l43 { struct mutex pll_lock; =20 bool sdw_pll_active; - bool attached; bool hw_lock; long variant_id; }; --=20 2.47.3 From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83C74494A00; Fri, 5 Jun 2026 08:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649338; cv=fail; b=kjCpKPs3iVAd7elXuJ49amvn/z4MnjTNSAwO03pf1VXT9v8CASSZ31aaONdkN/WIAuhTEiMXNrMahxGS7g9cDHVEWEVn6VESUTruwOuf3k5AyknmIwBWdmm/XJEgNLG23bLw9mmyhni6H1fRJ9ANxcxGzksvrGDkpmjGtV2haj8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649338; c=relaxed/simple; bh=KVy7EDe4B1uRYX1ov8iXQTxiyaQ6CzZuYjnX84Ww5BY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nOCt6Eh76FXNuIr2imggyGntpWF45cBEgw1AObuD7yYSeqIIv/MI2ikhgYDo1ktOWXqVNpMEBIPk0fDUdag8mWVQltW4GGOKh3daJqclXDHqgdiOMs5OGKkTmY98UqlS4UF1F6E5P+fleUe5pI3BQKzbjeRa6yYNGNft9uehDy0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=VguNbZiC; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=rqyH8ivg; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="VguNbZiC"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="rqyH8ivg" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6555iB1X3107326; Fri, 5 Jun 2026 03:48:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=MTtWJznKgs9gIXuboummiglLGBazl9sN72T7X7RWGYk=; b= VguNbZiCaGEp8qhBQ9ML79iUPjK/dv9BLTf7h3jAQip8TntERWMP6PF3dkqMcoGw niacP5mSQ249NrmkUjmqrhfz5Pp+2TGw3+whNQ+UxK6T7jruEoGDcV/Ysb3/ioqN 1VwLUTGOySPl5Db0+AYSoc3nU9NgKSUw0ltoGQSOSPJsm+V9l59Nbm+9sId/B7yY rFohK7c3izbu6xT28zbElHxR+qp/l/scs+DmCbnG7ut5wwYwlLdmhtINOWB3niTn yY/aq+edOU+64UQacxFLxsDSW2/mKwX+g0u4E6KyqSPwZ41FxfIv4x2KAybEY3K3 DFpfZBsPauynT+ykk/1zFQ== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11020087.outbound.protection.outlook.com [52.101.46.87]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4ejrbram9v-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:22 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D9QPomgQxUWmnq7ymzCbuYmZWz1q46cygL5FK0VLiBr5eZRPVQ567gc2C2xsf65c1WchRN5p1LPParUaSlIDIllN1i6hH7/WYWU/ghoDRtMyl9FEDV1vb0EGcnInL9w/W1h+yGDScoJ8y2z+BKaEaEodp5YlbbYtdItyGuhplQVTMOZuPw6u81lT+OvgPg8jcQcfoU8Jca0Qmu2kQ9RtiBjuYSvmh7NlGMiVnG7C2Rpltoqu2TQOnNJvOuDKLl9HzU7XxFfkiCb9zQZeXQy2llQQ5/4ZPzmJnDvF+hzuvkrRgA6M1nEBpJFznusOj8wz3X5qds8tPMFWgKbpyvY2cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MTtWJznKgs9gIXuboummiglLGBazl9sN72T7X7RWGYk=; b=xwJPbZVSL/PItDZqKVhE7DB/YmVf4GZdh79eGoSgQVdpwiBK7VYIsKPT1KDqp0GqQG+0eD3q2xJVmToXihtXBBr0SUhujEMRWrNfBYg9H158lPQBaImXLd9Zkob/jSMO/wopfyjVkvj15YWRo51E89FAUggWM7pSi67+dmTNkLWNPSCnMWJJt1IfpYf3+VkMPSBd+0G7L0ncMMl1Bq9KcIJH6ldNG1zDcjZo3ZVLa4jgJckux+0OF0mviZgFoe7eiXFEYz9mVxMP09EEhW4/bfoK1eWDhvu3gyivy3o6sXqY9ToTLugTzTzr57gQYlwaqSBIVkpqw8x0IK53yE1ZfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MTtWJznKgs9gIXuboummiglLGBazl9sN72T7X7RWGYk=; b=rqyH8ivggR7IQg5ZTszZLi02DCPM56vWUup5LkTu2byswX5TNV0cUivRwuTMi+9fe+tur3OFCZpdYnG3l9w4CMibGssluhfr1npL8zzxLm2w45DoZE3ceQc9R6e2wCHs2ujUedEwHR5uCo7H+E4to133UmKhgYtyCpI1IymfXlE= Received: from DS1PR02CA0002.namprd02.prod.outlook.com (2603:10b6:8:452::16) by PH7PR19MB6061.namprd19.prod.outlook.com (2603:10b6:510:1dc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.8; Fri, 5 Jun 2026 08:48:19 +0000 Received: from DS2PEPF000061C6.namprd02.prod.outlook.com (2603:10b6:8:452:cafe::50) by DS1PR02CA0002.outlook.office365.com (2603:10b6:8:452::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.9 via Frontend Transport; Fri, 5 Jun 2026 08:48:18 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by DS2PEPF000061C6.mail.protection.outlook.com (10.167.23.73) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:17 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 45016406560; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 0F20C822544; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 04/10] ASoC: rt5682: Use new SoundWire enumeration helper Date: Fri, 5 Jun 2026 09:48:04 +0100 Message-ID: <20260605084810.1575539-5-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF000061C6:EE_|PH7PR19MB6061:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d6cd09d-bb93-4e9d-8068-08dec2df3098 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|376014|36860700016|7416014|82310400026|56012099006|11063799006|6133799003|22082099003|16102099003|18002099003; X-Microsoft-Antispam-Message-Info: oMW5zoYdR4wy3qFb1znRIPodkfD7U7msnE7jOe6hmWtugqa5s9kTroelhC+9m7dJI9OKxuRu30jKNNoLJvGBBBmkhZPN/zV4lfXI3oIYsO2nwY8KX6miOHCe33XGml+nomLXTWB4eAECO4L/SLe/iwSRDSI7r+wztie8le29lT18R6TxtDx5/HjrlkMwtD6a4O+LwW+hMnbzfAAsWI2Tz+kDNZkdpq38MaQLac0P1/cDFsXqZzioFa7nYKyB9PYWFO131YXBKpA+RwnGs5L5OuGkCKN629AmdB5jRJR0Vg2wVbvaiZCq7hi6acNFGwplwADH5fA7yJFzc+zv0WB2WLFGMYFDQbBEx6CEtbsxUIAgu4LyJXT9Y30tEWa2Gd/4qH9aZG/SlIaNafoHw0Om9b4S+1vJDjGDZmx7VLnI31p58dV4UIsfnoVbvXDTuq9TUje/agbmiCr+9IcDhxtxNTpHE8AuwEnQztVeQVkCXWR97kFiS3cjNI5whH8CsiaDdJETUyFT9aYnRmlDQ6p3LPmwlKIBzt5FEyoz8WAgt18uR4iR5HfvEHU2ThX6yfBRo9jL5K5VzWJ+I8sQupP5/ECyrVLXocVp6vRpfzsd5vFwn6lueHNjj2lSZEzrdz6nIMEkTP0TfhsrWx+8Bx6aVgWFcIWdx0vPYnx1/FfpF/0Ci+xyNk3LmAq81+VjT0QyyDGAW4ST4wIXsoO6r0AQL/AefKi41z/nKFF6gIAXTH4= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(376014)(36860700016)(7416014)(82310400026)(56012099006)(11063799006)(6133799003)(22082099003)(16102099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dWVuphoUkyTA/7ACNFF0x8goCOPd+44HJJOjBEYMSLSAR70Sf2CLPy90zYVrS1vXvmxVRJ4bVgIvG5x/qiZd40M+MLftkoPOemrB45BeiY/p/qNI+fBo69SoxCMCsoPZLItvgAxHTq9zKDPYPdPtB9CsnSy6Dk6Sbav9VGsa1oWZ1Sz8c+AbkrqE0fy5bW0IEKkL2N4EWtdGqKXfviSJ3mTzXQ/pv7f8fo/nzfQ4THeastFzbY7X6cqMlfbY/uLytxlvJFvbW5mSK8UqyG1M6doNA4giJEz6tUcbVn00POJ9oEzREyWNfFxRfJBzw8IPC8FWouLGUKWN79yjJ6C8XUiwLKrXo5OM0HSXduQ01lecufV8iPF/+G2M0Hu6hU7tLK7Z066hM/pf0EDQ/+TUYDwHJXC4ullF/h1BxhrUWUTGHgA/p1ApXoPAna2qrpgV X-Exchange-RoutingPolicyChecked: Fqs9iK7yudShlKu3OwuaHr05VsutSbqAs7HC5h9pq8Rt0ZFdlgebwv2/7N/GtWo/VG94xPHo+phtDot55bDsjf793UyDlrVcle9DkmpG5gR6nQhbqWE2CFf/ib1DoFwq9KBTuLBdRx8+NltaQyyfgUNXX7m+he/l12+x8hf3gLtDSbC2W9gsRUdojNO1uDyjZIyDnlNOTMkRFPhugi7Q65jY5okJK2NP81YHSGpN21/LD7F3MsTt18h+P2TGkemihPPY+Ip/W/JrDYJ1tuAdPyEOhZddPCztf7LLmC8QfLPzIeLKTosWfQL3y+k+1XpmGUQ2EZNcd8AvLa5lVesvDw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:17.9201 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d6cd09d-bb93-4e9d-8068-08dec2df3098 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-DS2PEPF000061C6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR19MB6061 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfX1XrfxMGVEEkB QuU85cn+5HZPyytMxjq34tgIO41N2DEOPBKGxK98uFJXqYNp3RcVQuFnMEou6mcmdS/oNg3CrfF XHAZnGUy8A+5CSZMT1tbPM4o9nXJyAwvPPCZjhczi+7sFY+MZt512g1S12v5Fo0UlV73VZT60yZ Iossl9JSjkCLfEU3eI9qxDTwfGvfUMXkLSBG20QcS8uWmcA4Wtu5vz3gDn8551XvdMNbBdzv12i KGiT0T/RjrBHwXAWtkAlqKheEzSRpICpcZKLcYNxjAQx0tSxoz/hVSYdjmcvjTkR9gUXJZFoLRj fFPva62PLz97DDAopryzDna0F0ALI41ItPBqYgbukdW05R448t6cdhjWE3HXDr47DiWFy7ptScU pDMBJfYRDQjhkmiMJCfS8yQ6pItESWWwNRoaPVyup8dt3PhV8e9hKveGGVqnbaMcsC/sHhmtBZQ uY0SsNffvky19M1AfcQ== X-Authority-Analysis: v=2.4 cv=TZimcxQh c=1 sm=1 tr=0 ts=6a228d56 cx=c_pps a=JhSJYUolln7UJVv2rG4jYw==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=3l_c3HHteuAAOOvkCYUA:9 X-Proofpoint-GUID: hXv2Rrdz8GhXt8kvvz6m0A1Q6j-zCiQx X-Proofpoint-ORIG-GUID: hXv2Rrdz8GhXt8kvvz6m0A1Q6j-zCiQx X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- No change since v1. sound/soc/codecs/rt5682.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index d39f8e4f3474c..4b82e07d3b2c7 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -2929,20 +2929,14 @@ static int rt5682_probe(struct snd_soc_component *c= omponent) { struct rt5682_priv *rt5682 =3D snd_soc_component_get_drvdata(component); struct snd_soc_dapm_context *dapm =3D snd_soc_component_to_dapm(component= ); - struct sdw_slave *slave; - unsigned long time; + int ret; =20 rt5682->component =3D component; =20 if (rt5682->is_sdw) { - slave =3D rt5682->slave; - time =3D wait_for_completion_timeout( - &slave->initialization_complete, - msecs_to_jiffies(RT5682_PROBE_TIMEOUT)); - if (!time) { - dev_err(&slave->dev, "Initialization not complete, timed out\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(rt5682->slave, RT5682_PROBE_TIMEOUT); + if (ret) + return ret; } =20 snd_soc_dapm_disable_pin(dapm, "MICBIAS"); --=20 2.47.3 From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83D1B495523; Fri, 5 Jun 2026 08:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649339; cv=fail; b=dtFwRXvhvk7O7+pTKEZ8lywPJ2M8WyrPWgcEjeRJH2S71juk1TRoepHAb4d3kRWJPHc8Oa7SRDe/qUEW1DyGXVMthbpt+/2wbbcE5/iaRNS6c7qNehN2YMyLuWLiNZHnxH+dFeLlhdvOZts+EN4ksj9ygWCGCfFO1x5UsvrbOsU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649339; c=relaxed/simple; bh=/PSPI50Ru4vizBocCtmQUduKLKuQ7mmmO3I7BonfFHQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Vq+eUVp1TlVT01kLRnw9Ce3w3zQSuLDf2+cD29qb/9JoGzrnyMF+e+MJUb85ebIX9BUzMeJs66vn794Xj73c/5zt9dKwCyKxYRyjn7+ivSG7CyUzMbILnhb+0YwBc8bVJxxu91qaRNorEjF83CRE34K3ZhR9Eisj7iKAXwUeI00= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=Q5Zj4WAQ; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=e/2vbOuQ; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="Q5Zj4WAQ"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="e/2vbOuQ" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65500j5U2067866; Fri, 5 Jun 2026 03:48:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=JL8fo63cqzkdyCtQArwt1GpDA6EIZO+NP8OrL4Yw0nI=; b= Q5Zj4WAQB3OSg1Ndvblir3l5dqJYwDEdJWE9tvA7FcRGC/gXWScdX+5jlhBa0DA/ UYPwWYMSZs81mszQLi1Lpy2gt8Lfd9OxZOSE2+juBkP4Ofgo+6NckGXd5rjlAh1z HojjQpUMr0IiOdF55W3pos0hH+rVMN7VznXfO32XfMjwH2sWNsvUoqP/g85x9uVD dls9j8oTinsT18KTuG9OCY/gKZP4BuVtDYEVj2+T4sdAB6Wy+N8G5WX5ugcynOlq ccwFpeuReTd6lu8yaHx29+XVFNhGpEeR5I0A8DutiTP/yexBbvnPDmxbL8rqB4CI xTkWbpl75MYi+1qd9IzdCQ== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11022101.outbound.protection.outlook.com [52.101.53.101]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4ejrbram9u-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:22 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tuqDoucYXQ7XGvFmco7bo0wHhwMXWo9LZG1RyFfW2Cu3QOkdLmcuTKaZDBuBVCxIholOmFg4nOTkmiIAJorJEXUeRylDM8HwlDvVKTbbU0LcPTwr6J0fXpkzREm0V5NX3IAqUCFiXIToMZMenPJOlL7BQXz04YdXjaK2HZo3Q6zXTEd6x00TbP65uA+nmwm2a2Q4zC79xUN9FrPeQ0t+JEhCcYdzA+mVdk4N6l2mOqGIPKwY1QXPK1AfNj6YO+QEYZbvwW7fKutfx+uYgY5oSp9XJ3JR99mKRxHLOwLsnVYHyzFUY8vD8it3khBQlc4YA/IZIouGzjwEYM2GzpMa+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JL8fo63cqzkdyCtQArwt1GpDA6EIZO+NP8OrL4Yw0nI=; b=qnMLwFgA1+zoX5/pI5qRzZy7PEUcn0EyNTvQ0TYnzgS1KGnD2IeaRwqPdAV9cVfjLbBLEChRCVxFIb5X2mcpCukhnghWis+hAR077GmPB7SsFBThgxGId5kNhgPdVoiDs2X5+vi/N5yRG0pxCucRU65awNLroMRXR6ZgYPRf/uy/JT7/AR3Tloa+iS+VaeaXzJlAqoL7UPCnIJqHByIem5Eok2ti7yLBJz+v8dcjk5466qr98/1D6863Km4la7zIDoRHzxuXrjlqpGoA6/Ws0TqRNPtuvBdrRNB9vHBXGP/woB9E7IT3CtueYg8QXQftF8adlezklTfez9u9CCNwng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JL8fo63cqzkdyCtQArwt1GpDA6EIZO+NP8OrL4Yw0nI=; b=e/2vbOuQsBl/UUkKyuXcclu1LHfVDndBB2kmXAIIqr2ddwaZsP/hXQU+dAZllRBATHeDCSo4i5AIr9p9f4fxOgl4TfrBxDFDP0sMg/mZ4QZy8Qv0VriaZW2K4549XlvXyr6A+kA88fXueI6a4B8QyOlhmf33ahJrEwjfdTO0KSI= Received: from DS1P222CA0023.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:44b::15) by IA1PR19MB6521.namprd19.prod.outlook.com (2603:10b6:208:3ab::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Fri, 5 Jun 2026 08:48:18 +0000 Received: from DS2PEPF000061C2.namprd02.prod.outlook.com (2603:10b6:8:44b:cafe::a7) by DS1P222CA0023.outlook.office365.com (2603:10b6:8:44b::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.10 via Frontend Transport; Fri, 5 Jun 2026 08:48:18 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by DS2PEPF000061C2.mail.protection.outlook.com (10.167.23.69) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:17 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 3E993406559; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 12214822545; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 05/10] ASoC: pm4125: Use new SoundWire enumeration helper Date: Fri, 5 Jun 2026 09:48:05 +0100 Message-ID: <20260605084810.1575539-6-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF000061C2:EE_|IA1PR19MB6521:EE_ X-MS-Office365-Filtering-Correlation-Id: f46a3057-7c1f-43c8-4a35-08dec2df3075 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|61400799027|36860700016|6133799003|22082099003|16102099003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: Qz2c5pwYnRb+rraJQr70rnDN9btgv+Dl+PrDZdYQryHDscVvBI1kjrcdBM+2hT/yqq5Occ7Re02qs8OoiI1LHKHLNq96de+D5e6pbhpNAr3WtbE8NBSw8tsOOUrF7U461JLHz3tMFay0vUcGpV9NIH2QR2xhmcuIOUMGr1d3USN6u0WRNG6Zu5BB7HG5VCvUAZirHiGGZNGzdoMGHvwiHgv4+q2w3//rT+gSyqPLilw4d5YTy5fSzitxAK+7uOyB49w9jYLO4smgziCNfvExTFxHIjQkiUdomSANudnVbcmWidqlkPgRFfVK8+4nZb9Qs6XOiSNUmuBbjpKMXuUvAsuon9pcaaTYbH6gskZWpqsXOLw92Qm/GgcfBvvUH5gQEdY310kDLhmMtRPqa8/6i9cAtX1XezgVfDaQPLJhq5pVhNQwWs6KKpoT9f5ALA+S/SNrBzcF6g2EaupjHujD4TVRVKHc27kACoRkvSlVa+4Dg9Ko6XYjwqQODjMH5ahLLJvZjWk779lJr/RU79tjoXD54IgG/pm3L54chVkr8zK3eAQ4fncDWpUP1JWbs8f+DXTDBAVzpUrFonxLBaS7S6vQCbeQul3e24INdS+SvC/M69IHaGDkRC6+uccmIlXDxPmbxTIHWC5UmswW3cSYoywPoAaWtKj6IscwFQQNGdHTLqF3TJ2odBNREpih95vw8D5/yYkoM73E2+MPJNP/ykcwtk7Ui6ZeaH76B6NjhzA= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(61400799027)(36860700016)(6133799003)(22082099003)(16102099003)(18002099003)(56012099006)(11063799006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 26hA72Igoq1Nw562DKrEueQdY918Smt7NHyP+pljdn7/tTCYJvqbQbYptqbH2ffdnQc57nCrJ+78dQKXl3AcRNyRnPbdjxS4TKxbUrGMisav3+Z+0o7uVC1u5rWwySjL/1B9Bbaf7DWuDBBXWcXH7bfvjq0/0assQNods/7r1Yv0mlSnUI2LP/Y8IUCU3DgzLmIpsNVHtoAdpLw49yxT7+RCviuvOisUTguzbv+dyMlQ5IZAA0dI6Jbaji70jITpycmVjNt4JBCv6PROwzA2/dYLWWQ8w9oeaydBzgW9SpA2TVvk6utJgNwFkKczooX+1xMFnUhLGj1ucdp4nlACQOneRpA1XY+GGHjkLvSO4NDnI3Hs0sh6IylRi76Mb/eeVO3AtXgrXniXcEeDSY33scjDaqHJO5La+mcqWhOG/SMtfln6LDqvqYM25fy0lFLH X-Exchange-RoutingPolicyChecked: fD2knXluJHNEle01nI2EvI+8yaKmE1+BeNT8a2S4vg/R1JnslaIxiXOqRkpkDBBAr9XVvm3N9pyyctt38xa4iIzzHhZnArCGkaTuP0NRj8qM18St/asF/F4H4z4iCI6e0ZYpDBbO3fVgjRYa2jrDRbEUT3j7/zowIgV30y5HHAasn43ROeW8BW7Drje4gazu7H7x6HwjU8DldXOmDXfTVLW+HKxc/63+1mvXuTFSvCjuzdt31mlT3lZ9KpIxV2XPO/xo8RnWB9xzagXrbsmF3qRsiH+2wNL6ppQfcuReWixTUWVmfOD45fq0aT2e9x3nySfS9KefO4dAjjjEU+XTYg== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:17.6909 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f46a3057-7c1f-43c8-4a35-08dec2df3075 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-DS2PEPF000061C2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR19MB6521 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfXwSSogUFprY8m NKB81Y+1G422eqnObd/MkWsPihZLsOrgf5OoWR2Pb0X0HpatlkITQKjgtyCDwGxX6hgZaV2/8qx UEePWqRFvJ32b6lBIm9WdpR1I0YRidSdosBeFLEDeTDnKihbyy6f5oax4Jn2AzsC9dMdFTN8VNP U9VfSNujdVDyB5/GCL3hYSQKD6c8uVlhqoR+tc9wKyiDSLoNkxSaJB+WRn/U/pCztMskmY5XM8t FAqL2VqR0meJTWmOZFFDdBVGb8Ef8SOtyl92Tl4vCYGj7KMn7fEn6WDyvXsumhdRorjEWDm+1+c SuGNJH3fAbFrkM56ikOBGFH87aNgcIdN5ypdjle7gcgYSgRnVW0ccyUkLf29DeNzA9DoiyWKqPp sKjUY3d8kOYsXYumbrOZ9xqfjNG3qbsbj517Wh0IQmXhhVPM74K2N5ISosbAZ1LOzBEcU2/tstA QjtSyIBrTZeqw3r84Qg== X-Authority-Analysis: v=2.4 cv=TZimcxQh c=1 sm=1 tr=0 ts=6a228d56 cx=c_pps a=ZOOYKzJuauqLjokEqQd8dQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=3l_c3HHteuAAOOvkCYUA:9 X-Proofpoint-GUID: 8bBGp71CRJp_os8JMURbmhjupbaj-zLq X-Proofpoint-ORIG-GUID: 8bBGp71CRJp_os8JMURbmhjupbaj-zLq X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- No change since v1. sound/soc/codecs/pm4125.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/pm4125.c b/sound/soc/codecs/pm4125.c index 1f0a3f5389f1b..29655175ea289 100644 --- a/sound/soc/codecs/pm4125.c +++ b/sound/soc/codecs/pm4125.c @@ -1309,17 +1309,12 @@ static int pm4125_irq_init(struct pm4125_priv *pm41= 25, struct device *dev) static int pm4125_soc_codec_probe(struct snd_soc_component *component) { struct pm4125_priv *pm4125 =3D snd_soc_component_get_drvdata(component); - struct sdw_slave *tx_sdw_dev =3D pm4125->tx_sdw_dev; struct device *dev =3D component->dev; - unsigned long time_left; int i, ret; =20 - time_left =3D wait_for_completion_timeout(&tx_sdw_dev->initialization_com= plete, - msecs_to_jiffies(5000)); - if (!time_left) { - dev_err(dev, "soundwire device init timeout\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(pm4125->tx_sdw_dev, 5000); + if (ret) + return ret; =20 snd_soc_component_init_regmap(component, pm4125->regmap); ret =3D pm_runtime_resume_and_get(dev); --=20 2.47.3 From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82A8F47D94B; Fri, 5 Jun 2026 08:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649338; cv=fail; b=BwYHjpG28YPaaVaCkj0V7MaHBnuG2lueaaHOUuE40jNWylikV4zFDvwDcwZFJX+Y9JNXcB3F84cmNU+KcfEn9z1AlmZyVMOwH2/liuplHRg9w4Obw+/EX7hQGz0oDI1sFtFIMsXUM7yklqCSplTPRqHjk7n2inGdjKboxTxFBQw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649338; c=relaxed/simple; bh=Yi5IEg5P9ca3JwpPujVTzWWnm1mCDYLFN67OB3hs8w0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UDEHm13PA1zBtavqGGHKB+TYITC8J6BMkOrS6OoB8q3Kymz8IWPtEzUCvowsYPZOsmu79pJCQAdIAJUSSIgyF2O5G+5MPocgbBFuB2PB428TkKfvj+kmLpwtfK7wVdK9f24veIr3IBXkVlPivJe44Srt01CbS4NYK0pzF9TAdRs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=jJO4RKY6; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=dUD7H7wA; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="jJO4RKY6"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="dUD7H7wA" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65558R8n2870110; Fri, 5 Jun 2026 03:48:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=aVaN7LrSh/iSM+zlS10ggn5XHLrjJYBDb/9p0ztZSUQ=; b= jJO4RKY6HgAEt5S4u6gtc1+lnudlAmQzm8dYbG4mXcFH/syBmqRD9T8itN8op/Px PG3sBo9sZPIsyu2oEQpPrJ6Err5UgXsCz4pCz2WeIsvIIXmsMdafOy7XDe0Z2bTD Z7p2JDEQxENMqs8JOYK9mRR6Iei92KQG5rEothDolB3HivLYrcycVq/X9TDvvE2g 3YRxf3MdNGhKMXxSrU0n5A+a7AUqqIhhodX3Hlsy2xZmuKGulLqekwSmbkpL/iAx M9niCKLMcntxoy5lXk8QyP18UMmlblPQepTtN27u42g5WhSSf0RPKDW+vbOgWvpW 0drA6pWu/slphiOSllphgA== Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022119.outbound.protection.outlook.com [40.107.200.119]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4ejrbram9p-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:20 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fuFRJ6dsgCYxW/DfrRh2E9Ij/3EmQloF4rut0YbmPGMnt9r9rZMnVuLfuzk1xvL1A4JMHIoVWubn2jkPqAbQYU8IhgPo/ClY5WGm00h1E1yMHgdb1XcSKYw0NhVE3NewXTvnTZqR8AIYeFTxfAEKPucRrsp66PuCqyXgRFUkSFq/hVIgNu9905ToFyZuPWOLGQVP9TpEqkHz4/vKeb6BR5poSdkfULhji++KGEqrpfqLHpk3t1QR+oiYVNPFQdmaIScbEA0srPtAYWpI6iZYeKoEF3Ba9qjbVkhiDvC0wlcWg+1ml4juZQjh0TnwX24HLpD7QEetiM6HjuqFHg1ZMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aVaN7LrSh/iSM+zlS10ggn5XHLrjJYBDb/9p0ztZSUQ=; b=GfZt/wMC2bFaAT9diQJjbLKmsvNJJYBqZnyYEwJNCv5oI1LkJ3A+x1rggbldcFwC+JlwZyFa7ihuDaLtR61ugskj1ofgphd4xX0ckphrtMwwXjDycRqrQqY/Pe/dW2I9b4YuBQXjsydprxyrtXDFUDVNE3JvkTTspk/2DvG9OgMM6Lu+eacIWytgnapg6V1mlwIOpv5STPNtcR9GLYw7co+l1hMLWyBwkWmlHq4WibmnWKtldc4P+qTqcCIoKlVIeD5AeYrE1n2+44BPzLcNAWhQzpENn+FERCAFIh3EUWgo7HOTPHZBLCbs8Xokaiad1D2YlAThkBIbjA6dwk2F6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aVaN7LrSh/iSM+zlS10ggn5XHLrjJYBDb/9p0ztZSUQ=; b=dUD7H7wAtEUCEgv6EySFBNaWKdffI0Zg1awW1iaYz1lb0awXbWnxMQGOBybz6LnAhHjByGJn5QNhPLlTGWS4azznZ0Is9Qmjwse5pda9esq21+a2OwKdLefUW30GTC8cdUb9kE8BeAwLhDtY+jeYpRdm/+98tbRqdZY4NSVad/E= Received: from PH8P220CA0033.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:348::11) by SJ2PR19MB7413.namprd19.prod.outlook.com (2603:10b6:a03:4d1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.8; Fri, 5 Jun 2026 08:48:16 +0000 Received: from CY4PEPF0000FCC1.namprd03.prod.outlook.com (2603:10b6:510:348:cafe::27) by PH8P220CA0033.outlook.office365.com (2603:10b6:510:348::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.9 via Frontend Transport; Fri, 5 Jun 2026 08:48:16 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CY4PEPF0000FCC1.mail.protection.outlook.com (10.167.242.103) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:15 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 3D5B3406557; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 15180822546; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 06/10] ASoC: wcd937x: Use new SoundWire enumeration helper Date: Fri, 5 Jun 2026 09:48:06 +0100 Message-ID: <20260605084810.1575539-7-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC1:EE_|SJ2PR19MB7413:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e0ec52d-b972-4bc4-8ea1-08dec2df2f57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|7416014|61400799027|6133799003|22082099003|18002099003|16102099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: DnzjSoZaM5VBT6kkptNCXxB0TfyDi40dnUEQI5LFqGPxJiCeY05xOUMhPfm2/skuFtSdcLuePnXF+QDKHmbRoKUromRzm+4wARrnbk9ECP32/azO/6hKUIhTb90SSCfvMVRPLZmrtsYvflKJPaYBIexToSwkIreAVHov+9+4/j6NBP+vsrHHuB4WgIBsyRlVMua48EsgO7puSfmffH8vdEhS3z9e2sgSxfYW/K85PbZ8xB3ZQOAFP9gcE8ZF2B7S1+yc50Fu33d5vOfZ5jLnuT1IuxDcQcnptXzlw4x1OqqUJIvpJLc2xpXW6k6uN2/xckQL7dRfBpbMDg+OZyK7405ceILV4213TW7JaPtBQROIWbHHvNHpAC9xa2OPrQOi15Z+qinTa2GGVWz7DixBzLPE8+kiv+mWz5v5TmXm01YIx4FNDI9oQH3gWAdUB3YrRxdFfpdA+5sVYY2tbyE7y7YWK+/zmRw7qrlRIg6GmhNnywiRWE/9eLCjx/ObPsr0PhrSdVGpqHxf48iz8ZjfoHqJge9iM7bu4CytKlRfhC9BfCoJL2hVrp+lbEjDqxhsQsh40ThWF4h57OAjw+7vzOmubu6YgdSmjP3y5ofFNbo4HElNn/ks7NozMnYL+YpTxlAYPjJEYlekkKp+GAeccHrxahjTVMNUUE1yajzyrkjE+rzbgS6brlWQZbZTD56uFKs/Tf4gA2m238CfWYQBa3OBh5fINUhUew8k3meAqKU= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(7416014)(61400799027)(6133799003)(22082099003)(18002099003)(16102099003)(56012099006)(11063799006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0XznSUrvhQByDOjUC4EfxqkTlSZ8wBYvUqgV50r/V1q0xEoAO5ugTl6S7pUlQb6OD9mvMq4qB05MjO5HS+1UUO6r0KEG6BM0VIVV6BUp4SwzXFmpGeBx1Qpmx49Qf0ardDg2O9vhsf1Sez6/Wuz2gpIyj+0LzcqvuYY2wkLT3Jt8e2uyEXCXilveUGlOd9SpAhU1spnsMty4i0FDMdj6dliCf8XNxyuTp/eP7UCTRYoTKVdxP0vgupFh0q2Ayj1qVI8ABfw8YGomR4cdLFLjJK6ap/SnaP5+eCh6CaDbdDFbnoJHNUvepbZN8+0TyUsvh/LWb1nbRU3JKY/B2PsOw7ZJ+ouqmP63PJR6R5+/uqpVg6pPHaKf8HCbZQ/ykJwALRC8MlxDII4EqLtxKXqxvZ+UwWG/XX3WJLylTQUsbuw7EmHL5LA391F3gGRopd8M X-Exchange-RoutingPolicyChecked: Y5C+rG1MrXgNS0gGDbf2yaM7wpDhXpjcFiDW0aAriu8gFcf50wiTUamO7K0o71UhFUD0EIYi38Rl0SvAeA8RSHUVZeDSDKzdPUfDQbMjjp1AYvvNnYhGu0dLVntugHWb+G8ywSPjLKpjqeCitslm6B6BtEuqIj2UqdSx0crWbmbxhaNHWYRYgCK0ja01+LHvtKYv4UZEh9+v5a4FORGmuUkMXgbBsSOp/M5dLXGZX2Agv5YCkKdUN49xaC+WYp/EkrEGsvDb4gVe4K9TbWIcO2F6WG1lpxzasNqd3phkBhpLA2CyLc5dQxSibvTN84GxUoGhE82lNIPr6452/rTedA== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:15.7990 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e0ec52d-b972-4bc4-8ea1-08dec2df2f57 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CY4PEPF0000FCC1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR19MB7413 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfX0bnA/ItTsPG7 pngBexc8Z3ePz9k2etG1RfR5b036bpBGXQrvQb5kcnJY5FnMbuKDUcnxT0WKrLASQWZXr3kp3Wq XhoZu4YOg67uu/DcWjuQU4tIg7tBnWLzFKb6jTlf2E/3WxOehvsCUd6Um3iJ+6lpN/04tN2KOcW /RjuPngQLxal5XMy7t291/KlNo/shenOBhIYIQoueP6/oAeAjjUThLZnqe6gcSTNN//e/IU642r 39qzDivnhKN/hil93C7VJmB33Dt1RvWNqtYpLE5U5WMh15sDkOO97LwnI2MOwPfzOdlu/M7+egE TUeti8LsGWS/44gBWXXZQZBXoSa30lUl8AwMr+JElDyU8ynMUtUAGxz2AU/BUJG42WjaPqLiU7R nwPD3Zu7KSSbWmQ/NNjQV1CRDNxHC9/R6F36g4jZQWBQjRPfIZsbwdzTUl97ANWas6rq/NA7xli fmsLYAu1oalc4nZJx8w== X-Authority-Analysis: v=2.4 cv=TZimcxQh c=1 sm=1 tr=0 ts=6a228d54 cx=c_pps a=GEmlRGLg+63oxBMrosuRog==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=Uk30oNBv9cZ-rtdV3UwA:9 X-Proofpoint-GUID: OawhLAvSCSRcitlzw216Y70GLO2kAQqu X-Proofpoint-ORIG-GUID: OawhLAvSCSRcitlzw216Y70GLO2kAQqu X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- No change since v1. sound/soc/codecs/wcd937x.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c index 72a53f95d6887..e0169e783ee96 100644 --- a/sound/soc/codecs/wcd937x.c +++ b/sound/soc/codecs/wcd937x.c @@ -2499,18 +2499,13 @@ static int wcd937x_soc_codec_probe(struct snd_soc_c= omponent *component) { struct snd_soc_dapm_context *dapm =3D snd_soc_component_to_dapm(component= ); struct wcd937x_priv *wcd937x =3D snd_soc_component_get_drvdata(component); - struct sdw_slave *tx_sdw_dev =3D wcd937x->tx_sdw_dev; struct device *dev =3D component->dev; - unsigned long time_left; int i, ret; u32 chipid; =20 - time_left =3D wait_for_completion_timeout(&tx_sdw_dev->initialization_com= plete, - msecs_to_jiffies(5000)); - if (!time_left) { - dev_err(dev, "soundwire device init timeout\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(wcd937x->tx_sdw_dev, 5000); + if (ret) + return ret; =20 snd_soc_component_init_regmap(component, wcd937x->regmap); ret =3D pm_runtime_resume_and_get(dev); --=20 2.47.3 From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82E4D4949F9; Fri, 5 Jun 2026 08:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649339; cv=fail; b=VZLfbKK989yRx1rJzDUK4OwB5sibXmZ383Fq2mqBvBhtRhu309d1pzd3+QQWmJO8a1//q78PlY13Asb7FMnsY9FkRrSOtYRvfBa7sij2qKviYszUDDFc1oyPZrjvrlnLdZceKnrsRHMa6gGr92BYrguC5K5OCIThUxQGu9ER15o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649339; c=relaxed/simple; bh=syprN3dodN3cP/eiv9BMFjEFqD/2Vactoty4s/+YrJs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jhsJOjHNNGnGyM4nsGv/1Sgi8QrhxaX/zPY42sS2qJ0zK+j0JArC9Cw9aH8ehbYZFEGIDRdKZmmQ3ZuJyl/w/YMSx/x/YmJTgSgmaVts+EyP0saE1406t0BPWrOpmcLWellXVIdqLQmCv0yCs0Y/FPksFvTJKHk1kYtaVvsdMFE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=flDyg4TJ; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=M3V60Cnw; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="flDyg4TJ"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="M3V60Cnw" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6550wlZh2165677; Fri, 5 Jun 2026 03:48:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=lPUi5F9rqZ5QXVcaxg7DXgriPROLgUU85g3NVNUtKKc=; b= flDyg4TJoiVpzXlPmSAH8gVpOPhYDTBZ5Fum3FJqng6w+xgPUX0OCNpsDBcWHivU pRLK4YJjPnuObYgeocAO14uyvlUX3yOygi3G9n8UY4wc+vbZ737cqEkntlVC7kvg rYBJw1xxY6jVZe/1llXcAT3qBp7lbDRtKlWH+K4b6p6ciWlSQzVgWv59xlCZ5ibB e+okFsrOGnUdIMbhcdE3tmPeOpxKlGWYdzmAmbIxx/ox51+TTn7ABiXlQ0BpO5hD DtFMBHm7ZayYrwhBguf0jmQPNbbZZwSLTZEFgqt6uw7szcP02GLrxWW5+yF5deKF r0zN/ul+GYv7xWEyaPhAtQ== Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11021084.outbound.protection.outlook.com [40.107.208.84]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4ejrbram9w-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:22 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Tayj4DajvbN2lW3ec7JtPXYBDtV5l/LhVyuEbkB4DF7LGoskRCNzmdBWwwOpcytmqepXKGmE6hGTpY2aEhRD6flQsRIRe3m5YafOOncNKJtcc20FfpYfA9KtiqD/I8dFvGGnpRV3eSZ2fSq1LABimxOMZfPak3irsetUBNde2pqT/QrrCxfGz65kHIdt1b+ozkR2PyPBu+GD3LRROaaELn584mSs10qQ6kRAqZIrZNz2QFjGZXpTPToBnOEC6Hx/qY/caqJdjzR2G8tmuwrI8+lTsCx8JiZZt8mcP2k5/gWwboSpGVYiX8EKtNpmLGKP4WRYR1LAw9sBRevMVypgQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lPUi5F9rqZ5QXVcaxg7DXgriPROLgUU85g3NVNUtKKc=; b=vsaN9deNZhoN5pzMgdx0BEsZqD15vzOozMpHmB0Jw+fmQYm/x504UKAivLVdBRMbhfut68vKQOzkzbu0geZXKEp3oKMe32G3nB7TF0dBXeOKx5/S8eCY1FHSN8aPNx3tJzm7OI02j/b3EsiE1vcIKj6Orc9gat/0M6ibDgLvmlyQEB9WZvyi4EiY+e90DxNUIuyL6Y1EX31HDjFtnMg6koJJpTg8xJdcO/SvVzUOsJsjKXgbcNs58e3LcL4hVVHAp4oyiCuP5+p2xFA9Wlkp1AcesByxQsiUZNRbXIPlYvkddO6eXx7kxKDKHZjpoppoejr4igYY5gIEb5Gewi9uqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lPUi5F9rqZ5QXVcaxg7DXgriPROLgUU85g3NVNUtKKc=; b=M3V60CnwnXE7Um1sVqujQ90vQwup+Xa11+bWrKzjwE0mK8VLTjBRY3CR9hBnu1dfciDZNS1lRUDj6lK7BI6UpLR12MYyM3xsTQEkfs9/3rClDM0JNMI43kLEqiqKgaNoSwWYRM0np8c4x6eENzc6stRBWSxjEOmWc2Lwf1SDqao= Received: from DS1PR02CA0013.namprd02.prod.outlook.com (2603:10b6:8:452::8) by SA3PR19MB7586.namprd19.prod.outlook.com (2603:10b6:806:31c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Fri, 5 Jun 2026 08:48:18 +0000 Received: from DS2PEPF000061C6.namprd02.prod.outlook.com (2603:10b6:8:452:cafe::28) by DS1PR02CA0013.outlook.office365.com (2603:10b6:8:452::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.9 via Frontend Transport; Fri, 5 Jun 2026 08:48:18 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by DS2PEPF000061C6.mail.protection.outlook.com (10.167.23.73) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:17 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 43F6340655E; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 18549822548; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 07/10] ASoC: wcd938x: Use new SoundWire enumeration helper Date: Fri, 5 Jun 2026 09:48:07 +0100 Message-ID: <20260605084810.1575539-8-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF000061C6:EE_|SA3PR19MB7586:EE_ X-MS-Office365-Filtering-Correlation-Id: daf74459-77c5-49bd-6b48-08dec2df3092 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|61400799027|36860700016|82310400026|7416014|18002099003|16102099003|22082099003|11063799006|6133799003|56012099006; X-Microsoft-Antispam-Message-Info: /rJFvE7MycXlRR8t68KzOac9Jn3BhU/AzOTMalcHOUX2bUMdAVbDxfWxpXhGHFmClNhft0ou/x0RFV3tczWJxdUlgSFXjSM4lyFl70eABRPfdpw+JBknA7FOFCo9H134DNEMPF53/r1C+NJIIdv7KhUXPADiv86kw4YOodDk9oRs4R5cyfX8z104N1jW96vjILewcYZ1a/gBoW1ThrSg3UBlEcl/xaq784OQZW4W+sXtHrWDQBqSxK1Oo2bwfOTt642T3K6gAMDDf+BC6rkVhAQFl/KqTSbkfgN8JJDEKIROm4Icx/G1+JOvW/pFv8+rezbvdpo3Ygzx4J4fTCNFtXHeT/kEl/ZE/eidkyDbpPtT57RqsPo7bfewNsPFe+8NKPajK393w+1U3Pk1Pz1DI2YsduQw1giAG7GEJ631KDgCxHdOuKjiy/C4Bal0EriZ6084oIXzyOBCuof6c/PzNdv7rx4MYj4u5i5n3Rrw8tsDRtCsdNDqSjkkYCGvnzqwjgZlnuLAtY3hNcmsv0AzPvKnDWzcRS2CA8OXOXHWmyiFXEkvWByBshNeXJZ2EtuqWGtrTWYEGEPUIQKW0B55eO+D1LtUaQEdi1PHzzcPiWt0t+OfD+OMQo51jnB34OXddZMH+JRsURXs4l7KkApZnaGexT/rzpQi1Y0TscctoK6KZX0k2rUnIF3VWns0lHCRCDaQmUjFw4XaYhEyr6V14Y7u2aUQ1XrG1RUMW0JJeHA= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(61400799027)(36860700016)(82310400026)(7416014)(18002099003)(16102099003)(22082099003)(11063799006)(6133799003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: S+VjMYUDBf+Dc/r+IF7DCvnLg5mDYBbF5g9xdGMLB4Py+AZ98mKQJVfQSbBTiyQrg4r6WUh8OETrCBf85d8DvZl4tbbvSuhPXvOa0Gr2vDmE8LrwBlxrWatrRgv9aSjXvog/HO8tOKLyjSR58AHb3dC4UZdeQ3Lfm6xcsjTAoTpAgQgIJTBVpdhkF+BfhkC2fZWIztmDNIaz7x3qtCRNt4WRhtcsVkIfsYeYugIanPpKxXYnsjITMD2iDoJwkFeqhRexWPu3zlvaImimMOXEXp9ypqew6QCQ2Q6MavbtnKuGD+ZuINnCJ03gnlO4QTXaDxvz3Be9DgYYsnTSce/wQgP/Wmh/Mm1yVpnyjIddvTby4uOK3vMHT34L+/xKXeS6w7Hc02bzkLzfrxrML+EIsMw/uJ0rtkqvSyBzvi1KCtT9LCiJ9ANrf9ihHxTgZ0/y X-Exchange-RoutingPolicyChecked: nv4Rux6jT7cbHf5zqpKoPE6TrsJerscx9zlx23iSRT8xNTqVrUsOJSmkcpusU0f40RIz92o8zRs98Coay3CZHyoJwrwDnvxLmdCoWB63C/fqoYL35d6wbRrRnI/wxpWe6Dv4NOonPe1z7TruFB6c4C+wuLSBOmlfb1dcXI5/xTYvmEOtS60xGdWEuXp1G6th96n1ZM2a+oPHkc+B3Nfy/0MpDJbr+GPov6EPJ86O7GFTZLKHZq1p6USx1NeDPm6W9JHZJCd67XvGtey6vO2o3Pd4D0oBDS6EC5He/Ei2C662z/ns3vRNq4/XH25cFp1K0hthlQeoO6zETtbiijtfPw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:17.8868 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: daf74459-77c5-49bd-6b48-08dec2df3092 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-DS2PEPF000061C6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR19MB7586 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfX4btoDrTx/I9O RXrb1QM46JNT7E7WJpw4YBLYlfvySLysFJ7Td4mBzIHJqy9b2Y4N4jdfw4ku3CGNNslWbmETfgZ MYMCx2MTmsswlBY+7Yc55UrevbPWW1lVtniS4uYKkT1ZVUV0OfMl+GNyRm4lccnUHgqAyDrnOzR 3+/4xBgIzcSLNCxLfI78DorDpkp7VuWFftGyR/7AOJKQ/MLT09an+RLDU6eeH+GXJ/6MX7ZcGTo iVOIRbWYsoGF0h1rM8p78iNpDnwhTRPoT6Cge0nQLggY4unpSXPWZj/1BJW3j+Zo0rFwdcqdpH9 WI3foLqFkMgQ/sLB8veugyGVVouXyy4kuvYeZZKO/8ZhSjbb7rUEkLf5hhsXTvUmeQjf3A74nKz c5yYIaQIdeGNZifw6bBQsj/YQ1X81KtUarqLBQG3pSynSQ5iRv8cD0bnuWmsb7bRZPrzT8jCbD8 b+ggG4zNmq0569vuUcA== X-Authority-Analysis: v=2.4 cv=TZimcxQh c=1 sm=1 tr=0 ts=6a228d56 cx=c_pps a=0iCLHuH1wF6tAjvkAzcOzg==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=JVHJYPckqUcmq-FxO84A:9 X-Proofpoint-GUID: iwNCz9m2XISImNaM3ryjrQ-_SBp38wJF X-Proofpoint-ORIG-GUID: iwNCz9m2XISImNaM3ryjrQ-_SBp38wJF X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- No change since v1. sound/soc/codecs/wcd938x.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index cb0a0bfdb6e32..c69e18667a85b 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -3016,18 +3016,13 @@ static int wcd938x_irq_init(struct wcd938x_priv *wc= d, struct device *dev) static int wcd938x_soc_codec_probe(struct snd_soc_component *component) { struct wcd938x_priv *wcd938x =3D snd_soc_component_get_drvdata(component); - struct sdw_slave *tx_sdw_dev =3D wcd938x->tx_sdw_dev; struct device *dev =3D component->dev; - unsigned long time_left; unsigned int variant; int ret, i; =20 - time_left =3D wait_for_completion_timeout(&tx_sdw_dev->initialization_com= plete, - msecs_to_jiffies(2000)); - if (!time_left) { - dev_err(dev, "soundwire device init timeout\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(wcd938x->tx_sdw_dev, 2000); + if (ret) + return ret; =20 snd_soc_component_init_regmap(component, wcd938x->regmap); =20 --=20 2.47.3 From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 367483FE667; Fri, 5 Jun 2026 08:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649338; cv=fail; b=emoTqTcYY6ctZrqFYP4NAjhMvZOsa5NvEJUJsiKbZeZH8cqdu5YbhYnHXxTaMKNxv7baDwgMd3o8qwZkoBpwg5BQLLZYNbqDuJT3Zon3wOqgXoRXnwZjRTyMmtn6kOu0i1nUqeqFM3gzUxca3aHnYVj2UBPBhzieIh7wbUBgIFw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649338; c=relaxed/simple; bh=yyoC8NH3IiYaiYxVhRKVfjByziTA6sOMAUpYC/eaWF4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MptQplDYrFdOEQ78SzXyaQHjaaTb/CUyS7saVlwScAMjNMrHjAO7vKeSZZN394vK5EeCDOgI/0IsfIfTAL7n6VErD+7QHvWX42IsAZUid2vmZhABoGgHsG5seoa18Oa+ENsmoIHcZeguq2INu2FLrbiiToP+7I4TIgECnsk5RSw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=neT5NhTZ; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=NKlGto71; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="neT5NhTZ"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="NKlGto71" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65500j5V2067866; Fri, 5 Jun 2026 03:48:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=tfdWQSD8zcXwGiagt+atIquGGs3vJ7rkYX01VvVnZVA=; b= neT5NhTZZ5V6BqAbJcdf/4MKDf9AJnyb+ITuTN3/xoykVDn+b9r+nqwCozNlhc6G SIOMC+LItq5ZnNWmcSxBFhsnAeiW4CznIoxoC25zTuuzpKIWgTU6nVjP1DqzgMhq 7276oHhiRJMjobzKITFbIdQlERIG3GsEl8O+BlGfwEO4G9hDtFLmbaPJDz05SSZM 0P2jnRXGbE1gDCGdlktBs9SPplG06+8XreuZq8jxSSgjJShYkOL6qqmx6/pGF4Q4 v5cTzJA5wBJw6gaWVMlfFx3SrCNbz0LBwYy2j7Q5cDoQ9hnrbnV5MPy8JiEOnq5R kMsgcWQUqaoN0TVVVX5OXA== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022110.outbound.protection.outlook.com [52.101.43.110]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4ejrbram9t-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:22 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nAh/eaazlVDpR6L+S7mlRnhTc8EOsqEbDQjQ9Z1zE2ZkQx/okkbCd8sjTSu7N7A+7dTVO974Sk7sDMn3xe6rcpgAKCGqCncxhjNcdb4rRhLy8yfjNOCkIZbDiGm2Cj+MBOVGeuttfZa9UWqTgh/I1jf0tgoJgLFLBUTv75PgaNi1LBUwiCTfHBoRMlxPNl1rp9cgZmVatJ18dRBKbaI+bYgsXFlT4IL1I7CFMzjO4BngnNVYJg4kYpY4XpBmGI56tfyG482DgE00YMIXZhxaVZfsHV6iCXzukYeAu4FUqfovZQcTrL0uLVRSvUGQRnlIpBpcgdvlycTl9tIlng7NPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tfdWQSD8zcXwGiagt+atIquGGs3vJ7rkYX01VvVnZVA=; b=j05b0Sp309VSlAtF70WQzAwH4JnpLk64anjRpzBkRF7u/Jce1fQ/UxcMIhu1X9+rUmLBt1td9PjmUnxBdmBEVar1HxOJdUTygO3bwgqUzIjvh9qqr9c8vpW9c9sJjwn9aPvzhonfY+2GMRHrf2ejoy87i0wcs5W1zI+BkIcTQcYH8hwfk8FG0t8IX8X6Jx48etkZjdfdL+T5orE+6Pul7/0RFeQyFOttOHB3wcGfWIYMz2Cev/T5SiYTRP1GHHvSbLWwQugTp16i0WkCE+ayfGbbA2j95SANPspGB1gVTC6hJshTjb2sOH2R98LwMa6sC96Y5FESmdg21mukheKINA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tfdWQSD8zcXwGiagt+atIquGGs3vJ7rkYX01VvVnZVA=; b=NKlGto71oTnHdS4gb0pbgkz3WL7p+bTMRsr+K//5jb61HWTCCMJLC7xXrhICUOtG0O1zv1A5OhmehVAA4q3+XC3ietp9nZN0wgyPYDumYL4sdJz+TRVfxCi+Aj0TYHsuOpvbv163PSaQaouDlB8T/XE2ExaQYJVYwbQIm0NVxrk= Received: from PH8P220CA0028.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:348::6) by DS3PR19MB9200.namprd19.prod.outlook.com (2603:10b6:8:2e3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.8; Fri, 5 Jun 2026 08:48:18 +0000 Received: from CY4PEPF0000FCC1.namprd03.prod.outlook.com (2603:10b6:510:348:cafe::4e) by PH8P220CA0028.outlook.office365.com (2603:10b6:510:348::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.9 via Frontend Transport; Fri, 5 Jun 2026 08:48:18 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CY4PEPF0000FCC1.mail.protection.outlook.com (10.167.242.103) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:17 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 4299240655D; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 1B71B822549; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 08/10] ASoC: wcd939x: Use new SoundWire enumeration helper Date: Fri, 5 Jun 2026 09:48:08 +0100 Message-ID: <20260605084810.1575539-9-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC1:EE_|DS3PR19MB9200:EE_ X-MS-Office365-Filtering-Correlation-Id: 37d3805d-e483-42d6-d27a-08dec2df3085 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|61400799027|36860700016|7416014|376014|11063799006|6133799003|56012099006|18002099003|22082099003|16102099003; X-Microsoft-Antispam-Message-Info: tBAKOuRmnz7Z6stZSKgxXbecM/5KBge2csgQMYlepog7SHs4RlkGWT/+QVyJuk506uh/jEjOd1oUfWUJQH4lyH5ZK4FrMlqBbEbBf0oAnyEW38ZA1QYgpRj5kuHFGmOypx0j6GphCuAX+CB7mATcxXUrwW+AxsmbAHmN0l08sFur8FxKD1ZMdBKcgGSBbKkeca62I3xLF/QXXsMF9vsSwt84zKcEijMnkh3xWAdSM8mkjGb+Or8U+s9tovsrWU2HMbR0OYdTzQUkxRFgXAsUcRp1AMoBGNtVPCk78IB3wrWb4PhqcFCeF0/CodWk+D+NJJDSAGjdgGb5g12w1aXUi2lRQilb7V+feOURsNh3xHrqvaqvKr7LRZDXghLUxOdMa1hBxl1BWiLRDNla9T9KLQfeJzCtUHv6v8US6kbCVi8OMN26OUOEMLTKqj0JfWAvhHpz80wktnD96D3Q+0NgeAeTxS5OU82nP8iC/hT5I5O0yEMj7H9hbDfI/FKbSvNErF7Zd6Hm9Y4r6uB1ksa2cBKTJtTUnqBxWR8zHoudS4HhnVcJwWFKCYNbxBwoR6X0N8S/kCVer7iviWTKX0+zib39yndVnCPgByK5XGDnHcHcg0QtpXeKgMY5Kdz/3/i4/OfbsmHchm+a0ksoKeybpeHu7FaGaZUILCWng1YQA6InSz7DXWWuNVdZ/usBRAkI+rN/4emUqxsW9417JuQ+DINGuvWge7NbDAAYy1LmzVk= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(61400799027)(36860700016)(7416014)(376014)(11063799006)(6133799003)(56012099006)(18002099003)(22082099003)(16102099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 44HdA7IRF3B1utuGvnP5HFE6TNyVVCQJu1OnuJTBBkOeNtqVO0k4Ps8BKkQYzqUkjOeDczV49/HJ6TRBjcDvd+3b3MHOYyH+yjNofaH0RYVu1OQJln0jNsZfjj2tSk+n3kwn/TBjb9G4OFuWaNUQ7ejoq/flgwNJnUtXc0xxDeI+OMvD1tQ4PeRzmyNlCWhTBwz1sChZPdQjBEq69XSYWyfLil7Oc96H621+N+/q0+7w7InD1dzcy7BWrKNvmOVLWek0xQvvevQo1MxNINxDytopiIm5bYAzMPaamDgVNfSdRzZyio1Ae6uLOoeEMk2qQze+fmnnz9H3I3J0MwS6lH8zcODE91pF1TOI6TJ/BoomHq3isPjYPAIp4nwsvXX4j7BPFdJpOV1PiAINYkDyfGgUpMMpJBtAa3xa/P+S1lcVTNP8EX1P2CdXx0S58jw5 X-Exchange-RoutingPolicyChecked: Hd2pwM3LUAyExJsQZ/90uj/PM/4lsSGb7JA5jYOHP5HEr/NuwmNm++nto52pD7jRhsSeOFDYb39v7VfWtdHzV+dsGIrkqr/IB9bPTJTwb8SkeKguuXY32yrwbrf6VN4khd+f3HV6LACsTDKPI7qTtpV+ZsRIJUSH34Dg/ARp3QfYifxyssPnq1kk+wr5/Gu2VOh4LSm4rOBjjACoMFK107oM/j2niZUs+Bc7wMps+dIKytq6Csblr0LHn0Ze1PNIsG/E1Pt4td8e8KyC5NRe9lYUOOud3kd6BsSXHD5kuCi7CDtmCCb/OHI3vFS8enO1k3ORFgeL2ZetHkobzlBDvw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:17.7809 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37d3805d-e483-42d6-d27a-08dec2df3085 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CY4PEPF0000FCC1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS3PR19MB9200 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfX0rc43Uew0H35 U+yuitNZyBBrLNv7DRPOqMx0hbs9wy3cDRQIW/ikBeshxlwiQbAfwq/NKaJ8mUY4/BMNL0nbjW9 7VqOfNTZPbhZELQ7UsC+kA3S0OR1Bo3D//f2bGxRUZmYAemXDeV0cHA5hvaM8s1FxNASgLZ9m1+ o6fFsG/wfCgMUOmXYvNrCRMPbBNCmREn8KuP0V41lebUz015LUczQ8kGPtisRnXqSaKpsQiL+d2 0eWV2rm+MfNSeD9K6m8sBDAyyiZv90rl3IxyoUhRvFc/nBLkDEz8dq+bmfQZFPhSCRuua265wmq Fbvy05zN9vKsiu2etFEs+n4yjMk7kFYprK90VDdwpdXGOu1r8d7iAHMTTRQWkSvJciD2ZG4FNR7 w8kyF68aPbSDZx3c60/gu9KfKXAQVWSYuZEmoYEzAKxI8LJ6y+o0aREm621iO5r+ThHxmTuBgly cunhtmPBzjD5n1BQn7Q== X-Authority-Analysis: v=2.4 cv=TZimcxQh c=1 sm=1 tr=0 ts=6a228d56 cx=c_pps a=R5lJJwLUw69E8voCr07FQA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=jMxjxLXPGdIgYIqNa_0A:9 X-Proofpoint-GUID: -NKns9vwjA8LFskFddiWgohMZ7SdJNx7 X-Proofpoint-ORIG-GUID: -NKns9vwjA8LFskFddiWgohMZ7SdJNx7 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- No change since v1. sound/soc/codecs/wcd939x.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 01f1a08f48e65..010d124667224 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -2968,17 +2968,12 @@ static int wcd939x_irq_init(struct wcd939x_priv *wc= d, struct device *dev) static int wcd939x_soc_codec_probe(struct snd_soc_component *component) { struct wcd939x_priv *wcd939x =3D snd_soc_component_get_drvdata(component); - struct sdw_slave *tx_sdw_dev =3D wcd939x->tx_sdw_dev; struct device *dev =3D component->dev; - unsigned long time_left; int ret, i; =20 - time_left =3D wait_for_completion_timeout(&tx_sdw_dev->initialization_com= plete, - msecs_to_jiffies(2000)); - if (!time_left) { - dev_err(dev, "soundwire device init timeout\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(wcd939x->tx_sdw_dev, 2000); + if (ret) + return ret; =20 snd_soc_component_init_regmap(component, wcd939x->regmap); =20 --=20 2.47.3 From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7337F4ADDB4; Fri, 5 Jun 2026 08:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649344; cv=fail; b=p5anHdHdjLtoJKUdNT2Rcmc4FRFv6WltMwoNRBJSWteMKcGKUMUbiEWb+nmUPM9SGRBAY0aZmFt/KPe0X68lG9LD1tssqcCgj3mNZTIAuKgdScpLNLOR3ytt8FpoMYWNIuF7J1I1AsP0pWez9HdJDx8ch/6oaNet88TYDH9JYKM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649344; c=relaxed/simple; bh=CsyyGzpJ9AkuGSwk6a4aWe2fa+39tjUcdXD3r6w72TM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q+NsbCa8Kmy1ChbIg7VSo7jHVzdELnL7UTDaF3IjyXfupdRtlVHPy9NYvllgpn7WBgbchRSTTO1i8cMrpT2GDtOeh2bCRJmRtw+B5hpFTlQPiJW6NZFudPKN4FeHWjCc90hW8puI81kG5jw8muwwC9sVhoK5H7ewYhQpq8lkBuw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=QhxLVSK+; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=bgw5j6Ey; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="QhxLVSK+"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="bgw5j6Ey" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6550JRiY429440; Fri, 5 Jun 2026 03:48:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=4WDCmWoXWL0mSKvv3ezUJgLA1Wrex8PGAA5iycP7MRg=; b= QhxLVSK+qJcHDUp4zN54kDPx1WbafPD4I81LhwcYDTqJ5p4Xq5AoO4Pwmt9oyObf cScrtvSSp3yQFQPcAcNuW0jRjqVFoIGBqCTYl+MvFN7SPyWcLNJdd7NBEc4qYQ/Z v0qmBn79VjFzqBbkwz4wlixrghiOZERBL/3WLrShtDW8k6wjoHwZeTluz5FeXpTE uAfL50UII3GN7R8P2j/I/+ZoZBOcSOMf/qMDoEdTHhSFHmQTy7H+3ol7yMgrjEot gf0dwEj5ScIPmIYF+r+HUqqoj7xEMAE0iJ0CsRODnyO48cTcOFr6oJfTgOwJwnfY sBm9WzIr/7tvOhdwLcX97w== Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021083.outbound.protection.outlook.com [52.101.62.83]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa192ja-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:23 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BpoBheyglDUvVUwCdM1ePzFB5nSoui6k/epKpUHYWJGXvHkmEmf5KFDBqUeieCUAbHqv0DzeS/+Wv1gfgRBnxEWGaQP1K0tRceIPgG/OO0nLmGonDJmJNGLAufcjJFIX8UQsc4NqIfafalx0L18+gza/H6PXl+ktKGKz3GganZPi6rBJ8iI6DsxWZFd07wwhOILHKN96E60lgq4xwwzY0EmT4qG2yKNTxMeHiYEG5Jm8G1MZ6sXQ46NvGKlm5lzP4WkaT95Pjntxia6g96TmO/9MFBKVN8kZxZWi6RDNpLO1mz/LaL8vmAMTrgFmKlRJPfu+ttxhOL6a8qHfvnEmQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4WDCmWoXWL0mSKvv3ezUJgLA1Wrex8PGAA5iycP7MRg=; b=rL4sOwFUfxh6qgXzaIKqB5h0y5KeESDyB8wePJHjlvDKsoo6W56iuduJNsI9d9OkNvWw5ALVGQpievsl1Q7CgBptsGuPH8jPDXhJF9sfK4Ga9bvU3qWcHnt17oGL05vhMZ69Pp3+PccDi3C3aKHTCdeftQWwCHcymilKo2YOmVV6AKG9gC7ly8dpUs5/pyWV70khtMAY/jNrbDwRMCmthFm+puiHXulNZ/m5T9KOTEZ/GRwHv05d//zrM3Ip6YAZvkFKAw9LK9K0OmzCPAsI5RafUsrlgO5fusvOriEvfGfyXderjGYmvlVsZbHIUY3xUgpcxvDcVNg9ZqE9I3oKoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4WDCmWoXWL0mSKvv3ezUJgLA1Wrex8PGAA5iycP7MRg=; b=bgw5j6Eym7nQ4SCBeU03wpUFTLtge3X5K+ozA6WUqnBGvm4AivsALYyVX5CokicL07yBsGqdRU+yf2VZYGYNLEjHGLSTzcyjNF+EsVUENiViL6ZC9n31EmwOMd4qXiHYehwTmusxl89206oax1jq3kfDWZ1OP4Wiz80nu0YxLGs= Received: from DS7P222CA0022.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::25) by MN7PR19MB076263.namprd19.prod.outlook.com (2603:10b6:208:5f0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.8; Fri, 5 Jun 2026 08:48:19 +0000 Received: from CY4PEPF0000FCC5.namprd03.prod.outlook.com (2603:10b6:8:2e:cafe::42) by DS7P222CA0022.outlook.office365.com (2603:10b6:8:2e::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.9 via Frontend Transport; Fri, 5 Jun 2026 08:48:18 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CY4PEPF0000FCC5.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:18 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 45795406561; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 1EB6382254A; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 09/10] ASoC: SDCA: Use new SoundWire enumeration helper Date: Fri, 5 Jun 2026 09:48:09 +0100 Message-ID: <20260605084810.1575539-10-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC5:EE_|MN7PR19MB076263:EE_ X-MS-Office365-Filtering-Correlation-Id: 69925835-afbf-4ce7-5c9b-08dec2df30c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|7416014|376014|61400799027|82310400026|56012099006|11063799006|16102099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: B1E5+rHIRE4IkEDXL6zrLPpxNb77M9w1zwByUD9gt7NGP9zskCuh2aUMI61zdM9bHWL3yxS6GnGZLGYhtI6iDAIRWELzdUPpNUo5I/ehBGpoBuCwYZYR2OqqdJFT7pFDJSJSdxtmohPb4NXvYXLBaAsY0EgQUxLt3z/2fYfdtvFxgPlhteQ0akWpgWqt/DkhDOP+QMOYomwn7k1XGNS3n8RKWNORjQQZQtYAasDWn9Pyt0QtLs2bacdzFBBzCuvOOXDy9HjDI6XsjLBM9Eo5TGAIbycyI7exNMVzxX/KKN6UCyURm42S9lIZ96iG5Crwf7XHMc3KoiQDxPJTrDWKQyj6JM5QCoyyCP+nOxTCcE0+9GCPdTnCBu/0nbiy43OxrWGZcHBF9uemNRSyE0f9H68GSAIdTzrlhoOVngYB1a9M1a6d9ya7yyv6Ji7xF6ICBlbfftUpGUZ9nMp9dTicjjkepN62LltI3AkaYsRYOXHQimaMJ5Ct6YBcQ6JKEQAe53KTYwQcWRJuMgEeEc8LMVuRxrIlG0sDHpppKoHovfJeyKqttpvxIAMibYqySOroskgqKFVgryzmjisKroUE40X/pRRj8NfEbkXNIfXIrvXrz09iNrCv3BIID9C75xjXli0HLazwdAPiKlDTzd6jrnZwRpjDNtlVrCpUsnFi3x/Htos9MEbE/nQ/cMMI5XWLfLa0sCzid+72g3b3YFXVR6pcqusBw2ComgHccdk7uqw= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(7416014)(376014)(61400799027)(82310400026)(56012099006)(11063799006)(16102099003)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mv5/zdlRVSK/W7J1oogGSpGtEreNn85xZFszNq4SnJMpga7C6x1Dd5TCXxBHYi5pt5AuZfHnN9xEraqrQ/est95coudjlMgJ9mtm1WwEoRtXxurycmeZhsGtJC6zWjr3JXN5QOxsi8mM3pS+bDji49TrR40AJsx1LkcaQwAWN/7qnp2+fPSAorT1h3qve3a4cBDbxH3hqehCFXJ40fRTS5lEMVqPstI2m2veBeZxyoYd96BUQY7rUBsK2nhbPdu9Axu3GxqMPN3nmzzONGxDIhK8h9Jkmfw5UDrG5/U2r6VVmBq8yPQWEAwNp7dVLu5VoJ5UT29NIg1KlexCzPYMgE0TYnAomEIDWfbh2sQkisOk1FBaiX/RkxUALlPYwmvd51uluwAkJT7llXfqF2sLXV4FqJZQ7joL1X9dbHQiSNpzJbkF8Tk5IocNMo59f417 X-Exchange-RoutingPolicyChecked: kcmah+K7wYF8shhaDjx8LDYyOORCKrg2QGK3ogS24JH0fqsPGzeKxS0l8E8Xq3t5gjKVLhE9i5yzFmdpMpQuqCaeBnBQ6gKtuZoSUX0BGKsPTqBNtB2ST3Zx86BAIZmbb5I7Oeg19+GFF3Kj0TYCmSbX27bU3wCVcTblJbvGKYRTOd9DiqaqHavOVj9bVhkYulGMZJeSMTMGMmeasDMHC7dBE8AHIBB2gBXiByoa/5F1ll+HFTFIoe/co5rItaSwVL/vQ6uXnQXPF6jInbaaogOYSUWRHylVBuMhgLZ6Z5ZBTT8ROZ5KgnnxZi2pbgB4R8gOC5/eUfForpJMZqVzEw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:18.1968 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69925835-afbf-4ce7-5c9b-08dec2df30c5 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CY4PEPF0000FCC5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN7PR19MB076263 X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a228d57 cx=c_pps a=f6P8eh4LYcQUHlEOLA+94w==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=RJn9l5sriXOQfstplqwA:9 X-Proofpoint-GUID: TB3DCOx_ivwQoDdeQPo4_hPh5hK_uVTd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfX5B9aWdr1tn2u uj1rsj7ESDPGcW7kfWwglypileS77CwDRMlxsGvlZjS1uqmsygyb5TSbEBVO2EqRRyfqjvRoqYv k1h9vyowHChWEO7DCKDP6G0ZyRf4djsb/NTWfBG/W8sqbAwFNXXJLvhoZc9clQ32/YNtQlB8djJ WwFBY3zh6TuOiF7zANzfNKBae8Jt2gZit7mf1YNsVreDGNIfYRmVjBDGdDFrqR36toUZ7Fr5xdQ YwZpOIMSDwN17PI0kXEpv5LKKTXMR6ornWIQsjiwnp30TBuL49I2ggH06QWSeN6bh7WiTXhVvc9 YbzPNHmA8rrxqVEBc5dvEGP2vv6fUc/+50X4OnAhqP1uX5ixG71dWaE9Ne02HPKABRDe/2sZ+a0 A5MHlKG81Cu7A+GNS+rercgArqux+rhhESrn2GQguF/poDYdD9q6WLAqHOFhwQoVblmtmRqZ5u+ F8gsMW1ovPWpuPJZ3Bg== X-Proofpoint-ORIG-GUID: TB3DCOx_ivwQoDdeQPo4_hPh5hK_uVTd X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- No change since v1. sound/soc/sdca/sdca_class.c | 53 ++++--------------------------------- sound/soc/sdca/sdca_class.h | 3 --- 2 files changed, 5 insertions(+), 51 deletions(-) diff --git a/sound/soc/sdca/sdca_class.c b/sound/soc/sdca/sdca_class.c index a6a3da8de4371..6937a91ddfb9b 100644 --- a/sound/soc/sdca/sdca_class.c +++ b/sound/soc/sdca/sdca_class.c @@ -38,35 +38,8 @@ static int class_read_prop(struct sdw_slave *sdw) return 0; } =20 -static int class_sdw_update_status(struct sdw_slave *sdw, enum sdw_slave_s= tatus status) -{ - struct sdca_class_drv *drv =3D dev_get_drvdata(&sdw->dev); - - switch (status) { - case SDW_SLAVE_ATTACHED: - dev_dbg(drv->dev, "device attach\n"); - - drv->attached =3D true; - - complete(&drv->device_attach); - break; - case SDW_SLAVE_UNATTACHED: - dev_dbg(drv->dev, "device detach\n"); - - drv->attached =3D false; - - reinit_completion(&drv->device_attach); - break; - default: - break; - } - - return 0; -} - static const struct sdw_slave_ops class_sdw_ops =3D { .read_prop =3D class_read_prop, - .update_status =3D class_sdw_update_status, }; =20 static void class_regmap_lock(void *data) @@ -83,24 +56,6 @@ static void class_regmap_unlock(void *data) mutex_unlock(lock); } =20 -static int class_wait_for_attach(struct sdca_class_drv *drv) -{ - if (!drv->attached) { - unsigned long timeout =3D msecs_to_jiffies(CLASS_SDW_ATTACH_TIMEOUT_MS); - unsigned long time; - - time =3D wait_for_completion_timeout(&drv->device_attach, timeout); - if (!time) { - dev_err(drv->dev, "timed out waiting for device re-attach\n"); - return -ETIMEDOUT; - } - } - - regcache_cache_only(drv->dev_regmap, false); - - return 0; -} - static bool class_dev_regmap_volatile(struct device *dev, unsigned int reg) { switch (reg) { @@ -151,10 +106,12 @@ static void class_boot_work(struct work_struct *work) boot_work); int ret; =20 - ret =3D class_wait_for_attach(drv); + ret =3D sdw_slave_wait_for_init(drv->sdw, CLASS_SDW_ATTACH_TIMEOUT_MS); if (ret) goto err; =20 + regcache_cache_only(drv->dev_regmap, false); + drv->irq_info =3D sdca_irq_allocate(drv->dev, drv->dev_regmap, drv->sdw->irq); if (IS_ERR(drv->irq_info)) @@ -206,7 +163,6 @@ static int class_sdw_probe(struct sdw_slave *sdw, const= struct sdw_device_id *id dev_set_drvdata(drv->dev, drv); =20 INIT_WORK(&drv->boot_work, class_boot_work); - init_completion(&drv->device_attach); =20 dev_config->lock_arg =3D &drv->regmap_lock; =20 @@ -290,10 +246,11 @@ static int class_runtime_resume(struct device *dev) struct sdca_class_drv *drv =3D dev_get_drvdata(dev); int ret; =20 - ret =3D class_wait_for_attach(drv); + ret =3D sdw_slave_wait_for_init(drv->sdw, CLASS_SDW_ATTACH_TIMEOUT_MS); if (ret) goto err; =20 + regcache_cache_only(drv->dev_regmap, false); regcache_mark_dirty(drv->dev_regmap); =20 ret =3D regcache_sync(drv->dev_regmap); diff --git a/sound/soc/sdca/sdca_class.h b/sound/soc/sdca/sdca_class.h index 8b63e62485e64..57f7f8d08f497 100644 --- a/sound/soc/sdca/sdca_class.h +++ b/sound/soc/sdca/sdca_class.h @@ -30,9 +30,6 @@ struct sdca_class_drv { /* Serialise function initialisations */ struct mutex init_lock; struct work_struct boot_work; - struct completion device_attach; - - bool attached; }; =20 #endif /* __SDCA_CLASS_H__ */ --=20 2.47.3 From nobody Mon Jun 8 06:36:10 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A65C14B8DF4; Fri, 5 Jun 2026 08:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649346; cv=fail; b=jDcFYACtAOrGuOv+Cvmk9lwWmk9tmxRbk8rDGa4bQRPErSIGmzpnDl3gWt2FxI1CWQ3H/4sDbXjopr17ZxWhu4gOSqXkg/BP93HI/9HMNCNbdjp5Ef2zriIoH+vIK906dYxo7NmLT4mQC0gUeFghEbhRKPdRr7NDMkGm4b41fHs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649346; c=relaxed/simple; bh=YxiqkOxF8Rc5M4MX/F0o620yVpz/fl1cAypiXVLQBGI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=abKOV6M/KWU7LjiZfSUsTrc1u7UU0W8vsgNy7ecjWOT8zvPxAfMJ7g813Je0X77M+JRzH5LTRNw5nYh5JyuZqhMVe+xz0uTxSw7oov65PYduzEb28JsKb9kv3Ou0SLz/SwaPAoyTNJvupVDu5jpIDrdH3xpZhr25giKLip4qFQ8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=ReeRLI6R; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=hMkuAHZ/; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="ReeRLI6R"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="hMkuAHZ/" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6556T4pB1030980; Fri, 5 Jun 2026 03:48:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=6jzJt+jVnms5G/ETk8HgE/6mOXHM+20uSGz5SVp2uwE=; b= ReeRLI6RTgy/8WU4Darf3+cMkhdUuxCfDvL4vD+KszFT/K6hvfrdrvopX0XyUQxY Nsq+ER+RNPPK77Np/hq4Z6WhwrLKS/RCHN2ojwtXGfLy0KSGnC6+ZMXzL3+XRxR+ MROO1NspAXnCfAQgqvsb2D5/SC1DKY3U3pr/HX5kCRZ7mzmE8RWQ3AuqFy1TSgf3 FrKek2ZsMZNlC6Az/lVTgvdDhlGtA/iNsdxI4YxEaJsXB64SqpKRThjqCEnY+C4H olkWumy3kV4Vidn1Y5aSvi27AF4G1ehzM7Vbh2ZIjH+e8TVRArEWcEcuaqST4Sbh dddm041il4m1gotM6SjyGg== Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022123.outbound.protection.outlook.com [40.107.200.123]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa192jd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 05 Jun 2026 03:48:24 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Lmpbl+2y3+snYZMHm9SuPNRvbMILUkRuCd+cHzER7daGisfI6UMh5csH2M+zPr/xE1qjSHINdIdVhPvVxn+3Tm4r121PZm+OveQavK2/eA4P+ZNmmbDLVWiTjUGB9nlPqxUL+yg4U+kIXlUHDnSDInHME7KTk4vm76V2fqznX2SuoMUuuI6T2XuccrIRHoRmyamjWYoLYgGhHr5hUmJjnibuWdONW0+NxBt08eFg8vxqm0YSlVBQl6cne1PG2EGOv746fs/aceJMGvQp0uUi1ZCLKwDeIvAO+e059GBmjpJ3gszT0IO7WKdGI6Z6Sm7lEhn7kYKEIQP2QQfLXjf7Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6jzJt+jVnms5G/ETk8HgE/6mOXHM+20uSGz5SVp2uwE=; b=ehnUTiXGF2xyrVGLI9tOOy7R4Bfo5mikdMuC2sIAcyk+cVRwVJhu7zg+Vv2smLXlZzZfQLXqbQ+cr9ssYPDL9dPYdUCmDYuBdUqWXQRyoNd0rEG6Z2FPJAj/3rQBqmRjXa51PRu9rDnoH9FPUdnoO6Tm4yq8mzLanR+p1TOi5I5e4u4khAPKsg+W6OPhIjNtifj0TiObjjEtR7IXkJ/EcGjPQ0pFh2dC4mxD1Zx2M0cRYroLx8x3c8iAubDIww42/SjJWesEZwuZXbULlVod/zJc1NVX83CtUyXY9grti8uOoSvOUjy8D4fjztA3O4frwF0wZckAFcW6zCJk4OHNcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jzJt+jVnms5G/ETk8HgE/6mOXHM+20uSGz5SVp2uwE=; b=hMkuAHZ/amvwZ+3x7fMSKEYlXCS3qYjJO30lln1xmR7mRnaj94iaRL4k3yP6Qu2/K3n5sFrlCERJou7jE+FYziYWjHHekfxxFgZGVydDDhVkJXG5oRqWsaabSV98KWsksB0xY1GY27tZuAW5O3WcrerQTF9+D88RY7cTegxSLM4= Received: from PH7P221CA0009.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:32a::28) by IA1PR19MB6394.namprd19.prod.outlook.com (2603:10b6:208:3e6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.8; Fri, 5 Jun 2026 08:48:19 +0000 Received: from CY4PEPF0000FCBF.namprd03.prod.outlook.com (2603:10b6:510:32a:cafe::60) by PH7P221CA0009.outlook.office365.com (2603:10b6:510:32a::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.8 via Frontend Transport; Fri, 5 Jun 2026 08:48:18 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CY4PEPF0000FCBF.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Fri, 5 Jun 2026 08:48:18 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 47C77406562; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 2287082254D; Fri, 5 Jun 2026 08:48:14 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 10/10] ASoC: cs35l56: Remove unnecessary conditionals waiting for enumeration Date: Fri, 5 Jun 2026 09:48:10 +0100 Message-ID: <20260605084810.1575539-11-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCBF:EE_|IA1PR19MB6394:EE_ X-MS-Office365-Filtering-Correlation-Id: 7dfbabee-ee9b-4e25-87e7-08dec2df30c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|61400799027|82310400026|7416014|16102099003|18002099003|22082099003|6133799003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: Eot63XFPdYXTlTlRHgHOJkxi4dbq0qRnX0Btn9e9pduV9L24R5zjc62+1397WTgu2WDeBuJeyFIK3UT81c2sFDOQ7ds67m2ssAHvMEXYwAxqvtXfTXlZwW3G0vCNDbcyVq+FpzuBVr75QTeNqQpjxlXQszX6PALzdHu+WVYtYXgdiBHQDHsM/4nsS6fryneXJIOT4WFa3K5ugqUmHwPyr8Ne8N6+pX1axW5eDd8MjrW0LkwRwch0yDbqTbrBDsHAJo8jIrf1pn2IslNZ0LWKok79ylqSVJzjJpKV36ITSza6y7fQ6vcGmyNODHSfoUgjkii+Of6/bQ0+/dBWZooDjj5QAA4KOKWGB7z//JN3ctQQxhoPfvc0jvjv+mDjPDBibgc+dM3bS8o9TBL0UgMgMwGmoDuuqK51iW/i/C2yaML5pqhR2IKu1BxHWex9i1WWInxXArEmDr+y8z5WITcFXXzu+CVXgva+tCZVApADQJYSRLbHxA2zLiW9dQUBSNqW4+mZiQxwiAib3ccuv8HE4NBHZsV9r94bFqeN7b7K6wrt2xpcRg+aNaOoOW3UYY9FyMtPipG+f3fKBiXTiOxF6iWo1i1ywzoYA/Col4rC/qB3nwaIfBPxDFhGE9mn1K4J6ddW5n4A7G4nhFY8wVMwmSE2HqxQ+lf/G/njVz4UlFV+McqJFyWS5pHjTzieeKa0VyesknJSf+txkv28sr745LlNaRmbD6ywFHTs8JLtE68= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(61400799027)(82310400026)(7416014)(16102099003)(18002099003)(22082099003)(6133799003)(56012099006)(11063799006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: L32da/PLY5k5MQU18nRPEGYTMV015/J3PTIQQCpFQSt0EPdwTp96SDSsTGOfGy3C4LETwZ15bOZv1d9NpUoGOl0fi/v0nORkepux+kSNU4Yn3BGy4vvzarNJB8qA2Xb0f5yVRiJYT6Km8f5kbgJs6cwQd5U8LgINYk/n2gr+YP3J+rdZDXdaAeYPCbNhVTuE58xWET0+f5cIX2+7jloGE5x+rzt7O4S3ugJiPBEkjrPd8YSyZXrHxm4tufJHOKZnOK9ZQMcN60DJb5S6m0lp5qumXmqjoNmWFA9F/9x3gSQHFfd7g7Q5deL/fRqcnZoLet6kGoR9pezYtltzdQopPBVBnbKTC+s96QyN2eg2PxeIfpRjYwByNU8GlzsCOECBZbotFagxANVTA8DegkWU95JAEXHGivkoTA6VAjZzysfiee9rpHBjSBu4WPQcra1d X-Exchange-RoutingPolicyChecked: p3urHRl2jwX7Nu+sSToAWHBlEZWdMmVZadoCCqRfRXCgJBwrC5ljyQ7yuxPe2YPZvGVmRWzY8gR8Cpn/fEKRqRkPUxNbK6Vppmc34CYCrQCmBooYsxGK/am0AxDpA874L6oBv2q3Zfg3bFyassD/wYqwvhmW7nzOKcIG2F67D2r/eKFcAzepTB1ES3h4qAqjy4jBZ3A3FgjYI0p9rD4Gi8dKEsWht5ph357scw0yV6MCY1BKgOUCY7AkqHHQWYjee9Y4qwdOYf+nuYiVZgaKJ1YgzzQ6ruaI9SIgTfZ7DBklKzHhmHefOH7cVFfCttcaZU4XslGAfC6DD0oNyKIyRw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2026 08:48:18.1957 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7dfbabee-ee9b-4e25-87e7-08dec2df30c5 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CY4PEPF0000FCBF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR19MB6394 X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a228d58 cx=c_pps a=jAW+G/n5Z3iw2FAGIuuyAQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=fcoJ7aZ6GZweFMwf-4cA:9 X-Proofpoint-GUID: kjBE3RcQ0o1cAC5TwHxgyMWl-TGAGgrJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA4NCBTYWx0ZWRfX+Ht8eOrup1qa D3YL/S+nrmIxug964ZG692EYMdEiYfTOhNgUpVkry8GIr12UitbM+leDCAQ1DfBe6ViPvElBhWi Ja3YtyW08aLkQXE2Lw6fcwfa62DuWEFPxYqhFuTSpWNzSmGpsz9piVSVVOrEcN7PYzePK7zw+YF I3pI52AhHtMn09dkXfAxLuFxB0sQqPusIAGVimRoV1oiRB2D3WdbGBH4xEX2DErPZ8tm7rrYypn FZY0ZujdlZBpoyLk4rr+qsX3JYnWQMrXTKPs20KxJaqgKKNg+Fib6oAiHOtoTZvr/XKcc51K+Gy JI75xw36r00FGs/DOZpkl0Z+RYZXoqQ1tWTsT9ptdKByg4DG3AP8WH/9P00o/WKIg47cduBmFhO gk6DugcG21eAdD0xQcvIe7bxqiVUivWxeYhdFOoSyfNLeGSOc+pN3ENQ3It3CqLxqjkJyNm4OsC a5uJGQe3uKOLMq76zeA== X-Proofpoint-ORIG-GUID: kjBE3RcQ0o1cAC5TwHxgyMWl-TGAGgrJ X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Commit [1] updated the core to use complete_all() which means that the wait_for_completion() will now simply return if the device is already attached, so skipping the completion isn't required anymore. Update the code to simply call sdw_slave_wait_for_init() unconditionally. [1] c40d6b3249b1 ("soundwire: fix enumeration completion") Signed-off-by: Charles Keepax Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --- No change since v1. sound/soc/codecs/cs35l56-sdw.c | 47 ++++++++-------------------------- sound/soc/codecs/cs35l56.h | 1 - 2 files changed, 10 insertions(+), 38 deletions(-) diff --git a/sound/soc/codecs/cs35l56-sdw.c b/sound/soc/codecs/cs35l56-sdw.c index 847e88f3b2044..0a55b93b96f96 100644 --- a/sound/soc/codecs/cs35l56-sdw.c +++ b/sound/soc/codecs/cs35l56-sdw.c @@ -330,7 +330,6 @@ static int cs35l56_sdw_update_status(struct sdw_slave *= peripheral, =20 switch (status) { case SDW_SLAVE_ATTACHED: - cs35l56->sdw_in_clock_stop_1 =3D false; if (cs35l56->sdw_attached) break; =20 @@ -352,31 +351,10 @@ static int cs35l56_sdw_update_status(struct sdw_slave= *peripheral, return 0; } =20 -static int __maybe_unused cs35l56_sdw_clk_stop(struct sdw_slave *periphera= l, - enum sdw_clk_stop_mode mode, - enum sdw_clk_stop_type type) -{ - struct cs35l56_private *cs35l56 =3D dev_get_drvdata(&peripheral->dev); - - dev_dbg(cs35l56->base.dev, "%s: clock_stop_mode%d stage:%d\n", __func__, = mode, type); - - switch (type) { - case SDW_CLK_POST_PREPARE: - if (mode =3D=3D SDW_CLK_STOP_MODE1) - cs35l56->sdw_in_clock_stop_1 =3D true; - else - cs35l56->sdw_in_clock_stop_1 =3D false; - return 0; - default: - return 0; - } -} - static const struct sdw_slave_ops cs35l56_sdw_ops =3D { .read_prop =3D cs35l56_sdw_read_prop, .interrupt_callback =3D cs35l56_sdw_interrupt, .update_status =3D cs35l56_sdw_update_status, - .clk_stop =3D cs35l56_sdw_clk_stop, }; =20 static int __maybe_unused cs35l56_sdw_handle_unattach(struct cs35l56_priva= te *cs35l56) @@ -384,23 +362,18 @@ static int __maybe_unused cs35l56_sdw_handle_unattach= (struct cs35l56_private *cs struct sdw_slave *peripheral =3D cs35l56->sdw_peripheral; int ret; =20 - dev_dbg(cs35l56->base.dev, "attached:%u unattach_request:%u in_clock_stop= _1:%u\n", - cs35l56->sdw_attached, peripheral->unattach_request, cs35l56->sdw_in_clo= ck_stop_1); + dev_dbg(cs35l56->base.dev, "attached:%u unattach_request:%u\n", + cs35l56->sdw_attached, peripheral->unattach_request); =20 - if (cs35l56->sdw_in_clock_stop_1 || peripheral->unattach_request) { - /* Cannot access registers until bus is re-initialized. */ - dev_dbg(cs35l56->base.dev, "Wait for initialization_complete\n"); - ret =3D sdw_slave_wait_for_init(peripheral, 5000); - if (ret) - return ret; - - cs35l56->sdw_in_clock_stop_1 =3D false; + /* Cannot access registers until bus is re-initialized. */ + ret =3D sdw_slave_wait_for_init(peripheral, 5000); + if (ret) + return ret; =20 - /* - * Don't call regcache_mark_dirty(), we can't be sure that the - * Manager really did issue a Bus Reset. - */ - } + /* + * Don't call regcache_mark_dirty(), we can't be sure that the + * Manager really did issue a Bus Reset. + */ =20 return 0; } diff --git a/sound/soc/codecs/cs35l56.h b/sound/soc/codecs/cs35l56.h index 6a27ef2b7569a..9acd2e7e17c93 100644 --- a/sound/soc/codecs/cs35l56.h +++ b/sound/soc/codecs/cs35l56.h @@ -43,7 +43,6 @@ struct cs35l56_private { bool sdw_irq_no_unmask; bool soft_resetting; bool sdw_attached; - bool sdw_in_clock_stop_1; struct completion init_completion; =20 int speaker_id; --=20 2.47.3