From nobody Mon Jun 8 06:36:52 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 574AF47CC6A for ; Fri, 5 Jun 2026 08:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649233; cv=none; b=WS8/Cv61GlTwI7WbhH9+OBjz4hpbtg500vkmaWHQUax5FUomBOinT0UzESg31vPQtLjnFnPsKTLudnKiWU2XT3efpF26MhKEc+KWeagpWvY6132vNG3AmieKL5nTkmo4fn/9ht5LNrfUXL3GvwMBMA5sFI2zJqdA9M5O/Fxw0c4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780649233; c=relaxed/simple; bh=Yl/398wyefGK0PyYDRKyvaPZaxiQgOFDqqFHBTQIIGU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kN1j6ZEu+bgjxixcBwlmle0e1mn7l6w8GFwvvnUrEW05hh45pSDgFoME2wl6Oui6qV9GolB/MaxWmpsiluXKNWZS1tU9QQPnHeD/HeZ/oSQfavLOrr3EoRM3YvycqdZVVgSxzmWFJuCQVIa5Zvk/ywdKYNuW07cYfbIPu/hlHSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=kFpQxx6j; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=MqyMEOWn; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Fhh4LrbJ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=rPhR/gNf; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="kFpQxx6j"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="MqyMEOWn"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Fhh4LrbJ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="rPhR/gNf" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 306576A7ED; Fri, 5 Jun 2026 08:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780649229; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nZA5qkS5xbW9UHiYKI2mdN44MH2LzJK8McXEFj8Pos4=; b=kFpQxx6jB0x7clx8kVCHqO5xDsScpXYF6PER1hsSxRaUB5trK1Jc8ZvcNR7NPgNbq+kzFd 6IfiooqqvxCDjMQoF20rm4rJESKlyEZFuB5HjGxc8xrmtHfj+Mm0p5BkGrULPF2czOqoYV 3Jnw0Q9QTebPY9uHcVFSfRVATvLigtQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780649229; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nZA5qkS5xbW9UHiYKI2mdN44MH2LzJK8McXEFj8Pos4=; b=MqyMEOWndiUE0GDa27UJg2L6EA0QUKtCY1fRfZWpQvVrBi5KYV9+0cI5exHBaUYfu/8Y7V zrF01drKT5EuqQBw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Fhh4LrbJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="rPhR/gNf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780649228; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nZA5qkS5xbW9UHiYKI2mdN44MH2LzJK8McXEFj8Pos4=; b=Fhh4LrbJZ/FWvTKTuwzn7TF/nRMptOqfVWoa/Udstv6gWzt0UXWhJ5iyOLXExO880lZGKG TO26eTrrNCOQf8hHGhKXlJkbQnNI4Tu7MLWqLfZDyTarjsNA8Ds5x/kcg9SlIQLL69oCxu qCuaZ/JblXrlKLG9MPZm2qfeNsvhBsE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780649228; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nZA5qkS5xbW9UHiYKI2mdN44MH2LzJK8McXEFj8Pos4=; b=rPhR/gNfBhCyM5faxGNbyHomUaRlIFgCorSkGBe6ksjaKTagEgLvpWTL6jvzAVvnj8rj8M YRWwsQzHAEQRSVCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D0A6779A8; Fri, 5 Jun 2026 08:47:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yj4YJAuNImrxfQAAD6G6ig (envelope-from ); Fri, 05 Jun 2026 08:47:07 +0000 From: Patrik Jakobsson To: ville.syrjala@linux.intel.com, Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Imre Deak Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND] drm/i915/display: Add quirk for interlane align bit on CH7511 Date: Fri, 5 Jun 2026 10:46:40 +0200 Message-ID: <20260605084641.50778-1-pjakobsson@suse.de> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_TO(0.00)[linux.intel.com,intel.com,ursulin.net,gmail.com,ffwll.ch]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:email,suse.de:dkim,suse.de:mid]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 306576A7ED X-Spam-Score: -3.01 Content-Type: text/plain; charset="utf-8" When disabling pattern training after successful link training the CH7511 bridge incorrectly clears the INTERLANE_ALIGN_DONE bit. This is interpreted as link failure when rechecking the link status and triggers an endless loop of retraining sequences. This patch adds a quirk to pretend the bit is still set and no retraining is needed. Fixes: 3b3be899fc81 ("drm/i915/dp: Recheck link state after modeset") Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/display/intel_dp.c | 9 +++++++++ drivers/gpu/drm/i915/display/intel_quirks.c | 17 +++++++++++++++++ drivers/gpu/drm/i915/display/intel_quirks.h | 1 + 3 files changed, 27 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915= /display/intel_dp.c index 85d3aa3b9894..5b269b1f18d7 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5875,6 +5875,15 @@ intel_dp_needs_link_retrain(struct intel_dp *intel_d= p) if (intel_dp->link.seq_train_failures) return true; =20 + /* + * The CH7511 bridge incorrectly clears the INTERLANE_ALIGN_DONE bit + * when disabling training pattern. + */ + if (intel_has_dpcd_quirk(intel_dp, QUIRK_IGNORE_INTERLANE_ALIGN_BIT)) { + link_status[DP_LANE_ALIGN_STATUS_UPDATED - DP_LANE0_1_STATUS] |=3D + DP_INTERLANE_ALIGN_DONE; + } + /* Retrain if link not ok */ return !intel_dp_link_ok(intel_dp, link_status) && !intel_psr_link_ok(intel_dp); diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/= i915/display/intel_quirks.c index 33245f44c0d5..2cec0a945528 100644 --- a/drivers/gpu/drm/i915/display/intel_quirks.c +++ b/drivers/gpu/drm/i915/display/intel_quirks.c @@ -100,6 +100,14 @@ static void quirk_disable_psr2(struct intel_display *d= isplay) drm_info(display->drm, "PSR2 support not currently available for this set= up, applying disable PSR2 quirk\n"); } =20 +static void quirk_ignore_interlane_align_bit(struct intel_dp *intel_dp) +{ + struct intel_display *display =3D to_intel_display(intel_dp); + + intel_set_dpcd_quirk(intel_dp, QUIRK_IGNORE_INTERLANE_ALIGN_BIT); + drm_info(display->drm, "Applying ignore interlane align bit quirk\n"); +} + struct intel_quirk { int device; int subsystem_vendor; @@ -286,6 +294,15 @@ static const struct intel_dpcd_quirk intel_dpcd_quirks= [] =3D { .sink_oui =3D SINK_OUI(0x00, 0x22, 0xb9), .hook =3D quirk_disable_edp_panel_replay, }, + /* Nodka TPC6000-C152 */ + { + .device =3D 0x0f31, + .subsystem_vendor =3D 0x8086, + .subsystem_device =3D 0x0f31, + .sink_oui =3D SINK_OUI(0x2b, 0x02, 0xf0), + .sink_device_id =3D SINK_DEVICE_ID('C', 'H', '7', '5', '1', '1'), + .hook =3D quirk_ignore_interlane_align_bit, + }, }; =20 void intel_init_quirks(struct intel_display *display) diff --git a/drivers/gpu/drm/i915/display/intel_quirks.h b/drivers/gpu/drm/= i915/display/intel_quirks.h index 970a4fe52faf..7fcc3967f84f 100644 --- a/drivers/gpu/drm/i915/display/intel_quirks.h +++ b/drivers/gpu/drm/i915/display/intel_quirks.h @@ -23,6 +23,7 @@ enum intel_quirk_id { QUIRK_EDP_LIMIT_RATE_HBR2, QUIRK_DISABLE_EDP_PANEL_REPLAY, QUIRK_DISABLE_PSR2, + QUIRK_IGNORE_INTERLANE_ALIGN_BIT, }; =20 void intel_init_quirks(struct intel_display *display); --=20 2.54.0