From nobody Mon Jun 8 06:40:04 2026 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4378047AF6C; Fri, 5 Jun 2026 07:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645492; cv=none; b=ofH8IanBPJbG3AILM3azav2NVo+BJXcDyyVggo2orHh+MIH81q/wThb0o3B0lZLJGBtrKUmgB6sN6hGDdCaneP4AYKEOX4oYuT3qvSeCLdDUxhzz1LEBMVqpN3jhsp9U4Cdocmk2CdGLgBLgsbhwZPr6k5Ck4jZQFlNO77EWX4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645492; c=relaxed/simple; bh=HAZBs5BOqikvqTV0pkWO+hF/E1kHkdu3KinoNRr3J/c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A8R4nJdKhRvgMxFao0+A6pXtlSkBpM97czM7zoFj1KWVObIK56JJXz0oyYoPcrMiBH5+AU1PJ6d6fXZrmebIqhP9vEQurJdNlzEstmOauKVMPoFA0fi0aPU2MXF1czXUQ7e9P2i0ttK6eS0+bRLE+LRqvc4WcXIUS3pFK55XkVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn; spf=pass smtp.mailfrom=realsil.com.cn; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b=fWLDRy2/; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b="fWLDRy2/" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 6557hUeV51221753, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realsil.com.cn; s=dkim; t=1780645410; bh=cAL7P3Xyg9/GaQs/Xyb7AvlE3Tyao+AY7aIvuGNaF18=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type; b=fWLDRy2/udjw6yzWHU2OT6qivzH6oWWfxHdMbzbH3CLrneqzkCdxtKuSU1fQ2tRc/ tRV+YmS+MxH2aWy41WoEZOm2FdfYQ65VcYQo5Xw360KBflaIMTbZC0CC4QDcvyKO1O BUgcKPNhLST/zy1Ps9PFtuDQfUDQItEIOWqCPG4sFyiQQjjXgxsyKgg7yZ6ndUpBgp x8b1E/FOyg/tZFaVOqFpFsHyAEbpnuTzMDklMVSu0SMy5PVAHePSW979YOoBlWuXCh kDMbJsEHYguyqMllmdg2m5ce76zNk5N33JN8YxxSxPDazgy2rxO4idnFMQlHTsHtzt Xh/C/6hMly6Qw== Received: from RS-EX-MBS2.realsil.com.cn ([172.29.17.102]) by rtits2.realtek.com.tw (8.15.2/3.28/5.94) with ESMTPS id 6557hUeV51221753 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Jun 2026 15:43:30 +0800 Received: from RS-EX-MBS2.realsil.com.cn (172.29.17.102) by RS-EX-MBS2.realsil.com.cn (172.29.17.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Jun 2026 15:43:31 +0800 Received: from 172.29.37.154 (172.29.37.152) by RS-EX-MBS2.realsil.com.cn (172.29.17.102) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Fri, 5 Jun 2026 15:43:31 +0800 From: javen To: , , , , , , , CC: , , , , Javen Xu Subject: [PATCH net-next v3 1/4] net: phy: c45: add genphy_c45_soft_reset() Date: Fri, 5 Jun 2026 15:43:25 +0800 Message-ID: <20260605074328.1800-2-javen_xu@realsil.com.cn> X-Mailer: git-send-email 2.50.1.windows.1 In-Reply-To: <20260605074328.1800-1-javen_xu@realsil.com.cn> References: <20260605074328.1800-1-javen_xu@realsil.com.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Javen Xu Add a generic Clause 45 software reset helper. The helper sets the reset bit in the PMA/PMD control register and waits until the bit is cleared by hardware. Signed-off-by: Javen Xu Reviewed-by: Nicolai Buchwitz --- Changes in v2: - no changes, new file Changes in v3: - re-order function according to the order in phy-c45.c --- drivers/net/phy/phy-c45.c | 22 ++++++++++++++++++++++ include/linux/phy.h | 1 + 2 files changed, 23 insertions(+) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 126951741428..d8a83179ec40 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -384,6 +384,28 @@ int genphy_c45_check_and_restart_aneg(struct phy_devic= e *phydev, bool restart) } EXPORT_SYMBOL_GPL(genphy_c45_check_and_restart_aneg); =20 +/** + * genphy_c45_soft_reset - software reset the PHY via Clause 45 PMA/PMD co= ntrol register + * @phydev: target phy_device struct + * + * Return: 0 on success, negative errno on failure. + */ +int genphy_c45_soft_reset(struct phy_device *phydev) +{ + int ret, val; + + ret =3D phy_set_bits_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_CTRL1, + MDIO_CTRL1_RESET); + if (ret < 0) + return ret; + + return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_PMAPMD, + MDIO_CTRL1, val, + !(val & MDIO_CTRL1_RESET), + 5000, 100000, true); +} +EXPORT_SYMBOL_GPL(genphy_c45_soft_reset); + /** * genphy_c45_aneg_done - return auto-negotiation complete status * @phydev: target phy_device struct diff --git a/include/linux/phy.h b/include/linux/phy.h index 199a7aaa341b..25a66320df56 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -2309,6 +2309,7 @@ int genphy_c37_read_status(struct phy_device *phydev,= bool *changed); /* Clause 45 PHY */ int genphy_c45_restart_aneg(struct phy_device *phydev); int genphy_c45_check_and_restart_aneg(struct phy_device *phydev, bool rest= art); +int genphy_c45_soft_reset(struct phy_device *phydev); int genphy_c45_aneg_done(struct phy_device *phydev); int genphy_c45_read_link(struct phy_device *phydev); int genphy_c45_read_lpa(struct phy_device *phydev); --=20 2.43.0 From nobody Mon Jun 8 06:40:04 2026 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 844DE481FCA; Fri, 5 Jun 2026 07:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645497; cv=none; b=TKlyMXI/R9CqmJj1hybdK0h0+5oZ1bDwVa4RjdH6gqysfmDfs2uLyodODJuxnsNZuOK7DALKQzr7cwx8vx88/emDDpAf7UNT0R1rW+B9CpzW3qqDjWfs2JhdWGFUNhyZYDYXehHWLXp1XPEOTgieXvqaULjCubkovjRKCOrDsgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645497; c=relaxed/simple; bh=T4B7H85vrvd5LrFha4O8snmkpPt3uAYMiFPtIBi1GXM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WzGuRFM6/Y5btDk2Xjug38AmxFnzudQ7qwu1ZGxwT2Q9bq/cEuv/NOryKmPaCR47EozPES5CV5JQPufTBS/UF/sTFRgnOU1snnilKVH5QuoZS7BB4+5oTAiBq2fmdzJ5CEnp04yPvT5pUkuIfqKGTw5lPmaERMWqIdfxvS96uv8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn; spf=pass smtp.mailfrom=realsil.com.cn; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b=WSSGsK92; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b="WSSGsK92" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 6557hUeW51221753, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realsil.com.cn; s=dkim; t=1780645411; bh=nWzts/H4wwuI5TljBKGOGaj/2CwHAdU2rSYQgB7LJbk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type; b=WSSGsK92N/CcWIPxdkM/o04OoQGctJ+JaYSZQaenAVR9BZiretChwtzPSugQoJiiL sSS1MEIiJ5o3iMuJl/0MwAffodmVxiRGgqrzxPGgFT7llcC9DGtsgdBgemah6v7zJB lAnwT/g/oViD6AM35TAAM5LiLHnbEIO+1h5i45NY9/j6UqY7Mq0TlYj6Ocddx8NSUR cOr5FxQVoEM+cU11N14ftvW5UcoGOYEW08BE5LYnR1leT3I0qBwVR7Brqtr387Yj5X Yc21sd5iRP2cRdsnrBKB8t1GqJ8JvaZzkAybPAa9BoeB3XIrIDJ3jDRD8QyFUGtblO yUt6sfx6ihdyw== Received: from RS-EX-MBS2.realsil.com.cn ([172.29.17.102]) by rtits2.realtek.com.tw (8.15.2/3.28/5.94) with ESMTPS id 6557hUeW51221753 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Jun 2026 15:43:31 +0800 Received: from RS-EX-MBS2.realsil.com.cn (172.29.17.102) by RS-EX-MBS2.realsil.com.cn (172.29.17.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Jun 2026 15:43:31 +0800 Received: from 172.29.37.154 (172.29.37.152) by RS-EX-MBS2.realsil.com.cn (172.29.17.102) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Fri, 5 Jun 2026 15:43:31 +0800 From: javen To: , , , , , , , CC: , , , , Javen Xu Subject: [PATCH net-next v3 2/4] net: phy: c45: add genphy_c45_an_setup_master_slave() Date: Fri, 5 Jun 2026 15:43:26 +0800 Message-ID: <20260605074328.1800-3-javen_xu@realsil.com.cn> X-Mailer: git-send-email 2.50.1.windows.1 In-Reply-To: <20260605074328.1800-1-javen_xu@realsil.com.cn> References: <20260605074328.1800-1-javen_xu@realsil.com.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Javen Xu Add a generic helper to configure forced master/slave mode for Clause 45 PHYs using the 10GBASE-T AN control register. Signed-off-by: Javen Xu Reviewed-by: Nicolai Buchwitz --- Changes in v2: - no changes, new file Changes in v3: - re-order function according to the order in phy-c45.c - add kernel-doc about return value - add MASTER_SLAVE_CFG_MASTER_PREFERRED, MASTER_SLAVE_CFG_SLAVE_PREFERRED, MASTER_SLAVE_CFG_UNKNOWN, MASTER_SLAVE_CFG_UNSUPPORTED, MASTER_SLAVE_CFG_SLAVE_PREFERRED cfg --- drivers/net/phy/phy-c45.c | 42 +++++++++++++++++++++++++++++++++++++++ include/linux/phy.h | 1 + include/uapi/linux/mdio.h | 3 +++ 3 files changed, 46 insertions(+) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index d8a83179ec40..28cb173ff7aa 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -406,6 +406,48 @@ int genphy_c45_soft_reset(struct phy_device *phydev) } EXPORT_SYMBOL_GPL(genphy_c45_soft_reset); =20 +/** + * genphy_c45_an_setup_master_slave - Configure Master/Slave setting for C= 45 PHYs + * @phydev: target phy_device struct + * + * Description: Configure the forced or preferred Master/Slave role + * 10GBASE-T control register (MMD 7, Register 0x0020) according to + * IEEE 802.3 standards. + * + * Returns negative errno code on failure, 0 if Master/Slave didn't change, + * or 1 if Master/Slave modes changed. + */ +int genphy_c45_an_setup_master_slave(struct phy_device *phydev) +{ + u16 ctl =3D 0; + + switch (phydev->master_slave_set) { + case MASTER_SLAVE_CFG_MASTER_PREFERRED: + ctl =3D MDIO_AN_10GBT_CTRL_MS_PORT_TYPE; + break; + case MASTER_SLAVE_CFG_SLAVE_PREFERRED: + break; + case MASTER_SLAVE_CFG_MASTER_FORCE: + ctl =3D MDIO_AN_10GBT_CTRL_MS_ENABLE | MDIO_AN_10GBT_CTRL_MS_VALUE; + break; + case MASTER_SLAVE_CFG_SLAVE_FORCE: + ctl =3D MDIO_AN_10GBT_CTRL_MS_ENABLE; + break; + case MASTER_SLAVE_CFG_UNKNOWN: + case MASTER_SLAVE_CFG_UNSUPPORTED: + return 0; + default: + phydev_warn(phydev, "Unsupported Master/Slave mode\n"); + return -EOPNOTSUPP; + } + + return phy_modify_mmd_changed(phydev, MDIO_MMD_AN, MDIO_AN_10GBT_CTRL, + MDIO_AN_10GBT_CTRL_MS_ENABLE | + MDIO_AN_10GBT_CTRL_MS_VALUE | + MDIO_AN_10GBT_CTRL_MS_PORT_TYPE, ctl); +} +EXPORT_SYMBOL_GPL(genphy_c45_an_setup_master_slave); + /** * genphy_c45_aneg_done - return auto-negotiation complete status * @phydev: target phy_device struct diff --git a/include/linux/phy.h b/include/linux/phy.h index 25a66320df56..a46f4d9a6155 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -2310,6 +2310,7 @@ int genphy_c37_read_status(struct phy_device *phydev,= bool *changed); int genphy_c45_restart_aneg(struct phy_device *phydev); int genphy_c45_check_and_restart_aneg(struct phy_device *phydev, bool rest= art); int genphy_c45_soft_reset(struct phy_device *phydev); +int genphy_c45_an_setup_master_slave(struct phy_device *phydev); int genphy_c45_aneg_done(struct phy_device *phydev); int genphy_c45_read_link(struct phy_device *phydev); int genphy_c45_read_lpa(struct phy_device *phydev); diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h index b2541c948fc1..ffca03fd82c9 100644 --- a/include/uapi/linux/mdio.h +++ b/include/uapi/linux/mdio.h @@ -332,6 +332,9 @@ #define MDIO_AN_10GBT_CTRL_ADV2_5G 0x0080 /* Advertise 2.5GBASE-T */ #define MDIO_AN_10GBT_CTRL_ADV5G 0x0100 /* Advertise 5GBASE-T */ #define MDIO_AN_10GBT_CTRL_ADV10G 0x1000 /* Advertise 10GBASE-T */ +#define MDIO_AN_10GBT_CTRL_MS_ENABLE 0x8000 /* Master/slave manual config = enable */ +#define MDIO_AN_10GBT_CTRL_MS_VALUE 0x4000 /* Master/slave config value (1= =3DMaster) */ +#define MDIO_AN_10GBT_CTRL_MS_PORT_TYPE 0x2000 /* Master Preferred Type */ =20 /* AN 10GBASE-T status register. */ #define MDIO_AN_10GBT_STAT_LP2_5G 0x0020 /* LP is 2.5GBT capable */ --=20 2.43.0 From nobody Mon Jun 8 06:40:04 2026 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 436A34611C7; Fri, 5 Jun 2026 07:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645492; cv=none; b=alxPczsxzYtCeedmTTMHxtjlA0RNOA+z8TLw2DXKnygW6m5hJbxlIv00LfKYsYO244z0UPGlzIKXvvG4bheM80PorsyG3qVor6B3UTLu/FVUMj1V2SDNUtMzKnmtRTm0y3LvDvHIU6YcMypIsyV2W5EYBk+ncheckhTFjBRbBwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645492; c=relaxed/simple; bh=w05mEsXyfNgZIGJQeRXMcA76h/pV9AUQDIx87EaLqIg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n2PPvrP69W9YqB+85cvr8SoIIZORBLgy1zORD7isci+phVvUuQwyZyhTWOT6t28Us/Jy0qctXvXDNtg+76cCGAvsSQXF2/EY3jjP/QeEcfRAdEFFYT1uHDpkzCEIoNJfvtes3ZN4xMDvmocRy6TmBEdcvBw4DmHhth91B/Cavo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn; spf=pass smtp.mailfrom=realsil.com.cn; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b=bbsfis8i; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b="bbsfis8i" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 6557hVeU51221753, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realsil.com.cn; s=dkim; t=1780645411; bh=FljCfBWZt6zmGyfGbiRa8WrQSdumbJidxYols3nxfW4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type; b=bbsfis8ikkOEgKOcS1cG3Z5MOuqVGtwW2FxPzehU9sAsqarDPY/HSeZsP0Xq7q+J3 hnHcOWyIk1k7pzorND6wdMIdKZND5AiaNUEXQanQEwL8bi+t1K81QJHbjbVLK5PkiV klbcqvCng2XiLs8PmdPNnZO093kBpMLb9Pz01deU+4aX176ulTe5oEg3ZWn5vXKqmM dSHJiCcnB4N4hcKcQYRAWIKIYr0U6ybKIu++UMQFCAAV6fBTruHTx1T/0h6kkqaXb3 PNtD7+fCbbmm5St1W7Op4dP9+8G46skhQ0mwSB6WIfSI0GxpZuAGrTpBPSyKmnbzt5 51fXO0OhOAzMw== Received: from RS-EX-MBS2.realsil.com.cn ([172.29.17.102]) by rtits2.realtek.com.tw (8.15.2/3.28/5.94) with ESMTPS id 6557hVeU51221753 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Jun 2026 15:43:31 +0800 Received: from RS-EX-MBS2.realsil.com.cn (172.29.17.102) by RS-EX-MBS2.realsil.com.cn (172.29.17.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Jun 2026 15:43:31 +0800 Received: from 172.29.37.154 (172.29.37.152) by RS-EX-MBS2.realsil.com.cn (172.29.17.102) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Fri, 5 Jun 2026 15:43:31 +0800 From: javen To: , , , , , , , CC: , , , , Javen Xu Subject: [PATCH net-next v3 3/4] net: phy: realtek: add support for RTL8261C_CG Date: Fri, 5 Jun 2026 15:43:27 +0800 Message-ID: <20260605074328.1800-4-javen_xu@realsil.com.cn> X-Mailer: git-send-email 2.50.1.windows.1 In-Reply-To: <20260605074328.1800-1-javen_xu@realsil.com.cn> References: <20260605074328.1800-1-javen_xu@realsil.com.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Javen Xu This patch adds support for Realtek phy chip RTL8261C_CG. Its PHY ID is 0x001cc898. Signed-off-by: Javen Xu Reviewed-by: Nicolai Buchwitz --- Changes in v2: - remove RTL8261D, only support RTL8261C_CG - remove speed 500, rarely used - add helper function, genphy_c45_soft_reset() and genphy_c45_config_maste= r_slave() Changes in v3: - remove macro RTL8261X_GBCR_REG - remove priv struct and priv->sub_phy_id --- drivers/net/phy/realtek/realtek_main.c | 166 +++++++++++++++++++++++++ 1 file changed, 166 insertions(+) diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realt= ek/realtek_main.c index 27268811f564..f7b07f38f0c1 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -141,6 +141,10 @@ #define RTL8211F_PHYSICAL_ADDR_WORD1 17 #define RTL8211F_PHYSICAL_ADDR_WORD2 18 =20 +#define RTL8261X_EXT_ADDR_REG 0xa436 +#define RTL8261X_EXT_DATA_REG 0xa438 +#define RTL_8261X_SUB_PHY_ID_ADDR 0x801d + #define RTL822X_VND1_SERDES_OPTION 0x697a #define RTL822X_VND1_SERDES_OPTION_MODE_MASK GENMASK(5, 0) #define RTL822X_VND1_SERDES_OPTION_MODE_2500BASEX_SGMII 0 @@ -251,6 +255,32 @@ #define RTL_8221B_VM_CG 0x001cc84a #define RTL_8251B 0x001cc862 #define RTL_8261C 0x001cc890 +#define RTL_8261C_CG 0x001cc898 + +#define RTL8261C_CE_MODEL 0x00 +#define RTL8261X_IMR 0xa4d2 +#define RTL8261X_ISR 0xa4d4 +#define RTL8261X_INT_AUTONEG_ERROR BIT(0) +#define RTL8261X_INT_PAGE_RECV BIT(2) +#define RTL8261X_INT_AUTONEG_DONE BIT(3) +#define RTL8261X_INT_LINK_CHG BIT(4) +#define RTL8261X_INT_PHY_REG_ACCESS BIT(5) +#define RTL8261X_INT_PME BIT(7) +#define RTL8261X_INT_ALDPS_CHG BIT(9) +#define RTL8261X_INT_JABBER BIT(10) + +#define RTL8261X_INT_MASK_DEFAULT (RTL8261X_INT_AUTONEG_DONE | \ + RTL8261X_INT_LINK_CHG) + +#define RTL8261X_INT_MASK_ALL (RTL8261X_INT_AUTONEG_ERROR | \ + RTL8261X_INT_PAGE_RECV | \ + RTL8261X_INT_AUTONEG_DONE | \ + RTL8261X_INT_LINK_CHG | \ + RTL8261X_INT_PHY_REG_ACCESS | \ + RTL8261X_INT_PME | \ + RTL8261X_INT_ALDPS_CHG | \ + RTL8261X_INT_JABBER) + =20 /* RTL8211E and RTL8211F support up to three LEDs */ #define RTL8211x_LED_COUNT 3 @@ -310,6 +340,130 @@ static int rtl821x_modify_ext_page(struct phy_device = *phydev, u16 ext_page, return phy_restore_page(phydev, oldpage, ret); } =20 +static int rtl8261x_probe(struct phy_device *phydev) +{ + struct device *dev =3D &phydev->mdio.dev; + int sub_phy_id, ret; + + ret =3D phy_write_mmd(phydev, MDIO_MMD_VEND2, RTL8261X_EXT_ADDR_REG, + RTL_8261X_SUB_PHY_ID_ADDR); + if (ret < 0) + return ret; + + ret =3D phy_read_mmd(phydev, MDIO_MMD_VEND2, RTL8261X_EXT_DATA_REG); + if (ret < 0) + return ret; + + sub_phy_id =3D (ret >> 8) & 0xff; + + switch (sub_phy_id) { + case RTL8261C_CE_MODEL: + phydev_info(phydev, "RTL8261C detected (sub_id 0x%02x)\n", sub_phy_id); + break; + + default: + phydev_err(phydev, "Unknown sub_id 0x%02x\n", sub_phy_id); + return -ENODEV; + } + + return 0; +} + +static int rtl8261x_get_features(struct phy_device *phydev) +{ + int ret; + + ret =3D genphy_c45_pma_read_abilities(phydev); + if (ret) + return ret; + /* + * Supplement Multi-Gig speeds that may not be automatically detected + * RTL8261X supports 2.5G/5G in addition to standard 10G + */ + linkmode_set_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, + phydev->supported); + linkmode_set_bit(ETHTOOL_LINK_MODE_5000baseT_Full_BIT, + phydev->supported); + + return 0; +} + +static int rtl8261x_config_intr(struct phy_device *phydev) +{ + int ret; + + if (phydev->interrupts =3D=3D PHY_INTERRUPT_ENABLED) { + ret =3D phy_read_mmd(phydev, MDIO_MMD_VEND2, RTL8261X_ISR); + if (ret < 0) + return ret; + + ret =3D phy_write_mmd(phydev, MDIO_MMD_VEND2, RTL8261X_IMR, + RTL8261X_INT_MASK_DEFAULT); + if (ret < 0) + return ret; + } else { + ret =3D phy_write_mmd(phydev, MDIO_MMD_VEND2, RTL8261X_IMR, 0); + if (ret < 0) + return ret; + } + + return 0; +} + +static irqreturn_t rtl8261x_handle_interrupt(struct phy_device *phydev) +{ + int irq_status; + + irq_status =3D phy_read_mmd(phydev, MDIO_MMD_VEND2, RTL8261X_ISR); + if (irq_status < 0) { + phy_error(phydev); + return IRQ_NONE; + } + + if (!(irq_status & RTL8261X_INT_MASK_ALL)) + return IRQ_NONE; + + if (irq_status & (RTL8261X_INT_LINK_CHG | RTL8261X_INT_AUTONEG_DONE | + RTL8261X_INT_AUTONEG_ERROR | RTL8261X_INT_JABBER)) + phy_trigger_machine(phydev); + + return IRQ_HANDLED; +} + +static int rtl8261x_config_aneg(struct phy_device *phydev) +{ + bool changed =3D false; + u16 adv_1g =3D 0; + int ret; + + if (phydev->autoneg =3D=3D AUTONEG_DISABLE) + return genphy_c45_pma_setup_forced(phydev); + + ret =3D genphy_c45_an_setup_master_slave(phydev); + if (ret < 0) + return ret; + if (ret > 0) + changed =3D true; + + ret =3D genphy_c45_config_aneg(phydev); + if (ret < 0) + return ret; + + if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, + phydev->advertising)) + adv_1g =3D ADVERTISE_1000FULL; + + ret =3D phy_modify_mmd_changed(phydev, MDIO_MMD_VEND2, + RTL822X_VND2_C22_REG(MII_CTRL1000), + ADVERTISE_1000FULL, adv_1g); + if (ret < 0) + return ret; + if (ret > 0 || changed) + return genphy_c45_restart_aneg(phydev); + + return 0; +} + static int rtl821x_probe(struct phy_device *phydev) { struct device *dev =3D &phydev->mdio.dev; @@ -3001,6 +3155,18 @@ static struct phy_driver realtek_drvs[] =3D { .resume =3D genphy_resume, .read_mmd =3D genphy_read_mmd_unsupported, .write_mmd =3D genphy_write_mmd_unsupported, + }, { + PHY_ID_MATCH_EXACT(RTL_8261C_CG), + .name =3D "Realtek RTL8261C 10Gbps PHY", + .probe =3D rtl8261x_probe, + .get_features =3D rtl8261x_get_features, + .config_aneg =3D rtl8261x_config_aneg, + .read_status =3D genphy_c45_read_status, + .config_intr =3D rtl8261x_config_intr, + .handle_interrupt =3D rtl8261x_handle_interrupt, + .soft_reset =3D genphy_c45_soft_reset, + .suspend =3D genphy_c45_pma_suspend, + .resume =3D genphy_c45_pma_resume, }, }; =20 --=20 2.43.0 From nobody Mon Jun 8 06:40:04 2026 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 435CF4508F2; Fri, 5 Jun 2026 07:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645492; cv=none; b=e35K/iwie2zTIzkvy1ZUydaw+KqKKy2ENSjJnz6bXSGpIGhDHl1sDAX/LpseN0Iw5lRdUzv2o50Z8nGUuKvD3Fz5jEgbZ7nf/jlNsXVZK/pgvexedOb1BN1i0myjJPDXab4E+9luy2wVBoT16vLehYdjJy1sRMbdNcJj04RnXpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645492; c=relaxed/simple; bh=oyLiZLasXuM9gXS0pBIgtACsuR+t/mlOUbVvDq6mjG0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sjBAKTP+PquP82dAgy1CUVn7+qHWz+XWtMBzKyJG5lyX0h3twV5WQQzAoJJ9JiWM44dG/8n6D6fFYmmCXqLozHtnd8n9/WAHXe7QKwjxtE2fvmYJIuNGEieeHEKJpTH3wfoSa3g/aLsvTmVx9oiRFIPwP7P0hGqdtlPpN9T1pT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn; spf=pass smtp.mailfrom=realsil.com.cn; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b=uzJIAf4f; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b="uzJIAf4f" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 6557hVeV51221753, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realsil.com.cn; s=dkim; t=1780645411; bh=q0qZeaJfiqJgbKqEBoYwxtIO8Wv0rXORaL4/rqSredM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type; b=uzJIAf4fP7Q5MdZm2z4Jhw1pCX3BoetEhaF06ADNH15DwVnXL8f6D+cav6kfYM3mv XulIy6PDtnXrY6eNkt1XckhXW+5rVazmZw4QG6O9qDBJ4OjiklHWu35m9P+EAJUhXq YkqKwzB58k5wd6EurJD3XU8sCf4i1jWsNjbOTj4sdniWWHps/y6+2ymSQ2RFNwBrFL Xp9urtwOOVvVGW3levvQ3oenV2R7mWzl9mBMPw6WlOMOXafAB4Q3RTbou+Dgv0te0U non316DtQf8Wb7NCewn/8T7PBs0zVCmT/yt3sUMGW01IHStrfEDSOBWguuzVIaCt2J tB+WQf5DjLV1A== Received: from RS-EX-MBS2.realsil.com.cn ([172.29.17.102]) by rtits2.realtek.com.tw (8.15.2/3.28/5.94) with ESMTPS id 6557hVeV51221753 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Jun 2026 15:43:31 +0800 Received: from RS-EX-MBS2.realsil.com.cn (172.29.17.102) by RS-EX-MBS2.realsil.com.cn (172.29.17.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Jun 2026 15:43:31 +0800 Received: from 172.29.37.154 (172.29.37.152) by RS-EX-MBS2.realsil.com.cn (172.29.17.102) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Fri, 5 Jun 2026 15:43:31 +0800 From: javen To: , , , , , , , CC: , , , , Javen Xu Subject: [PATCH net-next v3 4/4] net: phy: realtek: load firmware for RTL8261C_CG Date: Fri, 5 Jun 2026 15:43:28 +0800 Message-ID: <20260605074328.1800-5-javen_xu@realsil.com.cn> X-Mailer: git-send-email 2.50.1.windows.1 In-Reply-To: <20260605074328.1800-1-javen_xu@realsil.com.cn> References: <20260605074328.1800-1-javen_xu@realsil.com.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Javen Xu This patch adds support for loading firmware. Download some parameters for RTL8261C_CG. Signed-off-by: Javen Xu Reviewed-by: Nicolai Buchwitz --- Changes in v2: - remove __pack, struct rtl8261x_fw_header and rtl8261x_fw_entry will not = pad - reverse xmas tree for some definition - add explanation on rtl_phy_write_mmd_bits() Changes in v3: - add struct rtl8261x_priv --- drivers/net/phy/realtek/realtek_main.c | 240 +++++++++++++++++++++++++ 1 file changed, 240 insertions(+) diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realt= ek/realtek_main.c index f7b07f38f0c1..f433c1dd3529 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -8,7 +8,9 @@ * Copyright (c) 2004 Freescale Semiconductor, Inc. */ #include +#include #include +#include #include #include #include @@ -281,6 +283,42 @@ RTL8261X_INT_ALDPS_CHG | \ RTL8261X_INT_JABBER) =20 +#define FW_MAIN_MAGIC 0x52544C38 +#define FW_SUB_MAGIC_8261C 0x32363143 +#define RTL8261X_POLL_TIMEOUT_MS 100 + +#define RTL8261C_CE_FW_NAME "rtl_nic/rtl8261c.bin" +MODULE_FIRMWARE(RTL8261C_CE_FW_NAME); + +enum rtl8261x_fw_op { + OP_WRITE =3D 0x00, /* Write */ + OP_POLL =3D 0x02, /* Polling */ +}; + +struct rtl8261x_fw_header { + __le32 main_magic; /* Main magic number 0x52544C38 ("RTL8") */ + __le32 sub_magic; /* Sub magic number */ + __le16 version_major; /* Major version */ + __le16 version_minor; /* Minor version */ + __le16 num_entries; /* Number of entries */ + __le16 reserved; /* Reserved */ + __le32 crc32; /* CRC32 checksum */ +}; + +struct rtl8261x_fw_entry { + __u8 type; /* Operation type (OP_*) */ + __u8 dev; /* MMD device */ + __le16 addr; /* Register address */ + __u8 msb; /* MSB bit position */ + __u8 lsb; /* LSB bit position */ + __le16 value; /* Value to write/compare */ + __le16 timeout_ms; /* Poll timeout in milliseconds */ + __u8 poll_set; /* Poll for set (1) or clear (0) */ + __u8 reserved; /* Reserved */ +}; + +#define FW_HEADER_SIZE sizeof(struct rtl8261x_fw_header) +#define FW_ENTRY_SIZE sizeof(struct rtl8261x_fw_entry) =20 /* RTL8211E and RTL8211F support up to three LEDs */ #define RTL8211x_LED_COUNT 3 @@ -300,6 +338,11 @@ struct rtl821x_priv { u16 iner; }; =20 +struct rtl8261x_priv { + const char *fw_name; + bool fw_loaded; +}; + static int rtl821x_read_page(struct phy_device *phydev) { return __phy_read(phydev, RTL821x_PAGE_SELECT); @@ -343,8 +386,15 @@ static int rtl821x_modify_ext_page(struct phy_device *= phydev, u16 ext_page, static int rtl8261x_probe(struct phy_device *phydev) { struct device *dev =3D &phydev->mdio.dev; + struct rtl8261x_priv *priv; int sub_phy_id, ret; =20 + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + phydev->priv =3D priv; + ret =3D phy_write_mmd(phydev, MDIO_MMD_VEND2, RTL8261X_EXT_ADDR_REG, RTL_8261X_SUB_PHY_ID_ADDR); if (ret < 0) @@ -358,6 +408,7 @@ static int rtl8261x_probe(struct phy_device *phydev) =20 switch (sub_phy_id) { case RTL8261C_CE_MODEL: + priv->fw_name =3D RTL8261C_CE_FW_NAME; phydev_info(phydev, "RTL8261C detected (sub_id 0x%02x)\n", sub_phy_id); break; =20 @@ -388,6 +439,178 @@ static int rtl8261x_get_features(struct phy_device *p= hydev) return 0; } =20 +static int rtl8261x_verify_firmware(struct phy_device *phydev, const struc= t firmware *fw) +{ + const struct rtl8261x_fw_header *hdr; + u32 main_magic, sub_magic; + u32 calc_crc, file_crc; + size_t data_len; + u16 num_entries; + + if (fw->size < FW_HEADER_SIZE) { + phydev_err(phydev, "Firmware too small: %zu bytes\n", fw->size); + return -EINVAL; + } + + hdr =3D (const struct rtl8261x_fw_header *)fw->data; + + main_magic =3D le32_to_cpu(hdr->main_magic); + if (main_magic !=3D FW_MAIN_MAGIC) { + phydev_err(phydev, "Invalid firmware magic: 0x%08x\n", main_magic); + return -EINVAL; + } + + sub_magic =3D le32_to_cpu(hdr->sub_magic); + if (sub_magic !=3D FW_SUB_MAGIC_8261C) { + phydev_err(phydev, "Invalid sub magic: 0x%08x\n", sub_magic); + return -EINVAL; + } + + num_entries =3D le16_to_cpu(hdr->num_entries); + data_len =3D num_entries * FW_ENTRY_SIZE; + + if (fw->size !=3D sizeof(*hdr) + data_len) { + phydev_err(phydev, "Firmware size mismatch\n"); + return -EINVAL; + } + + calc_crc =3D crc32(~0, fw->data + FW_HEADER_SIZE, data_len) ^ ~0; + file_crc =3D le32_to_cpu(hdr->crc32); + + if (calc_crc !=3D file_crc) { + phydev_err(phydev, "CRC32 mismatch: calculated=3D0x%08x file=3D0x%08x\n", + calc_crc, file_crc); + return -EINVAL; + } + + return 0; +} + +/** + * rtl_phy_write_mmd_bits - Write a bitfield in an MMD register + * @phydev: PHY device structure + * @devnum: MMD device number + * @reg: MMD register address + * @msb: Most significant bit of the field (inclusive) + * @lsb: Least significant bit of the field (inclusive) + * @val: Value to write into the field (right-aligned) + * + * Return: 0 on success, negative error code on failure. + */ +static int rtl_phy_write_mmd_bits(struct phy_device *phydev, int devnum, + u16 reg, u8 msb, u8 lsb, u16 val) +{ + u32 reg_val; + int ret; + + if (msb > 15 || lsb > msb) + return -EINVAL; + + ret =3D phy_read_mmd(phydev, devnum, reg); + if (ret < 0) + return ret; + reg_val =3D ret; + + reg_val &=3D ~GENMASK(msb, lsb); + reg_val |=3D (val << lsb) & GENMASK(msb, lsb); + + return phy_write_mmd(phydev, devnum, reg, reg_val); +} + +static int rtl8261x_fw_execute_entry(struct phy_device *phydev, + const struct rtl8261x_fw_entry *entry) +{ + u16 addr, value, timeout_ms; + u8 dev, msb, lsb, poll_set; + u32 bits, expect_val; + int ret =3D 0; + int val; + + dev =3D entry->dev; + addr =3D le16_to_cpu(entry->addr); + msb =3D entry->msb; + lsb =3D entry->lsb; + value =3D le16_to_cpu(entry->value); + timeout_ms =3D le16_to_cpu(entry->timeout_ms); + poll_set =3D entry->poll_set; + + if (timeout_ms =3D=3D 0) + timeout_ms =3D RTL8261X_POLL_TIMEOUT_MS; + + switch (entry->type) { + case OP_WRITE: + ret =3D rtl_phy_write_mmd_bits(phydev, dev, addr, msb, lsb, value); + if (ret) { + phydev_err(phydev, "WRITE failed: dev=3D%d addr=3D0x%04x\n", dev, addr); + return ret; + } + break; + + case OP_POLL: { + bits =3D GENMASK(msb, lsb); + expect_val =3D (value << lsb) & bits; + + if (poll_set) + ret =3D phy_read_mmd_poll_timeout(phydev, dev, addr, val, + (val & bits) =3D=3D expect_val, + 1000, timeout_ms * 1000, false); + else + ret =3D phy_read_mmd_poll_timeout(phydev, dev, addr, val, + (val & bits) !=3D expect_val, + 1000, timeout_ms * 1000, false); + if (ret) + phydev_err(phydev, "POLL timeout: dev=3D%d addr=3D0x%04x\n", + dev, addr); + break; + } + default: + phydev_err(phydev, "Unknown firmware operation: %d\n", entry->type); + ret =3D -EINVAL; + break; + } + + return ret; +} + +static int rtl8261x_fw_load(struct phy_device *phydev) +{ + struct rtl8261x_priv *priv =3D phydev->priv; + const struct rtl8261x_fw_entry *entry; + const struct rtl8261x_fw_header *hdr; + const struct firmware *fw; + int ret, i; + + if (!priv->fw_name) + return 0; + + ret =3D request_firmware(&fw, priv->fw_name, &phydev->mdio.dev); + if (ret) { + phydev_err(phydev, "Failed to load firmware %s: %d\n", priv->fw_name, re= t); + return ret; + } + + ret =3D rtl8261x_verify_firmware(phydev, fw); + if (ret) + goto release_fw; + + hdr =3D (const struct rtl8261x_fw_header *)fw->data; + + entry =3D (const struct rtl8261x_fw_entry *)(fw->data + FW_HEADER_SIZE); + for (i =3D 0; i < le16_to_cpu(hdr->num_entries); i++, entry++) { + ret =3D rtl8261x_fw_execute_entry(phydev, entry); + if (ret) { + phydev_err(phydev, "Entry %d failed: %d\n", i, ret); + goto release_fw; + } + } + + priv->fw_loaded =3D true; + +release_fw: + release_firmware(fw); + return ret; +} + static int rtl8261x_config_intr(struct phy_device *phydev) { int ret; @@ -464,6 +687,22 @@ static int rtl8261x_config_aneg(struct phy_device *phy= dev) return 0; } =20 +static int rtl8261x_config_init(struct phy_device *phydev) +{ + struct rtl8261x_priv *priv =3D phydev->priv; + int ret =3D 0; + + if (priv->fw_name && !priv->fw_loaded) { + ret =3D rtl8261x_fw_load(phydev); + if (ret) { + phydev_err(phydev, "Firmware loading failed: %d\n", ret); + return ret; + } + } + + return ret; +} + static int rtl821x_probe(struct phy_device *phydev) { struct device *dev =3D &phydev->mdio.dev; @@ -3159,6 +3398,7 @@ static struct phy_driver realtek_drvs[] =3D { PHY_ID_MATCH_EXACT(RTL_8261C_CG), .name =3D "Realtek RTL8261C 10Gbps PHY", .probe =3D rtl8261x_probe, + .config_init =3D rtl8261x_config_init, .get_features =3D rtl8261x_get_features, .config_aneg =3D rtl8261x_config_aneg, .read_status =3D genphy_c45_read_status, --=20 2.43.0