From nobody Mon Jun 8 07:21:43 2026 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB9673264DD for ; Fri, 5 Jun 2026 03:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780631700; cv=none; b=QhKG2z3M749V3k8ld6epbFLolZ4LQsc9wmLuaklhXzk7krW66b75zBcnuD6UTx7/fna2QkX2jJbhmeDMDrZ1ZWecLBP1hOL3htul9BQUY/hN/Fz+bKP+8dfAiYcH7UowswajF3BfydQLEpE+nmGTAu9NLTgc4TA1jDbU/GtcraI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780631700; c=relaxed/simple; bh=nM1BoT8PA92VKS01nonDSyd1jayFpvUtB1Z3IP5clv4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=YMsbDn9N8u92LXBqjxi+d36DFcojmLQ87PJaWxL0KC5YxsoDRk3oKPXhZvb5tIkg107oXpaO86k6O1qnGgS7NrJV0xOEDLkxgyDEncng6UdmO3+rcz30YL84JTOgjC6CujsRYljyTzS/a52M+vPMsBy5VIz6X5oBoxTZxO70wTc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pedtR+mu; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pedtR+mu" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-7e2fc11088dso13363117b3.2 for ; Thu, 04 Jun 2026 20:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780631698; x=1781236498; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vgCSFytiH503jBumxd+MnT5KFyiCQKUlxBkeTHeZkWI=; b=pedtR+muu0qMSr4UBbFOgSkAyIJPnCz/BfftoVHqCp+op/f5zguxoLdqGO0RT/NyNs zFxks7uqRyvv6SD5sqeWD8vS79MfWY+Hbsot7XJDnjnU0TyeuP7TNONKuijXmk9tdaDR q+musxHw82Hmv0xOzlOB+6vNcoCaXyyEb1T+t3C3g/pNOkZ5fmAc/OO2A2TuOv5Aj9Ic wiLc17WXm0VDYJOL07F4GxyKXIxqlo82Pdzx2LKxi5iMdnbqgB+MCh6R4HtF4oFad9GS J/cua2l4+/WCbKHScGUyvmLqQO40SCV0hydj/6H6WPCVzbGsLO/XwNRl6O8nm4eAaPrt /H5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780631698; x=1781236498; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vgCSFytiH503jBumxd+MnT5KFyiCQKUlxBkeTHeZkWI=; b=LFQFbo0LylwdWV+kANI7nXbWZF6HNz7Bz6ZMn4ICY2HAKkx9lEMtQmxccqatioYyNW qZUR4EyifKWqqCRrdfaUaqBv3ypuhRDb7TBZv7glgAS1AYgz4Pz6QNHI39IFI4PGVb6+ I92q+pa1GJoYWHY4MnbFi+8Iq9vjCV6TmAMDLU41mfGyrKrNC3zcRYHCEonA7uUv16MH ujDhkAPjhTNop7vnb1Vs3fc/3Yy5mvbCTWzE44udI6SmYsTQAf87n0Ah5kguoTs5rOYn vlPI/dhWKuRVuvVFrIrsHA7et/nPeveJjPDFOz8lddJBLBEq1VUfV1g3gvlKmzBIxQn5 +uZw== X-Forwarded-Encrypted: i=1; AFNElJ9o9KXglCvwkcYQxD1CFzDiCIGsth2s18D26QZS2QsfnUdpLSn6dvzznc34w8d9CMNQ7JL1VU46eN/Jnis=@vger.kernel.org X-Gm-Message-State: AOJu0Yzqls8JsFK/3qYz/7pq8Yf8tXsxHSrfazAD741i5WVifqAwN7Qp GBy8qIH3EW6WKi4AKxGQ2a3hV3mwJSk05i4k38+mfLOTuvgmivqEckLH X-Gm-Gg: Acq92OHT5rwezs6AlNVl3cgBtaA2l7QABb7tUBdaxoRikf5Gqn8FtCtnTOBXdxOnwFQ mvYsTpTN26QhlIKbx4H35FcDXZl3GfMIZHGBdKJO+0NTyBT3BY8yZNa06E5CWfO5NmKJt9W0bIi lwvUsssycO//G88jY22rfJcGxmqhT0oEV+lKI6BL4y4TSjZ6xKCb1TWG3qFjv3SVsmfZ1L9Iffi ak1os1YlOb5iX9iqzaUmTmhsKA3X3IXEknuWwmcHQgtl6GeDITcLQvu7agi9huaA+bDKzGt7Pi1 9dh3idMdn11MzO2ngDIA8icMSWv+GChPBRHhfZ7mq8E5UtrpoYzf1ezqNlDIFZE8595++LDBdvI do3fAxtD2a5opgAmvWp8DZJkGM/nUG3pp8OZ9L/mMaorI8Qy8HGrF3LVFf+GftyS5TiCrpN1gz6 MSBJ0atVO+REB56veOxRk21Z/23zqv1BKRakVJwNzblIo9lI9Iru6kcY+EUlLJ+zDCsehdk8g9T xM= X-Received: by 2002:a05:690c:e3ca:b0:7e2:47b0:1d5a with SMTP id 00721157ae682-7ed0a9d6de9mr18328967b3.12.1780631697790; Thu, 04 Jun 2026 20:54:57 -0700 (PDT) Received: from i-use-arch-btw (c-67-187-47-172.hsd1.ga.comcast.net. [67.187.47.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7ea23a99b72sm44468237b3.38.2026.06.04.20.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 20:54:57 -0700 (PDT) From: Maxwell Doose To: Andrew Morton Cc: linux-fsdevel@vger.kernel.org, Maxwell Doose , Fabian Frederick , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2] fs: efs: Remove unneeded debug prints Date: Thu, 4 Jun 2026 22:52:51 -0500 Message-ID: <20260605035251.89305-2-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The current code uses debug prints conditionally compiled with #ifdef DEBUG. However, that code, when compiled, causes compiler errors due to incompatible formatters and undefined variables, notably: fs/efs/file.c: In function =E2=80=98efs_get_block=E2=80=99: fs/efs/file.c:26:35: error: =E2=80=98block=E2=80=99 undeclared (first use i= n this function); did you mean =E2=80=98iblock=E2=80=99? 26 | __func__, block, inode->i_blocks, inode->i_s= ize); | ^~~~~ and: fs/efs/file.c: In function =E2=80=98efs_bmap=E2=80=99: ./include/linux/kern_levels.h:5:25: error: format =E2=80=98%ld=E2=80=99 exp= ects argument of type =E2=80=98long int=E2=80=99, but argument 4 has type =E2=80= =98blkcnt_t=E2=80=99 {aka =E2=80=98long long unsigned int=E2=80=99} [-Werror=3Dformat=3D] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ which also extends to the other formatters. As this part of the code has been dead for just about 14 years now, it has not been modernized to stay compatible with the most recent gcc compilers. Fix these issues by removing the debug prints. Suggested-by: Andrew Morton Fixes: f403d1dbac6d ("fs/efs: add pr_fmt / use __func__") Signed-off-by: Maxwell Doose --- v2: - Change commit to remove debug prints instead of updating them to pr_debug() per Andrew's suggestion. - Change commit message to include compiler errors noted by gcc per Andrew's suggestion. fs/efs/file.c | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/fs/efs/file.c b/fs/efs/file.c index 9e641da6fab2..9153dfe79bbc 100644 --- a/fs/efs/file.c +++ b/fs/efs/file.c @@ -18,16 +18,9 @@ int efs_get_block(struct inode *inode, sector_t iblock, =20 if (create) return error; - if (iblock >=3D inode->i_blocks) { -#ifdef DEBUG - /* - * i have no idea why this happens as often as it does - */ - pr_warn("%s(): block %d >=3D %ld (filesize %ld)\n", - __func__, block, inode->i_blocks, inode->i_size); -#endif + if (iblock >=3D inode->i_blocks) return 0; - } + phys =3D efs_map_block(inode, iblock); if (phys) map_bh(bh_result, inode->i_sb, phys); @@ -42,16 +35,8 @@ int efs_bmap(struct inode *inode, efs_block_t block) { } =20 /* are we about to read past the end of a file ? */ - if (!(block < inode->i_blocks)) { -#ifdef DEBUG - /* - * i have no idea why this happens as often as it does - */ - pr_warn("%s(): block %d >=3D %ld (filesize %ld)\n", - __func__, block, inode->i_blocks, inode->i_size); -#endif + if (!(block < inode->i_blocks)) return 0; - } =20 return efs_map_block(inode, block); } --=20 2.54.0