From nobody Mon Jun 8 07:22:47 2026 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30A333C76B9 for ; Thu, 4 Jun 2026 20:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780604793; cv=none; b=evokkUeTLngFxYIi3xvodlklNCBiwm7r2S8pd1RXEfvdxn63tajw0QKModUtbVhkIIiyoqDSMX8m4iqHZxzITQEELnzzsiITREXCMEXUX8DqBilzQtUgG1b6WObe4d7SxRnhmmShJuiZz80ws+CY656mUka9LrHMy1Fr7Fg0fuY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780604793; c=relaxed/simple; bh=79OdSiCOA8bfkBLSXiAGIpdzI2DhPqd6pAwVxY1QUM8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G/HkO7aBgGqkz/3WBeC2+c5/UUtfuMZa7/jQbmjDqAu1CFMRbIH4YmlKwgeNnijREGDBA+n+R8LWE3gh6FVLpoUgy5FGFW0sYkBA12/Ky00toLRFgRQp7qtEQyct8z9Bx6EyaVt62k++xwoaSuupVcdGzuf6WDLKSNsVo8EJwZA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BfVUbMGy; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BfVUbMGy" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-7e2fa3062easo12571537b3.2 for ; Thu, 04 Jun 2026 13:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780604791; x=1781209591; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=w+n5peWVUmr1BizDBiXhAWWD/s5YnzEWy6U0hE/Dv/c=; b=BfVUbMGy/qddMBUh3IGnZvZqTfHYRzBod76YezE4ZTtFzXbak/XVc9ld/4DPzIiV54 ghbBbNt85XLVTsLPndKL8zBOOj6Q/ffEJq+DdazMvt/AdGXAFaScq8PpPaH9dvu54pxr y7MqyFSY1DRdLTOYRZ2pVGx1OS61pC3qTDIo5+ikgS5h7qfJNgwMQ95NxWerrK7KGC2L emauuy2/w9gWBAT+bJtVbQzodGyvb3fXGiNW7Ro8aLw+3c2e73mtFqlcWcnR1QUSee9v jWoea6Iz+KfM9mDi39Zyo62HYKilRSNMCgufKJU741xeuGZAJ4giETCBCGdKjpLS3CdS pPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780604791; x=1781209591; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w+n5peWVUmr1BizDBiXhAWWD/s5YnzEWy6U0hE/Dv/c=; b=dmQ06gSaPpR9+ZYiCrPAzzCdY4kycghKqpUl2J12piFJdYtNyV7annZ4tePs98leKe BsYk8VVO+NR4aPev/RQFxvGR1bZqHpHE3uc3feJgxJv4nRBRC0o+ZSBBD3LH1vOOMzb/ ZnbgDhehTwjicw24r1u0cExATPoDjPNW/VubqXDk6wDXmqpMDXMZogjibx9qZQRU+bg4 9GNu/3sABBEwKFh7FOv7VraXJkJdVu0DzWrcyhFTWVS/CBAnP2+z+zX8xrJP1lEwRFo6 0VT5Wmmn8c5xQvxvfmc76f8kKPe+YTtnuh77WppA2lZ8mOkhJ9Js9rr0M+SzxhABLkHr nk2w== X-Forwarded-Encrypted: i=1; AFNElJ8uHq3Ax3JvxIU5AsqluNB/7O39ibY4Ulh5c5rlKreGbsIZKLCZ5BKtXKdpSBHYU0WTgVg0AeOBhYG86aI=@vger.kernel.org X-Gm-Message-State: AOJu0YywsUrgEqQb/3zXCXa0RE+fMlrLnTdjtrOnM9mFiuemrMRG/XCB MtRGEI2z9eMyi1i2VJHMOVf8RBFxn8SdyoEieUGPVyMxNFJEl3LIFy3u X-Gm-Gg: Acq92OHoQSxNl0HRqvUzTh1Cv5I0f3gl3IIxIWfCGCElEgkYnmAtoxqeIVpoTsBZIkj ellZ2LBT5lD1HysewFwlRUuFYeTuVSffJkpJRfnwo8IOgmV3AzbVT5l/GSsU5D5sbmUTQmmmJOh Iu6nvL9MtNqSeOTQs0aafVS+ogWUFAEgEtJyLypB0B9gU0fuaf4zRmWhap/s/JHfClomW60ClAl lyD+20imUmZe0bPaF8C7toc4T3O2BmsLWEs9MRSI/UrW6W1YQbtTlT9sCkgG5ELD/0SVj19sOId OXF1mJrUCQbL9yJT6MoEnzM7M69DLQod4pyi7TJrmEPsIousB5tQJn5D492xLF2KKpTluVcdsrn DqFMNXVPJd0WmIg5zKCvM44UBaxKTt5ljhQ4cVeiYF4dEYy97HpM8y2rlqakFXS5WR5WgpGyiom AkUBixH/ZF1fVWDgoFrgDz/HxnYf6ih9tfcXzfU5Stldz/QVslgj9/0b0w2Ab3lwKOMwG8TwSjt Ic= X-Received: by 2002:a05:690c:c24b:b0:7b2:136d:2436 with SMTP id 00721157ae682-7ed0a4ed3c3mr6103407b3.8.1780604791136; Thu, 04 Jun 2026 13:26:31 -0700 (PDT) Received: from i-use-arch-btw (c-67-187-47-172.hsd1.ga.comcast.net. [67.187.47.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7ea20ea986bsm40195167b3.9.2026.06.04.13.26.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 13:26:30 -0700 (PDT) From: Maxwell Doose To: Andrew Morton Cc: Maxwell Doose , Fabian Frederick , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] fs: efs: Fix compilation bug and use pr_debug() Date: Thu, 4 Jun 2026 15:24:40 -0500 Message-ID: <20260604202441.65226-1-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Firstly, the current code uses formatters that are incompatible with the most recent GCC for x86_64. Replace them and explicitly cast the formatted variables to their respective forms of long long. Secondly, replace the legacy conditional compilation for DEBUG with the more preferred pr_debug() to condense the code, while keeping the final output functionally identical. Fixes: f403d1dbac6d ("fs/efs: add pr_fmt / use __func__") Signed-off-by: Maxwell Doose --- Test compiled only with gcc 16.1.1 for x86_64. fs/efs/file.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/fs/efs/file.c b/fs/efs/file.c index 9e641da6fab2..625b715f2d96 100644 --- a/fs/efs/file.c +++ b/fs/efs/file.c @@ -19,13 +19,12 @@ int efs_get_block(struct inode *inode, sector_t iblock, if (create) return error; if (iblock >=3D inode->i_blocks) { -#ifdef DEBUG /* * i have no idea why this happens as often as it does */ - pr_warn("%s(): block %d >=3D %ld (filesize %ld)\n", - __func__, block, inode->i_blocks, inode->i_size); -#endif + pr_debug("EFS: block %llu >=3D %llu (filesize %lld)\n", + (unsigned long long)iblock, (unsigned long long)inode->i_blocks, + (long long)inode->i_size); return 0; } phys =3D efs_map_block(inode, iblock); @@ -43,13 +42,12 @@ int efs_bmap(struct inode *inode, efs_block_t block) { =20 /* are we about to read past the end of a file ? */ if (!(block < inode->i_blocks)) { -#ifdef DEBUG /* * i have no idea why this happens as often as it does */ - pr_warn("%s(): block %d >=3D %ld (filesize %ld)\n", - __func__, block, inode->i_blocks, inode->i_size); -#endif + pr_debug("EFS: block %llu >=3D %llu (filesize %lld)\n", + (unsigned long long)block, (unsigned long long)inode->i_blocks, + (long long)inode->i_size); return 0; } =20 --=20 2.54.0