From nobody Mon Jun 8 07:21:45 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83F023672B7 for ; Thu, 4 Jun 2026 19:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780599943; cv=none; b=hI6EsUvxhSAe1ULykUKBWOTn/s6uIEqm5Y1G8s8RwMwNOXl4ttEOVgrgVYAnKQEj9qyEICD3Orm1xuxVkPMntmjKxE8Xivpz8a7XDH3dD6zX7N/5nwGzn3KH67uXfrVx6Y6cMFC4DKe3aPmtfcIr2a4ihnafr4yyPIQhG4hjDGk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780599943; c=relaxed/simple; bh=t7HTSXQedCZiYZaYzlpBFRKtS8iVv2rqPb54+tDX3TM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DVkHErHBe5K4Hyxr0eaQq6+rPv9UG3ePs616LUlieqhNC4dX/WrrG1E1v+Y9VVj7oK7PkGnNqdY4gTJ8M9AuXt386cHeGQEwGKp3qFClFUAWWCccAwDrsTGjFFMaSbM/iPWIghYsiS4MlHiYB/1FUubl4TnhZLZTVdTKY0Vk8k0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z+nvjf+I; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z+nvjf+I" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-36ba3ea5c46so701292a91.1 for ; Thu, 04 Jun 2026 12:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780599941; x=1781204741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/ffqDjSgGQ5QaASBEo3eqt9MQXd5NnLhzD6IscnM1OA=; b=Z+nvjf+Ir90ATMKFg4FQmsB6IQpDBIsH8RDSMzGKr9mDnVgkr2NJkUlZf75dcjv0Kd +SJv8Wrwv8svtFXUud0fkflzK0AMvfmp2zbIryBeHAlmexHcIchTbqm4W4SE6Rz5f9AM EXuTRSOtITVr+gjGH3+9ghCdNj6Hh9wuocO4i3w89vjdDOVj9d1f+VNA10sajJ2ou3ur hWhMj0k9rVhbpXOThI2mUsh270h6qrjgxQh0A0dq1nbEsKXeKk1Seipqtl/XE99IH5ON cTDUEstoi2EKmqBzOf0LrkxnGPPHbL68XDbDmo1Z1JkB9LiT8wmViwskd9aGXYaIXrp6 oq1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780599941; x=1781204741; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/ffqDjSgGQ5QaASBEo3eqt9MQXd5NnLhzD6IscnM1OA=; b=fQ9GpBh9wzk7y86kmjGWAiqY7uim5nqwOddGAF4zBg8Ps4kfhQcLaX+o4nO7DEa7zt ZdLOrbkO8Tc3O+QqQb1ZWcZS91nNU/ZIK4Xn7P/lCbNQRF2sqRu9vEfMf0Tvf+o3rHJt sYUVWz4NkN4pwYuw2dFJPj2DgJBgup9qdqchs+z9U+Wiumk6f11wDguzsXwMTyl0rUML oSb5ZPxNMAG6HQdhmJItlIrb9ChUI0N2nyUGCRS/krWGKwL0R4R/wtznIBeQwp6ZBstz 5RoWsIiB/7I2pBKFo5h3LtD4CsAzVGLU6UBoGijp3cobgNuBvA0+p9L19sm2+WZwdYBh A9Qw== X-Forwarded-Encrypted: i=1; AFNElJ+IrS5wYkZbaeQ4b4t+XGmhUfc1RLCvKLwtHtgMl+beAtJ9/4IiNVUfWV5ojfZZOTP3qJMb/cT+yuvGeWs=@vger.kernel.org X-Gm-Message-State: AOJu0YxaAfvIX+fHGX0Gxi4ORYUxJd4ehSEtHMysuMCq5qc1JBGQ9xG5 iRZT6SXKpTMykHBkSnVj7ronSAd6ymwRJ40+/Iuln5YpFP+SjOxTfAS3ObG7Kb6x1yo= X-Gm-Gg: Acq92OHjjcoaTZ3wr07Hoidr7tOw18CVDzPKrRvUqZkmr7z7IAbEjNCXUSTiKfC0U0/ H9NapYZGELPvRLmLOaq2pRMlBuvAiFYjzF+k+wy4vUCxQmpa6Sqph+j+GPCW+wS6GNErqVBF/+R Cu2iCnAXdUUnvP7yxkORgvxWbsDhhJvDZyheDS/tb9EfmbXG9CY99umnRPLxVZzoY33/E489IRK 4qzA92peVKKkXb0MLxGcz/eiJpgHyhOQD1JCanDg3rxCyInNB62qDREiFdLygueN0CTas3+ZOje qn3MsMG0kdGmg6+lvWngX2OJR5uemDpCq9aZEuyj6hzcmp5Eb4kHaHX9Lou0I1/kIS0LIkIobU9 Y8PmOyLitiSkGC6ZqxmPBdhIT5W39nbWHuguDm2iLr1PqropPKJBPI7NzXo3AZoyXyQe8cOFmja MnZ4aznUEQQuKSJW1v8OJHcYbWWfCWXDHGkcsm2I5Olk3KEGN77KdAkgAlDfS3GKmriUv2Y5YF X-Received: by 2002:a17:90b:57c4:b0:35f:b647:d98a with SMTP id 98e67ed59e1d1-370ee64373dmr263208a91.5.1780599940600; Thu, 04 Jun 2026 12:05:40 -0700 (PDT) Received: from archslayer ([2607:fb90:7781:358:d68e:f592:7305:af5a]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df032df5sm5818299a12.6.2026.06.04.12.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 12:05:40 -0700 (PDT) From: William Elder To: Greg Kroah-Hartman , linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Cc: williamxelder@gmail.com Subject: [PATCH v3] staging: rtl8723bs: remove comparisons to boolean literals Date: Thu, 4 Jun 2026 13:05:07 -0600 Message-ID: <20260604190508.404642-1-williamxelder@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove comparisons to true and false as they are error prone. Use the idiomatic C forms instead v3: Fix inverted logic for ht_option checks Signed-off-by: William Elder --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4cd9..1f7f24dc8f7c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -236,7 +236,7 @@ void Restore_DM_Func_Flag(struct adapter *padapter) =20 void Switch_DM_Func(struct adapter *padapter, u32 mode, u8 enable) { - if (enable =3D=3D true) + if (enable) rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_SET, (u8 *)(&mode)); else rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_CLR, (u8 *)(&mode)); @@ -340,7 +340,6 @@ void set_channel_bwmode(struct adapter *padapter, unsig= ned char channel, unsigne =20 center_ch =3D rtw_get_center_ch(channel, bwmode, channel_offset); =20 - /* set Channel */ if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->setch_mutex))) return; @@ -847,7 +846,7 @@ static void bwmode_update_check(struct adapter *padapte= r, struct ndis_80211_var_ if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (!phtpriv->ht_option) return; =20 if (pIE->length > sizeof(struct HT_info_element)) @@ -892,7 +891,7 @@ static void bwmode_update_check(struct adapter *padapte= r, struct ndis_80211_var_ pmlmeinfo->bwmode_updated =3D false; } =20 - if (true =3D=3D pmlmeinfo->bwmode_updated) { + if (pmlmeinfo->bwmode_updated) { struct sta_info *psta; struct wlan_bssid_ex *cur_network =3D &(pmlmeinfo->network); struct sta_priv *pstapriv =3D &padapter->stapriv; @@ -931,7 +930,7 @@ void HT_caps_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (!phtpriv->ht_option) return; =20 pmlmeinfo->HT_caps_enable =3D 1; @@ -994,7 +993,7 @@ void HT_info_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (!phtpriv->ht_option) return; =20 if (pIE->length > sizeof(struct HT_info_element)) @@ -1689,7 +1688,7 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeex= t, u8 *pframe, uint len) pmlmeext->bcn_delay_cnt[delay_ms]++; /* pmlmeext->bcn_delay_ratio[delay_ms] =3D (pmlmeext->bcn_delay_cnt[dela= y_ms] * 100) /pmlmeext->bcn_cnt; */ /* dump for adaptive_early_32k */ - if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done =3D=3D true))= { + if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done)) { u8 ratio_20_delay, ratio_80_delay; u8 DrvBcnEarly, DrvBcnTimeOut; =20 @@ -1737,7 +1736,7 @@ void rtw_alloc_macid(struct adapter *padapter, struct= sta_info *psta) =20 spin_lock_bh(&pdvobj->lock); for (i =3D 0; i < NUM_STA; i++) { - if (pdvobj->macid[i] =3D=3D false) { + if (!pdvobj->macid[i]) { pdvobj->macid[i] =3D true; break; } @@ -1762,7 +1761,7 @@ void rtw_release_macid(struct adapter *padapter, stru= ct sta_info *psta) =20 spin_lock_bh(&pdvobj->lock); if (psta->mac_id < NUM_STA && psta->mac_id !=3D 1) { - if (pdvobj->macid[psta->mac_id] =3D=3D true) { + if (pdvobj->macid[psta->mac_id]) { pdvobj->macid[psta->mac_id] =3D false; psta->mac_id =3D NUM_STA; } --=20 2.54.0