From nobody Mon Jun 8 08:28:39 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B802132E6B4 for ; Thu, 4 Jun 2026 15:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780586319; cv=none; b=mkuK1L0WojRGuZDhlx3dGeNyZ5A43oy1XOesKOLjP+WZgNJUf+LHKtGCPug4E4jPLrtX0RzaAyMgdH2iwdEHFeCiym/fXKWcSx4RQaRR1dhA5UAFA1Ezr9DpzDEN27Ax4VASGRm69OBOsocGh4pY2x+JFGEzKkZZa5BuBAx5qhk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780586319; c=relaxed/simple; bh=em2KQAPhKM0uW1X1phxTeteq6dH38ymmA9Hf2LQIZ2k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oH195xTovG4SeY4pAQYYKIAvfSZa3s/gIpX//tCUMUNsl1w1lssn/2cf5ZNdw0jCMQ2WNIG/M2SrEC8oURUwBb6qNA1eKnHtLYnF+q9xpxNl0req8I5s9wdVC7Xlo40ya4FxEWFph98GDB6t35RovnqVk1RmtF81mGf2hJiTAqc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cGN0Lecj; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cGN0Lecj" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490acbb0f89so5792955e9.0 for ; Thu, 04 Jun 2026 08:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780586316; x=1781191116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xQlKzjy8hie3RNjzE9LgS6V8/SHKqgabG5RGtEYZidc=; b=cGN0LecjXdIsPXE5HPCBPU6W9UK1IVedJXyjXnpFWdm+xEKO5Cl9kDFJ2du6VBS25n d/qooMI4It6dChexgWllfXOOthyQfi88Yy2j7udQkM6SHvKqqTQkdDpgCGDY4OSw+5T/ vAIH29eIJFluezV5NnUKOdjuD9FzQPfG8pN4y8N4vhgmG8BlyTovUbALxOd8TbGTYJkS mZcTbgtOFsQYBOdVigDyBfACE8zCoenjovmv+b1vezxE4c5jklJVsOMt2tPBtL61rr7P f4GXgqM98Cjh8Q0yv5QPQcaPOnHWTpRt3XXR7c6XUR5K4a9aP8ysuthnPuvzYVc2oj5z tvxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780586316; x=1781191116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xQlKzjy8hie3RNjzE9LgS6V8/SHKqgabG5RGtEYZidc=; b=tF49YhCu9rsu3HuIE41Z72085MAoGARzRleeejpEWNj5LDA1tfPDOgaBLDczTfwi/h i10q6/1VZt0BYvrVBzNcU+TTGnN+N5pI9XOVkISpLWZkQUoDgbvhol2Au8xZxddnsHGY NQ2wj6uxR9k8OnbuF4aKTMLjUiTtw+l0izHkUbPEIalkJBaYS0DruSUfe1oSF/+5qA0m yX++RpkFX2JXueV0N7Rx5C3b6/4sbXg0v1H5zruQU4Ii58TlUXWeUY5gZW5u94amS0yP xyglG/Qoqkg4O9G8NTPe7pBVkWIliUaZc+vny0+yUQ0f7/ZJotQrotdgQeAbvroq5Np8 q0kg== X-Forwarded-Encrypted: i=1; AFNElJ+vtREx/Yo0GuCA0CHfHthYLvA8KTzcNZYnNpWbtpw46kRzppRBb17DagJm6iKZ5IChTCeJ89mgnie3Ts4=@vger.kernel.org X-Gm-Message-State: AOJu0YwrTf6Xo2ajd6bFl5yAcVeurp8geEuIGR7czu0gPU+Tb7otYTi0 VF03IkTmr2/jWgYQ5uC6FzqJ5larMjn3ysGJ8pxYwFc+DZDvUY7HZTvBm42JQg== X-Gm-Gg: Acq92OEj/u9bXmhh4XpxfVNc7fB8IhqMW5W14V0bGuD9C6yyUL7LVvVkBzFEConejyV gwlFdTaLaJLPb/bxWJ9OfIr4yJEkJ1jvuDsBxxuJpyoXIhSfABOkqZao+tAX6wTt5RRgrllulpq L3VxkVbO9QjIRjSdIgNWIOUmhyvNDCRQPCOmDdDzFO/huYAA/wNCO3lwIy7/0H85TQarwjVM1QF 88Se3dvaeQtBIL/rFLyij+ba4Tbx5KMfnpfGkgX9tEU4PoCNEGj4Su16322XteVcNIRqona4g61 nTjXv5wZFowfYK2CM8prX5MZq1NhLbJJ7j3rgQEI44hFWE2I5KfOzfwe4oRr+V5dJPUje5PVrM6 964RSRA8khwM32bTNxigft4UesaS6Wner9f6IiQ1AJ73F93YBnm6mq22uy1hHXoKjOhCoQbvCSa caGLwCTCa+bv0V4Z767MrazF2gC6/NWoj/VDw4x1thpKZ1RBeMf5MB+5ryRHBV8ah7dvdlav3Hq Ggiql1B645pPw== X-Received: by 2002:a05:600c:458b:b0:490:a296:fdad with SMTP id 5b1f17b1804b1-490b5fda850mr140350455e9.24.1780586316002; Thu, 04 Jun 2026 08:18:36 -0700 (PDT) Received: from fedora ([102.78.155.64]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2ec711sm16534398f8f.12.2026.06.04.08.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 08:18:35 -0700 (PDT) From: Jad Keskes To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Jad Keskes Subject: [PATCH] staging: rtl8723bs: replace beacon timing magic numbers with named constants Date: Thu, 4 Jun 2026 16:18:28 +0100 Message-ID: <20260604151828.242801-1-inasj268@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Decompose the beacon timing magic numbers in rtl8723b_InitBeaconParameters() into named constants with bitfield expressions to document the register layout. REG_TBTT_PROHIBIT (0x0540): The value 0x6404 splits into hold time (0x64) in the upper byte and prohibit setup time (0x04) in the lower byte, in 32us units =E2=80=94 matching the layout used in the rtw88 driver (WLAN_TBTT_HOLD_TIME << 8 | WLAN_TBTT_PROHIBIT). REG_BCNTCFG (0x0510): The value 0x660F follows the same bitfield layout as the adjacent EDCA AC parameter registers: AIFS =3D bits[7:0] =3D 0x0F (disables contention before beacon Tx); CWmin =3D bits[11:8] =3D 0x06; CWmax =3D bits[15:12] =3D 0x06. This layout is confirmed by rtl8192cu which writes 0x66FF (test chips) and 0x660F (normal chips) =E2=80=94 only AIFS varies, the CW byte stays 0x6= 6. Drop the misleading "ms" unit comment on REG_TBTT_PROHIBIT and the outstanding TODO marker since this was the last item it referenced. Signed-off-by: Jad Keskes --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ++--- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 13 +++++++++++++ 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index e794fe3ca..4afba1252 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -878,8 +878,7 @@ void rtl8723b_InitBeaconParameters(struct adapter *pada= pter) =20 rtw_write16(padapter, REG_BCN_CTRL, val16); =20 - /* TODO: Remove these magic number */ - rtw_write16(padapter, REG_TBTT_PROHIBIT, 0x6404);/* ms */ + rtw_write16(padapter, REG_TBTT_PROHIBIT, TBTT_PROHIBIT_TIME_8723B); /* Firmware will control REG_DRVERLYINT when power saving is enable, */ /* so don't set this register on STA mode. */ if (check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE) =3D=3D false) @@ -888,7 +887,7 @@ void rtl8723b_InitBeaconParameters(struct adapter *pada= pter) =20 /* Suggested by designer timchen. Change beacon AIFS to the largest numb= er */ /* because test chip does not contension before sending beacon. by tynli= . 2009.11.03 */ - rtw_write16(padapter, REG_BCNTCFG, 0x660F); + rtw_write16(padapter, REG_BCNTCFG, BCNTCFG_8723B); =20 pHalData->RegBcnCtrlVal =3D rtw_read8(padapter, REG_BCN_CTRL); pHalData->RegTxPause =3D rtw_read8(padapter, REG_TXPAUSE); diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/sta= ging/rtl8723bs/include/rtl8723b_hal.h index ffd039278..81105c55a 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h @@ -72,6 +72,19 @@ struct rt_firmware_hdr { #define DRIVER_EARLY_INT_TIME_8723B 0x05 #define BCN_DMA_ATIME_INT_TIME_8723B 0x02 =20 +/* REG_TBTT_PROHIBIT (0x0540) - TBTT prohibit hold/setup in 32us units */ +#define TBTT_PROHIBIT_SETUP_8723B 0x04 +#define TBTT_PROHIBIT_HOLD_8723B 0x64 +#define TBTT_PROHIBIT_TIME_8723B \ + ((TBTT_PROHIBIT_HOLD_8723B << 8) | TBTT_PROHIBIT_SETUP_8723B) + +/* REG_BCNTCFG (0x0510) - beacon AIFS, CWmin, CWmax (EDCA-like layout) */ +#define BCN_AIFS_8723B 0x0F +#define BCN_CW_MIN_8723B 0x06 +#define BCN_CW_MAX_8723B 0x06 +#define BCNTCFG_8723B \ + ((BCN_CW_MAX_8723B << 12) | (BCN_CW_MIN_8723B << 8) | BCN_AIFS_8723B) + /* for 8723B */ /* TX 32K, RX 16K, Page size 128B for TX, 8B for RX */ #define PAGE_SIZE_TX_8723B 128 --=20 2.54.0