From nobody Mon Jun 8 08:28:17 2026 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CD8E2749DC for ; Thu, 4 Jun 2026 13:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780579036; cv=none; b=CWWx08zl6PSQdvF5jLclMm9vw0FGgEEoEBn7yF0uIb1URDZIT39Wk9tp/Ih3bn6Qd7cT0pHpcFg9yH3KfBstdMs2Nt1xf1JtNLYUYdKHX0/JJlVvKaodfEjnQiQGK/JQJ72HvFwrp8lcaglqyoSdHFgxiVSTUuZm93Rn0e89JxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780579036; c=relaxed/simple; bh=zo5TbhHUky/9AbbJa4J3DCTQeu3dka87sdS4FfXHqc8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GtRvztvGXmGG3p1aWNaAtaCcvQ2tHr3uHivnhv2wJ0iEpEuPli/818jI/pxTl0U2UwhXjXeHBYs6W9Mz7AC313g9qhHizAm9Gm0u+QTNJVQnMtsW0lbpb9NWnUkxPz0rQWIFZaHO6cSMSUzVPVoQgcuRN5MsA4pRldKKH+6arPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jM1dlTy8; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jM1dlTy8" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-7e8ec43e5f9so9598697b3.0 for ; Thu, 04 Jun 2026 06:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780579034; x=1781183834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QDM8Xoj5ZoqsbCsa/gDTbPX+rOqL1i39Hi5xHM5ECCo=; b=jM1dlTy8wR8aeewKFPH+VmTm7nGDv6GLvYS8frK6sqvA21rSWdVWFCTM8RS1szlcsy N4+gDM1/k0JOWhUWVNNEa9E1VSSLbeWkii7MN+OGsHlfzCJ1QmrFvbxglQuadk5RaX6R f2098tQEsDe40tIMsJfzc5o0UXjFs4+PKpbmR8GFRG7X7fRCAjkmNWQButTPp838CzcB OOIFCd+ltw/W7QDpTB437TsOXobs5UVBcYGHE5MF9WAlKVUWui133yl3fqw1tnud7EmX Dv3V2mEXuccogl7NNgSTR6jWP7WSWm1yShJ6IYRZggxGiCTAv4T9awnJzeBKdDnhOvoE sHhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780579034; x=1781183834; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QDM8Xoj5ZoqsbCsa/gDTbPX+rOqL1i39Hi5xHM5ECCo=; b=fpG1n3Eyyb7WOjdN/TF9fskrecuK2ia/VocHUBtn/C6v2YUPzGr/WkIHIqhZcuVJI/ 6yan5wWeFOKmF6MNV/SxepGdS8iNhoIfXMML2NGqjOBwzSWCxLvafv77hSrt+VHMA9l2 s41qvOKQ9SzlO2wZsDDaBU/LHFypoKd444hKMypESoyc8j//rGu46ihCoz8D5c11fP01 YxzcpMAQRCZ/PD5u6osB662eAi2TVxI7OV3hpMcOKYBeOaeS2Au5ZGxCUSktBNsRXZ9X VHEYWmZ6STlKEsyNrFJXV+Y+XWCmT/EczUkCUBbAcY5es78NBv8tyrevBcP1eDOT2ySv OxZQ== X-Forwarded-Encrypted: i=1; AFNElJ9Os1Vm+8omsB3PbQU5yNmmS0+gqBn6kCSlSbx68uXnXkBjQBs5g+k/8MHqgNJGWPTgYkT+e/IGlKbDOMo=@vger.kernel.org X-Gm-Message-State: AOJu0YxymF2JGXl4Eagp9+OOKUUMPNdbcLhgZWMJXoTOgVJ1XCC7SuSQ m8NHDx/N/lztVo+knU5Yvkze7qpKkAPpLaUIlFj0uUVEuGc/YsSRYf+F8zhJvHdce7s= X-Gm-Gg: Acq92OH+73ue58MPdP+IOkCFHj8XyKxSKu4aoNVDJhkZtUKDmTOIbvr6xTDsAH5Bcfc 2T76Wr+xEZMq5zOQ2uj/hfO2AlHy52H1d0JDO/Wm1GtmlLykeAeIIgFA49x30mBZSJJeVY+D+Bf D6X7A6HX9KROdLVuNLO1AzYag81bP7Ifb74PXPgYt2AW0q6KZyhvOMZAHdviImkz5d/mw5j2/SQ 92/xm8VIt9ylhCe0Dn8ZlbPkmqnUvXeVR6rvN9GWmB1QYA7IY0UNfEZfS6WhGWx84GZ8FQicVA7 8E5gvPNsZKNNByz+tgDa504frC39US6AqO01dOoH9p/uYtyUsRYF+lUDDuUoyqyJ7uCk3fmeq07 rPLvNwxZuJqhsq/iERDOiL2B6Xl+yjwh+VktFfVDWPd00itiO/y+orsc7QEFSysxvh7GXr1cyt9 YqSRb3l8uRGKFStVVFB8bnnmruKp8AV4GsvAuhXZ6cMnrf/PyMPVOke4I+TjMu3r1DF5I+a84Gp lo= X-Received: by 2002:a05:690c:c522:b0:7e9:a6b4:fb22 with SMTP id 00721157ae682-7ea4bad578dmr73567297b3.49.1780579034125; Thu, 04 Jun 2026 06:17:14 -0700 (PDT) Received: from i-use-arch-btw (c-67-187-47-172.hsd1.ga.comcast.net. [67.187.47.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7ea23a9a421sm33248547b3.39.2026.06.04.06.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 06:17:13 -0700 (PDT) From: Maxwell Doose To: jic23@kernel.org Cc: Maxwell Doose , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2] iio: chemical: scd30: Use devm_mutex_init() over non-devm mutex_init() Date: Thu, 4 Jun 2026 08:15:18 -0500 Message-ID: <20260604131518.27323-2-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code uses mutex_init() instead of devm_mutex_init(), which is incorrect as the rest of the file uses the devm automatic resource management API. Fix this so that the mutex is set up in the same way as the rest of the device data structure. Signed-off-by: Maxwell Doose Reviewed-by: Joshua Crofts --- v2: - Drop fixes tag per Jonathan's suggestion. - Replace dev_err_probe() with return -ENOMEM per Jonathan and Andy's suggestions. drivers/iio/chemical/scd30_core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30= _core.c index db5cc295aeab..198add58affd 100644 --- a/drivers/iio/chemical/scd30_core.c +++ b/drivers/iio/chemical/scd30_core.c @@ -714,7 +714,10 @@ int scd30_probe(struct device *dev, int irq, const cha= r *name, void *priv, state->pressure_comp =3D SCD30_PRESSURE_COMP_DEFAULT; state->meas_interval =3D SCD30_MEAS_INTERVAL_DEFAULT; state->command =3D command; - mutex_init(&state->lock); + ret =3D devm_mutex_init(dev, &state->lock); + if (ret) + return -ENOMEM; + init_completion(&state->meas_ready); =20 dev_set_drvdata(dev, indio_dev); --=20 2.54.0