From nobody Mon Jun 8 09:49:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1F6744B666 for ; Thu, 4 Jun 2026 12:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780575868; cv=none; b=cwV9yUCIEt4WoLB9w8+frwcb9dL4fjRIcsgdjza8rQAw89IkBvX/4PFgl9K1Im9I/Ld8VjRG0hak7YJuLkLDZlYbrZRVisYWd+PlnzXVgdBN1VmBirS3rK09QGyoSCwdOUiSBuiQit8TNzMM+/a6SD/JuEBrVqu9ILXDAhqsQJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780575868; c=relaxed/simple; bh=apo2ANK3NU2TBFyfekj/mxPztWFp1Q9vmW6QhNbAwlo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dTP1pCQlh8o3YPBDLuZr7hahgeKpm3S99jzbOa0KY86dGA3yj6T2X2SRKl1q8q2gPDbPwnBIQfajjfhc2gwA/9KOe8aC6BZZmCq3506PysvdbU5LVnWytwEgWrSuH+8R46aoFKM1KY7SQb229FprEB6JYgYPQ9GUe9Fnpv4KDTE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TzwDUUV1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QBmwyvtR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TzwDUUV1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QBmwyvtR" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 654Ap5ol1993560 for ; Thu, 4 Jun 2026 12:24:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=VbB0DABGOtK JoHg8hFmspUueMVJinTA763aGb11Q0CU=; b=TzwDUUV1cqPPPNDULsx7pcTxSPg HtsFmaBAHsswIDxGwczgXetqNYD2rEB6KuRPUn9lSzdbhopBzPE9RR1OiyMj6fhe nw0Aht1zkmaIrA2ALaISAJe+MV/HCcNvVLKy6XcS4n86ilMs4NuSpDchXnAKdSQv EPQOASHxCgWO0X90FWGZiN2GQz9vYMXHD3E7sqZlYJH+6yyresyho/LJr+KnpgbS bl0VTDS2siNQ5fqfMfLukCf8wRHb9RyFh4/0wi0pfX3e33B4BYYoCBcArX1tij3i kpi+x2a4PkBuR9E2nluaHE/P8+XZv3OIzH10kBehVEyW5F3ybDP0OBdPjDg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejs8pukrp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Jun 2026 12:24:25 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8423efdbe6fso468037b3a.0 for ; Thu, 04 Jun 2026 05:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780575864; x=1781180664; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VbB0DABGOtKJoHg8hFmspUueMVJinTA763aGb11Q0CU=; b=QBmwyvtRt1Ukx9s7x6eiHzbIz+KfiBMm6tkFtRwazBNioXfUdrhKQYoXelGcyB3Wj+ 3oIvSeIFJpFfS6i9+nqHnkbtfjxZPyXx0IHdybdQdyTdpdfYZsVPBWJh6EF4HssRRbFh bIQApTvgaYm7aQMYhdDDCBEMbiIgBzllWa2qaPZxTHQd5OX4nJ0tc9tMZ6qzJHkVVJ0o tzuPOneIG3rY1Okm+xa2P9cynj7uwQfXnACpB3TzAXVqr+eWZ8kSg0P1VtbSp1QWNi9D pg7Y4exEws+YZjjEDf8mTBe0c7C13L8oLf3gBjXq/6AcVoKwQRKym9YZzvGgJSkHWKMQ FAbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780575864; x=1781180664; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VbB0DABGOtKJoHg8hFmspUueMVJinTA763aGb11Q0CU=; b=baqxwOyGAK0J6fFBaOEfDvptirqcjWBt+eWn7GZyQrlH8G/ZR2NIBdNAMGFlQrDHJJ jHdkmf4GX0jFWoESZqhGQMZWnONHs+Xg9xt4meehBN7Bc/6L1020Nq3bpRYD7q4KgYIw AF3tuuJ2UJwSBR/4V1hJxQJy6MfFbahtY0INDKMqzdmy2HzC2Bb9OJxzTF29ofscZxlz cSerAy2x4UAL5ZWahdU0FUrYmRUxZcqP7DP1vbjcd6h7ySfzya/mxmUetcnPGGZB193P epnXOunxKQH8ETMNtxXvOr5bHZJJs9ziSlbyCFQ3gCVPb4vpr0NiijozD+51NZStW3Ot ZdNg== X-Forwarded-Encrypted: i=1; AFNElJ+FB/siQ50F/VdeHbGTWStpKSFZzMezBIORhFY5r7pvYRp6E2Nlib0fFx041gmPSWoD2SXzkNM2cUYBinE=@vger.kernel.org X-Gm-Message-State: AOJu0YyM7ucBfSFflJp+Tqqq8loHiZvkjEQ7KcKuB1dceheM1UMlWU33 goSip8gOWqdjWNlsSNCPAJo0LNEMQ7AiD0n8JkvIGm1Olf1QfyddpncRhmEWmce31YAhMbpuqga tU/FUthhpWlyfjzYHpibGx2VstHMslh3+8EiYLKJErejxs7bCToeBdpW25rF+zic8JU8= X-Gm-Gg: Acq92OEk871jhGaQr+sIh4fIoiST6fpp+ub+DE80feQFCLfzH51z8RztmPS4F4CZUtT C/KCm4NXvHWlTyGYJy7vb3oXAcN/pgJcWdj2bO4r4kkK2FNnNLAb7NINuiJnsEyRBF8J39XqwFz ZSiK0z0aIQb6EZRuoNGdqIpJJrqHbnqueZ6k1FpMEWxHYVcZZofDUnOWV7IOJCLKRs0LgrjjUpT t+cKKgflyVyqae6olKnlpBj05TT9uJertct7VcGGZ03uBV6j89NkbUBncsN4ah5aNRgF8OfBUqL eNm6i6AnUGoxliDZDjyZFbjpyWmtVBrqihefG02R/LPF2qGNYENv2x3jEnuka98qInpvHXJRNAr 7fnNJgbRLyjDWZLCgpSWA/5auZB6aegB3jYfzFAO54JAfuvImRIb3VAtu96F8dnItfi5/DfeLbp cruIIdCIKbpPPS9CBZt3qfXvG2hPSucNnw2F8W/HQ= X-Received: by 2002:a05:6a00:1d8d:b0:842:2cda:7aa2 with SMTP id d2e1a72fcca58-84284ed9c20mr7471900b3a.30.1780575864387; Thu, 04 Jun 2026 05:24:24 -0700 (PDT) X-Received: by 2002:a05:6a00:1d8d:b0:842:2cda:7aa2 with SMTP id d2e1a72fcca58-84284ed9c20mr7471861b3a.30.1780575863875; Thu, 04 Jun 2026 05:24:23 -0700 (PDT) Received: from hu-ymg-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282882156sm5841960b3a.33.2026.06.04.05.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 05:24:23 -0700 (PDT) From: Yadu M G To: mani@kernel.org Cc: shawn.lin@rock-chips.com, jingoohan1@gmail.com, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] PCI: qcom: Initialize DWC MSI lock for firmware-managed ECAM hosts Date: Thu, 4 Jun 2026 17:54:18 +0530 Message-ID: <20260604122418.727274-1-yadu.mg@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: UZI5LvtuQBE11qfvkcPpI1TBOefuvlXQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA0MDExOSBTYWx0ZWRfXy2hg88lwAJVg /V9/Y8PJZ+6/ZTPoz6PpSksAInfbjB8FMnmRM79/zMvtvVd9SVo6LojTD5yRbwtqUz3SjjI+jVe s/PunGiqDfzB65Ntq6sEhs7wLufRI94fGQwKbmJMdk1AjOVPkFobo7P2Yp8Nt5WSND4sr8lKWAq x6w7ZM+381hEDdsVlgCe7da7qjUJ8EaidFLiWmmT/TTaa0XmDa1z+taQvD9gDNrGx7/Jwnh0Ah8 MChUw0IuuzgHD1ZdC0jPn0mj3Rub6lyuIFu11qVNgVqSWH/GXcJbbot1DOjTMUCA8Hu4i8RgvEC TWEAuHIajqiD/H5GdEM9klGNJKqvrhsKFsaqAcZH1AkFeXK16quuzcy+twplhcghYT21ZgIoebp lzQz3JWVn9IuI/aLCQ5IErWYLvJLQ4wL9UdEJ5EjqiBrjbUtGPUlwkhb4ptjUV7WwsJDqyptCAO GR71O9hJw4+GwCq/qVg== X-Authority-Analysis: v=2.4 cv=E779Y6dl c=1 sm=1 tr=0 ts=6a216e79 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=A-MhOCtGDkUKx26caKsA:9 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: UZI5LvtuQBE11qfvkcPpI1TBOefuvlXQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606040119 Content-Type: text/plain; charset="utf-8" A lockdep warning is observed during boot on a Qcom firmware-managed platform: INFO: trying to register non-static key. The code is fine but needs lockdep annotation, or maybe you didn't initialize this object before use? turning off the locking correctness validator. ... Call trace: register_lock_class+0x128/0x4d8 __lock_acquire+0x110/0x1db0 lock_acquire+0x278/0x3d8 _raw_spin_lock_irq+0x6c/0xc0 dw_pcie_irq_domain_alloc+0x48/0x190 irq_domain_alloc_irqs_parent+0x2c/0x48 msi_domain_alloc+0x90/0x160 ... dw_pcie_irq_domain_alloc() takes pp->lock while allocating MSI interrupts. pp->lock is normally initialized by dw_pcie_host_init(), but Qcom firmware-managed hosts use the ECAM init path instead: pci_host_common_ecam_create() pci_ecam_create() qcom_pcie_ecam_host_init() dw_pcie_msi_host_init() dw_pcie_allocate_domains() That path constructs a fresh struct dw_pcie_rp and calls dw_pcie_msi_host_init() directly, without going through dw_pcie_host_init(). As a result, pp->lock has no lockdep key when MSI vectors are later allocated, which triggers the warning. Initialize pp->lock in qcom_pcie_ecam_host_init() before registering the MSI domains so the firmware-managed ECAM path matches the normal DWC host initialization sequence. Signed-off-by: Yadu M G --- drivers/pci/controller/dwc/pcie-qcom.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index 11fc60489892..b925a7af1d75 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1794,6 +1794,12 @@ static int qcom_pcie_ecam_host_init(struct pci_confi= g_window *cfg) pci->dbi_base =3D cfg->win; pp->num_vectors =3D MSI_DEF_NUM_VECTORS; =20 + /* + * dw_pcie_msi_host_init() is called directly here, bypassing + * dw_pcie_host_init() where pp->lock is normally initialized. + */ + raw_spin_lock_init(&pp->lock); + ret =3D dw_pcie_msi_host_init(pp); if (ret) return ret; --=20 2.43.0