From nobody Mon Jun 8 09:49:28 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05DF0386C10 for ; Thu, 4 Jun 2026 11:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780573703; cv=none; b=eBGiwmVFhaNH0+nnFcCh49CkAG2cfl9a83AikyVsOtZAws3sOaxECsN1qyEKRzkAGHHHDHL35snfwItHDOq38p3R3Z6b0PXuWvBxyYZudj+k+O4ckKkpEEAa0tWeG8rvrKth+aCSZD26dwdZExmLV5WU33TrgDh+5sMtZrdRrc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780573703; c=relaxed/simple; bh=YeO1DhhGF5uEapVd1d0k4rpIgakmuGSwKU+7CZAfHE8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Zu27Kry7k2CNbIuMWTSgLMWle+ocEEWuFOBkoYITLwDLg0Z19HE2MklXGVIY7gNxcB50hLuZ6g6GRYisXhToCE+qMFMPcm4NAvtOve0vmeVzO+I/HUZm3AqXS/4poRJzcqdbQepgQMAVgbiui6U/FZgl5didKgh8VTyP4dH/Hvk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DdHnJKZe; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DdHnJKZe" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2bea7176c72so3962285ad.0 for ; Thu, 04 Jun 2026 04:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780573701; x=1781178501; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+NpC1bqSInGOO1aahZDlWqyayeuLAZFyoOtvmQIUnHs=; b=DdHnJKZepIY3iO0GY3jx8h7mmE/invu6JrWaBati1oBeNj0sxCLlCgos7SbYYXx0ed BTS5LoDg3W1/n36aVQIlbc7QLU6WFd8JGApwHRaSpeyt1e4fnbZkLWg/UliH/ry+ZZyW 0AjT6cPyqjhYkYH9ig6m7kZdB3PhP9GyaTTpr2yJMmIfdQ7uKBn5AQbHiCPi17GAQ9EJ Xl5qw/YZqsxNiuGHGRDpxqt7dSPHdbTgjha2aCfRSfIDxux0/LLPQn/IZGaymnjRnjwc tpuLZNVl6RzBTReYBUZJXQdS15ZWu2NmBB/E2tTx3JdCVt0Z6lZUqSMX3jgZn+ut4TD6 i27A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780573701; x=1781178501; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+NpC1bqSInGOO1aahZDlWqyayeuLAZFyoOtvmQIUnHs=; b=VunfK7Vinddhq1lMPlADKAZLpRvJi8Z0H/G0FHWSW3tDFiQ5xjnCj6Xqal8kUD6Veg dmpSEPhdfAUMetwi+DE0kfNq2RIDC5m5kLbivIL56GPGee9WvbhXYxBaJYVVrRnbxQuR xu+mniCtTT0wptZUtiw0LrCbIf9mu12ch8pCjZG1mx66l1J+sZQfX8OgZ/OOvl6Gt392 eiVmBitBNR7hEVlJtKsuKHrzZuGE2YM0oIYmAa6kb9wEx0WXmoysbhoH9u5D1G/gvcJ9 MO0VneZE4i3nt9iLeCHKtzKy7QhRpC1tG9h+D7O9dI+/11k7pVFEgilPywK6M+lPsRTj eMfA== X-Forwarded-Encrypted: i=1; AFNElJ92H+uxcpygVPDuomFXt7YkHlJSE8Rp9YRbqLBRUV+5JevYxydJo/qb3vwqHHDEHbbRivi1JlfbYamW+wE=@vger.kernel.org X-Gm-Message-State: AOJu0YwXhhP5fdrKHJR3XzcbpwfHqpPFg5WojTPSaMIFvRozHOm7YjDG Dd3CxGQU89pfiMlvLe2cofkSwYlWOamCIlREW+7XHX6ZtQdNR7z1LXoF X-Gm-Gg: Acq92OHqgTZOx1KY3QnJ9oaC9iy9agd01hXKZ64G+qmk5jRbG3a+YHQFHtp/4doe3+M +BLH59FmXHCR3SoUc7BVAP6kd/stFSwxVHbOVQjgaL2EiFXaylfqKYbeO68Rs1TiWXLrr0z//dQ TPVjd2bqx+FAIViuv5ALE8fT/Cnv0Ardui7ZLKoxGHp01vKXEcstzpUY3yrSzRIG4NJ6jF96Toi MHyhtxT5yFBBS9JOn0joLYiUsx2ic1nEeXFwKw0OrE39u8Ugm3KP1HHqKhP1o0qQbhnBT89oguY DffP7qLoFpxYw8BQ8pqkILG7HYw9DSgYfXJFQ4yjW2Loo0/eTUJ/NaFGw8f08PCvGMYAULYWUrh 7NevJbxDrTw26m/hmZtKIVe9qwEuzmF2n+KGEXBq8u3xZEyE53+Aafi4ODGtssYwMUlbdyupa4n HwGz51RmipzUbokncC X-Received: by 2002:a17:902:f78a:b0:2bf:160f:7038 with SMTP id d9443c01a7336-2c163a12d2emr88021725ad.12.1780573701192; Thu, 04 Jun 2026 04:48:21 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c166396fa9sm55550165ad.66.2026.06.04.04.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 04:48:20 -0700 (PDT) From: Guangshuo Li To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Marek Vasut , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] drm/bridge: samsung-dsim: fix TE GPIO ownership Date: Thu, 4 Jun 2026 19:46:04 +0800 Message-ID: <20260604114604.1422184-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" samsung_dsim_register_te_irq() acquires the TE GPIO with devm_gpiod_get_optional(), but the descriptor is released manually in the request_threaded_irq() error path and in samsung_dsim_unregister_te_irq(). The devres entry remains registered and will release the same descriptor again when the device is detached. Use the non-managed gpiod_get_optional() helper instead, so the GPIO descriptor lifetime matches the existing manual cleanup paths. Also clear dsi->te_gpio after each gpiod_put() to avoid leaving a stale descriptor pointer around if the host is attached again. Fixes: e7447128ca4a ("drm: bridge: Generalize Exynos-DSI driver into a Sams= ung DSIM bridge") Signed-off-by: Guangshuo Li --- drivers/gpu/drm/bridge/samsung-dsim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge= /samsung-dsim.c index c3eb437ef1b0..2299b7dc0c04 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1862,7 +1862,7 @@ static int samsung_dsim_register_te_irq(struct samsun= g_dsim *dsi, struct device int te_gpio_irq; int ret; =20 - dsi->te_gpio =3D devm_gpiod_get_optional(dev, "te", GPIOD_IN); + dsi->te_gpio =3D gpiod_get_optional(dev, "te", GPIOD_IN); if (!dsi->te_gpio) return 0; else if (IS_ERR(dsi->te_gpio)) @@ -1875,6 +1875,7 @@ static int samsung_dsim_register_te_irq(struct samsun= g_dsim *dsi, struct device if (ret) { dev_err(dsi->dev, "request interrupt failed with %d\n", ret); gpiod_put(dsi->te_gpio); + dsi->te_gpio =3D NULL; return ret; } =20 @@ -1886,6 +1887,7 @@ static void samsung_dsim_unregister_te_irq(struct sam= sung_dsim *dsi) if (dsi->te_gpio) { free_irq(gpiod_to_irq(dsi->te_gpio), dsi); gpiod_put(dsi->te_gpio); + dsi->te_gpio =3D NULL; } } =20 --=20 2.43.0