From nobody Mon Jun 8 09:48:37 2026 Received: from mail-dy1-f196.google.com (mail-dy1-f196.google.com [74.125.82.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EA2439DBCC for ; Thu, 4 Jun 2026 07:28:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780558127; cv=none; b=maZI3UC6Q7ORatQaBWci5nsJG5pQJVthqHwwe52KIXcn0iZBZeYxeoiO90h2zTQza9ND3wOKNfXq8VyL20DyH8TygeqcHWB0X63Gf3Y9MaZq3UpGPz4POaWUs+ggN8HtcbeRIG/gQDyMUqTBqZJ2OtDgNzlKJkSrQubqnsi6SIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780558127; c=relaxed/simple; bh=vEj8EI5oExPm7tMbsZS/Ju8S071XB3QnI2EedtVwxa0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pYanUcWRftcIwT+uo0zOBpiG+h/YcO7cgzKYsTN/RgPmI9B5tnQw+fIkyFqdC+69ZDQ4aCoM/o7ROcmFchFmJ6vSqY9/OA6GRxothqXeskc+Eiw+V+uAsUpUrH85GYEG1IuCkZUrg01c++of7Aa5+YJN7z9xTPKHiEv3puml0NQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JJSXRrni; arc=none smtp.client-ip=74.125.82.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JJSXRrni" Received: by mail-dy1-f196.google.com with SMTP id 5a478bee46e88-304545f5206so443345eec.0 for ; Thu, 04 Jun 2026 00:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780558124; x=1781162924; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EUjaUGFNcoZHdC3YZeiMHCy05kdsPltvsJJXov2Ftec=; b=JJSXRrniQd7Xp1fx6hze/t/bk2uZ6xnRSlNTRU1EiAT283ysYfAF+D0xckGmTrOzkP eXb1V5Qm2S1P8s6LV8bWAANThiJGPBSRvwYgJsN01SBj74Lnbu2Bc/xhMhvwgq+yyVu2 K/4V7o6WuaDN0OFhNdYYMegdnW7cra6wO9/1gJ1tVDJLjD6HBN64rfTR5Qaig9+LVpZr k0HUsFY3cwd7RAApzdBT5gcZOCnO21o1RtzAcdLxbRAr+ZMAbgQ7xa21KK1mlec6uPal WycN5f1MtQ6xtGEQAiOcAcS+M3QFuoQjx8bdMJG/i4Nqs32aD0KW+ImWkbqsrzaSTqvN UGwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780558124; x=1781162924; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EUjaUGFNcoZHdC3YZeiMHCy05kdsPltvsJJXov2Ftec=; b=gJ94dlhAFZKRU3xCrkFIpfUEoNnpAfeejVv0++uZpywAPkmjlfdy4LrXs3qbANEPJp VoUeJ+hhjmW9HVzqU5gdjt/mRtnqAB2ihxuF/IN6Fx0vStXyJ+tOtTdO2VUi5fddQlfw KYRp5fAGJo7+GbeBpjjrHBeSwyzxgZF1IuZ2//+9hHIyin0SZ3OVjeEpXlIdtGAhEINI QI7CdjCMbGOyzeJ9iVo8IXwUKPoDz2XfV+vYgEi9y5TxiFa+6WuyRYTBVJc+Jwum59X7 +8zuRBzKOTHYns/PpIS/aDm8kDJqQix9PAZvR7ogK9banyXOq354mrLfGLJODNhEaiG4 sKSg== X-Forwarded-Encrypted: i=1; AFNElJ/4fMDylxRyduFf6YOve58Sdb3VTBwywm/33011YqcI7aPWTvUzill6NVuNPG8qUKbgDRbzSMO9w1wUw5M=@vger.kernel.org X-Gm-Message-State: AOJu0YwWIHnJY9NcpyshaDBfZXRbW4Sglk6pWsGsPHV1veaV8NadSocJ Io/RNiainRcOcJApa6JMuaZ8f7podZ63nUNR8rL7EEEni35Sy1q6pT6I X-Gm-Gg: Acq92OF5k3ed5cABucDlP5//QPXiuBr3bRuvPfhHSMcb1QyzAdTHQ+1CUw4cDulK+bM RXL2ZgLeGJUymW39hlu4lRjxaHqMXDuehyRfpfVCAmOZWhKX1lIiDwQqBS8mXmQJhOTDlcgAJD6 3kYiUAfw///NZqPfejAlExsE/4go02D1GwGf/en2WzCQkAuos9AFAbZgOqxfUE6PSyFlscdpI1V 7+LxOViufeMosWfK5QODAXuQ6QTH4SQQV3CTDI5dGxemFHKMGMENxy8F7RnJTYmqaTPSgukyHXg XkrrNmT4P1kGjbtDiUS/zF66BJZMw8QJl6uBkSmgsuM+ifeA3sYT0FVebt1Iog1xIJJp+U+hKDg wgz0P0WUq7QZMWVNZ35ABDQUPTQuYw1rWVCPW0uDXjqChZC4IwxzBWveollsdl161vw9joFT6kh 97t0M0uYGHEBZl07vXvS1cAtPCNba+5cA5FvuUMng5VJiEMAS+nyzajsRS1Kzs4bRVDg== X-Received: by 2002:a05:7301:6787:b0:303:a1af:5042 with SMTP id 5a478bee46e88-3074f703362mr4245372eec.0.1780558124494; Thu, 04 Jun 2026 00:28:44 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074db55f60sm5797164eec.6.2026.06.04.00.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 00:28:44 -0700 (PDT) From: Hungyu Lin To: Vikash Garodia Cc: Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2] media: qcom: iris: guard IRQ handler with runtime PM check Date: Thu, 4 Jun 2026 07:28:24 +0000 Message-Id: <20260604072824.45448-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use pm_runtime_get_if_active() before accessing hardware registers in the threaded IRQ handler. Skip interrupt processing when the device is not active. Signed-off-by: Hungyu Lin --- v2: - Use pm_runtime_get_if_active() instead of pm_runtime_get_if_in_use() - Handle negative runtime PM return values correctly - Return IRQ_NONE when interrupt processing is skipped drivers/media/platform/qcom/iris/iris_hfi_common.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.c b/drivers/m= edia/platform/qcom/iris/iris_hfi_common.c index 621c66593d88..1c05f83986fe 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_common.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.c @@ -100,10 +100,17 @@ irqreturn_t iris_hfi_isr(int irq, void *data) irqreturn_t iris_hfi_isr_handler(int irq, void *data) { struct iris_core *core =3D data; + int ret; =20 if (!core) return IRQ_NONE; =20 + ret =3D pm_runtime_get_if_active(core->dev); + if (ret <=3D 0) { + enable_irq(irq); + return IRQ_NONE; + } + mutex_lock(&core->lock); pm_runtime_mark_last_busy(core->dev); iris_vpu_clear_interrupt(core); @@ -111,6 +118,8 @@ irqreturn_t iris_hfi_isr_handler(int irq, void *data) =20 core->hfi_response_ops->hfi_response_handler(core); =20 + pm_runtime_put_autosuspend(core->dev); + if (!iris_vpu_watchdog(core, core->intr_status)) enable_irq(irq); =20 --=20 2.34.1