From nobody Mon Jun 8 07:23:01 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E46003D3D1D for ; Thu, 4 Jun 2026 05:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780552203; cv=none; b=HNcHzY09rl+XhdqwbrFey0N5jzEptm8KFIBoGSmFMJsa/+gHOtS0u5pJqsK3ZqBbgjEoCCg8pIh735YcHAEXmoNG9e1RQe7jaFFVjR8f5BEpK7tracbd5osn/scpiIK3GeymW1BLeua/ipawI/+muGux2XQbHfNSRg41ZJl8wm8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780552203; c=relaxed/simple; bh=zpCv17Sg5kWkxuzMxb1CNjR4cVcHw9YcPd9dSnigmAA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=WGpQdAslwCSCKHc8F09zeU0hNzRLKU+Q5l+RIFnKbfg5qikGqATXa1qh4z/5Z25Ynz7eAUtnjB4AQiXWtDmgYbUUiwSpkpOv88zvtBcDUuYO0RQBLJaB2a1w3+0kZCeklpAFK/ae9OEG9LXzLX65ML//jjyFeh5MqRN7vU9vV3k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bdNNhv66; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bdNNhv66" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84232e83ca9so129625b3a.2 for ; Wed, 03 Jun 2026 22:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780552195; x=1781156995; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=c6O/WIRCX+AkXpjS4dBwmz/ZiRhzvinSASQRSoiHl/o=; b=bdNNhv660kGRaonALZmmrRjd3LWqkfTf9/1GC8ICyOmlygFO2Tmxvz5/XGHdms8BIZ fE3AYYs1evukfkAbH3IoHwPb3Bf73o3yd1EU9LiWUE+Hfu+1kTZBJ9F9nYMkS+BYL4U1 nxnhsaguKWjKZgZ/2eqZQrcMcBhpufNIY0rXxDsp2hknz0DJMBiQ2a+v4bc37vVnP/eG OfC9FxxzkEpQlVYB3dVKDgdtIAwQmQI+UoCvQgJplLYoPuIBNRBcg218b7MScAKDomxG ejlZ4lvht7H4YIVgSThQyNN5HoPlyL7ymFdspZWDRTVp9cUur6sEVi5srIrG8aur2WbR LyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780552195; x=1781156995; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c6O/WIRCX+AkXpjS4dBwmz/ZiRhzvinSASQRSoiHl/o=; b=oOp+WDjVOaekWifzAEr8JsMlNCTbuO9ttOvJN7rnbwRnljXJUz7XOaUZOALcKqYzGP manRXo+/2HakjFrTmj4xqTT7YClW8uM+HJexPHQBecyUvztNCTD+DdzipJ4iYTKoypTO qbRZE95ECrVojRxDYDHRivA0rfVMv9gQ2SsE18MhzQELOrDMCUnGtX2K3KENn25sbxCd RR6TiieoBXgbWkVvjzJQWt9b+dgAFriKK74SQDgc5MqR3+REB7BDRMa1wzhsKCkF4VxI kpa9Cm8w2T6/dFx1zvwhpuxuaUJtaNG7idjoJqQnSMJuGy4qDci4ZVApVejLHmYWrFxS xJ+A== X-Forwarded-Encrypted: i=1; AFNElJ9DiaiypyD2CgCZqMS/soCbG4Et8HCkr5tIGwFKTTzXCsY6sxofTosXXEKUrZJWwdc6ls2hjIUXDR+6HrE=@vger.kernel.org X-Gm-Message-State: AOJu0YzC2ouNcdDDKdhEGMa16lWFiscADWudi0l7Wo3o+3JBVkuOjvb8 pRsoGxgLNZFbUUpI+EdJh86MVhWA/QlHydMuvb9Za43vDhXijwvbXjr6 X-Gm-Gg: Acq92OEsGnQzur+3BGxS08kSHy5l0Hf7jqVHEkdnyuAzr6C8WBtzmW8/ajsHat9Qebc WMxalZdLQxg87njLbUWNkof8LaB7aYGzNj6knqMvSZyVfa9XVbvisq7hAWi8oBgqtdkhGlLNib+ k8HnTbr6EQckW5bcdb224PfnfKCPIqRtyQRANifEdBAOvlnIseHOJIFukPmRWeah+Dr8eq+0S1V Uov3nso0jBqyd34zM7Zps3q4WX0wbwXja09/P3rn57yx/TSusThiLNKPSh4lP9OfJpInlY2KBPW eo9MmKvpZ33wqr2HicfmrvAadOqmDaiJhoVM7zHOngyx8I0uVgBLy+g25WYO9TS7WMU90QdwBgi 1qBA4keblIKADF4sJYb5dt2g5E2zCgqXSXIW6VFWCZZfpaFDwkkhvkRvH/0idYTmmjvWGmCmPZP 1qSjYN7tHYO89w2VLZ0psiAPfAkyoCXnYLD9KdxutDAQIK+rOj0yvXHRQAQSuNEfua+5iPGQ== X-Received: by 2002:a05:6a00:9094:b0:842:54c1:8e15 with SMTP id d2e1a72fcca58-84284ecf490mr6679870b3a.29.1780552194807; Wed, 03 Jun 2026 22:49:54 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828821ddsm4880943b3a.35.2026.06.03.22.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 22:49:54 -0700 (PDT) From: Maoyi Xie To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, fmancera@suse.de, jvaclav@redhat.com, andrew@lunn.ch, luka.gejak@linux.dev Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ap420073@gmail.com, Maoyi Xie Subject: [PATCH net-next v3] hsr: broadcast netlink notifications in the device's net namespace Date: Thu, 4 Jun 2026 13:49:49 +0800 Message-Id: <20260604054949.2999304-1-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The HSR generic netlink family sets .netnsok =3D true. HSR devices can live in network namespaces other than init_net. Two async notifiers broadcast events with genlmsg_multicast(). They are hsr_nl_ringerror() and hsr_nl_nodedown(). That helper delivers only on the default genl socket in init_net. So the events always land in init_net. The network namespace of the device does not matter. This has two effects. A listener in the device's own namespace never sees its own ring error and node down events. A privileged listener in init_net receives events from HSR devices in other namespaces. The payload carries the peer node MAC (HSR_A_NODE_ADDR) and the slave port ifindex (HSR_A_IFINDEX). Switch both callers to genlmsg_multicast_netns(). Other families with .netnsok =3D true already do this. Examples are gtp, ovpn, team, batman-adv, netdev-genl, ethtool and handshake. hsr_nl_ringerror() already has the slave port. It uses dev_net(port->dev). hsr_nl_nodedown() takes the namespace from the master port via hsr_port_get_hsr(). Reviewed-by: Fernando Fernandez Mancera Signed-off-by: Maoyi Xie --- v3: Drop the master NULL check that v2 added in hsr_nl_nodedown(). As Fernando pointed out, master cannot be NULL on this path. hsr_dellink() calls timer_delete_sync() on the background jobs before removing the master, so the notifier never runs without one. The check only produced a false positive static analysis report. Use master directly, which matches the existing fail path that already dereferences master->dev. v2: Drop the Fixes and stable tags and target net-next. As discussed, this is more of a behavior change than a fix, and the .netnsok commit has been in since 5.6 with no report. The multicast stays inside the rcu_read_lock, which avoids taking a netns ref on this path. Fernando's Reviewed-by carried over. Inquiry (2026-05-18): https://lore.kernel.org/netdev/CAHPEe=3DGO=3D2qqWZPwBB4rrXc3mkD0dznp2K78nCs= KwF=3Dc-QwxEw@mail.gmail.com/ v1 [PATCH net] (2026-05-27): https://lore.kernel.org/netdev/20260527075924.2707856-1-maoyixie.tju@gmail.= com/ v2 [PATCH net-next] (2026-06-01): https://lore.kernel.org/netdev/20260601022014.1175348-1-maoyixie.tju@gmail.= com/ net/hsr/hsr_netlink.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/net/hsr/hsr_netlink.c b/net/hsr/hsr_netlink.c index f0ca23da3ab9..8099f2069a74 100644 --- a/net/hsr/hsr_netlink.c +++ b/net/hsr/hsr_netlink.c @@ -252,7 +252,8 @@ void hsr_nl_ringerror(struct hsr_priv *hsr, unsigned ch= ar addr[ETH_ALEN], goto nla_put_failure; =20 genlmsg_end(skb, msg_head); - genlmsg_multicast(&hsr_genl_family, skb, 0, 0, GFP_ATOMIC); + genlmsg_multicast_netns(&hsr_genl_family, dev_net(port->dev), + skb, 0, 0, GFP_ATOMIC); =20 return; =20 @@ -288,8 +289,12 @@ void hsr_nl_nodedown(struct hsr_priv *hsr, unsigned ch= ar addr[ETH_ALEN]) if (res < 0) goto nla_put_failure; =20 + rcu_read_lock(); + master =3D hsr_port_get_hsr(hsr, HSR_PT_MASTER); genlmsg_end(skb, msg_head); - genlmsg_multicast(&hsr_genl_family, skb, 0, 0, GFP_ATOMIC); + genlmsg_multicast_netns(&hsr_genl_family, dev_net(master->dev), + skb, 0, 0, GFP_ATOMIC); + rcu_read_unlock(); =20 return; =20 base-commit: 8415598365503ced2e3d019491b0a2756c85c494 --=20 2.34.1