From nobody Mon Jun 8 09:49:06 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010011.outbound.protection.outlook.com [52.101.201.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96BB93ACA49; Thu, 4 Jun 2026 02:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780541603; cv=fail; b=E0ZTpZTluLeRfB10S/A6Eoqn/wxFOYJF0yti0fancHHFYKbOZSK/1UeHirNqKYqv5SbFChEq5XnPm9X84kBUFQOs8f4ccFZHItrKkCrqPg8ADW6ZYvkcLaVeJxGXlphmTha1B9FcjIkwWteIjGq42srwEfPEnptxe1Eq/+CxktE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780541603; c=relaxed/simple; bh=qxjjm+ydIQSmN18KGU1JZRZ0tN57MG0U8uM0E0RDQCk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Ym6v2x0EBlk730NQ45mUQQ/ypmwZB4clf9DlkOsHLsnOAWzHxW9pjYVr4Ut+PvjLdrbhUb7oZm7PHIDCg/lvqyupJbkkprcrK7/gtezvhyp8VTWbJLNSIwQsBWAk0+EwV0NfRaDukGjiHFaN7vudnVbvM7eM/sOeamVXZV3Av2E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=LnrKDwQp; arc=fail smtp.client-ip=52.101.201.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="LnrKDwQp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qqrPDlUGLfqUc+AXFEzvMENrXlZaJ3ADUZbrU0g3Yy8poXjEgbH3drP8ciymRzTogW01LJIAztpKTAJyEyv71GWTjRro0Y/fB9ylhYfUsLLfLi+rDvrR6Nll5h//SfEffHIXFdFrPsZalE6/0bq6pyrMUue7oK5G/o/fQ260cV7oBk2wc2Zz/JiUJFKoZZm7uWMs+syMFRZQtIOt9L8393hXl+JSlwGLWdSPfJyz5LfxW8VPJ6ZX3ufOdIAvJOg9W1JL84OBq4TbCtvOG43cPXTUulVetTru39a3lPDXUFD+p+CTYcL8u695Q1MFntbRtb8wUFIOgCcJFCSkbQKi4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7pQYC+KpCTOPFgE+F3QuMxHAmIOSvjNvcnRhgfWznjs=; b=YLymGED7zzlmrrc/W2jq1yyE3Wywo4JhJBF+g9kJXk8KNwxrkz6kKP+4kToX99AqUUYjT+hJ+V+506iTgbhyHwcMunVOMaFtxYhXETLz+ucRuiYifHmmFe9x24ltdWCfwudkkXIF9C/qiUVPSCvaFXEEGZFLiZvi5Wm0YNBrMPWPrTPrGncZt4XjmCQkZSWaBdIT4Edm8LUAsYoh4+7+WQCnvDCTzrWzXWRoIQoB3zQ1C3XI3AFpMsnAIuhNcxCcDYB2KiDk5cRIGzGhFK/1rfuGYwCycnM88fNMGIq0gFrs95oKfWOQ0snP1A6TRxfSnnU9mb0ftQGSdObuA4Xmeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7pQYC+KpCTOPFgE+F3QuMxHAmIOSvjNvcnRhgfWznjs=; b=LnrKDwQpTZcZOD8iFeYLlkpGPwlSJ7AMMa0I+UQRaGmtovS9cW6/srlsvGpQsN2V72DnCtKxhErNNqh5Bmb0DShJ1tW0Zb9Ef5Y5rcOxFyLv6uvmyIZvXLbHR9lW6A9YjMW2Irs92d0GYQv8+DKK9y2bf4OaIeeh2NyNaD2jiFAuIR/Xo6re259TjQ4WF8TswhcUx6+E1mKYRtlC8HT7gosxMNIbh70oyBMz2MaQZwIg+YMaoOPc0kf5o4EzF83+Rre7RUV947yCxzFrDkYjGWkQ6fWBEio+v398y9gwVkVANuhf58niYazcmAzvqfaz0OPAkJOhQVQKzY5+rZRUYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by LV2PR12MB999072.namprd12.prod.outlook.com (2603:10b6:408:354::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Thu, 4 Jun 2026 02:53:19 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8%5]) with mapi id 15.21.0092.006; Thu, 4 Jun 2026 02:53:19 +0000 From: John Hubbard To: Alexander Viro , Christian Brauner , Jan Kara Cc: Christoph Hellwig , Kees Cook , Cong Wang , Chia-Lin Kao , Benjamin LaHaise , Andrew Morton , Mike Rapoport , Paolo Bonzini , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jens Axboe , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, LKML , John Hubbard , stable@vger.kernel.org Subject: [PATCH v3 1/2] libfs: set SB_I_NOEXEC and SB_I_NODEV by default in init_pseudo() Date: Wed, 3 Jun 2026 19:53:14 -0700 Message-ID: <20260604025315.245910-2-jhubbard@nvidia.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260604025315.245910-1-jhubbard@nvidia.com> References: <20260604025315.245910-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0016.namprd13.prod.outlook.com (2603:10b6:a03:2c0::21) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|LV2PR12MB999072:EE_ X-MS-Office365-Filtering-Correlation-Id: 45e0edf3-01df-427f-3721-08dec1e46f19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016|11063799006|56012099006|18002099003|22082099003|6133799003; X-Microsoft-Antispam-Message-Info: b7SqiqPiyPkjaT6ADJPk4X0uTVRXSJGfHhXH/WmDAtkLal+ZUxjoNM9vYygHkzOSlyn2hIF/p7PXsAttuXdSkwQzGOnY2e79emcVq79yLnBbHBU4OB43I01xBbsodyKL5ZqwajHNCKLWcZKkxna5gLqPSPM3/GX8O4Z6hAUH/MFxVM0tHOmExa2bJVvTGxFyyccI2C8zR20fsFJp6h8N6dSMV+c1jX4q2+5UQmAjFEs89f3wufMwkSCrBIbHC/X8/hBNu7fC3O5KZiDsFuFIj6gu5s/cHoJmDsHkn4dv2HueZo6YMezPGeyyJl9pIykdqXtxrzQFIXV1uwNlHR46uPpJK1bF656ThA2pi4chjR60DcSMK8YRteFG/GSI7vjZAyKoVOqaV4Zhkt/YAS017giQ5eB7Au8oMl1dYn9EnqkH4+aqBBsBHygPMCXzHQ7W3fhN6JWuvLZ9jDF0Wr2/5mLaUGO5eARVvIXzWrcHfzeq7togACtFj0qOux4ZX5DQzqrEIpClu44cfkL35APpP1pLCcN25cSmECGvK7RdNEL7hjg/SydV7jhZPdRv6UB3zx4grmBjNtmmBSlK5ADCd1PqU7YNowaGWKc2v0+zlS0zSa3eVxC6T1L8AP7XYRA7zOaS/b5M7lOGPeS/YHGIH30SZsjwsQqmVSN3R7385uIq5/Jubnpqxo6d7syngR5/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(11063799006)(56012099006)(18002099003)(22082099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J0FTxK9CSwpbE1WqCzncPTxEGCLiVuYnr1K+/3+1in2fZNEj30hVqLY42gJV?= =?us-ascii?Q?smjMtyPIt+s2R1e/fAv1tsh6vSz78ugwLs1A1u3T2L9ZZKINTNB8W0UCuWnQ?= =?us-ascii?Q?0fVrY/cOfvaMmj5GPcNSYF6/frU/SNC39oIFfoF0D32wi/irzFkIvdIjz6pt?= =?us-ascii?Q?F6zy3eX5IN2ukwhT2btbWCJg/6XOe2NDJBAUv4dVGQzlFEN4gLRRqXN3ewy7?= =?us-ascii?Q?pX9zfT+d3O3zadFni7An3D319Yc/nwm8h4WB0FKGtlDxQiT/TTo3UPU4yAzf?= =?us-ascii?Q?x4RHEGy/Wajmj79gB8CC2+kBeGHLnwwKYEVNzHP72RvLOWxDGp059RBWCxTw?= =?us-ascii?Q?W4aCQDFPmuTktWiUdl4PAv4OObHTn8Egtu6ESmZO3m5BtSaSukb5yPfs0ig4?= =?us-ascii?Q?uNgzMcbH1ryieKn2W2iM6qSK06a8imneZqYZI6Q8UVa3wcZPa2rwdaljcsSo?= =?us-ascii?Q?iwZ1n7bHa8Q6/D3aH9c0AKGNgONjzdaVyfW/ZlqXVz9FI6J3oQ0dZuhd5dLU?= =?us-ascii?Q?43t9i2Xw0+GnMrLVBx+dCBGdY2g+EOf+3w49X9y7EWNyHmh9x2JQf2rFjFu/?= =?us-ascii?Q?vSELsQ51s5a2aHX1k+S2MimdYpDRG8j43XOGmprWDmDGX7FRpe15df2xpdKx?= =?us-ascii?Q?Ib1LpSEUU92AfVsOMmmZvis7KkxjJ/BHYW0U3CDjPQLdlN9gnqbUUt3+YfgY?= =?us-ascii?Q?Ow5dy55IFRNWXRbGmqN+tRvKWOn7RlYpTE7pE5hSQehhUQUGTfYqm3/EzbNL?= =?us-ascii?Q?sVhQtgMCYHgXVlxnUf950XRil/2TvEf0b9/PTt7E5dK2/EI4Y19zhRz5dYbI?= =?us-ascii?Q?NBDtmZcN1ALmSjxRqzgFk/rvd1ATpKSQ2Figpn0lXB0WIGTlM2AFpJMQ7nEQ?= =?us-ascii?Q?6MvG0T+x4B8xHUZX5LYB+k7gt/vvZaCwvZriIRJ+P8A+pkkczAW83F9XL7BX?= =?us-ascii?Q?FTbdzTlo37j3e5k9wWa9DtIygqoK5BDBXbbUx2WngKEDQuBVOFxT7Dw1e8zR?= =?us-ascii?Q?gHZ4a9IIrATEx2WEWVbNKaRfB82q1GnJ+oi4FnoBM0OIiR0MxOvSw5IPdTxj?= =?us-ascii?Q?YVMryD863nSAiqGrbKRImgEUD25CUX1GmGgmNX2WbilD88mzEck+ZT+ukapM?= =?us-ascii?Q?a/8970vRn4/T8wNPBiZGNUGb1vXI5KGysp8D+OWh4Pj03biCdZ8h20f8aOON?= =?us-ascii?Q?mQJiR5togRWEGNpiEDcFOSLqo4jxnxxW3Gc5HZ71BYH/GBA12Cq1vNQYGx/S?= =?us-ascii?Q?f9cldNyHIh4icfzizzdFjSYrd4wZvRAeItFjpgjwm9x3WYF81e+YKW7RDFV9?= =?us-ascii?Q?YZPxK+UQ9yDql3buY+ACYEGnyUr0sndjVbnN+Mr8Rvyy6Vrty/q0E8dCgX8G?= =?us-ascii?Q?Z6qQ5uMbK9wJ2kC/I+iWX6L4TnoeNvDBS+5ipBYzK7Zl02EqY7aCYRv7QB5V?= =?us-ascii?Q?jBSxOK7VOh40aKpNLIq/bqMghBhGv+XzhzB0dWLB3Gp4m/AcX/bt+7M6RMEZ?= =?us-ascii?Q?nnw9mNLYLEU1nEdWmBtMiZyBrPVLbmX3xIdK4sr3p48qHItImujtKdbIWJGz?= =?us-ascii?Q?KevTpOWDmjQdM9jCvkwUOvGe1T7Gn+QfBlXrlDESBhLbqewRUQAvIiUOhemv?= =?us-ascii?Q?2hxUkntnBwssyTD06AlMVgSxuhKwQDgz1af4q8jSQrS5n8rtvYTDqIko94xo?= =?us-ascii?Q?CfIMnuvleGrJcRXQUD12DSEy/YnKCFrUfVh1TsLLR/lj6E/CKWnAxomTS2L/?= =?us-ascii?Q?zhX4fNUirA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45e0edf3-01df-427f-3721-08dec1e46f19 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2026 02:53:19.5267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h0LWhp9a63ohjyevBymLnSQtrLjxEQAA+isHk8TZ69g94r3FlwrkKqQI7dJx4YSR5GuDMc3emxkTFCQQmL5RWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB999072 Content-Type: text/plain; charset="utf-8" Since commit 1e7ab6f67824 ("anon_inode: rework assertions"), path_noexec() warns when an anonymous-inode file is mmap'd from a superblock that has not set SB_I_NOEXEC. dma-buf backs its files this way and never set the flag, so mmap of any exported buffer trips the warning on a CONFIG_DEBUG_VFS=3Dy kernel: WARNING: CPU: 11 PID: 121813 at fs/exec.c:118 path_noexec+0x47/0x50 do_mmap+0x2b5/0x680 vm_mmap_pgoff+0x129/0x210 ksys_mmap_pgoff+0x177/0x240 __x64_sys_mmap+0x33/0x70 init_pseudo() sets up internal SB_NOUSER mounts that are never path-reachable. Set both flags here so every pseudo filesystem gets them by default instead of each caller setting them. SB_I_NODEV is inert for unreachable mounts. SB_I_NOEXEC has one visible effect: an executable mapping of a pseudo-fs fd, such as a dma-buf, now fails with -EPERM, which is the invariant the assertion enforces. No in-tree caller maps these executable. Reproduce on CONFIG_DEBUG_VFS=3Dy: make -C tools/testing/selftests/dmabuf-heaps sudo ./tools/testing/selftests/dmabuf-heaps/dmabuf-heap -t system Fixes: 1e7ab6f67824 ("anon_inode: rework assertions") Suggested-by: Christoph Hellwig Cc: stable@vger.kernel.org Signed-off-by: John Hubbard Reviewed-by: Christoph Hellwig --- fs/libfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/libfs.c b/fs/libfs.c index 1bbea5e7bae3..e8226b9e1bc8 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -736,6 +736,7 @@ struct pseudo_fs_context *init_pseudo(struct fs_context= *fc, fc->fs_private =3D ctx; fc->ops =3D &pseudo_fs_context_ops; fc->sb_flags |=3D SB_NOUSER; + fc->s_iflags |=3D SB_I_NOEXEC | SB_I_NODEV; fc->global =3D true; } return ctx; --=20 2.54.0 From nobody Mon Jun 8 09:49:06 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010011.outbound.protection.outlook.com [52.101.201.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC993AEF20; Thu, 4 Jun 2026 02:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780541608; cv=fail; b=YilPTbPQOGpVSuJEQ/sbECoRcEoEI3vqG8uAYt2IdGOG1hCkwhRIIlbq8ISHXAvk3X7C8S8Cgx/L1n8hlaefyQIO4TPWiWs7vpYVsGJBlY5NnG/FACrzAIcM1yDXvlSHHK5zZzmzAv32zf4cJQcrykKlifXZwgb7FvSxsXlu8+g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780541608; c=relaxed/simple; bh=y9KjTAjw7P1VAoeIOHMKxUHsniHJAXfuVFi42Wu5Xyw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=mHq6m7pSnxBNI6C/+bVxG2EteKWGMpvGHn5xGoSGTuV5DWrqAMzuGBSAu40xjySLd1uyllEgXpve4GCegyTn5cXnCltJXlAOegXqIzTqymTY0vWn1wbgEflR3Mak/xOeCGVV4mDStEL5V53GJoZ/ZLRhGgNtc2nR160hE82Xi/8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=BsUtxZEE; arc=fail smtp.client-ip=52.101.201.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="BsUtxZEE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DDSUz2o6ZyVVwLcfdI1jOq1ZW0fkWJTzLgBHH/WkdBkKhb5lJ5GyX79cX1Qwbz3NnFGsFUitVSrcIob2+gIZmQaPyZGqwDYeUtm2p/rpkdF0o5+9DHx8b/U/dCnMqAQcQm8Z70TWlsXXLi6r1J3S1ORdUq1uHlKYL5jVuDjuJiH+55+UMB9fwZvXsk0o6LEtf6xELEoxEQIJPGe+zb8E3orY8Ln2mBuKS1gDc5dPvJDaTmJn5u9nV0saBFhQx2Y5PUTg34LbMSnJVdLwmpL0YsU0fUU6YJHvyVzBxm2QzxYulJBYGQh8WM43110ZK8Zk32hOIypBZo8p/zLtzFkbgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=khUZ2Q8lrI1rHGypm9wMPqVGRa+3CwW2C0FwHsof6hQ=; b=aSlMGW7Sia9872yyu5To3NzBmevdLbgPSLd19KDz6kdNq8HZrHOWkKv/uQlPuoOMJiQWVGk/VRsRR2p1LoGw3P9gkgJhHNnRQRCQUMs2MNKVgBQHAoECM6e2nkOGbqbwefaJy/aM9n+V5z15Is7fs3sxWjwJ+kFbQipWgkfZYWD/YkeGUi7JF0XKNwEtBTho4ERmklIBx7gpBMGRAI1Gf7OLFGNgOw6tPHn4olDsSXs1kBfVNeoWrip0QrRxQJoOOs6H8TZM5t+64NukAr683gRXTV2auAymKG6qfe8ORY8qAJFD6DprnlW6veERLtYGFyJXgQC8QgvGCBid5VWM2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=khUZ2Q8lrI1rHGypm9wMPqVGRa+3CwW2C0FwHsof6hQ=; b=BsUtxZEEypojRnuPP1GfA/n+4EGY3xf/WLAbKLqWJv3Jl97bv6VKAUYA4Uuw58j47xOJmnmtm7gLEN70NPZ56zgnGJOeaVn3fcaHIJ3nNqtXcMI/MfST30WOZloi+92JnXBXvSa8BsaWYmyWfN5Y+yHWyEn9LBTOxA/sm6jUr0oOBWImOusRRdPw4WZxaVQeXjfsqpVwKEKjL0wRxDq6pBnfVCwicDGh7auF/ASNH4xPmc5PELpFPRQjG6gc5NFlBg/ZzB4Lbh6fmJUkj8Od8/7SFkzbJbgdkAZdNloAHcb22kq/RrJ8qu7iAasXs/A6RzvljU+nwwdAEUG4YZtSpg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by LV2PR12MB999072.namprd12.prod.outlook.com (2603:10b6:408:354::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Thu, 4 Jun 2026 02:53:21 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8%5]) with mapi id 15.21.0092.006; Thu, 4 Jun 2026 02:53:21 +0000 From: John Hubbard To: Alexander Viro , Christian Brauner , Jan Kara Cc: Christoph Hellwig , Kees Cook , Cong Wang , Chia-Lin Kao , Benjamin LaHaise , Andrew Morton , Mike Rapoport , Paolo Bonzini , Sumit Semwal , =?UTF-8?q?Christian=20K=C3=B6nig?= , Jens Axboe , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, LKML , John Hubbard Subject: [PATCH v3 2/2] libfs: drop redundant SB_I_NOEXEC/SB_I_NODEV in init_pseudo() callers Date: Wed, 3 Jun 2026 19:53:15 -0700 Message-ID: <20260604025315.245910-3-jhubbard@nvidia.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260604025315.245910-1-jhubbard@nvidia.com> References: <20260604025315.245910-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0007.namprd05.prod.outlook.com (2603:10b6:a03:254::12) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|LV2PR12MB999072:EE_ X-MS-Office365-Filtering-Correlation-Id: b0ae9ae8-9a47-47a0-ab82-08dec1e46fe9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: b3SbZ5CBYRDixONPxDAmeIsVTUm98ZBJttM8RLQ1A7ooJgyOsmNA9yscrTraqhS+RxmktD55TUcA0Y1pXsS7R0EBTsnvsYn6VCxyk1wPo+sOgTAOwuA7IalgZIGhAvqcD9CMABlJyBnOl6OdInxcCJXNs99SMvVJBV5EzTkz8H3Jx/LUVpGMViXnb8GvmEr1+NCJ0RKPnnuSgh872cRciIvBqy0xMO7c6UevO1Fq5PddY1liEJKk+p6me0EHTCYgG1wHUmpRfmh5z+cLyD/aWY9TmGVmZVG6WJwL0WgnLP9TjolokA5+QEZVfoMubhB/tWa3E7324AtLoFP0c8swvufhOp9oYLkGPpczwZVofAIlg5sLx6WJ39g1/fslcmsP3Z0obGuVDDaXEtgNn99ceFyZuYWc87u5agHM5R4VXBOx8z8NPQvjtE0S6MKIj4p1dx4j4fWoac/Bs3tY5nZ/s8u33VUVvmTyVT86FY3J63AnqK1w0VD4tHVrqbYeBBMX0v1Rb5WPPSrlTYMY7h9pMqBza92pe9EUTzA5ANeaUdwKrN0sPGLoakAsvbYcGe9A1n6WrrkINTo/+vRFEH/z7awfcbh4AB6keeODDDXMJf7slss6aD84b3RQkgfKFBU91hKDr9vPPOuYGbVDKllj/kp2znarIOPVe1XVJ8rqMmHZPxFMPmC3JcK/WGHjDNPX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nanr1v9SfcxHGg+6zDbxgPbAeCEBg3vC+ztLaHvLu2agZ7gi0LW0R1BSW6kg?= =?us-ascii?Q?b1aXscGDi09WpU4+7uTHKs3kIl4ZBXHN82GMDpRxiGwo0RzobloGgwtK4o/O?= =?us-ascii?Q?GLfj/Fc99YNW2bJXzI/zKuGT3qyUvobapmBUA8TfF3O82+QJtTjflw/cUSbe?= =?us-ascii?Q?6qxU7NMv9nnayDWy4xlkBZAcejN7DE5UwDA5YMyHwlg+3U0T1vGxGTrX/48N?= =?us-ascii?Q?qJ+OL8Yl2jpUVLit1K9gbRsGglRPvNyKFD6x0LwrtUbA8F9K60lkWJOW3Kza?= =?us-ascii?Q?1fS6g+DokOIC4jfJ7W5sC32wqDi2/8+RgvMYzvXtTMBTT8Kia0yYmEhQm4xU?= =?us-ascii?Q?WFpC3bhvGBXwAPfwyqi5gezXXN4FoIYveFuHmQnWOlRbLpLmrOOAxiWPzcuZ?= =?us-ascii?Q?45uCcv/29GheUqPkBIaBaasQDeP1E+ydcPYMPc1Y1yeP8T9YsB/qLK2Y3uS7?= =?us-ascii?Q?R9hSD0oS0K93Is9x5KpbS7akUVaJBdrV4rvk8Upk0iF+uB6k4qb6N9QhojTa?= =?us-ascii?Q?UNIBjMaLct0sVivBzhygj7AB85dcuMtXWlcT6mTue56lAaKVmQ5ii4itpFMT?= =?us-ascii?Q?AKu3l2EAvVkaxkngwp32OVvaWUN5O5GaCJEtpqdaDvZCYs5LTzfRRd6TqLdy?= =?us-ascii?Q?+frz9fypMxF2gpu6EhlOvzUUvBQMZ0EiMzQ3KgsGEsXL/IUyyFLubBIpQW1T?= =?us-ascii?Q?QrV7derDLjB+rMscHiJaRMlTuQeDFnjls0c6tMRjtzWIZqH9iwMjialzmne1?= =?us-ascii?Q?QKLIILM7fUKKO4dc0DdT6PcSinGALcqygjbSPHINoCo7em4qgwXpg9ONj4yS?= =?us-ascii?Q?fNHl6x+7E309bApEnzqWH6iK7migC77D2aGOTdJ0/aZiA0fKTrNyRlQs1HGF?= =?us-ascii?Q?lxlzgUBWjVL+ZFF4zYcNrPQ/OeTP7vP3Kf46lDv0AVMl19LuLNH+Ke7oxnR/?= =?us-ascii?Q?+D+Ey1x1nOfAK30Hy54QKGHOCjiZ5K//yWiUc4eYIePqMtmanqB15ylyKq8t?= =?us-ascii?Q?jVUMfPYa5OCpY28w0PuaxPBcgd60GgpLsImm0ELEKcYv4atuSClkkmDDww92?= =?us-ascii?Q?Lr6Y9UMipBcj6AmLfTzx1n/2FrSJnykwMXZwkuDdP85g4oJSFf5bQq1I1C/A?= =?us-ascii?Q?2BO0ypGWvjwlxFdzMqg/vjcEJUdOLnQjudWYFgZKGtUNXjg5W45UCkyWngy5?= =?us-ascii?Q?7yz5lay8yFT4J36bLNVdBfE6+8AdaUjW4KCd+GXYZTdH/TwWIw5pgneE4VRN?= =?us-ascii?Q?Ruqht8XKc/IN0xOlmMKmYSMypvLtjTv9Tr/oC+k/sw00D6wOJ32i6mugXD6S?= =?us-ascii?Q?52hYLxWX4WUgU4tYljlL44BWmrSJVzE3D70q0KWPCp+uBErL3MTcf2CNsMFz?= =?us-ascii?Q?QQjpMNsnBZmvzIsN5bbzplYpUds9//t0SKwDn/dIL9JymREJCGYZcmmNA7sB?= =?us-ascii?Q?iZc/Y0vGzHzHt64vaQyLeVVV3G08Tt5B4NyNekQA5QSX+/4cctjjWDpGSJQ/?= =?us-ascii?Q?945rDlX4hnP39l5R5IJZCsoFXf6IIMMK3QOFnzqOixLOOOCZP/ICHIV6F3GV?= =?us-ascii?Q?nnPDldwTzkcahhW4nWq6dQxN/8MPuNvjn/y48xxIpDhl/tz6ILlpJS36YYGI?= =?us-ascii?Q?bWt/cVDaJtxlCLia5ooPdGiJBj0iwU/45oaBMR78YJe2PBp5YWfRYOkwi/6R?= =?us-ascii?Q?pE834dSybTfahYWfZz9eBT55NsmBimWOJK3vfgyunWXLGrDzpnPsLZD271+S?= =?us-ascii?Q?z2Amb3qDYg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0ae9ae8-9a47-47a0-ab82-08dec1e46fe9 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2026 02:53:20.8908 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qHS7ecOd0iqOF12BpSXW6exq4cY/IAFGdcdvvguzAOSC1OK0pEYlQ3VpbK5zs6YNmXD3zBjQr23eAdRDwq03uQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB999072 Content-Type: text/plain; charset="utf-8" init_pseudo() now sets SB_I_NOEXEC and SB_I_NODEV by default, so the per-caller assignments are redundant. Drop them. Signed-off-by: John Hubbard Reviewed-by: Christoph Hellwig --- fs/aio.c | 1 - fs/anon_inodes.c | 2 -- fs/nsfs.c | 1 - fs/pidfs.c | 2 -- mm/secretmem.c | 2 -- virt/kvm/guest_memfd.c | 2 -- 6 files changed, 10 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index 722476560848..f57fa21a2503 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -318,7 +318,6 @@ static int aio_init_fs_context(struct fs_context *fc) pfc =3D init_pseudo(fc, AIO_RING_MAGIC); if (!pfc) return -ENOMEM; - fc->s_iflags |=3D SB_I_NOEXEC; pfc->ops =3D &aio_super_operations; return 0; } diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c index b8381c7fb636..a7b9b948e33d 100644 --- a/fs/anon_inodes.c +++ b/fs/anon_inodes.c @@ -86,8 +86,6 @@ static int anon_inodefs_init_fs_context(struct fs_context= *fc) struct pseudo_fs_context *ctx =3D init_pseudo(fc, ANON_INODE_FS_MAGIC); if (!ctx) return -ENOMEM; - fc->s_iflags |=3D SB_I_NOEXEC; - fc->s_iflags |=3D SB_I_NODEV; ctx->dops =3D &anon_inodefs_dentry_operations; return 0; } diff --git a/fs/nsfs.c b/fs/nsfs.c index 160018c4fb36..c3b6ae76594a 100644 --- a/fs/nsfs.c +++ b/fs/nsfs.c @@ -664,7 +664,6 @@ static int nsfs_init_fs_context(struct fs_context *fc) struct pseudo_fs_context *ctx =3D init_pseudo(fc, NSFS_MAGIC); if (!ctx) return -ENOMEM; - fc->s_iflags |=3D SB_I_NOEXEC | SB_I_NODEV; ctx->s_d_flags |=3D DCACHE_DONTCACHE; ctx->ops =3D &nsfs_ops; ctx->eops =3D &nsfs_export_operations; diff --git a/fs/pidfs.c b/fs/pidfs.c index 1cce4f34a051..c363416766f1 100644 --- a/fs/pidfs.c +++ b/fs/pidfs.c @@ -1115,8 +1115,6 @@ static int pidfs_init_fs_context(struct fs_context *f= c) if (!ctx) return -ENOMEM; =20 - fc->s_iflags |=3D SB_I_NOEXEC; - fc->s_iflags |=3D SB_I_NODEV; ctx->s_d_flags |=3D DCACHE_DONTCACHE; ctx->ops =3D &pidfs_sops; ctx->eops =3D &pidfs_export_operations; diff --git a/mm/secretmem.c b/mm/secretmem.c index 5f57ac4720d3..4877c262cb1f 100644 --- a/mm/secretmem.c +++ b/mm/secretmem.c @@ -245,8 +245,6 @@ static int secretmem_init_fs_context(struct fs_context = *fc) if (!ctx) return -ENOMEM; =20 - fc->s_iflags |=3D SB_I_NOEXEC; - fc->s_iflags |=3D SB_I_NODEV; return 0; } =20 diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index 69c9d6d546b2..80f201035d77 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -973,8 +973,6 @@ static int kvm_gmem_init_fs_context(struct fs_context *= fc) if (!init_pseudo(fc, GUEST_MEMFD_MAGIC)) return -ENOMEM; =20 - fc->s_iflags |=3D SB_I_NOEXEC; - fc->s_iflags |=3D SB_I_NODEV; ctx =3D fc->fs_private; ctx->ops =3D &kvm_gmem_super_operations; =20 --=20 2.54.0