From nobody Mon Jun 8 09:48:11 2026 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAC10C8CE for ; Thu, 4 Jun 2026 00:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780531874; cv=none; b=Fcyg+pww/laYSxDboisrEhMVA/5nCFIlRmJ92pTdTndk4vQkUKvyq7mrGbOW5noMEx7ie2Tt6qHNfRDGyu8MTQcsdPLsZEe3Kt7ejodlQ3yVwFhRrSXjE2biFRTukPZrj88YtMLVAT1QsDXNry3UgaXUUM7r6omqKwzjDBGK9d0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780531874; c=relaxed/simple; bh=X4zBS/0rIRr5kJf5yJUMlfYBwrqmipKAekQvJYznmqY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qBpmPlNXwIfE2vC1O5sAs08u7MsniezEycHXsB+yj0eUFLUYMAv0wXbSqAIaUAUl31zcmwTbYp/qSk/K3pmT0wzUzG9qLkuco6/qxvrxYmxiQYBZ3MpyyT0CQ0B7a0EWSz0Wq1d5w1FMQX6G6EGzqk1BoOtWQsCgV38fY8gemmc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=d1xJgGHG; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="d1xJgGHG" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780531870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kY0JOrGKHWHsX/V5r+8L8q5T7CTQVdqKxlvXCGnw9d4=; b=d1xJgGHGd90+WyhadqaFVXdRBXuW1YqkxBH17jkNjJRvfVJx4717dkVqUzrQ5r+XK0NFEE CaOjzW0b2T9aPLeHwq0vl+2smQGaBTMKBmDbIOwFW9lrPsVPYU5l9HFgrC7bakimziO9gb /z7pYt4Z6hJWwdBeiB9RV4TvYoXn0MU= From: Thorsten Blum To: Herbert Xu , "David S. Miller" Cc: Thorsten Blum , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: omap - use min3 to simplify omap_crypto_copy_data Date: Thu, 4 Jun 2026 02:10:36 +0200 Message-ID: <20260604001035.1256238-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2263; i=thorsten.blum@linux.dev; h=from:subject; bh=X4zBS/0rIRr5kJf5yJUMlfYBwrqmipKAekQvJYznmqY=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFkKh6ptEvc4P897GDh/yVovZitPTp+Zp/89bdrjuvsQ8 75zv9Y+6ChlYRDjYpAVU2R5MOvHDN/SmspNJhE7YeawMoEMYeDiFICJbHrByDBFf9VEg0z279tl zZum+NRI1dvNvlWeld1xsYfVayKXxCqG36zBkmvqyxLvGWyPD65NYEnNFhLf8mqC8ZX3XPP1v/4 tZAcA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" Replace two consecutive min() calls with min3() to simplify the code. Change the function parameters and local variables from int to size_t since these represent unsigned values and to prevent a signedness error. Signed-off-by: Thorsten Blum --- drivers/crypto/omap-crypto.c | 12 ++++++------ drivers/crypto/omap-crypto.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/omap-crypto.c b/drivers/crypto/omap-crypto.c index 0345c9383d50..c0400fbe313e 100644 --- a/drivers/crypto/omap-crypto.c +++ b/drivers/crypto/omap-crypto.c @@ -156,11 +157,11 @@ EXPORT_SYMBOL_GPL(omap_crypto_align_sg); =20 static void omap_crypto_copy_data(struct scatterlist *src, struct scatterlist *dst, - int offset, int len) + size_t offset, size_t len) { - int amt; + size_t amt; void *srcb, *dstb; - int srco =3D 0, dsto =3D offset; + size_t srco =3D 0, dsto =3D offset; =20 while (src && dst && len) { if (srco >=3D src->length) { @@ -175,8 +176,7 @@ static void omap_crypto_copy_data(struct scatterlist *s= rc, continue; } =20 - amt =3D min(src->length - srco, dst->length - dsto); - amt =3D min(len, amt); + amt =3D min3(src->length - srco, dst->length - dsto, len); =20 srcb =3D kmap_atomic(sg_page(src)) + srco + src->offset; dstb =3D kmap_atomic(sg_page(dst)) + dsto + dst->offset; @@ -195,7 +195,7 @@ static void omap_crypto_copy_data(struct scatterlist *s= rc, } =20 void omap_crypto_cleanup(struct scatterlist *sg, struct scatterlist *orig, - int offset, int len, u8 flags_shift, + size_t offset, size_t len, u8 flags_shift, unsigned long flags) { void *buf; diff --git a/drivers/crypto/omap-crypto.h b/drivers/crypto/omap-crypto.h index 506ccde6f380..436f45f3bb7d 100644 --- a/drivers/crypto/omap-crypto.h +++ b/drivers/crypto/omap-crypto.h @@ -28,7 +28,7 @@ int omap_crypto_align_sg(struct scatterlist **sg, int tot= al, int bs, struct scatterlist *new_sg, u16 flags, u8 flags_shift, unsigned long *dd_flags); void omap_crypto_cleanup(struct scatterlist *sg, struct scatterlist *orig, - int offset, int len, u8 flags_shift, + size_t offset, size_t len, u8 flags_shift, unsigned long flags); =20 #endif