From nobody Mon Jun 8 08:36:53 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EE3138D3E3 for ; Thu, 4 Jun 2026 12:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780576905; cv=none; b=K1+Mnmy3bIU0SULbbisqD6yrvDAH5oEm7l8qHvVXlMV1C1mKfO4kq3rGmKVY0Hdv8Osd2N7nm+DFHPf6+hu4vrEFzpK8UwB2dLoVYKhEmwRZi8q4Mr3MgFHviEYFTDISpM05HqqxHxyQJ/kpy+S7T1vtRG5A3b8VcUn3IKN3Dtw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780576905; c=relaxed/simple; bh=PVulcB9RNrXLgA6wJCM8kgQhPkwHb2q/wuju0YvTZp8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=vA+zszLP2GPiaq5rKsJUnz5AcUZOyIbn/FfXJ1ce4emvFzw/zaPt+txndxiIXN7VzWE0FAq/XBrd1PDPDfCrMjCEaZrFc3tUzyTYGpg2JVUaDk+8lrlKE/d2K+L2/G9z8QVi8HgTixAowVajFdbXr0rObfk3+Idb+oQX8HgVXF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=I/Y4xjFI; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I/Y4xjFI" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-45ee5cdbd28so1206494f8f.1 for ; Thu, 04 Jun 2026 05:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780576900; x=1781181700; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G1vgkxcaylBA8azApK5d6CMeHyMeuKB3ssqM3/nYuME=; b=I/Y4xjFIUxBUY4YdFVsxU9AEjmRRlpAfBxJpvSOEFDHvI8hBxWPSHfcrmkmLJzpfE8 qHAsUrz6u/uSkZ5VpKeFOOvY2LPM7NcZKzOdPpYKcnDQ9m71aAojOVGrH8HdtjWeplgr FhEfJWG/d7fc9uCfQMHwyIVK0fK4wigM4Z/TLIBB4ZWwq6MMJuc46zHNIpfutsf0Gx5X gJwpMIu2TFIjaUU/jEPMGKoKRQ4QIR3Ye773hYVhKJ9s8VKstartHQGsUwkvuUwUsUq9 c8tvcwKaNJkQ2Pgrqpl64PQKFAfFASH63yRFgX5+FOnvaaCaJWka2SkZV3Pqoh1KE8EC PBqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780576900; x=1781181700; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=G1vgkxcaylBA8azApK5d6CMeHyMeuKB3ssqM3/nYuME=; b=IS5vrNFQcUOH3ElycsTXJU4iXLLTAUESPm75xQK5BgQCSvWe6885VrY96LWFC36cks m4Pmo5pKMtAfomZ/VJBkYTrAb2LWOI/s7SnXOGb2F+/uucU4ff5ifzCCNzC8G3ESOo5U D0ZjMiTXB3ZPol94tCOZiNGEJAs5x8cAgGgaprCR6Ei5uHDcLxs/gu5sqEVCvUKPGf+S N0bdPxOCxqmv7jesjBiA8b9/mlw7xfLfUgdq7t8kVE7mgC1TKCst6+yfZMQcmQlXjSd7 UEg8QVvOkZAG1qpEts7GaOONoDGeePkgI9s7hXv7GJ3542Hbmh6p7EzBlsEutXgXF/qS Onjw== X-Forwarded-Encrypted: i=1; AFNElJ8en993GaT/26osIhHlcko+G07iTo2WuF8g05VMY4KUIlRtbRjWFPIaYpGdxoaBhU0E25fCRKIZoaFuhEU=@vger.kernel.org X-Gm-Message-State: AOJu0YzPW91WxIIRZpCRHOX4+MYIAizF6TVN8r7ssAGd/8dZoLtgN0On ewmV4jZquNA72dLHKoz9P2JFgQR4Fkdodqs4nW1EnpDdchGVtv5PGGOvMhLrUTqETrs= X-Gm-Gg: Acq92OHzHJ0IrXqgmjDR7zxUbHSs4X/18qBPjMv6aLbjWSNFhlo1BxCfkqqaqm9WNP1 OJ1VAln0MKQOKxcycQ6rc00+SvuYBELHpTe0OEr9aNGDGuEMvbxZ3yBmDsrd8+at8DGv7MvGh+i 3Vyf4q0rTWTqk6NycCEssAoNOxNa1oXgPFFm19dNZuHw1TXvlTSoP/pIV9U4esJaHaYxbDSiVPU KySuwC0M12eTFi3WlIghjE22xUYy4nUIHAjPs0LEK0mTURtptUqWZU/X4WqgJfJNEvMY4W3Jtpr /tD7RMJ6zuXSNmjqtO7rroA/mmyvI0MiF/D2pjn0c2NCTwKt9RNIXERemMguo9tlyOGsj2oduYP vWkRzmi7C8kaRJyarmlQMK4SaMrPs3lT3hurMEpl0fQV9vfZj48JOxE2G9QmEPOr5J4/CtaqauF CFSxLRVtnvkNzwwOTs1AKtr87QgOeE7pfBczZOHfALTFESF1SRipHQlJE= X-Received: by 2002:adf:f1ce:0:b0:45e:f7ae:d599 with SMTP id ffacd0b85a97d-460276257eamr3727151f8f.25.1780576899309; Thu, 04 Jun 2026 05:41:39 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:106d:1080:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f35133csm16242686f8f.25.2026.06.04.05.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 05:41:39 -0700 (PDT) From: Neil Armstrong Date: Thu, 04 Jun 2026 14:41:35 +0200 Subject: [PATCH 1/2] drm/panel: Enable DSC for Visionox VTDR6130 panel Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260604-topic-sm8x50-vtdr6130-dsc-v1-1-09bcd1dff1fb@linaro.org> References: <20260604-topic-sm8x50-vtdr6130-dsc-v1-0-09bcd1dff1fb@linaro.org> In-Reply-To: <20260604-topic-sm8x50-vtdr6130-dsc-v1-0-09bcd1dff1fb@linaro.org> To: Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Neil Armstrong , Jun Nie X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2542; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=iGIoz8y1+kxK+14436kxQSVWpsKrM1ada0Tll73iubA=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBqIXKBXsDigPKaWtmUskWy1IhWMEwjKdo/tOfBeFb4 bTOVwZ6JAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCaiFygQAKCRB33NvayMhJ0UDMD/ 0ZmDJf+5r63D6HghIWgKgYhGJPXRoxiL1JfJIiDoHdzEj2ncdviZUmB/5gIPHUC6oe3E+3YJ2D/EwE hXkvcB/iIFFT5OwzK5XtmbX/9fMtHE2T91GkhBMdVl08UbEREpIVkKKCQj7HhYDCrfw+WGXAhUhp8r BgRqxHSSxkTfE6ZQll6ZhA1Qo4A9p8uJcLCVf+fEwlhkbVtoXCqnGqrQjhdhmXxCYsvYzmES0iPAb3 8nGxOs4fKwID2FLUX6BjZueL4XXPZpJDaxUz1F2u+RARVpvdv0Owoie29LVG/D2u+KCFnoC8VdTgEh lDiNoq/UBvz0hueUWReTY8pz3anyqbqlOzBbx/e7BJNiycFodVtpScGtEVIBMo2abnpte0FZLM+Nif S00BCs0meSUAtkXNo8CXH9iu8cfvXJReJ9GehwRd9PfcgdbB1vO+zL77w+BoP9NLVQPjRzNIGsFhwM wkqPJaJMCKC9SjLaxxzV5/OfJpupjA4xYJNnNfxjXQUoBCndxiQcpvUj6zaKTlwfHUkHMsAtbTkM0p Fi//lg5zFLDeiayX/nIWdD1B4njQJcVg6TBIWcyhmd0IVmq/EB7VgM7FTladPh7MbGLjViMm1D3Sqo 5wW8R2cy8DfrmCbAA8+wy+atJgr6/b6VoWg0b3j3b6rBe3m9RLD8u88Ns92g== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE From: Jun Nie Enable display compression (DSC v1.2) for 1080x2400 Visionox VTDR6130 AMOLED DSI panel. This panel is the default panel for the following devices: - SM8550-QRD - SM8550-HDK - SM8650-QRD - SM8650-HDK Enable DSC since now functional in the MSM/DPU/DSI driver. Signed-off-by: Jun Nie Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/= drm/panel/panel-visionox-vtdr6130.c index 97a79411e1ec..0cdcdbbc766d 100644 --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c @@ -9,6 +9,7 @@ #include =20 #include +#include #include #include #include @@ -17,6 +18,7 @@ =20 struct visionox_vtdr6130 { struct drm_panel panel; + struct drm_dsc_config dsc; struct mipi_dsi_device *dsi; struct gpio_desc *reset_gpio; struct regulator_bulk_data *supplies; @@ -47,9 +49,12 @@ static int visionox_vtdr6130_on(struct visionox_vtdr6130= *ctx) { struct mipi_dsi_device *dsi =3D ctx->dsi; struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; + struct drm_dsc_picture_parameter_set pps; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x03, 0x01); + mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx, MIPI_DSI_DCS_TEAR_MODE_VBLANK); =20 mipi_dsi_dcs_write_seq_multi(&dsi_ctx, @@ -123,6 +128,9 @@ static int visionox_vtdr6130_on(struct visionox_vtdr613= 0 *ctx) mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); mipi_dsi_msleep(&dsi_ctx, 20); =20 + drm_dsc_pps_payload_pack(&pps, dsi->dsc); + mipi_dsi_picture_parameter_set_multi(&dsi_ctx, &pps); + return dsi_ctx.accum_err; } =20 @@ -269,6 +277,16 @@ static int visionox_vtdr6130_probe(struct mipi_dsi_dev= ice *dsi) ctx->dsi =3D dsi; mipi_dsi_set_drvdata(dsi, ctx); =20 + ctx->dsc.dsc_version_major =3D 0x1; + ctx->dsc.dsc_version_minor =3D 0x2; + ctx->dsc.slice_height =3D 40; + ctx->dsc.slice_width =3D 540; + ctx->dsc.slice_count =3D 2; + ctx->dsc.bits_per_component =3D 8; + ctx->dsc.bits_per_pixel =3D 8 << 4; + ctx->dsc.block_pred_enable =3D true; + + dsi->dsc =3D &ctx->dsc; dsi->lanes =3D 4; dsi->format =3D MIPI_DSI_FMT_RGB888; dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_NO_EOT_PACKET | --=20 2.34.1 From nobody Mon Jun 8 08:36:53 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA294290DBB for ; Thu, 4 Jun 2026 12:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780576904; cv=none; b=qjaJOtvhqFv1ylexK2v53ayPLzONsWtMCE3cDdjrfVbI1lyaGyN6FiGSvkhdL8E5zPHUBfsbFjp5MQY4zfr6oVwLyAILEoKsKx/5dbdtcmz8CEzgVC+BFKPiYzaE6RNJ2cExUzhGZFZ3m4goa8s4dt3+YPUYnkZh1goCpDReOwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780576904; c=relaxed/simple; bh=f5/dVqkaXjhX6dtp61tSmUjJiQd2J/ejrflXA7Mzdjg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RYuBEbeE5jJes/U8s6Dn4KMdWvcYt6sIxre2p8CA9Qyc6w1R9Le4zdpqDFmQzp/H/rLWp/wwGkzhMd4XYL8KQyvts5lv5XgUHlIXa2TGC4NzppUs2MofSKdjSF00qX1m3yLm3V3fd0DA6K35INyYlUP9VOHjOezje6j4lZ7Xrd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nrWYOGFj; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nrWYOGFj" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-45fe59255beso328864f8f.1 for ; Thu, 04 Jun 2026 05:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780576900; x=1781181700; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oX956Ovy0cEzFC2KbieHkOQE6+VfzcgweLx9ANa2s88=; b=nrWYOGFjEeCHipRW8ri4NCNe3bghFAiiHF6TenHMPyog/Ueeo7rH2IFn0ISKv3M4ed 1AzWPjkmSiHuMXvKYEUmjq2lkoS2PlF/BWuShXhz10A+tTliz2fb5L1pUqvVZazaS+fN TYanzutJ9PFeDjWTDreD84pifnFcHXDHLaNQ1cB+I+KYJfUXW7K6vmmbEfZH2F+U2pcv MhgMgqDye13escyltXAhz0ZMlFKM3PEPrWVaCnco8IhdtyNEV569xPlrG+XNMOrq19FO unq+lWIPxKQxIL1b4GWb2Z/8eT5fOuvuT8ndud961wrV2ClFR7tBXyoI59KiNrb0mFQp jfww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780576900; x=1781181700; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=oX956Ovy0cEzFC2KbieHkOQE6+VfzcgweLx9ANa2s88=; b=ivtlG9GMsupa1ERQdzFvNsj/r6/JFQzv07cVsDA79G8cyptkcBtUJZUaUgROBDbtXv bVfzlZ13cH0g2MLA3SVX/+6IGCvxJ7oOWHZ37x2xItf27DxV3Fz+qQA9VYyrCLxphRFD c4iBrbVqL0HbFKBF7HQxuOb6CEd3k9AF7b36g8W0nTBqL07c81/55Nnuza6o/u8bQLwG IjO9wPlVaJ5R+6+nhkBtRAozmuaKMdw7MJKjyhdLkwXa8ZpLbAdqWCKp/rOcjY2TczOM 0ABnRgy5F/g4sVqdCQ9CXAnL1RYN8v6GOueSV62BKb6p42VbuapiqQmfkX/qRUtlxFHM p8kA== X-Forwarded-Encrypted: i=1; AFNElJ/VSc6cY50WNx/lYMqQDdLEb1Gc8DAUL6KgUZvQzmrqbSrI3Lzx8M+Z3QRzJMXGqX43lzOpf2qdxsOJ9sA=@vger.kernel.org X-Gm-Message-State: AOJu0YzvAZ2bKkGIqKWHMe1iOYqHMcLMyXlFw8H/qMFact7tcZxGgGUN taqsEbg2Tj4EPQBRfF6heRWfoTNv0BCjFpWuxS5AXgveuDa5GOpnf1sfJGJ/ng6uhID5QtjIv4K iX8hj X-Gm-Gg: Acq92OFHG6L3Ch61Knyon4poCkOHMXRPW4r6eXsBwHiNDeoUs1B0I+GneEXCNX+aTNJ zChyQr9lAuIuTS4SN5RMyNPX+TqaeKsb0vGwbkSeiOvZI6m4+xQM9JeI2+8BrzW/1UXUIdgpuqW MjOU/Xx9se0r0LRXlrKXadzp2OLcjXJyDD5nv4KWXP6tHMHEDoFCnPsu38jWPMF1lJ5/Jpt5PWJ bhTov3GVzcth7w2eMUXi1uN59Vlu2yFmKzi2Mhd0cIyVq2NwM426wMzSyq51yiMR6TyIUtsgMWF w4CtEa0yrJufv0+6mPkHCuJe7yc+jdcN4e8BqcONhTOBs2fPaJtOhjMKPVxz1SzEbtaiqDUkgRD YD/bq0z5uM5RLxH2srhlXLSKs6qYjgyUNsI3aw9YaRsz+fmdVHQkMrOfM8lnXaMwPL64zrQZSYc 21THoNY932lEiiWBl/h4aIAobfZVqDIJpQnhGkmpMQ0odYlFqgiU+XqTc= X-Received: by 2002:a5d:6941:0:b0:43d:68ad:3b7f with SMTP id ffacd0b85a97d-46021829aefmr8958854f8f.21.1780576899978; Thu, 04 Jun 2026 05:41:39 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:106d:1080:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f35133csm16242686f8f.25.2026.06.04.05.41.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 05:41:39 -0700 (PDT) From: Neil Armstrong Date: Thu, 04 Jun 2026 14:41:36 +0200 Subject: [PATCH 2/2] drm/panel: visionox-vtdr6130: switch to devm panel calls and drop remove Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260604-topic-sm8x50-vtdr6130-dsc-v1-2-09bcd1dff1fb@linaro.org> References: <20260604-topic-sm8x50-vtdr6130-dsc-v1-0-09bcd1dff1fb@linaro.org> In-Reply-To: <20260604-topic-sm8x50-vtdr6130-dsc-v1-0-09bcd1dff1fb@linaro.org> To: Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Neil Armstrong X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1783; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=f5/dVqkaXjhX6dtp61tSmUjJiQd2J/ejrflXA7Mzdjg=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBqIXKB2tNes0WWa4Gf7ZpuO4XQ0jb6kgTgHv2NeRVG RiDKNyyJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCaiFygQAKCRB33NvayMhJ0WcDD/ 9RjlKVcIerDQizX5TaeDFEbTAp35lg7GsqLDEA6HFiFbH482Kadkjc/sTMYvECXYGjpaVhCzj/6NXt mrZuXBL5pxo/V8H0YHojo/V5d1vqCMBVHVypxynZIhxhc5wSTPogue1EYf/xH5gSETRFNcgOMW7gCZ cKuOYz1TZH1+IYJv2RaRQ3KFhZzP+B6POOW8G7RCqiPKt7TeOd064V5PGayiy+2Mkzlfpg/qjV5eJH rQYNrNh7HAQ8Rb9YtDDJPoG030Pi3LnPAY2sVcXPEkSz+N2olZ+XphhIHNcuTPZyzBhFTxyt8vTk9h ox/qnRAgdVLN1XHjgDbGHOJ2J+6w2fvpQtiq3UmsX/f6oKutcz3WIR8E/Scrh7j3IHexNyYENbDTU9 YIjCC1Dumkf0v4C18QZ9fgtkcluKC9TK5H4jxaO/QW0mfpl867N45ADj13sjiuSyj2e8YEE9YY8tZ8 1BiP2eIlE2ybkkr6tbtsIuCRX6G5lySXoVYPkNZauUOZAYZwkLEjc4+PmBdFb8/yIq6xGZXcraf7WR +tzpGG4F7iA+xi54iSSYg5yVacNsO92V5Dojb7J6wR52osA2cUlf1lpm5tpyOheewU2cGo+vBhRuty oLTgP7RPkc4DobjFSb8c+j+t4QTUmdrTCpduS9d9YeQeCbjytkhG7VG84izQ== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE Switch to devm_drm_panel_add() and devm_mipi_dsi_attach() and drop the remove() callback. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 24 +++------------------= --- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/= drm/panel/panel-visionox-vtdr6130.c index 0cdcdbbc766d..6733e0e1d061 100644 --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c @@ -298,28 +298,11 @@ static int visionox_vtdr6130_probe(struct mipi_dsi_de= vice *dsi) return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), "Failed to create backlight\n"); =20 - drm_panel_add(&ctx->panel); - - ret =3D mipi_dsi_attach(dsi); - if (ret < 0) { - dev_err(dev, "Failed to attach to DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); + ret =3D devm_drm_panel_add(dev, &ctx->panel); + if (ret) return ret; - } - - return 0; -} - -static void visionox_vtdr6130_remove(struct mipi_dsi_device *dsi) -{ - struct visionox_vtdr6130 *ctx =3D mipi_dsi_get_drvdata(dsi); - int ret; - - ret =3D mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); =20 - drm_panel_remove(&ctx->panel); + return devm_mipi_dsi_attach(dev, dsi); } =20 static const struct of_device_id visionox_vtdr6130_of_match[] =3D { @@ -330,7 +313,6 @@ MODULE_DEVICE_TABLE(of, visionox_vtdr6130_of_match); =20 static struct mipi_dsi_driver visionox_vtdr6130_driver =3D { .probe =3D visionox_vtdr6130_probe, - .remove =3D visionox_vtdr6130_remove, .driver =3D { .name =3D "panel-visionox-vtdr6130", .of_match_table =3D visionox_vtdr6130_of_match, --=20 2.34.1