From nobody Mon Jun 8 11:01:52 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011026.outbound.protection.outlook.com [52.101.70.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E32EA3D9DDB; Thu, 4 Jun 2026 06:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556062; cv=fail; b=QiO6gYxtRfjW8cmiWyU/579WB7N9eD+VRygGzFVlNVgbQ7Xr16cFvKEMqFdQcoDed5HnHB0+g/TuuFCN2aZPAM2GCzFDxoxe8DogyNlbBc9/DwklytnZwg0ClBWezrRH6clWLcUD5lfeFoAXTBOcvnGxsCZJVyMhqkKAqAIVrN4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556062; c=relaxed/simple; bh=yqj1H3SdQIvr/dLK8fT44xDp68Kgj8X+0xVau765Xd8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=T44nGCk5SLCrPCMJZv2ykdP/jI/Nn25xr4BHlvzLffL5oFvilXWnkZII2/nSKQhBPBndV9T8mBWqPxGv4iPQCi9WrAQrUPoQd0rcLI+Fpl31d/aUrbWXTtP+51QsfD9gYnuKhDCUXIuCiS57Z8PfrJjGgp3G4/uvDbC7tEQ8y0M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ZavVrNxn; arc=fail smtp.client-ip=52.101.70.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ZavVrNxn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r9lYvvHuBMU2ljZfDuDKel1eZ4Sw+b6U3ydxlF2ahbYk3t7T721cVMpvYSamfZv3I5piX0KhqCnE2TKN41XQrI2tH13m5Xh2oHzuzCYj55OddVhmVaVIn0snOguO5gGI24oogMVi5ySx1x2Z7FIUiBvc/iPzOXFOaCCbERkQp4DRiWzJIi2gcMasnwmppzALdhWbfbzBZOg9Yjq0AFY5bcuntpYvAt1Zxh+7nXX8OwTGxl2bEV+a7oT0kMYdWFdjr1NSbqaDWIDG+AdSZqSIzA6tQB17eeB/rJN+6SzuHiSl7m7FOPjDzXlh+FigkX1880Fd/S+8rAsspBtnqoKaPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sulV7gfCho9FigRxDguUEhBjT3FUSJbGBHInV8RUE2Q=; b=gG/PFGlFH9sz6DabYbXP9Wcg4heRLzz1M56k9x3Fqe2PZiEoyiuEDNWTjotayNKsjNZV5fzfDMHVNoT0sQF8xyxJhi+Oy2PsI3sr++vU6MEFFXwZ6MFWEVs0wl7AaX/yc6bNtuwsdGDC1gORo6vvyCdGRisr6LK++zudXA7rtDOr/5Ehf0iwSN1oX03xOU6TQfCYXai3+2ikYMfDZ1AfPlZ5PMl7NPp6JxE3w5AiG7G0YyzCsHzF0RL+hzZIC+c2T1TNdKQGT5Ihvufu2u/Ek0tc/FeRaiDH4m4S6GMYkmKTVDzHui6s4uV1MHghIoEtLtBgxLizMRuKII6mJPEoHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sulV7gfCho9FigRxDguUEhBjT3FUSJbGBHInV8RUE2Q=; b=ZavVrNxnc79t3OLufryUOT7zXSe73J4B3p+fJUeSwXrWz1XusevsJ33h/hAq91oVR9Yf7WniynX6r0TMKy0vYGKplU77kUX7VKy/kpDf2/canAvmNwvRvUQuRtX87lC+9IZisZbtBCJt1B8r0dpoPnd9I51AwaqOlteqw8voKNq9T1U8SB0rQBB1+T0dwOaO6Hh5l2LrtMnkCp4GRpB1bg9UghyE4//jv04+iI+1RA1B9A5eCUNy6742YVvsGDQse98DUz6Mzu0N9Vxgpp0HmWPGwP5Wh7HPoV4oP83STxIItaAE91Ok9gShzaskLTsBzUrqNCaYoObva3DShe7aMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5765.eurprd04.prod.outlook.com (2603:10a6:20b:ae::26) by VI1PR04MB7184.eurprd04.prod.outlook.com (2603:10a6:800:125::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Thu, 4 Jun 2026 06:54:19 +0000 Received: from AM6PR04MB5765.eurprd04.prod.outlook.com ([fe80::bc76:f507:9b83:9d69]) by AM6PR04MB5765.eurprd04.prod.outlook.com ([fe80::bc76:f507:9b83:9d69%5]) with mapi id 15.21.0071.015; Thu, 4 Jun 2026 06:54:19 +0000 From: Joy Zou Date: Thu, 04 Jun 2026 14:56:21 +0800 Subject: [PATCH v2 1/4] Input: snvs_pwrkey - make use of dev_err_probe() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260604-pwrkey-cleanup-v2-1-59fa0ddf0d7c@nxp.com> References: <20260604-pwrkey-cleanup-v2-0-59fa0ddf0d7c@nxp.com> In-Reply-To: <20260604-pwrkey-cleanup-v2-0-59fa0ddf0d7c@nxp.com> To: Dmitry Torokhov , Frank Li , Peng Fan , Jacky Bai , Ye Li Cc: imx@lists.linux.dev, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Joy Zou X-Mailer: b4 0.14.2 X-ClientProxiedBy: MA5PR01CA0155.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1ac::7) To AM6PR04MB5765.eurprd04.prod.outlook.com (2603:10a6:20b:ae::26) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB5765:EE_|VI1PR04MB7184:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c1eacf0-812d-41fa-387b-08dec2061999 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|19092799006|366016|376014|38350700014|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: gFw/SPXu93osI2Adj1ljwBMvFdNkTHYOXHx4fznldHjQFz55rK+df0qCvTnOFLMJ32Q6AzIsn2I7xjFJ59S8Txljz96yiwT/C5UTfWkjxMOfj8qmfFnH+WF/mKCh/hSGxzWAg8+eqCXso2sKbS4S/y049vIoMrANGARCt2rNppzV4M9QSLhCX5beBZ6u3ipuLxxeV7ZL3e9pK1r/6RGdknILGmjZPqkUUTUwQfpAga+paq/yk9k/dn1l9aMBeO37F9Cxhsi1/Wt/FNkZ2133n/qEpyry3LVzpNP8nwK3ErUoDYZjfbfaCKV9Hpbr2wRr47fmvmIMgmmElGXklDzWQLtDjkG2a5teo9syaJAFcqpuQ3y8pZIH2ecP58/hBpFyOUz0Vr4Ymet377Hekt3jV/ioaKrcyyBjifK06EUrKhfR34BtTi+rSjKf4Fu0IupdUP4napIz23CSSmgLEOtXm/NiWjf940n9qu6bt6ccOwpqodR+zQX6PQxvGMiWXZBd4G21QbwHDXDHycZ1I1P9cJzZp6O0kzpv9i4WlsKZY+l29kSsJ42D/AwoJTT7pH+AgmVhEG7WNAjbJ+lnMUACWHSem6f0BlJOh5eDMyc8f2xCnD7qFMwdAuHndHdO73S6Uc0Nwi4UsOyKbp+/IF04l009FDVMl7cD6pAmBIzIz8rd7//sKDNJWddn5/r5y2yRK6y2Yyd/2F9yswY9GCt7i7y/OEIuWvpAzKonvEKn2OxDIsyJXxhnXpQk758kDymq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5765.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(19092799006)(366016)(376014)(38350700014)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RE5KSk9qSWM1S290a0VWTk0vempjQ2UycnhtNWhOUmZkdFBsaFI2WVdsemht?= =?utf-8?B?M3lvQ2grSjY5TmJxQWdCOXF1RmRYeVRpQlFTcVZ4ZmZJdk9aejByVTAvTmNG?= =?utf-8?B?MmhYK3BIUFYrT3BkUE5BVElOWW5rNVhaMGZUYnhKV3l6Y3FPMHF5ZDdabmhE?= =?utf-8?B?V084NWpObUVMNko5OTB3eitZUkdpOUlRaXZwalplSTNPczVSNitNVjVpY1RB?= =?utf-8?B?N1l4TWRiNG0vQlc0aE5iOE1vN2ZvNnBHKysyOGpTcGZxVnBvQi84blh2bkFl?= =?utf-8?B?RVdhd0IzSHo0eG1hV2YvL0VyWXZubzBTbCswdkZLeTRkQmhIYWRqMFlNUGxM?= =?utf-8?B?cjJybjF4YjljMEM5TDViM0w0UUV5RDcyL05aRnE5ODVzN29zRFkxTWNUN2NK?= =?utf-8?B?em00YU0zeXBTdTgrWjB5cnNQcC9zakx1Z2J0ZnZJaC9IbDFZVWdDSk9tNkda?= =?utf-8?B?S0Vua2N2VXpQZ3J3R25vMHFVQjNOM0oxMHlNSzhzVTNDWGZDTGM1L0lvME5Z?= =?utf-8?B?S2ZUTzQxYkZhMllkclgwZ1lhdXVaTStxckExUW1GKytieFpYWWxoMTV4SlJD?= =?utf-8?B?QkVrZzNFRDh2dkxTY2U0UjZReklnY2FYajAyRnFnOVZwS1puTEtVUElGdVp5?= =?utf-8?B?N2ZqWkxXOXJVM1ZhYTNxSTVOcGJ5T0JlcG1lYXBIWklTUndmK3B0SXBmeGN2?= =?utf-8?B?UFl6VS9FeWVMaVNJNHhoQXN2dzRpbWYzOTdQVmFoVVpmaUZPNWhkMS9UK3RL?= =?utf-8?B?NUlBNFVqUVgxVmc4ZFl5MS91c0l5RVFHaDV3Sk5oTktTNGxUWkVWcndFelZI?= =?utf-8?B?ZDEyM2Z6amk2Tk5pYjRIVFlTRGNybnNsOUlQZlJONW53am1zLzhuRHNiQnNN?= =?utf-8?B?OGdlQ3J2cm11YkRxOE5ibDY5QTN0ZjRwb0FaSjhqd1lSVDdxYTZqY2FjQ3Nt?= =?utf-8?B?ZWgzY1dFWGZHRzU2ZGhxR3BENnA0bFNhTnlQekF0OFVPK0FnaFlLVGFhVmFV?= =?utf-8?B?aGh5eXY4M1RPaXF4ZVVLeEsvaTZyYW5DTGJPUkZUTi9rNG0rc3VxbFN0ZWMx?= =?utf-8?B?bC8wWXVmVkVoZmw1V0NqdVRrUkc4dkY1clE4SHE5U1U4T1lnNW9MZjdiTHZS?= =?utf-8?B?Y0pKVWVWVm5yV1R4dUFIV09qTlF4RHE3UXdxOVdRcUo4dC9IQ2ZzYmlpTE5q?= =?utf-8?B?SWNMajNDbkcyZTQ5Y2JrWlJKMlFRRUxycy9SRVRHUEFRS1Mzc3pYSU1IWkZy?= =?utf-8?B?T1RiNWFVRDRiZ2FKdW1zKzg2cldFSmlucCtEYnhPUkMvdW1jKzF6REhZNlNU?= =?utf-8?B?MUgwRWVLampFZ2tNZVdjc3BWWTFQS3ZWZmtpNE9IRkRYNHNYMVFlUW9oY0lX?= =?utf-8?B?eTYveTd4SG51OUxCT21JcmtjNjZQdU03K080ZXpTOU04VllpR3BIL3RObjNF?= =?utf-8?B?K0hkdkYvTXRhZ09LNWY4M0FoblAyN1lKMFI4cEFvRWd5eks3aEwzNnVpWklO?= =?utf-8?B?R09NVGhJYUFQekh3Z2pob1BhdHV6SVM0RS9zNGQ1ZzZySEt4V1o3M2NDL1pw?= =?utf-8?B?TTdIMkgzTVNaSktLMGp0dmNKQ1JGQ0I0a093UHg0aEk3cXNDaDgrVWFUSWU1?= =?utf-8?B?b1J1SURsUW4vMUphUzdmczNVU2YrcjcrQnlOVFR3QUIvUnB0OXJzcHhoNDBN?= =?utf-8?B?dXZZa2ZHcUJzbHZTcjRPNGI0M0pXTDJLZWFSYlpScjJnQjZTY0Q2L1BUbkFT?= =?utf-8?B?Sm54NmNudlJQK1ZCV3d1Tnc5ZEdXZTZXdFdvMDhmVlgxaU5vUWdPQWpWeUVB?= =?utf-8?B?K3VucndZRy9kWlJnYTNHSkRmamNOZDdGcEt5TlFzT1M5d0RJOFBLQmdhQ2FU?= =?utf-8?B?UXNpVG1TVGdhUHNvLzg4UURod3hZWDFvVlpTbTZPZXNVbC83d2p1eFRpSDFi?= =?utf-8?B?QSthQkw1Y0k2ZytKTDdUUnI5SFZuM2RMMHlnci8wc0VNRFZiQ2pBOGkvVmxT?= =?utf-8?B?ZlpqVWpTTis0TmZzdjUrdG0xb2dIUHdOY0xJYlhkbHhDZGdMN3BKTHVsQUow?= =?utf-8?B?MHlNRWx6OEx0S0crWUZLWW0zNzFhZjFPMUViS1VCMVlZUTc1NkhRYWM1amN5?= =?utf-8?B?UjhhZnNOdVAzb1FHblY1cjk3TEUyNzVHNEUvTk1EK1NLczBFcktqRHdUWW5i?= =?utf-8?B?ZlVFVlhNd2lpcHdiZllHSStYSFZNUGxaYzNiYldKU1FXam1GZEI4aWhkOXZZ?= =?utf-8?B?Mkdvelhwa2JMQkxWbkUxOEJMY3RPTjNYTXhqOWtpUjJJTC92bWpDQmtaNW52?= =?utf-8?Q?ie++DINmvLeIuM+Cas?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c1eacf0-812d-41fa-387b-08dec2061999 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5765.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2026 06:54:18.9580 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bx9PI3yTpnGD8BPukv7SBYp9O8xN87oRuiw1MztDr3+KraOdUrjbX/2nwleFVFkZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7184 Add dev_err_probe() at return path of probe() to support users to identify issues easier. Reviewed-by: Frank Li Signed-off-by: Joy Zou --- Changes in v2: 1. Drop dev_err_probe() change for platform_get_irq() per AI review comment= s. 2. Add Reviewed-by tag. --- drivers/input/keyboard/snvs_pwrkey.c | 38 +++++++++++++-------------------= ---- 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/= snvs_pwrkey.c index 954055aaf6e29527f22f8129fd47ca17722e2bc9..748196fcce75ba7192b1ee5fc51= 6bdf4a9ae074d 100644 --- a/drivers/input/keyboard/snvs_pwrkey.c +++ b/drivers/input/keyboard/snvs_pwrkey.c @@ -124,17 +124,15 @@ static int imx_snvs_pwrkey_probe(struct platform_devi= ce *pdev) /* Get SNVS register Page */ np =3D pdev->dev.of_node; if (!np) - return -ENODEV; + return dev_err_probe(&pdev->dev, -ENODEV, "Device tree node not found\n"= ); =20 pdata =3D devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM; =20 pdata->snvs =3D syscon_regmap_lookup_by_phandle(np, "regmap"); - if (IS_ERR(pdata->snvs)) { - dev_err(&pdev->dev, "Can't get snvs syscon\n"); - return PTR_ERR(pdata->snvs); - } + if (IS_ERR(pdata->snvs)) + return dev_err_probe(&pdev->dev, PTR_ERR(pdata->snvs), "Can't get snvs s= yscon\n"); =20 if (of_property_read_u32(np, "linux,keycode", &pdata->keycode)) { pdata->keycode =3D KEY_POWER; @@ -142,10 +140,9 @@ static int imx_snvs_pwrkey_probe(struct platform_devic= e *pdev) } =20 clk =3D devm_clk_get_optional_enabled(&pdev->dev, NULL); - if (IS_ERR(clk)) { - dev_err(&pdev->dev, "Failed to get snvs clock (%pe)\n", clk); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), + "Failed to get snvs clock (%pe)\n", clk); =20 pdata->wakeup =3D of_property_read_bool(np, "wakeup-source"); =20 @@ -165,9 +162,8 @@ static int imx_snvs_pwrkey_probe(struct platform_device= *pdev) bpt =3D (val / 5) - 1; break; default: - dev_err(&pdev->dev, - "power-off-time-sec %d out of range\n", val); - return -EINVAL; + return dev_err_probe(&pdev->dev, -EINVAL, + "power-off-time-sec %d out of range\n", val); } =20 regmap_update_bits(pdata->snvs, SNVS_LPCR_REG, SNVS_LPCR_BPT_MASK, @@ -198,10 +194,8 @@ static int imx_snvs_pwrkey_probe(struct platform_devic= e *pdev) =20 /* input customer action to cancel release timer */ error =3D devm_add_action(&pdev->dev, imx_snvs_pwrkey_act, pdata); - if (error) { - dev_err(&pdev->dev, "failed to register remove action\n"); - return error; - } + if (error) + return dev_err_probe(&pdev->dev, error, "failed to register remove actio= n\n"); =20 pdata->input =3D input; platform_set_drvdata(pdev, pdata); @@ -209,16 +203,12 @@ static int imx_snvs_pwrkey_probe(struct platform_devi= ce *pdev) error =3D devm_request_irq(&pdev->dev, pdata->irq, imx_snvs_pwrkey_interrupt, 0, pdev->name, pdev); - if (error) { - dev_err(&pdev->dev, "interrupt not available.\n"); - return error; - } + if (error) + return dev_err_probe(&pdev->dev, error, "interrupt not available.\n"); =20 error =3D input_register_device(input); - if (error < 0) { - dev_err(&pdev->dev, "failed to register input device\n"); - return error; - } + if (error < 0) + return dev_err_probe(&pdev->dev, error, "failed to register input device= \n"); =20 device_init_wakeup(&pdev->dev, pdata->wakeup); error =3D dev_pm_set_wake_irq(&pdev->dev, pdata->irq); --=20 2.50.1 From nobody Mon Jun 8 11:01:52 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013069.outbound.protection.outlook.com [40.107.159.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 345133D9699; Thu, 4 Jun 2026 06:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556066; cv=fail; b=pWDVkF5CgkvdxIZhwhQDazaiAzmATGbKRarxKmxFGBjVex/ot9jVTtCsdVoWMFIDq+MjyTMEHcTdfHwfMF5m82yRITr/njF6LHgNN5UdRty1JffDmMGm9SiAY1o4/T8Ua68i4nG+KoF+GbsDUZq4uXcio7+4YcI4CgrCR9oSL6Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556066; c=relaxed/simple; bh=5jTKXkTxtDaDi6KrBHMi5CaFJjzYAKVZkqmMoUQghq8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jqKjrgBUL+VDstRwCYzkdKe7YQaaUupVQ6SHIt/G+FMvfYkHpcZWWwGmQXOwyoUgnv4S5RVQKQFgnsd/6XIEP4pe0qAv17cyW1rW5DlhLyKaK6eLlfYOsLtMZ/52Z5TdJfDcaB7I6hvx/9FvO2Sxfu+yOTov0rcXEaSJVK/SoNM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=guu5ulxb; arc=fail smtp.client-ip=40.107.159.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="guu5ulxb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kKhEP+/INrQD5hiXpgjup3zTdlzxq5EsEAPQ5xjVlHrf6axPb4GGgWR4otc44QQNY0xmJgIt3aSf0SQoZ69IWE9yIk6zM3gXkOas3WZK8SQ9O9kNEzoQ1AyvQOzZdC1NMbYxuIDN5U0STldARsm1FqqNaGKjYM80gVB+gTWwtx+n25Iy90P0zQPv6oQa1W0Cw/HBJ1lpJb3J9mtUuVG3D7R1Yd77jAD8YOYI3AwiRm6unhTg+HIadFtld/ESPjFZm+TI3YMVyiPIYsaVBtahWMv0oVBm/3jh5LLaLwlxiYRmTrCItJ1v8Do+T2GhUGGIGhNWSSqSrJKlJsKPd7KeSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hg/hUARSYv4NtW1DwZ5b2ydFGWn1pA9qg1v7CkwH07g=; b=HV3qa6VLpaL/DRjXluOC04sri+MjVP3YlsVbbfn5As6jt77cBSauJsXIER7KaIGOB12E/KiB832QNLHuPm73B88U+rSaLQ/SIzUU/A/0NXazG3AlQC8n2B9DxE7S5zV9bKFLWt84U0nwTiU4G+LL8Jw+5WPrNlphVfRAQAPivjuLPcPjkj55rCMU2RfZtTGDxUQh8dl8wbL7n6Gwdj6Zyv04r5poIJpSdfX/js6Xjq1nTe6tZXIMcB1iJRAUWFWqfL2p0Sj7vzs1WyPMsSNjpd7Gfrr6qSgFqOp3xihf2xeUugwM6CD9SdorTXAMEDx7ADq5YHwBFIcWdvicGS+2MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hg/hUARSYv4NtW1DwZ5b2ydFGWn1pA9qg1v7CkwH07g=; b=guu5ulxbGgz2OAzH5dchPGS1BMchX1wUvcaktD26SaG9jChZmuQbwt0md7Xf84Z8Uu+HSXvKCFL3GWjNzYp0YZNk+bN0fLgTVcZesbFzJFOCZ3yC4msVXub63cAXih8GsR9nSLiFRO9dnB6PDJCjdSbIcToug/zf9BedTQHnYZ2k/Ozoz17xrOrxj3MfXHgZiiWxM4phtkje8nEAXaargcZWjaE/9XMJPOuadyHyzskZOfyTzrti3Qbfw/ClQRldiNM/lqnyQJFsi/58CWMV+ZKr+WPwWxPiqQZz234/2xwvXCSOvnJZrNYDhdAHippvjn2qF7VJI/Ji8rnsx+GkMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5765.eurprd04.prod.outlook.com (2603:10a6:20b:ae::26) by VI1PR04MB7184.eurprd04.prod.outlook.com (2603:10a6:800:125::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Thu, 4 Jun 2026 06:54:22 +0000 Received: from AM6PR04MB5765.eurprd04.prod.outlook.com ([fe80::bc76:f507:9b83:9d69]) by AM6PR04MB5765.eurprd04.prod.outlook.com ([fe80::bc76:f507:9b83:9d69%5]) with mapi id 15.21.0071.015; Thu, 4 Jun 2026 06:54:22 +0000 From: Joy Zou Date: Thu, 04 Jun 2026 14:56:22 +0800 Subject: [PATCH v2 2/4] Input: snvs_pwrkey - replace hardcoding -EINVAL with original error code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260604-pwrkey-cleanup-v2-2-59fa0ddf0d7c@nxp.com> References: <20260604-pwrkey-cleanup-v2-0-59fa0ddf0d7c@nxp.com> In-Reply-To: <20260604-pwrkey-cleanup-v2-0-59fa0ddf0d7c@nxp.com> To: Dmitry Torokhov , Frank Li , Peng Fan , Jacky Bai , Ye Li Cc: imx@lists.linux.dev, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Joy Zou X-Mailer: b4 0.14.2 X-ClientProxiedBy: MA5PR01CA0155.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1ac::7) To AM6PR04MB5765.eurprd04.prod.outlook.com (2603:10a6:20b:ae::26) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB5765:EE_|VI1PR04MB7184:EE_ X-MS-Office365-Filtering-Correlation-Id: ade2d0d4-5a49-4f0b-2c1b-08dec2061bba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|19092799006|366016|376014|38350700014|11063799006|6133799003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: /knIitC4OAHMlwFCbKXLlV+3qpBO98muQXX89fwxmdffEHkeO9kR8e7dwhZnWOJdKV29QIJudhRN43Afqe2Hyjox7hdTmyaF60cnsnryQd2zNG9yEXMbBnnR1iVhB2GkZs09ceI6Puo/mqBBqVxhEB9PQ5jlAy+5Rzg2BvPtKHu00R9iC5kDObxaqg6iuIG1XFXSGfUcryFEV1DVGzX2XxTmdto8cC2X3gTpVvtztcUPrz2CIZ7+tRKfRGeTDJae4rKcvVQq8swSYcpGZyqn3iu8FtA6/M7pJmoZFYH+Q79nuSXmnDFEYU5lCgIFB4ruSvn8k31gombjHVY7JQffwcbzWjYPooCPuOuQPkfBYL1W+WVmXm8LiK/s/dMDQZJttJBdpxwAjxWrXslR6e04CXk8g7XiM087TeuIhwMYpif6O4gi88mTUb/JRvOXpBCLi42lpbjhEEu3bJ7nwB/ojC+SeLpB4/EwSaX8IzN7gbJEpTYeQFyTmqSEQQmySCKy8eOMl9w5hJ4y/zL+WkLCuf3nb3j1fXP1KZUqkP5bGaJY3b/xm4kOP7OJqRWal8ao04N+bY989YB5UwjKGjSkklAgxuwxtWuqA8yWZfMlRWAGNdsffcxwf7MR2ZTCuAuGriMBkkiCpF4bwUWG/3OwlE78ZT/ve44VuPIj+sO3JVFTgQ1A86v9rLr82gP2nDH+pkr+VKi6iuU6bsv7bykyyhYaoMN0cVHRFvx8LmR5Ep3B/iSexcATUO/7GiqNbKh1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5765.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(19092799006)(366016)(376014)(38350700014)(11063799006)(6133799003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXRzUmNUQlVjQ2dTWER4Y2J4OCtHNzMrTitMUEZMZHRpYlRJRzZESXptYnRL?= =?utf-8?B?djJnRFc4eUkvVmUzZ0xWdStlWm1OSEJZUXRDTUlHUjVXVElhS1hKdEY0a2ps?= =?utf-8?B?eUJxNW04dEN0aWhMa3JON3h0MzNWRWtSWDBVaXZjeDNMelFVU3pEUmdCa0hq?= =?utf-8?B?Nk1CZWordlRLL2N6NkU3RFd1K1llZVordytQM0lNeDY2bWNXa3k4SEYxOHR4?= =?utf-8?B?OHJxT2JyT2tmS3psdmZxYVRya3hVSTZ0enZ4VHN1WWZZR3R2WDJFZ014S1po?= =?utf-8?B?YjJ4WHczRktzMlhINjBENTNjYlFZeWoyeDU2emVnREdVQjVzcFVaaklUUndw?= =?utf-8?B?ekRjeWVFVzNoWFZtMjlCajdkWlEzSUVFaXY1NnE3SlFGZUtDR0tSQjVxL3dB?= =?utf-8?B?SS9waUhTTlh6ZHhLaWh2aENMWEMrcHo2RS9ZRGZpdVBEaWcxdnBzVExxVVJU?= =?utf-8?B?VzRDa0YzTUZsRzZqaUpzMXlzWUFhbTlsaHZNUzF3dkpaTzd3SS8xd2twK0N5?= =?utf-8?B?dGNHT1N4OHFDWkxyQmV2ZXFORWtiZ202WVpOR1hLQjRDSllIMDBpQTNUbXEz?= =?utf-8?B?TncxVHFJZDVyajY1VEdlVTgzaXVQTStzN1hYcjhVZjFTQ0V0bEpqUWdaakJq?= =?utf-8?B?cFBOWGc1bWFxYUxxQlFlZGs0KzdraE1pYWlGdWVHbVZ3OEtCZXZiUTQyVFlx?= =?utf-8?B?SDZJZ25lTU1KaE9BMkc4c0dVQnk0MVFKUUpOQzY2aWZUQ3ZObVNQOXk0Vk5Q?= =?utf-8?B?RlowVUk2K25PVmxDT3V4SGx6Q3pYZ3lncTVseVhQMmZ6T2FaelJrMHVibFRk?= =?utf-8?B?UmNLNUVzMk4zQnZxRkJUcExHUTdMOE1lSFlpc3ZZY2xDcTkyQ0hQVkl1NTJK?= =?utf-8?B?cTErVzdwY2JUZHFEcUNQVStRcnFmRTJuRFhSMWZiMXFRdldXNitOaEZwSjVG?= =?utf-8?B?eENhL1AxeXU3RFQvMEVVdm81a0lZYlVmRUc4SEZrRk9TUndGSnFYQ252bVdr?= =?utf-8?B?dTNKVEtocVNYUEo2K1MvbFdWaXluNnFwQzhOeTVDOGVENExPbHhRKzBRdFd6?= =?utf-8?B?VnBoNDRvaGFMMm1EbWFPdkFUUXlrL3N6Lyt6aVowamllM05NNEg1OUZuUk0w?= =?utf-8?B?dUcvbTd5K0hDV1lrUEsyQjZBMTQwczQza3dzQ0lKRzQ3TTVuMUZkWnVrSXBs?= =?utf-8?B?YVVpZ015S1pmeGxYNHViZFZEUG9ycjFiUkFib1ZaV1A2OUQrR084QUpoc2I4?= =?utf-8?B?ZXdFVndRN2MwVkRiR1liWEU2YzB3K1Z1VTBMSGNyK0NBQVE1NGsyaDRLMDVU?= =?utf-8?B?UlpDUU1PckxGajNrcHlHTytuTUFDaWNiaW5NTjdWN0d4bEhlM0Y3L0FVRnAy?= =?utf-8?B?WWFuSkhKNk9KQlhHaTFkSzFMVmR0RWhoUW9lR2RPWm9NYlJyL0VTaHJINE9G?= =?utf-8?B?bDlad25YZHhGVGxha3VhdGU2L1BFSmZvejBSSm5BaXNhdFlKcnBhSXNOUVA4?= =?utf-8?B?em9aZWxSSldkK2s4YnhZODFTVkJ2eEdnU2FxMkVjbGxsSExMQUhRNU1ZVW5U?= =?utf-8?B?U1VCWmllSjVqRU5JQXdkbnRWSGlpVE5ZbldlcTZSclR1NGtJbTdNd1ZrQmo3?= =?utf-8?B?emhXWkp1NlNsSWZMcTJTNXU1YVZjaFM1Qi9UVFdVTWlpTGhEYkVNbUYxL0lG?= =?utf-8?B?WlBVd01hRXlKVXhycEVPbUNPdGhyUVl4NjFIYmhlZ2ZFbGN1K0l5WVJSbzE2?= =?utf-8?B?eUxRWk9veTlEMXk4aklvcnVBL1ZJZjZ4SFFSUFdZMkdId29Xa3E4NDRsYmoy?= =?utf-8?B?ckJMdEJVNWN3MXIyU2dVaXo2L0FNUnBkYWNXcjFZaTVpL2ZEeWFJdGdheVhv?= =?utf-8?B?bll2eTZoYk9zY0dsbXZCcC9Ya25rdHRSY3QwNXdpaWJ2R0p5aXc2UjVHbTlI?= =?utf-8?B?WFNYME5tZ0pVTmh3MWxwYTNBMmcxWEwxTFZkdnovSWd1NE5qdElncWdYelQ1?= =?utf-8?B?bmh5VHR6L2E0R1EzbE52cEpuVDh6UVhTN1Mza1ZlN3ZsRzFQaGkvc3Y2S2l5?= =?utf-8?B?dHBYaFN1V0RwR0RNL3JJTElXREdVd0ZSOGtRWUFZSjJEQkdLT3owV2ozWVBP?= =?utf-8?B?clBSQVUvdG1EMFVSNUYvQmhkS2pCWGJmTk9MZnMrTll6S2l1dnA1QlhmWG5W?= =?utf-8?B?d3Z2Slp4UHRXRDF1eGFabjhtR2hmUW9JWkhaSkRqNHBmKzFFZ3Bsa1owZ2o1?= =?utf-8?B?SnJaU09hMGJacVp0alUwSm9VOHNBTGtDUVlSZzRlOXZvTHF5UG5iYUdTZHA4?= =?utf-8?Q?EtlqI8yCCmfHVcdJ0b?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ade2d0d4-5a49-4f0b-2c1b-08dec2061bba X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5765.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2026 06:54:22.5340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cfAi1LiEA/zCYFMLhA1I++nIQrOneADh+iI9KFq57P/y0e8ieWQt2xX9r/e7+UrK X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7184 Hardcoding -EINVAL discards the actual error code, which breaks probe deferral (-EPROBE_DEFER) and loses critical diagnostic information needed for proper kernel error handling. Signed-off-by: Joy Zou --- drivers/input/keyboard/snvs_pwrkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/= snvs_pwrkey.c index 748196fcce75ba7192b1ee5fc516bdf4a9ae074d..a291812e6d22ea963568cced5b8= 89bad00658526 100644 --- a/drivers/input/keyboard/snvs_pwrkey.c +++ b/drivers/input/keyboard/snvs_pwrkey.c @@ -148,7 +148,7 @@ static int imx_snvs_pwrkey_probe(struct platform_device= *pdev) =20 pdata->irq =3D platform_get_irq(pdev, 0); if (pdata->irq < 0) - return -EINVAL; + return pdata->irq; =20 error =3D of_property_read_u32(np, "power-off-time-sec", &val); if (!error) { --=20 2.50.1 From nobody Mon Jun 8 11:01:52 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013016.outbound.protection.outlook.com [40.107.159.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DECED3DB33E; Thu, 4 Jun 2026 06:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556070; cv=fail; b=klofLhWmmkpS56a24/W9i97+1Nde/6rfe0S3WJQsAgeyU5Q2Uslph2jges6RcRyxsSJZtWDiIxrsJGXORhJNdrsyNeO/sz9WrwDHKHM/jTzQ5Xfu/V8HGHzYH4d2JbXKRg2wSkXxDGJUj/OGNiVY6iyZoFUDQX3aGwSjvv7Mkig= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556070; c=relaxed/simple; bh=fhiweUTxO6lrOUpqZhuAjL2AVYKfhFB+OBPIKrbH0cM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kry3kPgzmZduWllY6pV4V6fchRQgZc8Yf+5I5XSrucedkxFPcWQQMFda+0+LQZC9nMGEwwRMQ1B/1jJsM+WgJCijqy78aSkX/LTa+ofNK9DKjVlIs451En4NW75coB14pjzjOwqPCjOjOG7Zym1eNWcYceJrK1sBnXfds39WrdQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=IL8X7D91; arc=fail smtp.client-ip=40.107.159.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="IL8X7D91" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Zh2S6FHeUMslGWhu4UzHMR9fgZS50aZiVOs4Ud4znn/8JWLjBTVqZEQ7aZs225Chl247+mfbMlsMySte7HrJGLSRIMLL7zkUXZSnfOG2Q5PJHb5z169+LHyIrqXlCyniSnXVnrPzKTGEufOZ1RcDjt6r+dQ+vZPEmrZhwcBiAUFhOVITyHN3PJJxcF9nQ2lxjdKdjCKwo/ZfkbE0NTM4GNQc51LrLbCriQ6wr+D1vAt3shrZ6f8GIzZGgkUfCF2ldCQGa7Mlz9aSUROyezffFe3crlqzS6tqtblFn+R0DYLGmecM+bXrVJOnVZZfgE3wkAebCAHuDLAjnR+e/7H88g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mszyY4evDkGmzVIOQpv2Hbq8VRZvE74Ne6kBmEbUDZc=; b=jUL6Rf9RaaNndXhYrWH768CBEdXPvGdDnyFOlNHDvMQWxjJKVMZMy3KAQjKrY5vADMf3IFuBkTlw7evkmJNFw+JHKNkSEhnCt6rd4i9cISPEKAl0YPoRLtMkG4mXMfCovksZwOmff3zNp2rxRY59B6NyGvh4qZIAi5apQuureMQjNpiYXaf9VYTbW4vak1+vblMQczna94kck3OKcHgL7zvOJvWLpNFpHBi25G3bGpsDd3P4+s3g1ehX3hHxGoeBBHGyeNFoycMmT8cjYYL6Zz19xfWTbNeItSV2o2DEeJZ2VtvDMnoFATFk74cX2QZCo4kwo1wi/Z4ue+m+kGQ4ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mszyY4evDkGmzVIOQpv2Hbq8VRZvE74Ne6kBmEbUDZc=; b=IL8X7D91Qf1jcXONQ/XVTk6patq0ZQo0DmMXKZQpaSRT/yJHgZv3ODo4B76RJdK37zsBWk1d/F7Aq5kzONoP/8Nvm8Tat7zJwZoAd6rYu6EP+xGYUCC4bZmiK0SG821k911jjM8qbXGYfOIM/9dh6cQQmB1cxEvP+yye3sZKc4Aqd/8I4szK391v6KWfLaQn8vUoLO91Gd2hlSr3PfGExXnorKXO0BW/7HTrOAa9QJtXLdgkzTmyyzgK3IQNL0buxyflKD5Q0LRG6VHpSsDnh5tflFgZWvVe+E2eJVKtLF+uLwXDJvc9aTtqo2Q2FicHWvyFWcbtWC46AcTozY8vuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5765.eurprd04.prod.outlook.com (2603:10a6:20b:ae::26) by VI1PR04MB7184.eurprd04.prod.outlook.com (2603:10a6:800:125::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Thu, 4 Jun 2026 06:54:26 +0000 Received: from AM6PR04MB5765.eurprd04.prod.outlook.com ([fe80::bc76:f507:9b83:9d69]) by AM6PR04MB5765.eurprd04.prod.outlook.com ([fe80::bc76:f507:9b83:9d69%5]) with mapi id 15.21.0071.015; Thu, 4 Jun 2026 06:54:26 +0000 From: Joy Zou Date: Thu, 04 Jun 2026 14:56:23 +0800 Subject: [PATCH v2 3/4] Input: snvs_pwrkey - use local device pointer to simple code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260604-pwrkey-cleanup-v2-3-59fa0ddf0d7c@nxp.com> References: <20260604-pwrkey-cleanup-v2-0-59fa0ddf0d7c@nxp.com> In-Reply-To: <20260604-pwrkey-cleanup-v2-0-59fa0ddf0d7c@nxp.com> To: Dmitry Torokhov , Frank Li , Peng Fan , Jacky Bai , Ye Li Cc: imx@lists.linux.dev, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Joy Zou X-Mailer: b4 0.14.2 X-ClientProxiedBy: MA5PR01CA0155.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1ac::7) To AM6PR04MB5765.eurprd04.prod.outlook.com (2603:10a6:20b:ae::26) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB5765:EE_|VI1PR04MB7184:EE_ X-MS-Office365-Filtering-Correlation-Id: 678b3764-be11-494f-64d7-08dec2061ddf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|19092799006|366016|376014|38350700014|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: RN0ZPVaj9ApOL4hLRBfuAC8fpr5NysJsXgf97I2M4RE2c0tdWzL/UMeja8/6+pm2so+gH2Xpztoxo9z1YGe31yhzepFMQACF4eenCwBYrUaVBO9L5HzueW3AC223OUCGC1EQkaE3lBcWVvM4lUJb5pZ5cSa4gatd3j21W7DYpObyx+mdBHIWuFNaJ6SV0TosEcdKfIKnw0EITJ9KEEIoQuz+hLp5ALZ450AGfN5dKvQDRLAbDXeSSNW0J51n8rho6/PCs7IGGEchi9Fv/u3K95A5wbPlgVHDI5Dmy+Om2YWcyLo0xz0YegZa84vC+Ys1VcIcEDXzkfkWciafoCoEHhkWCZIyRWGjzOkO8iu2Do/7GJR2FKE0EbTkEY2LYnA0coT+dctWOYuI2/Hm8lFj60/jOoIsrt0rvfcJ2c5BVi0RR3Lld+pqErXZYO9o/oPynsUF6FuEldD4FT1PIU9OAES+Tv+rqmN0U4HyHHXRBfXzdXWGASxXNfTI4WlYl3kuM7AS4NsMFTZKo76wOMydH2Ziot3caN+cb7RbfQD9X51b4O+fTiQVH8puI8HgFpD9cW9rXYqoNxQSr/vWvybFIEY3PD1/Fb1u8fCbXZnXycNvyQSTM04ZHRoC8XvhMoS4/VSVHRxJrtxiMLRVIXPHB8JA+Y65RagM+k1KJuIU+1fNrr1N2LpvpgK6/XMYzn8IrB76Et3fQ9w3DloUZRKXmD+X9AwuPKcyo57C7hKKYn9pfOZ4JzKOT5OHYaCLmPve X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5765.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(19092799006)(366016)(376014)(38350700014)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlJXU0hDcmRYSUltZ2JwU0NRaVNjcGVFNHBqZHMzTlR5NXRyOVJRVGZtN3cw?= =?utf-8?B?S0FDQmdTemJsZ1gzOFBLUHdUS1F5VUlCKytKVFhxMG82T1Y2RXpPZzJoTFhW?= =?utf-8?B?NXhra2l0MFJ0cVZQeFdjSGczMzlFYkpZWWNHZTY2bC9DRElhZC9BRHNZVjBn?= =?utf-8?B?VjBkVXRpU1JOaVcwQk5xWjV1TWNReklXVGhLRmFlVWxXeDRaT1FJUkYxa2Q3?= =?utf-8?B?ZFZIcGFmeEVKVVZEdHpiZnBhSzZNQXRQcjE4aVE0cDRxY3dSVmk3MWEvUWRl?= =?utf-8?B?UWVRR0pzUUI5YkxBdDh6UEJXa1pLWXE2dG84TEFEbnZWVUFsOTl3ZktJSVBp?= =?utf-8?B?dkFKWWREZGNyY3czaGE5Uy9OUDZSeHF6SmhyUkJKUVhDV1ZwcmxydjF2VmRu?= =?utf-8?B?c1dxMUFqaXRTVnpaMDk0T3lTdzNScjhCUFQrYmtDdjhzeFZLTW1UK1Iwelh4?= =?utf-8?B?cGVhNXpmZ1gwRkpGTU1WdEM5M1VGL0xpdTV0K2U1cHlXcTd1STZWMkVDYWhD?= =?utf-8?B?bndQYy9aaUtWRHZOSVgwZXJGYmhnYXJTaXdySEY2VFRFZEpTNDRtMnU1RzRF?= =?utf-8?B?VFdIK0E1NmtXQ1pncGJMTXZ6a204VjJXZStmNVBobDlQakpDOHRBNmNFbjBl?= =?utf-8?B?TDRmRnRtS0pibEY5VUpsYkovS0l4RVNqdHdsbXpTeS9KZkFmU0d0ZUlVYXo1?= =?utf-8?B?U0dYQysxVCt0amdvOUNPcllYM1M4Tm1nSnlyRkcxS0FJbDdnZ0ZBKzJkVjZD?= =?utf-8?B?NXFFTm1ZZkxyZVJZaWRpa0VJOHl0SkxTamlIaWdGc1BMUFJyUnpKMXlic2lm?= =?utf-8?B?UzhlN3dyWmttY1lrUEtuMG5PR2ttNDc4ZUhRQ3h5NXpMUEE2aTBXQTBkcHho?= =?utf-8?B?c1JkM3NmblV2dlZ6UzZKZ1RFNTZtNEg1UThOZVhMdkE0a1g2ejdIUU5PS09k?= =?utf-8?B?eFZDM0ZpK2RNakhIcUt2N3FmNlE0b2tzcXFOQ1lUbEI3OWFONFd0Ny8yVlZD?= =?utf-8?B?emhmRSt1MldNblIxa0ZyRE85MEhVT3dOZmQrR3IxdUt3cERkYTFIcitKVmdy?= =?utf-8?B?anZmczJLdGFDQjlLUDdqbENUWWJjbEV6czExYWZwU3dZVGhSTjBtMnIwQkNy?= =?utf-8?B?czA0SDVVaXRadmZsNUxiNlFNcGtSQzJibmJML2pmdGRqdUFNbncyTWVnRU1s?= =?utf-8?B?end4R0xwbjFqSCtyQWxkVW95cVVTYzRXK0dOTDJWN3I1dHVvdDUvTFVVRTlu?= =?utf-8?B?VjhlRTU4cVZYL3hUQjg2RHU5L3Fpc1M1cnorK1ZEeWdreGFDeXNOeW9NQVJ3?= =?utf-8?B?aFZwQ2IwcVN2SVNqeUx2YzlUVVppS1ZwUmlINGFzVWZmY0IwRzVtTVJzVEVH?= =?utf-8?B?eDJiNDVxNUJGcDJvSkltVUdmZDVscUpsWTcvOGwvYjZId01XVUhROU1wdWI1?= =?utf-8?B?WVFra0RSUGh4ejZnS1pkY1JRa3E4cFZGL0VmQ2F4UWlQVTBqZDlZWG9jSmlk?= =?utf-8?B?WTdwMkFJTmswZUNGYlJwdHpKVVhjdVhmUXQ0ajFqKy9nN2VwU3drYkJLdDkz?= =?utf-8?B?RUF6eHFDRlZscGtGTDZ5eStwc3JqYTJLc2VrMXl0SkdoZ3c2bXFzeGVuYzJh?= =?utf-8?B?TWtLaE9hQVpuV3ZaOTJ4Ly9Xb2JyQmR6TFUvVGJOcGpMcHFLb25HOEpjQ1pn?= =?utf-8?B?TVU1QmJrSklXQnFsNU94SktvdWpCUzdqeFVXUXZPWDRZWkZuNWc2SzlSRU5M?= =?utf-8?B?SFhzUWRRUU9HL0pEM1IzeCt4dWNKcjVEcEk2aG5MeEJ2WDlsYWExNHh0dzJW?= =?utf-8?B?eGk4djByRmNqN3NCZjhCSklnYzF2SW1OUG13QzJaZ0lzSnhGbnVEeGJONnZs?= =?utf-8?B?VDArbzBER2tyamZDWHdUNXA5RWh3OWxLY3hoT01Md0JHcllYUnNPMURSdnpv?= =?utf-8?B?ZHB2K3R4SXlvRmpkdjNvcWtGQmxYTG05aXltN0Exa295N3k3Sm1mRjBkN0Rn?= =?utf-8?B?Y0VleENzYXVQZ3RJeFNIUjJRbW1TT2VjZ2RhUWkzZ1grRVZIZHlibkZnNmJP?= =?utf-8?B?cUMxMGtIVmNmcnJwZXVnaUV3NTMramxrL0w3QTFmb0h4MFBvaVB1cURsUTJY?= =?utf-8?B?ZjQzOU9idCs5SUFnMEZOVnhaQi9wQUZYNFVXRlpHR2RnMFZIcmNUY3hoM3hk?= =?utf-8?B?SHJoUzg3RFozUUJ5VDJHMi80cW42a2dLWDRvblI0ODF0SGRwUUJ4bm4yNVdF?= =?utf-8?B?YWVweUlmU3c4OXdhMCtjTkVCRkdvTVBhQVVRcHVHVThkM3M3TExJUTRaSjhW?= =?utf-8?Q?LBtK/wu0hc+rNCxgoB?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 678b3764-be11-494f-64d7-08dec2061ddf X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5765.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2026 06:54:26.1216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2fjaec2c2ECjFuGW9LGbBj4wpyhmeMh2iBojabNhgVhraCt+zIkM+1IO/LxPtokS X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7184 Use local struct device pointer to avoid reference the platform_device pointer every time. No functional change. Signed-off-by: Joy Zou --- Changes for v2: 1. Use dev instead of &pdev->dev for devm_input_allocate_device(), which was missed in patch v1 per AI review comments. 2. Modify commit message. --- drivers/input/keyboard/snvs_pwrkey.c | 41 ++++++++++++++++++--------------= ---- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/= snvs_pwrkey.c index a291812e6d22ea963568cced5b889bad00658526..4a1d04898482669894e9978014b= 62e4e9774b4e4 100644 --- a/drivers/input/keyboard/snvs_pwrkey.c +++ b/drivers/input/keyboard/snvs_pwrkey.c @@ -112,6 +112,7 @@ static void imx_snvs_pwrkey_act(void *pdata) =20 static int imx_snvs_pwrkey_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct pwrkey_drv_data *pdata; struct input_dev *input; struct device_node *np; @@ -122,26 +123,26 @@ static int imx_snvs_pwrkey_probe(struct platform_devi= ce *pdev) u32 vid; =20 /* Get SNVS register Page */ - np =3D pdev->dev.of_node; + np =3D dev->of_node; if (!np) - return dev_err_probe(&pdev->dev, -ENODEV, "Device tree node not found\n"= ); + return dev_err_probe(dev, -ENODEV, "Device tree node not found\n"); =20 - pdata =3D devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); + pdata =3D devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM; =20 pdata->snvs =3D syscon_regmap_lookup_by_phandle(np, "regmap"); if (IS_ERR(pdata->snvs)) - return dev_err_probe(&pdev->dev, PTR_ERR(pdata->snvs), "Can't get snvs s= yscon\n"); + return dev_err_probe(dev, PTR_ERR(pdata->snvs), "Can't get snvs syscon\n= "); =20 if (of_property_read_u32(np, "linux,keycode", &pdata->keycode)) { pdata->keycode =3D KEY_POWER; - dev_warn(&pdev->dev, "KEY_POWER without setting in dts\n"); + dev_warn(dev, "KEY_POWER without setting in dts\n"); } =20 - clk =3D devm_clk_get_optional_enabled(&pdev->dev, NULL); + clk =3D devm_clk_get_optional_enabled(dev, NULL); if (IS_ERR(clk)) - return dev_err_probe(&pdev->dev, PTR_ERR(clk), + return dev_err_probe(dev, PTR_ERR(clk), "Failed to get snvs clock (%pe)\n", clk); =20 pdata->wakeup =3D of_property_read_bool(np, "wakeup-source"); @@ -162,7 +163,7 @@ static int imx_snvs_pwrkey_probe(struct platform_device= *pdev) bpt =3D (val / 5) - 1; break; default: - return dev_err_probe(&pdev->dev, -EINVAL, + return dev_err_probe(dev, -EINVAL, "power-off-time-sec %d out of range\n", val); } =20 @@ -180,9 +181,9 @@ static int imx_snvs_pwrkey_probe(struct platform_device= *pdev) =20 timer_setup(&pdata->check_timer, imx_imx_snvs_check_for_events, 0); =20 - input =3D devm_input_allocate_device(&pdev->dev); + input =3D devm_input_allocate_device(dev); if (!input) { - dev_err(&pdev->dev, "failed to allocate the input device\n"); + dev_err(dev, "failed to allocate the input device\n"); return -ENOMEM; } =20 @@ -193,27 +194,27 @@ static int imx_snvs_pwrkey_probe(struct platform_devi= ce *pdev) input_set_capability(input, EV_KEY, pdata->keycode); =20 /* input customer action to cancel release timer */ - error =3D devm_add_action(&pdev->dev, imx_snvs_pwrkey_act, pdata); + error =3D devm_add_action(dev, imx_snvs_pwrkey_act, pdata); if (error) - return dev_err_probe(&pdev->dev, error, "failed to register remove actio= n\n"); + return dev_err_probe(dev, error, "failed to register remove action\n"); =20 pdata->input =3D input; platform_set_drvdata(pdev, pdata); =20 - error =3D devm_request_irq(&pdev->dev, pdata->irq, - imx_snvs_pwrkey_interrupt, - 0, pdev->name, pdev); + error =3D devm_request_irq(dev, pdata->irq, + imx_snvs_pwrkey_interrupt, + 0, pdev->name, pdev); if (error) - return dev_err_probe(&pdev->dev, error, "interrupt not available.\n"); + return dev_err_probe(dev, error, "interrupt not available.\n"); =20 error =3D input_register_device(input); if (error < 0) - return dev_err_probe(&pdev->dev, error, "failed to register input device= \n"); + return dev_err_probe(dev, error, "failed to register input device\n"); =20 - device_init_wakeup(&pdev->dev, pdata->wakeup); - error =3D dev_pm_set_wake_irq(&pdev->dev, pdata->irq); + device_init_wakeup(dev, pdata->wakeup); + error =3D dev_pm_set_wake_irq(dev, pdata->irq); if (error) - dev_err(&pdev->dev, "irq wake enable failed.\n"); + dev_err(dev, "irq wake enable failed.\n"); =20 return 0; } --=20 2.50.1 From nobody Mon Jun 8 11:01:52 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011006.outbound.protection.outlook.com [52.101.70.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 855833DB300; Thu, 4 Jun 2026 06:54:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556074; cv=fail; b=CEkXwPzySD+bEcnBdmjdSvA76bbRsdii98W/yxPH2x+1CK1/T2imxilqqqis2MnjAi3ytkDOSX82lRcxTKlU+Ji/10/pCN2YLRT4Iydm/mxeG6PqxNUHZzQn08QY8xmFQfz3YrD3iGSffdTGjNwki6Cwp24V4ktySYm3ktfUlBg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780556074; c=relaxed/simple; bh=VtnbJvA8pYHTvGPkWduDf6BpOxv61YXsuKCYOh5WtDM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=UGYUxAP2u2SxnVlJ+nSYb1JvosK0C3tS2oxTorkck8l2+V1RDZcNtaQbrNtxOSVhYEnkYv2OQ5MbYxfI2nmcM7XvNBCxiH3FBDY+G/oUF8mfTHGJRXKeiAPnUSYDEqk75gAbEAdXxBp+R8FeyxDP4HSPujzigR9sqcOvq2OUkFk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=EWgsar/T; arc=fail smtp.client-ip=52.101.70.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="EWgsar/T" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hbPrUgwIPOXDvvoxIHHF1NOdJ9ppmS9+i2HAqUSOuNhb4MzgyMiR4Bk+fl3jnsfzEUff6DG8DX8UL2OBJz2surumJkPwBZ/Me9QQXAgkWsodKckiD800z1pquzIjt8ca5dh9GralAls4BwaHnd91TL2r3IeNc1afz38F6Lz2aAhE1xR9nIi17c2i94mIX0NU+qpdYC7uM0eypYDpbdOAkDWryKV2Ei0KUUo9jgtZ1ZKUSj19xdg1/3NAabQVvMf4k75Og/KKMG++N1OVsDOGOWVYbUYnnm/qG8txjyasarInqcBbmSm7bq2ZOuzuyVH8UZEPYdSvVf3BuP6M2+nX7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s0We7+jtSkoS2dN3coVMBudYg269pJSvY3jFfLyh3hc=; b=vIfBllsgjocadn1w4HIWpfSZqsEnw/tuRBAbQCE6JzwWVyPBU+FBKwoSpkBLutVelfUyRba+xUUTCI4WDkjTZZs6V/K4n0S+SIiLwnadMH7V5Sqsu1p6eELWN1AvA3EhBIXh3yoW9HcA3CE6UFU2ynBgZ3NfA8HWKn+cD84SoM1tXopv/W2/HMKvUtjpxHbvdg4z8GFs54xs8cBkzKHqoQs1/gJRg8Bj0leD51WPzVHC/8bQvPEBMGC6FlS+VzQlCyu8mKCer7N1jSp6rcwQa/Usv8cIAgYCjm/zjV35+VBSWOa6qYlgOcjOLSvDsPHnD7VAnPHWRYbIpQOCgirEvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s0We7+jtSkoS2dN3coVMBudYg269pJSvY3jFfLyh3hc=; b=EWgsar/TSTwiYNHOA1gU4UzkZdFF8t16uS/bhqtxSZUQbBZMx1DfjoCMeYguyPmq3G/iZz2OdLPk2NRGX5VsxnHkTUNq/nuPwxwwA0R7TMhcIg9AOdPaIvZxsOXJg1rMMf/5FpDdvv9LtvbPRz/zCnveyXkPLhmCYwYVxnbLQhbJ9XcZZRK+p1RXHPUPb1cx6WjWhufJYCQ/Y/Rsq9NHawYeU7CS3ef0yJbYw2ORxKjUjZbHEsEucm822RNyDDoUWc/F+xz+NdI4aEtGv8aIZ/UXoXR87OfioZxhscrLHwL4/9twonTFfRZP7RVkoE9MKEgzMLG1rylLDwVJSjldkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5765.eurprd04.prod.outlook.com (2603:10a6:20b:ae::26) by VI1PR04MB7184.eurprd04.prod.outlook.com (2603:10a6:800:125::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Thu, 4 Jun 2026 06:54:29 +0000 Received: from AM6PR04MB5765.eurprd04.prod.outlook.com ([fe80::bc76:f507:9b83:9d69]) by AM6PR04MB5765.eurprd04.prod.outlook.com ([fe80::bc76:f507:9b83:9d69%5]) with mapi id 15.21.0071.015; Thu, 4 Jun 2026 06:54:29 +0000 From: Joy Zou Date: Thu, 04 Jun 2026 14:56:24 +0800 Subject: [PATCH v2 4/4] Input: snvs_pwrkey - report press event in interrupt handler Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260604-pwrkey-cleanup-v2-4-59fa0ddf0d7c@nxp.com> References: <20260604-pwrkey-cleanup-v2-0-59fa0ddf0d7c@nxp.com> In-Reply-To: <20260604-pwrkey-cleanup-v2-0-59fa0ddf0d7c@nxp.com> To: Dmitry Torokhov , Frank Li , Peng Fan , Jacky Bai , Ye Li Cc: imx@lists.linux.dev, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Joy Zou X-Mailer: b4 0.14.2 X-ClientProxiedBy: MA5PR01CA0155.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1ac::7) To AM6PR04MB5765.eurprd04.prod.outlook.com (2603:10a6:20b:ae::26) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB5765:EE_|VI1PR04MB7184:EE_ X-MS-Office365-Filtering-Correlation-Id: f84b0042-516d-44d0-0311-08dec2061ff8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|19092799006|366016|376014|38350700014|11063799006|6133799003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: WLiiEX+v8NVUy/V/07QkAOHzkBphub0xkfQB7rTJfMKPVAQXU7ZlXQJzQYRJ75Act6X0rgp9ZNASGu/zLkgNcOljzMjXDYwC8nWdWesiMvuHmJyPd/GzXC4riDz0uJzPNpRIMKaXWYVBjXhCdu5DPkLpPBrUipAR/T3UUinxcbHTy4ljRgXQ+/UcW5lFfZVwcalH53oQOcoCMqGQWcMXjkbOD/6qaKz3pWQjCvlm8WCZvzjxXPmqRV+BKVWRRE5QRkCMEkc0a42jDTta7vPs1vt2AZ3/u/50k9gk45MUkh+q4y1AtuJAj+JP9Z5/Jjuf341RiAH+CJLH+809E6PXlkcIEwKrsWX6iYQj4QzlYNYhqUNKtjVUPUnkVQ3jVw6413+jfHYhTl6rQ3Cf3kcJwKULf3y/DUxz1OjSu6d4SjcKbxTjRu6MTcfNK6ofjWLNm3dijrdZwaJjqMIlzstbM9LDdL0XovH/8ltJLdRFvck8sef5Rbu3pmcRyo5rOGOAINA3renJMtPptHboMPuGWCNlVk34LQWjOys2NOvlPqrL9oVDgedd+mhY/fuB9XjzvcRNqe9LyNaNyZh/tblVRxkSRUAT8vqM/LjV31OUT/fLbqMsYfQgnX7iiUUwrGhO0kjWCk+a9J44wYH0QUeUqySEMFZYOaUrBxYHhfrcPS62BpFEiPoydDKwMuAtLKEfS2rghMSBT7lE1ikh66cUpplSqEX51X2dvMbKzin6UBBA9yRo6YdrTkajnNI3jVNo X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5765.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(19092799006)(366016)(376014)(38350700014)(11063799006)(6133799003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUhkRllqMTRxVm5Zc1BsUkt0Sm5SUkw4dWsxdkhNVER6VlZCMDRFRFdQVU9u?= =?utf-8?B?ZFF0Z3VCczNqQzFDV1RJajRkcUFLc2c0STFUWW54S292NWtpc2tLekJIUHdZ?= =?utf-8?B?S0JMNnlzYXNIRFRlaUh2V1dhdGcvS2pIYVhpaHN1dmpaZVU0dWJxZklRQldR?= =?utf-8?B?S2R1UHJwS2ZMc00yVXFRV2VMU0srVjNmaDBHcjdZVjd6aEpEZ0NKUjZySTJQ?= =?utf-8?B?amQ2WEYreGlCTWFrL2Z4REdRSDJRbzJFQlc4RlorMlo0OXBoaFhwQmwvd0R2?= =?utf-8?B?eExNMlFTZWlibWRadExJdGJGam5hV3h6bU5xM2M2bnFaOGI3cmFMWEFoL1Yr?= =?utf-8?B?VWxtQTdncm1jYklWTGszY1B5aFhBKzdURkgvRlRPMFo0N2RUWjZuSGRMYW5F?= =?utf-8?B?Umtnd2VESXZkeGFxeFhsOXI5U0g4WE9XbCtKQ3l2OFNFSmxqV1ZkRCsxREJh?= =?utf-8?B?RmJPUzU3SWNwYzhSbUw2bEY1NTk1K0JrMDU4cU43MUhPTEtDU0ZHYnh4NXNp?= =?utf-8?B?OGhyZGNCUit2cysxNE81dUxoKzFodmlCS0U3SmhCMExMRG50bzBxM2hrV3pq?= =?utf-8?B?MDgrYTJvNGlJTmdhOFpTT3krZjVvQXJ1bW0vTmVNNnBYclRwbnVIMzdmK1lT?= =?utf-8?B?Z292d1pGM2Y1RVBLWE44UFVWNkFtUHFEUUV6aTF5d2E0eVpJSW8xc2dsUWZj?= =?utf-8?B?WGNzaEZLNldualRsRVY0SGNhOEFBcU44VWcxb251dUV1aGxpMkRvZjdBK0hZ?= =?utf-8?B?dGdTRzg5NmtqYnBlL0ZxWG1sSXVTaHUzQjFRcWR3blJpbUo1K1FMRm9rMVpu?= =?utf-8?B?dEswcFBrUElpV0RzQmM0NEVzUk9sOTM0MHhjdnNia3F1UnRmcU9zS1Zrc3BC?= =?utf-8?B?WnlLUWFsTU0ySHdOY05UcjJSTEp5ZDkva3d5Yzg3ZFZxUW9VenN0dXhJK21D?= =?utf-8?B?bUF4bUVTaTNqcUNUMzlwaktzeSsxUW55ZGJGYzVhSkZJcU5CMGFSRDBUVDdY?= =?utf-8?B?RUJMZ3MrYlFEVnUxSTlwZHdiZStVdVJLSzVOZVliQXpEVEpmQzRLU291QU5U?= =?utf-8?B?dFZGZElIL0xhUUJpWHh0K1BhZmp1dnFpYXZIdlZLUFZGbHNOY3RhQjFMV3Vh?= =?utf-8?B?WEF5Q0VVWjZQeTQvMEdYTzhZNU1Lc2xtM29JeU9NazZwSVRObzFSb2xIUzU2?= =?utf-8?B?aUxFVkpadGRGTW1COGxUbmprUTlpenpHODc1Q2RkZnNLdjY5c2tiQWE4dkdM?= =?utf-8?B?bElsdWlONVRGbWwvNS9MaDlDY041WHhNYWxVN2hCUnkwZk5tNnZTYVJzOHFJ?= =?utf-8?B?QkVEWFF5ak9FSGNmQkZZVlVscklzMDF3S0tWanBRa1FFMUQ2UmE2TWVCTnlw?= =?utf-8?B?TFpTbnVCYTc2dWNrR0syK0NQMUR5c1kvdGVSU1V1MHJnSDZ1QlhWMzZHYkF4?= =?utf-8?B?cGE3REt4MVEyUDE4aWNYR3Q0clFWQjFBck5QM1JHTU1pd1o1VEtmT2p1SHhO?= =?utf-8?B?QjFDb1ZiL3JjU01rcUNTTVRMVnVaaEVWSmVaMWFxNCttME5sQnMzZFMrdTky?= =?utf-8?B?dmhnbjRuMEFGa0tUUjNDVjZGMlJYL2orYnNNNWVIUm9rK3YxQk52cGNjeDlp?= =?utf-8?B?dmx3bjRvYmNVMFZ4YVorV3c1WS9UYm9TVVJmTTRpZ0w1RTdaWi9QM2dqclF6?= =?utf-8?B?WFJqc29wM2pZUzZkRjgvVU1abGk2dUdnL282aGMzelMySlYrVnNOSnNOTzg5?= =?utf-8?B?aU5veFBHZGkvS05VMEg5Um5ocXV0OFpNdG9MdXozSUg1Z3R2TERiSmFPbTNM?= =?utf-8?B?OFM4QkRaZ2lES1hRdG8rWmFjM2J2TXg2Nk4wdGdtMkNNSGdNWStJZjErTzVI?= =?utf-8?B?Z2RxK1A2TkNTU0NLbDY3NEZwZ1lhRmJiL2FSa2JGVnhsdElpNHhMSGxqNVM4?= =?utf-8?B?cGMrbUl4clVXYnVrUXBaSlNjUU1YdmVDSFdyYlpJdmxGNENvTUhobDNPZW8z?= =?utf-8?B?UFBKbEh0OFRITkcwdEdEYldvZWFNNXJHaFZaaDY0TjhwZmhrUnd4RDNxaDF2?= =?utf-8?B?Y3VhYXZqYTBRYjQ2N2lnTUJTcUtKcnplZWFVNkJtVjU2WnBOWW4wRGFZZmU5?= =?utf-8?B?ZVd6cEs3VDNLY3VkZ3VRaEpwaXJzWmtMcVdEa3JKOVVpKzh6Q3hOK21CNTN4?= =?utf-8?B?bFRwT29jYXgrdkF4M1QvcExhMVloZFptOVFvT3FQYk1SNnZmWDRLaldsYlcy?= =?utf-8?B?QmhEOXhhOW00aE1qZVFzb0hZcFpra3dORUNhNzBiNThmRW40b1ZsN0hmKzQ3?= =?utf-8?Q?67fGpt1FuW+ZMMq3u5?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f84b0042-516d-44d0-0311-08dec2061ff8 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5765.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2026 06:54:29.8332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tDelnwrr5Bucx5qroqJpeHEPM8yoQzusIX5MOC17HgP+aqjfQNktWGsqvqw0cJif X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7184 The driver implements debounce protection using a timer-based mechanism: when a key interrupt occurs, a timer is scheduled to verify the key state after DEBOUNCE_TIME before reporting the event. This works well during normal operation. However, key press events can be lost during system resume on platforms like i.MX8MQ-EVK because: 1. During the no_irq resume phase, PCIe driver restoration can take up to 200ms with IRQs disabled. 2. The power key interrupt remains pending during the no_irq phase. 3. If the key is released before IRQs are re-enabled, the timer eventually runs but sees the key as released and skips reporting the event. Report key press events directly in interrupt handler to prevent event loss during system suspend. This is safe because: 1. Only one event is reported per suspend cycle. 2. Normal operation retains the existing timer-based debounce mechanism. Signed-off-by: Joy Zou --- Changes for v2: 1. Add a boolean variable suspended and PM callback functions to replace the use of the is_suspended field per AI review comments. 2. Move event report handle to else branch in suspended state, since the pdata->minor_rev =3D=3D 0 branch has no debounce detection per AI review comments. 3. Modify the commit message. --- drivers/input/keyboard/snvs_pwrkey.c | 35 ++++++++++++++++++++++++++++++++= +++ 1 file changed, 35 insertions(+) diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/= snvs_pwrkey.c index 4a1d04898482669894e9978014b62e4e9774b4e4..f212a6b26185d13e1af62728e7b= 2add5010adc5a 100644 --- a/drivers/input/keyboard/snvs_pwrkey.c +++ b/drivers/input/keyboard/snvs_pwrkey.c @@ -39,6 +39,7 @@ struct pwrkey_drv_data { int keycode; int keystate; /* 1:pressed */ int wakeup; + bool suspended; /* Track suspend state */ struct timer_list check_timer; struct input_dev *input; u8 minor_rev; @@ -92,6 +93,15 @@ static irqreturn_t imx_snvs_pwrkey_interrupt(int irq, vo= id *dev_id) input_sync(input); pm_relax(input->dev.parent); } else { + /* + * Report key press events directly in interrupt handler to prevent eve= nt + * loss during system suspend. + */ + if (pdata->suspended) { + pdata->keystate =3D 1; + input_report_key(input, pdata->keycode, 1); + input_sync(input); + } mod_timer(&pdata->check_timer, jiffies + msecs_to_jiffies(DEBOUNCE_TIME)); } @@ -219,6 +229,30 @@ static int imx_snvs_pwrkey_probe(struct platform_devic= e *pdev) return 0; } =20 +static int __maybe_unused imx_snvs_pwrkey_suspend(struct device *dev) +{ + struct platform_device *pdev =3D to_platform_device(dev); + struct pwrkey_drv_data *pdata =3D platform_get_drvdata(pdev); + + pdata->suspended =3D true; + + return 0; +} + +static int __maybe_unused imx_snvs_pwrkey_resume(struct device *dev) +{ + struct platform_device *pdev =3D to_platform_device(dev); + struct pwrkey_drv_data *pdata =3D platform_get_drvdata(pdev); + + pdata->suspended =3D false; + + return 0; +} + +static SIMPLE_DEV_PM_OPS(imx_snvs_pwrkey_pm_ops, + imx_snvs_pwrkey_suspend, + imx_snvs_pwrkey_resume); + static const struct of_device_id imx_snvs_pwrkey_ids[] =3D { { .compatible =3D "fsl,sec-v4.0-pwrkey" }, { /* sentinel */ } @@ -229,6 +263,7 @@ static struct platform_driver imx_snvs_pwrkey_driver = =3D { .driver =3D { .name =3D "snvs_pwrkey", .of_match_table =3D imx_snvs_pwrkey_ids, + .pm =3D &imx_snvs_pwrkey_pm_ops, }, .probe =3D imx_snvs_pwrkey_probe, }; --=20 2.50.1