From nobody Mon Jun 8 09:48:27 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 288703AB285 for ; Wed, 3 Jun 2026 23:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780529231; cv=none; b=NeiSKEBoFxut8h+LDa9getOMFJS4kRW8YGSHeVn7Ym/vWPCsxcak0WSaMGjdl1UeCXmgrzri2gWiZnzdoJX+cQpJZTKJ4zaeHb7RMktlV1Qe1GVyZyyrSts3I0qyHBhlDJiWAYGwcbbUDGRyMg8vao5es5V2QRHMtWwgpp+Mde8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780529231; c=relaxed/simple; bh=41RLXGxxCkF6evkmiuQBXUvrmZEV/tP+nyRrVDCrsLs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=K5XkL6AsewLhWczsEuFmsDEGl+1TpkvcxwSl/N4150wS/guwGXQGTjQdY6py8ZX/zB36fG6ImI++kRGktz+DDnu/Bpd5gxsEOdrrQdgab7cdw4MLkdkf+WyGurer4/k2dRzsYuZb+Ne9+1pKPGgqP1iTUelvyIBFIZEvdzIMu5s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iZ1PMRpw; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iZ1PMRpw" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2c0c3543590so556345ad.2 for ; Wed, 03 Jun 2026 16:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780529229; x=1781134029; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dZ7Whjf9rGOihI7ocMNjiwJGEh3geoh5OMV09wppzAY=; b=iZ1PMRpwDlark7ivsv5Ey5egPuqBjWy2QeOZI5aPP6jOmJhuGqe2ezWmHzjpty+UI+ Qefmzc0vgeMy8tejybhgCVVJ27iFA5js1ojh7Mqa1Z/u3aBhCwGU1qivpWzXn6hpx2AZ CBRfKHGp8Ihj2OgLylIECc/4A/7sf2mE7aLr0/mecigstC6X/D8tvc767NTIT5jhP7Og kKlvsoeVQEB24PqzE+GRCP0D8hjPgEajERddQcMf0JTNl76DqYo3xBYxmN+sD1arkf5y jimTGWXfBNa+EhoCUS6DtarkVTYDB8sS02TJ5UySXsNOeDp7ghBW5we8swasFBRD9RTM 9XYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780529229; x=1781134029; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dZ7Whjf9rGOihI7ocMNjiwJGEh3geoh5OMV09wppzAY=; b=sVi5InVzaA0oXs+4sb6dHJ7xYVeJzfDtVYPfBkCK/r7b7R4/NXWBzsNXTYNVNPkywl VPc3YEVS4u2wD3TYg2aeQ3f+fzfpqKxcT2K6bNm2CjBRkjwJhfrJYvomjc/yW/SEUF4T ym1lFeXl9X/C4lQ0MgrFW8J/tTNzgecwkHaUVplSCspFDnqbjNyJaql/v7xUYaFZYShF B2chAtcrWGtTKlda8SolaUgpinPVon8O6lgrJFXXUCnTxz5BQJZNMFcCGrLWhzHws/mh 49zYo/pXxvqEu8+SDoVJp8qycpgFciSzT3OfMl75qCFVeIZ91Qj2c2mw1Q/9A0sLUDGL /aYg== X-Forwarded-Encrypted: i=1; AFNElJ8qC3PFiVaC1WOPy9upNsdFpxvYkUD1Ky+Ulv+glsFjTO7bH5y8hexvGoEqkOxO2VbcQrfBwcwZP971oa8=@vger.kernel.org X-Gm-Message-State: AOJu0YyYEw/LQLHQaHnCGiRiu28tQVWE7P/H8XqQN7Vm8pXkz9+9YaUG 1ZP8WjBoEGOyG2hawfNI0LGO3H626CdCJs2MjfWrBcRgAVhikyJAXb31 X-Gm-Gg: Acq92OGYGVqLQDDjIYuqM3E7rd8qdCXKvEjym/wLEJXK0DAD6SUT2cDLbPitq4QpQCs kZnLHquwzp1f4b+gVXCoS/zXgrvSzJ0ZW2XMkoGf7/Uc6nKgV0QOuql/SDUDCLPRWQeeuQckyiN xLXnxWOvc2ZrDdbKhPXa2EV7DP8BBk/SPctrNdKs/8Ekk81QNBWSEwRGosHe8kdxsBGF4zLwj+A CJ66R1Jh1Wv2p3k5D36EN609IZPk6RPY+u7eMXdHZwK/tbGPLABFeDiu5pZeztcRDGUy5VzBRsR l3dPpJBdiamm0vKTKYae78ggc4h3rml6epDLNSatOeqwWNTU4z8KTPzbYn38xarRaSiNurop9u2 gNcMMS1qIEKqhlS8Ig4Jo7GEtkNVUxtmbxUYBhl6e3awebY20Xvgvgzm8o+EEfu++gdeiub34Am t/oo27bhmFvXPwdMI1oe7Cre55VmleZqMZTpy8zMR2PQ6FD+4MnbpfmEkdXbvWWJb2rsDv9fVod gTSuX4u/QK7rH9yB5Cvoud/lCSHYihclWe36/D23FE4iw== X-Received: by 2002:a17:902:f60b:b0:2bd:9803:9308 with SMTP id d9443c01a7336-2c1644b827amr62195945ad.36.1780529229363; Wed, 03 Jun 2026 16:27:09 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16649bde7sm37462955ad.72.2026.06.03.16.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 16:27:08 -0700 (PDT) From: Rosen Penev To: linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] serial: 8250_pci: fix -Winitializer-overrides for Brainboxes UC-260/271/701/756 entries Date: Wed, 3 Jun 2026 16:26:51 -0700 Message-ID: <20260603232651.8580-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" PCI_VDEVICE() expands to set .class=3D0 and .class_mask=3D0, but the Brainb= oxes UC-260/271/701/756 entries immediately override those fields. This cau= ses a build error with clang -Werror,-Winitializer-overrides. Fix by expanding PCI_VDEVICE() manually, omitting the trailing .class/.clas= s_mask zeroes so each field is set exactly once. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/tty/serial/8250/8250_pci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8= 250_pci.c index 3e5bc9e8d269..0513f4b3c093 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c @@ -5394,12 +5394,14 @@ static const struct pci_device_id serial_pci_tbl[] = =3D { * Brainboxes UC-260/271/701/756 */ { - PCI_VDEVICE(INTASHIELD, 0x0D21), + .vendor =3D PCI_VENDOR_ID_INTASHIELD, .device =3D 0x0D21, + .subvendor =3D PCI_ANY_ID, .subdevice =3D PCI_ANY_ID, .class =3D PCI_CLASS_COMMUNICATION_MULTISERIAL << 8, .class_mask =3D 0xffff00, .driver_data =3D pbn_b2_4_115200, }, { - PCI_VDEVICE(INTASHIELD, 0x0E34), + .vendor =3D PCI_VENDOR_ID_INTASHIELD, .device =3D 0x0E34, + .subvendor =3D PCI_ANY_ID, .subdevice =3D PCI_ANY_ID, .class =3D PCI_CLASS_COMMUNICATION_MULTISERIAL << 8, .class_mask =3D 0xffff00, .driver_data =3D pbn_b2_4_115200, --=20 2.54.0