From nobody Mon Jun 8 09:48:24 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B554920FA81 for ; Wed, 3 Jun 2026 22:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780525097; cv=none; b=WuZI20GXonLKg7WnRZUNbNSyAlYY0hjWhbPsT6tECOtalmFtQtsXM+VrPh82miR6WxnEKB01gd/9JkoLArP0+Sx+3kuJqsKP9ma04qkd8klOgzQZ+4jVF6jkDU3hEL6RtcJ06NzrEIp5zmUi/ChMZFTGDxD7po6aH6yqIr7RjhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780525097; c=relaxed/simple; bh=DZJR7JiHnIxr/d/xhHstClpwxcMYObV5dZ1CAJ/DFQs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nOwZIaskMsHxx6UzKmdQt/x2HvFkkDqNHQUBmtltZ4i8UYydqDJEs07aNLqzjDw9pSxycanRIeYWOi53PnWJf4XW+uuW19DIeNs4RBMVtJo4BJ+Vz6mvIDiaZLAuoN1aP6NoHuBwul7QGu1ftu7FcUURMPZ6W0SAyq5ZhRL9fZw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sAlV/yy4; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sAlV/yy4" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-84229481d44so16112b3a.0 for ; Wed, 03 Jun 2026 15:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780525095; x=1781129895; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ad37qvFp+RqpJv8WaZQLl/jkZ9QxP+cypLV1t8jzXk0=; b=sAlV/yy4C4b7vzoiN2g4g+hT/lk2oNCoDpuZ5lKIoDnmBnP6xnp3d9/hBQq98nDZsE NtOMapCL4lQPv/I/WdyEKtGGwhsoY6OUwsbEw5BMMJEyq4ztPdxB+WVjStw5FJF7lSd/ AglrMMNDZFQGQf+7P8xPUd24CXVZLKwX8LpqGo0lvm70qVdzBptFBzYQyrNE60KhwiH/ PRCg5TYETWGo+DWAkOzid6BSCafI9vb/tBlGKoYc0MtmhDV6f8vICHIh2KL3gE/VyhKQ ZRBJ4+G8CxlhL4uCTay5SLn5ECRSWgInrG5aXNkV9jU6PWzANVik032IIi9IK4hSXVV9 V2vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780525095; x=1781129895; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ad37qvFp+RqpJv8WaZQLl/jkZ9QxP+cypLV1t8jzXk0=; b=iuKCpO67XXsZIqROu5RG/+nxdNaf7yw0asX24LQ4etv8dMTsilm3jiSgLtv/UHaEaS jc+Cjekzhp+spODNWxMGwC/7em+TJq4M0glsrRIjiAiXY2KKDyRyYS4JDPhF92dSgnQp Hwm4M+DyY8i58LNbJ/roO31r04aUmejucTZ8JctXcvRVVgxK12i1I6ro0nED9DTnT7g6 vbHsA3TMp2PLGVtdVlUf9MrqQeNS+pjZvgj2s36Dr/KjWvwPmmt3F6OUqBI4cWOs/EQj g3i+PRMHLcDXbbKwtIOjEM4fYIYviFqiu42SGpwmsUZaeKc729i4lIAgbiWA3nv1tffd quqA== X-Forwarded-Encrypted: i=1; AFNElJ+WeSMvzQBDSDgb5wlEH8wAbaRXlfW/ylJk2+gv6ZN19iEuzw1TpYZ8nDFbM2ypsxegKukUIPy3gZgOag0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx++R9gdovWsAENewOe1TC+j7Vxbh8N+Y45B9ZKIXQeaEgDNhbC X8v7sPJSxPy/H5wSmXu2FLQXWovfLuDo3hCjFgS1AKYd5cW6XvON8x4i X-Gm-Gg: Acq92OGfbqL6LEUOlo/3Aw1s5UyRycSj2+kCL5gJ9nxSt4OXuQJLxkUj1Hx8fTWbK3Q 98IF3V6hXpZshdVwskF8q5Mx+prtE/qcYeFnkk30WU2+chB2teSoiNpazpLxf3QQ5pstMN8h3/4 N3je987eAUPYDn+UdVCB7L3EvdywnzlnYecdZ+/jXE/1D7qXb4ng1+/dJqZy3Vu/8U0D5y+inn1 cfY+nFLRQmDxzwC4vJelsl9AeCBJG1zoAde9ElBDFeO2a+9lkcPDD1XOMZMOFR04rbswcMlO7Tn B3kLz769fA9rRrc9rb9EqEPp9xXuPdibSSlw8hu3okj7XE2sHPYS3Gut/yEqs1NkhDfRvZulvna NclOsfus3rQ6GH0yqtKaWi2rOmR5vxJs9+mlt+BlN/whpfMfXTuqlouIw2aQHzjqTMBCcha2ySF LRfOTiLmYwfANXoaHfPalbZgqoa1iTTxO4cF0DCNFBirg0pw4ERsUevw4kGf+FHRMIKEygmnyYU /tVwPCpt7bVPrNeedbb1k3zkXhUosxnBH8dqf06ujQvlQ== X-Received: by 2002:a05:6a00:14cf:b0:842:4327:6cfd with SMTP id d2e1a72fcca58-8428501684emr5311737b3a.49.1780525094963; Wed, 03 Jun 2026 15:18:14 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828daf76sm4186747b3a.42.2026.06.03.15.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 15:18:14 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 net-next] net: ibm: emac: Clear MAL descriptors without memset Date: Wed, 3 Jun 2026 15:17:56 -0700 Message-ID: <20260603221756.56203-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clear MAL descriptor rings with explicit field stores instead of memset(). The descriptor rings are carved from MAL coherent DMA memory, which may be mapped uncached on 32-bit powerpc. The optimized memset() path can use dcbz there and trigger an alignment warning. Use WRITE_ONCE() for each field to prevent the compiler from merging the stores back into a memset() call. The skb tracking arrays remain ordinary CPU memory and still use memset(). Assisted-by: Codex:GPT-5.5 Signed-off-by: Rosen Penev --- v2: Use WRITE_ONCE drivers/net/ethernet/ibm/emac/core.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ib= m/emac/core.c index d2194b406c9e..b7568d96aa47 100644 --- a/drivers/net/ethernet/ibm/emac/core.c +++ b/drivers/net/ethernet/ibm/emac/core.c @@ -1162,6 +1162,17 @@ static void emac_clean_rx_ring(struct emac_instance = *dev) } } +static void emac_clear_mal_desc(struct mal_descriptor *desc, int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + WRITE_ONCE(desc[i].ctrl, 0); + WRITE_ONCE(desc[i].data_len, 0); + WRITE_ONCE(desc[i].data_ptr, 0); + } +} + static int __emac_prepare_rx_skb(struct sk_buff *skb, struct emac_instance *dev, int = slot) { @@ -3089,8 +3100,8 @@ static int emac_probe(struct platform_device *ofdev) DBG(dev, "rx_desc %p" NL, dev->rx_desc); /* Clean rings */ - memset(dev->tx_desc, 0, NUM_TX_BUFF * sizeof(struct mal_descriptor)); - memset(dev->rx_desc, 0, NUM_RX_BUFF * sizeof(struct mal_descriptor)); + emac_clear_mal_desc(dev->tx_desc, NUM_TX_BUFF); + emac_clear_mal_desc(dev->rx_desc, NUM_RX_BUFF); memset(dev->tx_skb, 0, NUM_TX_BUFF * sizeof(struct sk_buff *)); memset(dev->rx_skb, 0, NUM_RX_BUFF * sizeof(struct sk_buff *)); -- 2.54.0