From nobody Mon Jun 8 07:22:48 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85AD34963B2 for ; Wed, 3 Jun 2026 21:17:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780521477; cv=none; b=c8oBhPW8CC3S5Sx+cO1QorI1eZ1nrKQmsOMAy6JbyeLhLad5RGDSRB2wv/grZ4UmUp4mzhV3/V7qID1hq0RT5N/DkmSPKWKBNOOApQ00uyls1c+2p0zE95Bg0mos4LtifmomQzn5o8oK6SD/5lxlNuovIJtSLBYxSV/xfYFOi0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780521477; c=relaxed/simple; bh=kSnVs3GU1f1orJvqpc5R32SF8xmTYRrRDsl/Zm8fdAQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AAWsdbggD963N1SdsB2xE/XCPwDGZgVe2HcJNvtMyEQHyFjQsxxwXzj+RiHvK9u4/p/sjW1Di4WMioMX1LutCwpa6rlUJtySkWpYj1rTuqLrFPqq/kfpr3V/P/9ZZuJoOepiaO3a+6MbkZgHr3TRh21utCIV+1G0w6ClRodaPAE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kUfQVHC0; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kUfQVHC0" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36d630c0e35so4703114a91.3 for ; Wed, 03 Jun 2026 14:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780521472; x=1781126272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y7NhpR306DthBWL5Ac00AOL5THAOVS6A2OjkkWt587s=; b=kUfQVHC0CJ5zpb24VruZC1oA9JnJEhJnC273scNhGNlNz77QPoYCBeiEu4DHJVjV9A 7I5ShPU42Vms7iySyroTDJAnzQ+xFhHWilCQufjvFugRvKE0a+VRRuLuR9vHH/BiwdEs Q36ROtyUxTEheIohk2NeJjNGotp+ZbngpD0jPF4hWIWnSMeB60K/zWgpJ9bH5uZuQbzE 820dZjUStkRGQydMQ9TSTJNNlICE2aqk06Wdz4rwvTgn61bxt9G98XAt2gYUpZ9ovtf+ PPnHcNwmxabiHSa0yJ+rWdSClZN/MDCe8KO6U0ygTlN0aruwGFYpMmFPRwxCnzSSlmJ2 DsrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780521472; x=1781126272; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y7NhpR306DthBWL5Ac00AOL5THAOVS6A2OjkkWt587s=; b=eCFGq29/zTBqj4kydPixh/pWM/VBp6m0a5bsUEytzFwsUwrpYaJuH3iRat9esrfgIi lYLAzclUa+viU4UezMdziEYiR98e3o7Drr7VrfxyqwPJcYJZrwY1bBzQZFGQ4NNIEfB2 OnNDpSH6/x1aBMComgzzwotiEK7IWmYYE5FFeVW403ugmhb8QyyZB3ziut/10lHovs2p q7JlhK/bXcWGyLfXg2LeXY09N74Z99LFzqx4cKBALkan4gfJz6Er57OX9jzYhRL5CoIA zB72GIYFitOw1LvpKFE9XZnfyJ1Uwq3wwwZiQxvjqNaqhbt2Dg87xVx8YNBygQfqHp+K 06QA== X-Forwarded-Encrypted: i=1; AFNElJ/vkDghq/gwid9/ERWDanpw+qsTboftgGI1Rzyrpb0rlo5rmKbkYnw2gT6dFL8Kc3cPiXaDSHz6e57Jqkw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9D2YfgRI0X1Yvrcu5Ei18GE/dcmO7vH3seIPep6moWLdi7Khd ZB6Zv382eEOS87Qu6C4QFB5hNv9ZWvbw2yhpiYMVPtNhHmhEUFlwqpZo X-Gm-Gg: Acq92OEM+vTbFHH9NPeXmQgUVoBgJ6gGMNQkNifFo/P4gIem9P99Ey6HqSLW6rttXWE kIo36ARu1KomXhj2CJShEPrdkEwiGoUOKlA8/8e5YsOfS6s1otlAYZV9yv5pDS0xf9M39/aUGYy IS41EOA3c3LkikXPSk6hLmtd2+WlNBCFfAM3XzIsBRuikRORYH0H37Hyr5AzfP+y+GLVToTr8nj rCo8qDjbkrI6KEWl3dCuLJugnklFA+PFPvxfyA9lMzKQEz22lFbpGoptn2npzrI1hvM7fHZYvkc ZI+qoj0WW/hyM35cXdCpNH3O041B8binmFkzmTOCXujpsAsUUJEN7uT6y6tQwOHWNT60aruVxXM y7b0a8hbZ1UwTHgPPpW5/8ToA5ShQ9pEWFsuf8w5z6MZqjyjxgqRfzbsxwVaPWfet7JM7QM+Sx6 lOi7Dh0w6kp4UPVqH2X0G2UUGp+2sxFJKbM9u8wXhnQ2rI5tbnfwbBJM/CwAvaJMNWvp6A7cW0/ twabcR3gut+gRRFLPhn34IUb0XHjtPiCrePLLfK6l0MfW8Kd564AOSv X-Received: by 2002:a17:90b:48ce:b0:35f:b987:4dac with SMTP id 98e67ed59e1d1-36e2fe831a5mr4943283a91.12.1780521472469; Wed, 03 Jun 2026 14:17:52 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6d1fec67sm782670a91.11.2026.06.03.14.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 14:17:51 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rosen Penev , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 net] net: ibm: emac: mal: fix unchecked platform_get_irq return values Date: Wed, 3 Jun 2026 14:17:34 -0700 Message-ID: <20260603211734.30750-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" platform_get_irq() returns a negative errno on failure. Commit c4f5d0454cab5 moved the platform_get_irq() calls and explicitly removed the error checks that were previously present, claiming devm_request_irq() can handle it. However, a negative IRQ number passed to devm_request_irq() fails with -EINVAL instead of propagating the real error from platform_get_irq(). Restore the missing error checks with proper errno propagation. Fixes: c4f5d0454cab5 ("net: ibm: emac: mal: move irq maps down") Assisted-by: Opencode:Big-Pickle Signed-off-by: Rosen Penev --- v2: remove error messages. platform_get_irq writes its own. drivers/net/ethernet/ibm/emac/mal.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/ibm/emac/mal.c b/drivers/net/ethernet/ibm= /emac/mal.c index 7d70056e9008..83dd7f99d8d5 100644 --- a/drivers/net/ethernet/ibm/emac/mal.c +++ b/drivers/net/ethernet/ibm/emac/mal.c @@ -635,6 +635,11 @@ static int mal_probe(struct platform_device *ofdev) mal->txeob_irq =3D platform_get_irq(ofdev, 0); mal->rxeob_irq =3D platform_get_irq(ofdev, 1); mal->serr_irq =3D platform_get_irq(ofdev, 2); + if (mal->txeob_irq < 0 || mal->rxeob_irq < 0 || mal->serr_irq < 0) { + err =3D mal->txeob_irq < 0 ? mal->txeob_irq : + mal->rxeob_irq < 0 ? mal->rxeob_irq : mal->serr_irq; + goto fail2; + } if (mal_has_feature(mal, MAL_FTR_COMMON_ERR_INT)) { mal->txde_irq =3D mal->rxde_irq =3D mal->serr_irq; @@ -643,6 +648,10 @@ static int mal_probe(struct platform_device *ofdev) } else { mal->txde_irq =3D platform_get_irq(ofdev, 3); mal->rxde_irq =3D platform_get_irq(ofdev, 4); + if (mal->txde_irq < 0 || mal->rxde_irq < 0) { + err =3D mal->txde_irq < 0 ? mal->txde_irq : mal->rxde_irq; + goto fail2; + } irqflags =3D 0; hdlr_serr =3D mal_serr; hdlr_txde =3D mal_txde; -- 2.54.0