From nobody Mon Jun 8 09:48:11 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B18D3A1E89 for ; Wed, 3 Jun 2026 19:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780516377; cv=none; b=CJ5PXfw5EmL8EMdBIE0f5CcrSciWzdYRvErJ5zyhckzj1pv+XsGrzNUs2619qCgvvgs453oJKBsel+anSqDNvAdPFW0/CyseOKsumOitTVkxNCO6D8uC2uSevQ17n8yMaox1KA+2rIbGkb8a/GcOs9A/oBHx+y7p1aERBQzTaM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780516377; c=relaxed/simple; bh=lMdHmccPFgHqUtcZip0253tDRUzC2rxFG2WXTAelIvU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=o+FOPg3M4PAZbTwGEqqiPnH+bM1EIonpCZ+A9ypwRVaGtyT3BdsaiYdYndilQekSIK47i6vktioe3S/Jw/fSfLXYLXSKP+/nuLNhl7OniQwWXNpyldhZg5ZuT085P74DZKIhjc7hgOuamqQtxp06TSIRpSlrkA1sxfYfEAfiD3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hzdwy528; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hzdwy528" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8423f1e2f8eso3240479b3a.1 for ; Wed, 03 Jun 2026 12:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780516376; x=1781121176; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y9tKCNwD4GU9LX//oe1xKz7alWoDBMbIfrdtn1ITaOA=; b=hzdwy528BJ0Uw4CStKMLRKbrRFN3ro0m1TDen/xvZPa6a9cbykmniZPwijRuvyj4rP cF8yG77HxAYJ+i9MrQAMWwqLxwDvhwBQp/RZCCdwNMq4LZc8HWfqGxRV94wPU1drt3wI W36coWRiBBBpT/++GHGSiFsk/AYqM1xywt5fimt6uyiRturckxoCeB37yurzMsnhvYwE +TG3w6yZ4zO+iYLHeqaUR6I23UinnyWVNyR65jS6QXcVIz7I13nZsGVZ5ceU4slSA+0b OlQbMebYj/EcTM/O8z9ClEG8QDQFBhsV0s/ejNoZy6cUR9jeX5BgXCNB1z4csMNv5FHS gu/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780516376; x=1781121176; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y9tKCNwD4GU9LX//oe1xKz7alWoDBMbIfrdtn1ITaOA=; b=Rxq9DpA3o9FqK6CVZENhiomHWf8GA85JEdgfRCNGdnBp0OCnPhMylZF2AwtFE1aH10 IKZ6ac9h/bOQ3XWb4zc1WxSriaQEvc3NwCLXt/wePi0l9e/+NxPWg4F9zJ3+EGLEd4AB 9xFY4JaHUFupzXhJznXo8ch0smUujHgmr7SsVLejrCBp8nUTX8+KyKMNgxWyBM9O08zD bty9/k9+fe0LXV8jpMza7XDL4VZV78NU8FVtn6yOyaDtp3UljpvhZ7M9rI9UOpAiqq3U Fg2NHzkIm0OCI+RuxXr2ltj2vZAifplgLs6nBxdUYHqBJD6Cqwan/LgHWr3jUH1i4r8u ax8A== X-Forwarded-Encrypted: i=1; AFNElJ/Y1F+kQRaBsPfqV+jl+waf7Zf2cfRCaywVIGx1SnOjmLLFbtT30I7sWBCmmtfS41W4rw/S/m8Twq2Dn+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwccXyhQKT7snzgAMrA2xFrC418YepNLpdzgM/bRHXYdjvdtkYN 4xNLGPxqiLYL1j4EmNhddHi2xJkGvIL0Xme5SoxF0UhooE8T9S9fhPcS X-Gm-Gg: Acq92OFi9ItlAh6RzlfyJxtSPpmbCduKAgYrg2yoPMNyXZ3oY2bqAhp6MaP0SprgxAW SSHcFhQjMXimDDRG0BhrTEyWokblNT6FVm3e/lhbY+rVhJfi5jk+te9Q2CPXQQltlGBA6kiLLOg yr9ki2HE+YTrC6uZAloto31PVTQm41P/ZqfkJvhMd7rYiNgBqrB3FeYLhnRirHJkrxecZKptP07 3ovsO5ZnC4Wrw9Xf4db+wZJouIRyaXmNZ+1VHoO8RTlfdEzwm9s/leDU17b35Tm3jIK33Y0vFXv 719ythp6x5nTMaHUnLJpKjB4coBXqFJnVX23A5NzMCggT53EaJBE+BMkGk7JukAcuSgtxV8ASd0 7g7wf/aPuxWDTXYJmFhdUWMkWcGVJM7tgquXzPbsSboMEggO41aYnYxmw5ZZGW2AwvqUS3vGJrO Y22Lk1LHsPtk/+5t/4IgM6gjlVCnFmlM24EManHLj6YUO5xmBFCyqrc42NllZ18ydeFsF9PfBM X-Received: by 2002:a05:6a20:938e:b0:3af:6704:18ca with SMTP id adf61e73a8af0-3b4978d5202mr4940025637.35.1780516375878; Wed, 03 Jun 2026 12:52:55 -0700 (PDT) Received: from archslayer ([2607:fb90:7781:358:d68e:f592:7305:af5a]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df04ff24sm3169719a12.14.2026.06.03.12.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 12:52:55 -0700 (PDT) From: William Elder To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, williamxelder@gmail.com Subject: [PATCH v2] staging: rtl8723bs: remove comparisons to boolean literals Date: Wed, 3 Jun 2026 13:52:39 -0600 Message-ID: <20260603195239.200775-1-williamxelder@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove comparisons to true and false as they are error prone. Use the idiomatic C forms instead v2: Fix inverted logic for ht_option checks Signed-off-by: William Elder --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4cd9..c58bb4ecda05 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -236,7 +236,7 @@ void Restore_DM_Func_Flag(struct adapter *padapter) =20 void Switch_DM_Func(struct adapter *padapter, u32 mode, u8 enable) { - if (enable =3D=3D true) + if (enable) rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_SET, (u8 *)(&mode)); else rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_CLR, (u8 *)(&mode)); @@ -340,7 +340,6 @@ void set_channel_bwmode(struct adapter *padapter, unsig= ned char channel, unsigne =20 center_ch =3D rtw_get_center_ch(channel, bwmode, channel_offset); =20 - /* set Channel */ if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->setch_mutex))) return; @@ -847,7 +846,7 @@ static void bwmode_update_check(struct adapter *padapte= r, struct ndis_80211_var_ if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (phtpriv->ht_option) return; =20 if (pIE->length > sizeof(struct HT_info_element)) @@ -892,7 +891,7 @@ static void bwmode_update_check(struct adapter *padapte= r, struct ndis_80211_var_ pmlmeinfo->bwmode_updated =3D false; } =20 - if (true =3D=3D pmlmeinfo->bwmode_updated) { + if (pmlmeinfo->bwmode_updated) { struct sta_info *psta; struct wlan_bssid_ex *cur_network =3D &(pmlmeinfo->network); struct sta_priv *pstapriv =3D &padapter->stapriv; @@ -931,7 +930,7 @@ void HT_caps_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (phtpriv->ht_option) return; =20 pmlmeinfo->HT_caps_enable =3D 1; @@ -994,7 +993,7 @@ void HT_info_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (phtpriv->ht_option) return; =20 if (pIE->length > sizeof(struct HT_info_element)) @@ -1689,7 +1688,7 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeex= t, u8 *pframe, uint len) pmlmeext->bcn_delay_cnt[delay_ms]++; /* pmlmeext->bcn_delay_ratio[delay_ms] =3D (pmlmeext->bcn_delay_cnt[dela= y_ms] * 100) /pmlmeext->bcn_cnt; */ /* dump for adaptive_early_32k */ - if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done =3D=3D true))= { + if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done)) { u8 ratio_20_delay, ratio_80_delay; u8 DrvBcnEarly, DrvBcnTimeOut; =20 @@ -1737,7 +1736,7 @@ void rtw_alloc_macid(struct adapter *padapter, struct= sta_info *psta) =20 spin_lock_bh(&pdvobj->lock); for (i =3D 0; i < NUM_STA; i++) { - if (pdvobj->macid[i] =3D=3D false) { + if (pdvobj->macid[i]) { pdvobj->macid[i] =3D true; break; } @@ -1762,7 +1761,7 @@ void rtw_release_macid(struct adapter *padapter, stru= ct sta_info *psta) =20 spin_lock_bh(&pdvobj->lock); if (psta->mac_id < NUM_STA && psta->mac_id !=3D 1) { - if (pdvobj->macid[psta->mac_id] =3D=3D true) { + if (pdvobj->macid[psta->mac_id]) { pdvobj->macid[psta->mac_id] =3D false; psta->mac_id =3D NUM_STA; } --=20 2.54.0