From nobody Mon Jun 8 09:48:37 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8602248B39B for ; Wed, 3 Jun 2026 19:37:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780515482; cv=none; b=GhBe9UWfGjaBW60ZyWugkamIgIlUgrRhSAd8cOGFubbElznX/SpKtrNzNXYwMmT3ST3wpmZRukVMNevfODTfN4o7cm82Rp74HR7CCWWvf6XXD4vrcBPPExsdFRwAaEmOle7zY2+/PilKpjonYKGrto7F+364bxMPY2fRaSGqNBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780515482; c=relaxed/simple; bh=0ozitBAMrJvwv8hC/10hZPw5Q1GIwmuvAtXfFxS1UwQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PAjvDP4Enls+b5Z2pPcVvgKlbFJ4Y6bpe3xvntW59e5CVO2Vl9z5JuSMKXwHzALUcieT9dSJqmK8LnB0sHYF78RJYZLhTpycUcNQHBFIsdpERXiIV70IkNmRRVORVK2L+kH3Pj73aXqh/9sZVBU9MD+WtXVyx6znd27SudKSCIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R/CYNmJg; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R/CYNmJg" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8422871b42dso2632703b3a.3 for ; Wed, 03 Jun 2026 12:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780515479; x=1781120279; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bQahfrouqVjSpdsk806Jg+r95FmYpzMVjKE9AkAHTlU=; b=R/CYNmJg5gyC2MMR2UnBnQrBi+oqwIQ9xuGIwSCE8mL4SVxOHPBT6Zuu0YemjwExW5 6ELXCB8V41sGV6YbR+PWNtBamSxbKiWl1DgndPk2ghWd3oh9G/q1v4MO881vZLoO8DZX HLA3pKWk6DIAwKvDmsh5WqHvvXajS7lv3QCH+k7Xl0AWMznscjG0KohNsd07MtpYG4sb 8uI6NdBpCUQqCzCQgZxWJ5si2Ef6aZihjGJjqFgrfDJ3+J7mNMJrSXBba6prVOZG7fwJ /8J65zOqymMhszfu9QsOJxkRgx9sUX8ynZIY7ASKyocAFLBFN9wCkM7WDDeaHoiONQeR 4miQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780515479; x=1781120279; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bQahfrouqVjSpdsk806Jg+r95FmYpzMVjKE9AkAHTlU=; b=UVTob7LYrBKGEVWOuK3hSRixDYBH5M6BFzxP0N0KkLflRzYKCPOGu4ARX8hGTSpWNG lZb0t/oNNV7EwoSSAh/zAj2nyl1BQkPFEreXuRLXtGPpAalZQY2Tg7kctNGi57MhFQ2P GmDY3hjbfcyPxc+YSM0aPY3kkAQvl0tjJ6wPhwTlGk8nhbFmgiZfsQ71Z67rshhku0sw ORcqxls2XyznvqYWe97cdm1lb96iF5YxLjqtvRsTpknFfko5v2R1xMreYjAuf2vvvBUE QJcrUkc90rxYVmZDVUENI8cOPfiumGQSeNX2YvlYaU1CchCLTYb9/6JgaS+0PJsgnpyZ E5xg== X-Forwarded-Encrypted: i=1; AFNElJ9UP62nOJ+GKpHFkgZjpimiF/gB+dCBi3nQYPKJjKHMPz/ibdd/6cj/b/KfahvsgKFWEnoszqlnQRI1ERU=@vger.kernel.org X-Gm-Message-State: AOJu0YyrocHpMwLTrg9COi+xssHIQBxvs7hpQNqKiELnnNBbHL/eSwhB xjhlY/6+UgHx88/76xSJE9+MY1WlEoKFYfzhae/R1PcEc4VJ2651WbJrVeoR8ZyDaHY= X-Gm-Gg: Acq92OEB4JHXCoHd0qpKGoo17wELTbZhVT9ePIMscoOn2/NIkkQj2i1CutmvMgowb+2 08GN1FcFtzsAgU1I2zEs45LR/yuw0Xrk6eVLjMKrM3/9Z6JkFm90dkTCpflARktU9sZW9VxK1xn 8571pcehQCWMCFnmhQvoGJSsaHqLM0rhfRMSygyKgmaCin5s75iXJFVCqkDMQ6sLOY48u8iuC4Y 89YzZTEsGxbSUPEenEwKP6sPW+UNKGOXfEaL5vhY4rp+u65OmjGVtmNFABMsUTG7CAS2TOCXRhN jPXR6PirO7L8a98F8p/Z+OOPTf3sMvZ2kHWC8U1451KXBWIBpcBO/0TX9y2kNueMYerAdce4xVi cX4OjA0VvC3DOi6xMxnR0R26kJ2JWlf2JoirznQhFSFlF1uCQ69/c9qpUJiV7uGNaQFX9r4bl7w RIGY38MSarKeYgi5ACeZmpokc6/mnnmXzqc5O2ge2m/mgpBjQ3HRi9yLF8SuF5B6GOslRdJQ0a X-Received: by 2002:a05:6a00:1d96:b0:836:3f6a:3e77 with SMTP id d2e1a72fcca58-84284db2215mr4709363b3a.17.1780515478778; Wed, 03 Jun 2026 12:37:58 -0700 (PDT) Received: from archslayer ([2607:fb90:7781:358:d68e:f592:7305:af5a]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8428235006dsm4024314b3a.13.2026.06.03.12.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 12:37:58 -0700 (PDT) From: William Elder To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, williamxelder@gmail.com Subject: [PATCH] staging: rtl8723bs: remove comparisons to boolean literals Date: Wed, 3 Jun 2026 13:37:53 -0600 Message-ID: <20260603193753.195640-1-williamxelder@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove comparisons to true and false as they are error prone. Use the idiomatic C forms instead Signed-off-by: William Elder --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4cd9..c58bb4ecda05 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -236,7 +236,7 @@ void Restore_DM_Func_Flag(struct adapter *padapter) =20 void Switch_DM_Func(struct adapter *padapter, u32 mode, u8 enable) { - if (enable =3D=3D true) + if (enable) rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_SET, (u8 *)(&mode)); else rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_CLR, (u8 *)(&mode)); @@ -340,7 +340,6 @@ void set_channel_bwmode(struct adapter *padapter, unsig= ned char channel, unsigne =20 center_ch =3D rtw_get_center_ch(channel, bwmode, channel_offset); =20 - /* set Channel */ if (mutex_lock_interruptible(&(adapter_to_dvobj(padapter)->setch_mutex))) return; @@ -847,7 +846,7 @@ static void bwmode_update_check(struct adapter *padapte= r, struct ndis_80211_var_ if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (phtpriv->ht_option) return; =20 if (pIE->length > sizeof(struct HT_info_element)) @@ -892,7 +891,7 @@ static void bwmode_update_check(struct adapter *padapte= r, struct ndis_80211_var_ pmlmeinfo->bwmode_updated =3D false; } =20 - if (true =3D=3D pmlmeinfo->bwmode_updated) { + if (pmlmeinfo->bwmode_updated) { struct sta_info *psta; struct wlan_bssid_ex *cur_network =3D &(pmlmeinfo->network); struct sta_priv *pstapriv =3D &padapter->stapriv; @@ -931,7 +930,7 @@ void HT_caps_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (phtpriv->ht_option) return; =20 pmlmeinfo->HT_caps_enable =3D 1; @@ -994,7 +993,7 @@ void HT_info_handler(struct adapter *padapter, struct n= dis_80211_var_ie *pIE) if (!pIE) return; =20 - if (phtpriv->ht_option =3D=3D false) + if (phtpriv->ht_option) return; =20 if (pIE->length > sizeof(struct HT_info_element)) @@ -1689,7 +1688,7 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlmeex= t, u8 *pframe, uint len) pmlmeext->bcn_delay_cnt[delay_ms]++; /* pmlmeext->bcn_delay_ratio[delay_ms] =3D (pmlmeext->bcn_delay_cnt[dela= y_ms] * 100) /pmlmeext->bcn_cnt; */ /* dump for adaptive_early_32k */ - if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done =3D=3D true))= { + if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done)) { u8 ratio_20_delay, ratio_80_delay; u8 DrvBcnEarly, DrvBcnTimeOut; =20 @@ -1737,7 +1736,7 @@ void rtw_alloc_macid(struct adapter *padapter, struct= sta_info *psta) =20 spin_lock_bh(&pdvobj->lock); for (i =3D 0; i < NUM_STA; i++) { - if (pdvobj->macid[i] =3D=3D false) { + if (pdvobj->macid[i]) { pdvobj->macid[i] =3D true; break; } @@ -1762,7 +1761,7 @@ void rtw_release_macid(struct adapter *padapter, stru= ct sta_info *psta) =20 spin_lock_bh(&pdvobj->lock); if (psta->mac_id < NUM_STA && psta->mac_id !=3D 1) { - if (pdvobj->macid[psta->mac_id] =3D=3D true) { + if (pdvobj->macid[psta->mac_id]) { pdvobj->macid[psta->mac_id] =3D false; psta->mac_id =3D NUM_STA; } --=20 2.54.0