From nobody Mon Jun 8 08:28:16 2026 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA2F2BD00C for ; Wed, 3 Jun 2026 16:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780504283; cv=none; b=MApmyNhGzmwQyJaarj7zCXol4fsWyApuYC3rK32nxVmzrIIVGjA2BqgC0SECovoF7Wr4APMrbQ+/X2FLDv+6Gls9t/t8MeWYIwckyVC0qGsHXmCwRPReqkuj6ROEsrXe1gz+YHEKPXgJCoUqK3s/UyEh1nvwKV+3FHO7Ik8rqzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780504283; c=relaxed/simple; bh=kZuntGh7R1Zcir8T4NZB55Zh2HDLKf7Nfeerp7Ltv3s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JFj75ELr4ODpM+R1EmDvvFDC4WW3iV3daVtNDNcPif0BqZMub0QLJ16De65zosKqZ3c2dcsQoo8JoiZ+fu9tL5sbSd5ofx317xabUHMVx+1fL0rAPBMCEPHlBymgZavxyKbq/M8Hu+AiQfHjt+0Tpiear0UnviDSol+auh4zHvc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aOagqHWp; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aOagqHWp" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-5176bbb9384so21925281cf.1 for ; Wed, 03 Jun 2026 09:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780504281; x=1781109081; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YQQVNMiIZrFDCExxcCQvpDKG0jGJapLATHkxQnfkmNw=; b=aOagqHWpCflWnCYDngC5We9HU/n6EFr1hcyVGvdESqA71isKBVExDu2+5FpEfIiU/a hPCqwiEp1bIOjLc9TQNKyPBiNnGowQfIYaM54quUXJ0wFvsIZeST91tG6lKxmmEUgtQu U8/aGqi5UOXl2gwAV3Fnx6ryS0MTWITWw1FVh6Q7pZVm1jwJdYoCK8Al8htLTCtsggPq NooYJT4cQvlxG/0vj9VBvl371aFchqY0dnzDmcZoN/5Cpelzo5RU2cCmpJPofWGf5xls K1M2SJHnLoZjRv67FJByVxYlH+7RT4iH8pHi8jXvyR+O1DU55vnHOIS9lunDKqHynlCn KUrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780504281; x=1781109081; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YQQVNMiIZrFDCExxcCQvpDKG0jGJapLATHkxQnfkmNw=; b=T3EC8JDD3fg3ZNlxsiiZvXaeigIVV/eeNlNGRYngLGwSSOs7SLVJgIlE43nHya4O9D mYOxD6JV8aa6YDSu5cykyywZrsj3oYUa6SvOt11P+ZwYhdtkunA81hvWkUhT/eVbMygu vwpqe75ty3sVRBQeYZvKQK9/Ug1aPo/Dd1eMX6w6ME94cCKIPHujs5AREZwzjO7CMiz9 R5IJT/yRFPd4fVbZXpUomQDL5sOSRH2NFnQ0bUumzgHcn7XlFANLJswMvUJzcX/nkUH5 Au+p2MXAIVKmiAyLhK8tSwdb+MNU75wxPdAZD+KkIvq79V65aVvruIHQRrLcohp/8KjK CNRw== X-Forwarded-Encrypted: i=1; AFNElJ/J8y5mmfG5Vnc+4bwlKFV+VCaHQKuhdfxq5vr21ITZDWLOLoz0cjSOC+E5yhbqD0u1MGEVk3LLCgIQCdw=@vger.kernel.org X-Gm-Message-State: AOJu0YwZ5qFADlHD4T4gQvQOcJuJyk732EjazD486+DopJwlYWjoF6DD Rs+POhxduE8I93PEEjLRnIZsywvHuGA78Iey1AM9mo61t3MuTlr3Wjh9 X-Gm-Gg: Acq92OGsX3GphEeP0JGYhrRvF6laVxC/VrYeNVo+7Z1jtgBXtsHDrUJUh6fJRkj+qoh AtqeJN0wHpEFbnaFaqNk53ViL1sBqb4vFPnDMTBmGPrye7udzoAdGKSvMH0QnJs1kqW+8dn/bCV 96StozGPLyylz+TTdMSdvFgXHKjZYWB1NCrQco8/CG3NEcFDVG7Vj7c7+E2pD5xJVaFeUXwghY8 xwPrygWuzXJIZnY/QgqP59cSjkykoSWKdBr+okDkuiEzPzkfvYoQz7EgJhKINLbgVndZEzJ3Cmf kfGwPflu6Ygh9yPtO1AIYW64ZNl+9Gkuh7T7LdCAbPRaJmds/JyNnKKQNrO2G05yugyHM4VG7Dr vYzBEbHVMacHKtYE1cry93HBM4lqXvDvf2iCSwHNEf/sHoVGz/7NUGSA3UNWns6W+S3hNI5PrNs 1bsK6zMzb+QXKoRLu96mNNkNwXQvikY1SB+ymfPA1JSeg7O6Esb0Q= X-Received: by 2002:a05:622a:1814:b0:50d:efc1:841d with SMTP id d75a77b69052e-517786447camr58410201cf.23.1780504274255; Wed, 03 Jun 2026 09:31:14 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51775ddf0cfsm27179891cf.26.2026.06.03.09.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 09:31:13 -0700 (PDT) From: Yuho Choi To: "Rafael J . Wysocki" Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] ACPI: IPMI: Fix message kref handling on dead device Date: Wed, 3 Jun 2026 12:31:08 -0400 Message-ID: <20260603163108.2149359-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" acpi_ipmi_space_handler() takes an extra reference on tx_msg before checking whether the selected IPMI device is dead. The reference belongs to the tx_msg_list entry and is normally dropped by ipmi_cancel_tx_msg() or ipmi_flush_tx_msg() after the message is removed from the list. On the dead-device path, the message has not been queued yet, but the error path still calls ipmi_msg_release() directly. That bypasses kref_put() and frees tx_msg while the queued-message reference is still recorded in the kref count. Take the queued-message reference only after the dead-device check succeeds, immediately before adding tx_msg to the list. Fixes: 7b9844772237 ("ACPI / IPMI: Add reference counting for ACPI IPMI tra= nsfers") Signed-off-by: Yuho Choi --- drivers/acpi/acpi_ipmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c index 8f1aeae8b72e..79ce6e72bf29 100644 --- a/drivers/acpi/acpi_ipmi.c +++ b/drivers/acpi/acpi_ipmi.c @@ -550,7 +550,6 @@ acpi_ipmi_space_handler(u32 function, acpi_physical_add= ress address, return AE_TYPE; } =20 - acpi_ipmi_msg_get(tx_msg); mutex_lock(&driver_data.ipmi_lock); /* Do not add a tx_msg that can not be flushed. */ if (ipmi_device->dead) { @@ -558,6 +557,7 @@ acpi_ipmi_space_handler(u32 function, acpi_physical_add= ress address, ipmi_msg_release(tx_msg); return AE_NOT_EXIST; } + acpi_ipmi_msg_get(tx_msg); spin_lock_irqsave(&ipmi_device->tx_msg_lock, flags); list_add_tail(&tx_msg->head, &ipmi_device->tx_msg_list); spin_unlock_irqrestore(&ipmi_device->tx_msg_lock, flags); --=20 2.43.0