From nobody Mon Jun 8 07:23:59 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77493390C81 for ; Wed, 3 Jun 2026 16:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780504076; cv=none; b=f3sr5LSPt/4xeJLC3X6fUGbo9V0FZqZ4BdNVbLh3XS0pJ7hBkcVgLPv6x5Ml23izBLj02FBVIStufS4oviDLxuxHBnmQ/24iOr10OP1gp14Rz3n8yOHkGjO+06CmFOhMHBQe7gdPqUYbTsApQKjJpzrGsqCUoZAU9t0E9Ll/wMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780504076; c=relaxed/simple; bh=bZWAhI/SNWesR7lukDoX5NGLCgeYv7Rk10k9NwhATLA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=czYxcDMr1Q8FTtDIRHQzUr64gLIJHmzUwoYMTJuasYAciLTDta8I7M9o0Iy+O0UIJXJeS5oiVxBL+8u7azq/Lw6JkwKVaKD9FRrwsDMLRpI2FuHlPedbAXCtRqM1E3WGOuUWnmOBR0cXAZIdtHkU2f1TIdBsXzm5dXAe2H29n+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lAoOHqiH; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lAoOHqiH" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-842307472d4so1205114b3a.0 for ; Wed, 03 Jun 2026 09:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780504074; x=1781108874; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Pd5YhtxLNp2KnXGrb45Y+o+N5pgMe2J5d5AaYwVVkHo=; b=lAoOHqiHkGUQKO158ZG8BXYY7dp+xUKGtR0Uqd7YQ3hzvXx8cbmitf8nBbmDHGUO3X WyCHEdkkzlYQ9bm4hhSJ2jgxQyMFzh4egE6wSU4BeeTtf0++tTZHjpjceEYm5nVXzEPq 8s5mh9hCc5fC/aqtto6ILqCCRK5A0Hw06w6cT9A5GZvdxVMDtRr3onb1WslsiwKGrLWS SFH58u91/hd5ZmBxXAkOfeSZb9kT2qSxrG3u2f7zL/IueAtb12AJCucNLp5LoaT+0Yr3 AcvSJQPYP0upHmUbLwGjP6loiveY6Emstqzo9CEgm+aHFTxckrMN2xzHZBSO+NaalPBl pChA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780504074; x=1781108874; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pd5YhtxLNp2KnXGrb45Y+o+N5pgMe2J5d5AaYwVVkHo=; b=itgcQhVxhHIHlovu2afpqoVBmUct8tWf/FkeZsuUbILIYuWow2Te1FWOlcmPGAHcVy fig5ft2HiAUqehgv3p5GcLQV6d82HkpEwLAEwxWBGLHf5GoWrN6shGWMC24VxmIzG7oj ihK2dwZu5Zm10W7GP7qutZcFJHm9SIRPhVozEjaHk/tf2CS1DHQ8IQqvnNLSXxrmT2pw J+tJNzxSejOsCmEJqVu8q/K/rH05Zb2XlNZ0GRmT7xdktdLCG4T69YK5BZKTEiAwRWUm /84wGgKGk9cJ8m02yJBuo9HT7zVYO2KyXBYOdq9+1naELXf4SLpje0JgE1pkoWeKm06r vTCg== X-Forwarded-Encrypted: i=1; AFNElJ91SmCWd3qX+c0lAwQPhpru7dTOSucp5866NFYeGri3TYU+gHEX5P3gEBybLD1ooA79H5yGzcdS3G/uaoM=@vger.kernel.org X-Gm-Message-State: AOJu0YytYQXh27aafR79CV0RrsP+R2azd69nkLlFI0Ld2YbmvEkTWkCQ UQ/7iYzOy35CPULxTjlf9P3JrJeS13BY0aW8CWR7wef9wrsUhw1e8x6Z X-Gm-Gg: Acq92OHMGomb0eUpvIyQyg6xYoIB1I+IBQgzP6TCDI+asrObvrK2V5DuPc92r6l8Xav 9qh4/XxD8zhCi0JjcH+Q8lQhg2MVDFy+QLrwpFjvPUSqKRHHgUBMH3wBi1px832C2g0S19pOYt2 MVrHIt/WrDYJivyBup2k4WEUxkMwr2gIVOIbinAndcTD0KL+KBp7G3S/BNDb9Q2hjJzgSNxdLF1 LlSTFBWRcac9j/c6vKeh6X76x1lRnY3v3gz0va9gXCBlVGZUlVsojf1Zns8fNxMqaVMTHR9babs dExkEMTi5wnhEdAy6UZjgFsSLpOcL7p5Ia8mOYTGnn92FlNnIO21T8YTtzuBPvY7uAXekDKyAyp WeGPQA7I1gAHugpt4CxUEfytHPfD23LNRI2GGQDPqYp0NVNsAqK9dQLLBor1rkd6QhzumIFw0aA 9enRFed5k90LX9gFWXhT56FVzepKrkEC27hKXw8tKBNJA1yhQWb5e3tpDNIOu/cm49WlTkHhsZX Qml7nvoqzo= X-Received: by 2002:a05:6300:67ca:b0:3b4:813d:dae with SMTP id adf61e73a8af0-3b4978049femr4892709637.16.1780504073819; Wed, 03 Jun 2026 09:27:53 -0700 (PDT) Received: from cps-manycore-1.. ([147.46.174.222]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df0a4e59sm2930976a12.16.2026.06.03.09.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 09:27:53 -0700 (PDT) From: Sechang Lim To: willemdebruijn.kernel@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: horms@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, jakub@cloudflare.com, aleksander.lobakin@intel.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net v2] udp: clear skb->dev before running a sockmap verdict Date: Wed, 3 Jun 2026 16:27:33 +0000 Message-ID: <20260603162737.697215-1-rhkrqnwk98@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On the UDP receive path skb->dev is repurposed as dev_scratch (the truesize/state cache set by udp_set_dev_scratch()), through the union { struct net_device *dev; unsigned long dev_scratch; } in sk_buff. When a UDP socket is in a sockmap, sk_data_ready is sk_psock_verdict_data_ready(), which calls udp_read_skb() -> recv_actor() (sk_psock_verdict_recv) to run the attached SK_SKB verdict program in softi= rq. If that program calls a socket-lookup helper (bpf_sk_lookup_tcp/udp, bpf_skc_lookup_tcp), bpf_skc_lookup() does: if (skb->dev) caller_net =3D dev_net(skb->dev); skb->dev still holds the dev_scratch value (a non-NULL integer), so dev_net= () dereferences it as a struct net_device * and the kernel takes a general protection fault on a non-canonical address in softirq: Oops: general protection fault, probably for non-canonical address 0x1010= 000800004a0 CPU: 1 UID: 0 PID: 1406 Comm: syz.2.19 Not tainted 7.1.0-rc6 #1 PREEMPT(f= ull) RIP: 0010:bpf_skc_lookup net/core/filter.c:7033 [inline] RIP: 0010:bpf_sk_lookup+0x45/0x160 net/core/filter.c:7047 Call Trace: bpf_prog_4675cb904b7071f8+0x12e/0x14e bpf_prog_run_pin_on_cpu+0xc6/0x1f0 sk_psock_verdict_recv+0x1ba/0x350 udp_read_skb+0x31a/0x370 sk_psock_verdict_data_ready+0x2e3/0x600 __udp_enqueue_schedule_skb+0x4c8/0x650 udpv6_queue_rcv_one_skb+0x3ec/0x740 udp6_unicast_rcv_skb+0x11d/0x140 ip6_protocol_deliver_rcu+0x61e/0x950 ip6_input_finish+0xa9/0x150 NF_HOOK+0x286/0x2f0 ip6_input+0x117/0x220 NF_HOOK+0x286/0x2f0 __netif_receive_skb+0x85/0x200 process_backlog+0x374/0x9a0 __napi_poll+0x4f/0x1c0 net_rx_action+0x3b0/0x770 handle_softirqs+0x15a/0x460 do_softirq+0x57/0x80 The rmem charge that dev_scratch accounted for is released by skb_recv_udp(= ) on dequeue, just above, so the scratch is dead by the time recv_actor() runs. = Clear skb->dev so bpf_skc_lookup() falls back to sock_net(skb->sk), which skb_set_owner_sk_safe() set just above. Fixes: 965b57b469a5 ("net: Introduce a new proto_ops ->read_skb()") Cc: stable@vger.kernel.org Signed-off-by: Sechang Lim Reviewed-by: Eric Dumazet Reviewed-by: Jiayuan Chen --- v2: - add blank lines around the added codes (Olek) - use generic block comment style (Olek) - Cc: stable net/ipv4/udp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 0ac2bf4f8759..70f6cbd4ef73 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -2011,6 +2011,14 @@ int udp_read_skb(struct sock *sk, skb_read_actor_t r= ecv_actor) } =20 WARN_ON_ONCE(!skb_set_owner_sk_safe(skb, sk)); + + /* + * skb->dev still aliases the UDP rx dev_scratch (its charge was freed + * on dequeue above); a sockmap verdict program may deref it via + * bpf_sk_lookup_*(), so clear it -> bpf_skc_lookup() uses skb->sk + */ + skb->dev =3D NULL; + return recv_actor(sk, skb); } =20 --=20 2.43.0