From nobody Mon Jun 8 08:28:15 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 875DB383C65 for ; Wed, 3 Jun 2026 14:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780498452; cv=none; b=XSBAvEIbsquE7Q7NFfj/ivres7VplGUFicTwEKB1JRBp6tldJWtzVH9z3BLcFTjLnhcx6vucsxBdNC4UKSBegdv0eVPsP0L5oRNR3p2vmO2Ke9JLXZgspziyOWIpwkgxR3tByPoVCdFsD/g6c49JzzzWmhnee8gLgrvXwEc5QCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780498452; c=relaxed/simple; bh=/S9s8ZKcdS7oOvv7a+3aLT/6rnW3bUSJTq2lThopnqk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rKzRCWcGIcRO1DcRA18DJh9Gwl2bHMfzVBf9Wk1v7Qr8X5OCHcXdpnnP/91vLnmjNHo6L2nNQaK6G+e/yLciVX0heF7Z320t8Haid4vRymBm4dgKRFnmhaG8Evi9BWtaKq3yer/N4Kl/PdDumpQcyBFVZTHwRzjwNEhsQPnnKn8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qblsZ8wg; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qblsZ8wg" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-7e2cb01a974so48489797b3.1 for ; Wed, 03 Jun 2026 07:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780498451; x=1781103251; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uHFrxbCNBMrYadUB6FYLUTtUp0U5b5/I03Sahx2pmHQ=; b=qblsZ8wgeTChkRdUJtzr6yg55SW8OrevFl2Sb2+7okPtr4DgtB159pvbELIvUro0r4 GZn6EAW0nHRDDS1QInF9Qq4g4Ohm7Abo9oABWLRku/JHLIL/L6bUQg/D7wL4bI6jXdJV o9QAWKoRkXO7PHkqmd9FcTHsTgB1o+c1aqPVEKamINsQLjXm6AUBMMUxvlNWn4Tv8ctg albl3V14F2ZMlF/7By1ncn0fQ1o3SVQJ301eOOtDzdC9WI2pmyeUP9e8B+hbTmGwc7Pf AcLzWY1W/XiHA1d+lJcjmDNJi3lsB4P6Wx8uqydJDKKmWm1yBWZGY2/VLtY1hDDgP34U dvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780498451; x=1781103251; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uHFrxbCNBMrYadUB6FYLUTtUp0U5b5/I03Sahx2pmHQ=; b=KAp8JGt+qEK+yQdXVVb+xj4UmTeVKIX40ZdHIv2cAZIchDPStKDB9JHqhPqjYXjuof TMVX52ZE905h7lY9dXhFM4+grEyHFyKHsKyc4J0QRtwgioa4hJfmUUszo1SLEcfwBawN 0/77ntJfOIax76hJ6YDwVilPNhbapR/cdx6g8IuI+3SzAaThR3YAz2yh5GxICFBZ0Mfp Ty17kY3b4Qjj+LCqMEfHSztCpLoJIWysWGiX76IanVWhNEgTJjUXOujKTdWvMGB0yvo0 LLtTCzJWafl2RxS3gz6NR19YXR6QGvk6T49HMHiJmmZuw8weGT9CC/0VgngdspyJyAPr cSQQ== X-Forwarded-Encrypted: i=1; AFNElJ8edowu0ZRzmnx4nHrOuUApqZS5LZgyrJPIjd7Ukh6HF7bGk+9prQLyXuOH7VONN8ZLNoS3XDWZFwjxBzM=@vger.kernel.org X-Gm-Message-State: AOJu0YwSZY/0IZ3V2qeWiwgrORFkYRYhjAjjj5l8FT87qYV4Qbf9k57E WYvJ3QCyLUUTqx9I4nBYus8mAoXIY4QBs9vT1quw7/j/8o6be3188ipVooYYzZv2 X-Gm-Gg: Acq92OG7Zf39i5Z1FqheUib6IjihuwwdBZubhXOMQn4iMqUa67TpUaKfyr68EdLjRy8 anH+kfcd1HekORo7J3Y90+RDBweYsZD75JOQzalG2HIWOREfsMiQbtrQpy04X0U6VTMvyxtZe7b ummsZdoA/Z99YeDvBuGC8HPqCSfcSFkbq+g4iY1Gap36iQRfuhBmREC57HUmFHoA1Xfff/G6wAX wuSgJJ4tR0GjKvS3L1UBomOAHzc5KlMeVC/Jwqjr38BdcDT3EKULlbk+96R0FftQySw5Psx58R2 /sv+WOmbx5rOkGqEmRIHaO4QkaVWDUvpcvEzx5h9BlCQJxK6/ZfLt9hf+UxS7OFFnjHKLUbyYp2 8UNuWm9vgT1fTd/ty/E91I0kyQOqL0ScHHLFTBp/cqsRFnHMLS8vNsbur6T/Wdj0nlKV8WFk+Ga 7mkGL8JajAfLE9FbjO8kv4KAERl5RaUHBHX4RTNg== X-Received: by 2002:a05:690c:6902:b0:7b9:39f:62c8 with SMTP id 00721157ae682-7ea49d678bamr37294967b3.27.1780498450376; Wed, 03 Jun 2026 07:54:10 -0700 (PDT) Received: from i-use-arch-btw ([70.158.100.171]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7ea2409a21fsm17836967b3.47.2026.06.03.07.54.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 07:54:10 -0700 (PDT) From: Maxwell Doose To: OGAWA Hirofumi , linux-kernel@vger.kernel.org (open list) Cc: Maxwell Doose Subject: [PATCH] fs: fat: inode: Replace sprintf() with scnprintf() Date: Wed, 3 Jun 2026 09:52:21 -0500 Message-ID: <20260603145222.59012-1-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kernel documentation notes that sprintf() is deprecated and unsafe. Replace it with the more preferred scnprintf() to help with hardening. Signed-off-by: Maxwell Doose Acked-by: OGAWA Hirofumi --- Test compiled only, as the only functional change is the addition of bounds checking. fs/fat/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 28f78df086ef..b032bbc6855c 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -1786,7 +1786,7 @@ int fat_fill_super(struct super_block *sb, struct fs_= context *fc, */ =20 error =3D -EINVAL; - sprintf(buf, "cp%d", sbi->options.codepage); + scnprintf(buf, sizeof(buf), "cp%d", sbi->options.codepage); sbi->nls_disk =3D load_nls(buf); if (!sbi->nls_disk) { fat_msg(sb, KERN_ERR, "codepage %s not found", buf); --=20 2.54.0