From nobody Mon Jun 8 08:28:15 2026 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B43F33970F for ; Wed, 3 Jun 2026 14:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780498402; cv=none; b=hfF2b7BIGhJ7lYP8Yk/LER+/M56ifZIJXrGWe7YDL2YqFGKsvZoGl5tnCyFIFdAWT1K53kWSWT7FjSU7zidVTMxAvzYeRyCratyvla/aFOE+/kG87fHtLereowx95/c96hbeIA2kxUEW9MOX2VjvqNXXWBM0cYH++BqBwnner0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780498402; c=relaxed/simple; bh=fl0AOOMrv64Vs9g9S0kA7ww829mKQewnMQR0lDfBafQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ico5A0xXHQR/8WjLFm/DFmn5iVTCWtWJnrBe0IX0idnS76aWbGluEl8/D/6f7Rh+lgj6jh/JVJQ6dwT/uU2qZ4ePquUqmDLf+iaMln9eEFvyJBn6u+DWEJrfr+xyfAjeROVm5l1N8Og1foNNelEiEqnbCMxxUKVaroDnAboh6jE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m6M0N+uo; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m6M0N+uo" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-7dd3f176f84so74720667b3.0 for ; Wed, 03 Jun 2026 07:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780498400; x=1781103200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kkL0W1MPhO9S/Xxf8ecAvCJWGs8h6NKPNpnFVtd7Rpk=; b=m6M0N+uoEhg9DVFmX9q3bLn1S5To9OGJeTU4sEnj26oe5oG249g2u6fMJNxuY7947d JRpGj1sFjKioQpO/dACScMhGKHHMyvDhtwVdeeNx7ElVPWT55HcYXpEKWfdBkr5v4nbv 1aq6NqxeV/YDOhChlftBNGboHiD5RQ3z1LD9riPtR17bQnfCkmvnSDdJMMIAl3DYoU9O JYU6WAf2IFRvOMOsvpIl0wHJky6/FkEj9zs4/oGwBZQARibdPiYlA/7Q/Mbzg19aD8N7 jT0RglIThw+9DxWyK8yJ7iZ8giHC82UxawrlapyYFe73yzmFjhFQwlAoVds1kBIYYnB0 Vw6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780498400; x=1781103200; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kkL0W1MPhO9S/Xxf8ecAvCJWGs8h6NKPNpnFVtd7Rpk=; b=iMeCbTA/OtnwkfaPM2jYVFzsxy0AiJJNheSmeXBPwThQz/TqUMtrcEFXufq2XnYPon 6ys/o+vnzyuLusHu1dp0BUzmUElGJLYptegUgtz3aoyDy0RJBLs3Kp48whQjON/MdTBQ 9o543YAiY0vytgz4hcD7582HmpVMKoUdCFYYffCn5EgmQ2Y1fpsz1sf3Ny6OU3KynHZQ ktWUJLpg35r1Wlat2fDyPrzzJ3mPx7Bq888VT4g/b9xEf+41HPc5vzRl90Wt9qk5/K3O lk+nQ7w4VC1BQiBpqIyIHx+78Iwk4H1/ZntAkcJMjTfKmQl8MxX/xOo8dqrtgoes6b5q HXRQ== X-Forwarded-Encrypted: i=1; AFNElJ9nf530WNbq/n8OSiT1zIDYT60JTd8m7gniA0RXkR2r/HuKOlPdz+o6krKMGU3LY2fy2+p0cKnG/yc8cH4=@vger.kernel.org X-Gm-Message-State: AOJu0YxIU3G/XhSCJj4J35KopI0spjrltbSUcxk6wouFc/tV+FpFwdC5 YVw9UJE0WmjcjC/xFWDsU945wX2zXDZ7LKjpuZSu6fWA/wNzbOIYIl4/ X-Gm-Gg: Acq92OFfzQZZztOwawFVZnAvravLxMg0u5w93+kMPSq0BZraamQvMdug9w0hbx41ltt f9iS22sUEW5u2CuaWW5BMpMU8UksCfIMPOVhCmouCJBrvWDJcZlrIED3G7OZWEsCkhBL4ww+Z3/ ZlHehNULcoT7QcQAT1jybSUaV0Kl3XFhAdHBjyiJITEo+EAK4d1z7XF+FNRL/mup/dCDyZrJNY9 pSWFziKNfM0wd2l/dLuW9JaA1kon0reTpUoTrxcqmhLfurVnX7nTE2qXoTJsMa7vk8pD0Kw5dew Jz/oWxnyaAGFEPZVZovs0W16iVNGVx6PK6TzcRBIUuyNQNv5x6a1v7riOZipNmwhV0aaEvQIIRb CjpUT5OrQcH0KrNns9A2kijOq03AIMB4FiKIb2Der6bjhhCmLWCexY3Y/czI5ztH4//i6cnNxAl wTMqJSS1FDXd7BPffWkv7YLcB3bAxgTfZRumtWcg== X-Received: by 2002:a05:690c:600f:b0:7bd:8ce4:92c with SMTP id 00721157ae682-7ea49b6fb00mr33679257b3.31.1780498400350; Wed, 03 Jun 2026 07:53:20 -0700 (PDT) Received: from i-use-arch-btw ([70.158.100.171]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7ea2409d513sm17985957b3.49.2026.06.03.07.53.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 07:53:20 -0700 (PDT) From: Maxwell Doose To: jic23@kernel.org Cc: Maxwell Doose , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Tomasz Duszynski , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] iio: chemical: scd30: Use devm_mutex_init() over non-devm mutex_init() Date: Wed, 3 Jun 2026 09:51:33 -0500 Message-ID: <20260603145134.58956-1-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code uses mutex_init() instead of devm_mutex_init(), which is incorrect as the rest of the file uses the devm automatic resource management API. Fix this so that the mutex is set up in the same way as the rest of the device data structure. Fixes: 64b3d8b1b0f5c ("iio: chemical: scd30: add core driver") Signed-off-by: Maxwell Doose --- drivers/iio/chemical/scd30_core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30= _core.c index db5cc295aeab..f00979c0c196 100644 --- a/drivers/iio/chemical/scd30_core.c +++ b/drivers/iio/chemical/scd30_core.c @@ -714,7 +714,10 @@ int scd30_probe(struct device *dev, int irq, const cha= r *name, void *priv, state->pressure_comp =3D SCD30_PRESSURE_COMP_DEFAULT; state->meas_interval =3D SCD30_MEAS_INTERVAL_DEFAULT; state->command =3D command; - mutex_init(&state->lock); + ret =3D devm_mutex_init(dev, &state->lock); + if (ret) + return dev_err_probe(dev, ret, "Failed to init mutex\n"); + init_completion(&state->meas_ready); =20 dev_set_drvdata(dev, indio_dev); --=20 2.54.0