From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DAFD3B95E3; Wed, 3 Jun 2026 14:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497949; cv=fail; b=d6+ayRK2LYhqJbpJPp8Li2vtkVtcx4l2eyeYzXSnlPXOCGZQzkXDxSYsOYoJ6IR/WZXC39sTw4DH9pyQqP311q0SrNhLOUZr7yirvhlps0l/fQPQP64iAVLfkK31HobF0Sa3F/8puqTNePhMuF64ajP80OoQLpx2VscQvRqQtrs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497949; c=relaxed/simple; bh=XQIA3Y+Bgbhb8o6J1e9gbKBO6HzEWGK9St2MPr78I+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GZWSpNj0AdIQTajea1xiYDKHGlTkla+pEhRAdJW2Z46apoFS+J2EeKlDpronJPjqMnNKOiHWWToRWflI04YZKVO7w0FB+zfyEGNvoOXNDflSTg+UmTPp5M9n+oKB3niy1rbATPy5lzIhW3eUtiUx0fVheSlG/p1AigTpWdv1MM4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=GPyvHUIP; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=v+C+aB8Q; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="GPyvHUIP"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="v+C+aB8Q" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653ESsrn1297281; Wed, 3 Jun 2026 09:44:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=9pEW5LtBhGHN8EXN1xMBwok4xpXWMgfVn8jgAFQRZbU=; b= GPyvHUIPbPSTgAJhCsdBsWasnu8W8Fjch4tjIXIM7TTNsscYXCZG6YAVsaiby2hv +2hkPhaizETIqGozWb4Bg+yM/Mynz/ngv7KoNrR8EOw8/FPB3gov1Fs0NucwmEc2 6jNKOx2t2w9bnBDmI5H54GB4/zZAY7btOIiJ0Bry9HirffSapu4VcRphmm6eRi+v zQSCF3gad6wd93Xnsz1tk990uc/BYkDT3rTEabcncc9qymYgU6OGQIzq0P9s4S9y c2e8a/7L6hqhdy0ceYnr6CUXn2Z9S5SuLYBLvQL+EYaQOSeyPIsVVmryXYBXlBSV ihHrjfHadzP9BkRgBL8pzQ== Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11020123.outbound.protection.outlook.com [52.101.56.123]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa1695c-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:56 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pJyVlKKJRdKltB1syAA/BmT1kYleMyoW/Hzs3w6YEaBLvB9f99ELIK46DcPeyAAit2Q8WoHHA6gaY8w5gc/zNz6bCXPDsmYiFXQqT52kbHoMGUirxs5yca0bvkePRXU6pUj2L4HTHbF1x4sOeNd9bLNFKXfodENTWtDbgnJ3vWFK36ewq0LmT5Z5gQKQQqLpQ3OFHCE7Tc5Y9Ruy2F6DiY1KzMsFVYT+af22P7RqUV4XbW5rQpBAt+eGGP3wxgUt/0xWXPYg4kEBo6wA5RoDQuWlZWjm0r+wf4GROx0XWh4Z9JTyqyO2ex8gNhTpvBip0DPZ6hiCsCwMvIRSTn+tOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9pEW5LtBhGHN8EXN1xMBwok4xpXWMgfVn8jgAFQRZbU=; b=bkaNpV1XmTPpN6dMnpTh6pKq3deazvuChvVr4kVAQ55AMxjG7YT2TNyTDhO+G2/xDsk61s2VSAt5GboBZW/u3Vnazc2jQGfUHNLlJQfZlc7CgX3iqFE7/bWQJqOi2BXAf1UodI9lVKOUYijdP4l4E1ZquDfRd8xbKO+Q9otQi+zJdQvwOJ2KLT8L5C7ljPa9Z28aT5jq+D5VY42/uOYkTF5h6Id4iO7BTCThSjlKr3+TxL0KpLVEZKEx/nPeQSJ/Mo3IrCItvlKpXwAJo7qLeLZDfXrweZdxxDELxQDzY1EaQyBmmFNPmc0CgjK0gDLTDpfprPtpPLQ6ItYr84ba0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9pEW5LtBhGHN8EXN1xMBwok4xpXWMgfVn8jgAFQRZbU=; b=v+C+aB8Qh/w7KBwI6/Hu26Yo4OkWDG58As95U0ea1HecZ4saajxn71sghbIkh0HYvBgoyVh4Pm/Kd7s03j+xL49bJTOYocllm1vHNlgLPW/lCbwMBl9DL/qLptlP1TAVPRLSGZo2uqst0lfmA/zz+a+J/E6a+3dtoPfg0MqMSVc= Received: from MN2PR07CA0024.namprd07.prod.outlook.com (2603:10b6:208:1a0::34) by DM6PR19MB3932.namprd19.prod.outlook.com (2603:10b6:5:22b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 14:44:50 +0000 Received: from BL02EPF00021F68.namprd02.prod.outlook.com (2603:10b6:208:1a0:cafe::a8) by MN2PR07CA0024.outlook.office365.com (2603:10b6:208:1a0::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:50 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BL02EPF00021F68.mail.protection.outlook.com (10.167.249.4) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:49 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 3F61A40654F; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 028B582025A; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 01/10] soundwire: Always wait for initialisation of unattached devices Date: Wed, 3 Jun 2026 15:44:34 +0100 Message-ID: <20260603144443.593230-2-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F68:EE_|DM6PR19MB3932:EE_ X-MS-Office365-Filtering-Correlation-Id: badda406-1bca-4dc4-ac88-08dec17eaa44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|7416014|82310400026|61400799027|18002099003|16102099003|22082099003|11063799006|56012099006|3023799007|6133799003; X-Microsoft-Antispam-Message-Info: GSRGzP4Z/3JjaL6Lkr6qKqfdeQ0okHpGLyiN7Dsd1ZETKICyY6tnuJkt4Ow82Gn931J35vGxskq1bbm/XUyusdjW9mEVPYANL5bsZgeoWs4KD2WojlPFRR/7oj6ab8C9EQ7aRwvoRroJ+47eLTp9yE8dQs8APeykcif8oieyjHIdypLEnz1dAuC6NrX146tpCAXcJ3szHEk6PgF96dK46rSaJeMAIv1Rs8gpK+M6UIT6Rdm8AqwQWyzwxQkph1rPw5vE9hmNv/qOjacypysAp6MemCH8y62E0Vl/2mnx9kNpQypD3WDK3xDL/I9utNKz9vI1c9Y/hGhomDMKiC03xPyHxbsqgwj4mxHnkDUsoiKOuXYLlJjguixOPsh+TUoIAzO2FOtY3wUdY5c9OW6xcBKWkn1cHB+JxHo2LU39M3BrkN3Rbiktbf7YSUm/9wqyj6gDzyzc8QZzVlFlDZMVCfZQLjg7KPBBzUdpaJ07WlVxel92YjBIK2FhDsrJcQyBw52xOVqMetrKcj2QCQzKx6z3j4wwse3iZ4YxSzejqG7Gw+crkFgvKqOBR6xeD2KrXSfE16RhZtRsxJK3tHtQhVPRvDhEWgOk/zNUMeYC1EWobfGlhc6wghbi/OYB+xwESaxM/hAIe+tseldVK7c7VRB+eO25oKxD049HF6jTlUeTLfWJ/PO4RkcwyO9gdjpxSSBmaPv3KgbSLopnT6D6mnn7N+gG58iPviVncj3Maac= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(7416014)(82310400026)(61400799027)(18002099003)(16102099003)(22082099003)(11063799006)(56012099006)(3023799007)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1KZABtse15kn7U+Vh+5hgZtLDkHQw2b3U6UGEOODlR8yvZ4WG7YPrJNIQBApfEmnPfYRBQfgAII9K/ANlvwwwbLRGXPp0zDaHIW7fRXsXcCNyLuRACasDr8YzZ6vMGo62+E6Uhi0PcbcVjaoil4Y+vmJ+mm4wwtb+d7Vmi7U0pWV7tjunH2KMDqNBU9+CvDlwQREtHGUka7z8KkFTxzrRzbocaDmYvLFnN6tl0IHRZBgz0TG01J8+8Y/qQ5Dc+qZJRJCn8KIjVLZV62IToA0ZLnoeUyKGlbHk5mfLpqCBnYP3SubLbxg6amHJtLTJzlgjkq6D6heP+gXGMoSHJVdoBSES+B1XaL+QupZQBl+McfqJy5JVxFv83a3jdpipQoqNOzT4WqV4wyiigmGFZYYgPtJ3QvPW3+4zvwAy3SnfiNpZq/AFpYlrzlmMdBDbNn7 X-Exchange-RoutingPolicyChecked: KTCoyTqQ0BoUsv9x8pAcAGeR3h94C2HgeQPEgQmrRABi5eaAyofj5BfCfU/qniWG1cDfNleXCJSSlOaz/se3WLX2VJ1zGvNEZjCoz/yUA5Bx6n20HgKqof/bygG33VxlaEmbUl7LxFomPuqGTdHt7kglCusx1btJBppWpEExOhfkz41FoqpJA307Lx4cz9kz7ZHWNFw5I/IRyu5bdqKq1qZa/iKOLzTISBBeKpnNvHXuW2KpReBWeUcftj64IdRKyk4YJrQM4CxpYTQ0YsKzy2fue4jIbY3qsRFHC6onV9/qwPktK4n2w5SZ71oY/2qaeJHqMnSgaPzeT2AUiIBCmQ== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:49.7802 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: badda406-1bca-4dc4-ac88-08dec17eaa44 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BL02EPF00021F68.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR19MB3932 X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a203de8 cx=c_pps a=Ww/eyc9HJI3lJRrv7Oj56A==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=CWTouP-59cMm0TkFMMwA:9 X-Proofpoint-GUID: IhEi0yxUqkCO5tcRclbxQHjXjCxJWDPL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfX4sutleZt7nGf izdI3dLaWKSPaAaiyUoB283GNmfvb/txi5c/FXWHvS4NwzcABiIaT5hpe/AvKd46ORtUKbFgaom jCizMRx2t1iyo4d3jd2EtZXKJaOu7Dl825w9YLXNCd0jv+ht/lG5i7V/zyUUTipxXQgGGlHS1GK wtfnRLprsWQTD67Zyf4fFyks6qSjsL/lDZ+AVCvcqRd7MELpx9D+JPTxdVO6j9+8lGivda1jmVB zPGHykdaD70N/++8eyvePX6TGVp83V0S3yuD+0ML6mygX7ATx7izEbzzmmLWiLBHuwx9CEte5BJ fXKkZlCmAGwATXd/FnvnAZVUqVP2G//gUFNpbuE8Rg24ALUVNgsIeoL4lGJzkM4inypawE33aQ6 ZDvHg6zPjZqpOIgWZPeyUEKvk9h0VHSHxmvqbOzi8jqtzoAZCG/3KfAkwiztYgeuWyholtiNT3h MmaJJTOVKQp9U1ZL+hg== X-Proofpoint-ORIG-GUID: IhEi0yxUqkCO5tcRclbxQHjXjCxJWDPL X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Currently in sdw_slave_wait_for_init() the waiting can be skipped if unattach_request is not set. Doing so was added in [1] likely because the core used to do a complete() on the completion so waiting in the case an unattach hadn't actually happened would block for the full timeout. However patch [2] updated the core to use complete_all() which means that the wait_for_completion() will now simply return if the device is already attached skipping the completion doesn't add much. Additionally, unatttach_request is only set if the host initiates a bus reset. However, the host doing a bus reset is not the only reason a device may be unattached from the bus. Other options could include the driver probing before the device enumerates, a sync-loss, or the device itself powering down. Removing the skip using unattached_request, doesn't cost much in terms of efficiency and allows the sdw_slave_wiat_for_init() helper to be used outside of runtime resume. [1] b2bd75f806c4 ("soundwire: sdw_slave: track unattach_request to handle a= ll init sequences") [2] c40d6b3249b1 ("soundwire: fix enumeration completion") Signed-off-by: Charles Keepax Acked-by: Vinod Koul --- drivers/soundwire/bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index ea3a24f805c00..b7bdf19ebb42e 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -1386,9 +1386,6 @@ int sdw_slave_wait_for_init(struct sdw_slave *slave, = int timeout_ms) { unsigned long time; =20 - if (!slave->unattach_request) - return 0; - time =3D wait_for_completion_timeout(&slave->initialization_complete, msecs_to_jiffies(timeout_ms)); if (!time) { --=20 2.47.3 From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DB993B995E; Wed, 3 Jun 2026 14:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497948; cv=fail; b=RrSsHmbtvMvgrFD3twiZrfAOXsNqb/ivd3WTa2S4IbW/W2KvVZB/bghYlfjNTO6XbUeLyN7RcLLFuSwm5aeytREvxqp9hsA+GQNE66+1/Xp/zhq9M6ylI24JlvEK4xNWmbfKI1uJYAgLYH/NWI1FBGhkXRkbXLA/P52hhN3EmqM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497948; c=relaxed/simple; bh=6M1Y/aRpeEb3qALn7R/lZmqMrri6AYCx4MbvCasPzRI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PnEBidYy0cDFv+Jwv+fGtb/QH3d0zS8DraMGp3VY2jKvHaxxUSVIOYZC8HKG/MIPzTGJlweF4s9sExRlB6FTMMKeVsYZyXS0HVE2lnAoSn+UvQ3u4aJfs6C3AneS/zbHK+F3o5xKDHV/mItAZT4J3nPxxm/TE9H4itPWBjng0ag= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=hhTykutY; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=qgdB0XrQ; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="hhTykutY"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="qgdB0XrQ" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653ESr2p1297173; Wed, 3 Jun 2026 09:44:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=p3kwYGCtqhyefa3TTIcUbbm74mIrd5JOHXM/d9JiNe0=; b= hhTykutYw9xrkyQl7QVVxNhaienBd91SaVMF5m91IPQjVwDR9TXSggr1+i7F3Y1C L99B5HFy5cbNY4teLIS4Jm9KapEqhLMPlEGvOPFhW8ueeEqjRMmTkmJrERrrAr/1 F+0m9SOaUQ0dNHdlvZBRUS/oER4c/hpyIZ7BLihzHYQCyTTXqWtAhp0b3NaHhEv2 42X+78kAGxFupdIau8PUQTRPDLYyTCPeC3WlPEEGaku20ErZ9m/6m/O6fHAju+3I 7h2GkWPeS/pGBomYXL4CsrJ3TFXsJ9QjTfUSoXmHv6mwyY+zh4sV1u3oKtPy1s7U fqCfiSLJKsU3WvWkQRuR5w== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11023122.outbound.protection.outlook.com [40.107.201.122]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa1695k-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:57 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f2puLa8bZ7X+vn/3h6qnkxtlI8z/9T+V2KqD2r611Ke65NIAHzTHKMkA0NOVrJGyNmf3qxwZk++coL2OmThSWqTx4N2KDVVf7xtYNqT5R1dDQgKlCtkuTxMr1iKFcdahOvt5ll+GebQHIA6DMXkTMYiyMZUV3mx3vyXTcqCYdOPODS1ZnXrY/v99kCjXGziUtNoTC740xyylbWHMJHnCumvGLzvGyph2/SaB0Y8306AWvo6K977eOkKH3P3+R/oiCD895rLUI7c7iwe+UkFP4GGVyRVRKBFyJQ0AUv48fdf7l6p48wJ5Mw8Q7+wHg5jmLTXwQJ6OIg4SfdDH2ADhNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p3kwYGCtqhyefa3TTIcUbbm74mIrd5JOHXM/d9JiNe0=; b=NlQqDopLSumWhj26RZ+SfdWgVVV59F3bhTh8TZqC5ZuLGaaKyQVLmn8ujbUAdul0s85mygwDCNV2YC12ZiK1ErWpnc7tkFYeakIUVyW4LydIuzaRrlKzt3pR7HO3nR9mNkNuiFpnafjslyC0iuWumF7RbcHXuv1F8ZVeobyhgqXuO2QhJXVMCS/tCTXRjou6hV0ZgerTXjNVahEBSo3orSi+0yoDDdosndLHZpHeu3vUT9PQoDhi/zo0BWChogHrgupcTfg12sorRbNquyV6xX6IXfOm9V3nA5l0DAOXGiru4dqXjczVeQK0xgFePBtu0rEcclWf+89YhTUjmP699w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p3kwYGCtqhyefa3TTIcUbbm74mIrd5JOHXM/d9JiNe0=; b=qgdB0XrQzmPiNZsQzVQGjwZKAWlRXhj5/pQHiKDVD9d/CDpYmzLWW03/hiHGwLHv1wP0WnaOiqw94jmcjqCpWKh3ceveJatXpz8HQ/xojXOVAdVe4SR2vJrhRy47YL7b2uBj9tO5bcJWB+ubVxbr2lL/XM06OyaWXB7cDdTn4aM= Received: from SA0PR11CA0127.namprd11.prod.outlook.com (2603:10b6:806:131::12) by BL1PR19MB5769.namprd19.prod.outlook.com (2603:10b6:208:391::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 14:44:50 +0000 Received: from SN1PEPF0002636C.namprd02.prod.outlook.com (2603:10b6:806:131:cafe::73) by SA0PR11CA0127.outlook.office365.com (2603:10b6:806:131::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:50 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SN1PEPF0002636C.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:49 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 42C4B406555; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 07C6382026C; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 02/10] ASoC: wsa881x: Use new SoundWire enumeration helper Date: Wed, 3 Jun 2026 15:44:35 +0100 Message-ID: <20260603144443.593230-3-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636C:EE_|BL1PR19MB5769:EE_ X-MS-Office365-Filtering-Correlation-Id: 890fb4d7-0e70-481e-3c18-08dec17eaa49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|61400799027|376014|7416014|36860700016|6133799003|22082099003|11063799006|56012099006|3023799007|18002099003|16102099003; X-Microsoft-Antispam-Message-Info: /nS/6VZok2W9zvRtyjBtPEyZFyrcEBQaJIms5eJJE+Ry6nG9S7Bhi6e/YGqn7FW0NkGec6lKQ8Wf5tplpC5G5o322HGl1Ef5v9gqiwlNlf78n79TEKmqtV7GT1VslMe6EbkV9Ewb6PR6aEk/vNC0Ea1M7Dk2OsZ6ZSJlRk3myUzbBPTjFNnr5V7CKwxsZ5yuMHKSAWXKL6SrgB1n/tVNR+HI9klNiKxlYSsZdUPZnAax13VdsxPbauvnNpuBeBvhm4SVd9LL0NmC9dyxdKq6QJZzOYevJ8A23yLess8ldqfxV5CzZyFA4DaOsX78JX3XDznpOTFK+q93wPd5ihNSOlSN+OM5nQX08khFc+yg+v4rfQ0gOaWW9KwQAdnU1jL1/uhqvRtewWbjrRRVNSbwrbLvRTqyMlpEhMcihlJFNkWnEx2YnXsfZ1FfPZtqsXmeDrfkmOgDwf2XNskRAyDTIrjsZmekTQjsr8y/XPIIJJb5KpA03SRd/TxDvA1jKmqdIUHpBM05NcMPj0ex1GdL49T0yplBlqeTOJRH9mY+PcMBZH4cvTTszfO0GFS6lMgVHlmqvxzcuZvnCQ/UW81ADpjn0be/OYTVOgcRNy3UVBclamTuz/qMKXU4odvjn1FfP9U7TkJLDDvvG9Ezjr+B5dcV9d0+ATjmvV6NiWoCFdCkk4w5YA9h4AZ59L1uzlGZsBxVPNOdG0oGVKiRFcbYA/5zx5GVu/B50cvICNmV5BY= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(61400799027)(376014)(7416014)(36860700016)(6133799003)(22082099003)(11063799006)(56012099006)(3023799007)(18002099003)(16102099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mWBipDpn1xiK4Y/yp7YvZtUM/Rfor3I4Cf1euuKzCp42nRFZU1PL0ORMjabW4gipzQ2nN6Nt7e7SJdwWlFaEQX7+gQNUDHyq/8SaOaTPSawilXTCf4OF9CxokKwLIQe7QNbmu/YGyw+hDtLWXkuNh9dk8LdfLwfxjML4WSLctqtEtR2eZ52Q7gJ1aibDH/247ArDSP0fv3COqbI85dv05Bh4cCqrdizNG89USh/AipV6ssuJ8pt9ajvYU6OC5P9wsghMCGnK0JUqtcBpr+1OFDGVY7r5SvkYT2knp+daRAYPWEbERDL00Nx0EeD01+oGK2PS6FvzAl4QJAWDKcEOk9bNluAlAyy8wI7HAFh1ktsdzYYdxVxbxEOdvOO9YwsKR9IpAApqT/mecdQzEKq3B7XReizU4/Xf7GtshBU0ZkmEKKcbSUZJFCo8eo7pZ0iG X-Exchange-RoutingPolicyChecked: EB0bM3RVqYu4QQXkqeR/lJWDSMHjxPkK91FcnAxEXQkJkPLPhplt7u0OQX0OfzVI204f+CR30erW8sodTqouKkvveYgIe7mxnblesbmVEBdOkYw9ciNwNOVmyBMzuG4YFTv5Zsmj6IcQCFffpXWYbtmQ1fZlOC3qcuOju8ZEtMa1N2C1pqMNnF2A0BYA+axY25FLkBg67UtIVImyZg5wYf1+cq4o0k/dTyNNUwKr4GZ8EH8IbSq4EJcw4YUU8ZIknTvvfrzptZ3hHss/CccjR/MZpC+KPHPaqymBT4gl6Em5j8iITQyB3UGLe2EuRB4bi/rCIahmhv9+m3pKjonb2A== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:49.7351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 890fb4d7-0e70-481e-3c18-08dec17eaa49 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SN1PEPF0002636C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR19MB5769 X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a203de9 cx=c_pps a=1IaZlVIhgsmdv03QAtF1KQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=BxSnUCk73ilfYBohU2oA:9 X-Proofpoint-GUID: 5NN3Pws9RQI44w81ojLl4FWeS4r9Eh48 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfX2YMsNEiTEXdZ t+NY0uuCvdXOPJ3uRCsHX+kKymtzi7vqJ1EBKv1lY9glv2N7P2WIiWcnWVaBxUgo2BwXxSZhtLt rTp5JERaYS+Yx34IjT0aH5GidWjArKjaBiIVHLYenezvnhgwK8sEyOFoT/4BAE3wyvFYPLTUE9K laRzG9KgRevppsj3qcSD55N1SeSNt4yVUm5JkI7tBOnf4rkmie246V62YQpQ6u6VyzGa49iLlt8 KwN3kXiNInb1waCUDMOKV6VuiY1gdySz/ZFakdPYhA1zK4BDInYAt8YiFVxO/HUErytR6IBKBaN THzHFxIjdBqYp509brh3m3zDoYDQyQQn4C9XkrOviH7yUQXmdkh9SCVOGDO7NxNV1c/S13rYUps 32dnDSkgG2ZOxEX/7ltdxXdys/rqVzvLZUcmMUae5wsX+X9cXJ5VECuPbvdMppLB4PrB/tKXsmY 4tF8PD+3NpxzMMgWEag== X-Proofpoint-ORIG-GUID: 5NN3Pws9RQI44w81ojLl4FWeS4r9Eh48 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it can be used for code that also doesn't check this flag. Update the driver to use the new core helper. Signed-off-by: Charles Keepax --- sound/soc/codecs/wsa881x.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index d15fda648dada..5174614c3e837 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -1167,16 +1167,14 @@ static int wsa881x_runtime_resume(struct device *de= v) struct sdw_slave *slave =3D dev_to_sdw_dev(dev); struct regmap *regmap =3D dev_get_regmap(dev, NULL); struct wsa881x_priv *wsa881x =3D dev_get_drvdata(dev); - unsigned long time; + int ret; =20 gpiod_direction_output(wsa881x->sd_n, 0); =20 - time =3D wait_for_completion_timeout(&slave->initialization_complete, - msecs_to_jiffies(WSA881X_PROBE_TIMEOUT)); - if (!time) { - dev_err(dev, "Initialization not complete, timed out\n"); + ret =3D sdw_slave_wait_for_init(slave, WSA881X_PROBE_TIMEOUT); + if (ret) { gpiod_direction_output(wsa881x->sd_n, 1); - return -ETIMEDOUT; + return ret; } =20 regcache_cache_only(regmap, false); --=20 2.47.3 From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAC9038C433; Wed, 3 Jun 2026 14:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497946; cv=fail; b=OcqEbteAlxdzKWEDQPjNCKPcqcwdFQZwfZ6NqNgZfrGKBdZFM4J3NzvNsg+SDtnWLJ6JyaFdzaiagI8F8qcsFDW3FzfSBd4roUBlcg6pLKfhtIbTrqB4C9r/w9uCpEIG3gO8joCiHFOQHx3S8/DROtETZfYw604jDFntCeU1btk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497946; c=relaxed/simple; bh=YvFTVQHwb2KbLY8xn/wJxK9AxryFNKSJ92Wsj2NzTSU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pZw1Hf6VdwSq14nIQVKBYIDPOVIOTbqJ56wnvid3Oo9q81FnFpW/x1sP7X//B75IIB5OvjWuBapRZHTlY8ie1xyAjW9rm9ZMV74Rfj2GMHI6AMM1O8YlcNzGXUNSIN/M7/8Rw7ag2jCcX31vD42gatc2uR0Vk7g9xgEWrqlHJw8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=Jh1IWgyr; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=Re5THFAe; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="Jh1IWgyr"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="Re5THFAe" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653ESsUM1297289; Wed, 3 Jun 2026 09:44:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=Q5GQtZV1NR0j0aVFwzNka5LvKiFXPEPGQpdmlYuW4/Q=; b= Jh1IWgyr5Wdsk7QADTLTt6b3RmPmIqiThyB+gJnGddnB1Mgxq/DJDdbFZTOaWHja t6Xt2IEypaZ+P6GQPy6Lp0uUNjzEoofWSmyFIXk6tVQVVwuz302dDZ60ZuR0v+0L jpSL8rItpNoFFQvaA52Gwh73mtdPbSw3Deied0iB8FFcwN43U3mq8wLYxaXpInbQ ZdVfsDP7Mz+gZskyaXksbXxooB8Xf3jrGtLAKj2S5aUK+N+9mw2EyVZtXK+blTOZ HI9mJrLq04ZvjhtOlroDy156Jzz90bKBPGW49n1ztvPHa30zZPhptN6cwUkRaaqt pe855bHtEWW9vtdWEzItpg== Received: from sn4pr2101cu001.outbound.protection.outlook.com (mail-southcentralusazon11022103.outbound.protection.outlook.com [40.93.195.103]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa16956-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:53 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NFpWYGXDXYYDja2IesLZRkP1gTxl2Dmomaybpwi2WW2MD3joxhcDi1nXIQZa50dcjQwcb82PaSAZDKQrmk3+7OiqWYFFTgspbe1TN+Tp0b847FZ7Z0PcNjzjZ7zElJWTJZmF2jEeSusfZfTLU6haKgPP06p07gJPgBWWY0f9ivwsxRXU8rI/8+aCxpXJ33Ox2ixkEMQzEC/Sh5jV0rDgnjGqwMAEfo8jA8yAbXYjJmf+XCkEDDX+q/Bvrdtb5KegmF3MaUSOdVeIh3Qlct64QIjCZdhKD9MY5ewsC6Z/1S+K32r+CSVRUNIZNWymqd3uWZ4fnY5sJUz9QqzSN11XJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q5GQtZV1NR0j0aVFwzNka5LvKiFXPEPGQpdmlYuW4/Q=; b=FZYWxvoeo3Q6VGej6lb1SEcTCWcimzh3HKW0Z8IsvLY4sbTAAG9/OozLJQv4O2hwkHR+ZNwiLCktQmIsQpjNKWSxq80AoRRcDKvOX6BbOlH190lWv73H/4fCglPQ1I12R2+v3QGo+iNwmF24iHAPZEjh9PbGn3ekVIDLpq/RhX/5LqiP+PwABhQ81+nlzuerB6QBSuBQynRWYWpQ5Qlog5jJ/uP5WYZmDVUsRDumeIhox58iFHu6ra6Li5iEynTHrXmTj/eDWBrfm6krNN8O/EdZGXfBzsQq/POum5cQ0WZwxMpovV2va6aZ+0DvLRD1YyjycG614pmLjLr17r3Hmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q5GQtZV1NR0j0aVFwzNka5LvKiFXPEPGQpdmlYuW4/Q=; b=Re5THFAev/w5yM4ouDz/UB0B7vHqrMdJG76S88KzgklfbpNX8D+p2PKq77+z3D19sBIrVZ3hTuB516PJNxVYBgpwty+nuOYrvFUFA9ABoFBYgCh77p3d+5c+ClMGY6ryxTO+9f2UKz0ndrOV3JL6UMvOiM3GyWLDtIPg4MQ0SvA= Received: from SA0PR11CA0002.namprd11.prod.outlook.com (2603:10b6:806:d3::7) by PH0PR19MB4889.namprd19.prod.outlook.com (2603:10b6:510:91::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 14:44:50 +0000 Received: from SN1PEPF0002636E.namprd02.prod.outlook.com (2603:10b6:806:d3:cafe::76) by SA0PR11CA0002.outlook.office365.com (2603:10b6:806:d3::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:50 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SN1PEPF0002636E.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:49 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 4C022406556; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 0AEAD822542; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 03/10] mfd: cs42l43: Use new SoundWire enumeration helper Date: Wed, 3 Jun 2026 15:44:36 +0100 Message-ID: <20260603144443.593230-4-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636E:EE_|PH0PR19MB4889:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f37fcd7-1a5b-4826-3929-08dec17eaa5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|61400799027|82310400026|7416014|376014|56012099006|11063799006|22082099003|18002099003|16102099003; X-Microsoft-Antispam-Message-Info: CWGSf/v3p/dzvzaQNVDKTgYgSJtQ9bhpnnDf+Ih8agYIH42Dv8qUdHalw7ElWNLPMD2DgAa1z75WDWlyca+JsN8PputLEkznHHZbqu0Y2mxypOzURENHOIzU8xKC+NIhjtQjCvclpq0upMseJOkFbw226cU6T76teyqOj+fpI81pUA87FL29pESR9emMGmCDwtnFQ2frM/N9CJdg9MXMN2w8fVxC+8gDcbVrUsathSMrdOUTEiPq+oGRgWNVNtrIF51Wq0z28+nUpa0WTVJrHjDJOdNyGZOaJpV9az0WlKeaAMwAoCy0l81DDS3jpqYuVa1uQcK6QoSTk9rn0aV6YrMGcZUrhPCmD+5fPbADtMOSQVleuu0TREozsjAQ4dcqrDaCbt+IDmMCsekFxevT15yuuRcMdOq6aAsl4vD1MGNvVr5HsHRuSSMcIqxr/4E6x6DMLYqaHTJk6MKgKawJpynflZpSBOh4pD9Akg5FNqQLSHmgCi9ElcUaO8wAiNsoBystE1ijQWCx7wAla0db5p16C9wOOaNZpOqSv5Z69UD+F5oYKX446SjGyuT1cTqCqA6TP1Xg6SnWQkIiIb7NHbN7EpsVqSi/4flJKL1VXgmJMhYr03eAn+QyP8P7hQyR/2jy8eM1cO2IvtKCC0MMyB5OA+40bIg+x2bB6gWfrwrouS/eumsJAPRIv6OqcwkWWISmhqhnNLB4v9s7+0JxTHZIB6N+tt7rwfD0D4WcEd4= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(61400799027)(82310400026)(7416014)(376014)(56012099006)(11063799006)(22082099003)(18002099003)(16102099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rA5vWPyz+qisH/KICUN7FGoiSB22cnBqkPdaqiuLHu0fzYAOF9MhK/CNwSGapBf1rMIwCQrgi3ut9LyRjIDVwo8ovcFQcJANPjE+wJgO6eyhNuhMCs68KTcWDgCjNlGoM9fJmpzssPfqb3OkwcosdMV20JYXGMC2PN+PzLEubU1oYSajCOPRbSTlbGCUur3vNBMfFYyMMo0/RRI1klGA5lWUVrBUTeE31dgdNL6JFFkU1crh0/GWALhDusxWol3y7O64oZKwjmuNiBv+/wu5h/LPf8P7JhMElfuzCXNT5XrMoy7BJRgJTJ/xHeEJGmfipMcMRm1GVoXK3MGk9YDVEnxiWeYToOLnPVv2wxfsCRq6AVlr3sJikFTerV/JV2g0PpWU9bEQUc8TcxjO7117vlBm7QpQD8Nyx2ELwKhU17k9Oo17J5LCP+tkADnokRVa X-Exchange-RoutingPolicyChecked: pwzFe4wBMU5MVYOJwJxwm/UpcRNvFO4GdfLxLsaGLVsQe0qEUbqbCtDK1u2w66rzEl6APFmaV9t++rcLKsbxHOLnd6naD0YiT3IVAisNw9AuyBCwV2ydIqDJj/+eULHb0osigvyKe7bHm60m0HxibV6tmH1bihdVFjbh87633HCMcJBTonuwjVHanQMst9wT07W64ogef+0rmFiAHJnLkxm8zJ3eCpvFyGjM9q0J1BdyboNjYUDhgpKtvWu58Dzhz5Y2Q2hJYkbbx/0YlqcNfxcfmwI2AZkgVy/cNthBAxYXGZWoN1quLZvCbpNC61rq+LzeRZcSFXh1bnPBSKzjBw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:49.8736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f37fcd7-1a5b-4826-3929-08dec17eaa5e X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SN1PEPF0002636E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR19MB4889 X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a203de5 cx=c_pps a=dTL/NSpv458ZJk1fBD1pSQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=pafXaJPY5UDKb7RKIksA:9 X-Proofpoint-GUID: sHZ1na3073mmPd2iiU3dEEcNOqUXHCTz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfX+5EHSq7+En28 y+1/Fu6krBSOsu8gTP2h96Xd+H8Fl6Uv3mQJxer6i8xsjAHZPwKWqX0mEtrXWXGT4uHctk9+BGf uq9uax2kGzKfFqHaHQTqpm9qfVD96jjzXG1sQS3PljvnoaKOMA807u3u60mj9U/B/xT6IcOtIx4 /6EowzbeSuYaLPR7x/4aHRCbPUucoHZ9hGfndabcIEUikk08PdvMhsty12tu8r4WIm58nDh3MCS NKlqClKtFukq9laZIQwHbhRNqkxl1OWVFYX05v8E+kKuBmgHtAfIMc2VK0l15pg+3kQwmQ7BjSt alxJ+aYyhon2JaG+6unui4Rsvg1z/exHYy0h5nSdbB/8PxkFZ5zqZzVZmjU+EYoz6ygBR0CriSO 7a+yfyJ7e7YFq7ioTj2wYTeGIl2zAAaMKl2pJK8L28i/esJewn5bx6Cjh40Qjfv7iJS4viUrJkU 071GU0RcsF+Xt6wb6DQ== X-Proofpoint-ORIG-GUID: sHZ1na3073mmPd2iiU3dEEcNOqUXHCTz X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax --- drivers/mfd/cs42l43-sdw.c | 3 --- drivers/mfd/cs42l43.c | 15 ++++++--------- include/linux/mfd/cs42l43.h | 1 - 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/mfd/cs42l43-sdw.c b/drivers/mfd/cs42l43-sdw.c index 794c983781750..2c890a4315438 100644 --- a/drivers/mfd/cs42l43-sdw.c +++ b/drivers/mfd/cs42l43-sdw.c @@ -102,15 +102,12 @@ static int cs42l43_sdw_update_status(struct sdw_slave= *sdw, enum sdw_slave_statu CS42L43_INT_STAT_GEN1_MASK); =20 cs42l43->attached =3D true; - - complete(&cs42l43->device_attach); break; case SDW_SLAVE_UNATTACHED: dev_dbg(cs42l43->dev, "Device detach\n"); =20 cs42l43->attached =3D false; =20 - reinit_completion(&cs42l43->device_attach); complete(&cs42l43->device_detach); break; default: diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 166881751e698..cb1e175586bd1 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -586,15 +586,13 @@ static int cs42l43_soft_reset(struct cs42l43 *cs42l43) */ static int cs42l43_wait_for_attach(struct cs42l43 *cs42l43) { - if (!cs42l43->attached) { - unsigned long timeout =3D msecs_to_jiffies(CS42L43_SDW_ATTACH_TIMEOUT_MS= ); - unsigned long time; + int ret; =20 - time =3D wait_for_completion_timeout(&cs42l43->device_attach, timeout); - if (!time) { - dev_err(cs42l43->dev, "Timed out waiting for device re-attach\n"); - return -ETIMEDOUT; - } + if (cs42l43->sdw) { + ret =3D sdw_slave_wait_for_init(cs42l43->sdw, + CS42L43_SDW_ATTACH_TIMEOUT_MS); + if (ret) + return ret; } =20 regcache_cache_only(cs42l43->regmap, false); @@ -1120,7 +1118,6 @@ int cs42l43_dev_probe(struct cs42l43 *cs42l43) dev_set_drvdata(cs42l43->dev, cs42l43); =20 mutex_init(&cs42l43->pll_lock); - init_completion(&cs42l43->device_attach); init_completion(&cs42l43->device_detach); init_completion(&cs42l43->firmware_download); INIT_WORK(&cs42l43->boot_work, cs42l43_boot_work); diff --git a/include/linux/mfd/cs42l43.h b/include/linux/mfd/cs42l43.h index ff0f7e365a19f..5f5c043e7cab9 100644 --- a/include/linux/mfd/cs42l43.h +++ b/include/linux/mfd/cs42l43.h @@ -86,7 +86,6 @@ struct cs42l43 { struct regmap_irq_chip_data *irq_data; =20 struct work_struct boot_work; - struct completion device_attach; struct completion device_detach; struct completion firmware_download; int firmware_error; --=20 2.47.3 From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B62C944D6BD; Wed, 3 Jun 2026 14:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497951; cv=fail; b=iyzmvcW40jBTyVKR0nVEzFFIXva9lIyQqaLt2JIdmh1xuhzYqSKe3R+YSqKrlr9EI66PpKS+ePR0sx3mI/6vPxNeLZjt0XHm4I4sNqBxNpbluCd/ryQE4V9SiN6Mw23UiDiB5uGYTqfq0Oxv3HSEJ1Fp6rq5ICUN+IxdO9qh/DI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497951; c=relaxed/simple; bh=FZ156FLlBLrXeJAINYKkW6WlpSFaDPdc1c94BiwYhdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dznEbDHkIsOxIlMmkZMKq0jlIc/9N6CaoG+QmdBdL7fla6tIj4UXyQr0w1WJDemJyBEobcceSYkNM5pjCOQJCgo2orP9Kcn7DktqBm7Tp5y20PR20H1TefIE/kVbgN9qh5DCpHWSHWaTmQR1BLA06xxFde2o0tYlvqi345t7g5k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=ZGhOfCBl; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=EhX+QGFK; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="ZGhOfCBl"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="EhX+QGFK" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653ESsSj1297282; Wed, 3 Jun 2026 09:44:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=a0KjpoVRg/v+wUNRgo/UZqjic3bofdfYnYE9BpzoQUU=; b= ZGhOfCBl/KJZSa0nsb0HK1Ha6EXbu5BoYS3pvJcsqgtU59+R1MUAN9cCq7buY7HH P/SA/sPhGNlwaXrEcd0s9Zu++CrAPrNzivDhS9VhNNx6YfKpYK+Jmn/jMRW/m+nS YaJNwEF+PuAnoNpdEiVqflGB6YGX1ZHo+AnzURMw9vmU5PWv1dRTC+QZ9k/DYSvP Q0pW6rp820OuVDth+R9OLO94t7a4lYz55PLPdtsVCks4QKmxc3Mc+n/H0GNXN7TO 708+BcvGpuRSTJ5Zp3zFNNUqg4e1D4eWPYdPFUdPm/lO0lkWfIuH1o/nz8IRpvj+ xhVc+FWG5ffMhbUBCISyww== Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11020102.outbound.protection.outlook.com [52.101.85.102]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa1695e-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:55 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Oq4Tcdgc/ktwbrx2hLWddpuZoEL3Kd7cTNkLwz3W3zxNJG+8I22q/U/K5qPnjAMQk5wdTHf50CpiSYp4lw5TpyuY9fRATh8gA09GZ0R7v7jeFYJiQDXrYsnaxtPGArmu85R0Bn1hdIkd9JY//zNcgvQCTRD4si6jCBrDG9aP9tQld6NxzzNMWXzGpD5A+WEOEjW5HOYWGqjptJzWirPNtH0Xdm4JHOMnbdlUqYhanj4HwLO+IafczFlPOqFIqB2HMQ9NFH7XHv1WAOLkGTE7braeHY0pO/JsKlcd4s6qEmpZ7thf336uO6LCqt7lohPWtt6UNoaXFr4iDdrEwbNMpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a0KjpoVRg/v+wUNRgo/UZqjic3bofdfYnYE9BpzoQUU=; b=mH6NdAzDWU4wCi3JBuLEmqixJXHC4/wZElDHGiCbBmigmqG1FzQv1+aNWGk+gnIFMtCvCGj3BHh4tfGBt3VF9o7YSBRemWmktxUgSfnyQ26vGHP4tS0D3TnftzVMUWcasKBePBbMxYOyzj7kvj0uTr6MJZlBDZ3I0cqE2zeWQECkk9DjpkhcnHL9QeMk8zQ2zPoMY5bdLseiYQS5xqXfT8lNh1gTshhmgec0HtLu9fi5DDFDyBDmGyLiSq4E/bAJ4sKP+C6EWjRFdEkuTYr2qIp7ogDwQSfx/aeQknx+UNzG0eToo0HmiDFppfgkB300AkVwgPpij5m0VuWP+MQfuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a0KjpoVRg/v+wUNRgo/UZqjic3bofdfYnYE9BpzoQUU=; b=EhX+QGFKcYNA5uMd41VQCsQDS+KGyfSRjq3tWiri+wZS8o+0j/qLRHJC2eo2xHzJFHwy4ZRC7rLrn8UdMNZBIeMnC3X+HdYsMDeB0RlGt+9+kQ2ON2u71z2PB3jpjwDtndopAbDCR0UlW1QSMpf8UaoSyHCr0u4lK7smsTrQw8E= Received: from SA1P222CA0087.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:35e::20) by BL3PR19MB6537.namprd19.prod.outlook.com (2603:10b6:208:3b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 14:44:52 +0000 Received: from SN1PEPF0002BA50.namprd03.prod.outlook.com (2603:10b6:806:35e:cafe::51) by SA1P222CA0087.outlook.office365.com (2603:10b6:806:35e::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:50 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SN1PEPF0002BA50.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:49 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 4DF6B406557; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 0E430822544; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 04/10] ASoC: rt5682: Use new SoundWire enumeration helper Date: Wed, 3 Jun 2026 15:44:37 +0100 Message-ID: <20260603144443.593230-5-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA50:EE_|BL3PR19MB6537:EE_ X-MS-Office365-Filtering-Correlation-Id: 318e6d70-d002-4c33-67d4-08dec17eaa5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|82310400026|376014|7416014|36860700016|22082099003|18002099003|16102099003|56012099006|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: A7s7pSAebKIjNXH6btoDqR5FuBTQcHFrHIYY1zj2KN1gUec4iLP0ekyWoSoQIrJydLZTvlCYlUZnZVQ2CC8AgST/wV98jiGRY+8MJ0zY9/9gpi0yq1oS8L0D0Yhh1Y2oQM89F+Vg8189AwFtwjcmYmVNmiTVN2yZ+495Mc4McdbWRa+VlHR2Eyh9M3z276TEZlJ1bjK0BAP+kAO3LCV4w6nvmkQSzkYcwAv/+PZBeAgNrIvFmPgANE7dFLsJonBEGkO1RBDI1g1pZQNHhY3soawdzxBuokdq+UQLvtRymivQzGGXQed/62AzXy+VO0Ter0ALyNpHhn/m/zDBaltbPDf8kGDkhjX32u9Iz9eRwwzQ675XbbzIbbJzzbj630Wfdp1KD8Ha2cXJxVwAWif42mYbCSeT4CaUIN16N81/3fd5ZuNgm7NeoDlvxXze9+5AGAKCoQDmoSyQWdw8ehKmgzypSdI0XHRS7HkVLlC8vtmqfnA7U6pOgDWutYw4l3vQG84yKSllUSpwxGxDqkHq78sFUq6XYLW+JYTsfv1YRtD4I8KAtkePh4+H0di6ENUlUmTJ40dwCcYo5TSU79kuhEki5PxmWwlIjYgyFpAwGq2KyUw9PUS7dR2ooRFLmitB9ozii9gMqxDIpVqPq1hSe2YH8JC02W4jkM1p3/6y9tZGnqqVBp9gEV14dExAC9/zI1b50NudlFRa1U02nRdUUhpQQ6m9AQLj2Es2cQCU2lw= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(82310400026)(376014)(7416014)(36860700016)(22082099003)(18002099003)(16102099003)(56012099006)(11063799006)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +nttQtsL9E8DMmk1txI6/hjRl9B0qsH95vpOJ7tD3khgXQm8xQQUoh3thmf1S3pBHwb6U2kn1XP4i1GLRIej4kOEbp/OACzhsUvrcOBWqe20KqwBwwTNIupudV6NXuvINh9gm/8hMAafv+gPBmD4cxkYMshQeH8HEHBOelNgy+nfLvth7PQXV/liFkWNE8amBkbXg9ABbCuex31M54GF4TuQ1PdzBjEAEmwCKL9RwRvMRjFOD6iZ3j4XKGwKqta7ddl/oBn3O30VO2pGmBLxk2AlcxRtjRCE2qLlWukZHtqo5JKrRp/Oby0FdZZUW9QzaBlIxTvdgWlNSAHTLPid/JuxFy4VA0+dooNbBzOrDQLKp67FJ67fFr5G1qU0C9NhymVnGJB2p/SXOROP3eUS5BaUTpDQOLnelZ+n8dOQZ+OiGJGTWvf4nn+NczrV2dni X-Exchange-RoutingPolicyChecked: iyjwkW+uRZzCEwHP5967P7o0dtZ0haStXTinMfpnmIruxFUkQuyBBSV1LRcvfELKcYDlDMFIDRUJ8qmpPbEek6WaN6SC+ZlB5Gb7RYb/Aqtq9Ec53khwrk3K/8RfkRUrKmW209/8+iy5zFTNaHF2iLqwAtmsp31AabTvyVPe6+MVAc8DUYGa3ABC/MwXuOmGzq3s5g0o/XRGA3lA6x/BTppjyCEQBPOoLznq4rN+P/GlM4V48TX+kfnwen/Uhd+Vk386q+azdLjEbNEg8bWG0v+YDgUTYjlOLVxCqxqN08m3Qy9IYAXYD3H9Dp68JW67ZLOWuVYTIxYHymoFBUn/6A== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:49.8471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 318e6d70-d002-4c33-67d4-08dec17eaa5b X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SN1PEPF0002BA50.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR19MB6537 X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a203de7 cx=c_pps a=/HvL1LX/IhLcM0VBVohJhQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=3l_c3HHteuAAOOvkCYUA:9 X-Proofpoint-GUID: tV3U2p_Otjl56UXnOvZF6fWflAKBkhLA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfX0gpmo/WgV+Ch Uo3lLJF/ZAQAmunXRdbtNVWNpTDCA4HSG+91mq/Yy+qCunMzkprkjSxeahChj4w5Tqqx/E3zZ6R MvoTlLKDWQ/I0m75E/sIZfY/YzOBpYpGU3ANbfV4Or5HQqFyMWm4VEyBz9vpqIKndKnRZSapyTU 368z4u0SIYW3Dx5RWPZnILfhlv8x18V0c/0lNHlZZSxJeva7Jvolp5LGeo2wope6RJiCbcyYwqb v75mXdqWCf1oVjpPswAqtmdBvqixScFHlgQrnwZX1oQfCNvOoJqdzO4O7FXqlNrxWLdmZ6/l78M IlOc4QwZL3eiE1wFKfRUuhdpjsMQehiaNvwsHEP7/XmSEbyA7GAYSNw0pLPudtKtxWt01a4N9uH AGqEaxlIM7yqxgYaznGP798OtbLEJdgWnjMn/atOgpYlGMgBQkrO0GmHtsrQ/IiX7Pnxz9a4Bwv RXkT7Ggo1xjD8lLJ13Q== X-Proofpoint-ORIG-GUID: tV3U2p_Otjl56UXnOvZF6fWflAKBkhLA X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax --- sound/soc/codecs/rt5682.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index d39f8e4f3474c..4b82e07d3b2c7 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -2929,20 +2929,14 @@ static int rt5682_probe(struct snd_soc_component *c= omponent) { struct rt5682_priv *rt5682 =3D snd_soc_component_get_drvdata(component); struct snd_soc_dapm_context *dapm =3D snd_soc_component_to_dapm(component= ); - struct sdw_slave *slave; - unsigned long time; + int ret; =20 rt5682->component =3D component; =20 if (rt5682->is_sdw) { - slave =3D rt5682->slave; - time =3D wait_for_completion_timeout( - &slave->initialization_complete, - msecs_to_jiffies(RT5682_PROBE_TIMEOUT)); - if (!time) { - dev_err(&slave->dev, "Initialization not complete, timed out\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(rt5682->slave, RT5682_PROBE_TIMEOUT); + if (ret) + return ret; } =20 snd_soc_dapm_disable_pin(dapm, "MICBIAS"); --=20 2.47.3 From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3494223DE7; Wed, 3 Jun 2026 14:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497946; cv=fail; b=FzSJ6cOmSRKetmW8W2vXjdZhKa4F25iwGws+gxhy+/mhylgUnZlyhlDib01aJPD31e9mqsGJE7NanmhE7HhzCwDrrzbLIvyWh1vUU9WB2gNOBknWXS+H7VzhEDlM8vbp3dy16qGadcV85R9u+O2JWEfTbGM4/wf1lUA0vATA6XQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497946; c=relaxed/simple; bh=lCkQ1KYa31w0d9ZGmhb5t9F9hDtBb9fIsY4LxFU5GzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=V2g5cgbdkc7iJ0csz+8ZZcBR3qB3Qh3ffi+qZ50JiWPElzrBoKWhD8ZsfOOEZuBLX4of7r59SWCJlGl0Fd1GNGojxmyRsm2zv8ccnKfSn7bQ6spom/BTeMGLZj9rJuwAAmx/jqxiIvA83PUi330jcXP5o4GfYmapxDMgily7pa4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=hpfMzV0k; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=DjEDi7CX; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="hpfMzV0k"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="DjEDi7CX" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653EPPul2840060; Wed, 3 Jun 2026 09:44:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=nnUC6ZGZyJZO+BvBt6jxqMai6Vzezo6t2vS8fbxsE0Q=; b= hpfMzV0kGA83pV/lQcGc6+F7X1zKRLgII/cblTGmbkXr1LfaFW3CrVUcoBeA4aC1 7H8N7T0meyDktfb8UgQ0l+1BPBOtg58C2DtPxcBS8W9OcG9qx8url9ZUSFcB9cKb Moi3hpg+D2lXJ1EDzMtDLEcKnOpohQz9kYQdxZ468jTrihH8g7YwCg+cFdTh7H46 3jGDNGWub82Kk/zf2TRKo6p0Fegb5WwL44ytdi1If00s05yjw1e/9w+pM4cpCm8U Q2Uble3GbcNHRA8cj/vYJS04Jya8ITMJOk7OsMP763W8WUCIT58ywXCU2l9Yl33U dqhKHbGZZPiP8steHMtznw== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11023095.outbound.protection.outlook.com [40.107.201.95]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4efvagedgd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:57 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fU6pLB5I3XxxhLTBca5ZTkxeihG77XnVteqnqnXVPBGyKiDUBIA6r3JhT9u+7+/6buj3yt+YhVJ1VX5XfZhGtuloLyj/q8Bc7HzXszh3Le6qS+hD2kATaaQj35RL6TXGnrr7+HPaUoWbWeaYmROhFLlwbGuaHVY16m1Ud0L7DbQBkzxhF5mvWDufgkbAJXNE4VAFAIzEZUW7QES6QD5VoJ7e9zdFRjGVAF7sIAOWaQe+IqhjumIupD34kihZXHbwcLz3+cdc6xFBnlYrblMXlk+HScmdJzeJx9/5hzr02cfu5qf3t0qCZlhoAVmsWueei8znoG5T3HsORcz1XSQrdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nnUC6ZGZyJZO+BvBt6jxqMai6Vzezo6t2vS8fbxsE0Q=; b=jd0MBX4cBqmg82EoHYeD66XPH4H3xbKus1kxhG4jxLT9D5z3cCBoxX9FUwYQVeRfiRf6b9IiHC5S7Opd7rUWBIqLFwQxOBTMLzYkUE2ucyYf7yLyvSlH6uu8V66FvPgC9cYJ/EcscCtoF8G/WbsoPqCg58ZigDRrtS8G0ZrcCzJLTClytnTHVH8uiyxzRxmtNqWMrQYKEcgLx19Sc66muOZqLKcVqM8N1WXL3acaPPpo/J+8WGjeNFJ+jOHGgt5oe2Ha+oCQYKWQQdIa87DaYBz7ciUH5K08r89xVjluSauIXJtINsMY7jH8Al/a0KrcyBarvNw7+g/uoR5oVxgOyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nnUC6ZGZyJZO+BvBt6jxqMai6Vzezo6t2vS8fbxsE0Q=; b=DjEDi7CXdytV92sCagJb9Og6x8YpiRpiYnM8AB0B+4sCk5t73lAimwoxSwti1JtBh3TZJKHnxVP2ncHuGftHNNyObpiqgUoTu6sKQFkfaV5iQ+Q+/PHsUGzERcopsRofZgQAof/njfTSAP9krFBwSnWQNQxr7n+Ax9ubTuxzJe8= Received: from SA0PR11CA0122.namprd11.prod.outlook.com (2603:10b6:806:131::7) by PH7PR19MB7510.namprd19.prod.outlook.com (2603:10b6:510:27d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.17; Wed, 3 Jun 2026 14:44:51 +0000 Received: from SN1PEPF0002636C.namprd02.prod.outlook.com (2603:10b6:806:131:cafe::8c) by SA0PR11CA0122.outlook.office365.com (2603:10b6:806:131::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:51 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SN1PEPF0002636C.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:51 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 50574406559; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 1170C822545; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 05/10] ASoC: pm4125: Use new SoundWire enumeration helper Date: Wed, 3 Jun 2026 15:44:38 +0100 Message-ID: <20260603144443.593230-6-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636C:EE_|PH7PR19MB7510:EE_ X-MS-Office365-Filtering-Correlation-Id: fc2d8577-c551-43af-c573-08dec17eab59 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|36860700016|7416014|82310400026|376014|22082099003|18002099003|16102099003|56012099006|6133799003|11063799006; X-Microsoft-Antispam-Message-Info: uVMVXyvGaRcdrwoz+CBEmvxfBRcAWUnrBBEAaeUEjiSScWe1ZyPnW6kni2RQzxNXlMHTR+vS/aNMPoLoVKYjQ5aj9YIL8mBEo9YK96lH0N/CQgzDxUkZdF2SLPmeMzalhsKwCkfOJuHJWV1/aIX82NdwrakTpQ5CUAzbe0Hvw4yvyQZ/kw6XLoVYerkk8TH6gjGqdGEgWiQH9vpN3Vv5xSuTmhrGZyrnWKSseaFY9V4CM3BCdC462J5nsH4C8LSwBbIs7SzGfFihtSLZVVkS/NNyIwLph+hEUdopTmnKJxacCHGBue6gS744DxgRMGDEeKD948U3+LXxxRCBpVByTdBFWVPFtSmW1+wH6OMy9ygAZ+juFArIoDHbhHfv2vKXNVmBR8dSFwtQgDwoOppc+wbN/ldAAfLjYjuUC0Sz/K2GkKFa2p+LAgz4eoXiS5NERoPsDYW3nrX7QGlRzbDNCY5y/G3U3FZeM0+NCq8E+XM84wXzFBPG3cwWIgiztRVj8onYNOg+Tf5DVJn8hL34F4oF7dTVr7ipCSf95TuTTx3phSLYjP8qQxiOA2ulYsjO8ZJ2KO31cKlAaQmve8ocP4dbtR1V32SJi4vWYk7k2BxdBo03aXlkWIm/tsq6ss66TD/QJkn2IpaMpM/lWreQt/wZLH+C4w7U4JjJeBEqzswCtOfanOsgFp5hhGkdIVKgrAS21DvPLLQtddU1E8V2S3BoGq0VqnM0x6W0vV5ZLm0= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(36860700016)(7416014)(82310400026)(376014)(22082099003)(18002099003)(16102099003)(56012099006)(6133799003)(11063799006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gIocyp4gGh6s/W72CRvPY+zS2cP6n3HioM/qPbXQiuXjp8IimRgmAzF30HSiknuuIh4ZNpJ2mNo4q8q+WMR+7XESXQP+kMKxcm5vTvJIDAHXUYDyfulau3gbNZXM71WpTZ7KA1RrIxyX34rFf6Em78ReRuBQzxp+A86SbynsRHv96A9+7ABn2urI65wwYH85ehBna5QDjdSP23XS6L7mqieoDH920OKX7HUWu45HoqQ10VyHSm5xLhfdDujQ/Rn6IouEZDxXjPtuEBm98i8/vtt0FpvHkpBi0R25FEDPFNnQZR8WVVninChGTvvXk+dfP6n21TJw2HfuAjYpUuXsHT4mKFg6Q61sUQIDQOF1rbjj3EcgM/5xIiRoCh9yp83bOUFa0q47qUJctXxv1IPaJDhDa6h9MsmhdP+gACeVR7IBYk/Q2oga+hir1QaR0L/X X-Exchange-RoutingPolicyChecked: O0W6Y2qcX58tx/H5PDcqsmVtiDPfzdFWgm7oHnmegmDdQ+ojYoefs895UTbG3sau+DzTUq+uyB7uyE0K6INJlxeQIiCXNRvpD4W/t8xi8GxKTl3HQwFRMBxIMVzG5ofFp/HuGBslRnFOUbcLWcR4GOoJfD8j4rZ2kgtZTukoYYWLGUtI0RDoojNzU7nIi4wbMr1C/82MkkQdiwu/vVMgDkQo+k7w/n9oHH4yYUmgD+I1JltFhjj3N9SJ5JS1SGdjYgk8nzL3hbCA5ZLJc3npqsS+3b0Krb3mudluFYC5jo8R+xolQ81/Gvtn5xwd56h9EAY62/zPDtYDOQClHeB9YQ== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:51.5239 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc2d8577-c551-43af-c573-08dec17eab59 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SN1PEPF0002636C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR19MB7510 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfXxqB3BVns9BXo zwS1oPiFAmH8xbdDP8b+rlxPva7AovaF1vPA0rSHhpy2UTH3jeJFXNXGvt8ffDsw3goBjgmHLp6 dMvWY/aGY6d6tNrYy14Qxrzg7g3Aa+2M8Vy5Oq0TP7taedbUVxjz3OKkNRGoKr0YZR1TSL7K7Og 3kH86BdfxQ+8oHTNabRzSp3linVbk2h7YwerUwOMxVzA9dnMkmjNyWiB3bb6Wx+40z2qMqIYkYi gaW1I9pNULg9WGCrVDGQc2RJ+ATHaQy3yC50L7VaNIqRLYETD33I4pxEDzZFMWSndOS0Lk3X/oq /10YIm0uhBrKkXuA8x7BqQl9UcbFrAjm6QdvcsuL8FtlDnunNvISd5rlphL+XHWvJEgksxt4E2t kHe+e4nG2dLAa6/K8W/eAF0r7ZqbjlZtT8Ai1MfzIxOJkAhKhJ8mriSo6O2lcq3hGMXlN5lEb7J QExNloYIIrGOHrwrXuA== X-Proofpoint-GUID: 1X0RX09tEHLS2hF0cKEjiCC1o9Hd8Zyh X-Proofpoint-ORIG-GUID: 1X0RX09tEHLS2hF0cKEjiCC1o9Hd8Zyh X-Authority-Analysis: v=2.4 cv=ddywG3Xe c=1 sm=1 tr=0 ts=6a203de9 cx=c_pps a=iE0qjxSwE5SXcvk24aZtBQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=3l_c3HHteuAAOOvkCYUA:9 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax --- sound/soc/codecs/pm4125.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/pm4125.c b/sound/soc/codecs/pm4125.c index 1f0a3f5389f1b..29655175ea289 100644 --- a/sound/soc/codecs/pm4125.c +++ b/sound/soc/codecs/pm4125.c @@ -1309,17 +1309,12 @@ static int pm4125_irq_init(struct pm4125_priv *pm41= 25, struct device *dev) static int pm4125_soc_codec_probe(struct snd_soc_component *component) { struct pm4125_priv *pm4125 =3D snd_soc_component_get_drvdata(component); - struct sdw_slave *tx_sdw_dev =3D pm4125->tx_sdw_dev; struct device *dev =3D component->dev; - unsigned long time_left; int i, ret; =20 - time_left =3D wait_for_completion_timeout(&tx_sdw_dev->initialization_com= plete, - msecs_to_jiffies(5000)); - if (!time_left) { - dev_err(dev, "soundwire device init timeout\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(pm4125->tx_sdw_dev, 5000); + if (ret) + return ret; =20 snd_soc_component_init_regmap(component, pm4125->regmap); ret =3D pm_runtime_resume_and_get(dev); --=20 2.47.3 From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B658A24A06D; Wed, 3 Jun 2026 14:45:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497945; cv=fail; b=kMYPTR0ro3a0/Vi5FwFH2vza9xo1fJGFmHzsCgmXpboHOyOvLymNEzaZC9xyHmAsB/U5wP/A4H/XbXhE4f6h7hfQx1AmcuOSYOm4pxS7xi4i37Se3fSz8dcn1Q6KBU/9Js7rmPwu2DiXsibaZhvounRewdxyyuaObVNz6kflsUo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497945; c=relaxed/simple; bh=u//Av+sb5wJsb70mZouhRhVtHE2fyjNA+J9TM6dmqI8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OTzeUcon2OEocn/llppjGNna8q1OaLAmulFnYWLDuHUD+iH0+ABG8kELMx39NEhLpKbgnhQ98u3LUpU6G6nk+BZBAjTCGdf8+nTn465EJeWCZXSAoBPzn41YCVxzvf74urw+z/2e55SbdemIivLyA0nH0l/0ceBuuYdm0f1sK98= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=JwlSJKwT; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=gVWiMG9K; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="JwlSJKwT"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="gVWiMG9K" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653EPPWE2840062; Wed, 3 Jun 2026 09:44:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=Oivxc7nyIFh5PB/UbGIVdZAgls7y7JxnH7eGai3JxBc=; b= JwlSJKwTG3j6fKEoKkW1/YTxacOlPaBsCUM8W8Jvy9RrU1PZffAbHffzZy8oY9n9 T+wJnQ6VUrU0YgJTw4QsXTuglkakxrKK0iRxNXe9DykpSiz919wui+Ki3w1iezTI jd8zyrZ23wDLDMvfhp6DIkM8AODsUJIrV8/Lec/viod6VKV8VvujK/2xVpXO9HRc PBwBdbAGUonOwPcaMrTcCXZz0bjxWObjshwSJ6I0wTdOmsNWNV/OEZd1xvT3HOHP R2xiQdzO2P/rWW9WgxliDszM11uYRy/VDwBn4LyQEPkkyL4wUa7G13cq1giNtj0y /+CP3oC2kF+GfH8uqcHIjA== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021093.outbound.protection.outlook.com [52.101.52.93]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4efvagedgc-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:55 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iPHxEjv8xClwzGnQuKROGpPT/Pdo9XpFMFpbJOWKWBn7S+lKvO95RCSEg+VodHjmpK6T3mNENqQcAK72iKVbzFOvvObFczaoxfBHUGzLbZcwr5XULTEfRhX8HPxmM2+38L6bj7XReHW0pApkprZcrXeS0KzV57kGFgqrP5NLux6QasM8qYvGGkJIX1c3J4Q4KcH389kTw0ZrKDPvZuEjoOLL9vajZpVFPKZcx2mbLTCWeC45xNRsVRSvA3zWdA3MLxF5m6uJWiDw2hRlq/IBIky9K/eHfDOIwbR1zQIY5zVca241EUHSjzLAbng7MUjwLVXuq5ilyGEXKTNC+rx35A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oivxc7nyIFh5PB/UbGIVdZAgls7y7JxnH7eGai3JxBc=; b=j97ydC+oD1ogrZOL8MDBbhQO0DwZd/n3xsDVyM25ILOi8pWRtd+OB1u8PA3LsiGctGE6alovPkPDee3R4rbnWD2ezhTB3JZWdtxrY49tSVVXKizK9lrwbFs5+aG1/yBjcHH2sWUXeXoGDm2U1+vjRLmAeOXNhEn+o72+sYx02Tchb944iBr1TrlNHrgeNFa9STqgbb5tyXCGSRIFYCNye4QwRY5OaPfi6zV/Fhx5ivsQYXEmVOtqi81o20OTjFzJmc8ZVyIMJBCcBde1Cqq0qGqJGl7eaQR6gI8FDW1mPosmNc/o1bcnKCQYv2g58Ra3v5LG3x/tfZTfbId2vT1HYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oivxc7nyIFh5PB/UbGIVdZAgls7y7JxnH7eGai3JxBc=; b=gVWiMG9KGoYY70hs4/e/75SfiY3Ex/1sUX2a0u/tZUOcSDvqrI0kaoNMcpK9q4IukoWkQXBWQysbr5oFIQYJsY4CrN8T0PVAZJdzUt2rTkrPASPvCMAXHyOGoM2NziINaHdrwSPosEO4c2WNklWFNH2LgFdTEcQnqVOT9gK3LfI= Received: from SA0PR11CA0022.namprd11.prod.outlook.com (2603:10b6:806:d3::27) by DM3PPF667CD6AB5.namprd19.prod.outlook.com (2603:10b6:f:fc00::72f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.16; Wed, 3 Jun 2026 14:44:52 +0000 Received: from SN1PEPF0002636E.namprd02.prod.outlook.com (2603:10b6:806:d3:cafe::34) by SA0PR11CA0022.outlook.office365.com (2603:10b6:806:d3::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:51 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SN1PEPF0002636E.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:51 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 51EDB40655D; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 14D52822546; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 06/10] ASoC: wcd937x: Use new SoundWire enumeration helper Date: Wed, 3 Jun 2026 15:44:39 +0100 Message-ID: <20260603144443.593230-7-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636E:EE_|DM3PPF667CD6AB5:EE_ X-MS-Office365-Filtering-Correlation-Id: ccc99281-4bad-4eef-8792-08dec17eab5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|61400799027|36860700016|18002099003|22082099003|16102099003|6133799003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: 8yV6syDNCxWV8ioZa/GCFQt/MlqjQ7sPG346xhk+hgprhpKBI/7IoX3IUVQwvHg22hAkgnfG7Tipy54dZWj5OrGsaQFiinUvjVd3tWSM0aW2CQMYnoRRQjjyCr3bwMAvgErITtkDhAaRo2lY9FbloZgp7hTL0JiqpLqg2NzvL5RpnPMD9ShIh2/1yxjQg5mB4G0KSQB8juh2/lmMc0InHEZsb19Dq1grjQF4JeSN7oFp4C40J9R1SylwOPESuOL8QkWlsm9FtnfmYWd5/PtakRdnTPmhr66QtG0QA9dFi2D4F7u8agOAbv+ceNCNB5p1SuxGLmHcVc05EzkiwInzqvtWUPRZKn5Wh2IfTLAa30a5N/J20fkJLptWSxLHJaSnC+skoujw21AsupsmXAsX/pzjrIu+1l8muJXRngvaU57zy5datIzAzkeEYv+im8Tx2nEwIcGbM7FY2fLpmzY3BmVT8gfJDmM1YCW2KYpbGEGjLL6QxaVU21HJ9sDj9i+GoopxuY0ZykLV8Kop7kUb6EZKpacHs8SE1JhjD5MFXxncpLVSVSM8HpGwGhCTH/uBvfrDnNMc9QhD4F89/djD6dpPDW/GnkI6PliFEwI0IbcVKPJJaLc0qFtisOFV22lF/LZvSh+4PHhEPScA6zCnPM8J0dV7EAmj0jIP98V068OGs+z0p8ifqLlRqKmsmW5UPf0YYAHYm9dO9oiOTVySVoP6p0DvPo8JN9tTNYbV4Sw= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(61400799027)(36860700016)(18002099003)(22082099003)(16102099003)(6133799003)(56012099006)(11063799006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wCzmvyndkf2VT6dpkz7bx0orfapXZT+ILy04/Pz8GoS31w2x8MKbbK035t8mkgAPmSff2UyRRjBUjm3ahMcTqKX4flkSmmQ6prMR7Kzo2vZjzQQYXWUkf0Qpjf6YKV/R2DL7zRExTS1VWSVmRS+UDcqxz/O/mCCgy8GppIO4Io+8OblpUteygeTAnD6+TuRCFp1s/NGuVb/5q8wtRQmfUWd24gjWNBavMyaaBgKRqoD6cJB0AMrYqN/TQ7xL0MzwqnwxUBz26RnwqQirgWTTkwttDUeNAaV5C1qKX4Fhj3xFfToTfhMUe2owDDmzLjIumU7ilJzCSABhF5YgsKwgwZP8KCroHwgIixtNywQEPSOpNWgpVhta3IyNwj7z+shais1mpMI0QirLDbiPlj46KtcN5g+zhalK51wv/b9Qjv5jdrKTHuSOdyK1pSMcmvZV X-Exchange-RoutingPolicyChecked: pWwQcixhvHQt2Aqb57XsEuZHPt7Cs5dnZpAsPtrnwMoZARByPZll42tQH2oo1kn6mlZoM8mbxCQp3KwbmFBsftWW9hWRUW+y2X02aib/+Y5MW707gzdpQqmEeqc547gySm3z1ZOCTRIU12fwB6p47GuR9KP6sYN0R7XtTmvU3kaxm6O1Zb7t0r6YzCiDPO9RCaqUTTq3/7AJ1qWN0rwmzf9NB7GwTC6CCozou/cTdt9QVHC7YiU9ek4g9mCCi3eBejXve8y+cxzDRKpeQXLKdEY3icItrYedKbV0c1FgdgW64hCkLUn9PvYV7Ly0xZLA/DKoHn3snQEqV8/e8lLG5w== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:51.5455 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ccc99281-4bad-4eef-8792-08dec17eab5c X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SN1PEPF0002636E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF667CD6AB5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfX6I7zxdLFi3gn 29ZXQRfYex1bOHKtpFI095RiLYPL5inYQJacPq/4HOzcEgURwtp29K4d9f87N4Bkad/K7cjKynj rz0eGwDulits8thT/pBHlNR8p7/ktN16DbUaVT5LUYd8LcnZeCqkd4RiWIqxFQfUYjqn+dAKsw8 ZXsuScmgLaprKxIq0p+9sgYrrTY/OO1kQuiia+oGhplX0sBp3/jNmj6nb4TZawf5shdX0IoBTjW t4GbHGtwSbHAlcswtkbc2azbizoVABsIElortRr0JWyOP+123aMbcCg0OVwEB/CcZNqJx6+yXoS b232zTrkc1926AS8NxIcwlSCq5nq8aOyBc8cffMxJfVh1VT/4ynguTux8jD3jrSmJmfN7MLck4r LOIWTs7byVjlkHAmm9fmmSa7Ggp4Gemxzg5doBFOr131wR8Bg9TZTzKatTAj56hPNruy9TRZ/GR 6zu01RKAljFzRviainA== X-Proofpoint-GUID: WWTurcoCyhDVbkxRSNdr4tF9hCmTuCyU X-Proofpoint-ORIG-GUID: WWTurcoCyhDVbkxRSNdr4tF9hCmTuCyU X-Authority-Analysis: v=2.4 cv=ddywG3Xe c=1 sm=1 tr=0 ts=6a203de7 cx=c_pps a=0scnO40TN6uu9waSdQKTQg==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=Uk30oNBv9cZ-rtdV3UwA:9 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax --- sound/soc/codecs/wcd937x.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c index 72a53f95d6887..e0169e783ee96 100644 --- a/sound/soc/codecs/wcd937x.c +++ b/sound/soc/codecs/wcd937x.c @@ -2499,18 +2499,13 @@ static int wcd937x_soc_codec_probe(struct snd_soc_c= omponent *component) { struct snd_soc_dapm_context *dapm =3D snd_soc_component_to_dapm(component= ); struct wcd937x_priv *wcd937x =3D snd_soc_component_get_drvdata(component); - struct sdw_slave *tx_sdw_dev =3D wcd937x->tx_sdw_dev; struct device *dev =3D component->dev; - unsigned long time_left; int i, ret; u32 chipid; =20 - time_left =3D wait_for_completion_timeout(&tx_sdw_dev->initialization_com= plete, - msecs_to_jiffies(5000)); - if (!time_left) { - dev_err(dev, "soundwire device init timeout\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(wcd937x->tx_sdw_dev, 5000); + if (ret) + return ret; =20 snd_soc_component_init_regmap(component, wcd937x->regmap); ret =3D pm_runtime_resume_and_get(dev); --=20 2.47.3 From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9F033BED18; Wed, 3 Jun 2026 14:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497949; cv=fail; b=QTwSjekxhG7YdP0NqzZFbUbrAH6GSNp2WCzFxieZu9+38OzbEjVSRH+iEEzBWRdhur3f3M2+3oP7kVgtG4eaXI707j3wN5i+551sO0Iuvl8weEYkx2rypCDeamALMpt9+5005SCAM0nlpZi8Q94fPEl5zDZCZJKw7MgSh/QBGsE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497949; c=relaxed/simple; bh=NVTU9H9V5psEyWHZ8oecAz2rpugNmdY45njScwtB/Ag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=paDBVReetRACqlPu8FD7D3iYI7NUPCJULl51YebsRTRJU1+VmtY5dbOOztft5cYv2tPasFqBiDc0WgmHJ34fkCXTE0/Qi84eL0cCHymAdzlu894D7c3ezxXaduI4GKZtrfGfV1lzNqVMiuISyHAwyf66FsVHiKsSosJN0hPR/4s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=ZhHGvfXk; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=zrL7vEWr; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="ZhHGvfXk"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="zrL7vEWr" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653EPPnn2840063; Wed, 3 Jun 2026 09:44:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=AaS1daJiadOl7CFvexDevDHNEC99CLUDTcbW+mUV9KQ=; b= ZhHGvfXkgdKRoaL7lGpFxzT0RzRVu9MupWXqtYOLUCEvTBZDuV4Mo7AmJI+wSvCP 8tLN28jJN/TsY55B6dlEaEA5h067QZhyApu4Ok73gbU44MM+EyWc5jhYTdqEhTBi vzhP1VzhtMcDi0HAFH3BwVFuA+UNr3OtifyTrZLKpqKsogLMNl/w7ei2UsA8PdZf I4BbcI5ABV5JbFO4jQ96FlmG5cNwGe3WKOjSniygPQ417gZwMwrcMKKBIsUkUGTo HG9vdj3bPMPVaUGpMb3nid5b46HiiRLiAHJhAcX/OO+sCY3HGCtBr59U/TS5ogvJ kNf62urbAlV3hR352LKtnw== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11023106.outbound.protection.outlook.com [40.93.196.106]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4efvagedgm-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:59 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PuEhOrAZ0SjMdH/LmYPbzT++KH/pvNZOF/IiIkPyuFqdR+EpVSb4V8GTBUMYgPHpngTmGqFAM/LZrSpluBLeH9cPkSHObfYmo1v7iJqDbXlGteiZ/e2TgdrTySXP24Y+YntnkAE7WXNGFNmbrAluJBSrP1F1WLt+ckmigoAycJz3EW25yyKslvJ/C54xVyp9jD8oX3JvnH1G4Q3ld+DeSAKvuKyiHACox7r0zkU5UjC4kyHRduXVy/EV97avIEuQhJ8TSFInvWPnTWmvV/FLMVBX9cyyRmO5bTmDjrlVNbOgfPugIuvrZ6qLpWWHwUZzL+VZ0aayU5UvZ6rlnjOZFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AaS1daJiadOl7CFvexDevDHNEC99CLUDTcbW+mUV9KQ=; b=FPJwLwOohr3odVrkgV4fLfSDPFQlsrWkavUQRzCRbiz8mA35huLAGljqHyGCSHeilO0Tta1Er67SipR+Aa2/HLiaRhbm9/4gHH5L3NLirDNkVm6KE2LiaWRH5JnlAkTGUqMMWfKkSlbhi/Ru47yXMKYy6H/O9hXzAdDF9rnWd0gMX10GOyFX2S5wFUtMLGWZq13hJvV8ghH7CY1LrFLsjdESyKmKsZJoCfQSciIonx7vDw1/+M/QbG/62QAl1JOynXcYXe/Nee5EgymDs8JzmMCDeBmTEynCPAqaI3H0Un3c7kEdkwIGiWr63jnVUym4aNXZ8rJwqNyEZxbm2VUz5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AaS1daJiadOl7CFvexDevDHNEC99CLUDTcbW+mUV9KQ=; b=zrL7vEWrMU4p5P61et7e6qh5vqyhnDDdjClWjoOJQwMFRKhdkLW9YRWSZfqOVH/GLWYHxbHLpQFBXcGdI7MpQQLFb7KzJGYxosQVf5sZTfNnGayQbGssgNq3P3mVbFOZCbYCQABP4wn/d8P2I6R04Zn367HNlJiELS4dC1fibq0= Received: from BL1PR13CA0275.namprd13.prod.outlook.com (2603:10b6:208:2bc::10) by SA3PR19MB7418.namprd19.prod.outlook.com (2603:10b6:806:304::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 14:44:53 +0000 Received: from BL02EPF00021F6A.namprd02.prod.outlook.com (2603:10b6:208:2bc:cafe::29) by BL1PR13CA0275.outlook.office365.com (2603:10b6:208:2bc::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:52 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BL02EPF00021F6A.mail.protection.outlook.com (10.167.249.6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:52 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 5560840655E; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 17CEB822548; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 07/10] ASoC: wcd938x: Use new SoundWire enumeration helper Date: Wed, 3 Jun 2026 15:44:40 +0100 Message-ID: <20260603144443.593230-8-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6A:EE_|SA3PR19MB7418:EE_ X-MS-Office365-Filtering-Correlation-Id: a04a022b-939d-4e0f-4507-08dec17eab9c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|376014|7416014|36860700016|82310400026|16102099003|18002099003|6133799003|22082099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: cBWytF/LH/mlHLH4fHPRDCKf+7VjYk4/r3bemZ32f+8q4/XPFCpLuS7WKIKQoP0LpKOGXXqnI/LLVR6vzB32TyrXuacyr/fdYscPW+CjH1atFEwZiA77z73pEcDS/DHmV8UzUtfWHPXbPldtuyGcckY6iiYIWuU90qEHsseHly45M8sFO5U8HNtccABEF/P4ubHO9PFkH5i/Y9qA7nxiH7os8NvCDYgqag1SJCDInkesM2mrzyw98lOEQ9HC9KowA1A7WpX7A3odzm3vAROivSb4EFgQmHiMBY/R1S1mNcp6gkqWi7Thq14uz/qyHmTblcRCDsi5dd52+yUJ4GrEyMd6nBNvrMPNoPDfRvOLJu7+2w21P54taglSA7exSeafLJGLlBz7gG1cOalnGdeRboHbCulta7AHDz+KbZOEWQFS+J07CtVB5kukl3CYaYycKPjK2yabTgprb9jPHw97qA70tZnMkxiMogiPzQfQZAOWv6GpVmfDEsr8lomSGjSXUBwk8BSKrjQScjAa4Z2Ov4XN/zRlh3F0ZAKLYUO6abvDyX+5ook6oS4Rv1IT/csiDTzRDJBa6P14nmAWFBZeTa5OL02JJXfRb+EB5YP/qDAwSgx+Ggyovu2SOzV7OHo8Ww1MmZ9+qGU4PDTcHM42MpXaJTV085q71WqKphuMDJtGDX88V3HB0zPNGINOB+4L7iL9lA0l4RpukdK+lMXvx9G6J0NPprwupjOtwsTyAPA= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(376014)(7416014)(36860700016)(82310400026)(16102099003)(18002099003)(6133799003)(22082099003)(11063799006)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kNMT/hUUKlsTPEnrfjhfmGQ8+QSeSjTIoAVPxMcIsGSoq+3zQdy5mp6sGOYc16xNDqcP3AAKRERb6IkCgBlNId+cLFNlOXyPxidJZslCmf+RxIi+zoBbmWe/Kauywvfq0FvbjO2kQdePwieki1x2Gk4jYiktxyr4Vdb8vZmJEWm9oJJsy6HO1uvQadtafZZXmCLERX9AaBJxEGNNCJoMYOt51H8mEFc7pIbh0n6Uu5P1YtyYxJjJ2ZFPAP/pwNeAl02o2H19i04f4HI60hjUgIcAjpFhcOOFNV5c+PqZdCZ7oVZG0pI+2njTveI4H+4Px24rfutD9g+A9sbdNhVLusp/Cdum95WYdUmddQwDWPlhcYtB6OcnB0Mz8i4L+2ZDmMA4Vy0pTnHeNv4xd+snXHwyc7cNPfIisdKFY7E8z2gt8dadsV/sGh/hD12Ijp4U X-Exchange-RoutingPolicyChecked: r6jIbORPwCr8+w/nbz6JXoYWrVc6eb77ovn6GFNxNBsLuBsX5OOns09HnmzDmR8ltPErKizHxB8E9rNe3gyuVJJqEsYlF0bzPneXPDYIEabf7/CVf3Y8qqdiP1VjSCc6/J6WwWuwNaYG/fyR6CiNtU2agPJw1OufqfocBO8uHKhRslE3A3GsSiJKMoE5/ccgsnZb8WmdyXUImdMYG+L1ixILdFRsEA2SnM2UAocLBHcVpO1gBNgx3bqyqaLBmk+ZDm6mGFRnMcp61kHDXhTuaB1zjwwTaGg23ssjR86+wi57ahrVVLF86yWUm8oUSZr+EEZ4qM35cBfM3ALo291xWQ== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:52.0326 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a04a022b-939d-4e0f-4507-08dec17eab9c X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BL02EPF00021F6A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR19MB7418 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfX+1wMeodyGqzF P/ARivQQrYDfYKd4fHw0q/EMjeLRntMeqwKwHhonqgfZcTQ4tdzNtwDMrB+M4TeontwmKFrjtvo 45YXwrSV4MSibmBq3iswQLcMRv+LpzVE0MEKsH+ABXZyLT69KRA0SHXU3NacWzl1UMa94EM3eZB u/c0GtjadermSMXwBOYCjmgQPDEQiPXOORUrCiysBJ8LJ7nY1U9PTxvff4QKaDbXKaX3fxdrCSZ EKuxFknaDRFoxFWCv2tpsnwffGaXz8W1LCwIL+wV3EM9NPs5p5l5BHOXThTkiw3g0F/OwCExT5m QSZlMWd7FR1EWx1II7ezZowplf2sBxkBzJUZ+MXbcCKZqyYmuYzduQ7jFORGkkwNdYBv69CZSAb /hdSj5eEF/IDiJArd9h+/XMlhI8tLB04FqIOA7/85WKEnHxXcJizMFq8WIJAk48ca+WKKjtLwB1 1YBSQjNU+qakRCh4B8g== X-Proofpoint-GUID: hy3E8xthKrH3RhWh6oMEEghAS_V0kc36 X-Proofpoint-ORIG-GUID: hy3E8xthKrH3RhWh6oMEEghAS_V0kc36 X-Authority-Analysis: v=2.4 cv=ddywG3Xe c=1 sm=1 tr=0 ts=6a203deb cx=c_pps a=glTcUGO0A6QcesvNX5ZrRQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=JVHJYPckqUcmq-FxO84A:9 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax --- sound/soc/codecs/wcd938x.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index cb0a0bfdb6e32..c69e18667a85b 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -3016,18 +3016,13 @@ static int wcd938x_irq_init(struct wcd938x_priv *wc= d, struct device *dev) static int wcd938x_soc_codec_probe(struct snd_soc_component *component) { struct wcd938x_priv *wcd938x =3D snd_soc_component_get_drvdata(component); - struct sdw_slave *tx_sdw_dev =3D wcd938x->tx_sdw_dev; struct device *dev =3D component->dev; - unsigned long time_left; unsigned int variant; int ret, i; =20 - time_left =3D wait_for_completion_timeout(&tx_sdw_dev->initialization_com= plete, - msecs_to_jiffies(2000)); - if (!time_left) { - dev_err(dev, "soundwire device init timeout\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(wcd938x->tx_sdw_dev, 2000); + if (ret) + return ret; =20 snd_soc_component_init_regmap(component, wcd938x->regmap); =20 --=20 2.47.3 From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F086481FA6; Wed, 3 Jun 2026 14:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497955; cv=fail; b=QYxShZSTWhv3vQDi743FhfKZ/kMC7Zh01EXLnlvynW7d26O5CHJu5TzRSV89KSZQEz6ntMxW0RZSurnVsKMXfuJ+gD3EIJ30h+yCwKH5Fp4PtvI8fpReNq5Jr0n7GPzE7VE/HsKKNIAK4CcOwePeDhV7Pcnyk1J32AgsMT3t86o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497955; c=relaxed/simple; bh=vBb2gGc6Dj0RRzZmCnJpv53nN79DnrHXFgYILYaCAB0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TxMcVdlnD5hT3DUUbOlfLT/EUSNvxr2MplR7UpWp7pBP711Qi3BONhTi0mNB2RoH+GPbx+HToHvViRqlhgTsb+3aAbZ9a0IRMgMPGXz+Q9LwDRFIRDnNLQelqDFizn9xmHNyyA9+8c9KHiTUPQk/pWvQ8WwMq3/lbgf5Mi2xboY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=NBkV6MyQ; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=BM528ekh; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="NBkV6MyQ"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="BM528ekh" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653ESsro1297281; Wed, 3 Jun 2026 09:44:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=whopwarGogdFeKx2r6tS1s1Ts7Gbl/EwtMB/bDLJm3g=; b= NBkV6MyQfhF/J1N0cNAFv445UwTzAXX/k/HC+tDGtMcRgIB7iOGY1CtETCCMO1a0 GNvKJzGULs1FG2B82ZUvLWF2J3AiIuDGmqEBVlbD+q+Rl8LSY94Ntnn/FWsgQenk xix5w8WURDnQWB27ir8AOLf77kFeQR2jCD1R5yN/hRgeDLw/ehGve9cq5YoA6qNH cLH+g4ZcJq+xzDc9w6YOnwDvfXEopoxIlubZfEtCH8JYAylwpZ73yq5KzGnVw+Xx WPZD23uJVuVYOtF34VxmIYGyV/8xjmsQl3/VW6KOApDVoZ0B4j/vitT8LTeG3SRu +/bjotdtbBEk7okeuuqFMA== Received: from bn8pr05cu002.outbound.protection.outlook.com (mail-eastus2azon11021076.outbound.protection.outlook.com [52.101.57.76]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa1695g-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:56 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IwwxiarFkt3d8CtR9AGp/8v5HMzI06M+cS4z4xCCK/rKJC7ROk51OLbvjLF74rX/sZVP63/HZ0Y1Nkwo3YXlN3rVDHqq1C8hf0S9J1QrYuE1es7C4cmjr29kvlB1Yzz8wf7ra672ZdMpTiVy5tXjIFWxBsoUwJCXXPcNcJpN0LxHHTHUlzzPBoQjzE7lgROMDnhhuhV7JUroLK/YPRnjVvDfmVJ1o7+4a7kGAX+cXLSgXayJwbcF3Drt1kT61YrNvXv2c9EUK3Udid5aMzLrviZ7R5cvDruG9IbDpQAz9XSCklTy510hNDgBBw/NfY+0RD0Y8FyRKhWjuUasuj1akg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=whopwarGogdFeKx2r6tS1s1Ts7Gbl/EwtMB/bDLJm3g=; b=M58SgoURebTF6gMNBF7bMMRB7yTHID7ekw2HifwHJ1lalLsel0yMFkm+mE1WcRX9qtPGgNYtzozTZCskV6pSBnhmG8YiRJKF/nzuXVcp0hleVQipiR3X0Km3jaM1w1AlkGGXoI70YeamF97oVJOru7Iak4/cWSkxjfeVf8JY6x/kqxs9QTOLUOfiaPXzciozwSqDxwLrp8ATB+3rRDI3iU5AsTFjFbgiqEzVGbuMEJzJ3nR5Rk8Vfcj7lncfg44YDzAqEdBsw9ycxY0PNgfO8cu/dbzBDEUApm1ZFhOb0xY2gpw28YTjIbHpao6yQZB/6xXzT769f94YTdC/YJL3uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=whopwarGogdFeKx2r6tS1s1Ts7Gbl/EwtMB/bDLJm3g=; b=BM528ekhvghr9EJIa1U2ysXG2qwge2UV+oVQZZDNB2HNQDhklUpNU77Rfy9b9ZUIQeWXv3Vgd0gbCUZvTSciX0gkG0I0EIyveQvXcBQXM0bHil6Q1vboHBHEPir9YCIVd9JUzvRKr1g/epGrL+u4K1GR/eAe5E2g9mmNMYJ4TS0= Received: from PH8PR20CA0003.namprd20.prod.outlook.com (2603:10b6:510:23c::16) by MW3PR19MB4220.namprd19.prod.outlook.com (2603:10b6:303:45::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Wed, 3 Jun 2026 14:44:53 +0000 Received: from CY4PEPF0000E9D9.namprd05.prod.outlook.com (2603:10b6:510:23c:cafe::41) by PH8PR20CA0003.outlook.office365.com (2603:10b6:510:23c::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:52 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CY4PEPF0000E9D9.mail.protection.outlook.com (10.167.241.72) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:52 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 59928406560; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 1B7B1822549; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 08/10] ASoC: wcd939x: Use new SoundWire enumeration helper Date: Wed, 3 Jun 2026 15:44:41 +0100 Message-ID: <20260603144443.593230-9-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D9:EE_|MW3PR19MB4220:EE_ X-MS-Office365-Filtering-Correlation-Id: e6443eb9-9454-4f44-fa73-08dec17eaba8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|82310400026|36860700016|376014|7416014|22082099003|16102099003|18002099003|56012099006|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: laWZ51R6qAmOHkY8iVrTOV6RofGy8RapuQbiZ7NywSQOrfqVst/MhphvHYJfI6s9yjsM7+le110qf1ECL9dSKO0dxFCBgvv0bJm9anPsYj1v0PXruaYy2mb9VgqHd4KnhNF3wSwdqRegUacLO1I8jmF7gOy2iFJaQGOoVJV2ONy3WqCaTvbjSD0QWBDnvT42dxx5PJSIzp0ORPCH+SQ/Vq1oXXYT+J1vaMXgdTPo25vdL2XNMU9GpImnKI0/bD3wZTpf8fIE3aFZ650bIXK7gqIi00Ici1xR9hapnA/DKKf9jV7xJZ8DGuUjPSyCfUjCneVYHx4z5nFd3qLuBbHoi/s8xMV2ICPY0bV5aTaatPoTPUjUEbu8DNJKiQE9VP80+Iq7xEHzrdoxMz4FMBQ8dk+ttOS+aGTHqAhGL1nlch+OsDceSpP5jjDvwJ57NOvRCGXsmMcy3AnogSCXBW7+DYn+Wmvla++QGr3g1ZEpjciQoHU1gwyHFMPHf5rXD7Sf2PIJg/cODnd5HdYcBW9k5yI1ar07WWrPZR/T0RJVlKkCpq0i+EXhIBtiA95mR+58GBHpo0DBycOllXmdb2alEI4KCXNmn20YTvNCMbo6vgeVvxB0fJ8NEcVjnntCiODQVjhAMyO9LufNK0bktODyieq02Bd5ILji0Dv38E9HQ8OvBxmPNGT3c3RoEyRY+9K8bwa7YCjUPIV5vCpQYM3iXYFzTYXefWF6zKgdVTR0+wk= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(82310400026)(36860700016)(376014)(7416014)(22082099003)(16102099003)(18002099003)(56012099006)(11063799006)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bNkBU3DjPLYxj2blpVdtHibZYHxNRa0fT4nOs6i3KdZVZBM9R/c3Y/bkKAytZMBrO6iCnF/ENq50yFMk0E2Jbjsbd4ZYnoBbSwH0ZDeEhpfBa41E3gIBUkqQJlD7lVstotXPlAY5eTdNAFqMvLRe8EiXIxSRHpJGKEzu1cLksbBjmCvvYfQdresF4viUvYvodGXJnd1r38BAa8Y7g4uHPHzijifBccvbtb9eCMdV3RXAYDYodgnm1/YOI9oNWOV2mzGXeMFCgkj0XDhXRlnhFUq/r853czgQQFOE1ZThH5pCLgfKGs5pcHiHGpNhWEviVpw2ADPPib5PvCt4a2bXT26/OURVoFjzPA2z3yKAhMKQDCGS7k8Q6+pjZ5kQoM5OQ+J/cg6sTko2gxK+UjCkinRDPh/MmQ8d3WQSgjtgFfwGnIJSgMoBWh3Kj+y9DWWx X-Exchange-RoutingPolicyChecked: PMqTSfqReKOC21/t4QMhUwOxAaGaz4VwXUzGQaAj3CJdg0cJd4QTnZIgoIW2DAoq+OMPDijcFZ297mJL8ETi1NZugTem4iWxINEeRSaUikirgnEr2IJ9XtE8sjoh4hxX9vsBnAI9amgekeWwJ1aloQi8VDUi6LnMWAfh+PYCsU8I+4i6Kdx3Tg+2xeU+LO0p1TXIykMObyPyZAKdl/fc4Kt7TM4dMCl8pSKVvQxT433Llar5yUMR534AVY2KxX5B3eCtMI2oUniBBg1QyoFHr+lbaBpGQ2uv8K1UC94pFhWh34blgV9UW5tWn5hTGf4h5ppGsxYE/uoFSbLdJ5/HXw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:52.0366 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6443eb9-9454-4f44-fa73-08dec17eaba8 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CY4PEPF0000E9D9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR19MB4220 X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a203de8 cx=c_pps a=A1ZJ2ZpE7ptU6E6UTMl5DA==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=jMxjxLXPGdIgYIqNa_0A:9 X-Proofpoint-GUID: LVskp6OhDRjC0K9KEgsDVWPIhQXZ-toQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfX/a3CC7uekynw 4exk+w7VFQtfN+5amT6sfQLeXa0CjgIdTvciFxKPcWFyfU2TtB1Kt4Hby+uASZzTmv+sKmaJ7ur zEJQBrwRG8cOXHIN7gFhRrkvTdD8jYD8aRZCV4a8Qju97Hvvf/PXcDQmFVQtppR3F0LFgmLIjrf 3hs14N8WplzpEXMdogklWKaX0DIaiVZ7YJVdMi6yi2vh33vgSgcDdCkA4FhzK61QFUTQChiCrek tG/I6a8Gmr4+r8Fh5A9R3zrM8lc99cPpdP0QPt4RdF2nUMzQiKmsA+uCQLvOG7MlNqPOSIIgpnC 2Axc15yOy1OZasZV4KzvRmCuQZ2MBZaL4qxvvH107od9UMa8N+JqbKUy2uCP9yot+/i0jX7GKbX TI7+t72UtUf1Sr0KLu/AiR5LB+0pnYYqCDonEEEmemuu6UAZl8rulM80col/QUwxnne0N5i5TD9 O4CLlX+wIZN1ufmTo8g== X-Proofpoint-ORIG-GUID: LVskp6OhDRjC0K9KEgsDVWPIhQXZ-toQ X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax --- sound/soc/codecs/wcd939x.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 01f1a08f48e65..010d124667224 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -2968,17 +2968,12 @@ static int wcd939x_irq_init(struct wcd939x_priv *wc= d, struct device *dev) static int wcd939x_soc_codec_probe(struct snd_soc_component *component) { struct wcd939x_priv *wcd939x =3D snd_soc_component_get_drvdata(component); - struct sdw_slave *tx_sdw_dev =3D wcd939x->tx_sdw_dev; struct device *dev =3D component->dev; - unsigned long time_left; int ret, i; =20 - time_left =3D wait_for_completion_timeout(&tx_sdw_dev->initialization_com= plete, - msecs_to_jiffies(2000)); - if (!time_left) { - dev_err(dev, "soundwire device init timeout\n"); - return -ETIMEDOUT; - } + ret =3D sdw_slave_wait_for_init(wcd939x->tx_sdw_dev, 2000); + if (ret) + return ret; =20 snd_soc_component_init_regmap(component, wcd939x->regmap); =20 --=20 2.47.3 From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F00E5397E80; Wed, 3 Jun 2026 14:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497948; cv=fail; b=VChIxa41gHbt15bjvAUMSf7DHqNLA/DaTM4zvvC39Xg7yG1LQ2+DcRISF3kpD7+Dj1Dg9mjw8+wRsA5Rr/BvDjR+zWgfcAFr7Ho2RbI0iOUXylgO/3GMR8JV0mBo4Pm/a25N2Jc7bacToOUToIA6+nf2p7u8PQoqFrBVu789tWg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497948; c=relaxed/simple; bh=Er+cmvSPgBOjOSI238pnjachBCjIVd+5xBK2KmKnNQA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZaABJ61db7dJdhg+jtU35S2CajiZZPsNsgZp24GQ1ipaWwYNbJkwCF4vF5Oa6sIWzGK3WURcwW5szEcX5z3WilXr1uSvgQ1hKrw5/PfLebu9yFoNdwAYBLe0GooAmEbcX+1+te0umRBAfuBUQfdM4idZSuJEoDXhi1z0CvISeO0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=m2r1b//u; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=aL5xE4g1; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="m2r1b//u"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="aL5xE4g1" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653EPOp22840048; Wed, 3 Jun 2026 09:44:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=GXIy4lwH1HtTihcl6Szlfq0ozESb0OHgDePmz7aqN7k=; b= m2r1b//usWoSnREzS3a2S5AF4C/oAXGpvBsqCBZ4QVa489EDHHZrBZGcWrkeQ3cF IKJMZ0Q0qRlLMOBe9aM8kzjKT47g9Px5fVM8Eoy4LlvDk5vYrXmlLcud5/H1ZLEU d3VOGDIJB4toGnl6JTNSdsfzd93p1u+r7ycne79s16dslRtLTxTZOXDtfswmbSoW /6w/oksZd/YcJMYizcXQtXCfGfUaK5EoB9F8WiLGC2gRTQUgotf7EkKVmCTMIH9w ZB/xP4FOKU41FILvTU0zU8aLalMzeGzmJWf1n5SHo0yP4GqgF/Lqq2o0uNPQQJpq hqGJyzdPR8XakRHjhwUWEA== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11022125.outbound.protection.outlook.com [52.101.43.125]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4efvagedgh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:58 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E1K5I5s44YuJ1Jr9X12GwX5eaRDjNcHxWsi6/KSJav7EtRWtH5+CaH8qLZfRlQhvXBn2+1cVPNZrn4VIUUd5iyhfEyGt9WCGDCPHP3BY9DWuMA499l5QmUF9XMuOew4EZTnVpc+DxLv+MkMfQSNCspWE3aHSuRq/lsp6pDN41ceCX5xUQ90vRmuIeIau/eiBjiDbykTT8s8XJhOlINydmgdjuoBNNmkh29pdqXv+p7xEVaIFPaS7sDtZ0f2Y0U0x3+Y8kttT1R3cRXMxR//wc3i1H1hkb5tJcKDjZGFkido3WxWNO849Pk65ZISKrTkDcfVUJKbtrEEtFZuPG7Zh0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GXIy4lwH1HtTihcl6Szlfq0ozESb0OHgDePmz7aqN7k=; b=YGc0Tbdul4tk0i47g4JQBOpTbYOJ6JAWs9NGTq8YBJr00OvFUW3Arvhudv2NZ8+Zo2YGEFBkNr7lcVhXHRDQhCx5vYMpWiRUCwPAZ0/+vBHTlmN9DqxB4e57d2XQ6DN9CTyuMD6lkKqKpZiN1+ojdX4H0y1nGIwLSRbqSHJjrKEyHsfmFRMTVXlu0qP+yko+QpmC2D1xhTHEKoX6Uv2J/nC9Vjl+KCWA1vAeehYD/lq5nHHuCD/PaCRbMRrBuB4TrLvogGMibc4VYzjLijxpv3wJ8cy1UbKoizNXUF9HuFLlRh2FFME3EYF2Kj08dkAa//A6hpCT84QZN+C9Ny6UHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GXIy4lwH1HtTihcl6Szlfq0ozESb0OHgDePmz7aqN7k=; b=aL5xE4g1lSVX2BAN3myTjwROvMwmzN8a38YuTNJ0UGoB2jveGvoxU1WL4MhqprRXJbIADDiMCJ8msS+HD1Hd6y0cgWQoBLTJfhVvqwbIu41EPNTsLbDtPakGrSjWvMPogGY1Zi1gd9VdA+z2z3UNKPqBghp/iA/FuPMQeTYoUzw= Received: from PH8PR02CA0010.namprd02.prod.outlook.com (2603:10b6:510:2d0::21) by DM4PR19MB6295.namprd19.prod.outlook.com (2603:10b6:8:a7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 14:44:53 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:510:2d0:cafe::91) by PH8PR02CA0010.outlook.office365.com (2603:10b6:510:2d0::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:53 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.71) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:52 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 5CB22406562; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 1EFC082254A; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 09/10] ASoC: SDCA: Use new SoundWire enumeration helper Date: Wed, 3 Jun 2026 15:44:42 +0100 Message-ID: <20260603144443.593230-10-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|DM4PR19MB6295:EE_ X-MS-Office365-Filtering-Correlation-Id: 745f5e3e-4283-4b08-898e-08dec17eabb4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|82310400026|376014|7416014|36860700016|22082099003|18002099003|16102099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: lI/nkDCzttPWDCcChCegFBvA0rXnJYZh7bqbbtFOWlmIzzjNzpyghLnIvs/WIw5L+ggQBf8pfN9ToS71Yu7iTZNn23eKHiaLXP+juxJHU0d/nHh0A2s4Upe6rIb1AfObLaWmXdq+Q0wLnL6sKTfU+RpfT2KHcyY5MgRdJvjaBTsnPzSF1pTG/sStSebHN3XGvHfzmCpa5/1YTK+cfTMf2l04iIazO4X8gv53LmAqWXO+dT1ugMj7vgSS2idCiqmiD8TyfdPAm+zaLDb0aTB/1FOgPEWJQFP2ypNA1F88mMZLJtf4ZxaOflVBxzowxyXydYuH2iRhXfdl7wOtdw2WkiW7RBlkK+RLiyGbxAbhQDei5Ft1uBp8hkTywTRIviSPzUeSigw5dLhscP7AHl/WvIE2lEVLUfJwVcxCkWwSvJX7zFUzUe0NfOp4vgB4QAEjImpasJpur5MWP29+gLV4vlGIaXmSTPq9raLi1iaURxZrpwA6yqOXrxzkl2pyi9yYNq1b/m2CbtG7UWHBbaEKfamo5WnuhmeeCJLqroV8m9lUFcOk6Lb6+rUDtD2nnSwHAAwcYVgHPl3JpWyEZCcxPodKJn/6j2SKC7TddY02OEtV0mme535wyXiRbT/+zK9s6vSw/9iywhBy5Ic3R9pNS7c9drxHI2OOClemYLiyYN4zdj4+NAQbBNYmyCDnYAQBNuOx1yY1/J8C5U7+MUtsHjpR9PJgKfjhQJUVbARHnu0= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(82310400026)(376014)(7416014)(36860700016)(22082099003)(18002099003)(16102099003)(56012099006)(11063799006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mrkh6gF69tMNPgFjNBpeEhf7DuJAy04L8MEg+XKQSwfcJeIMbjJ7M10OcI87xhaSU674mqH+wBRtYKGgscD7e0j047Puuvfa5/Xi4vfE1u3VazPv+QRUyjaxzJDGxvGGdUjQqUHFP2t3qZV4H6SzBfjQ/Sc6uExh6kQZyn7LiQbgkht6IYbUOscr5NvfCOFH/ugJR3rutU4Q4mRObOmgIp60J5/0VKdRmfGxsxM4mYJ98Lu4ApXXH5Ew/O6dsFPirMbw8VG8+DkvrTq+pv2M5HE5SeIn3VCAlr3OVvqfhpkVUNzCAyZJ0nAmRjW/nqmYJtPloPccWdLR7pczyteeuUH9gIgjPX+OkkWUUVodh/yTXEljLwSmeGln9hSNrDxCfaqM8vwszs3VCBt64kPb9J9W3zrpALUft6gJp9KvuUMxSvgcsXEapB+3j4/+0H7G X-Exchange-RoutingPolicyChecked: EFYKVvNlzZS3IzD0yxVebOMlgOLnHYeknac6F1UAKoemV/roKEbacRIM22+garZfnoazAu8z6WjQREryI5r/XL0znS3VYD+maGXWqgc3Y0akH2oubTFFOkIWMdWbIyLPwr6n+sAsvmhf5YMd5EifUlbBZN8pEm3kIhsZu94iyEfuvsN1j7JRYbY442bPyijZkWllWMNzDbUM0UHL6SZwbSLM4nCD6982gwYQEtoGvrx4X7Jfv41FFneCtUBFUcP6WacMI1cuUghMKnAxwMjAg76Wo7J9iTLWr0BrRli27l8f1H85j1Uf7xs3KoKa7Om9tH7LAhNKwcMKJ9OXiTd58w== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:52.1139 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 745f5e3e-4283-4b08-898e-08dec17eabb4 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR19MB6295 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfX0uzXQGBKLpBW K/eWCAaFU+RX/m6e6jdhK9BfzJT/2wVBFgAlu1NoDyxgYnHnG44/tJwTke0jog3lGc68IO4fgW6 w/dBmUY5i7RCm/QB76Y1dYnQdp2gqYCDKkYiLpPbRUhmhXOXMgLjzJVEl/sDGOHK0QQd+xPLO9O BrOqoB2jM/JiyoN/L6hjO+WFCRgK1K8VMy6ECH16ca0w8KzsKsZyEHc6aKER4bnyQbav4vNQtWk Z4YNOzL1wFXI2j9OmixuIL8ZoX/Onk7cN7NSTm7nujaLx3zOoHecwgVEb4cDex3hh7mBAEhD70Y Pb0KbIx6pUIgH1FQEVpCa1DTtVR571vci20thT8oF8RL89/N+AKALBz6KyWM7j+dy5DDqKjlXLZ 2BQVGLWEpGms+5/2jjqYkCdH4tGHKJLKLd8dW77+cbgikVv4YUQN/HY/Eu8GubV82onosadwa+f GL3i6ZagFnrAB7LttHg== X-Proofpoint-GUID: aPVD3ZPjUJtSyifgNUKuYtF0AN4UL4ja X-Proofpoint-ORIG-GUID: aPVD3ZPjUJtSyifgNUKuYtF0AN4UL4ja X-Authority-Analysis: v=2.4 cv=ddywG3Xe c=1 sm=1 tr=0 ts=6a203dea cx=c_pps a=YMpgYF4YqoZtRZf0gxQL+w==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=RJn9l5sriXOQfstplqwA:9 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Now the new wait for SoundWire enumeration helper no longer depends on unattach_request it is safe to use from probe time. Update the driver to use the new core helper. Signed-off-by: Charles Keepax --- sound/soc/sdca/sdca_class.c | 53 ++++--------------------------------- sound/soc/sdca/sdca_class.h | 3 --- 2 files changed, 5 insertions(+), 51 deletions(-) diff --git a/sound/soc/sdca/sdca_class.c b/sound/soc/sdca/sdca_class.c index a6a3da8de4371..6937a91ddfb9b 100644 --- a/sound/soc/sdca/sdca_class.c +++ b/sound/soc/sdca/sdca_class.c @@ -38,35 +38,8 @@ static int class_read_prop(struct sdw_slave *sdw) return 0; } =20 -static int class_sdw_update_status(struct sdw_slave *sdw, enum sdw_slave_s= tatus status) -{ - struct sdca_class_drv *drv =3D dev_get_drvdata(&sdw->dev); - - switch (status) { - case SDW_SLAVE_ATTACHED: - dev_dbg(drv->dev, "device attach\n"); - - drv->attached =3D true; - - complete(&drv->device_attach); - break; - case SDW_SLAVE_UNATTACHED: - dev_dbg(drv->dev, "device detach\n"); - - drv->attached =3D false; - - reinit_completion(&drv->device_attach); - break; - default: - break; - } - - return 0; -} - static const struct sdw_slave_ops class_sdw_ops =3D { .read_prop =3D class_read_prop, - .update_status =3D class_sdw_update_status, }; =20 static void class_regmap_lock(void *data) @@ -83,24 +56,6 @@ static void class_regmap_unlock(void *data) mutex_unlock(lock); } =20 -static int class_wait_for_attach(struct sdca_class_drv *drv) -{ - if (!drv->attached) { - unsigned long timeout =3D msecs_to_jiffies(CLASS_SDW_ATTACH_TIMEOUT_MS); - unsigned long time; - - time =3D wait_for_completion_timeout(&drv->device_attach, timeout); - if (!time) { - dev_err(drv->dev, "timed out waiting for device re-attach\n"); - return -ETIMEDOUT; - } - } - - regcache_cache_only(drv->dev_regmap, false); - - return 0; -} - static bool class_dev_regmap_volatile(struct device *dev, unsigned int reg) { switch (reg) { @@ -151,10 +106,12 @@ static void class_boot_work(struct work_struct *work) boot_work); int ret; =20 - ret =3D class_wait_for_attach(drv); + ret =3D sdw_slave_wait_for_init(drv->sdw, CLASS_SDW_ATTACH_TIMEOUT_MS); if (ret) goto err; =20 + regcache_cache_only(drv->dev_regmap, false); + drv->irq_info =3D sdca_irq_allocate(drv->dev, drv->dev_regmap, drv->sdw->irq); if (IS_ERR(drv->irq_info)) @@ -206,7 +163,6 @@ static int class_sdw_probe(struct sdw_slave *sdw, const= struct sdw_device_id *id dev_set_drvdata(drv->dev, drv); =20 INIT_WORK(&drv->boot_work, class_boot_work); - init_completion(&drv->device_attach); =20 dev_config->lock_arg =3D &drv->regmap_lock; =20 @@ -290,10 +246,11 @@ static int class_runtime_resume(struct device *dev) struct sdca_class_drv *drv =3D dev_get_drvdata(dev); int ret; =20 - ret =3D class_wait_for_attach(drv); + ret =3D sdw_slave_wait_for_init(drv->sdw, CLASS_SDW_ATTACH_TIMEOUT_MS); if (ret) goto err; =20 + regcache_cache_only(drv->dev_regmap, false); regcache_mark_dirty(drv->dev_regmap); =20 ret =3D regcache_sync(drv->dev_regmap); diff --git a/sound/soc/sdca/sdca_class.h b/sound/soc/sdca/sdca_class.h index 8b63e62485e64..57f7f8d08f497 100644 --- a/sound/soc/sdca/sdca_class.h +++ b/sound/soc/sdca/sdca_class.h @@ -30,9 +30,6 @@ struct sdca_class_drv { /* Serialise function initialisations */ struct mutex init_lock; struct work_struct boot_work; - struct completion device_attach; - - bool attached; }; =20 #endif /* __SDCA_CLASS_H__ */ --=20 2.47.3 From nobody Mon Jun 8 08:28:16 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0FDA48AE06; Wed, 3 Jun 2026 14:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497969; cv=fail; b=VgGCkLQHDmwdsEThoiyhiaO/0MIjICWRx3RrbILlcanpDOQehPcvli85bFo6QZo8wmlmOYrtFJHNkQx/DJqjMsMovF0DVatDGDml3w2P9SkhvMglE31BdJHO+EOhdoYGsgAjaxGIiEJY0FRpWbYJ1gisjqstn5oEcVgaVIOCAnc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497969; c=relaxed/simple; bh=4qMgBOTlYqO46lQS7rPsPRlI8bo3Iz7/qPHzA6+rxQI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TVqOGev71m1bjwOuEGnSWrsxwG1IwM2o1649RPB/4RMNu7ULziy1nyQ+niukLfPtos1L8+o9s9SY/IrJG04snR+Ay+ucQFuGzo4zsqJt9q3DvuJK6ApEEYxfhWTDZVcUfrLnR8xGXJ4tScVaPJbiWdTVhZBpQprbtSvhI3l3bxA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=P/uR727B; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=yl8jWZJo; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="P/uR727B"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="yl8jWZJo" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653ESsrq1297281; Wed, 3 Jun 2026 09:44:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=96BiPLh+Fa+r6eD/M86QJoOKtyv7RjfdWaWnrxFsEdg=; b= P/uR727B6o6ezp+95MsFN2xMUSAoaQWioESmEDcm2bXGg7Ezmd5Dq0e69Bn1WAi1 Ntvpc3d8tHTAsjXt7ltkbsVvnMpAgCSyl44UAhXneEc8ePDPPFX8u+BwyWmLt9ty LUwM+cCLU76R3YVDftkemRSZ/wvfM41h2zVfFEUIuEtp1jotaIGtdD/PLR3pBWf2 BH9NPN/budkxPKlAX3jmuE5ILCoIvdqUZTrsKuV/fG8eqrY0/BvK8mVmxIxEHv0F q06ux4lYfx4C9lZcwRIt6HSKSOqOL4G8WraU/IdyC9DxY0BH3l/MR9PyUWi6nRtV vc9oeeUEFik5t5bf5Kb0Ug== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11022101.outbound.protection.outlook.com [40.107.209.101]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4efwa1695n-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 09:44:58 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XNTqEt1JtHEbbb74PT/eBGTT1wDcCmv2gAYlomzlc6ZjA7SaxM3LpoLzYtvo8O86d7VwudPKvFV9EQSiantsEnTeela57lz08McG4WU+lHauHX0Zhv5g9aJiZ1Y1cimi3RM1OCr+ucwK5+dPdf/XPFGd4O1khCBG0kZwwRO/4wJN0Fyy7xW+GLraAwS4ZS3d0h7n9+DVGnD4upZk0fQP4ry41uk2tEsstn+sDZGKYryywULXzdEPXFczFSTvqTTgkWiWlMJoGdgUC3uA2QCdB4yTMUPMxW0IyhQ+XyrEM909ij8SUHAB3HVlAZ+j3xQdhhwylRGiYGZVRWuehvz+RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=96BiPLh+Fa+r6eD/M86QJoOKtyv7RjfdWaWnrxFsEdg=; b=JxlJdUGSZqwy0uiap3KbSg3DUoqHcPO/tg7FZkGMzEQjxwiYm0v7EsEt7b1Axfnmq5jZswoESHkPuVQYwpA1JPvDAVcR4/VKfDVwY1D4sOrcgvYKAh9bXy2eWmmuJY81TjucuTc7uoGNsQWhOOlBgcTiC2GPQTwA6za3H3abXf0y9bmw7a2H/Ict3T8Z497Qk2m8NZoLOaELNDxFYaHL69WhNMcxJgkdlMcBokO9NJba7/NbWX0bWcAAEccj2liuShEQaK8pD17erhzpBqp4Bnd5EHwmtpiwM0OY+vPvQI5QfTAkKUBtJKaFv1Yhh73lWSHeGKCW2qAGQ3dY7Hgj4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=96BiPLh+Fa+r6eD/M86QJoOKtyv7RjfdWaWnrxFsEdg=; b=yl8jWZJoSuL6lTzrODgcX9Mj5QgE2cnIgecFk9Waex/p6Uf/05Xkpyrt3+0k1PXKsEOw/YuLKLzFLC7DB3MpecLH70sxsruXp/bAg0XMHD/cmNcepvANA/px1Z+wDgtLgh9FSt1MzrMbsXzf9ugKQDxclkAS8MkQjhrQQ1xV4uw= Received: from SA1P222CA0101.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:35e::9) by LV0PR19MB9261.namprd19.prod.outlook.com (2603:10b6:408:321::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 14:44:52 +0000 Received: from SN1PEPF0002BA50.namprd03.prod.outlook.com (2603:10b6:806:35e:cafe::1b) by SA1P222CA0101.outlook.office365.com (2603:10b6:806:35e::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 14:44:52 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SN1PEPF0002BA50.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 14:44:52 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 5CA6B406561; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 2259482254D; Wed, 3 Jun 2026 14:44:48 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 10/10] ASoC: cs35l56: Remove unnecessary conditionals waiting for enumeration Date: Wed, 3 Jun 2026 15:44:43 +0100 Message-ID: <20260603144443.593230-11-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> References: <20260603144443.593230-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA50:EE_|LV0PR19MB9261:EE_ X-MS-Office365-Filtering-Correlation-Id: c61f2330-7dca-4ba4-8299-08dec17eabb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|7416014|376014|82310400026|36860700016|11063799006|6133799003|56012099006|18002099003|16102099003|22082099003; X-Microsoft-Antispam-Message-Info: Cz+er0yLJAUeZG8FVxHT4oSCkQ/9/SlKU/M22EMvQzsoN8euflYmcTMNJKvSA2WQRV8q1Z2qG0Mxxy2McUlRJRKL1HHvGzwdjNb6HsHmQBJcpwQgOxY8/ufB/S6JA+Kag9KYA97qvhWYBItj9OSqqMJjluBn13hOjXLxPAFL0T7YVMDhf9equVimXonQGLvj3VnRezsFTNc0H9joWHhgHVvGIOASe82Vn4YQxNINqR6wNjmv6Ul1xWSUBRMW9cAk39TSLk0Xt289q6kxgfnQuMzwjd9aSwd/64WodS4/vI55zQUns68pKMVMwHyHl6r226FsBz/UBex5qzpfe3gVl54+0CrPLuQFMqA7fK1VNaGClVxlOxd4hukUv46heeVwf39qKXbk7eXHFN3N2lcgb8cQSWDIAMEtiYyQ6EyekX/O7cK6M66stLtKvGYRC56+mcW/Jy3eoB+ZYynlp6PJTLQd31FDUDpXAiyd38jo4GO/qB6ylduEv/oFRRbrrBD5PB+9qys3SWetljRQxbrdZeIPyl72tFPHj26JqqTN06UQ7qjkQ/lt//URjbwt7b5aLU51oCHCfHm99EsnYRsXonOprK+Uf+9M/VInrBnYmtcpR+LhvEfLO5+Podc3W4ZPSH74oglk3B2pO9y3EWyE3WyKQmtI1q6qb3Lb5KTe5+oAVU1k+/yQ2U0lFIXZpQlFQfxWYGpJBDtTnbe8ZZwdTElZM3G9AcE16MfBkdB5nws= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(61400799027)(7416014)(376014)(82310400026)(36860700016)(11063799006)(6133799003)(56012099006)(18002099003)(16102099003)(22082099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GE6KxA4rmYaPuoRYBH00ol3y7G9QFX6Jf7oqFdBbpoG6WzTzclivUNJy8HzYWb3tXSbOyXK5J2rmLtsRX/aFTW0jcgfRJX+WzvwzlbNR9FZCrZ+aMKWVrrp+FJVYG5C7O4z84JmahjYu9iLN0+yP6USG+/ayGPMIFNb0ud6q427V0vTxBTfxuOFC4D96IqdD6CyIgfXXIhQJEnlZ4WN36hmFl1/cJQO/zDcAjUDOoWao6f1Ily1D2Fb7rSaBcT0rmDwxuwDIpbKgCcFTvps9hfzVfF5dqNETI+OGi151yhbS+bySOoiEoYi9UwnLRJbeLNqK38Tt9fpKrDQvrbjg5MR+N0GeWc9ZUJrXadbrjbVwRf5eSsVHB7P30tCjKNiLw9oV8Gjlumw1NMptKt6HbYrTmrKWFcdPIan6Iewo994JQ0ePCJLbkePYrtvSEvAA X-Exchange-RoutingPolicyChecked: BkAuTrunUXg+m3Ja4Zb/p43UxmmyN4hdoh1oZb+tE/c4qQnD63fWc6Xg7zrg8ItDeyV5BkjLNQ2x9q5Onrae9yjESoR+WdHgMZx0mahtHm0euL1ZaOFZgCy6Yb3rTuu8ODa3h8Jm+ZJNS9ovd7Cstfzt08CnbvOB+dGJZW6mxb0vOf1w8+sOhX6/4XsEKC01XtHwV9g8B0XcnOz26kD30tFE87YSoU0mHmm1idVKaD1NmFfEpaLwlmhNyPovNDcHGDYmkT81O3m8aWgPdWbFmLgNMvMcVAKslmRTN/tQj1RzR0daufaIQzUIR0DSM/sRNQJ/atjh5LJdcr/CFfVOrg== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 14:44:52.0998 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c61f2330-7dca-4ba4-8299-08dec17eabb1 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SN1PEPF0002BA50.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV0PR19MB9261 X-Authority-Analysis: v=2.4 cv=WZ48rUhX c=1 sm=1 tr=0 ts=6a203dea cx=c_pps a=vWQ3mT+D5TKWrXkKqtKQhw==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=FelO9ux0wxsA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=fcoJ7aZ6GZweFMwf-4cA:9 X-Proofpoint-GUID: dZAsnOj19h8TGVuXzuS7m3LGaROz9rdZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDE0MSBTYWx0ZWRfX6wJNV7/ezbFd fnUlLxwrOllzmjXjm/5+q9oIxyVeblSSecQwxcVQMWEqlLic2jyjszD6Icscxy5zVjc2efdVezB VjySv4LxKZkKtjZyjMGngLbt9PRbvoP8CeXQjQoKUI5zQB2Qw6X4AP4zzX9qk04x0p8A+eDkSRW KKeIa5+2RdCHJ0zYN4EN6jF7yGPXNphtViS4psv8ncFxKj80EI51+Wkm4+tFyqWCQVURH7Vu5VL 7NwSOCl0pQ9u8vyTgeBeFun+n0ukHU6fJjjYOs/cSrywFg5fuX7llBlTE4DiYNv8zyuu6Mu03zr UitGkV3nr6gla678ITk/h5OBrCUbdrJvk3pnkjj+ce8W23QKtq0xh98OhE8d9iBHjzy1Wm8j18/ jrXKkasQaHgs5iN8DXaGnZn7lLqWxAv8mZYLynRep31CjrLd2RqL+I7nxIDiXH57QV5cIxtM86n sOUENGxiygAPbDTYsZg== X-Proofpoint-ORIG-GUID: dZAsnOj19h8TGVuXzuS7m3LGaROz9rdZ X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" Commit [1] updated the core to use complete_all() which means that the wait_for_completion() will now simply return if the device is already attached, so skipping the completion isn't required anymore. Update the code to simply call sdw_slave_wait_for_init() unconditionally. [1] c40d6b3249b1 ("soundwire: fix enumeration completion") Signed-off-by: Charles Keepax --- sound/soc/codecs/cs35l56-sdw.c | 47 ++++++++-------------------------- sound/soc/codecs/cs35l56.h | 1 - 2 files changed, 10 insertions(+), 38 deletions(-) diff --git a/sound/soc/codecs/cs35l56-sdw.c b/sound/soc/codecs/cs35l56-sdw.c index 847e88f3b2044..0a55b93b96f96 100644 --- a/sound/soc/codecs/cs35l56-sdw.c +++ b/sound/soc/codecs/cs35l56-sdw.c @@ -330,7 +330,6 @@ static int cs35l56_sdw_update_status(struct sdw_slave *= peripheral, =20 switch (status) { case SDW_SLAVE_ATTACHED: - cs35l56->sdw_in_clock_stop_1 =3D false; if (cs35l56->sdw_attached) break; =20 @@ -352,31 +351,10 @@ static int cs35l56_sdw_update_status(struct sdw_slave= *peripheral, return 0; } =20 -static int __maybe_unused cs35l56_sdw_clk_stop(struct sdw_slave *periphera= l, - enum sdw_clk_stop_mode mode, - enum sdw_clk_stop_type type) -{ - struct cs35l56_private *cs35l56 =3D dev_get_drvdata(&peripheral->dev); - - dev_dbg(cs35l56->base.dev, "%s: clock_stop_mode%d stage:%d\n", __func__, = mode, type); - - switch (type) { - case SDW_CLK_POST_PREPARE: - if (mode =3D=3D SDW_CLK_STOP_MODE1) - cs35l56->sdw_in_clock_stop_1 =3D true; - else - cs35l56->sdw_in_clock_stop_1 =3D false; - return 0; - default: - return 0; - } -} - static const struct sdw_slave_ops cs35l56_sdw_ops =3D { .read_prop =3D cs35l56_sdw_read_prop, .interrupt_callback =3D cs35l56_sdw_interrupt, .update_status =3D cs35l56_sdw_update_status, - .clk_stop =3D cs35l56_sdw_clk_stop, }; =20 static int __maybe_unused cs35l56_sdw_handle_unattach(struct cs35l56_priva= te *cs35l56) @@ -384,23 +362,18 @@ static int __maybe_unused cs35l56_sdw_handle_unattach= (struct cs35l56_private *cs struct sdw_slave *peripheral =3D cs35l56->sdw_peripheral; int ret; =20 - dev_dbg(cs35l56->base.dev, "attached:%u unattach_request:%u in_clock_stop= _1:%u\n", - cs35l56->sdw_attached, peripheral->unattach_request, cs35l56->sdw_in_clo= ck_stop_1); + dev_dbg(cs35l56->base.dev, "attached:%u unattach_request:%u\n", + cs35l56->sdw_attached, peripheral->unattach_request); =20 - if (cs35l56->sdw_in_clock_stop_1 || peripheral->unattach_request) { - /* Cannot access registers until bus is re-initialized. */ - dev_dbg(cs35l56->base.dev, "Wait for initialization_complete\n"); - ret =3D sdw_slave_wait_for_init(peripheral, 5000); - if (ret) - return ret; - - cs35l56->sdw_in_clock_stop_1 =3D false; + /* Cannot access registers until bus is re-initialized. */ + ret =3D sdw_slave_wait_for_init(peripheral, 5000); + if (ret) + return ret; =20 - /* - * Don't call regcache_mark_dirty(), we can't be sure that the - * Manager really did issue a Bus Reset. - */ - } + /* + * Don't call regcache_mark_dirty(), we can't be sure that the + * Manager really did issue a Bus Reset. + */ =20 return 0; } diff --git a/sound/soc/codecs/cs35l56.h b/sound/soc/codecs/cs35l56.h index 6a27ef2b7569a..9acd2e7e17c93 100644 --- a/sound/soc/codecs/cs35l56.h +++ b/sound/soc/codecs/cs35l56.h @@ -43,7 +43,6 @@ struct cs35l56_private { bool sdw_irq_no_unmask; bool soft_resetting; bool sdw_attached; - bool sdw_in_clock_stop_1; struct completion init_completion; =20 int speaker_id; --=20 2.47.3