From nobody Mon Jun 8 08:35:57 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09659332623 for ; Wed, 3 Jun 2026 14:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497099; cv=none; b=dNTUQMif3JPFkoMi8KTDBwJ797+gCNBsBoPtg2uy+Jr8aqiPCQHfsqMGXYj/2z/+hm6jG6QztEVMY+futMKTtzpKZ3HetmAav7uDsadNKjmWnQubeBpyw0Y4im/nX+0zyShplt9FVd11fvtYp7w4bRl70jozPizOTYMFcsyAB34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497099; c=relaxed/simple; bh=PJVJnAZf4a7XwOjdpZ7SCRkj5FZGXwgZPu7OvbbLN50=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tkDq7pp+jOUKtdAqYhvJT9qYfCHBIl3ORc/Ld3KxTBWDnWM3GYZtnSoMK9f7rnX/XMrHrt4jTyr/CaI3qmoevGaP7gcL8u5/s6jo0TZcia9ZvS5mcj0iCNGmEGnKrX/kDObLOfGQfbT88IROc4VqgMJnZ27dd4G/pbIN3ENV1Ns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FEmgtKND; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FEmgtKND" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-45ee6d32402so3733922f8f.1 for ; Wed, 03 Jun 2026 07:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780497095; x=1781101895; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q3tQtc8uJKCPmpmDRcr+GJZB85OACAvXLNmzr/e668c=; b=FEmgtKNDUeYs5yLiNrP0VgoLy2oHFNO5qHERlduLTZycUEKbaB8xHKqUBjtd3wpwa7 35++BD6bvYWuX77BICDohYs48eV4v/hy5wIr2cK0yDXZO6E/Wdd9qVSOmk7uxPZvS/MV Sw/pngZHKsr/mQxrcPCaE0EjI4V0Lqv80E94OD/KFLclk4q+f4fTTIYtFI+Iv6ZXxwFT 5MUHIbNAAJ5HE4aNKMGCJy7iuHvP8ymzK9PRNWj55X6tzHzbrrNxr5CWH5Uujlm8jYw1 4Dxl+jr5EEqHRZsq7wpxnM/uRbw7KRiORGosHqW/ZXQTpaDh/1lKfv0Ppl97C6eHAI95 zCFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780497095; x=1781101895; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q3tQtc8uJKCPmpmDRcr+GJZB85OACAvXLNmzr/e668c=; b=snDj0NS+9USLZeg0owue3qw9iGYYQY4TwnqYepswmx2GtLTuUIippY/6sC8BfNThw6 VvLGL7nEsg4K3OGSosMGT7B0WyIJq+ZkX/wwuj79fPkRnbZ5tyG3SpOofWJbU/4NEIoG dlGFn5A+uBEUww8mJmv5v4n2fj6ChKTC0BthJciQdYaBLUGpICBN2TOc0qFpc9+DwdTQ hJC2FeNGNme1/aMW9tKFqkox0dYpz/nPvymN9SxkvVvyVvGlhPKkyg4lauqaQlVuy/xi PB9buuaybqQfeJz4gb6sRpkTYwhk+kUh8uLhXATQPHO3VomOjWjUFCI1fHhVPc3+Wf9N +wTg== X-Forwarded-Encrypted: i=1; AFNElJ+p8KerVT+qOHneV9SvQRx7muwuGwzuQZ0ntVcsLZYPTwGLJaKqHdKDcZK6VcV9gvTU/RDcF7CqDY5fJ70=@vger.kernel.org X-Gm-Message-State: AOJu0Yzbv0ll4Hi67CHfr7GHA5mNcjFBYk0Tn8WU4Iwsk7x4cgwSxgyC L5EUV53r3CQqSh9Oi0Q0BWn9mmUmaKn2y2XeadRTDDWuI/zdoSyhiVl0U0ksHA== X-Gm-Gg: Acq92OGmsQn7z4V/g5ec89+6KDrVY5Xg2nc80v9ID1H3c0sxTApMvqMaamW2jGhLQnJ IlLYEI9VeqgpxBMyimxTSNSlw/teeexJQjPx0AbXBVJyrix1pausoV4YjDUY8gCbMcHGdTP+4U4 kkPolym+xV+MCACQXoCfGhNvYdoJjKL1BZlWsJSlQDmStXc4u26V3R/uucm7St3yjt+Yriz5NQv TvEcN+oFjHbSkQMwPSnMr7Hx+oNPCsQTZx/8x1KwP7O7vB441/Pxg4HfJgLieBgIh3wRCypymCl mseVAToxTKqieOztYRxyou4w+eGJpleSRxvGkqmiuJg5fjKp+KN/k+9dIm5usMBfCxouRg+VBMV 2uoBEqI0hS326uec7B75KVhKPXqgPhKvx/yNX1/7vYS8fwoEI2qVKgwXB1gvxJHDAE0Uj/p0rN6 5LrYNzIG4YOLLhuY8wYVqZ040b4v6s9Ptt4Y4oAWVBpJ6oaCb9Cv6A8+jlTwvvuvKgzYyYjWm22 39cRa6LXEHVH603 X-Received: by 2002:a5d:5e0e:0:b0:460:e4d:bd46 with SMTP id ffacd0b85a97d-4602181f3b3mr4268953f8f.21.1780497095168; Wed, 03 Jun 2026 07:31:35 -0700 (PDT) Received: from fedora ([105.156.125.135]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f35133csm7448183f8f.25.2026.06.03.07.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 07:31:34 -0700 (PDT) From: Jad Keskes To: linux-staging@lists.linux.dev Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jad Keskes Subject: [PATCH] staging: rtl8723bs: replace magic numbers with named constants Date: Wed, 3 Jun 2026 15:31:27 +0100 Message-ID: <20260603143127.343103-1-inasj268@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the magic numbers in rtl8723b_InitBeaconParameters() as requested by the outstanding TODO comment. Replace 0x6404 and 0x660F with named constants defined in rtl8723b_hal.h alongside the existing beacon timing constants. Signed-off-by: Jad Keskes --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ++--- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index e794fe3ca..c5da5d0be 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -878,8 +878,7 @@ void rtl8723b_InitBeaconParameters(struct adapter *pada= pter) =20 rtw_write16(padapter, REG_BCN_CTRL, val16); =20 - /* TODO: Remove these magic number */ - rtw_write16(padapter, REG_TBTT_PROHIBIT, 0x6404);/* ms */ + rtw_write16(padapter, REG_TBTT_PROHIBIT, TBTT_PROHIBIT_TIME_8723B); /* Firmware will control REG_DRVERLYINT when power saving is enable, */ /* so don't set this register on STA mode. */ if (check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE) =3D=3D false) @@ -888,7 +887,7 @@ void rtl8723b_InitBeaconParameters(struct adapter *pada= pter) =20 /* Suggested by designer timchen. Change beacon AIFS to the largest numb= er */ /* because test chip does not contension before sending beacon. by tynli= . 2009.11.03 */ - rtw_write16(padapter, REG_BCNTCFG, 0x660F); + rtw_write16(padapter, REG_BCNTCFG, BCN_AIFS_CFG_8723B); =20 pHalData->RegBcnCtrlVal =3D rtw_read8(padapter, REG_BCN_CTRL); pHalData->RegTxPause =3D rtw_read8(padapter, REG_TXPAUSE); diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/sta= ging/rtl8723bs/include/rtl8723b_hal.h index ffd039278..311acfa0f 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h @@ -71,6 +71,8 @@ struct rt_firmware_hdr { =20 #define DRIVER_EARLY_INT_TIME_8723B 0x05 #define BCN_DMA_ATIME_INT_TIME_8723B 0x02 +#define TBTT_PROHIBIT_TIME_8723B 0x6404 +#define BCN_AIFS_CFG_8723B 0x660F =20 /* for 8723B */ /* TX 32K, RX 16K, Page size 128B for TX, 8B for RX */ --=20 2.54.0