From nobody Mon Jun 8 07:24:43 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793CE44B66E for ; Wed, 3 Jun 2026 09:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780480595; cv=none; b=SLAaT9VG5ZdCImw6Y4vZzo7MDxstSwt2nCp6K+wGmyZjegvQ3pGsTRKhfyMKusRX5C2W0RZRi3ycdRauxXTn+jWN6J4n4MSLHKcv682BmEgPXvqKw/ZJMG1Rrge69nJEJtjmIXtfw0jbIh4Z2h2cJBbE2ObelrHXHVt1+T1b1DY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780480595; c=relaxed/simple; bh=h0GCPRfZ56Gxbea6qEAfu6YkFn6TF7RVgzes+iDvugM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=A6XTjw5wH/uTfEs8rSVKeVisQaoHScWBZDO99hRWpvP2huxYhY8armUNk6m35jXZjC79qjuhuCzWsnKUESWCWhTWrAN7HHxrvQuGfxDDfL2yNCEAoE/Hf+jf4DBC9J1GGZ8N0UruxAsREHdYeEBVphHcqLx93e2fcZYyduenpaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=ANYc6we3; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="ANYc6we3" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-45eedcdaeaaso4362015f8f.3 for ; Wed, 03 Jun 2026 02:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1780480588; x=1781085388; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uaAmYFcDIpEYne8PHc2ww/mb9Tv4n8AUl2bEA6Ewd1A=; b=ANYc6we33voJJAis1M49KWFYU+GAnXkVehYZiFfab9qf3ryIjTbLjsVmorVntPnSDw ZfJwlYaWVpwafnPNBdaeb8EutJ40ScaqSbppz3H9ZoiIo0/A9w1WXgw93Q3E6rWCNLW2 NmjI1q9b/UvnE4Nvp8znkskLN7GracQHcT7UoHelg9BiPtk5CQwUKrl4JcK0SiJOyKSU lnogNOXw29vGtcJjKeDga0zVqaIDLnJ4dDSaBrCsnIA6RlwnbswVnR3flqgn4w4WeM+p xzf2hA0W737F9LEFxJ1q57nnluXte4Y+tgClcQ5BiQZrb7wignHClDWa070hyEPZMw/d FKqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780480588; x=1781085388; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uaAmYFcDIpEYne8PHc2ww/mb9Tv4n8AUl2bEA6Ewd1A=; b=b980QnYyT37kyvXs345RB4g0i+sRWZYxgOwjouJRGp3733AGfaOfXCUvL12RknRMPQ L64lMcLt+5uCIti6P0sgZHYBWhfqzx4CRabiZUDemIAEKdr4HtccMyn86WJJ+ue0Id1a Us8a5iJHSVIQm/0GrdW1z9N+ysItJ4C+I2jFf2W8dJ190XUxCe1LFhjynTQqJ0zfI4mU C8fvBo89lBRjEKcbPXZg/qlrj+VJrto3OK7Rvn7HH7YdASwFah4ltsRhwSGWdG2AEgdy jGiTNiyPpgwGf+4U6YiT7W6gQjzaeTEuynkSN8sAfWcMgMpwss//KxMNubdrDtv/S7V+ XuFg== X-Forwarded-Encrypted: i=1; AFNElJ+wu78Qp6vUL5hnyed6HFBpGSuW7sY2bIxyRNxpu5H0TT2ZbmY5WPJR8tzsKORsZGK7JGHBdzTiWplEvkQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwvZkW+btceFuKPMKQe42eekNBPE2kY3gvAuyFkUuoCjrDUu98b VVpmJISvmjBpgD91MjP1GL+zFGMImLBIkjQf6isntJbIhqXctGp+OZBf37gtLvoMfNqS/NykZHG lk1rfYy0= X-Gm-Gg: Acq92OG2+r0/RfGzYr+PZHPyny5uX2ha9HNcA7M2mgLM6D6R/Rabxv5CRoUQXxmGeUp RDLJzZyz4HR4FZ1JtWgQYGlt8xVcKxSF0YrBcsDrfNfEm3bEhuWL4CSt4CnJ4dP9+Uq1CsTNJf4 ssryssSWGo5e2k7ad5uHjDKdG0+nyRArz5UxjGj7PrnX4oXTK8zg3RoqtT/V1N/dlCgn8r9wYDu /ekL9LdJtvHdrG5XmRp+6qjCw0evSOskF6dv/X+PsHK16Ed6p8tU17OO1rf7dhrgQHB94Pi61ks 4WMnbcyz0wcHyXOAmTatEy+Rd3DZsqZgAh14E+2o9ZfgZoB4kf7ZI5tp1c56MVRUV8IzN92U8b0 ZS7cafBOeN107JNEZ3JsWaoWC3ftH9uyH/SdJWQ9qpgXaEpRUFplpMDNwFxtseeacP1XODnq2WD q+Y7tX5ARaLnJqu3lSmoCcDnRQrvg4aHUv X-Received: by 2002:a05:600c:5288:b0:490:6237:521b with SMTP id 5b1f17b1804b1-490b5ed0021mr43592885e9.27.1780480587687; Wed, 03 Jun 2026 02:56:27 -0700 (PDT) Received: from localhost ([90.85.134.233]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-490b6162289sm46455705e9.6.2026.06.03.02.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 02:56:27 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Cc: Florian Eckert , =?utf-8?q?Martin_Roukala_=28n=C3=A9_Peres=29?= , Kees Cook , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH] serial: 8250_pci: Don't specify conflicting values to pci_device_id members Date: Wed, 3 Jun 2026 11:56:16 +0200 Message-ID: <20260603095616.937968-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1794; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=h0GCPRfZ56Gxbea6qEAfu6YkFn6TF7RVgzes+iDvugM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqH/pAX3O/RrbBlXEAYQhu7mzHOhWwxKz/IA69c JY4vDOjjFyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCah/6QAAKCRCPgPtYfRL+ TrvmB/481bkMr0Jy484kMJNcMO6QvmZHKju5WwH474C6i+WGqlgxAFe34YOf0JM+/mgz1ExlloR BX9UVUGYuJYImdefZiR/OLhj6nNo3K2GSrVLEYSNsBiONnaO4CEAU3IJuRAVHkKiYWQ/+VNyveL 8ozTLqPo3qUHZiube7rBvgQ0N+RCYg6xRCd3XJcDogRZmBxzaeqpN9HFcYpsv3prEijT9H/wSB4 OynZnkNGphqnf16s0hzyqvpikK44KlH+aVvnucwQbcULkEjDMz/3ltWS1/m6UhLK7Qz8IOsEPh/ lEgJ+syCno3X48EKrs3r6cBAD4/kd1LvLQitdoDZv43RFdU2 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The PCI_VDEVICE macro assigns 0 to .class and .class_mask to allow the next value in the initializer to define the value for .driver_data. So the construct { PCI_VDEVICE(INTASHIELD, 0x0D21), .class =3D PCI_CLASS_COMMUNICATION_MULTISERIAL << 8, .class_mask =3D 0xffff00, .driver_data =3D pbn_b2_4_115200, }, introduced in commit 44e55f1f3088 ("serial: 8250_pci: Consistently define pci_device_ids using named initializers") has conflicting assignments. In only some configurations (i.e. W=3D1 for me) that makes the compiler unhappy. So convert the two affected items to PCI_DEVICE which doesn't have that hidden assigment to .class and .class_mask. Fixes: 44e55f1f3088 ("serial: 8250_pci: Consistently define pci_device_ids = using named initializers") Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) Reported-by: Andy Shevchenko Reported-by? Closes? Tested-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8= 250_pci.c index 3e5bc9e8d269..58b4e525bdb6 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c @@ -5394,12 +5394,12 @@ static const struct pci_device_id serial_pci_tbl[] = =3D { * Brainboxes UC-260/271/701/756 */ { - PCI_VDEVICE(INTASHIELD, 0x0D21), + PCI_DEVICE(PCI_VENDOR_ID_INTASHIELD, 0x0D21), .class =3D PCI_CLASS_COMMUNICATION_MULTISERIAL << 8, .class_mask =3D 0xffff00, .driver_data =3D pbn_b2_4_115200, }, { - PCI_VDEVICE(INTASHIELD, 0x0E34), + PCI_DEVICE(PCI_VENDOR_ID_INTASHIELD, 0x0E34), .class =3D PCI_CLASS_COMMUNICATION_MULTISERIAL << 8, .class_mask =3D 0xffff00, .driver_data =3D pbn_b2_4_115200, base-commit: 44e55f1f3088e4a471a943fbcf087ea7783a0199 --=20 2.47.3