From nobody Mon Jun 8 07:26:03 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12CE0423164; Wed, 3 Jun 2026 08:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780474916; cv=none; b=bhZloUpMf2e00QryBQseQffeFvC237MW084kDKNQvvag3NIm9Y9eSLBppEhxr/8p4kcBrkcYg4CoqY/KMBfUkUfzQv3sultP98rTVaeGuKMuYoN4FTqBw2wPnhiV+dB0QEFg8d+RjeyPuxE1VHPA9HU+HmE4rKET1lxcA7nnpII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780474916; c=relaxed/simple; bh=pYhGnlXp7CqTivc0W0TtUSsSjnWnMGQykmALPzcWqyI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=C8pgExUyYe5O0d8XUYEFkL1aV3QutkXYick5AgiaqRxZ87R44bDCCC7D/w+AVYrea94ocBBirRv1ENw40ZeEK6PSc7SlaOeQS6UhCvE6JtS+Ok+XQvMWLlwoU/EqMRtNl+1zqbslp9j6Or7n0ojjeLdWoy+UOCoOhMWswhsOoW0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-03 (Coremail) with SMTP id rQCowAB3W+Ie5B9qbix7Ew--.18997S2; Wed, 03 Jun 2026 16:21:50 +0800 (CST) From: Wentao Liang To: herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH v3] crypto/algapi: fix refcount leak in crypto_register_alg() Date: Wed, 3 Jun 2026 08:21:40 +0000 Message-Id: <20260603082140.3719314-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAB3W+Ie5B9qbix7Ew--.18997S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Jr1rur18Zr1kAFy8Kw4UArb_yoW8JryDpw 1Fk3yYkFW5GryxKFW8K3Z3Ja4UWrW2kr15CrsYkF4Yy3ZxJwsYqrZFy34jqFy2krZ3JFy2 qrWvkF1YvF1DAFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkK14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v2 6r126r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrV AFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCI c40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267 AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_ Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbYFAJ UUUUU== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBg0HA2ofvLubrwAAsJ Content-Type: text/plain; charset="utf-8" When crypto_register_alg() calls crypto_check_alg() successfully, the algorithm's refcount is set to one. If the subsequent handling for CRYPTO_ALG_DUP_FIRST fails with ENOMEM due to a kmemdup() error, the function returns without decrementing the refcount. This leaves the algorithm forever pinned with a leaked reference. Fix it by calling crypto_alg_put() on the kmemdup() failure path, matching the error handling used elsewhere in the function. Cc: stable@vger.kernel.org Fixes: f1440a90465b ("crypto: api - Add support for duplicating algorithms = before registration") Signed-off-by: Wentao Liang --- Changes in v2: - Clarify the refcount lifecycle. - Fix code error. --- crypto/algapi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crypto/algapi.c b/crypto/algapi.c index 37de377719ae..260d03b328ec 100644 --- a/crypto/algapi.c +++ b/crypto/algapi.c @@ -446,8 +446,10 @@ int crypto_register_alg(struct crypto_alg *alg) u8 *p =3D (u8 *)alg - algsize; =20 p =3D kmemdup(p, algsize + sizeof(*alg), GFP_KERNEL); - if (!p) + if (!p) { + crypto_alg_put(alg); return -ENOMEM; + } =20 alg =3D (void *)(p + algsize); alg->cra_destroy =3D crypto_free_alg; --=20 2.34.1