From nobody Mon Jun 8 07:24:53 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013042.outbound.protection.outlook.com [40.107.159.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 548B9399CE6; Wed, 3 Jun 2026 07:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470831; cv=fail; b=hF3R1FpnRYzRwbEOzOSTLSm3ESWx/ynhff3R8KsBerF5R911DAmi/ls2kbvCNBl1xsFX1LuxoQLzHw1ziP9LW6GQ53C5dP21fildahkK7LvCW/t6M6YvfbyNFQe+e0UUily9MN/sL4o3ifTKmCoxCoWcMQPvZQda7SXVj/7H4Ak= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470831; c=relaxed/simple; bh=VlaV463z9LAC1wNALjkbRCbO3hKIHhq6Xil8Uqyaj98=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=cvIG80XkFWCmGtEnkH/JwjsWQTqeE4Ui1dj2dD8vZBz1NhwBmPLalsw9uVq6HbquffOoZ/lO49qQ13/67KGHRRzwxY9deSv7+2EqHvee1AxgJ10onDkg07sk19f/GUXa1iC0KkuqxyTRqITdUzxLh/DmhrRPobuUBtALCUrus4I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=QJSPSwrV; arc=fail smtp.client-ip=40.107.159.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="QJSPSwrV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Lem3YaTpNApEnT7EytUJP6/q2HOgn1LD7JlCKAnrUr6xvFLR8z8LCLU8oSpqVuATwn3P0VR09IAPTCUNu+1oCCUl5+kDd6bFME6yqXDuCnbLIPEZSn6G0yPYmmXc7ZdnaWku2B30FIynb0CAFVohryq1h3RB7I5//hGlAk+6HiPjhRCl4Df8fsiJSC2bI27ONUj2rf60f/O5kWwBhQ9R2ccFCedlVu912hDLAsMPaXcX42TYPaN/Y090jW4G5zRXs0wif85z2YfKpZSrT3eAMlFmFnou1VXVKXw+Dr69pTjdL1CL8PIT5aLOY5klztGIId5b+QMVgXdHxl+nSwoLmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jXj4YTgfkV97oBYFc/OQX7btN0RSqrP0NjNGEYWi1+c=; b=OIChm+orKHWGw5M0gtYHIaZNPdoLPaXYUpJDYoxQNRiKSpmdDuJLgoBjaHksTf3dhfzA415eq/RGSBQJUZSUXuez11O5rWBV+fPpmsg3+yXKthZ4gmaUvxZR8ByC1OZkBDlaGjn3IoniBKOGztCWNhdk8FSZ3GuQAcT3hJ706DuEWtej7c0MAuFpizTwqKip9XlzzHiyLT2dIUGg7+bBCmx1PuJGChnjKPQVB+L/jbdoHTsVWTj+LiLFka1r+RKThMGl86JTGqah05c9Zjb2YZQ6wp+V1qjiPrAjN0M6j5lb2EVlzE0stx3DwpQBe9FswqNtnB+XXRaIiePlNpnpZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jXj4YTgfkV97oBYFc/OQX7btN0RSqrP0NjNGEYWi1+c=; b=QJSPSwrV/34c7WE9rNF7a/ZvR6x0PXqfxowcI/2pO9lBdAUdyPEMtip+i4r0Es8RQey77DEbY4zGdF0TQp3hqeW2t21gi6QIZrrtp8FupAyPu1VLbgPDhSEFfbRS1+FnWo/t0qJVtDdZTANJS6678fUK+20m5/bAooj8Y5Wt5jgniuU3vqtTac77UPwtaWGLTXcLASsxs3pywqc7sbOSCTDWQKCg2L5CENkVGH4/j9DhAUSjEYEZOvk1dN0WyT3UX+f6IYT+kPu/kig85ZHYVH6shdAKzIc/olOnzVUEneeEW+hSJSKWx2U2a3tHjyg06LZN2HcPRiz6yMj1VaABoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PA1PR04MB11406.eurprd04.prod.outlook.com (2603:10a6:102:4f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 07:13:46 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0071.011; Wed, 3 Jun 2026 07:13:46 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea Subject: [PATCH RESEND v4 1/8] can: flexcan: use dedicated IRQ handlers for multi-IRQ platforms Date: Wed, 3 Jun 2026 09:13:35 +0200 Message-ID: <20260603071342.641874-2-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> References: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0268.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e8::13) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PA1PR04MB11406:EE_ X-MS-Office365-Filtering-Correlation-Id: af15ab3c-f6fe-4f7a-d9b5-08dec13fa71c X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: G5fcSd0s25Pmtek90um017XRjbe3E0fscL4EVjPTRq6ILjtSaIXsX+LX1Yt/GLY6SVFwTdSfYzMDI+pNswbYR3KPfWb8OtuJ7ElPCn3NC8wClWB4xuEaotkt/mBvbM7VEVnQkgxUKnZELP80OrrWjqwiNuh7k3c/md4eQ3v5IVDQ3tp00iYXTNrGMxbkDaUCgLmQ9753btG2gFUaH86kkh+NwRY9+DldowTZi1iG6axwZ5VUmSLbkKdDSp9h2oLTTCrudgkw+cYsT/4NmXGHPKF2wvNJV7vlAeGWn8p6GyfOzRhNS+it0NIITLgb+yVWbF3q0oEdJtH9WlhXcGT2dQa1Yfovbvs+eOZ10XEyf3IBlsgA5nx7QyF0hfcC0iyIobDWR9gP4nF0Gu/eABXnByx/aoP3uSeYEhxRrO0RHb2CSzzM+/dho6Lnemu++vt4ItxjxeaqdmEGl04f+WzLvZ4S19vZBgskhND1+VUCL9uG/lSvVxp1TvAgb84uIdnsJHkM7N+bOqYJjP9vDwl2tM2iRjc23Vzd+6WDwpN3xEiE3xF4XdtOLgpqz/WKQ/ctsQrp0xO37ACYBtD0rMkvfo+qUgpCVH7C/x7HguF2+iqw8sH9ewGO6QcHJZhpECAzbcj4dstu0k2rQ3t0xKmEQNy1gd+uNG3dBnOp9fWgXjdzpBTA/Kl9MQUb3i/WDdSd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGdmUHYvbDVKUTJBcnBxa3BrQ0U0NXp3YmQ3NHYvdWdCUUQ1cHN4elBYdmJ5?= =?utf-8?B?WW1haGlmc1FyYXVFWVZMSDlnN1NVeUZISDFRZGsvZ05jdTh5UlN5SDliREhC?= =?utf-8?B?VTlBeGJPeERsUFFoakNzeFZtL3JtL1MwYisvNGtUOGNOaGNObjAwd3ZGaFhL?= =?utf-8?B?S0NBUWhzV0daK1B6V0liajBUejVJUzFMejhwZmVwYWZpZGl1aEo4NXZIa09K?= =?utf-8?B?d0Rsc28wUVZrNG9DemcyRVRyYU8vcFBJYnBYRjdTYzJkbXpiZmI1UVQwd3Nh?= =?utf-8?B?Tlpyb1dBeFJuZU9YRUNLcnFRbG5FOTBRb3dpUGRSZkh3dGFLdGc4UldDL3Yr?= =?utf-8?B?dTFqSC9hc05mZ05LMHJqRW1BNE1iYW1KQ0RTWm4yNGR3TDAxR1BiYWV3Sk9i?= =?utf-8?B?ejVBQXZucGNYOTNGbStiaXdQYjZTQjJScUZEZHVLQ3doRjRYRUt6ekdCbjh0?= =?utf-8?B?K1NlcmtxckNTMTBmaHoyZVIvU1VmL3pXZjFSRk9hUjNNanp6OWUwMTFmQUhl?= =?utf-8?B?WVBPNnMyVndSV1FZNVU1ZDFKTThZWWZ4d282K01hVHdINTI5TGYzTnRkT2hk?= =?utf-8?B?UW81UHorQkdBQ2svTXBNd0M1M2QrOGhKYUVBVmlaR2thSHdIaFBnQUtCamg3?= =?utf-8?B?dGNucDZrL3JNa3pNbFNZQUxmU0xFS0QzUTVrVnlXYmExTmVNdEFabTVyRzBj?= =?utf-8?B?NGNlWk45UkprZ21WVDh5dm82RTh4VERvN0JrdUNKeEQ3N2UvdHQ1S005RSt3?= =?utf-8?B?ZFhXY1pjL1dGMi9ubGFKZUk1TGlGcjJrTUpxWUo0R2xMYmh2K2dqVTh3SXJW?= =?utf-8?B?by9zbkJNSzQwV2Z1QTloQ1MwMDlpR28yVlNuQmhMRmI1bDdKdVFCUzJNbG5Q?= =?utf-8?B?N3E2K20yaE1JU3lSYjA1bXFvM0p5N25NdTRBUjQyaEdoZm5pTHAydkNCaUht?= =?utf-8?B?OGZzOGVkY25vOHIyeWFCUTd2RXM1WGEvSExXVldHOHAvQ3ZweUM0YW9ONVV4?= =?utf-8?B?UkFJaGZQNlFXUHJZcDJiRS9rUlJGd2RCTmg5QWVJRFZGS2hMajZ6N21ycG9W?= =?utf-8?B?UE9ISE9tN0ExeXUyaU5mRkxjSWVkZ2prZ1R2bW81MHJORXo5UWMvYmJNcGxV?= =?utf-8?B?WG83dFdWR2tURlo5U3FTOXJhWjMvU0JTUG9pYUVRUks3UzhqR2doRWJyTWI4?= =?utf-8?B?YTU3MzE1Ujl4alNRQWJWLzk2R1JJK0xMSy84cGV5ZGhRWTl4SnhSZS9UdXFZ?= =?utf-8?B?TS96WXNSdmEvRVJYcmplTStOUDBFSnE2bkhWZVErQ3l1ZkF4Ym1tY2lCSUZo?= =?utf-8?B?OVZneSszZzg1VDRWWk96d0xqNlltbmtoRXRjbERWSzN1RzBWNXF6UFhGeWtY?= =?utf-8?B?SUl4UUxvREFOOXZ4aGh3Y0lvc2JmMERBMVhLdjNFb0lFU2Q2cXNBY2gxYW00?= =?utf-8?B?VVRJdkJnOUNnRnBEU2hHSm9kbk1Oa0lFa3BqQlE2MXFpd1RQY3J0bkJDMXJi?= =?utf-8?B?VVkrQ0QvcytVbHJzSlVTc3Q1N1VjQlNlSmR6SzB5V0hyem1YSkpkalpWQytN?= =?utf-8?B?ek1SZGRUY3FJNVQ4OTc3S2w3a2Y3V2FzS0NTTzJEWnhCU1B6aDNhUDFRM0RN?= =?utf-8?B?S1NnSmZCUzhKaE1HcmhHSDhuM0wwTkRhRGYrSmZuK0FHdnFXc2FyZHB5b0R3?= =?utf-8?B?NWNKQmpTVjNoREFsb1dLTEVVUEY0YnFxTWJoR0c3QU5WWUlCYW5VMGlCamQx?= =?utf-8?B?aGw3bTFqbTJEV2N0Y1JydnNxamhYc3FFWlNzRFc3MWJZNkhSYnRvMmFTUWJQ?= =?utf-8?B?c3NMNTJMYWNQUy85SXJNcmUrcXJzaktraE5mZjhNR0I5c3llUU92ZlAyR1Vr?= =?utf-8?B?WS9OSnZnNHR6RGtVUzNFa0Q4Mlg5cVdHOFBPazJFTS9LTlJXNTVxTjlXdlVH?= =?utf-8?B?OGg4K2tZaUlJUGhTYTI4YkFNcUVNZEYzcGZTalZHQ0d2dEY0WHR1cUFqdDdo?= =?utf-8?B?cVc3empocmpSeWc3NmgvYzRkR3BjeXlEck9LeDIwTVpCcm45M1p0aHh6dm44?= =?utf-8?B?cVUzYWxhY09CdURGUTBTbXZxSHhsMk9YU0JLb2FWR3llMzUvNkx4Mm8ya3dX?= =?utf-8?B?c24ra0xuWEhLSFNlSm13Uk5sUFRoMkFXNlRkQXpMbXgwb0VOWkYvZEx0VUt3?= =?utf-8?B?cSs0R20vbVBOaFl4djVkZDVQVnpLTHByMkxOVUcyOW1rNVVJZURqaFprb2NS?= =?utf-8?B?ZkxkaWFCUFBCT05KMjlPOXlMUXprdk9WdVcwbjFJUmlGVFFxbmg4QnU3Q3E3?= =?utf-8?B?Zkk1YzdzNmh5LzlCTG9aNnZjZ3ZWQmo0dkJCSEhPd2h1eEl6eGpEMzVucm1E?= =?utf-8?Q?X2C4tmQvsBvp3Ms8=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: af15ab3c-f6fe-4f7a-d9b5-08dec13fa71c X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 07:13:46.6566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AiSPhmX2uyyJelxMvbCgPBAk19rvo62ayDJXq1Eri1FXdJb99Nk/emDMq0eIqkM7wTIkvUvT+3AQHflbzvVv7haM3LnTcz4lFei3jfMnBGs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11406 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea On platforms with multiple IRQ lines (S32G2, MCF5441X), all lines are registered to the same flexcan_irq() handler. Since these are distinct IRQ numbers, they can be dispatched concurrently on different CPUs. Both instances then read the same iflag and ESR registers unconditionally, leading to duplicate frame processing. Fix this by splitting the monolithic handler into focused parts: - flexcan_do_mb(): processes mailbox events - flexcan_do_state(): processes device state change events - flexcan_do_berr(): processes bus error events Introduce dedicated IRQ handlers for multi-IRQ platforms: - flexcan_irq_mb(): mailbox-only, used for mb-0, mb-1 IRQ lines - flexcan_irq_boff(): state-change-only, used for boff/state IRQ line - flexcan_irq_berr(): bus-error-only, used for berr IRQ line The combined flexcan_irq() handler is preserved for single-IRQ platforms with no functional change. Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support") Signed-off-by: Ciprian Marian Costea Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 128 +++++++++++++++++++++---- 1 file changed, 111 insertions(+), 17 deletions(-) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index f5d22c61503f..f73ff442d530 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -1070,16 +1070,14 @@ static struct sk_buff *flexcan_mailbox_read(struct = can_rx_offload *offload, return skb; } =20 -static irqreturn_t flexcan_irq(int irq, void *dev_id) +/* Process mailbox (RX + TX) events */ +static irqreturn_t flexcan_do_mb(struct net_device *dev) { - struct net_device *dev =3D dev_id; struct net_device_stats *stats =3D &dev->stats; struct flexcan_priv *priv =3D netdev_priv(dev); struct flexcan_regs __iomem *regs =3D priv->regs; irqreturn_t handled =3D IRQ_NONE; u64 reg_iflag_tx; - u32 reg_esr; - enum can_state last_state =3D priv->can.state; =20 /* reception interrupt */ if (priv->devtype_data.quirks & FLEXCAN_QUIRK_USE_RX_MAILBOX) { @@ -1131,25 +1129,57 @@ static irqreturn_t flexcan_irq(int irq, void *dev_i= d) netif_wake_queue(dev); } =20 + return handled; +} + +/* Process bus error events */ +static irqreturn_t flexcan_do_berr(struct net_device *dev) +{ + struct flexcan_priv *priv =3D netdev_priv(dev); + struct flexcan_regs __iomem *regs =3D priv->regs; + irqreturn_t handled =3D IRQ_NONE; + u32 reg_esr; + reg_esr =3D priv->read(®s->esr); =20 - /* ACK all bus error, state change and wake IRQ sources */ - if (reg_esr & (FLEXCAN_ESR_ALL_INT | FLEXCAN_ESR_WAK_INT)) { + /* ACK bus error interrupt source */ + if (reg_esr & FLEXCAN_ESR_ERR_INT) { handled =3D IRQ_HANDLED; - priv->write(reg_esr & (FLEXCAN_ESR_ALL_INT | FLEXCAN_ESR_WAK_INT), ®s= ->esr); + priv->write(FLEXCAN_ESR_ERR_INT, ®s->esr); } =20 - /* state change interrupt or broken error state quirk fix is enabled */ - if ((reg_esr & FLEXCAN_ESR_ERR_STATE) || - (priv->devtype_data.quirks & (FLEXCAN_QUIRK_BROKEN_WERR_STATE | - FLEXCAN_QUIRK_BROKEN_PERR_STATE))) - flexcan_irq_state(dev, reg_esr); - /* bus error IRQ - handle if bus error reporting is activated */ if ((reg_esr & FLEXCAN_ESR_ERR_BUS) && (priv->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING)) flexcan_irq_bus_err(dev, reg_esr); =20 + return handled; +} + +/* Process device state change events */ +static irqreturn_t flexcan_do_state(struct net_device *dev) +{ + struct flexcan_priv *priv =3D netdev_priv(dev); + struct flexcan_regs __iomem *regs =3D priv->regs; + irqreturn_t handled =3D IRQ_NONE; + u32 reg_esr; + enum can_state last_state =3D priv->can.state; + + reg_esr =3D priv->read(®s->esr); + + /* ACK state change and wake IRQ sources */ + if (reg_esr & (FLEXCAN_ESR_ERR_STATE | FLEXCAN_ESR_WAK_INT)) { + handled =3D IRQ_HANDLED; + priv->write(reg_esr & (FLEXCAN_ESR_ERR_STATE | FLEXCAN_ESR_WAK_INT), + ®s->esr); + } + + /* state change interrupt or broken error state quirk fix is enabled */ + if ((reg_esr & FLEXCAN_ESR_ERR_STATE) || + (priv->devtype_data.quirks & + (FLEXCAN_QUIRK_BROKEN_WERR_STATE | FLEXCAN_QUIRK_BROKEN_PERR_STATE))) + flexcan_irq_state(dev, reg_esr); + /* availability of error interrupt among state transitions in case * bus error reporting is de-activated and * FLEXCAN_QUIRK_BROKEN_PERR_STATE is enabled: @@ -1188,6 +1218,65 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id) } } =20 + return handled; +} + +/* Combined IRQ handler for single-IRQ platforms */ +static irqreturn_t flexcan_irq(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_mb(dev); + handled |=3D flexcan_do_state(dev); + handled |=3D flexcan_do_berr(dev); + + if (handled) + can_rx_offload_irq_finish(&priv->offload); + + return handled; +} + +/* Mailbox IRQ handler for multi-IRQ platforms */ +static irqreturn_t flexcan_irq_mb(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_mb(dev); + + if (handled) + can_rx_offload_irq_finish(&priv->offload); + + return handled; +} + +/* Bus error IRQ handler for multi-IRQ platforms */ +static irqreturn_t flexcan_irq_berr(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_berr(dev); + + if (handled) + can_rx_offload_irq_finish(&priv->offload); + + return handled; +} + +/* Device state change IRQ handler for multi-IRQ platforms */ +static irqreturn_t flexcan_irq_boff(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_state(dev); + if (handled) can_rx_offload_irq_finish(&priv->offload); =20 @@ -1761,25 +1850,30 @@ static int flexcan_open(struct net_device *dev) =20 can_rx_offload_enable(&priv->offload); =20 - err =3D request_irq(dev->irq, flexcan_irq, IRQF_SHARED, dev->name, dev); + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) + err =3D request_irq(dev->irq, flexcan_irq_mb, + IRQF_SHARED, dev->name, dev); + else + err =3D request_irq(dev->irq, flexcan_irq, + IRQF_SHARED, dev->name, dev); if (err) goto out_can_rx_offload_disable; =20 if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) { err =3D request_irq(priv->irq_boff, - flexcan_irq, IRQF_SHARED, dev->name, dev); + flexcan_irq_boff, IRQF_SHARED, dev->name, dev); if (err) goto out_free_irq; =20 err =3D request_irq(priv->irq_err, - flexcan_irq, IRQF_SHARED, dev->name, dev); + flexcan_irq_berr, IRQF_SHARED, dev->name, dev); if (err) goto out_free_irq_boff; } =20 if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) { err =3D request_irq(priv->irq_secondary_mb, - flexcan_irq, IRQF_SHARED, dev->name, dev); + flexcan_irq_mb, IRQF_SHARED, dev->name, dev); if (err) goto out_free_irq_err; } --=20 2.43.0 From nobody Mon Jun 8 07:24:53 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013042.outbound.protection.outlook.com [40.107.159.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1338439B4BB; Wed, 3 Jun 2026 07:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470833; cv=fail; b=AHAA70qxYjx5dRbsm6m+icXFdvIVNjeZFvFMAxWUuH+0XrA6S4B2D8XhyloztxgqIWfnCfN09B/I9mjVzmagpFiJLAZFY6gHZ1Y43cdA7gC8lGTuNVDHjs8jHb33MSYHAxNl/HFMKkOl8FrOH9kobXD/WNNvDfVSF/hL3BhfJDc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470833; c=relaxed/simple; bh=8EOsHs7J6ANm39x00dNUt4uy33ChTfGHoogRmHAEvLU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=KxVipgy5uf8lXJ9j3qN+kan5ZV9/q+eGC2LgLnUDFrhcyjua+xTjAlQOJe826HoyXwyzwk7a8i5+bjE+lvAx9FGC/h18VQRbb1pg84ctNdLC2+tlBqz/mesmY2p9ujNBNgL7IsB3KHGyYmmrZ0oJ231ctTqjuTFO5i8hUkP+FEI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=a7/pWoin; arc=fail smtp.client-ip=40.107.159.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="a7/pWoin" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pQn1MGZZUyrAemv8Y3Pr0Exvz3M4mgcXy0PZrD4lUU2KXVCpLXZdF0lgK6bCPT2JIECgXSKuU5v1IANhr5xWp8tAPZgIZpKVvKecjy9tRT+IhcamrmdYqCQGnH6ly90eP0t+/SfZ1Vu4WEMZICGy1PeXUMzQnBG6PLxHeHZzVYLPVn7583NUjWFvtCboHGy6WAkCHl7PMGVuhPRJ8x80Styz9fd0pmGOo5EflZ6RTrA1GcIt2N+0mwZ0+17AkKHttRoC+mq7BCnUWYj0SUZokUwsYVyYZmBrPAqtcZ2+gTb7lfDgs55/pAIyjNf6ImEQ7us0JuyZduBWlW35qdJgWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oY/iIRo27uKIqzkg/Rz5IhDiJmPYK8ia9+8E4UiWGlk=; b=kw+saTawsSMxdVeJkoKwvLw8ZvY2kvmwITEpiQGurny9v/TOSE7MrAjAZqPIpG0zb8xXygPXf2T+IVwUSO1WaKxQdA/wWVctKyUGYu3by4DHx34STSIBxwlF1DHly+enULHjBGGSbQvMylfEz8LBUtyNGbDECq8yiNb6LXvBJu4QOh5JJpMor01ckqzJ8Dyhq6X+v15470rSNBzPJonUEPcnalQu+VxZn+mENBhknInWht4+FcmzJTy3Z1JJRq4J3SzE5rDEO5A5mZLd/y71bi0bV7GBQAtfk+Oq573SLPoq6EGzh4mYW+5eZyRMjZu/vmG1OIEhbCrXDyzGLHwz3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oY/iIRo27uKIqzkg/Rz5IhDiJmPYK8ia9+8E4UiWGlk=; b=a7/pWoinosPVt1gnE+Fjl0RNUbHfGOswOXOHHoPRu503/TwYM3yNgtgU31DOK1DmV1PgOhbS/dAXq3uF3fwaTDyCPL93m37UTKJXdNaZD6rwDHduj0cDqAMhOrrS2034CBOmwvDw32pLCJubg7YgmwktnFbZYNFTm8ieBYetPHGLyj4R5NZwqq0klB+O2gVBPtljjbAsTRnmyrQ4lojMX6HuSbefhSqpcQQbS9vHVFAa0JRq1Cvdcw2GKoct4pYnO1ud/eRkRUNloezF7FaGxmhRBux+e+ft8K6LdAqOkDo+qeyQhAPa0K/IuZ2wZ84/3bHKF7BjRr/0glp830/THg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PA1PR04MB11406.eurprd04.prod.outlook.com (2603:10a6:102:4f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 07:13:49 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0071.011; Wed, 3 Jun 2026 07:13:48 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea Subject: [PATCH RESEND v4 2/8] can: flexcan: disable all IRQ lines in flexcan_chip_interrupts_enable() Date: Wed, 3 Jun 2026 09:13:36 +0200 Message-ID: <20260603071342.641874-3-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> References: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0267.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e8::15) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PA1PR04MB11406:EE_ X-MS-Office365-Filtering-Correlation-Id: ad128123-a4f2-418f-c22c-08dec13fa80b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: r0kwk3sfzggGfhtlkLxc83W4bL0/gllpK8afsX9gY9lcH8nlCUu0cE0vAalmn8i6TzA+5YWCq8ifcDNmunf8ic1EUh/9emOP38o22ycgOYNxOFBT40CAIYZDGRwvCclsG/cpLdSC8cOlf4f6WRz9QeEtTQ/z58ZDEXpSb9ht2K8Bx64wwZTzoq1g0OzzHxrVUlLk73n5dqnnIZtYyf/ckNvjpQyY9NhEPTkI8L2OSb7pbUVfQf3KxU/plTmYjTACC2yxdvpDy7ASLtOvIzwGpkGe6VJKMPmc4lqQCYJz0QzDY95oaeFG2r3ZnR+E1/Xb73w6nRfXn9ptNsjbRsNWu7cVroqWS+6Lo6EL6F5qFzGzABQWDnEzetLWaPOlqon7lpWPUxF0LYPIYquYYIsQZWIg09SQzZomtoeQBBPiuduoPkKVOpoC9VnGdogygsTbpVrJkxSlaCzNBuvyIjnNr/DdcZqBuUQ2yADHk+qJVKXHhgabM8OE7sbnYDGreU/Jv+m0Hbyg1IYpGXiW5bpW4qQl7Ks4PRBTx6elvSggQ+yw2bLysebWZ6qFWvCv0MomDLwv2L9GV6WFm0cqrCW6kwTEKFI2tJutxghKV3oM9hWv6Ke3gkxgFXfqwLhJecE2N0skGDvh6eTGG6uBM9Rn/mvM+1p+PfJhG2tizsaZCOoB9unZa1xyCyddNPYgM3MW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUsvQ2lOMUFRenR5N0dZVXI1bm5IcTFMbW5ScUlXUFN0VExXMWhBSFBOMG5l?= =?utf-8?B?UlhaTWE3TFdRcTVqMWRHdkVicFVzdGxOdmM0QUhkaElRSFNkaG4rYWNrbHIw?= =?utf-8?B?MGtrdDdTNmJRQXZ2MnZtMEx1MkYvMUdMa0ZKdjlqbkp4SndKYVdtcUxOZEdl?= =?utf-8?B?MDRpU1VDR2oyczBjcEpVZnJleS9pQkdWU0lialplbXlZQUN3VTd1MTFYb1Nm?= =?utf-8?B?REV4Slg3RUptdjdvRjl3TUpOcWJDUFdtT3FsOE4yQzFJdFRldFE1bTQxY0dH?= =?utf-8?B?R200cFhrd2w5Y2R5L0pFTVhKajhIb1dVT3FlWE9LTDN5bDl6Y01RSEo3ZEVR?= =?utf-8?B?V3luZmEzYmVvcEl2QXJ3WnBWbmZJb2N3R1QxbE1zek1SclpnQmZadHV0NGsw?= =?utf-8?B?RXYyeURLZlBJa0ZlVU53dzJsR205UXJlczBYcWxEYkVHalFCUXpwSG1EVVo1?= =?utf-8?B?bmdDN3Z3T1Rrc2RvZkk4RU9ONVMxSm92MzY4UkVUSlJ6OEpCUkNxdkZIWjN3?= =?utf-8?B?V0dLVmpJY1ZjS0xhVzJFTldtb2kyVFp4Z3RlUVdZOXYxYTE1aXBVbXdra2xh?= =?utf-8?B?QjRvTzd2TG5FS2FWMndrdk9yV2lxYkZCWTJMakhHbEc4S2pjZktQUTU3OGtI?= =?utf-8?B?NENQKzNOZFV6Ymppdm56N1dxNUEzVUt3TzVxeUVMMHVCd2h1ZnJOOUJYdUp3?= =?utf-8?B?cnRkUmtBdGtueHVzSlNRSUozSEwvMk9wUC9iL1A5bDNySlI4Y3paNHBwU1o3?= =?utf-8?B?dTZjUUU5ZHFzNGRDbEprbHlKUWlJbk9QbWZCaTkzUmZ5RDdZUGxJSkczaWFv?= =?utf-8?B?dzA5SVdoNXc2dDVkOXIxMWhPbmU5TlQvQWNoYWJOSWdEZ3F2b3dpSk13L1gz?= =?utf-8?B?N1VHRklMVGhXS2N1T284NXBUKzBVTFNnSStpN3BRTTJHSC9NVTFIWFYyUW5t?= =?utf-8?B?aFBPK2JOMGQzNGVEOTZrOS9qTHNZRENkTlJUMldjSk1PRHpUWmtZTjVyS2dk?= =?utf-8?B?Z0RSNk1YdTNjMVgreTZ2T0lxSFdyeVN1b01jYm1LUC81SDBDcVlxR01ZSHk4?= =?utf-8?B?TWZTU2tobFZCTVcxYjZJYVlraWpMUkFCK0pWNm9LdDgwM0hhOVBSVTVHYWFV?= =?utf-8?B?QUszUlgrVDdFZzRtbUtXVERtcUVXdDc4Z2NQalQrZGVab1RVZG1VNVdoRE1k?= =?utf-8?B?S1h3dmpTYWJNbUdHTUlsc2VNK3p5QVo4NTJTZHBuYWFwUFhrTHJlclVZcEZC?= =?utf-8?B?MXVsOTYwK1lkdzJqakY0SkJid2NoM0k2bmFTQ0RqTWwvZjdEN2N4NXdtY2Fv?= =?utf-8?B?TGIrS3UwcGF1cEEveVBxV1BwSWo2Q081SWdxOEZ3Tm5obFhhS09aMXk0R2NE?= =?utf-8?B?QzhCaGxLaGhuMTlTc0JCcFZRQmM1SkFuNjBIV3FRalVGZ29lcTZETTNGVXMv?= =?utf-8?B?cmNqajBqVWViYlpOZjd1V0xwQXN0SFNhYjh2SmVoL2xyYjYzRGkxODVnYXFr?= =?utf-8?B?VkYwRnRWRXRzMC9Ha050WkdGODg1ZlEyZlQ0OGJQOGhCcjVxN3lydUNGUjBR?= =?utf-8?B?WFFvNzdtRTR6TDZKZzdsREFMUWVKN0lSeHVjU3lBcUFWZ1FzRk50QUd5UGF2?= =?utf-8?B?RjRJVUpjZWlaZUNLTnZzUnl4bUk2VmlKTjl3bDJYbWlnbGxuTkplbnVTNE5k?= =?utf-8?B?bzFNeWREQTN4RHowVkZLekNnd2tDbnBCL3EwNi9zSGNVYllveGhZbXRiTjFn?= =?utf-8?B?RGlEVjhvVUlIQkRiQjBpaXdmdWo2U1pwMWpoNDBUdUdlbTNsU2E2elpYQnlQ?= =?utf-8?B?VGlDNWpFNDN2RjZQRGViRFRxOFR6Y25oWHBWYWxNK0RhUEREamNlSXBDYjdK?= =?utf-8?B?Uk9tRjBZNzNjdWg0RTNRaUdyeUpRb2ZWRmowSHoyT3pMNTZMWmFNMkJ4Z3JH?= =?utf-8?B?WHZNZU8wazIzaFNtMXBJbStZOFVBS051ZTRmM2ZGNWtEUzFvcWxRN1UyS3lB?= =?utf-8?B?UGtkQ0RmUHExUFRweHBzVWZLTG5UeUNnQWhvbyt1MXhTK09VdXZtSU9pTzRv?= =?utf-8?B?d015UXBmemoyN1ZiRG9YNTF5VTQvbnZUT2JkbzJkMVoyR0JMVXluSXJObUV3?= =?utf-8?B?TGNvY0YyREVYTVEvSnk2YnExRUR0b2RoSmdJUjlicHdoLzVob2lsTTY3TWt3?= =?utf-8?B?U3AwWWhNS1pWOGQ4eWpUbFgxOVFrYUNPK29qdlJsRHFobWVZVTJyZ2ZhTW83?= =?utf-8?B?ZmdnSkgrQy9xWTVqcUtjRzVqSXR1ZGJBLzdOMjFJREhsNzlPMDJ4cEhTWm9U?= =?utf-8?B?SUV3NXZLcGh5dUx4U2FVek40bDdnR0k2MVVBZ2JvVFRhZVRKMmEzVExCaEFF?= =?utf-8?Q?hj+08j0WSsqQjjjU=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad128123-a4f2-418f-c22c-08dec13fa80b X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 07:13:48.6646 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5+FTihUmVhOMuBdEEv4h/6Oo8h8rE5QujIucV5dRKLv2rVSdWybqAP6lrA9Am+KxKFvboS2j4Z7YO+zD6ikKDoYX2KeqrheY1n4Ghtb8fHc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11406 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea flexcan_chip_interrupts_enable() disables only the primary IRQ line while writing to the IMASK and CTRL registers. On multi-IRQ platforms (S32G2, MCF5441X), the additional IRQ lines (boff, err, secondary-mb) remain active so their handlers can fire while registers are inconsistent. Disable all registered IRQ lines around the IMASK/CTRL writes. This also fixes the resume path, which calls this function. Signed-off-by: Ciprian Marian Costea Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index f73ff442d530..7dde2e623def 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -1519,14 +1519,28 @@ static void flexcan_chip_interrupts_enable(const st= ruct net_device *dev) { const struct flexcan_priv *priv =3D netdev_priv(dev); struct flexcan_regs __iomem *regs =3D priv->regs; + u32 quirks =3D priv->devtype_data.quirks; u64 reg_imask; =20 disable_irq(dev->irq); + if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) { + disable_irq(priv->irq_boff); + disable_irq(priv->irq_err); + } + if (quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) + disable_irq(priv->irq_secondary_mb); + priv->write(priv->reg_ctrl_default, ®s->ctrl); reg_imask =3D priv->rx_mask | priv->tx_mask; priv->write(upper_32_bits(reg_imask), ®s->imask2); priv->write(lower_32_bits(reg_imask), ®s->imask1); enable_irq(dev->irq); + if (quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) + enable_irq(priv->irq_secondary_mb); + if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) { + enable_irq(priv->irq_boff); + enable_irq(priv->irq_err); + } } =20 static void flexcan_chip_interrupts_disable(const struct net_device *dev) --=20 2.43.0 From nobody Mon Jun 8 07:24:53 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012055.outbound.protection.outlook.com [52.101.66.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E86973F8712; Wed, 3 Jun 2026 07:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470838; cv=fail; b=hJHGHPbLmFU7zeZ9pY8KeXc1roL18PYY45jDjOKnFQWPcTOopJOYfB/NXty6IDqzIbf2xdXHXLGm/L25V5iKCNBjNBL//72hN1gqdkFw+kBTitqMEPQ8rekc9AT6DSvknNQ+iMBrQfv9/bUPyazfNwquVOGj4a3qso3JcsropN0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470838; c=relaxed/simple; bh=X73y5eKmEDXMZkOeid41Y9oWjpHvGp3eMNcJyEOVYYw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=PNnyRtPw4HFjZX5IwOqPZwGnnsRfgOxxj2F7WslBRQl7QgF2tWyINY0cbTQk+bPA2C7y6JGwb86lnv1R1TxqZujNZoMFKbhNUYLGd9pJRQXjVtWS25a2lXMK4CQfxtVsNK08G5YABm2FQf6AFuhqqRvt7ttZeYvj7EbLcJUYYhw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=HlePR4QM; arc=fail smtp.client-ip=52.101.66.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="HlePR4QM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uJ93M7RAmybdafhvdOpW5IhtpJIhaUSB77Gp7Jp2KzjMzAha6WuFJyBLQtrlznmdMBbzMUQ35HkcmYkoDUmk7G1NiakrCWWzN4kifXOx4c21qG9bsvLc9HkKW3HOxTbRmiz59YpHMY64J/FCUe5/JcokFdh0iL91W3TlO2VycNApmpIx+fqYuivtgMuTVfjlyDtl6EyLM/9kVZxHvg5epj89YItuY4lvBXzRDY0r3lwjovvlq1+Jbohhm0FJtv7mzomIfmEb6zov5jva8CLKECFj4jv1vzwpKsupe45OMv7cWUgqqWlEUN8VFxzvwq+eoGmBejIepyDGir16wtBDXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AZzABiD+Y9NW4W0IfLoq3EPHnlZMdPk1rCC0LnYNhQQ=; b=Xy1tHwq3BbZUoJLBPh+EglHPG7alk3Ao5zrULDMxbXqK+aLCUr2F0IcMIOlYXeoif7BBmS7BWUxjkjQquBdEB2ofjWJKiUBnnqapesyKyoewB7pQt0/vDmGL/RzVaHAr6wg40UDPMaso0b1f9URACfH2CM5fsp092RCYlpRvNM1DHs+/oAIFnuGPQhYee0UyIRJlMb75AWgi9L+GtwjK7+6aHJW7nIb3d3KvRxwiFN0jkl0GSYw3+U8UKMn3w+DPN5ikM//5w+BeAj1LL7SSU8sh0pmpzWXRad/4jN8BXgfDmKXyF9hXlEIvnKUb3vl7PQO9GbrZJ5MC30lxJkBRLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AZzABiD+Y9NW4W0IfLoq3EPHnlZMdPk1rCC0LnYNhQQ=; b=HlePR4QM9ISsq8yfdatgpgW9d1pjk0rx9sqB5ohYy6YcEkcQsHuFlY1tKvVNOH1IIdTGUy+bR18SvZQHXqiDA7qGzdNakEcyGe2stwX+vNlknoEEU94QzlG7Y/lMR2ZmDdvbu+f/P2/V+Vl/UFFh5z2/eFswg+1gLrIN3YLKYhkcytuDu01/vgd6svYcZUeVReXGozrGemRzAbl6kAynMdU+9cTrROonv4i8X3Q7BzuDLVCodC2J2D7mz5WrHRQK1iufokxzZjAT+YIHMgTDc79jMYmIyGfFEGu/Mlkr+F+EEXQb61ubJIwYDKPzCNXrSirhDryZ04UlCMCbOTW6rQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PA1PR04MB11406.eurprd04.prod.outlook.com (2603:10a6:102:4f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 07:13:52 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0071.011; Wed, 3 Jun 2026 07:13:52 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea Subject: [PATCH RESEND v4 3/8] can: flexcan: split rx/tx masks per mailbox IRQ line Date: Wed, 3 Jun 2026 09:13:37 +0200 Message-ID: <20260603071342.641874-4-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> References: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0265.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e8::8) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PA1PR04MB11406:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ac1b481-d3e1-4484-88a4-08dec13faa3b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|3023799007|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: wuLxjElZz0Ogry2ErvH20hEImWs6FjxZnELTP5z6TwBgv/SFr9n9nPoACXD8rkVRtHvCnRQU38EegOCOVKD20L70ded7bR2Zhf4VvUKK2N+S5ASJCMy6X+x9ZuB2RBjliLt4a6WvX/zMPJiiYr973QQwR/ctkeWPJkcQziM35I/gK7RTvle9xoVCB5eFSwnYfgl1VsyBfCtvSefPL/k2nb5xnWk9FNP128GwTlwyISI21tTnrLRjLEsVE1oMatP+e6m2sG08l5QYUbRYpu9KZ3RA9s22mNZVPSqSsApBit5iycEeIuL2hqL5CPJOb1ze4sVi77o/u+b9YXd374DEj4ufxRL8SFbWi/Li+sy43sJMkflSos2MkmDy9Y9UnBkx0FDXlo/Q6hhdEYvuDySJXNH1J7cATce8bJ5KNVJHSzjlpMGmrkuuwm9nr2fS9VSDrVnrdCoMEt/AND5wvhLNH8BcuFruJnP6kkxKbqPW9/LwzMLY4YToc9I9ZMdr2+dbSGg3zY/Pq6dojBfFL5zK0d5QBK4/TFPoTUNVTJ25BbekRAnXaoXLfJFByZAPI2zwpH63B+qJfDqRhZDq5cXd4l5hgMKkkGQTkwJ4no86s/xfAQMFYrHh4vto3c/b0xBE+wac0bzAMZnoAudc96Vh+SFk6cgm+A+Jg7953UBqNAY/tUWxLcySIYy4bEBbnWV/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(3023799007)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVdIR2VDYVNKY0FHS1VTaTR6eUxRUFNzbHlUWlRjcGNadFNES3BSUnVQYTNy?= =?utf-8?B?aTV5aHFNbUNYTm1oUmRndzkwZ1Jud0c2VDk2OVQ5aEJpK3FTMjZtT080SzZX?= =?utf-8?B?NXViZTIwckU5dzhrc09YeTRoU3E0ZEQxWXlJTmF2N1FpRUZqaHNWNlBGSlMv?= =?utf-8?B?WmRwM2Rxc05adlRyTDAzazdtVXNKekszWjVQVHNUNGR0QU1pRUJ4aUdpVTUz?= =?utf-8?B?ZFFlb1AwVXo1M1o5dzRmTzZkR25MMFdEajE3dzJ2M1VaSTdFdGlxWHhYTU5m?= =?utf-8?B?K093Y1NJRFlTdVJkZUhSNytiSDBzU1dNQXVNZUdVazJSVkRCMnpTbUFZaldw?= =?utf-8?B?dmgrMDNtNHBjb3NhV1kxdUI1d2Y1ZU0zRDRvVWM0bmRTdVI0dVRoNi9UdzE3?= =?utf-8?B?K2tSQjhObW5JWU00V3BWWnl6UFBDb0RNRFR5elRzUUNJWkNFVXphdzJhdWZ5?= =?utf-8?B?NUFYR2k5SnVBV1lWc24xK1pjZExmN29heURhOXprdjNaTlV0S0xXb2EyUVg5?= =?utf-8?B?N3BVbnQwL1M3SVlnWjBrTUkrdlBZb0t4bHFPMDJzUUdGMGcxRG9qU2N4K3NY?= =?utf-8?B?QkJJWUpEbHNLUmRRZ2I2QXBOK1UvZUJudG9RQzVFbEdJQ0o1VUhmTlFPVVJ1?= =?utf-8?B?bDRlOU5pSVhzeTltYnB0YUgvOWViZnl1NlY2MDUwZjV5R0tXMXZMSTFsblBN?= =?utf-8?B?QTBSZmErWkVNNTZNYjQ4QjUrcGRqeU83L3VsQTFVSXBMUE9IeUhTVUtRVkhs?= =?utf-8?B?QjNGRkVKNUJNQUlSVWR3OU1PR1dVRnpldm0zVWRQZUpEWmxhLzFTcE9OQzRa?= =?utf-8?B?dkpKbVQybVg1WDJKVVg0L21mVWEzZk1kT0xiUitqeGI3WWZDMm5KQ0lCTWp0?= =?utf-8?B?STNwUlJKd3NLYklLSmcrY0crUzdYQWhDRGZGdGlPKyt6alRKL2dzZ2JJZDd4?= =?utf-8?B?Zmt6TjJnRnVyUk81ZXIrZVF3Zkh0WVVuWm1CanFnUkRuWG1sS3JkTi9qbkd4?= =?utf-8?B?bkQ1T1dnQXhDYS9oQ2pqQ3JxNnFVazZxSW84OHRGU2YzeGROOXBvUnVyNFBJ?= =?utf-8?B?dFNJWVdNcm9Zb2t3YURQUUQzQUdNaDF4cWhmVjUweGhJZ1Z1TzRJZkRjNk45?= =?utf-8?B?WjBsc0Y2dXlzM2Z6dXJOb0orUUpvWmVUUDhQSDZIZURaM3laS2ZlcXErZU1w?= =?utf-8?B?bXpiZTVhQi9iNUlWYjdYUTJjVjBGV1k4U25XdFlRQUgvRTROd2dLeDhPZmZ3?= =?utf-8?B?d0E5MnYveXgwYklvTm0xOWpkcFBCS2tUUlUzdVQwY1RZU1lDREtIQjFydngr?= =?utf-8?B?UmZlWjNSbEFVTXdUV3ptWjRBbVlBeHN5SmRFL2pHSzhrUEpxRkJmY2o1azAv?= =?utf-8?B?V3RaQS9XbU52Mk0wVEd4MkVSN3Q1QllHd05EeHQzQjN6T0JEWHpBTXhBZEhI?= =?utf-8?B?T2x0b1RIM016NXJ6c0lJdWJwblBTUHRXMVlNQ25tMmJTeUFIaUZEZkxhMHpG?= =?utf-8?B?aTMrTXF0K2dzbXVjRk40ZUlWYmwrRjRsMTY5cUFGSTEwNmlqSzJDZjEyVVlM?= =?utf-8?B?VUd4ODcwRGZGUmJXeTFDVlhFVHZCSldCc2VQWi9hWk1UUXk0SGU4VElBSWY1?= =?utf-8?B?d1dqS0t5UDluVWFMK1hBQTBXcDh0TEdqamwyUksrWFU0WGxDNVBIWVR4U2Ev?= =?utf-8?B?VC9jbmVMZ0REajhtQ1QrRlNYeWhkSDFCejcxSng1TWpuNlU0RFJtOUdnT1NM?= =?utf-8?B?eTgvcnNWbmVVbkQxYzZJdCtBN2dtQnVHanU2V011Z25FOXhLR1gvQnRXYUgz?= =?utf-8?B?VVhDanRkTzRLczJVNUtqY0Urc1BiNmJNdWg2RThaYTdYcFM5em5MLzlsejFz?= =?utf-8?B?eTJhenZlbFBuYzU0NXc3bTgwekt1b3UzOFhnZlA0S0JiZG5qOE5LRjExNFkz?= =?utf-8?B?eFUxclNwRFUyQTlqSmVtaGR2UHk5bDd2WkUzYkUrWmZEN0xBRnlqVnVmSndG?= =?utf-8?B?cFl1ZG9Sa1pCWUluTURweXovdGNxSDRFMGJ1V3MxM2dSSWhHT091RStHVU8y?= =?utf-8?B?ZDBqQ01RNUlld2diWFFCNnNzc3I0MDZsN2pJVXBBT1hObDJzaERiTjlKUUVW?= =?utf-8?B?b000UlBwendxUmJmYmRQL1A0WHZkaEg0bmRLT0FYMUcwZ0xoeDlDZHBpVFFp?= =?utf-8?B?UEZEQlZYM3BzUWdYM29YWDJRTldSc2dYd21PWHZyRERoRlhEMHFzZXY0NjZk?= =?utf-8?B?anhtV0EwSWpUN3pCTGR0WHA0aUoySmNybnNWdVJmTHVkK28zLzYrMFF3TmI4?= =?utf-8?B?S2p1UFl2a1FGMTdnKzRhQTVNU3JqRUVuUWxyTVdpSkpvODNOTUt1VFp0NW1n?= =?utf-8?Q?BxCGc35/XpGrfKoI=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ac1b481-d3e1-4484-88a4-08dec13faa3b X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 07:13:52.2445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TvZ1iYf32ELQnxMi6anKHQoFrVzfYt3avr8bp/Zqp9zKcSCzFWBv00IhRud+P4wxQG/COeQrwMc1toCoGYkm9M3n6Fpi6LAYy5yjiZza4jQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11406 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea On S32G2, which has two mailbox IRQ lines (mb-0 for MBs 0-7, mb-1 for MBs 8-127), both handlers currently process the full rx_mask/tx_mask range, Introduce struct flexcan_mb_irq to hold per-IRQ-line rx and tx masks. In flexcan_irq_mb(), the irq argument selects the correct mask set: the primary MB IRQ uses mb_irq[0] and the secondary uses mb_irq[1]. For single-IRQ platforms, mb_irq[0] holds the full combined masks with no functional change. Signed-off-by: Ciprian Marian Costea Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 61 +++++++++++++++++++------- drivers/net/can/flexcan/flexcan.h | 10 ++++- 2 files changed, 52 insertions(+), 19 deletions(-) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index 7dde2e623def..32e4d4da00a1 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -957,14 +957,16 @@ static inline void flexcan_write64(struct flexcan_pri= v *priv, u64 val, void __io priv->write(lower_32_bits(val), addr); } =20 -static inline u64 flexcan_read_reg_iflag_rx(struct flexcan_priv *priv) +static inline u64 flexcan_read_reg_iflag_rx(struct flexcan_priv *priv, + u64 rx_mask) { - return flexcan_read64_mask(priv, &priv->regs->iflag1, priv->rx_mask); + return flexcan_read64_mask(priv, &priv->regs->iflag1, rx_mask); } =20 -static inline u64 flexcan_read_reg_iflag_tx(struct flexcan_priv *priv) +static inline u64 flexcan_read_reg_iflag_tx(struct flexcan_priv *priv, + u64 tx_mask) { - return flexcan_read64_mask(priv, &priv->regs->iflag1, priv->tx_mask); + return flexcan_read64_mask(priv, &priv->regs->iflag1, tx_mask); } =20 static inline struct flexcan_priv *rx_offload_to_priv(struct can_rx_offloa= d *offload) @@ -1071,7 +1073,8 @@ static struct sk_buff *flexcan_mailbox_read(struct ca= n_rx_offload *offload, } =20 /* Process mailbox (RX + TX) events */ -static irqreturn_t flexcan_do_mb(struct net_device *dev) +static irqreturn_t flexcan_do_mb(struct net_device *dev, + const struct flexcan_mb_irq *mb_irq) { struct net_device_stats *stats =3D &dev->stats; struct flexcan_priv *priv =3D netdev_priv(dev); @@ -1084,7 +1087,8 @@ static irqreturn_t flexcan_do_mb(struct net_device *d= ev) u64 reg_iflag_rx; int ret; =20 - while ((reg_iflag_rx =3D flexcan_read_reg_iflag_rx(priv))) { + while ((reg_iflag_rx =3D flexcan_read_reg_iflag_rx(priv, + mb_irq->rx_mask))) { handled =3D IRQ_HANDLED; ret =3D can_rx_offload_irq_offload_timestamp(&priv->offload, reg_iflag_rx); @@ -1110,10 +1114,10 @@ static irqreturn_t flexcan_do_mb(struct net_device = *dev) } } =20 - reg_iflag_tx =3D flexcan_read_reg_iflag_tx(priv); + reg_iflag_tx =3D flexcan_read_reg_iflag_tx(priv, mb_irq->tx_mask); =20 /* transmission complete interrupt */ - if (reg_iflag_tx & priv->tx_mask) { + if (reg_iflag_tx & mb_irq->tx_mask) { u32 reg_ctrl =3D priv->read(&priv->tx_mb->can_ctrl); =20 handled =3D IRQ_HANDLED; @@ -1125,7 +1129,7 @@ static irqreturn_t flexcan_do_mb(struct net_device *d= ev) /* after sending a RTR frame MB is in RX mode */ priv->write(FLEXCAN_MB_CODE_TX_INACTIVE, &priv->tx_mb->can_ctrl); - flexcan_write64(priv, priv->tx_mask, ®s->iflag1); + flexcan_write64(priv, mb_irq->tx_mask, ®s->iflag1); netif_wake_queue(dev); } =20 @@ -1228,7 +1232,7 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id) struct flexcan_priv *priv =3D netdev_priv(dev); irqreturn_t handled; =20 - handled =3D flexcan_do_mb(dev); + handled =3D flexcan_do_mb(dev, &priv->mb_irq[0]); handled |=3D flexcan_do_state(dev); handled |=3D flexcan_do_berr(dev); =20 @@ -1243,9 +1247,15 @@ static irqreturn_t flexcan_irq_mb(int irq, void *dev= _id) { struct net_device *dev =3D dev_id; struct flexcan_priv *priv =3D netdev_priv(dev); + const struct flexcan_mb_irq *mb_irq; irqreturn_t handled; + int idx; =20 - handled =3D flexcan_do_mb(dev); + idx =3D (priv->devtype_data.quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ && + irq =3D=3D priv->irq_secondary_mb) ? 1 : 0; + mb_irq =3D &priv->mb_irq[idx]; + + handled =3D flexcan_do_mb(dev, mb_irq); =20 if (handled) can_rx_offload_irq_finish(&priv->offload); @@ -1473,6 +1483,7 @@ static void flexcan_ram_init(struct net_device *dev) static int flexcan_rx_offload_setup(struct net_device *dev) { struct flexcan_priv *priv =3D netdev_priv(dev); + u64 rx_mask, tx_mask; int err; =20 if (priv->can.ctrlmode & CAN_CTRLMODE_FD) @@ -1494,20 +1505,35 @@ static int flexcan_rx_offload_setup(struct net_devi= ce *dev) flexcan_get_mb(priv, FLEXCAN_TX_MB_RESERVED_RX_FIFO); priv->tx_mb_idx =3D priv->mb_count - 1; priv->tx_mb =3D flexcan_get_mb(priv, priv->tx_mb_idx); - priv->tx_mask =3D FLEXCAN_IFLAG_MB(priv->tx_mb_idx); - priv->offload.mailbox_read =3D flexcan_mailbox_read; =20 if (priv->devtype_data.quirks & FLEXCAN_QUIRK_USE_RX_MAILBOX) { priv->offload.mb_first =3D FLEXCAN_RX_MB_RX_MAILBOX_FIRST; priv->offload.mb_last =3D priv->mb_count - 2; =20 - priv->rx_mask =3D GENMASK_ULL(priv->offload.mb_last, - priv->offload.mb_first); + rx_mask =3D GENMASK_ULL(priv->offload.mb_last, + priv->offload.mb_first); + tx_mask =3D FLEXCAN_IFLAG_MB(priv->tx_mb_idx); + + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) { + /* S32G2 has two MB IRQ lines with the split at MB 8: + * mb-0 IRQ handles MBs 0-7, + * mb-1 IRQ handles MBs 8-127. + */ + priv->mb_irq[0].rx_mask =3D rx_mask & GENMASK_ULL(7, 0); + priv->mb_irq[0].tx_mask =3D tx_mask & GENMASK_ULL(7, 0); + priv->mb_irq[1].rx_mask =3D rx_mask & GENMASK_ULL(63, 8); + priv->mb_irq[1].tx_mask =3D tx_mask & GENMASK_ULL(63, 8); + } else { + priv->mb_irq[0].rx_mask =3D rx_mask; + priv->mb_irq[0].tx_mask =3D tx_mask; + } + err =3D can_rx_offload_add_timestamp(dev, &priv->offload); } else { - priv->rx_mask =3D FLEXCAN_IFLAG_RX_FIFO_OVERFLOW | + priv->mb_irq[0].rx_mask =3D FLEXCAN_IFLAG_RX_FIFO_OVERFLOW | FLEXCAN_IFLAG_RX_FIFO_AVAILABLE; + priv->mb_irq[0].tx_mask =3D FLEXCAN_IFLAG_MB(priv->tx_mb_idx); err =3D can_rx_offload_add_fifo(dev, &priv->offload, FLEXCAN_NAPI_WEIGHT); } @@ -1531,7 +1557,8 @@ static void flexcan_chip_interrupts_enable(const stru= ct net_device *dev) disable_irq(priv->irq_secondary_mb); =20 priv->write(priv->reg_ctrl_default, ®s->ctrl); - reg_imask =3D priv->rx_mask | priv->tx_mask; + reg_imask =3D priv->mb_irq[0].rx_mask | priv->mb_irq[0].tx_mask | + priv->mb_irq[1].rx_mask | priv->mb_irq[1].tx_mask; priv->write(upper_32_bits(reg_imask), ®s->imask2); priv->write(lower_32_bits(reg_imask), ®s->imask1); enable_irq(dev->irq); diff --git a/drivers/net/can/flexcan/flexcan.h b/drivers/net/can/flexcan/fl= excan.h index 16692a2502eb..22aa097ec3c0 100644 --- a/drivers/net/can/flexcan/flexcan.h +++ b/drivers/net/can/flexcan/flexcan.h @@ -75,10 +75,17 @@ */ #define FLEXCAN_QUIRK_SECONDARY_MB_IRQ BIT(18) =20 +#define FLEXCAN_NR_MB_IRQS 2 + struct flexcan_devtype_data { u32 quirks; /* quirks needed for different IP cores */ }; =20 +struct flexcan_mb_irq { + u64 rx_mask; + u64 tx_mask; +}; + struct flexcan_stop_mode { struct regmap *gpr; u8 req_gpr; @@ -99,8 +106,7 @@ struct flexcan_priv { u8 clk_src; /* clock source of CAN Protocol Engine */ u8 scu_idx; =20 - u64 rx_mask; - u64 tx_mask; + struct flexcan_mb_irq mb_irq[FLEXCAN_NR_MB_IRQS]; u32 reg_ctrl_default; =20 struct clk *clk_ipg; --=20 2.43.0 From nobody Mon Jun 8 07:24:53 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012055.outbound.protection.outlook.com [52.101.66.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 943863FADE0; Wed, 3 Jun 2026 07:13:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470840; cv=fail; b=TuAZeEKbomW46D7ik+3YTXMCa/uG233DUjctbdbuSKgrWIytA/B5pg0w/F9cT8DaHUONNyIBozAQq4V+YW2RElDK+61oPHYefjFtg1LqHhYXUE2EcqTpxu5HIdKl29mHnBskyrLgzjdSJRmfdLXwQ91VPI5Bn1dDr1knf85/3Aw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470840; c=relaxed/simple; bh=D1Xd1s7YrEqbtvlFTkhmj8SJVSWChuDXoZfzKtuxKH0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=AmaSiql9CZeFZZbG5+wWyBgEf7PzyLb0zw38c/tvnH0tplPi8XlwJi7znqmdDJLep+TH6bZXIC5+l5D+lmuKnEelQDoS11gpQpQ4YzX98x8wd0l8qspKrE4Lnp9cyxceZ5NJIXk1F9Om2bzdNmK5tXvVTz+RVI0er9Jh1k8zPNQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=xON5SIeC; arc=fail smtp.client-ip=52.101.66.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="xON5SIeC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CDiy2OAcOPKU6j8rOvrorp1y12z2ZN8pzImifN37J5h/8ckcLT1DaxI4rOSyjv48BRsQ3w3VRkdQS88/7d1eKJixWjau3oKXEEiufwOHchSc42EYgfrgUNo2dGK53+Q73jJ67TiAoJ+gL8NrnqyGayJ9kO6hY179Y2XaHPJu/A64vu+3I4TxSMxjWNhvsnc/fyUGdNLL7nXkF1LMiFphxaw0kEO8aBcig2ZLfg82O2mqJznTcS3/WZX2VXvqLb09melvDRKXXSanoMGDUetSh6ysUoONAwstL0X3YrVMywaFB0DbBkjdnssck4JuT5oQUIop2ibKW4PU3axk/DaQAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6O/zHz6VHNH2clBthNEnurAD46ZT8OtXUs1Vwyt3dZ8=; b=d3X/xFt7oao57WrEdsdUR6Df3MhOURo/blPox3WolLZndw8fQV2AXdrYWN5YOkW4pvztXK+tw6bphA0HCzHth3hypV4b+RVH2cjMTAWK7YEoJxH4C8qheGUVv2zI37Lgen2j1nd/57O0Om8W4Jn5ki9Zt1s3znWBlh1TLD2uioFYXnscu+2F94KZtXHxJ22IDMgSmhMFMs89fJ7sLc/R0cG7kg2Ko6lkEesidn8ZHU98RAHrM2nR78N52hQDA8b8TaiF4zWXymXN7S+bVDNkyBX+O7YECQ9PxZughJ3EYPyiIzgg6cmKroi2579C4l+V3Wj4k3aE/bEmxfp0I6SnVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6O/zHz6VHNH2clBthNEnurAD46ZT8OtXUs1Vwyt3dZ8=; b=xON5SIeC11dng7ZtKLdyumnPGoqkuy+1jOp7iM7Ch/0nsrzHeWSixZe3JgM89A16Se9Fn2PGMRLVi1YgfzZqup+sWIIzO+fN+qAeSs6DQtBEXw5L6HSQq0xfvq2Buk+zaCZFLzGdzB5O+KN+OUA+LN48W1X/K0M/z4vNAv84YwFH7g9hmQxVYRRWTqRYpM8n1kb/jaweh6wHS0D1KDHRn/Yh0Vh/K5Bonp/RetjwB7b6xV+b8o5b9XsIQYyHOPsts0fXf55dERDk5Dsswfy+XqweE94hZk1TrFh37/C0u13qCxDeVckFml1CZ7xPEzNmOrLwLlqv1lDbyoYgegaNVg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PA1PR04MB11406.eurprd04.prod.outlook.com (2603:10a6:102:4f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 07:13:54 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0071.011; Wed, 3 Jun 2026 07:13:54 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Andra-Teodora Ilie , Larisa Grigore , Conor Dooley Subject: [PATCH RESEND v4 4/8] dt-bindings: can: fsl,flexcan: add NXP S32N79 SoC support Date: Wed, 3 Jun 2026 09:13:38 +0200 Message-ID: <20260603071342.641874-5-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> References: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0267.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e8::15) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PA1PR04MB11406:EE_ X-MS-Office365-Filtering-Correlation-Id: e1504c47-47d0-4def-aee2-08dec13faba2 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: diLWSW4wVMpLT0BQJ4oIrF7diZ6hGlhuDtUSYxGT9UVj6fTqC273T380OOHw5veNRTW6Yg9lNI9PJpKR+ocHF/HnYPvmnwiRfJn1PEeRtIxL6CKpnEDi8azM2UtJG/Q2szPsqyBV1gtM4Lo9YNDYK22NDgZXd/Ns0KSRxwD35Yw+NSfYCY3aFpjW6HW++iM1fqo0ZtCZLXqDKZWl2WPJoH/qFZIzkal72Nmw73p0iRg/ZPW/0/LassEOuP1p6UdgpF2rl4rC36vasyMy+j13u8jatXgdTMM+wj3jB3o/VZ4APk/9LZnG6YwCmrE/31ZggED6R89ccVDqn9q/OZrtky09I/wK16c1460EKC0kYBkn59PU7wzCRjrvAWeqWaiEn1pA9VHzha32AeQJ6LWhbx4/w4nV4iQj9BrFTzRMMslkHSzGO054TAWdtbheh+BaRMRQvaJVSaeyDhZt5ySK9bNfSxr8zn2zMwvyATtRTMbBHN3idM/FbWJkqOZ49+N1F1ri9nD6WJEvz0J+xO9zbJxk3j/FOtqBTCLO6nk04TszFVfMTWGvy/935saJE5FMgZR4xN2uA12nN4Ku+7b8WhWG5OKUvryKvDz7MSjyomp1dUHl/IZNcpIgHjOwBg+VJri/nDkefSVMWiFhuez/MUVkPAwVQZCAQYLS02TsRi1YbJBEVd+QInc7uHcduSbQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWc1TkptSGoyem9jOFh2T1lHdzgvdU9EWkFmTW50L3lNUjh4R0FmeVR5d1V4?= =?utf-8?B?S0xUUUhXU3VHS3dyUU1WdEpQQitUNHlMb3ZGOUxoVnRaVDAyUi95VHM3dXRs?= =?utf-8?B?Zy9LM3p0TDhZeUo5WncrSlhlYjIvVnZEMmZ3NDFZSm5qN1ZmSzlpMHBxRFlU?= =?utf-8?B?TFRIY2RBaFpZcWU1dHlLZlJtTEczcm9PK0puKzJCSmhlMldwSzBqemFUYVh3?= =?utf-8?B?MlJ0TFR1M3JJaTFvTlRNczhTb3dxMTJlZDdWRis4cTd0ZExwbmFXdFJqS2Q4?= =?utf-8?B?Um1acngxT3NTa3FNeENlbUVkYWhCOWk3YlB5L01GZGVLbmpwemNwazBndUpy?= =?utf-8?B?eHhCdkt3K3graWdNcUpVdmJNYTlJWHVBOTlHZlpHbE1RSzQveUJQNjhPUGpo?= =?utf-8?B?MDhyZDN4NU1wb0ZqaG9UbmVRckptK2FSS0RVZG5wdlc3K1ZIN1VCQWUxeVAy?= =?utf-8?B?RWdHSXJxWG5vWVhoU3AzK0ljU0NkMWlvdEp5UzBNS2N0ellpSThtdVNtRE84?= =?utf-8?B?eTRBaTlOb0Fkc2NmMXViY0x4TkJPeDRKbGJpbjRldkgxN2RRdDV3MnR1MU9G?= =?utf-8?B?d1NFcE84UldJaGxSSzJ6NVVLQlA2WjR5TVdLWDNUR3NuZTZqQ29rekxyditu?= =?utf-8?B?ODZ3ZzdUNmNaWXlnSWZkSzFTQUFDNDlNZFk3UEZvVlFDVitXZWZpMXU0VENt?= =?utf-8?B?NURmQURRdEt1K2NDeXJjY0o3K01QSHhLVTVyUXk2Q0w0QVUxdk1JM0JYMDRB?= =?utf-8?B?S3FqeHVFakJjaVpFdFFFenVITk0yMmwyeDFTbGp2TzF2bTFEWnNwdFFKM3dL?= =?utf-8?B?QW5oN09MS1piQ29BMjRxUzhnQ3IwUi9KdGlpTTFrc09jVkZjaWdGY3hpaXht?= =?utf-8?B?aFdNMzVTRzMveHB3cmhQNHp2b2tWcEo5SmNqcG8yUjF5bExCYWNDam96aDZL?= =?utf-8?B?YXBHd1k3WXJMQTlCK3lZUUhpUkhybHpqUmVvL3dDcXdsa2R0TEl6b2V5bXRn?= =?utf-8?B?T3FlMHVzeCt3RE5LemcvUjZjUWRUdDZmeGlXS2JZSm1RK3dNdlQrcjlrclEy?= =?utf-8?B?V3VYSW9vTkI5OXdseU90Z3pkSVFTbDJnL01kbVBKRWs2K1lWTzBqd1F2VnIv?= =?utf-8?B?ZXkvazJWUWc3N2Yrd1ZZSWZqSnVKNGJnRlZjVXFEQm8rRGJsT2xxUitIeUgy?= =?utf-8?B?ZkxTUUVvdjJBeU5zeU41Z3VIV2dNU2dland1Ym4yVDAzdERuazQ0ZTJEZWN2?= =?utf-8?B?RGhZZUNYV1gyQUVicEd3ckxuUHkwVllldFk2dnVOODkyQWVLcVd4NllhZjFa?= =?utf-8?B?a2MycTlFZ3Q0RHcxR3JCcGdCNXcrdnNjMVZaZGwvRUhXcktkeXB0SVlSTWV4?= =?utf-8?B?dTV6SHI2bUtiM3JaNWJpOVF0dDBWWVR6QTlWeWJjSlNmYWtMRk5TVmcrWFpN?= =?utf-8?B?Z0RpdEVoRGZWRUN2WUdMb1orT0xLSGI1S3lReWdqNTlTSWFWTGhtUHNSMTJm?= =?utf-8?B?UkN3L2pNQmlTZDhQSmJaekZvR3p4dUpFVFV5R2IzY3R6dTBsRnBkZ0oxeGpt?= =?utf-8?B?d3ZyaklxajJWR2VMSStEdzBKZm9kc1VaVWhmNkc3NmE0RWN0OGpPSDJhZnYr?= =?utf-8?B?L1JTRGZiU2NmakRuMVpRRGFEQmNOaU9zQWVKK3lXK3lGWGVwaVF6NWFkSk4w?= =?utf-8?B?b0EwWks3NjJLWHJta01oL3ZRemw4TzNMNmJSRHdlMWxRekRISzIyeENQZzQy?= =?utf-8?B?aHpId21yY1FLNHo2TVlMZXVKUmdHdllweFJKZFpxbDU3ZGkwTjJFV3d3WHZ4?= =?utf-8?B?UGdWQU1nT3BXdWFtaDhXU1A4Y0Y1ZmcwTWx2QWlzR2crS3JZalJYeEZCeGdY?= =?utf-8?B?SFA0bnV2cWJxdnN6SVJHSjVFZXRBUUFIc3BIc2JrOUhSbFp1R0FLbHZlMUVv?= =?utf-8?B?cEI4dysxUnJHZWc0VmI4ZjV4MjlSMG0vd1dGL2J4cXAzbnBiSis1Z09CV2Y2?= =?utf-8?B?NDBqVmJKVmh2bWtuM0FSZmZRaStUUGZZUFIyejQ0cVNoUG9RQjhUYWdIekZJ?= =?utf-8?B?QlN0UUE5U1AzQ3E1dDZEaGtlL0c4dlRFeDlnTXh2TU5OUk80czlyNU4yVlNK?= =?utf-8?B?bkM0ZDgvaGF0ZWZ4K0I0cnhMUTUrYXE1cjNqL3ViSFNYRFdjSG1KUDVCeEsx?= =?utf-8?B?REhGZW5OTVM2NHFhTi9SV1RLSDBVc2YyZXJFSWdPR3hMZ2RMSUExdmlLcGFu?= =?utf-8?B?VStDUVYrUGh4T0pUa1dBKzY1OUNJQWF2bkhtc0lvcDlHZytzMTVzdm82Z1pD?= =?utf-8?B?Q0g0WjZ6QUxBbHdRWUVNVnh6RlJqdXlNNDNzL2dnMGxLcG83YWZ2S3I2Mm1Q?= =?utf-8?Q?86gT+5o2SNbXfkhM=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1504c47-47d0-4def-aee2-08dec13faba2 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 07:13:54.5280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HwWRksdLZ803CpyD4/659P2EtJBu9V5uqWZvIh+XylvFQhmVP/vXKp/C2cUolu/O+nevQJ4cMQsjAjrUBoBt3R++GIB6MktF2vh1JpCDsY0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11406 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea Add NXP S32N79 SoC compatible string and interrupt properties. On S32N79, FlexCAN IP is integrated with two interrupt lines: one for the mailbox interrupts (0-127) and one for signaling bus errors and device state changes. Co-developed-by: Andra-Teodora Ilie Signed-off-by: Andra-Teodora Ilie Co-developed-by: Larisa Grigore Signed-off-by: Larisa Grigore Signed-off-by: Ciprian Marian Costea Acked-by: Conor Dooley Tested-by: Enric Balletbo i Serra --- .../bindings/net/can/fsl,flexcan.yaml | 30 ++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/D= ocumentation/devicetree/bindings/net/can/fsl,flexcan.yaml index f81d56f7c12a..d098a44c2b9c 100644 --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml @@ -26,6 +26,7 @@ properties: - fsl,ls1021ar2-flexcan - fsl,lx2160ar1-flexcan - nxp,s32g2-flexcan + - nxp,s32n79-flexcan - items: - enum: - fsl,imx53-flexcan @@ -173,11 +174,38 @@ allOf: - const: mb-1 required: - interrupt-names - else: + - if: + properties: + compatible: + contains: + const: nxp,s32n79-flexcan + then: + properties: + interrupts: + items: + - description: Message Buffer interrupt for mailboxes 0-127 + - description: Bus Error and Device state change interrupt + interrupt-names: + items: + - const: mb-0 + - const: berr + required: + - interrupt-names + + - if: + not: + properties: + compatible: + contains: + enum: + - nxp,s32g2-flexcan + - nxp,s32n79-flexcan + then: properties: interrupts: maxItems: 1 interrupt-names: false + - if: required: - xceiver-supply --=20 2.43.0 From nobody Mon Jun 8 07:24:53 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012055.outbound.protection.outlook.com [52.101.66.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD513FC5BF; Wed, 3 Jun 2026 07:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470843; cv=fail; b=UOKFYvbl4Hr8vdROtW2L5VACx4L3UCFbqewbSRrQP8qZP1FP7KPowUVmi+xIDByNOtt5BZ+AF9k5EqF0zzFBIdDE9eHwKuOnTgjX4yfNxnHTUHtOBuvbjjErJfx4pgQxEI22hQmyTP17NxSYK3Hm8SCvX0YbW2JLfkrfwMqulNI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470843; c=relaxed/simple; bh=qzems42JZDALtZjOyylkBxSamEuZvhtzQ6EdLzhOMsI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=AdF7BvusWfuLE/Ya9CAQCHXcIKQEd15R/tAx9aXrR+9qXsifoFoQaJbW5LIXkfQ6NUFMFv/163C9dNiBAfIRfs1MeZAmwqPoMZHeg4i4dk8zPjHF+qCieQxnU16AQtEOsZb6yNKpSpFVR16Zm79aBevvQh3ptQYMartdUBkq97w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Imv/dOcj; arc=fail smtp.client-ip=52.101.66.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Imv/dOcj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sYc1MHhJeudN9h+5nnYl8M7uMhrmOef3lgUEQ5VAxwYIOrLFKohVPkyY7UO6A3rxVygzVbq/f5VrOuZMUiW45/CX2sGTZ5TPYJki0kKze84DXvFkvlIuIIBHr4QjQ3fStUu/usObJuoa1ebfIZ32c/KJr1AML0f5vElSRHJXhMJH/iXo2nARF4Qm8kus6mWNv80sZid+i2XAHPEENs1rwWvEhuYvG49/cR7aGkg3OkPFOIrx209oWIlvWcmbPPNrzyKMvcV/DWWZJNqAZ9upe8gONRw641nXdT55sN+7U2kMa0rvIhrX0tP3dg7iiriuZDEihzJ/zYMrRYlKGiISwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5uss7/Ijtj0jsVvVvdMGWuu3tCDw6dMlREoi5kZ5o+Q=; b=zFR7otfIYCdl9JLbsjLSpJGTBQubGeT+eESJaJX4gt+E0E21KGyM+WY+JH/ROK///ibhR2JkKf/RaUE1YvNTHxbhQb5lFVpaIVzkJhV/OtFj2h8T4+73WRMT5K3v0zK74sOuMrH6NAaPi8/hfaBIIvkMRW1Ag1gF7ylG+TF2fWnocyZ3I4iAF2TPwcJ/0MWhsBZNbJ3L7SffC1xx8kIT9y/5ua61+1i90Brr+jtSzeZw3FD4JuvTXKvy5A/vxZGB6bhDFYbRjL+RdEFPzPVmQmE7kuRLj8rLJkC5iSQmvsjklMX7ZnNbLM+nlvbgFzeeYvjb3onTGhJhxsBqJemnuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5uss7/Ijtj0jsVvVvdMGWuu3tCDw6dMlREoi5kZ5o+Q=; b=Imv/dOcjw8qAqhSMoEti2m2Ehl2WX9qoERf8XE3PF2O4vMxYGMi0VYjqxG2QSX8TY4ap/nl6Ly0PyJVKgh4SXuu3nW2jZNCHn6KFTswAGOvAuLZoPwRHUk2leEmS29eISXv3XEYV2PWK31BgOccFBCfV2QOqsnGpCtB9dvGfUMIY1W+C65BCHn1oKqY8itdTm1ESfLS6TVziF3UQssOMcWC6T7VaZJZ6AKKOEx3aGi5m6iN+jXzumIdWhQ4m+Kx6qJqRAOFxiyrq1Db/um2eaAx/cS6dpIpCDeMiXfbNeagt9rVTRmctSwZTqgYTTaus0nqWqXGQIhrvSe3Qh26GCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PA1PR04MB11406.eurprd04.prod.outlook.com (2603:10a6:102:4f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 07:13:56 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0071.011; Wed, 3 Jun 2026 07:13:56 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Larisa Grigore Subject: [PATCH RESEND v4 5/8] can: flexcan: add FLEXCAN_QUIRK_IRQ_BERR quirk Date: Wed, 3 Jun 2026 09:13:39 +0200 Message-ID: <20260603071342.641874-6-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> References: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0265.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e8::8) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PA1PR04MB11406:EE_ X-MS-Office365-Filtering-Correlation-Id: e7ca4a22-580e-48cc-5d91-08dec13facd3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|18002099003|22082099003|10063799003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: Zr2et2LStq23qdzgPDdbrJoLOOI3TW/JZFfvULoc8t+97O7HDHLgco5XrOgZyDhthl/4BcHwlJZhd5oBRyczCW/R+8SnGXS1qRT3nladSqh9ned/y1e805ks2jgnu+m9B3ndroehIxKA7/s/MSa3cxKCuOZUQ1RNpYGfapdhjN/8RRfHO0ngV5nJsst5bEoNPVNUm1JYIFq/xyeGUb7vj3/H22OuzzQohN/cJVJMyD6mMov9W+9Isa2ZF6MkOxcBqsh6QWlVjg25DoB87CYGw1BeCYTxr2H5OQccJhFPpDA25PoJXMc/2fXISUwPvxS0payb1HdLy7F3KZZDUruYIe+PmJPljFbPQmeQ9JyymEYdoC/UZXhFNmuAh3EJgjdZPepCckD7r1wA4TZLCJTtQ3ywbxMZXK7K9+KuMbuHVq3rEhz8abseoVKEgRWHrlH10qeVVnB1zxi84zECh3wIp8XFZ04CIzBmpHhU3Src9fSz512tNTlXff8ZZbHk8E004AK4TOZZwkIYLlbC+eAnKifQQjFh8wwD3S/5ZNKnpvd06yDRK2MgEKx9krpZYVv6Qc1YqlAFC5irymnG3WFTcif4Yi/jsDNdWx0c46PQVXYadltlqfE81H1qDvSu9+nmXj0M+BJkckrym3FbZOZDfq3WYJd2566zC3AkAFHV0VqDD6IhTDO2tWbyo37BDOoo X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(18002099003)(22082099003)(10063799003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZC9XcklyTGg5Zm5GbFBnMDhLMXNxYnZ0S2wrVDlyL1RuaDIzdUkvTy9oOTYw?= =?utf-8?B?SEIxNzFsWG9pK0dzNEVsQWQvT3d0VnZGYWZQN2pKeDhSSzJyY2d5dEI1cGIw?= =?utf-8?B?YnJHN2o1Yk5ORk52MEk4a0MxSmFMSmw3ZS8wT3JsRXRGd1ltWGJqOUJJNWpP?= =?utf-8?B?YUtyV2c5a0Vaa0dkekg4d3FHamFjZ2JhU1R5TGJ3UzhSZ09hOS9ndUNGUFVh?= =?utf-8?B?VldIQkg2QWh2azF3eExDTEsrRWEvazVvM3UvTHNQbHorb2VMaU1zTW1iRW5t?= =?utf-8?B?YjZldGNpMGdIUHF1OXUxNUx6WjdDMVhnakVNVFlIMzJmcmE1V3VkU0hRNklx?= =?utf-8?B?TGZLeFpERUxYcUNoWTU3Y0J0UUFSeG5iTjF4aWZZeXZYME9tUUhlcW5KZU15?= =?utf-8?B?a3oyUDlWd1JKMHVqbi9ZSThwK3RQVTF5U0w4VkV5WFAwN0E4Um1QaGFRTGJE?= =?utf-8?B?MFp4R0hlQTJsWkVxL1NtREhKbzN3MTdLWm9Vbm1Uak54ejJ2a3gzMXpiamNT?= =?utf-8?B?WmRzbkFydERoVVh4aDhHWkltaEEyWGdNRjMyMzhPNUFORUNzMjZkS0crd2Rz?= =?utf-8?B?Mk4yNDFCTWFjbGw4Mk9vaFNJZHhqTXB6bFpNRVRrcFZFQnFqa3cwazh6aGZi?= =?utf-8?B?b291M05FZ2kvR2ZRTVlQRU83NmU2QThnNTh2cjNrNXJRWjJkVFhDUG52S0Rq?= =?utf-8?B?UFhVOXpsUkp2TFRYVktUbUREVEVIMFZWcVNUczRBd1paUzg2eGF0R3E0dFVW?= =?utf-8?B?ME5vMWoyRkpVMUlmaUNHT2JGdGNEaHpvc0pYR014NUFZd05ldGtoM3N0UDFJ?= =?utf-8?B?NFdsWXM1TVA3V1FOR1ltVkRMaks3bFZYYUdkK1A1Rko4alovWWUweG1wVlFu?= =?utf-8?B?cVFCVUhBNVZZNXhCVmFaTmRTei96WmVzZk94N3BQVzV5QXF5UjlYS1dJZDhE?= =?utf-8?B?V1pIQUYrN1hwcFMya2l0STRpUXJ2RjBKRkt5cm5lc3hPT3hsY3BlbC9YL3pt?= =?utf-8?B?dlBVMnBia29DY0YzWjRUbUJnSXQ5WC96UWJmOHkvNStpa29GSEtTREhLdkxH?= =?utf-8?B?TTh1LzF3TTcreXdmVEpNSHVsSUlqVVpvNW9ZY1NIdUtKTHRSSENOZDlRYSs5?= =?utf-8?B?cmFvQms2eXMrVGJNS0J1cklIejU3M1Y5dWUwdE9OSlg4cUpWSEZqM25QTVlr?= =?utf-8?B?czBiN3YwNnI0ZmxSay9POTNHVmw3TTVIUjBiUUtwOEt0UzRqKzNlNzlYY2FK?= =?utf-8?B?dEtxWTNjWUYvMllUaGs0SHNGRU81aVZ0anY1UHdTNzVSeGEvY0h6ZzNFODQv?= =?utf-8?B?NVQ4YStkdEhIN21mNFZXSk1US29HVG5UODlMVGdidnRYeXlyQ3FLUGh6MlFK?= =?utf-8?B?K1B5QmhCUnNxQ2xjN2VlNVVaZEpxQS9scG5ETG9ub3hTRXFLcWxzbytDMlZB?= =?utf-8?B?SEVBeW9TOUo4RFVpeFlPbWNDWjFnLzMraEM0VnhlcnNYTlptWld6M2VhT1Q3?= =?utf-8?B?RXNwWHcvZzNtMUdZQTRlcjYxenhKRE5sQjREMnFkUGpGMmR5b2JvTkhwTFor?= =?utf-8?B?a1NuL3VXWHYyODgxOTBhWkdYL2Jvc29YbmJyZlFhWjdDSGtEcnVGL1VocFZj?= =?utf-8?B?WkhUbzAwb2lVZFpnVWdGTTRyWHYvS2lBNXY2NWoxWHRtZGllL05UdzNNRHpi?= =?utf-8?B?bXdIQ0xQclNFdVhabEYxZERBbXZreDNwOGxpNWo0SCtwZ2NEWGY3UHF6Vkl0?= =?utf-8?B?c1BkWDVwR2pTaXV6MW5nUC9MVXlMYi9tUkw3cUw0aUM5VC84Q25rVW9USFJ4?= =?utf-8?B?UzUreUdnd05lTmJZenh0MXJQMXZkV2pUZEZOT1puWm50bVcxcHNyZTJPV3R5?= =?utf-8?B?K1lYV01BRysyR3o4WnE3SHJwUmZzVEtVeXIxcTFLUjZmTTkwUGVOdUVSSEYr?= =?utf-8?B?cTBnRmFYVUtUME9vNE1IeEdvT3N4OWRJRmVZR1hPcDBFWHJTZTVSYnFacmcx?= =?utf-8?B?WUgrb29UOFFuTXFKTlc0VWVvQ0ZkVldiZFoxVG5aVVI1MjZ6SjU0azE5OUNm?= =?utf-8?B?eGRqc3RQdzFwalpvZFdkYlRuTThLOGRzUXVYY21EOXpnN2dZaWpzakFPK1U2?= =?utf-8?B?emNNVk1lYmo3L2hhaTk5TjRrSXJ3RE00ZUhKZzRvYTMyUS9oTkd6S2ZKRW5J?= =?utf-8?B?Nm12Sm1pQ2NLR2E5Uzg0MjVHQm15VUFqR1R1b0VVNnF1ZUZKcTh2L3ZEN05z?= =?utf-8?B?Zjhod3U0NDVxdWNpdy9JUThGT0p2aGpaejBuNDJjNS96QUVvd3VOS2NNdjQ1?= =?utf-8?B?Unc3SGNiWG5YbWV0THVaZnliMGdlSEprdjJKdDdCbmkybWFmS0FZUnFmbnBE?= =?utf-8?Q?ovf5A05MnVtopGXQ=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7ca4a22-580e-48cc-5d91-08dec13facd3 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 07:13:56.2834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W5gatpLs1fGvhg+rL6CYk3lxW8s7buNXcD05UYae7dd7FB8n31ZDX75mH+uiPk7BXY6iC9k09QHvUV+7BpRAkYmXizwiRSFOEETHcqqVQkE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11406 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea Introduce FLEXCAN_QUIRK_IRQ_BERR quirk to handle hardware integration where the FlexCAN module has a dedicated interrupt line for signaling bus errors and device state changes. This adds the flexcan_irq_esr() handler which composes flexcan_do_state() and flexcan_do_berr() to handle platforms where these events share a single IRQ line. Also extend flexcan_chip_interrupts_enable() to disable/enable the new IRQ line during IMASK register writes. This is required for NXP S32N79 SoC support. Co-developed-by: Larisa Grigore Signed-off-by: Larisa Grigore Signed-off-by: Ciprian Marian Costea Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 54 +++++++++++++++++++++----- drivers/net/can/flexcan/flexcan.h | 2 + 2 files changed, 47 insertions(+), 9 deletions(-) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index 32e4d4da00a1..23ddf7910641 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -1293,6 +1293,22 @@ static irqreturn_t flexcan_irq_boff(int irq, void *d= ev_id) return handled; } =20 +/* Combined bus error and state change IRQ handler */ +static irqreturn_t flexcan_irq_esr(int irq, void *dev_id) +{ + struct net_device *dev =3D dev_id; + struct flexcan_priv *priv =3D netdev_priv(dev); + irqreturn_t handled; + + handled =3D flexcan_do_state(dev); + handled |=3D flexcan_do_berr(dev); + + if (handled) + can_rx_offload_irq_finish(&priv->offload); + + return handled; +} + static void flexcan_set_bittiming_ctrl(const struct net_device *dev) { const struct flexcan_priv *priv =3D netdev_priv(dev); @@ -1549,10 +1565,10 @@ static void flexcan_chip_interrupts_enable(const st= ruct net_device *dev) u64 reg_imask; =20 disable_irq(dev->irq); - if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) { + if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) disable_irq(priv->irq_boff); + if (quirks & (FLEXCAN_QUIRK_NR_IRQ_3 | FLEXCAN_QUIRK_IRQ_BERR)) disable_irq(priv->irq_err); - } if (quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) disable_irq(priv->irq_secondary_mb); =20 @@ -1564,10 +1580,10 @@ static void flexcan_chip_interrupts_enable(const st= ruct net_device *dev) enable_irq(dev->irq); if (quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) enable_irq(priv->irq_secondary_mb); - if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) { - enable_irq(priv->irq_boff); + if (quirks & (FLEXCAN_QUIRK_NR_IRQ_3 | FLEXCAN_QUIRK_IRQ_BERR)) enable_irq(priv->irq_err); - } + if (quirks & FLEXCAN_QUIRK_NR_IRQ_3) + enable_irq(priv->irq_boff); } =20 static void flexcan_chip_interrupts_disable(const struct net_device *dev) @@ -1891,7 +1907,8 @@ static int flexcan_open(struct net_device *dev) =20 can_rx_offload_enable(&priv->offload); =20 - if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) + if (priv->devtype_data.quirks & + (FLEXCAN_QUIRK_NR_IRQ_3 | FLEXCAN_QUIRK_IRQ_BERR)) err =3D request_irq(dev->irq, flexcan_irq_mb, IRQF_SHARED, dev->name, dev); else @@ -1912,6 +1929,13 @@ static int flexcan_open(struct net_device *dev) goto out_free_irq_boff; } =20 + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_IRQ_BERR) { + err =3D request_irq(priv->irq_err, + flexcan_irq_esr, IRQF_SHARED, dev->name, dev); + if (err) + goto out_free_irq_boff; + } + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) { err =3D request_irq(priv->irq_secondary_mb, flexcan_irq_mb, IRQF_SHARED, dev->name, dev); @@ -1926,7 +1950,8 @@ static int flexcan_open(struct net_device *dev) return 0; =20 out_free_irq_err: - if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) + if (priv->devtype_data.quirks & + (FLEXCAN_QUIRK_IRQ_BERR | FLEXCAN_QUIRK_NR_IRQ_3)) free_irq(priv->irq_err, dev); out_free_irq_boff: if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) @@ -1958,10 +1983,12 @@ static int flexcan_close(struct net_device *dev) if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SECONDARY_MB_IRQ) free_irq(priv->irq_secondary_mb, dev); =20 - if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) { + if (priv->devtype_data.quirks & + (FLEXCAN_QUIRK_IRQ_BERR | FLEXCAN_QUIRK_NR_IRQ_3)) free_irq(priv->irq_err, dev); + + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) free_irq(priv->irq_boff, dev); - } =20 free_irq(dev->irq, dev); can_rx_offload_disable(&priv->offload); @@ -2348,12 +2375,21 @@ static int flexcan_probe(struct platform_device *pd= ev) if (transceiver) priv->can.bitrate_max =3D transceiver->attrs.max_link_rate; =20 + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_IRQ_BERR) { + priv->irq_err =3D platform_get_irq_byname(pdev, "berr"); + if (priv->irq_err < 0) { + err =3D priv->irq_err; + goto failed_platform_get_irq; + } + } + if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) { priv->irq_boff =3D platform_get_irq(pdev, 1); if (priv->irq_boff < 0) { err =3D priv->irq_boff; goto failed_platform_get_irq; } + priv->irq_err =3D platform_get_irq(pdev, 2); if (priv->irq_err < 0) { err =3D priv->irq_err; diff --git a/drivers/net/can/flexcan/flexcan.h b/drivers/net/can/flexcan/fl= excan.h index 22aa097ec3c0..43d4e0da3779 100644 --- a/drivers/net/can/flexcan/flexcan.h +++ b/drivers/net/can/flexcan/flexcan.h @@ -74,6 +74,8 @@ * both need to have an interrupt handler registered. */ #define FLEXCAN_QUIRK_SECONDARY_MB_IRQ BIT(18) +/* Setup dedicated bus error and state change IRQ */ +#define FLEXCAN_QUIRK_IRQ_BERR BIT(19) =20 #define FLEXCAN_NR_MB_IRQS 2 =20 --=20 2.43.0 From nobody Mon Jun 8 07:24:53 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012055.outbound.protection.outlook.com [52.101.66.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 450C53FCB06; Wed, 3 Jun 2026 07:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470844; cv=fail; b=C5cKzpFyKvC3lxumKJScPylqk7zUqzkgSbGEbdr5uitJfNDfiQmAjoz/g+7bPZenVY55hoAh+0F7MmP6+QIDwUPG8xU0eSC4NdSLZDXq68N7T/IFmVEShucETSvF6eUgs6V51Sy0Vs3fYhgJ9e1QgNp/PhRRybGkZ8D1GsOc99w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470844; c=relaxed/simple; bh=dvqlA/+PsJJlEzncLWa+oyUQ9lH5CrO9L1+Eu35xP4U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=OipGqXr0h5ILVXDn8WB86F1IHb/S3SKYEpiBnG8cUFGliCP7hnZMMP2JSSFdQXtFZWeHyO3AnDD/dZ1LdqScnBpyLsDOlenMDl8WT7D+Cja9Tt1KnDGBBTBkZZvc7J6li/Huj12FE83dkh1ZEcaq03va/NjIaR9YDIoAPrQyehg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=QOPaQUdd; arc=fail smtp.client-ip=52.101.66.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="QOPaQUdd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=if2X0sWV9MiZZzThqCZ8jgOuKKhwm5mdkLRs/zBwNYzpEoFZhGzN9WlwIFecdIUbiJmC/+i8I1cEUAh0boGmt31fv1lknRtjEM3vwlaS4AKIxpta/R5ImmRR2puKLeAakejzhNVCExCdYB0ZGz9Beu1lGi+ZGX1ExxxBMAsYpFDN9SrbSiYGtWuGE80RBYlScR434a2j/4Z/ItHxT5GaEKgogjZVNTyt+EDyXF/pdyBYxxieCvv2/IVy8VqHVcGTRibhqQmj5/d1kBAFZJXdDzezNvwSH2ILlPuoSbRoRluNXz7XVRSFq0+rxfD6VBqgAQFuqqgZ/I7dGtDSALqr6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DuI02eGgTMohLDcKqbUKOD9e9B5e6+jwjve8/2Av1iA=; b=V8ZuZm4DZ2JDxq3lJ3D3JjXjXG80fZE2YdZ3VPD6jp3GiY1/uW6jzG9xGnngY5l9+OGFaJ8hPsXNjUwASsbrTaJ2be36rtWt1B45SpOS3MxNVM7L7eHh2jgWd7g5ltgOMEc0ogSCWPUBmhaqpaHN0IOeB9EzV7e+IZAD+xYiE1M8uV5yhEQRMTCIUW9M0gQKTFnKx+iQ3Mw+M7j9/YMQugmA+pELwCynCHFglHx8OY2vxFlzkyoiQ5wBR2IeBsYWTzR7YHDP0LwXDYGBOat371JfUI/nmoJA5QSp/aE1BAt2huu0fTXTdOWfp/UpC27wdVYEiVzxpOCqukzJefUssw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DuI02eGgTMohLDcKqbUKOD9e9B5e6+jwjve8/2Av1iA=; b=QOPaQUddK3MnExMgmtGzJiFTFbi7JOPfc/4IQgvgAdi3Ub+yKWwJfQSOnGPKVf5fu4eNiWnbcLO7gjOWDjXGpuQdiVTQqFSEWjq1VQQW0xRNhb0EhP5WqYH5TpU0og5pxVhmWAl0j8kzIeqeMFenctMNeBg2fJj4acQRthbaG3Q611W5GvC9o4ys1Ad0qGiy1eJxKP8mcWCqwFOX07R5qdz1nuAEizcoB2fyDhM/aW99XcaXgWxgP01OzYcpHYZqWwngXdLK6mc6uEjKCZ02HkKkQ3uWHOF+gbRD8XvjG/7QgDK6B3VvbELFK8sTnGWgmzmMO8nx5VeUY1Vd4/50dw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PA1PR04MB11406.eurprd04.prod.outlook.com (2603:10a6:102:4f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 07:13:58 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0071.011; Wed, 3 Jun 2026 07:13:58 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Andra-Teodora Ilie , Larisa Grigore Subject: [PATCH RESEND v4 6/8] can: flexcan: add NXP S32N79 SoC support Date: Wed, 3 Jun 2026 09:13:40 +0200 Message-ID: <20260603071342.641874-7-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> References: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0263.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e8::10) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PA1PR04MB11406:EE_ X-MS-Office365-Filtering-Correlation-Id: bdeabf49-85b6-4661-eed9-08dec13fadff X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: nNVhgc0lksMegnmQ4R3k5j5fttlZMnvgXUt7pUJMQqxE3CY1KUmzJ2ee/cpvWwmKsKviwGnZPFURZ8VAWstsMv35wh6CdDwb3UOvXLQ1VowGaWmxViCC1ZjSG/UlI1vn+7592WV8sxMnLe5S1V7fgkjBk22luLCAtwd28+NqkA2YAfmpWr2uoMeDVs/DhHGLHC5oZeuelPK0DMuzgfiZZpxfQ1CjyIClXoQVqFqcH0f8Yg1igoy8w4RfmeuQXlbDpg0QQ/+EhnrabO4QYZzK9/4Y/kOBQOu/EUEV30uNgkg8aCD7GSNr8muneox+wDMIgSnrk3z3QgPNpIHDdkr8wkkcWnLQGMJxgtAEwtpLy8MqCgzVG5BRa16Z0TIUfsXBCabLZWr4UMOgUQ5rl/nfyHzClwcMCAeGPRNSwdOx+w5SVAvUcOgqyk7TqPi9AXkQ4OcNJyGcZ6bBjkS1mYueE5SCiNrBB/iy+pKK6WiJNKDt4O5C1mUQRwtTDqdHAIlvUwYI69S0sykUjoP2mbARS6KJAdEOwFQljU3w9ofQZLtNYC9GRCztMMZTtPra7re1s65Vxj7e7Ok6VyQxbEDj0WeXlBgZIlFh7RHWW9zMrzL1mGjoQnfjc5ya/sQxNZkNVXNRjl3x+G2KMStNQlGxPGJGYdzkFbSkJjb4WJO8cxgy9Vh+uYZAvwlRXqJnpVHU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmh1V25adWY5ZkRzbWJxalZCWVc4SVRCUUdYZnNLajFvNnM3S2poUDRyU3pJ?= =?utf-8?B?QjVJazVZUnkyV2VZbDZ6QVhiUC9xcnlEMXZmWno5d1gvQkVpQ3l5NHBNQU4v?= =?utf-8?B?Qzd3U2VreFdTazRSaVArVi9mdm0ya1FoUC9ITVZOdFcyS3lSSWpKZll6aVZr?= =?utf-8?B?dFlWcFRDOElKSHg2TzdnY2dnK2ZFcTNGc3lkTVM1T2oxMUUwM2lYRS96Z1FV?= =?utf-8?B?d1YzRkVNUlNiVTJBY1c3YkVJRkQ2N2gxTThwaGRpMlcyNC9pQXlIK3NjSnVR?= =?utf-8?B?cHJDRGlwVTlwbEZvS1JNV2s2RTFScEJWckJrb08rdFViSTdaTWM1K0Y3Wm5y?= =?utf-8?B?cTE0Unh6T2VFLzhtN0N0VCtJaFUweTd4eEx4QnRDSTVtRzkvZzlSY0ltL2RZ?= =?utf-8?B?Y1VGbDhYSm1RcXNZSy8wSWpsM08rSGR6S3B4Y1F3MUgyZmM0aHAvQXFXcVV5?= =?utf-8?B?c0dkdTdibWduY1dUVDA2MTZHa2hGSjJQVkFQS0w4S1NBVHUvdkJ2K3daYzAx?= =?utf-8?B?eXMvZFdOaUJzRFkzRG5LaDV1b29HK3g3TzhoYnZGS3hKTldZVHdUUUdVbkFz?= =?utf-8?B?MnhhZzJUbFAyMEI1clB1WGYwWGRDbkpGRjFEM3g5VFRZRmZmRElKaGRML0dC?= =?utf-8?B?dWtTVjYzdkJhNWtUWi9hVnNyTjdkRmtiQnVjdzdpb2hyNWJQNFZEdkhSbko4?= =?utf-8?B?SEtvUG53QjNpbEh2YlhGOWNZUUNrbVRwY0NDMEFLbzMzWlFPcldNcFFkd2FN?= =?utf-8?B?Rnc0OHB6VjBQcTlBYks4akg3d2xQWGE1YlNrQU9xS0ZXSEpOT0VCTjJrRGgr?= =?utf-8?B?Y3pCL2orWS9ELzBSYWlhSXp5bkJoOXBCUUJOaXp0OTFUZG5Pd3phZnFBaHlW?= =?utf-8?B?cWptbGJrY2xKbHhOdW50dktLRU1IaTM2ajBOc2lrWWt0NUlSZUVPeGxuZ1RU?= =?utf-8?B?RUE1cFlTTkwzbEVVd1p0L05GdFBEY2xqR2NRNG5IZHd1SXZMM2dQNGtyaHhI?= =?utf-8?B?eWUxSHpySjNtaU5EYlBnU2pEa0xNUnhFUzVzbWxCUExjQno1c2xPaVFOdGJH?= =?utf-8?B?c0tPdSsyRDErb1pzeTJTaWQwekhna1RmUG1icDNhQlJFYTVEM0Q5cG84S0R3?= =?utf-8?B?c3pibjh4dUpzdXdKUXpNU3ZwQ3hjRUJZRUM0VVJwbktHS09RQk1sYyszRkJ1?= =?utf-8?B?dGpwMVBjSFJ0NHB6L1hucm04eStXZWJEekptK2ZkdzRtb2g2RkVZNVY2akp6?= =?utf-8?B?bUh4R0J6bDQ2OTRFNFdoNThXQWdqcGcxRkpHdExLYnZhVzg0M1dUUnFSMmJ5?= =?utf-8?B?WW8xOVlzNkp5ZXd3dDVSb0JZUURUUmRPVXR2WDZIL1NnTXhmaHV2aHYrOHFr?= =?utf-8?B?ekIrcWF3TXUzamdrV0lXaWJ2WVZKcmh4T1RML0hHbHY3S3VuWWdpejZvR0pU?= =?utf-8?B?Y1h6eTBGMktlVnB3SmZETDdCS1JMRlJERWhNUm5sNDEzZlpFaWpEamdvUDdo?= =?utf-8?B?VEZuaFN6OGVRSkZLRm5PQm53amFHQXRNSXZCMUpWMGd6TXBXdjhZb2c1YUpl?= =?utf-8?B?WVpUcENnNjJHOEZUTzVzcDdlWHR4aHVpYTA5NVl1THlsakxwU0xmZFJVSVBh?= =?utf-8?B?MzBzdmhFQlQxby9zdkQ0TFRCZWJzR3ppTDhqTTU1NStrWFI2VUNta2pqSXYz?= =?utf-8?B?NUk4NUNXSlh2Rnl1bVY1MkhBM0FLOE1kSzFQRC9yaEFVSlRnMXhUa2hDMzRB?= =?utf-8?B?WmkxV1NTUEMxY09ZUVJ1aFUreHY5VDU3c2MxQjYzaEF3cDI3VUZEUHBzS0Vr?= =?utf-8?B?K0FkQW5zUnhoR3RmZDNxTm5ES2NCK3BBRDBUSVhwOTJJRytNemJhYXp2MTdF?= =?utf-8?B?K2V3SHhqc3VrbEk4TkN0N3d6aHdlTzY3NExIdGZzREVEaUZsOXRaZjNkOXA5?= =?utf-8?B?aGMzR3BNNjRkZlQ3U3MvWE5oUmFEYjBzMzQxaDJNQ05zczlidThMdmVVYVRC?= =?utf-8?B?cVlzQTJKY1RPb3kwMFVGTHljTGhTUjhlWElhQU1wU1pKcnpUN29yd0JPaVpH?= =?utf-8?B?NUF5R2hsbnMwM2tTMFgyMGJnbk9yNCtLU0hodWFKcEoycWsva01EWU1NeW9y?= =?utf-8?B?bTgzWG12elk5SEorMktmTGE2WUc3Z2pJalgrVXh0Rm9qREUzeVBUSUJ4YjY0?= =?utf-8?B?VFZUUE8rUndjS1A4RTdoOFJ3S09NZURaUklSanJ0T3h6dGdhREoyR0cwNEFn?= =?utf-8?B?VzVnMG82QmNoWWtGckJRS1RYcUFLTXNmYjB4ZzREc0xlTW9HbEZKdmxrMW16?= =?utf-8?B?aGV4bks2aHplSjZVbVBZbEh1YW9mRDVaY2FvS0NtdjZiZDgvK09YNWRqRVV1?= =?utf-8?Q?WDR83ixeqixBaTDc=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdeabf49-85b6-4661-eed9-08dec13fadff X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 07:13:58.1361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 01V58R+7pkePjorjTtPmobjRvq3DEy6yrUDE2T8PrYTBiFM/zTzZGlOUjMTjL6uM/J4TdTm5kcGjQ55+hayrXJYEAnh/j0G6zbnSO85BoiI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11406 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea Add device data and compatible string for NXP S32N79 SoC. FlexCAN IP integration on S32N79 SoC uses two interrupts: - one for mailboxes 0-127 - one for signaling bus errors and device state changes Co-developed-by: Andra-Teodora Ilie Signed-off-by: Andra-Teodora Ilie Co-developed-by: Larisa Grigore Signed-off-by: Larisa Grigore Signed-off-by: Ciprian Marian Costea Tested-by: Enric Balletbo i Serra --- drivers/net/can/flexcan/flexcan-core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexc= an/flexcan-core.c index 23ddf7910641..9ae0d9eb4ccc 100644 --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -397,6 +397,15 @@ static const struct flexcan_devtype_data nxp_s32g2_dev= type_data =3D { FLEXCAN_QUIRK_SECONDARY_MB_IRQ, }; =20 +static const struct flexcan_devtype_data nxp_s32n_devtype_data =3D { + .quirks =3D FLEXCAN_QUIRK_DISABLE_RXFG | FLEXCAN_QUIRK_ENABLE_EACEN_RRS | + FLEXCAN_QUIRK_DISABLE_MECR | FLEXCAN_QUIRK_USE_RX_MAILBOX | + FLEXCAN_QUIRK_BROKEN_PERR_STATE | FLEXCAN_QUIRK_SUPPORT_FD | + FLEXCAN_QUIRK_SUPPORT_ECC | FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX | + FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX_RTR | + FLEXCAN_QUIRK_IRQ_BERR, +}; + static const struct can_bittiming_const flexcan_bittiming_const =3D { .name =3D DRV_NAME, .tseg1_min =3D 4, @@ -2232,6 +2241,7 @@ static const struct of_device_id flexcan_of_match[] = =3D { { .compatible =3D "fsl,ls1021ar2-flexcan", .data =3D &fsl_ls1021a_r2_devt= ype_data, }, { .compatible =3D "fsl,lx2160ar1-flexcan", .data =3D &fsl_lx2160a_r1_devt= ype_data, }, { .compatible =3D "nxp,s32g2-flexcan", .data =3D &nxp_s32g2_devtype_data,= }, + { .compatible =3D "nxp,s32n79-flexcan", .data =3D &nxp_s32n_devtype_data,= }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, flexcan_of_match); --=20 2.43.0 From nobody Mon Jun 8 07:24:53 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012055.outbound.protection.outlook.com [52.101.66.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35D1D3FF1D8; Wed, 3 Jun 2026 07:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470847; cv=fail; b=ZbT5Omat4hCDd3LPRg3UauicQQL60rxB32O0D0J5bwfcdtxpN+OIjshU2Gw3vxFHmrR8VUEJQVjJMINwe1dFwiutZcJ5dDdFWuVjcvyOS3f2h+OTn7c87PyOTr/zWcSvYCvi9llnoDRAP1z0E7m7MAO/pJSjNxbvBGuXj5S5QeM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470847; c=relaxed/simple; bh=AmkQXFLaAgioZXQr+kr0ifiAPUfa04f++MCQqAML8pA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=P9nUb0yvoOmtf71GWqU1exynPgvdN34qDjiHDUIqn8kvoLe3zLSFQBGIa6UNB24PxUh178J/P4BXV37DtweMhizkZE0wzdhd0es5l7zMCJEIv3rJMhAswnOpww4c22vAlQaCS0bHGJRvQKGNXPP7CzutrbQl4IcIV9mrFuuJq2U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=RppTPrZ/; arc=fail smtp.client-ip=52.101.66.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="RppTPrZ/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b6PFdmRj1qyuSmRXllJY8hMJbweZU3L2mrVA0iDdYgIK7ydMpPHOM0XtPeS/S4hhfYee8Z8shn0AOcYll6ttqNs5Dv7RVa4C+YXDjZe5K8eKN65K2VmC5VA+IRexHBUc56ESaBmwZT2IcIcir4pOcSjHWYkVzrFEGLYQ+mJNMyxFlx9AjEsqtGDnp8nEutEnXAAttVXwIDwTh4cKEBJC6a60SM4sbhA21kl2eGpCqVt/dOkdGxGCxbB4lPLRI3MSzrzp35M9eovdRRZcXCyE9N77///+jxgkS92J4A1hFnH17xduc5cCkoTl6f5PX9fo1muwaEIsuNYd/+pn7LBVNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U12gOewEf6DEQLWhQ0GYz+ip2neAn9Tagkuag0OJu1A=; b=Sz5rN4ALszA9AqyRnFhLc0uy7nFwKRByUcrtAKzj1mN4AipBDqolk9sSfH2DWM/djRng0f2q0mGWcYgSGoTrMok64XFhcLyr2TELFQtH59GF34B5zzAHBeMd2G6o+qWvPgSgQnCFMdVDWpA3xMUiPfD25GvgScUj4fYQI/aATyqMWDJi6Jemb9yJ/NHaWmFB9WftRQinfqlnCw633YtdQ5Aao3ovsVPmcCmVjx8he5dusXodMy4RGhc4kmpTy1bSLrGlsLNKbj1IeJhbrba9ofTZYiEi6+2dMcrczKgtbNKxFe4JHrcLP32sYCtm5rUbvdSAZuvkip2+M5l1YZRgBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U12gOewEf6DEQLWhQ0GYz+ip2neAn9Tagkuag0OJu1A=; b=RppTPrZ/0JXsOVZAEGaa7Wp3IjELD7sQlhTsOUeCAab0FAJGYBpeVkOKS0skUTUVQbI/0UvEozaJVFaOEy3eVcZD2hqwbIzIYdVeEx+z5vj5/OJik+5KBGrO+1WZVInM17KplQBCDd+HDVR7IeQJyj8ZedhG85gdYRmn9CIk+9ORjqpmRURdAoqN0xKtaquLheoY6tVBFBWWE//ehv5hS5/n4r7G/hPZ60S1TKAK02T9NmHVZNK01JXLs7mkLlK92YqFnI0GD2p9nlrs+g7a/U7Ns4na15RoLcjDwWMJ/B+QYx9RmUbboWvdggMNZmfAFdufwLmw+WsuDS92LYNh9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PA1PR04MB11406.eurprd04.prod.outlook.com (2603:10a6:102:4f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 07:14:00 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0071.011; Wed, 3 Jun 2026 07:14:00 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea , Andra-Teodora Ilie Subject: [PATCH RESEND v4 7/8] arm64: dts: s32n79: add FlexCAN nodes Date: Wed, 3 Jun 2026 09:13:41 +0200 Message-ID: <20260603071342.641874-8-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> References: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0263.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e8::10) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PA1PR04MB11406:EE_ X-MS-Office365-Filtering-Correlation-Id: 64fd23fb-8600-4452-d75a-08dec13faee3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: 1HWE47z1s3A9fIVyJgJHd6TX3vzODnOxcLX3zgPYp6awIhA7DASDg23ILOfCe6A0CNjgSnplxyMMlbPYE+nvU4O7cH4Th9PpCrWCFSQF+GVtDKD3VHIaqlif0QULgjwpbxsZlLC+XOopNdy/+WuY9Y8JmH3F2qOlKVG6FNPq5JjHGVD5/9j+bWvPkUFOzApJ/YOFp+oqC0e/WCF5Kkz9SB4MMdULQJ4vyFvP45fh/R9uIsNE6O0Tlfwaou+gpMoT+LNzjuQPEqU/cqkrKcu16FwcEfFC4Es7XPv/oddz97kLqOIGpSsE2jVyPKHJJewVmcL1WY7/hwVnZoo8SqX1LQ1OQDnRCfypTrCBYNkvskdnJCPGV54ZLFB4wnElk16bLYzzVsS3e5Q1B/BD9Wr79WgUCP2OooqyYL8vnFTK8Bh8EYuCgzJIRtKvu5CIY0rjSthFZCHi47rXCVLCev6bSZGFMlsMcIBQFoh2tg3r/YLY87HjjAqqr0v/1yR1j0O8doS0d8uxMsqbxhNnDxJRjDz+s7zCnoWKTCd7WeTVpo4ZEyB0NKjoF00+FoFjlCLbHasxIsVJDolF1Nsx+GTFMnLsLvnS7y+BFqR8/SVlyxv+MpDpLoR7w1NToUXIrcHV9OpbmqPPOXdOF2811QcMDSPb8MI8fT5jFPUy5UTovQiw1QLvXGGf1k7dyJLjP/fp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REY0QzRqVnBEZVhYL001aE9ZSitzS2tGSkxUeEI4OVd0WFdRV3l3MTBHcGlK?= =?utf-8?B?TitCaU9HK1gyb1VwSnBwQ3cxVnZvZVJhSDlNSTc5Nm9mWTh4ZDBmQmxrOW9t?= =?utf-8?B?S0w0eWxaOEVlOWtHckV4QTBoS0lHWTgrTnN3VmRFNE4rdWZISjBnMWF0YTZS?= =?utf-8?B?RkNhTmRDSVNKeDNkVnZ6K2krd0dlS3g2bGplMkhhcjdycFlCaGl4N3VIbVB5?= =?utf-8?B?QmhnMjJWZHN1SlNFYTdiV0dwb05vZkN0SHhRS3VicHBoS3RLM2V4STZQeGRR?= =?utf-8?B?Uk9CVUhEdzY4dDZhZEs5NE50OVUrVGdwa09Qbkxzbkw3YXp6SkpLb3hpaWNQ?= =?utf-8?B?NUdpSUVhZ2VZUGVxUVpGaUlwTDZzNTQwamhnWHVocU1rTFEwcllBMFRRVksr?= =?utf-8?B?N2J5eUd5UzlrczB4TzNTTmRVWkk1L3ZzaGgwY1J0cmlDUE1MMjhJNWlpWjlH?= =?utf-8?B?OFVxTEZ0UENRZTlyV29pRXZzMGduVGpkNldXdzBSdnBDVU5SQlE4SkM0enUy?= =?utf-8?B?bTJDcTZJbXlnbHBrMzZwUXpPMWVyeGtJSjhMSzgwUG5jZXBCTjdOOGRlNUNG?= =?utf-8?B?bWlocm9QTTZmUkpXb3N1d0pjbTRGT2hJL2NjNkdpK1FpOVNreFVNcExwUm0v?= =?utf-8?B?RHBvekUxNlpqTUFUYUZpd0xlWW0rUkU5d3Y1NTVoaUFBRHZHcXRWTXdvSGVX?= =?utf-8?B?NTJ3SmpEOTVVcnpGWW1PWkdVK2ZRVnlPMDBya0lhSnRpQjFJVFZDRTV5TDJP?= =?utf-8?B?QUQxMmMwL2dlUy9qSExTcGlZcUllRE40dXU0amM5OGZwNXN1dGFWYWl6VmVB?= =?utf-8?B?V0xySEVYMXFsd2tvMFlmM1Y5M1M3RHJOajRNSFc0UVpEM0J3dER1ZmJNZE56?= =?utf-8?B?VmNqRjV5dlhkdFlRZDZkdUNPWDhxeVZTMG1oRllMU3hyM1FkVmFobDFXSmhR?= =?utf-8?B?V096V296eDQybnRPL2ZkWHI4VGtLaEE0dTNwSnZXYkFLSEwrRnBFblhjM0c3?= =?utf-8?B?bEdvdEtFbzNNT2J4UkdadFdGdlh5ZnpYa0dKUzlXZXJiZFNYM01QcnZ6TWdp?= =?utf-8?B?M1RsbU9jYVlsVjMwd0xzejVGdE5jZTJJdkVTLzdEVFltSGdVSHR4MG9XY3hY?= =?utf-8?B?L2xkYXhZUlRycmdGWE1UK2dudXh1czJaSXhlVHdmKzN4Ny9LdUlSaDM2M3dO?= =?utf-8?B?eHFUNUpXYW5CTTM1R0dGeDRvai8reDhVYVJZWXI0V2NkeURLc3p0NDZDSGU5?= =?utf-8?B?WGlVS0RCRGhCNVVmZ1RHa2tPVVRtWjlJREprazBscXJGbi9YaHdCSkRueCtW?= =?utf-8?B?T3k5cDNkSTM1L3JvSEdXWjJlcEVTS2o0Y29GdXdVUnA4Qmp0WVFIUDRvdjFS?= =?utf-8?B?L2ZHdWZ3em9mWmIweTdadXo5b0wxcFlwUlIxZmNxQnQ0QmppYkdxTkJBL3Y5?= =?utf-8?B?SHovU2tzaTZGZjdLQVF0UUJVUzdNSExZRnFWdktzN0NCWnZUWmU1azdqV0dE?= =?utf-8?B?TzhIeVg3RTFGSDBqd2lEVHBRU3pGZzlUZTZudnY2VWNYOFRjeEhZNm84TVlX?= =?utf-8?B?dGZOaEtiNHB6VlBuRS8wTDF3V0c5T1RmaVRta1ZJT2FFZHBvVUo0c0FZdko3?= =?utf-8?B?VGpVYld3azdiNFFCaStYL25QNk1lR0laakxPbFNUNnZMY2ppSVM1S2VFeGhV?= =?utf-8?B?d2hkU2loc3ZxZmE5SXRWK0VPb3JGb1Y4bTZLTFhPM0JTa1Z4dXByV09Xc2Vh?= =?utf-8?B?cTVIZzZ3SEdURmFhZGRjcHNyTnQ5RlUzL1oxRkZTVjBKZDllaHg1bkx2TVJr?= =?utf-8?B?UXV3ZzIrSDExSEJHajBIcTVGekJTYUx1dWhpSllnV1oxMkZkcG16VnE0WHRE?= =?utf-8?B?bzUralowbjlDV2RuZXdmQUd0MXNuMW1jb1FScUttLzI5UmtCcWpDcUlUekdR?= =?utf-8?B?WnkxN3FZMVVyemFLMEFTdUplMURuVDR4YmR2dzFnK1ZXYk5ZMXNlejd6VTNs?= =?utf-8?B?QjhXeEVOZytuZHVhdTB0WHNCajNzemI5eVdNcmFLc1cxOXlRYVdjRjE5WXh5?= =?utf-8?B?SGNoemJvNWxmL3grTG1WeGpsSzBtUk1kUVdUMVlGRU8vZW9pMHRYdFhIWk45?= =?utf-8?B?akVjSHlJQ3JaVUpPd09LWWF4MjVNanZyQWw4MENrakVidWJZTTlVMFljYXc0?= =?utf-8?B?Sm9iRzkyVk9KRTZhNjVLdGdhZHRYRFBtMk5jNE9mdDBzWUlUZzF0RzBQRjdU?= =?utf-8?B?ZHMxSlpyVkNWeXFxd21jdFBYbFBuTUtVbDJ2RjdLalo4enNFUHBlaUhZcGJ2?= =?utf-8?B?RmRjV0NFRmwxdHhtTi9yQUFXeFhJM0xuOGVkTm1ReXM3YW05MVN4WHJnblUx?= =?utf-8?Q?L6mDCQK6hNL5IUXQ=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64fd23fb-8600-4452-d75a-08dec13faee3 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 07:13:59.9890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jec/96q0+tAt9FI0uP8NHKiY6hwb6+IB7vfKZcqimQM6OoH2o4jQq7Bjk0Ssyas8QhgE4fWSZE6VOKGK/Qxfun/NE3/XHJfwSYUAluNrZ9M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11406 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea The S32N79 integrates multiple FlexCAN instances connected through the RCU irqsteer interrupt controller. Co-developed-by: Andra-Teodora Ilie Signed-off-by: Andra-Teodora Ilie Signed-off-by: Ciprian Marian Costea Tested-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/freescale/s32n79.dtsi | 50 +++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/s32n79.dtsi b/arch/arm64/boot/dt= s/freescale/s32n79.dtsi index 94ab58783fdc..c1a4fdead91d 100644 --- a/arch/arm64/boot/dts/freescale/s32n79.dtsi +++ b/arch/arm64/boot/dts/freescale/s32n79.dtsi @@ -352,6 +352,56 @@ pmu: pmu { interrupts =3D ; }; =20 + rcu-bus { + compatible =3D "simple-bus"; + ranges =3D <0x54000000 0x0 0x54000000 0x4000000>; + #address-cells =3D <1>; + #size-cells =3D <1>; + + irqsteer_rcu: interrupt-controller@55101000 { + compatible =3D "nxp,s32n79-irqsteer"; + reg =3D <0x55101000 0x1000>; + #interrupt-cells =3D <1>; + interrupt-controller; + interrupt-parent =3D <&gic>; + interrupts =3D , + , + , + , + , + , + , + ; + clocks =3D <&clks 0xf9>; + clock-names =3D "ipg"; + fsl,channel =3D <0>; + fsl,num-irqs =3D <512>; + status =3D "disabled"; + }; + + can0: can@55b60000 { + compatible =3D "nxp,s32n79-flexcan"; + reg =3D <0x55b60000 0x4000>; + interrupt-parent =3D <&irqsteer_rcu>; + interrupts =3D <0>, <64>; + interrupt-names =3D "mb-0", "berr"; + clocks =3D <&clks 0xf9>, <&clks 0xfc>; + clock-names =3D "ipg", "per"; + status =3D "disabled"; + }; + + can1: can@55b70000 { + compatible =3D "nxp,s32n79-flexcan"; + reg =3D <0x55b70000 0x4000>; + interrupt-parent =3D <&irqsteer_rcu>; + interrupts =3D <1>, <65>; + interrupt-names =3D "mb-0", "berr"; + clocks =3D <&clks 0xf9>, <&clks 0xfc>; + clock-names =3D "ipg", "per"; + status =3D "disabled"; + }; + }; + timer: timer { compatible =3D "arm,armv8-timer"; interrupts =3D , --=20 2.43.0 From nobody Mon Jun 8 07:24:53 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012055.outbound.protection.outlook.com [52.101.66.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84D2B400DE3; Wed, 3 Jun 2026 07:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470849; cv=fail; b=iiCqStTjJQAfA8AJf3eNPY6Fr+qA0NEPPqJDy1Ncm5yUPZq6aQm7DG7FlIGT/sKRQn6ApPghWnL2SvVIBGq+cmaFBRK3oOj47FgGalgDqlEOvWLHmt6DAOskgBrPKXvLrifHINkDTR5lTc3bAA+jJ9zjzsagc3pUDGSvtTqHFw8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780470849; c=relaxed/simple; bh=NjkkmEQvIhu/ukpc3rYoo+G4FDElFzZoJ0lqkJdSKiU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=sCJTWSJke+Dk2rzXeTnuKPitJ1/JgSf8UR124i6PNiCitVx/GrwFnc/FG9tL5CImctQ+uJ/MBr4HjFQhn+sPdYfNM2xd4xTihMO+mGFW1w53HLA2d1s5SiRSKqsxdqhaVxepND8Ct5jLtCY8JEjBT+cxuTMaDCB081Lz8CA6Dyg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jyRh3lOa; arc=fail smtp.client-ip=52.101.66.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jyRh3lOa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MgMuco1j6JatuKiGoQDSIV5B2555f2g5/cJOyR/cI8hgj/F1qXVY5Z+t6raVLQjJdQaab9vPa9O0SeFcPefQmKoVWz27NHE5squLpnl+22kHj6zg791mG64UrebJb4pi5dDkgT8ghhpW3/8RXe+li77MZsZdfFAfsfMa0E0dLu/z/Jcy9dC6cdLkxHmpcpZcFRSmxVF/WZzvz7amUAaKrA7LC5t12iYR1YzMs7SqbDXa1f9IETyXpWtRggXRklrMJOINZHjVA6+SH4pxTei5cimkyuNBRUeZA8jW9TtyRy8HHu06uQbmvi5HwZKp3k1Bw0yNhoB6UMCrfc4+qZUMpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GRQouUAtAoFM2r1Ht6OLIZn6BKh+s2A174EICOx9dcE=; b=gya9EC5ZlcLyjq1ixUeM30/zLTDpwzN/u2qr7cdHw13hiLwg28s7KaNBwDMdYzlxL4x6IJlbfgewcbPM9gUrwhMwdUAUq7nlFrlKWM3G3pZnhmZAg9+y5xwFiCH+N16K3r0rCH+tIbTGgBZLYlvl17rWgfBJp0GN5UcaLhhci+dYxknlHw2fTC1E4fb+PCx7U5aBoXqBDilUgLJUbqPUFAcRd6eShvsOOwYcpvWDConJW02xk2FoCtmSbnO5bPBBHAnhpuY2dmJ/JX9ZFE5rqykSD3EUCNm0EqZPi3CAk0iVYEUe3imd+ej5Fd2NTgWSl1FrpMBcZrvciBC/keDU7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GRQouUAtAoFM2r1Ht6OLIZn6BKh+s2A174EICOx9dcE=; b=jyRh3lOaTbfVxbx4Tr63g9LP65bMU7YMPGOIvJ8k3BDSRB2GZt8j6EiqooSB90jWRWyWX9VpWHhLo8/BRZ1aF/mCzOITQun0YRGo3uDQwe5UwZlS3vpxU1hQHUySrSnz7wzltghMnAjRzh/nFEp5bo/N3xuJxgDzi7pbNSQhRT6E1OYCWEA2ZCmUSJudyz4wh73ig20y62xM79bvHurnzKQQEgkdF04nHhGLi+BI5Cbn0z7tkGAlz4R4za5yQRzfaJ7hePb0g1ehYS+OJ2ZvQHgeokWXv0rVoFukcgaZueWqsBMTspLZnAemq4qHxRN6g2aEQ6D+y5g9njCJP3rebA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) by PA1PR04MB11406.eurprd04.prod.outlook.com (2603:10a6:102:4f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 07:14:02 +0000 Received: from AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6]) by AM0PR04MB5858.eurprd04.prod.outlook.com ([fe80::bdf4:c9d1:4e3f:68c6%4]) with mapi id 15.21.0071.011; Wed, 3 Jun 2026 07:14:02 +0000 From: Ciprian Costea To: Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Fabio Estevam Cc: Pengutronix Kernel Team , linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, NXP S32 Linux Team , Christophe Lizzi , Alberto Ruiz , Enric Balletbo , Eric Chanudet , Ciprian Marian Costea Subject: [PATCH RESEND v4 8/8] arm64: dts: s32n79: enable FlexCAN devices Date: Wed, 3 Jun 2026 09:13:42 +0200 Message-ID: <20260603071342.641874-9-ciprianmarian.costea@oss.nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> References: <20260603071342.641874-1-ciprianmarian.costea@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:bb::12) To AM0PR04MB5858.eurprd04.prod.outlook.com (2603:10a6:208:132::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB5858:EE_|PA1PR04MB11406:EE_ X-MS-Office365-Filtering-Correlation-Id: c849be3f-ec43-417b-11f1-08dec13fb04f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: MUxvbKa8l1axHp/TFfiGMc8eNiUTsPhtGduozyhaZRuwmrtIhpjDxVs7m7ZQ+XRHv7atqTb1eszTj3etBvXHcXkfp3jvBSyrwGRTm7n+Ty/bEqgMFKKHlmIjIgeC+eWm9bumLSa/6L0TH1lf8rq1ccTZukRHHnjWY2EQgbHx1LaPzogQ78PNfUP5J/WCIol54S9t3b67HptC7R7ZeIwOMT2t5VIJ399r3isy2sWT+TlM0PIFi72oCAqd7xiX1DWjZpx6uF2V+BJEAJyZK8V1VCZ+8AwedDFnPWP4fqpSTjDYkKKXv73PrLufhkRXIU/VDHkmIRuP/6NXuq0G1pk3cbFnD40RLY4H+xtn33PlrqtBsWQMbJ1pSFSNt2rHbWMMc5TsGskc/TIqBh+XtHKHTG7JgxeivdNQEiAJjuCyjUP+NCdM7sgJtD9oa7rgGErxneGE/Sq/6Rz6Rrdf6O+RvobrMFEYbsH5ai4g2FOPDUFNLKL63EvLfMN0ZWGELN0wZ6dOzdGRRwPZ0opTx95C51fvJ7zWRZvO2qcrv5c8+VaSS6F5kxrApgV4WAeczw8QxiP60a0S/cO+WkLQZHEXkUayd9LsPf+ZLkX1RrBOj0umwMAnnSyecb7oeirBBscljsttpaII2lLKVcVuh7a2yUBu3eHuTN+dfB4HrWwEiY0M1guppGowEK+GUJcCSR7J X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5858.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmY1WmphcVNGNFVZdVlXUzFTMXJYOW5TTFE1TE1YWGJoMDV1ZmhTbVMvM1hB?= =?utf-8?B?aHdIQjVwanZNOUVodHhPa05KRURaU09lM0hzckc1V2x3MTJtdmxLZzZuNGMz?= =?utf-8?B?L3dJQndxUERTQm5BWWRkRVArcFlLa3dhcmxMYU43endJcDZNVkYyZ0FKS2R2?= =?utf-8?B?WEpPNis3ZWRicWNRTU4wWHo4WjR2U0J6UTVhQlMyK01xd2QyRDJROENSQ3Zm?= =?utf-8?B?eW9nU0p3cXFHcEIva05KZGFaRG41eEhmYkFIWnV2NmRrY3MyU0hWRUQyZ0Q4?= =?utf-8?B?cE01RDN3d2Y2STIvT3JXN25adWN3ZUZoVzJ0a1hlTW94cVg2U2tBNHhWYXRP?= =?utf-8?B?VHVVcFlSNzJDODdKSTdwbVBZOVZuSU0vMUNqdUdxSExxTE9VOVZaUW9UQ0pI?= =?utf-8?B?Y2hIbnR1Q0JLRFQrVHBveUZOZ1djck5lQjhrZ25xSTM5bitGMGFnTW14REhD?= =?utf-8?B?VHhiek1iSXQ5QnR2a2dmMnM3M0hzZk4zTk1aTlloR1ZHbkJjWWl4R1FvMHBp?= =?utf-8?B?aGl5MmpSZGcwWVNobTRob0R1N1BhSjBNQ1BSSzFKbnhzOHpvQ0VraUFkd2pS?= =?utf-8?B?NHVhNkdjOEVlU3hTNFE0ZHprMTYrRU1CakpDRStKZFRCdWI0SnBqTDVIUTdP?= =?utf-8?B?VDUyUW9JbFhZOXZTRXMzSVVwQ2lUQ1Naa0NuNFhUQTZrVlZ2MzVQMklyOWxM?= =?utf-8?B?REFEQ1VrcXBQdU5keWxRRWV5Y25mRUpHd3FpcHUxNC9zUnNqam5mdkRuamRm?= =?utf-8?B?L1M4NTV0Mjh3TjdZTEluUjVaUHdndXpoNFR1MnM0aWxpT0hqVzVLaThyMWFW?= =?utf-8?B?b0RuTUhpVjI0WVpXRFk1K2ozejdDN3l2TlNXUmFpb2dhRi93UFZ1VmlUdmhQ?= =?utf-8?B?Y1cwUGxVSm5uc0xyR2tOM3pyTHZOOXkzZ3NLT09WMmltVjdaS1JjdHcrNmdX?= =?utf-8?B?NGxDL0s5cWJCRzArMWZXeVpKZVN3YjcwMEN0R3A4U1dtSXBIZStab2NOYUFC?= =?utf-8?B?eGtxdTZsTVlMSnByVlJ2WHl5Q0ppbnowSGQydUlVT3dlS1dCWVUyN1hISFNJ?= =?utf-8?B?djNHT1h1REhsUW52R3p3RzJkbHRhVU9rQUtRdmtUbXhudy9RejdZaS85anJt?= =?utf-8?B?YUdjdytqSnZHSDhCVG1YbW13dVVyRE1oU1Z3cjl3bStrUkttZ0srQmRNWitu?= =?utf-8?B?a0hUV0o4Rkwxb1JPUmIzYkpDbXBFNGxqTzhBMUxYWGVOQTNQUUVBRGFMbExU?= =?utf-8?B?L3JRNFM0MWFtK1hhUWUxSVdJRU54ZVNwZC9JeGg4MkVmMUM3U3NsMmVPZFI4?= =?utf-8?B?U2JMaERVKzFSdkJZeGRFOEc4VThBbGxQcElrY0ptaVF1ck5tNXl1RGZYdytq?= =?utf-8?B?NjhkU1RwSFJMWUVGUFJIUnZPV3NDb0x6MDBWbXlId05PS0dtaUtCZTNwUzFV?= =?utf-8?B?TkkzTThXMkpNQk9XcmpMc2c2a0Ntakprbm9KVWVhbldITlAxSDFsbnlQak9F?= =?utf-8?B?dFRmeitNSFk4d0o2OVdyUmZYa1p1aGR6QU1KU1lXMHVNcXRoTjhyamxFaHMz?= =?utf-8?B?QnZZWWhqYUQ2NDRZNmcxTU5tOHJGRzJsM25LZWwyN3JuUHUrY1VNWVBJY2cr?= =?utf-8?B?WnIwS29YWlAxcXRQS1Q1NjErZFlMampCL0doc0hrcG9jRzR2OWdTYklVNG11?= =?utf-8?B?NTF6NGI2MjF5OXJCeW1tRi9Oc0NoWlRPNWxXbFVvaUp0RUJyWmREZ25vb2Nx?= =?utf-8?B?UWR4QlhkNzNxaGdSM1RuMWdlc0lRdThqYW0wM2JRMk5iUmQycW9JNFJoeE9y?= =?utf-8?B?dnIweGhlbmU3VC96NmUyWHQ2ZlUwMFFBbGJEUmxuNzQyb25vcjRwZlR4Tmd2?= =?utf-8?B?VDAyY2dTbzlKOURoQWYrQTBnU2xpRnY1KzhrTE53dzFPdm9KWWMycUhIWTBs?= =?utf-8?B?U0lNSVp1dHlBbzFnTVRGVnhZNHVZeFBWTWgxR0ZxZmFVU05OWTFqaE1vWDRh?= =?utf-8?B?U0ZFdTBzQkNsWThSeWlYanVsdkRIUDdkd09RU3pXdEtyd2lDWmZIRDhucmZM?= =?utf-8?B?Zk91VThDMUF1ZTBIUWU2MTVNWnN2akFZQ0YweUV2TE84TkRiREo2YldlT3Mv?= =?utf-8?B?bWxIT09lcURIZWdTbHpBR3hrS3dmNmZIUjlORXhFNm9jeG5lZVRaOXhNb2NV?= =?utf-8?B?K1dRNHlYYisxODhCclMxV2NWOUlTaS9PcjlwM0hTaUw4akJlWDF1OXYxem9C?= =?utf-8?B?cVJxc0F2UkFVTVBFejV6TGZVRzYzWmhGeDlQdHM5YjQwSlVieUdlYUIrVFNJ?= =?utf-8?B?K1pSeUhYVGVTajkvSzQ3RDVpSFEzZGs1NThTTDByMmVlNTlDdHVBR3RlWGhL?= =?utf-8?Q?P6qt6CyKMkp6gLXE=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c849be3f-ec43-417b-11f1-08dec13fb04f X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5858.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 07:14:01.9477 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IjZbwdZhH6tXCMN9BstBAp90v5ilLj9aD9aZ//3SITrdEComh5cHvHToqyIwJeAdHv1TW94chp9YW+r6BNeB2t8+UvYFJ7fXFw3vLjpR3Uk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11406 Content-Type: text/plain; charset="utf-8" From: Ciprian Marian Costea Enable FlexCAN controller instances (can0 and can1) and the required RCU irqsteer interrupt controller on S32N79-RDB board. Signed-off-by: Ciprian Marian Costea Tested-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/freescale/s32n79-rdb.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/s32n79-rdb.dts b/arch/arm64/boot= /dts/freescale/s32n79-rdb.dts index 1feccd61258e..65a595d7535f 100644 --- a/arch/arm64/boot/dts/freescale/s32n79-rdb.dts +++ b/arch/arm64/boot/dts/freescale/s32n79-rdb.dts @@ -43,10 +43,22 @@ memory@80000000 { }; }; =20 +&can0 { + status =3D "okay"; +}; + +&can1 { + status =3D "okay"; +}; + &irqsteer_coss { status =3D "okay"; }; =20 +&irqsteer_rcu { + status =3D "okay"; +}; + &uart0 { status =3D "okay"; }; --=20 2.43.0