From nobody Mon Jun 8 07:24:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C33544E05B for ; Wed, 3 Jun 2026 10:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780481688; cv=none; b=c31P5XBl7XrGyaKDZRzkYtI8xyzKs9NrukyId52hWYmax/BJrYEP9VYpulgmdKrFKbwotZWHN28G+p7wG6i3aDTFBfBE58BwcxCqd/1DSOYwa+MtvfW30Ahq9RO20CrUeA0Smq2rEJysLsyiy+oZIcIizYyx0unpM/qRpJQ8HnY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780481688; c=relaxed/simple; bh=ZmzlMq5l8xv2ijHU4ddQbj2AgHT+1ygitV4sixDeFQk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LLs36MqE01JTnHFTrSYmvTllrEF1vbTE4UqztCw0Uoi9Hpz4tGUlK6OjRqLNno0ulCxoPFBVdSjyxhl3rGJjaxH3dpXd2rop4eGW1ZrKyHqyyfDCYKudWXaQOQjP7P+Lg1Awmi+eTX6RArKRcRxhzkFDk1/yiwd/Wfdwc5245Us= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XWfzMXDL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iuTj/YOr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XWfzMXDL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iuTj/YOr" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6536RKb93077837 for ; Wed, 3 Jun 2026 10:14:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1MbKYOxYNhOubmMTGU6IUo9PxYH2oVk8G/hA/fqgBHE=; b=XWfzMXDL5IRfHEG6 GkzILN1/Q0prLEW/596xuUU35At52iSt82ceomQzGsDcxZZ/7oHvbyChWrut7Fuv yiVNi3puosxg2Crq19h6FIiUTz5KBrGNdZTHigNJlqQzPeP65bpq+e0PbGrFuyKM iD1LGjkyCBFzLA+7iRzVFh4Ny3Iypop08+VG9BgzSk5tYFq0Ob+VnAEUd977ItKD ewDYPse1jI2T7LCB/e74WfxA8akYNA+xWHUx1k1o+rZQH+XibHgQxgjf6Ww092n2 VuPlpIm8aEikZjlnjekR3DJNlcixFX0/9QhDjC5ZVZ8lulbuAAVoo1iWX9lTMDPe IxMPsQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejabbsy7f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 10:14:46 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8423970cb30so2566249b3a.2 for ; Wed, 03 Jun 2026 03:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780481686; x=1781086486; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1MbKYOxYNhOubmMTGU6IUo9PxYH2oVk8G/hA/fqgBHE=; b=iuTj/YOr21QckrBd7R3TUOIO5FwLwW7WX4Nh/QztTuSGJqXtK1Qq1HhFOnfx8WCGda b22cLh/G4Mux81d4xI3yeJm4icvgoUkEPdcKnlyQRYM6zaWidNGHSOX1SWSqvEIO7DLN 53vdybgSWssvW98zDO7K2HyTatHq49scXDalUIzEBsHaqSq9Q3bmoRBFiYlAMMvCKQQO ycIcIQncvd5frqtvsfGm06Tn63uJAGo7tlsHmFmA0cGXXjcBpPi0IcXi7NWRHfa+v4V1 hCh+piTeYDGpBJz3UwqW6frE7OKrN1YguIrUwVD1tJWnQaiwA5PoB+QwN6wldhzXDYoq ZbZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780481686; x=1781086486; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1MbKYOxYNhOubmMTGU6IUo9PxYH2oVk8G/hA/fqgBHE=; b=rMnEzCMN90wAJnZvmiUjmPQttP4a8WWdnEsVee2pugiRC5V38FJ+x8WRPP4Sddkp33 97hEQM3uUcwCStjaiL6CDLKOJkChgaJF7qA5eaVlVVE/c2aedKwyXtOWd83FniPQTsLS nvAZi+qZHSSXjDa16LjaO2Q2w7XUkxENpVG2iQXc9TDawW0KZ6QpjDBc2a+LIEfo4QrR m45BFhhGSs9/WYmojIY2u5Cu+LxozrZSbdEjvG7SxTp5Wv/TBxl34wonX9vzhrS+UY93 IRw8FPQRQX5uYQk5vRaVXPA5VW9ad4Sa+gTlDOFRQ5LLAeWKZEYdkgDP3Co5I2NhT2hC qC/g== X-Forwarded-Encrypted: i=1; AFNElJ9rbSHEYHOAWGiB/82TSiOHA/jgpNiQ/YI6gAiWFRUP3K6KkXwqj7cfrb538YWS8/ti9sa/G83GXcEbh+s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2osCTwYiLPAfTULL8l4MsyfVFWzCceEi3U+rwl8TV4ovorJZU 1/XgHvKQLrSaboTVaKuadItCjYnbXtjFOwL8YkPjbJ+0nGK2s2cgrE/KxUKrQ5x/uxlq683JgHx RlzzhORf9BGBztY8UFsj3WPrsGHAgjlfbK8syfN+382YskrzUGTfliVS2i/nKoh8SGTI= X-Gm-Gg: Acq92OFrK1AEyvsMvCXeAsX1zghdZzWUQl2UvT1+vr469bz04M/GlD8gJI++r4IYGKJ pf7dghT/+VtbJR6J2/elIcG0CMtCsdb/ZUHy6awC5acxIa/JegVOBPtbZ22rP+eayyRPQuQ2+dm RcGmr40GABUGSFbZvQJIoKPtTkGSyrGGg1CyNechrzysr3xC5NaTDAbT7bhhgTxN671iiBgS+Wi SMwOVIYb92eTU29ab9FzKpU65oa5QCvZ+TwXSuF25DOJgvSuUFBig1grsgn4VGRQOXRb+8aL+GH +E00XqoiQEEdPz1R0ka++yXpFqU3q1l2KjVPlUvYn2Z/s7eObJNc8baNsOBYnR9aAPtBnPXW0xP zUP4AQ+8ssbtKhRgolgk0pKXDXF1JSSy5i+yzu2ueN4jhvYG2SoZpj28kviM= X-Received: by 2002:a05:6a00:9094:b0:842:6fec:1296 with SMTP id d2e1a72fcca58-84284df0098mr3089134b3a.4.1780481685945; Wed, 03 Jun 2026 03:14:45 -0700 (PDT) X-Received: by 2002:a05:6a00:9094:b0:842:6fec:1296 with SMTP id d2e1a72fcca58-84284df0098mr3089109b3a.4.1780481685472; Wed, 03 Jun 2026 03:14:45 -0700 (PDT) Received: from CHUNKAID2.ap.qualcomm.com ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828e02f9sm2463747b3a.48.2026.06.03.03.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 03:14:45 -0700 (PDT) From: Chunkai Deng Date: Wed, 03 Jun 2026 18:14:28 +0800 Subject: [PATCH 1/3] rpmsg: glink: smem: Use device name as IRQ name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260603-rpmsg-improvements-v1-1-dcfc22ed69f7@oss.qualcomm.com> References: <20260603-rpmsg-improvements-v1-0-dcfc22ed69f7@oss.qualcomm.com> In-Reply-To: <20260603-rpmsg-improvements-v1-0-dcfc22ed69f7@oss.qualcomm.com> To: Bjorn Andersson , Mathieu Poirier Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Chunkai Deng X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780481679; l=1293; i=chunkai.deng@oss.qualcomm.com; s=20260512; h=from:subject:message-id; bh=ZmzlMq5l8xv2ijHU4ddQbj2AgHT+1ygitV4sixDeFQk=; b=uODXbFl41lOh88Hpx+APw1QDYwaKlhfh0Zxa8Zu0thp6bpBSwbTNh+yBhAa4VTVKYxTtIA/w6 KDrirX4yQsLCSa/3A6hTTvo+6kc0BU6AlQLCKqeQPWK0iQDRjnC9ljA X-Developer-Key: i=chunkai.deng@oss.qualcomm.com; a=ed25519; pk=NfifEElkZxgJ0ghUBxNu1RTaEqtoCGYDb0k5UzIRXOY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDA5NyBTYWx0ZWRfXw6pzNJ4eqeYT fNjYsLdS6LiFz7PV7f1ACqeILGfAv9u6DQcSedaA9G4zgJBdgmzIAV7ALc+1fQuQWRP/jnwL4+R 8mDxu9HCDtg7GVTKTTgH0X3pHrszDFEujhChiCsoHRfOmW4m9MlivX05+pxeQ3xqlG/ylhSLPLn NGjaIBzGtA6CgKLn48LEZMcP67nI77q0b8iPBJlgDtokcLhf+gJfn9gOUF6hbCGX8fdJEH7jkZz fUP+t/4H29TBgv2hup1utvwF2dDJ/dE2M5Xb3sZXn1CLalN34hp6JxQPA4zAfaeoL7MmkOBEYs6 sZ4QL/hIFx6sS+TGchuIFbM6P5172V1s0LpbtpQgSYCW5oueb6pfS75mZJ9eFqH3TOOsG1IUD9m zVyuYBZjIuTRCAhX4K5+riNWtDYd5uKQWpOIk/+4h34RM+H4rOlwQGh2NhN58jEOeQi98B0CCji jRCuSalRjpNzb5wF3VA== X-Authority-Analysis: v=2.4 cv=UqZT8ewB c=1 sm=1 tr=0 ts=6a1ffe96 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=Nqvb9vKcIXZEg_ORUGMA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: QhFWGOy0l6BlecRxbpqaCGdjMD3XJU0e X-Proofpoint-GUID: QhFWGOy0l6BlecRxbpqaCGdjMD3XJU0e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030097 A SoC typically has multiple remoteprocs (ADSP, MPSS, CDSP, etc.), each registering its own SMEM GLINK instance. With the static name "glink-smem" all instances appear identically in /proc/interrupts, making it impossible to associate an IRQ with a specific remote processor. Pass dev_name(&smem->dev) to devm_request_irq() instead. The device name is already set to ":" which uniquely identifies each instance without requiring an additional field in the driver struct. Signed-off-by: Chunkai Deng Reviewed-by: Dmitry Baryshkov --- drivers/rpmsg/qcom_glink_smem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_sme= m.c index 62adc4db2317..edab912557ac 100644 --- a/drivers/rpmsg/qcom_glink_smem.c +++ b/drivers/rpmsg/qcom_glink_smem.c @@ -307,7 +307,7 @@ struct qcom_glink_smem *qcom_glink_smem_register(struct= device *parent, smem->irq =3D of_irq_get(smem->dev.of_node, 0); ret =3D devm_request_irq(&smem->dev, smem->irq, qcom_glink_smem_intr, IRQF_NO_SUSPEND | IRQF_NO_AUTOEN, - "glink-smem", smem); + dev_name(&smem->dev), smem); if (ret) { dev_err(&smem->dev, "failed to request IRQ\n"); goto err_put_dev; --=20 2.34.1 From nobody Mon Jun 8 07:24:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 463AD453486 for ; Wed, 3 Jun 2026 10:14:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780481691; cv=none; b=qcLDIAe31yNTsaJifz8YjRpr0HrHQXKrKJrgEABcys8B45ZRR45L0VqfECZcwjB5jAT4JtN3wGNvqMjFxqph/ag7OdIPxynLaJ/g3hDorxV4byrqQxSlTr3X6q8i80Ae+ms0+3U1ldmQ4tB1YdgVO/D//XrgE78HpeNs3hmxeF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780481691; c=relaxed/simple; bh=xryvc3WEeX6Eg2MpUAaAvXQdss2b3pJzRlW6dcfR2XM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SsOOMO8NBZqzvHs8y8cLZL15bX3B47u76EZ0SN6DHh41HmcnOa6mcKKEHAIKmhHgoX70xATqv0KN0hyMfW/9+FivfPPQWnWsLnxkamTMUc9AUsc+7S4sCOcr2k30Hy//+oCK2JUd5Q8yWQI0xwjIhNp4G+T0j1jfX+g3s8ksjXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iMpnQS5D; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MZZoQxkf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iMpnQS5D"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MZZoQxkf" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6536RSuU3077996 for ; Wed, 3 Jun 2026 10:14:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +8UO4LKBr0BalaekeUgLna7aJRBnbkSc89WeUtzQIK0=; b=iMpnQS5DgUZjEs2D Qgu9qR7UF2Fet8Wx3iS7N+ZwF2u6viHKrCKoOJ9mLvJAQ/RNHsma3t507XLh/itQ cCAYaw+mNFdVnSZLBvHNk1jBdDneBXKf9Yu3NmjZcL5RraHaDauaMTSYi9QNhhIv ifXSPv9oY+LWjBsoyQL36x8+0xGt9Rm4i8RphoVaVnFUFq6n6+uh5LKV7dyVDgNV sprZHNOFk/O6F/AyB/LoagTfhBOjd1Z+fa99WfeKqpNtGsfTZxBRNxtfdgGnHMn4 kqqnkYd2W2eirzMbttwhp85H3J2UKdAcXrpPV60xHFXIuhndttKz7JAegzPb0AJm tORYdw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejabbsy7q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 10:14:49 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8421f5d76aaso3143078b3a.2 for ; Wed, 03 Jun 2026 03:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780481689; x=1781086489; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+8UO4LKBr0BalaekeUgLna7aJRBnbkSc89WeUtzQIK0=; b=MZZoQxkffj9yO4isAIS6XvrMDS22zvD64YU4bFLmDcetS8eu9oREmkYhVwj+QPKu8Q M8aryS+8Tx7hNsK6BIMmmdREtiyrQn3i5NFoXtZb1jkBVhYOTunPIP5ErOJ+nWXcL24+ LKieJoyN1k6RvbEFQLqD3NAt0PmjD6eyzT7kHuhajtZBAIjXb+KT94bmYOLhwfcGYa+B oLC6g4KJ4OmoFRp0rHszBIwV4P4IQMADLZ5BDETfo8zNCNecJ+aNqXIgBOX4KBSXduZ7 LSYZ5Jedy+lqDE4jBtHu46e8aFmheGnqYVOnyuu/4We0P8Fy9WC21Lxylxe8RV9ZEvtE aMMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780481689; x=1781086489; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+8UO4LKBr0BalaekeUgLna7aJRBnbkSc89WeUtzQIK0=; b=qCm+oxpi/2mphIvZrtiC5xobq6xxvNna3r93mbz5RJhbiyEffjeHAiEr/xu3qKeTYb 5+t30tVlxV59PnmywWGM/uceDNgYXch9zRBUeJyFAw9UqMg3YN0boVc0cZfB2rzehlCp /xahmvy2titWwZuYIaij0pKQz9RXiv/BTbRcc7NcarluFSM4BZzAq5Af9FxvQsTabs1Q ndeF4Bx1CRubsQXEBMmA/wwCwM5J+HFh+vXg/VAsD5vT3bFymqryNyNsDEDIdkDi5eCR hycYzEoUMu0IntLhdkHUvar4QHQAbI0SIZLu1xUui5aszzu4P9H5dElwA9SjxxPwnxYg f6EQ== X-Forwarded-Encrypted: i=1; AFNElJ8LCgAj1PtoHf6yX45V46iUVlEvGgIoGjh55XbhxHZEPWEckh0pcjmyX0NkBqQY6oK2FUhomrFhbYY/Iqg=@vger.kernel.org X-Gm-Message-State: AOJu0YzeSmGE8gBc/pWZyujmMGmTqsf28XiNa07KuNIZONsx7QlyxRWI 2k7DIZ+D7uC7pJTw4a1e2zLte/wJKqe+/3KjZYfXqLERmyGDcG/a8oo39InydHn0JW0wP22lRHM 7mkl2PJgB6VHFHKy+8SmtndLDjjBL+yeqaGyenRQJ1myZAjpric9mJZrBUl2+zSQvtxfEsFzApg A= X-Gm-Gg: Acq92OFUD0enEaIpyqGpGiOxMAezMYK2z3O1ir2rB26bE5b4sWooNuvhzhu1TknRP4Y YqXdn+iMw3h/LPBYGrOWN/GUaBXdwYMrPWWeSqsnIV7ywDCgapd8W2GROD7uMj4zkrsnWW/et8J hG3deuejVI7HLOBavnsHlkcIWXuTpdctMuee2OsS0GDQevsHbpgceHOVjGcL/26AtCC4feJB5Na wD9rKrfjbBaAcvpl8PVfiwhQrjORlPnq19wXiUEa2MOqNS/ylBnSn9NuUamT14IPLQVrh0KQ2aq R/OvQfzDuVZnbKC2/0TF9YffXnhM6GQ3GAAIcnyM8lYLs2CvSZgUP/4E3fEcMYG9L47V425FVwg E+SIk8eL/jBx9wpSuhyI9tI5ba/V5AJ/5XSY5VmjWR7NspdmrKy0c27q1+f8= X-Received: by 2002:a05:6a00:c90:b0:83f:2568:d45f with SMTP id d2e1a72fcca58-84284f5f588mr2733732b3a.23.1780481689012; Wed, 03 Jun 2026 03:14:49 -0700 (PDT) X-Received: by 2002:a05:6a00:c90:b0:83f:2568:d45f with SMTP id d2e1a72fcca58-84284f5f588mr2733703b3a.23.1780481688493; Wed, 03 Jun 2026 03:14:48 -0700 (PDT) Received: from CHUNKAID2.ap.qualcomm.com ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828e02f9sm2463747b3a.48.2026.06.03.03.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 03:14:48 -0700 (PDT) From: Chunkai Deng Date: Wed, 03 Jun 2026 18:14:29 +0800 Subject: [PATCH 2/3] rpmsg: glink: smem: Add WARN_ON_ONCE for FIFO index invariants Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260603-rpmsg-improvements-v1-2-dcfc22ed69f7@oss.qualcomm.com> References: <20260603-rpmsg-improvements-v1-0-dcfc22ed69f7@oss.qualcomm.com> In-Reply-To: <20260603-rpmsg-improvements-v1-0-dcfc22ed69f7@oss.qualcomm.com> To: Bjorn Andersson , Mathieu Poirier Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Chunkai Deng X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780481679; l=2183; i=chunkai.deng@oss.qualcomm.com; s=20260512; h=from:subject:message-id; bh=xryvc3WEeX6Eg2MpUAaAvXQdss2b3pJzRlW6dcfR2XM=; b=W7rrhdR9oZq9h/xeDM4l2ttYCLekP4r8zRmTb3sRZ/mfXd4ngOI4iO9OkHkxPf/p+rkR2SjVn 02lc2TjGcE1D/VPblg/3GjpaHaLnOLH2k7yM4w7TbSYwiMofUxiDXGW X-Developer-Key: i=chunkai.deng@oss.qualcomm.com; a=ed25519; pk=NfifEElkZxgJ0ghUBxNu1RTaEqtoCGYDb0k5UzIRXOY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDA5NyBTYWx0ZWRfXw/Bm61WyrthH UX2fPz4nlYyVQjeetKUCxG+hprHQBpqyr59eRRy8ugdLpq9NgQaGCBmHPZlkYMWla+8612Jk/zu ob6cfWvSnGJPG5w6s4uGCR8BiE3aliv5xFVRY31u/+36xQquDtWQqSSELPc6Z1aD/l44V9cM6FV pe79fX1A/R9lpi3IUdoZwyEvs+fbkcmMmihQkMemzAe5mB608/ByXk0EcPFG97L/rhSuaih+7vL dr7J76w+ZngxlWGIpM4odUizeGRJUz362Fz7XplrkH9Vh6c64jooOzT89S8xFDkgR5A1rxI6nD/ WDzJ/Dljlr5wvMmIcwtdTqEhgAp382tD+kRufs8mkkiCJBkNlHDF6xmSUfabY9XEydeHRev1NdM D9L+h6yWQR+xKB5UIkHnBcxHkIZseDe8mwgD6DMm9qJ4rJ95SVD1zKKN9YgsQJ9mk00gwcJa8oV AL75UmMzPEjF3vUolzQ== X-Authority-Analysis: v=2.4 cv=UqZT8ewB c=1 sm=1 tr=0 ts=6a1ffe99 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=SdC2vBNBQt3qShdCGKMA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: LOUX9-mhRkZPqwwb8s64P71ksPxGTW41 X-Proofpoint-GUID: LOUX9-mhRkZPqwwb8s64P71ksPxGTW41 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030097 The FIFO read/write helpers assume the head and tail indices stay within [0, pipe->native.length) and use them directly as offsets into the mapped FIFO region. If that invariant is ever broken, the subsequent memcpy or memcpy_fromio would access memory outside the FIFO. Add WARN_ON_ONCE checks in these helpers so a broken invariant is caught and reported once, and the out-of-bounds access is skipped, instead of proceeding silently. Signed-off-by: Chunkai Deng --- drivers/rpmsg/qcom_glink_smem.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_sme= m.c index edab912557ac..42ad315d7910 100644 --- a/drivers/rpmsg/qcom_glink_smem.c +++ b/drivers/rpmsg/qcom_glink_smem.c @@ -86,9 +86,14 @@ static size_t glink_smem_rx_avail(struct qcom_glink_pipe= *np) tail =3D le32_to_cpu(*pipe->tail); =20 if (head < tail) - return pipe->native.length - tail + head; + len =3D pipe->native.length - tail + head; else - return head - tail; + len =3D head - tail; + + if (WARN_ON_ONCE(len > pipe->native.length)) + len =3D 0; + + return len; } =20 static void glink_smem_rx_peek(struct qcom_glink_pipe *np, @@ -103,6 +108,9 @@ static void glink_smem_rx_peek(struct qcom_glink_pipe *= np, if (tail >=3D pipe->native.length) tail -=3D pipe->native.length; =20 + if (WARN_ON_ONCE(tail >=3D pipe->native.length)) + return; + len =3D min_t(size_t, count, pipe->native.length - tail); if (len) memcpy_fromio(data, pipe->fifo + tail, len); @@ -141,6 +149,9 @@ static size_t glink_smem_tx_avail(struct qcom_glink_pip= e *np) else avail =3D tail - head; =20 + if (WARN_ON_ONCE(avail > pipe->native.length)) + avail =3D 0; + if (avail < (FIFO_FULL_RESERVE + TX_BLOCKED_CMD_RESERVE)) avail =3D 0; else @@ -155,6 +166,9 @@ static unsigned int glink_smem_tx_write_one(struct glin= k_smem_pipe *pipe, { size_t len; =20 + if (WARN_ON_ONCE(head >=3D pipe->native.length)) + return head; + len =3D min_t(size_t, count, pipe->native.length - head); if (len) memcpy(pipe->fifo + head, data, len); --=20 2.34.1 From nobody Mon Jun 8 07:24:00 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E01744E04C for ; Wed, 3 Jun 2026 10:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780481694; cv=none; b=Zy5YiADIDoJPc3mslm/D0ieUjGGL9l54QYF/VdxMeDOYWyLprld+rOVwLAyzT7zLnxPRXmS/ZevaU6qLBO09Y8t8O0vkivDEc+W75L2aFOmIX76/uz+zk68XO2XootGBfExq63SRQPmJO4bBmaEXwncx9FpbR66luYHJ2YZNPoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780481694; c=relaxed/simple; bh=OU4D6VlRdhjfTz2yiRjWGJXP0ElAyKuAC2J0p8/GCyk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EiflZEu1t3aF/D7nygrhxx4aoWKlmFbL/8sQmrZ6nsuoHdTcvJZyt3K5gKSswDULz6SfNNUqSPczxSy6Nz4c7pEA8EstUPdAlFMBl9Q0GzyGNAGIjQQTGlDSIgNteaepe+oO+cD9RHJlzuwKA9xB+ubVNSR8dqxveshitbYJd3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KTiAZyRf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kSfqtsAj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KTiAZyRf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kSfqtsAj" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6536RMe83077899 for ; Wed, 3 Jun 2026 10:14:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J8jbjEtYmXkjBNahyGDfrzMdPepXxsuU6kZsy0YicpI=; b=KTiAZyRfpUnB++l9 LzgLfI/6TSw03aQNyl6h6MaKHkXOMsLzcvqfSFAbInMYFeVR5DHLyf6bXEGPvUqX pQyKYZzHGqI83N3arPTn2ZgR4Vi46fWGQEStRmThnv/ziDdK8MxdPzD5lbNri082 jiRevfSW5UnD6giXj4K/BEtppK/hgLHM4fQ0tQw6K9SueHpw8I+i0NCMMUm/A3pA SuYs1VSPUlShr0au+HbPSW+hX7dY4rxVBCvrHrBmwxAXx84eQT5ojc8ILjLkTIdF zgEcFLlZA8oEpN5oiwnQ9LvbAF4551r6s0o6D/dJC2bAoUwWpNOjE8yuaXCIdD1j TH+QYQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejabbsy83-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 10:14:52 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84245e2bb00so3052137b3a.1 for ; Wed, 03 Jun 2026 03:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780481692; x=1781086492; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J8jbjEtYmXkjBNahyGDfrzMdPepXxsuU6kZsy0YicpI=; b=kSfqtsAj2h1p93BYwYqsivMnNflA95gwKGMnL90NA7hQqT/f+CZ7WZCpKgyVTTWiRQ vk2lz9ELnJsZx0RQ1e/2ogQXZCFigEfXVNBNtkxXQUWhl6ljbanCLwm4YuZnAj/S6aAi hOGS/8rA4yroaLQoAZ4cgsggXKgCrOFDJEJUJZvBR3Fsyg0t/vsW2qzuz3FP1oOn59XC /rwrBbVQ343aQH+e/qJwFchicvY/7c9CFMXpx66JCzD4GMRWVpxhfmvf6n3e9uaCk7c7 gH7Vl/khHyN+bRHB6oVPLJAhjnaKz7C7r0OFRVtytXxR/uJw6/XSvf9PrJisjny3ThQb feLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780481692; x=1781086492; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J8jbjEtYmXkjBNahyGDfrzMdPepXxsuU6kZsy0YicpI=; b=L1lGh+Qxw8Z6lD2o+l8BCTxsfGtXabtM1LfNxRlWJYm/EpwUWevy5DBoR6e+wmKCvz RUJt78cl/yt40vAh9b5X2GfWGUIAhSSb1gNu1hlVou0c3mJmZ96PY3uuUfgAZP0sk233 PmF9Kb7ZE8ayid2aEXu1o2FEh6Ay+jT2XLBibkv/4lMEzlDPH6e0zhd36RPvUdOIz8eO 3ryQ8z2fi/AyzL+Uk5ygQeaazMSdijY8zs9T9lUq34fEHhp8Xx0ZuafCBDdWOGCI4610 8VvejBoKKibWAREduPHpettHe3n2R5gSXY4ZUkGJwLRTKYfGZfXy7zirpgjFGwA9tKz0 Lbgw== X-Forwarded-Encrypted: i=1; AFNElJ+UP+HNykqxVrHpjopHbdZUq9eu3LUtqFCNnHLrOeXXEimSoXM2mefjSDbZFvCqTKZrAFVJrbkMDB9bIBI=@vger.kernel.org X-Gm-Message-State: AOJu0YxGTk99+Erx1bVYxjq+JmxSBTJNI/mkQcn4vBhStfFHNkEbycdk VGaaeI+FUUh+LUCfVDe2bkiJPox29csDGOj4u/eZm0OqyMqyuA3UsjM/8hAHWA89usSrhQctj3F lVnE+f0NgbqLOjrHiBbMB1RljjCaQraEDAwNW6YVkQ7SDA1DjQlgh46o2dQpvlSg60aw= X-Gm-Gg: Acq92OHymJbKh6GeJ7iF14qkvY7kRlF3z7tZBNwKQ8P91gtCFoPuHAnFiGy13Aph1a8 lXcJWYRj8+oTq/hbBHc63x9MQgV3MoktSVnSZUmBXhfdjhpJUv81k0Y+t8/My2JPnQX72qR7UvN bnVM2pSYq7b4sZibQz/H0bWFHgc9++eZfDlv8ET5gBHrPA8BxxE0YJ+FMrvwT27/xy9jK2XNMOb ZWCtPzqwGKyzoPlLHxo6l/95h847ss/ry/IyFo58wJ3efeM6yNcINp6iCP/+RM1i4iXsdd6+iwB lshtMiyElqAttR90yOB/UZAZf80y+wRKkNmHAJNqtntT4egpW1lxs1Jka8RiIINqxzOb0Vz+ROC dmik6yJJMIN6M4X5gaysQHAc5cIjq3vyDs5OzH9UvwUhaXwhtszssHG8KLKQ= X-Received: by 2002:a05:6a00:1c89:b0:842:2efa:5fac with SMTP id d2e1a72fcca58-84284a85991mr2725750b3a.0.1780481692212; Wed, 03 Jun 2026 03:14:52 -0700 (PDT) X-Received: by 2002:a05:6a00:1c89:b0:842:2efa:5fac with SMTP id d2e1a72fcca58-84284a85991mr2725720b3a.0.1780481691743; Wed, 03 Jun 2026 03:14:51 -0700 (PDT) Received: from CHUNKAID2.ap.qualcomm.com ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828e02f9sm2463747b3a.48.2026.06.03.03.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 03:14:51 -0700 (PDT) From: Chunkai Deng Date: Wed, 03 Jun 2026 18:14:30 +0800 Subject: [PATCH 3/3] rpmsg: glink: smem: Use modulo for FIFO tail wrap-around in rx_advance Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260603-rpmsg-improvements-v1-3-dcfc22ed69f7@oss.qualcomm.com> References: <20260603-rpmsg-improvements-v1-0-dcfc22ed69f7@oss.qualcomm.com> In-Reply-To: <20260603-rpmsg-improvements-v1-0-dcfc22ed69f7@oss.qualcomm.com> To: Bjorn Andersson , Mathieu Poirier Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Chunkai Deng X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780481679; l=1194; i=chunkai.deng@oss.qualcomm.com; s=20260512; h=from:subject:message-id; bh=OU4D6VlRdhjfTz2yiRjWGJXP0ElAyKuAC2J0p8/GCyk=; b=GZnF4XghOPx2VQtWAqPUnarVMZF5a546d0cWm5HkCXIVLFf3ziF1A23aEr6ddnS2hs/gW9Gyd PtjBoSpM/71CztWFiBDFNMN0p7ZUIuDhGkHqLqmq8PbC8nBjLmfG5Z1 X-Developer-Key: i=chunkai.deng@oss.qualcomm.com; a=ed25519; pk=NfifEElkZxgJ0ghUBxNu1RTaEqtoCGYDb0k5UzIRXOY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDA5NyBTYWx0ZWRfX1iuhjp8qMJD6 Mx9Ch4vXeMC26l6h0Il7sDwS8FvY+NggLUnEndP5Xhf6hZszloNY/LNjeF626k7jpTfqQf0kY4W fFnwYlEXXKc2VBZvNgwHL8rSbsfo+3yi0XF2Q24YuL3zJYXzzdW5vIkgG583Br4/YeYtZt37SKj 29bYHfFU9R27h9YwS7E5l1Yyb3YCAxKXLDFKFle24W4YTMxf5qoavjwp9r/nYyOuc0o9s2Z9Jk9 ZuukMkhpVRo+bh/9ZbF1e+RvofFJjMf3gzC1DEiCO2oO3F8GslNNt1Z71AYB1ZxuQ5IqT5r4lZJ zhpzbjERv/fvb7rmJPf2rHmhUDvMm35e839TT3TLayNAvyIAotW/K55wFubRnG3cY98J63w37X1 SDMrHbDYG/rFMHjlA1LodLDxFMjRUv0VrpWOztbEHAkpHAiSLf9uRZtI/r1hebun8jTzW5sx1sN BDqsfbw8BQYXSoOXDzg== X-Authority-Analysis: v=2.4 cv=UqZT8ewB c=1 sm=1 tr=0 ts=6a1ffe9c cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=r6yPUBAwCGnPY4Z8tCIA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: GgsLrZ9DNS_amWUtzHzFrDc_8uncG0_v X-Proofpoint-GUID: GgsLrZ9DNS_amWUtzHzFrDc_8uncG0_v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030097 glink_smem_rx_advance() wraps the tail index with a single subtraction, which only corrects for one full wrap. The advance count is derived from remote-supplied packet fields (up to sizeof(glink_msg) + 0xffff bytes); if such a count reaches or exceeds pipe->native.length, the tail remains outside [0, length) after the subtraction and the next FIFO access uses an out-of-bounds offset. Use modulo so the tail is always normalised back into [0, length), keeping it consistent with the index bounds enforced by the WARN_ON_ONCE checks added to the FIFO helpers. Signed-off-by: Chunkai Deng --- drivers/rpmsg/qcom_glink_smem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_sme= m.c index 42ad315d7910..4f143921b719 100644 --- a/drivers/rpmsg/qcom_glink_smem.c +++ b/drivers/rpmsg/qcom_glink_smem.c @@ -129,7 +129,7 @@ static void glink_smem_rx_advance(struct qcom_glink_pip= e *np, =20 tail +=3D count; if (tail >=3D pipe->native.length) - tail -=3D pipe->native.length; + tail %=3D pipe->native.length; =20 *pipe->tail =3D cpu_to_le32(tail); } --=20 2.34.1