From nobody Mon Jun 8 05:30:29 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BEA9395AED for ; Tue, 2 Jun 2026 19:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428371; cv=none; b=Sbxb92epUbnAMjTSlBY/qlHRbsR40Aso0wgnt4nfsAyUal3lp1BEsgAs9qlco5nILft+pbYCDJh1xUr3JKW0WRl1Yt2ncvsc0LJyeOxPpuw3MEvugO/skEY3D+X36SzhVW13ZfuNWj+ETtUylPdkl1BtiH6GgRKDf6oaZ+wecwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428371; c=relaxed/simple; bh=Rr8JzWohT1tJsTGXm2ibqCRdqbA1on/DZn4rk+VclDs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TGsi9FpGyzgPjTc+iHsKwwDyUWqWl//V7U4svr9poDcskm+5zHDiUh2md+nokFVOZ8ZoLBSPj3MGpiIhoyy5H6UGp2AW13/x/F7oaDwlmbTgWcExentqZJ9miPYWo4SJDsrT8LgXp4rlzB3Sra9XfR1YHAfQvBg/1bdzgxhimsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ld2Vlz3k; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ld2Vlz3k" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-490b1bbcf3aso10548735e9.1 for ; Tue, 02 Jun 2026 12:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780428369; x=1781033169; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gz9Gm1t+wb2XGdBfPNWvyntpJxCorkDCnuo7sD8+Tmc=; b=Ld2Vlz3kElhVFbe9t/6Bbc81i8nhWuwVt6NJGqBnRJITR98uaiikfHxJw4BTEqNp9A vxbETM2FcG3jzONh14FE8cRC8YgmqEtolIp76RQv5VLlsCjL5KsQuNiIbZfdY2WdkAn6 1Yo6zZ+Kli4XhkI1W2ixLVut07uVWwqx4zuEb09GPsW0jsv9N/9tNY3TxlNQwEEnGhOS 3XLgiNqypufgkdx3gFHZ5N9vp4x33hImUvmIzmrX73DU5fWNjPO3UOe9V0ahA1uibdtV Iz35smpoKktR4t4J2gTUx2Sd39Ng6hb1ivNtX1jrABYgppkueWyd6SKRD0Pd8ywxkYjR ojdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780428369; x=1781033169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gz9Gm1t+wb2XGdBfPNWvyntpJxCorkDCnuo7sD8+Tmc=; b=noG7hXA9RUrFwK5HvdfUOWK1TAOJfr/nPy/siuFqp3U/BBbpuAK8fxK+KlA78fyYy1 ipexUPEPlMd2uRVftMrbBSvLNcA1Kan7PvTnUkiTs5pxiipe1Um405AmTFFOAYUf9a8n L8qjVrY1zFQvpSQgy1ohRost6PL7J5wpTyRHe7rUpDGrFVQZGe3kwdx4Qegq30Kx4+fV mQ/DBHTQhEvR9UKSnAV49F4ZZYnUiGWZxtDDAfiVWpHyKIiZ9HFFEHPY73XA6E52x6md +e+PTlmohUeQuisrhob7T4ZdmH78+nT3xq7af1eckqrIN9Papf2F/A6g8UQT7jzqcnXp VDKw== X-Forwarded-Encrypted: i=1; AFNElJ+EuaF4HWr1z49Dq40ny9QHCPkeuCRXyQ+0a1yryU+fBwUc8iRpyD73oIHD01KDKYOXPaX3XXVSdiqRRio=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3Fc9IdZ7QV+7AjseP4xT++fRtrz1Lz/PoXlC3AaTQ9Tz+zXCI YzicRx1jBWK5FEUaFl5fO2DKWtBemYHBA2hiE3zJstE6h47dMW3XrPFg X-Gm-Gg: Acq92OEYOhtGHO+nFJKMJ/ObhTzSBX9WKMGZAy9hhD+31yA0RUkwVd2IWERnkpiOYZk K45skYj2/eho6LmboG6nZMFMqmpuHMBaCIWygnClC1oJrKLQ/PtsxPmcdebbQoA7J9F7gEXOEP7 j9jg4TzInP5HrN6NYabvDleW+xxz+YGzsd0M1OBpkxIEkfNt5K9yFW+dgO89GxVzGYi9wXKlIe5 0H9SnUmOO4us7A0kSA5QSQ4ay3CE2HtjpHwOydquUUvHiWxZeeyYUTu5umziDd2WfzMsb5sIwXB vHJocQiahS/S6XrmtSWHo+MlqbHJOl+O1S+ObutZQsEyy2ClqmN7ewBSA3oV8+5Xz8cGH8ayZ3G hdWGRJu39OctQSuUejbuDYQ1e7Qso7FwiFtdgiejkyxYQk8jjg382YP9Qi3Zg/pJw1QOVKbNs+H XTPOebzhuRUZJWnAFaSswn+WiTdbvV/Ky/ZB1jLNdtk0Tuj/ev/zWxbK865hUvg81nq/EYy3fGI AL0Oc/yzp4IYd02EsfXAr29OBEK9qe/mUiNJGtQ211s0c1oKY3vGic+ X-Received: by 2002:a05:600c:8a0c:10b0:490:9d5c:a3e0 with SMTP id 5b1f17b1804b1-490b5e8982bmr2280875e9.9.1780428368805; Tue, 02 Jun 2026 12:26:08 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:5ef:9913:4a77:3bcf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2dc577sm1473364f8f.3.2026.06.02.12.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 12:26:08 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven , linux-rtc@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar , stable@vger.kernel.org Subject: [PATCH v2 1/5] rtc: renesas-rtca3: Fix PIE clear polling condition in alarm setup error path Date: Tue, 2 Jun 2026 20:25:55 +0100 Message-ID: <20260602192559.1791344-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar In rtca3_set_alarm(), the setup_failed path attempts to disable the Periodic Interrupt Enable (PIE) bit and wait until it is cleared. However, the polling condition passed to readb_poll_timeout_atomic() uses an incorrect expression: !(tmp & ~RTCA3_RCR1_PIE) As ~RTCA3_RCR1_PIE evaluates to a mask of all bits except PIE, the condition effectively waits for all non-PIE bits to become zero, which is unrelated to the intended operation and is unlikely to ever be true. This causes the poll to time out unnecessarily. Fix the condition to check for the PIE bit itself being cleared: !(tmp & RTCA3_RCR1_PIE) This correctly waits until PIE is deasserted after being cleared. Fixes: d4488377609e3 ("rtc: renesas-rtca3: Add driver for RTCA-3 available = on Renesas RZ/G3S SoC") Cc: stable@vger.kernel.org Signed-off-by: Lad Prabhakar Reviewed-by: Claudiu Beznea Tested-by: Claudiu Beznea # on RZ/G3S --- drivers/rtc/rtc-renesas-rtca3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index cbabaa4dc96a..2dc080d0eb6c 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -455,7 +455,7 @@ static int rtca3_set_alarm(struct device *dev, struct r= tc_wkalrm *wkalrm) * specified timeout for setup. */ writeb(rcr1 & ~RTCA3_RCR1_PIE, priv->base + RTCA3_RCR1); - readb_poll_timeout_atomic(priv->base + RTCA3_RCR1, tmp, !(tmp & ~RTCA3_R= CR1_PIE), + readb_poll_timeout_atomic(priv->base + RTCA3_RCR1, tmp, !(tmp & RTCA3_RC= R1_PIE), 10, RTCA3_DEFAULT_TIMEOUT_US); atomic_set(&priv->alrm_sstep, RTCA3_ALRM_SSTEP_DONE); } --=20 2.54.0 From nobody Mon Jun 8 05:30:29 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D362B39C649 for ; Tue, 2 Jun 2026 19:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428372; cv=none; b=SLlCPy1VOCpAx9xG+2hOzxiy9Go88MFbhtod36TOKpWtu/tyeUMHq+c6Qze2V+s5Br1uI2bnkLZmfU042B2yJoIdsEJWOfxlj66SC2f1V4WI9hv6KGPleKYazm2xFkdNWyKv/2gfbEyuwZx82Kozd1M2z6OJUJQBKtrhpg6csKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428372; c=relaxed/simple; bh=vhJ8WlfT/UQKh+30bwKCtTBDLTkgAU6sbYcOm2fZ/iE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sLQ9SI6dkmGr54vhR13DfnvwCslgzmnkVN7xxWzRr1fxVkY0H9CTPPV/DavkgASQJrFMeNKbSfmDvzBajjkax9C1QLkSZ0JW3k2q3QBY5QkzsrBrCLWuJQ6HWm+o3oVwAuYdhWQxzifFNDeMJwTE6zVPtbZQ81XCFevhGxFmcBQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B3vq3ao7; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B3vq3ao7" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490b43e2b95so4997355e9.0 for ; Tue, 02 Jun 2026 12:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780428369; x=1781033169; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NcNCGawN55HsRcrqYdjNNvHCWY847Taw/F366F1svkU=; b=B3vq3ao7tj3+HgchqDNa1Umtn55nJkVqy6UkOAKPo7e289WRrZf4gv+w5+zIC+xXWO vaPgadYZ8Rf47QJqzl8ee5WBbKWCe39tfaE9l35/+dGk9V3mkfnLcsSEp3tutzkI5xpr K1atyATMHpS1sf0SjHlVzndcHMyd0FgmfvAyecVVBi9IBv/Q5C0pIZY/W9uv/DOvejL2 LZrpPsB38oSCImRkWUAIBU4HUhjoGyBujzGaRD6qBwQCgowL64WDegEFW7bJnKum6xKn OqRcPyRRlinChdMuBQOhVCaxl9E5JmY5bkzM/fAcZqrrsc1duIkSazVxXVTkWSh7Dpqr wh2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780428369; x=1781033169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NcNCGawN55HsRcrqYdjNNvHCWY847Taw/F366F1svkU=; b=XftwOxARx7XgXYUX8/Wy0iTswZnalH0P+Yu3IJ1aARbBUMyXGuenGy1Sv3d2TsnMBW C9Nuw11PALSQEh5LUKkR656nMEWtQc7e3S+pUkbcIFQlxUDEHXr97winVACcOjCkSMi0 MinQf4fszLf0i63Vy+2dxn4dTPQANUiNoetQnoYQOdSAxo1YcdGcOt7AHvcWVs9Re+Y3 7RWSwx376V9UcKWGGkNNsPgKHeGRgyqYYri+aDsaJFMrAK3mD2iR1ZsicMZHIrnpZSFM I645hMsSpOS3MaBf9NHBjMk7fzNY7NiNQxOlyYcU6q+EKq9PSHMSKbMQ20q+SD9V+VJs Clwg== X-Forwarded-Encrypted: i=1; AFNElJ/ZLHC+dGRG1QIXxLUsSx6jddL1MbyBJv9klE5RB0v7qHPAB9mRUVjvLdyNHN3SJsGaNv3AwILdGTb1h+g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3K6ug5EwyzkXT9cwtjrIeZBAiPjHPNLYK3sArpmJG2GgXZxF2 GSY8niMDsmirEcQD3y4qKo2XP/PxGVPrPQ029OWbU3Hx5bhOxVAVolLA X-Gm-Gg: Acq92OEKmj0ZrwZWngoeDpKQcHiC09JZ4xRrqVdeLnU+CoxPl40c3ckZkwwONi+NYhn rKoEmVKf5j90RMH+VgGuuCWYOqhbMAqDU7iVtzDS9IsHuEr5nmeT0bqD0Unih9Rzu+hp+B9bp57 lHxKFUOudZ75HBfrc/qP//51n1+VNVH7Opp2snOy5kGi3bz8m1bcsWx3vKISAAqKXoA6/wwNuhc TuyNvHILPK8shCFplt9dj9VSFzEiQTiEBaw8QspdZbBE8fHWK7AQw4Zgm/93En6+oYGgJWb3DtM 0p3C6NyDB45XL02xDf/So1qMrUTmqLoVTS8+5nFagP1p0ZOG/im26y7rYgmCvBlyih2GqHSfy33 ZuGXmzQ/3gjoXEnNG08DmUtsD7IR6IzLoeWOkabwHET5roT3mqVE2GecBjeHDmXZTOl1xATAlDK qDzYF1c7qtjGrDTg1NxMMLlVOOk9Th5IeE2gm+DavaPEXhMuTe+y39Fm0wQYtC4KdHqq0MSwC6U xK2pIvxVqkf5gm69H9YkkKJ/pxOT8FuajKdstVqYku4RyfyRpW9fuFSLTwjA7YI3gs= X-Received: by 2002:a05:600c:3113:b0:490:388f:1c0d with SMTP id 5b1f17b1804b1-490b5e94d56mr2872955e9.5.1780428369407; Tue, 02 Jun 2026 12:26:09 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:5ef:9913:4a77:3bcf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2dc577sm1473364f8f.3.2026.06.02.12.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 12:26:09 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven , linux-rtc@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v2 2/5] rtc: renesas-rtca3: Check RADJ poll result during initial setup Date: Tue, 2 Jun 2026 20:25:56 +0100 Message-ID: <20260602192559.1791344-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar In rtca3_initial_setup(), the driver clears the RTCA3_RADJ register and waits for it to reach zero using readb_poll_timeout(). Check the return value of readb_poll_timeout() and propagate the error if the poll fails. Signed-off-by: Lad Prabhakar Reviewed-by: Claudiu Beznea Tested-by: Claudiu Beznea # on RZ/G3S --- drivers/rtc/rtc-renesas-rtca3.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index 2dc080d0eb6c..af2a3878289e 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -634,6 +634,8 @@ static int rtca3_initial_setup(struct clk *clk, struct = rtca3_priv *priv) writeb(0, priv->base + RTCA3_RADJ); ret =3D readb_poll_timeout(priv->base + RTCA3_RADJ, tmp, !tmp, 10, RTCA3_DEFAULT_TIMEOUT_US); + if (ret) + return ret; =20 /* Start the RTC and enable automatic time error adjustment. */ mask =3D RTCA3_RCR2_START | RTCA3_RCR2_AADJE; --=20 2.54.0 From nobody Mon Jun 8 05:30:29 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E97073EAC84 for ; Tue, 2 Jun 2026 19:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428373; cv=none; b=XxHww05ygbKJMJ0sTaq0kaDmQbwq1ExIVuPJIwGO4TRIWhRsx8S+gPddnYTpuFRXFqN9TDiX5XyYA3zc8t57AVgCb7XEodyF2Tzc/wf7dIi0l0o9mzX8B4+OLeCYo45QGf8BHwThYUe7VpKJOX6QIxvk5Uk7WJnDG3zfbobv1/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428373; c=relaxed/simple; bh=KmqoBxF9Fq/rxvKf5KdwMsGgv5Iw4McuSBL71dPTzh8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SKXS8uUh3DnrCXThuMRug17fI0B+NqlYtbWy6UxCzbatVChyWMblN1G/4gPGd4uoxnBd+KAlcAhEoc5HflPC3Povl4f+lqyVj5sFU5MKrpKlHM5iwlu1f/7E74f3SUjuG0ag6qIhmQmUFc+wxlonrctWHSN1fe+NYjy+gzAanUo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o0YRtmGJ; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o0YRtmGJ" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-45eec22fab7so3064295f8f.3 for ; Tue, 02 Jun 2026 12:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780428370; x=1781033170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HuHBcNAKhq2nFa40i0FpC1ftR1msEUqJgWkorTy+ZHQ=; b=o0YRtmGJHfNW25OhCdNYDB8gvIJdIQSYroRNnp8p9hndjEa5sFqIAeGEhu0y75j68Q krh8F6xRcNasVf4+xTd/OMFT+z3mla032qj6+XfjYNdEc0Xu0r5fFR5Qp/4FzPuEQC43 SCjzRCWPamyCVEHghJhrTeNpZm6BBYQOtW5SObecX+Vk/S1mhdGy5tVC7T0KPCUBz2Yx 8a5tMwZ+BVEGe9rb+A6BlWtEgF3ApULFL4vS0BCf2bBvhyiRNSN5sTKqlOkSDqvqdBfe COpWafOYQ3je3r+60wSl1wglkOH7HZ9Qcb1SIIgGAKkiffSUTrzrjkUx+DKLBoNt/jXk ozhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780428370; x=1781033170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HuHBcNAKhq2nFa40i0FpC1ftR1msEUqJgWkorTy+ZHQ=; b=huRVVhyCIwDbV4UyeqktsAzoWeOoPPwVlHl0RCBdJwNICoUW3BWEhxWES2NorFzhQz ih4QeaF+LFBbK7aPR8k4TCMwJcU9SGN4J8i5Yzl1SY7c3oTbQMkZjc7K0SfbAzjC8njH K9q4o9EKW4c1pZ63aVYesHRpeEh3B1FNk+ofufn9xhjSLhzox1cJpyKqotp0hDVNgu9c u3SqhwRHQz90UvSy9FfmO1AiU3SJ/W7Z6lCiRopec9uB+d+sw6vr5q9T+kp1XjU9blC2 0M1vsHgcZKp97H16r+sOiHfLhvw8/Azyg30sDHC65fOA/PalWmZcEtAXOhkq/TSFBGwP w9rg== X-Forwarded-Encrypted: i=1; AFNElJ9xVoHWwoG2J5W8SUxf2xX+wIArgTjXGIA2qb7CeArslVYyqY21N3cahvyfRZQYtevx25LGDJi7cqNuBHc=@vger.kernel.org X-Gm-Message-State: AOJu0YxOG5bzNTLR0j/JVaCjCpku4Gi2x+S4dbVbRXr+FkeYpfqUTzUV 4X7j/81UjBklfnrkNGdoawv86MPJiVaAljiSV1XXwwB9P/ANON+9xOwC X-Gm-Gg: Acq92OETqt6rtvrFS0fwf7/artre37nGzjvmtIIJTBFUIY8CjS2E54OQOMF4oVyVQD7 GPGmS4A4z9IICC1qSBTz31MieR2bWJrsRBIOsV/G5bidCmpTJO0QXq02XjfDP4sU4l3JPwvDeZt KwUxVUvg7REfa3O5QcgVkDX23VCG9q7sKbPWIwW4wsPNhFP1Z7Q4qQMiRdYGHEMZB0QWxlFN6Fx dKUb8Rb9MoFZf/6o2Zc+jHOmsBDzA4tbv5O1+dvf4w+er6EpaH0GsnTG+4Ctl7d2YYREJKv8f/R QPYtM+cyHgAAK8yT8hv/8NYihsob9MWbVh1+eBZWswGAyTyHsT5syY4P0be5NtiN1i2FiDItkze C6I5p0bRP3U9iSnrE1BeBcDAviOO4aPyZkCglw40ZtmvW2uA/cHrQ8doPcSJJPgP9M4f6p3hz47 S0r4M2ODDxBqSBCvz10IPL8VBbiy78YhJZdYIZ7ShG5+IsvbDZ64O7vpmQDh7TkhHkT155fZrPO /QBhHyD71u/iEVfmaZj2Quao2HC3O20hhCs5fZ6B8OGn3ulyER6tprv X-Received: by 2002:adf:f2c2:0:b0:460:1a36:deac with SMTP id ffacd0b85a97d-4601f6087c7mr745571f8f.24.1780428370407; Tue, 02 Jun 2026 12:26:10 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:5ef:9913:4a77:3bcf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2dc577sm1473364f8f.3.2026.06.02.12.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 12:26:09 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven , linux-rtc@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v2 3/5] rtc: renesas-rtca3: Fix incorrect error message for reset assert Date: Tue, 2 Jun 2026 20:25:57 +0100 Message-ID: <20260602192559.1791344-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Update the message to "assert reset" to accurately reflect the operation being performed. Signed-off-by: Lad Prabhakar Reviewed-by: Claudiu Beznea Tested-by: Claudiu Beznea # on RZ/G3S --- drivers/rtc/rtc-renesas-rtca3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index af2a3878289e..8763745b9172 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -702,7 +702,7 @@ static void rtca3_action(void *data) =20 ret =3D reset_control_assert(priv->rstc); if (ret) - dev_err(dev, "Failed to de-assert reset!"); + dev_err(dev, "Failed to assert reset!"); =20 ret =3D pm_runtime_put_sync(dev); if (ret < 0) --=20 2.54.0 From nobody Mon Jun 8 05:30:29 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E8E93FB075 for ; Tue, 2 Jun 2026 19:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428375; cv=none; b=LEcVrM6611P8gEqE+56zEZZ2Tg2cuEXDAeD5Wgkv3oiNcX0cPnEhU9L4vfzrczbksaszvODnuPMX5e1marAQ3VYD8RuOZ7UupxDwYHTsocpJhPRpYtiq7jdHmt0U52dSAgwOWnSw02Qvcy8JNCnCJb37eIiYbloyvZLnZsqyPno= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428375; c=relaxed/simple; bh=Pq0svnGPa1u3UfwlKgWp463B8xAdVz9dn0+Hs3N2waU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aTGk8tCca0m+Ljx7GKQhDGcRw1KAQ/OQODOeqZuInnzh3WFfN3W1ANUcSEbL4JcLD/NOIaHV/epdqYzbfcvpnKcqT4MllniLjqSQIrOtLWp8/gg4xnzvIeJOyNefLzoHqFmmlpBRDi5DjDu/U+lZQj6LZBEei7PkLPwNgVj7WEs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LcNIGMvP; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LcNIGMvP" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-45ef779c1c2so2919960f8f.1 for ; Tue, 02 Jun 2026 12:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780428371; x=1781033171; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D1C75smfFsRKbCTgs6OXcvR1GgVjxJ7f2dUMhEZaFrg=; b=LcNIGMvP8AsP5B46MFNPvJ3RepFhX7A60l2PuXzptSyCbTjEDvTVayGcl85E938Mkq pr5rDfODU042i3CwCXIgZUv1eOquY15T2I/qSIGYU3UqvMwN2083SXec7vw8v2IcDWkv w3L2AZFadWmU3qZsIRojAKwkpWexas8W5z81XUCf0gg/bjbUi3fcvYcqsEFs4mPXS/NP BYE2Z8tVP8hvlDZJleYhOdHlRUHX7mVKjzcLI9ZviNIrqC+17XpKHde+jgOK5Z3qC0Yz iv4GwG65OM1QBDgeXXiSTPhtUb8J6rbPyGiWhPT3uA7jvrs7Z59BJboTo858UBIS/0m5 dHww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780428371; x=1781033171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=D1C75smfFsRKbCTgs6OXcvR1GgVjxJ7f2dUMhEZaFrg=; b=YXiHtUwyrYzhuDKCFeWyp8BgwGyKtvwpvq3lsac713bL0kZA0kL26RL7md2l/r8J9/ 0BK7OEJ5B4eWiylyP5mhbzpGkzeI60b9uQS+ths46hsCaoIZWdenJca6kimOJWx9pMox s1l+iNXwm5ryeeKXXGuR9ALcn4FAZoDeNRqSiS065sRJgWP6asAeflYmYJF4e8p5gyx/ QYE1+lrT8QbRIs+i9kVIBVxNpvU47fi/aHIze7vnxdAh6Z/vd2fbgYIrdfW19004o2qN D+jOyXwdJ+lvyYy7EHzJsJsbo+UCib6eyL1Xj7KRbdA+uNxmkdqXDBkzBV2voqPc8itD jJJQ== X-Forwarded-Encrypted: i=1; AFNElJ+W6ilR2yjgLv4vcEHtBKOI9uUWAsM75Hidgdyb1QQEONod497JiupJNRPGh6RKLSGn5ID0oYRVsy2GI40=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+Uq8ZeZZRCV/0rcGcy22gZv5MlGngrSc6DnszNhsP+J38nCXI ZwoqKweIUWIc14zughWT0kmImJjDRRM0HJIgudmB8JTkOGKXQM4cJrGr2W0+J/HxRRg= X-Gm-Gg: Acq92OGG1Ihq6OM41XINT4MWhmxLaWfC1dj0gObLJjBHB9/KTE/tEpdZiYCQaTPAEGr gFRdwLg6NL5XQK+0liVGVrDAMXjnG+ctISG/H88Si7WWSMHktfT3AzFs7iqWH5yCATnh1B+2poj eJ64o/xlgHYJzpyWt24m4+tUyYpo+Z+DWBW/aBz1dRi3zkbddZbH4zAav6QrQ9FgybRelRarcA7 fPHl+Rgnx1eiS5DoLei3RjTsoHvl+8Wlpm8UKiSghL+fXkrogPzlBuSRtz1zRGU42zFqNvGFG8U pgdJlUksN7Df9wBjyW3ljoa7lxN18dVd0UrXh1VgFa5I06wwyFrSYJruGz0/K08RWeJXicj54gn ulgdtSEyQfO7mtgrRs+Sn/Ljl2h1kx3ElmuAAZ/N8Rpi4p90cTWvrhzR5U1VlhAY/hLLDwK6kr9 Oqx8Q3etOangPeDDS2BrrW2murbrTi1vyFqlstQ0FNiPDi1hQwQogoJ0FF1U5NT+EQ9bJpL8y0r wiXmjk1rsRPtaOq2fcNgrgy6njE7hY+YZh5IzEIKAVBjNYCuOt4sQ/nY5s6j4DoDP8= X-Received: by 2002:a05:6000:1a86:b0:43c:f90b:5668 with SMTP id ffacd0b85a97d-4601f6216b4mr1021407f8f.23.1780428371405; Tue, 02 Jun 2026 12:26:11 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:5ef:9913:4a77:3bcf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2dc577sm1473364f8f.3.2026.06.02.12.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 12:26:10 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven , linux-rtc@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v2 4/5] rtc: renesas-rtca3: Fix typo in rtca3_ppb_per_cycle documentation Date: Tue, 2 Jun 2026 20:25:58 +0100 Message-ID: <20260602192559.1791344-5-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Correct a typo in the kernel-doc comment for struct rtca3_ppb_per_cycle by fixing "adjutment" to "adjustment". Signed-off-by: Lad Prabhakar Reviewed-by: Claudiu Beznea Tested-by: Claudiu Beznea # on RZ/G3S --- drivers/rtc/rtc-renesas-rtca3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index 8763745b9172..97e7e65f59a5 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -103,7 +103,7 @@ enum rtca3_alrm_set_step { =20 /** * struct rtca3_ppb_per_cycle - PPB per cycle - * @ten_sec: PPB per cycle in 10 seconds adjutment mode + * @ten_sec: PPB per cycle in 10 seconds adjustment mode * @sixty_sec: PPB per cycle in 60 seconds adjustment mode */ struct rtca3_ppb_per_cycle { --=20 2.54.0 From nobody Mon Jun 8 05:30:29 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E97834B19A for ; Tue, 2 Jun 2026 19:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428375; cv=none; b=s785e8rYSx/tliUvyhZ3iVMIwHaGfWdWmIG8DobhPWt7DgRhuvXw/y9h9NvCfDXmrNBcZ0R8bYO7F1VKXLMvPbUM4lSxuZXao9qUcv9WlEFbnStL+AIs/iSWyAG9/+MjUSBYacm8vLo76rrQBjZwm4x7tUe1lXv3IbWCJzakZE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780428375; c=relaxed/simple; bh=eh5Ozs0edkRZsnMQsj4tIuBKDaf7zwjmpDtFtsUTUfM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C5zSflf4eDmWW0GykV4pos5/G4PgR+qGw0bWhr2EnnvrSzsmtH1FHZn83q/vxnOqCoGZUeEa+tAXbeLCOK+yWwS6QIk5cd0QNFBSgX3ckGZxVGs3S9P6rxWelCvbo/VgnkYgRnY+IG8AFCZc6kDeLrHoheRB06lKV0AxYiRyib0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TIGS5BM0; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TIGS5BM0" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-45f3cf907ceso1715517f8f.2 for ; Tue, 02 Jun 2026 12:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780428373; x=1781033173; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=93V/HD08Dr66e6NMTC/hLxCahTv4eoK0wDXtTo0JpXM=; b=TIGS5BM0HcKHLeL16kANrka1Y66w/siT89V5iycRxEIZ0GGQyAhEZ2E6gTk9lmqXfo 2BOwSDPwa5lKO42VXOus8CVqLOjzVhE9HG+cMN1iG2BjE/ZJHYx6GsWtbW0brBr9aDGl TeFpg+Gm19ViVXFsXreL2t+qsoVhWS7Bo82hGm2cDG2ItZSJtU0rFJJ3c5lFLhnf3n6r 8C65kKn1+5MXxfbqSQ+t3iRzq4pvJE+tSYQ7Xy5iRL2nAv+iQqp7B9qlH+0Bil8PLR2h akV+D9lxl2tB4LaKyNzXwR/cjcV+9UiuJhmeg/v8mncH8Gp765CqHJrCRsPCuCSEwytH KcrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780428373; x=1781033173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=93V/HD08Dr66e6NMTC/hLxCahTv4eoK0wDXtTo0JpXM=; b=rClQK2QzSbFkn7HTDuak4tCOZWCQ2VBhFfHbgakd/K/cQQKNAm+D6dNSQdUVw8YLip C87CzOeGVFg8hqwSjUXa1UuyX5MvG+bfe+X5aLpPFjJWirZWvU03exaIuoA2sqT0vAC6 uxVi06huem0cg8qKQGOVFgrpaHZcqz8Z8t4AqVUhlOrdbWmPeroICxEtuhagklfJeLId XFLssxbn69tF2npkydmljROx3mBLp7Xi0GNqzpVx30XHYGVIwRe0Ud0FImUF1wPxbQAw 0dhq4AEEKk51d5xVTMP8L8oRoS3ERadRRRBDjjGirN+ezaSZkPqRyz2N3So4RuugM8oR xb6Q== X-Forwarded-Encrypted: i=1; AFNElJ8KQoycf6dOeS7rNZ0DDMDrEOYRaSc90+431KoderAY5+a+ULqYct15vZOkHYdxyIh8Z5YCuxuxD0qHAJo=@vger.kernel.org X-Gm-Message-State: AOJu0YzTsuY18w0ea6ol0ZMq8KX2xxcZPWekrRwE8965o37d2dxt9QLT MqV1VxlfVNyUb2Xd8pweCf14qZahKO0k02bvlLD7VNbx8vAwdBXEDOy0 X-Gm-Gg: Acq92OFxdrIv1tLtoP62HDjy9oJEcopFfl9rgOYVY0DO81LTf1biaTpCDQclWCguimS PsN7uqsYFRtYOSG8GYRBelctWLo2Eett7cHjCWsviYNjXrpE5CWnYaWwHbo7nlISxhPqIFrDjmo CL4rkfMBB4LIrR759bpkDBy1v68FF1c+mwLoetKui4HG5n8R3Crbom6MuKpYuacRfzZ1Js1Z6zU yl+oPcCBBu+FKNLyC6dhpfMgSvKiK68Iy4Cx0d6a1N5FRoWRtieuvrrHHWbS60hHXvXnUOl3/8u hoTKv3V8En8X8RrqScQgJK9hmxOwAXlJCxo9MnM7rRB+fWkj7TyOB9rqT5kk6vlrzqsqK6RLGIt E6iKSQvVJFvKpNPdw9J5a4XNAMUT8+9jQAWTZzhW2SmVtfFLUFOc4XrtRqvqw7ycmKRvPxds6BA 6IvuM8+lsoN4C4TQL7mpPmdJvLnGkAa5e/g1uCHcChBxkeSMCcE8FItjjXPBXq9MKmer9az99xi aMIKsn6R8hnXfD5vEMIeBtofrBQuqApZz83SOu6UTeWqfWLF8zn8KWN X-Received: by 2002:a05:6000:12cb:b0:45e:f266:f4c4 with SMTP id ffacd0b85a97d-4601f645de3mr760603f8f.29.1780428372438; Tue, 02 Jun 2026 12:26:12 -0700 (PDT) Received: from iku.example.org ([2a06:5906:61b:2d00:5ef:9913:4a77:3bcf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2dc577sm1473364f8f.3.2026.06.02.12.26.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 12:26:11 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Alexandre Belloni , Claudiu Beznea , Geert Uytterhoeven , linux-rtc@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v2 5/5] rtc: renesas-rtca3: Factor out year decoding helper Date: Tue, 2 Jun 2026 20:25:59 +0100 Message-ID: <20260602192559.1791344-6-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260602192559.1791344-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar The logic to decode the year value from the hardware registers is duplicated in both rtca3_read_time() and rtca3_read_alarm(). Introduce a helper rtca3_decode_year() to centralize this conversion. Signed-off-by: Lad Prabhakar Reviewed-by: Claudiu Beznea Tested-by: Claudiu Beznea # on RZ/G3S --- drivers/rtc/rtc-renesas-rtca3.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-renesas-rtca3.c b/drivers/rtc/rtc-renesas-rtca= 3.c index 97e7e65f59a5..b3875d041de5 100644 --- a/drivers/rtc/rtc-renesas-rtca3.c +++ b/drivers/rtc/rtc-renesas-rtca3.c @@ -228,12 +228,19 @@ static void rtca3_prepare_cntalrm_regs_for_read(struc= t rtca3_priv *priv, bool cn } } =20 +static u32 rtca3_decode_year(u8 mask, u16 year) +{ + u8 y =3D FIELD_GET(mask, year); + u32 century =3D bcd2bin((y =3D=3D 0x99) ? 0x19 : 0x20); + + return (century * 100 + bcd2bin(y)) - 1900; +} + static int rtca3_read_time(struct device *dev, struct rtc_time *tm) { struct rtca3_priv *priv =3D dev_get_drvdata(dev); u8 sec, min, hour, wday, mday, month, tmp; u8 trials =3D 0; - u32 year100; u16 year; =20 guard(spinlock_irqsave)(&priv->lock); @@ -274,9 +281,7 @@ static int rtca3_read_time(struct device *dev, struct r= tc_time *tm) tm->tm_wday =3D bcd2bin(FIELD_GET(RTCA3_RWKCNT_WK, wday)); tm->tm_mday =3D bcd2bin(FIELD_GET(RTCA3_RDAYCNT_DAY, mday)); tm->tm_mon =3D bcd2bin(FIELD_GET(RTCA3_RMONCNT_MONTH, month)) - 1; - year =3D FIELD_GET(RTCA3_RYRCNT_YEAR, year); - year100 =3D bcd2bin((year =3D=3D 0x99) ? 0x19 : 0x20); - tm->tm_year =3D (year100 * 100 + bcd2bin(year)) - 1900; + tm->tm_year =3D rtca3_decode_year(RTCA3_RYRCNT_YEAR, year); =20 return 0; } @@ -354,7 +359,6 @@ static int rtca3_read_alarm(struct device *dev, struct = rtc_wkalrm *wkalrm) struct rtca3_priv *priv =3D dev_get_drvdata(dev); u8 sec, min, hour, wday, mday, month; struct rtc_time *tm =3D &wkalrm->time; - u32 year100; u16 year; =20 guard(spinlock_irqsave)(&priv->lock); @@ -373,9 +377,7 @@ static int rtca3_read_alarm(struct device *dev, struct = rtc_wkalrm *wkalrm) tm->tm_wday =3D bcd2bin(FIELD_GET(RTCA3_RWKAR_DAYW, wday)); tm->tm_mday =3D bcd2bin(FIELD_GET(RTCA3_RDAYAR_DATE, mday)); tm->tm_mon =3D bcd2bin(FIELD_GET(RTCA3_RMONAR_MON, month)) - 1; - year =3D FIELD_GET(RTCA3_RYRAR_YR, year); - year100 =3D bcd2bin((year =3D=3D 0x99) ? 0x19 : 0x20); - tm->tm_year =3D (year100 * 100 + bcd2bin(year)) - 1900; + tm->tm_year =3D rtca3_decode_year(RTCA3_RYRAR_YR, year); =20 wkalrm->enabled =3D !!(readb(priv->base + RTCA3_RCR1) & RTCA3_RCR1_AIE); =20 --=20 2.54.0