From nobody Mon Jun 8 03:17:04 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E593D47B9 for ; Tue, 2 Jun 2026 10:16:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395401; cv=none; b=Ye8Yhf2FNzKppJsq9qSAuI9iQuswr7mex30bzw5cylyD6Z5lELDDKyLXjrvweeZm18O40BDSoZ3tm+UWDK6JzxigHl0DGQgoxbOQxWCrBqhMZ2unUbROVUHWafXcfQJRZdVISI1lych52hk3Ee9EQoIy8lLdlwkQM0R5Z8HN3VQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395401; c=relaxed/simple; bh=uW2jVibi5UlVA0sr1KUeudNxCWTIR8KeS8lo2eLVMg4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NmP9E9JhccIUN05ZbRThrktMn5x5n78IlSYAji0/SP+WZwHM4S1friVI8gYgSK+O4DWQIYpasR/Vc+MEa1BCjlWfkm2eejwWkGW09sIZMl1HWnLdZJZVwnlFeP3bd1Oz1bhts64Lu3qUIUI2Zvi16+lCRXN11dGaeBGNRhDXSbo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V7eQFVIb; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V7eQFVIb" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2bf125989f2so33297435ad.3 for ; Tue, 02 Jun 2026 03:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780395400; x=1781000200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=itZ+htTWHTauD3C5JTmFzIrqx+Hfh0DDPlT3jqkIXr8=; b=V7eQFVIbEAH0qA+HSG67mI9/Dy15UHKBjRc8dC51Hqx3v+3hd05Plp0x/2Sed7WThn aDc75iNsSDHj9CJ5kFMCXsJk+uTX3Gu04NL/BuVHsIkcaPL2MQHZkO89T8VHMuJpOnKG pD8cmlnkVF8cg0RLH4mLc1mr2EQR9IIgR0Wh/Y/Q/j5mVqGL4o/URmz8/auMR+OPJluB eIhb79uYKw8MFuCpcBMR3LCWc3AaordjJY715aT4St+HsGbjToJ73UvxZYKgWVxN5OPZ vhZEU8QiGoJzskAWrm9vcdLGzKk+7NtS0DOhBkmAYENZ0OqDPW94Dq/bsmIYcqWcb3VC DfDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780395400; x=1781000200; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=itZ+htTWHTauD3C5JTmFzIrqx+Hfh0DDPlT3jqkIXr8=; b=Pgf66O3ENeoYShBdeoKqXs4f9JcNkO5tQTKe0UNchkkaNg7MBe1HNbdCpgTec6MTGP pw3OfHfYWUGg76aq2xoVm0oPMWiPFteruJ4Eot49RTKAnFCDXu6hfKv4PqvK8ihFFhuD zoh/ZnUB5Jm8DN+EFjH8axLvv+OWzrv1SNqIG9ux9Q3uxIr3t79OTTv1UEMi4LuYujXw 2fu3vPhn/hyxwosQa01jI8NDr2CVDv/VVIA9UO+XfGawMjAaZQeD/YK+Cr77AncWAl73 y6HgLd5/KvZbDY+YnWs2pd0uD5wZGXcK0fzt0BprY2lsG4PxJQoRRGjMKwFY8ZATaejq KCHw== X-Forwarded-Encrypted: i=1; AFNElJ/dfshMHb+nQn2qabmXsGng0LYu/EyTF7PsiWVcTcKCKpWLP6VHRnYxTrB/C2jb5fIG7MDsN2bOFl2KUPc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgn8FtrBZT22p7SGC3m2EYBQkXuWLOnpNH9+sMz+pWb22WYinL BDZLL9hhj6PdeD5PariTWr+rBYX3R3pIM9L3EnfuqvtkjkzsR4S398dG X-Gm-Gg: Acq92OHU8Ym0uDOJ6/0IgIoeTn9RcR3SnenDZyHBWln62Wx4XRMQX/rSBVGVcFX3vaF Wmb8xAoFvjonwSHqpLf8yhti2qghdBZz8i4lOyYNrHl+s2EmePcRbdyXDCMQct6bKkev47WHASm /4Td5BJKy0irfCfC8l9DYtguLAFNT/SwUEck2IxHnWoZvD+ygDB0iyWCkMNG4EFg7PVz8vwO9Rz Gg8m9afPomP64Ci3zc4dmApQrQNTQ2OTuaWOMNjM4gfo6St28UhEItGlpqnyome+5VqDYIQElGg GyvkM977uhGdcjoQIXzeKuikVbGQgkuv7siivh7VQkfQk2B+s/cFu/CnKoceqVrG0NgzY9RZoy5 jBSiEYA9Qdx9V5nWZH7mGB0NkL87uSsq07q6lRfSPTgm95pL9AxS4KJL07n1m5Zq8la9UXYtlQB duMYpkHsBtmvBQWeanx/Adc0LYepwfMMlwyyXmCIX/VEt6rHmCPIGNIehjP8g7eFfCI/TV X-Received: by 2002:a17:902:e88c:b0:2bf:30c8:bfa1 with SMTP id d9443c01a7336-2bf368bd8aamr168629675ad.41.1780395399946; Tue, 02 Jun 2026 03:16:39 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239fd84fsm132766305ad.23.2026.06.02.03.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 03:16:39 -0700 (PDT) From: phucduc.bui@gmail.com To: Heiko Stuebner , Mark Brown , Liam Girdwood , Krzysztof Kozlowski Cc: Rob Herring , Conor Dooley , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 1/5] ASoC: dt-bindings: rockchip-spdif: Correct SPDIF clock descriptions Date: Tue, 2 Jun 2026 17:16:04 +0700 Message-ID: <20260602101608.45137-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260602101608.45137-1-phucduc.bui@gmail.com> References: <20260602101608.45137-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Update the binding descriptions to match the actual clock usage, where 'mclk' is the controller clock and 'hclk' is the bus clock. Signed-off-by: bui duc phuc --- Changes in v2: - Update commit message based on Krzysztof's review Documentation/devicetree/bindings/sound/rockchip-spdif.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml b/= Documentation/devicetree/bindings/sound/rockchip-spdif.yaml index 502907dd28b3..b174d7498029 100644 --- a/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml +++ b/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml @@ -45,8 +45,8 @@ properties: =20 clocks: items: - - description: clock for SPDIF bus - description: clock for SPDIF controller + - description: clock for SPDIF bus =20 clock-names: items: --=20 2.43.0 From nobody Mon Jun 8 03:17:04 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BEA13D668C for ; Tue, 2 Jun 2026 10:16:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395408; cv=none; b=D/4wJ6JExCDLKU0DsgFAd1svhM5/Vp1R5bNBH/5xuEZ/Wz/0+0DeeVm651EjvrtaLE0KUx+pSHQ0f3ELH3NvtEE5WRDyHhPGQcqRnHJ6BiVqCxj62h8rShbuPXrv933VZvIZrgKbvoVrC7QVCo+iOQBRsErUPwpUvxFB3fmmpHQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395408; c=relaxed/simple; bh=jLLJS63DmaW6/N5p/t3mdPzRbOoNEcIP/BNYCgIzYbM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i5bXRWIkAQO6QJYg3Wr4SS6JHBoxiOuAw0m+4r77LOfXMv/KGDYa4avlyUOMyLy6JBvAXSEspHdEoP47pZS6nApulqXLOXG6dZFA9Wk3wksSwl1eSWnWr0uJqXJy/xuWpkITzWASu63W8KN4JBeU4782T0vYRbURkCwKm+nDNxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OCO5KFgs; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OCO5KFgs" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2bf02708e8fso38061815ad.2 for ; Tue, 02 Jun 2026 03:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780395406; x=1781000206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zlqWTxvd2nybMb9oOkq3B+WZ2+KSO9DV36s9D60SrZ0=; b=OCO5KFgsWDtTd/4CHl4JEMzWtt5h8mWhi9Bz2OnEzsi12PddUsNjjLjTunolulKAdS pqGxgoglTPnQeTap04YEXV+0Rvzg6pWiCk9NdMCUnjLDOEiagk2wGf1h8EWiv4X56fF2 fzId7wy5xMBmr3AV6Tg5DUF1CZiiIc8qXzXoB6qPbsiqy4h3o90s3eLx8EzGFXV0XlOE GI+DO+UUGAUT9AM5fXlmnN3PFAFAAO9RjZLgNLZ6raysWQeirKAz9mcCou2/Gk0O7y+T Lh2EZ/E+s9WXrLSjYBH4GBjHB14c6oyhodWgqaUvVjnTEg+XG6zyONL9GkBZwcYc8cIn SrJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780395406; x=1781000206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zlqWTxvd2nybMb9oOkq3B+WZ2+KSO9DV36s9D60SrZ0=; b=kQWtWhLkkoEXqxWkpovNhniy0U199CSmUVWj5tu6aRFpdMzPzzo6V9XwSCZ+mR6jb7 LVa5FC47F/9+ffKUhAP+MR6Poxj5zBlLQpi8X+PYYoLqGEpCz84zNiF8cflGtAX/S1Sr E6YyFn4EGJTbaGaSougqSM8bLzf+NUIE4D5FoKYhT0m5k04O+uYoi9DWqrFYwK9gPkqU QBpjs7BV2bFMjL2Pi68VRlVjDIbffj6kRJ1dPkQvITXSMOXVs+NRBlXhOPMdKL3GiiRG jy+d5N291lRH8Yom9IWjkAhlnnOi0H2jDUki79k3Ffy1I3TFrf3l+iJy98eCizMo9AzB ls7w== X-Forwarded-Encrypted: i=1; AFNElJ9sceyvldyjjX+vsGbHPvF8StVwmOKYEv/+awiNJSlOTqDGRo9eKBeKEIEnNdsNG4r6pPC/rTr3jggPJw4=@vger.kernel.org X-Gm-Message-State: AOJu0YyQCQ4LWoAFfc1pjz+/js+6Pzi8/tajpQsEZ+JFOwMbIcBLjrvx skV/D2JLfJ3w6HvJWiLb8ShVd/tY0ZMdRvj2wZtRCcGPa/Nb0oUrpdAP X-Gm-Gg: Acq92OFCADN9cZGJqJWNWiO78LAoWiMfE0OJP2V+vidTeqIlh++ltgugUQZmfVEomWa XmvTZABSZHV7Iuxh37pDnb+fOWiIs2QracCZvS3KnOOI7xQ3bWOwo3BOp0/c2YarhbajKmY+vIW 2YGmPDnVt0UsAOgB0fmWkEsJVzklnVvfpiaKMLQqwQmVN42irrYrdt98uLwYJpFEo+7w8xuQSPa 74lS1Z2hsAz1Ue/5U1z3t0Of3Az0DOWNfNtc2AfTYEjBad+8tT5HWUMdU9gezyGxkSUD/gp+ZIA p/4fh8FgIB4UNNr2UMBP3I6f+Tl2tVkrCJoxhQBX8G4Te0No21S6jXgVLjgNZT4Vc4NctUr1p7O TzSPZWr5M5kdEt0eEPu26aEzY94CF9lEpRE0qD7PHxRGbkycvn5SH8KiFwEDSPI5VPSKUHZRvHr TaLjCJEYTZox5wGNotxHifqjo1PIL7Am4kikKtCmRFTR9HS9DWz2tUrEYLoPYBok3nt9IM X-Received: by 2002:a17:903:1983:b0:2bf:23cf:3e4 with SMTP id d9443c01a7336-2bf367d9da0mr164110925ad.17.1780395406357; Tue, 02 Jun 2026 03:16:46 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239fd84fsm132766305ad.23.2026.06.02.03.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 03:16:45 -0700 (PDT) From: phucduc.bui@gmail.com To: Heiko Stuebner , Mark Brown , Liam Girdwood , Krzysztof Kozlowski Cc: Rob Herring , Conor Dooley , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 2/5] ASoC: rockchip: spdif: Reorder clock enable sequence Date: Tue, 2 Jun 2026 17:16:05 +0700 Message-ID: <20260602101608.45137-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260602101608.45137-1-phucduc.bui@gmail.com> References: <20260602101608.45137-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Enable the 'hclk' bus clock before the 'mclk' controller clock during runtime resume. The bus clock provides the register access interface, so enable it before the controller clock. This also makes the resume sequence the reverse of the suspend sequence, which keeps the clock ordering consistent. Signed-off-by: bui duc phuc --- NOTE: This patch is compile-tested only. Please help test if you have=20 the relevant Rockchip hardware. Changes in v2: - Clarify in the commit message that the resume sequence becomes the reverse of the suspend sequence. sound/soc/rockchip/rockchip_spdif.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sound/soc/rockchip/rockc= hip_spdif.c index 581624f2682e..8de5b76cfe79 100644 --- a/sound/soc/rockchip/rockchip_spdif.c +++ b/sound/soc/rockchip/rockchip_spdif.c @@ -76,16 +76,16 @@ static int rk_spdif_runtime_resume(struct device *dev) struct rk_spdif_dev *spdif =3D dev_get_drvdata(dev); int ret; =20 - ret =3D clk_prepare_enable(spdif->mclk); + ret =3D clk_prepare_enable(spdif->hclk); if (ret) { - dev_err(spdif->dev, "mclk clock enable failed %d\n", ret); + dev_err(spdif->dev, "hclk clock enable failed %d\n", ret); return ret; } =20 - ret =3D clk_prepare_enable(spdif->hclk); + ret =3D clk_prepare_enable(spdif->mclk); if (ret) { - clk_disable_unprepare(spdif->mclk); - dev_err(spdif->dev, "hclk clock enable failed %d\n", ret); + clk_disable_unprepare(spdif->hclk); + dev_err(spdif->dev, "mclk clock enable failed %d\n", ret); return ret; } =20 --=20 2.43.0 From nobody Mon Jun 8 03:17:04 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FC3E3D5C3A for ; Tue, 2 Jun 2026 10:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395413; cv=none; b=mA4MB3mmUbhGesqkuWQ91QU4aPWQsiNFmry5NNf7PfW2Zbpnwo9yyTg4DRDmV+BIHm6UTmSi/HO/+JJbOpt4Wu3t1z0r3sTtsAJIyyYyqriDYIyYhbnZ759VY6tKdvZLmI8nUM08450cWTwyQGfXmjoiMajtYTxpuBCpX/dFCuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395413; c=relaxed/simple; bh=vhEkZTw4QlzQZ3n04KU8Ww88nfpYBe6Oem2sU6WQQ/g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Tt4s2u4KJUZ8aazjkSEuCktSJ9oMh7mWcIy7LJhh4lpspHso2hyWh1D6wuoL/euYzzTlcQ1i6VZqtgL1eqXJHDOEi+/iy4EUWy20UQFBjTIoOLOOAiPz8lw4GqJlWf+JHml6P8EtnphoEBIMOVUJpaP8eevZCTAttXxKYqBcumk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AKUOceib; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AKUOceib" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2c0c2d8b95bso15209435ad.1 for ; Tue, 02 Jun 2026 03:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780395412; x=1781000212; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rCb8DxBgLNYKl2se7nFRUFkwYJO2PqG9toAr7Dgva9M=; b=AKUOceibMMmAKWnzXZzBgWiyiwi/+OxZoPWK36atW27zLbhPRMVx0xhWqR0yFRTlaM RUjS+/5ukYAmwFeliiiJzgjsYcRhmzJXeAseByAuWKiias3jIWcjHYrWVO77VqA++mfR LVn2n1+C0eN7goUADfuE5eYtk3Od7gXzFGbw7uFz57RUtX9rHQraym7Qi5tqt42kr09e NlUcQ6eqxVNRHg3jdvFmWhBsFhqSJnd23wz3vRjO26Dqp/3zyd8vHxc+aO7/K0tzwxK8 I8n+r2uVICI4UWzDS7/t2O157yRryCQHMTyxQCz236IO6J1HInXp8byUy4abFdCw+ei6 BDCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780395412; x=1781000212; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rCb8DxBgLNYKl2se7nFRUFkwYJO2PqG9toAr7Dgva9M=; b=XQqF7nGsHSQyHvrwkY4VpCImHxB5zOzCpGLAXNGTiqAPGkBumMtlbct8iJy8GUZeYJ MOwFhkpN4vmAWK4cW2X/XrzTJzg1AHDPk+VmmkYNaVOCdLri0h5NPjVEYHEJxKMdmw7Q 4UPrSqn+wqXLxIr5H8AoZd7Z9erEO4UUvA3VrPy6dMse80yFow67Wu6ETAiDJZQs7KaR txj1+XZLYzFs4CkZ5DB2sdJz9TEotRJYOtqilm0FYS5LPl5iUigMqBR09/cpENzbIaVZ /4Zo2rvuhJZ3jUPyfEjA2RhMNGcaOk+vNBt5vaDY0eR5uKAi+Afy6MNzmT43akHWOup0 SFSQ== X-Forwarded-Encrypted: i=1; AFNElJ9qN5t5RhYO47RFxGwn/NNIiL3sAhSMfK5u+XxQglFXHc8danFwacyObasEG8SCkUpLkumoy2dRHTD1NnY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmgvmc4K626dO5iddyM0Ic1UMdJ6FmQDUsy47eXToJU1ZpzRLz EtxItOyztBDrkpx/4wVo2Y2bs/freu7YeUK/I27EN7Syw1qvkpGo2VW+ X-Gm-Gg: Acq92OEoKtJ+v3RD6I9+RmYYpdcdPWabsiFVTsGTSmDfNnjOPkY5eKjoUEPXXIQ/9h9 y5hOTs6LgziDoUQxXNFeS2NEJINRSIQojYtvZua9LHYyAQvvWDImpdUleK+zdgfWRid+mmd1zb0 JPV27/qFjmxEELnYCltFxOXRf/vYaJFPvLd2aVP/VJb1+kGp+qyliZPlELoPxfuktJTMFdw/zWw lXL1YVBDg2vPg2rsB980161HMAOIE/frc7E0ZUxVDbndMuuzvR5TJz90D6lumdf/Pb5cGvAV/zN pKRu1sGoIGkk9HiW7solqjMedATOYqtykcGxM410+5u7btfjM1s3cG9qltw4quIEfQqh64ihBjd upsvUHOCb7n0twmP5pncHKWgSmmUQKtDx1nkl4tb/sN0u5Z0ZbIfGIbq510geOKrhr2RY/MKFFS rVyD5hL9gJX7XfYRshoA0vIB/puWJe+fAfVMI/JsRzMLukcHZeWEETYvXsxZpYRt3krs6b X-Received: by 2002:a17:903:46cf:b0:2c0:c625:400d with SMTP id d9443c01a7336-2c0c6254383mr111686365ad.37.1780395411951; Tue, 02 Jun 2026 03:16:51 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239fd84fsm132766305ad.23.2026.06.02.03.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 03:16:51 -0700 (PDT) From: phucduc.bui@gmail.com To: Heiko Stuebner , Mark Brown , Liam Girdwood , Krzysztof Kozlowski Cc: Rob Herring , Conor Dooley , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 3/5] ASoC: rockchip: rockchip_pdm: Reorder clock enable sequence Date: Tue, 2 Jun 2026 17:16:06 +0700 Message-ID: <20260602101608.45137-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260602101608.45137-1-phucduc.bui@gmail.com> References: <20260602101608.45137-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Enable the 'hclk' bus clock before the 'clk' controller clock during runtime resume. The bus clock provides the register access interface, so enable it before the controller clock. This also makes the resume sequence the reverse of the suspend sequence, which keeps the clock ordering consistent. Signed-off-by: bui duc phuc --- NOTE: This patch is compile-tested only. Please help test if you have=20 the relevant Rockchip hardware. Changes in v2: - Clarify in the commit message that the resume sequence becomes the reverse of the suspend sequence. sound/soc/rockchip/rockchip_pdm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchi= p_pdm.c index c69cdd6f2499..8f78f7bc1806 100644 --- a/sound/soc/rockchip/rockchip_pdm.c +++ b/sound/soc/rockchip/rockchip_pdm.c @@ -422,16 +422,16 @@ static int rockchip_pdm_runtime_resume(struct device = *dev) struct rk_pdm_dev *pdm =3D dev_get_drvdata(dev); int ret; =20 - ret =3D clk_prepare_enable(pdm->clk); + ret =3D clk_prepare_enable(pdm->hclk); if (ret) { - dev_err(pdm->dev, "clock enable failed %d\n", ret); + dev_err(pdm->dev, "hclock enable failed %d\n", ret); return ret; } =20 - ret =3D clk_prepare_enable(pdm->hclk); + ret =3D clk_prepare_enable(pdm->clk); if (ret) { - clk_disable_unprepare(pdm->clk); - dev_err(pdm->dev, "hclock enable failed %d\n", ret); + clk_disable_unprepare(pdm->hclk); + dev_err(pdm->dev, "clock enable failed %d\n", ret); return ret; } =20 --=20 2.43.0 From nobody Mon Jun 8 03:17:04 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 702623DA7DC for ; Tue, 2 Jun 2026 10:16:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395419; cv=none; b=WGx+nkPCeVnyMJ9uuRAtRhwqy6qFzXetkUecjFknbtKlRNdwMXluNTq2bkLpm8AYLVtfUt3mhCI3RhrSIli/bCVDNWV/DvGfMqxVmlHHfs+xWuDmq8Fpf8Y6/ySaAKqLGzSwvgS3S3rs2haSP5Nw+GYeXzLD+ThuTrW1eSA5nPA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395419; c=relaxed/simple; bh=QA4yfPP1XxGkqqeUczCeaNMxgcEitZq5JbfLWgt6jZ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UATR9xvRf/pdNAuAntRqygOlg/uXGwHRa1NCYGTKm0/E+4TBkLJHY8CITCzEGxJRY+3T7K8XFbO2aNVR9VFSMF2EXI++Fo2BGfSbmgsKHj5Ldldqb1zq+EETFUUp9X/kNzIPD0Lva2/Wdqdx0RHyqAS6AlyAHL3FMS71wW1Q6DA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FEUjRwTQ; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FEUjRwTQ" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2bf2e8ccca1so22879665ad.0 for ; Tue, 02 Jun 2026 03:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780395418; x=1781000218; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GPHRLle9I7Nd/qZunsQNy1JsrfMY8rVkIYFRWvNrhY8=; b=FEUjRwTQ6cGEhrfF5peAmdh4DaasOBOvZfy8GSJgr+l3a9UPta7MbAO7+1yjShXv+h RR/2Eqd4LGyZWYyCYdU5mMusj67V9/L2m6OO5IUKfHlSsdkjN3KRFUy9akrcM1/WNr5U uyYFo7A+rbTWi9kjIBz5pdCfyg8erSC8E8z9EnVak/UAYcPCpdrUU7Rfp7Z7OpWznI6p ZF8sEVLlSY95KpVmuXh3NE0RT7hqR+v47k4PKGM9TFWkZelJ/8UCTWlGPxpAtbj/3O8Y 63irI1YOK3Rlg3/GmZUeCHGGUcH7SVQVkGsRYqTB8zvMp5xQMds9Li5/HHQgNh6PPbHa 9HZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780395418; x=1781000218; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GPHRLle9I7Nd/qZunsQNy1JsrfMY8rVkIYFRWvNrhY8=; b=rCkQdtnwWnV/B4ZugawPfi/DIcT582lVUBwPCI2yEFLx6As9Y68ZGFnSlFSDPMfl9p Kd5u9Kv7rSA38h45Rrwcq/ZcPjNObrcLDo0ov+7epyOuomWLcnyl58G39UhK7Pl3OQaK Xd6uEw3KqiHUgheNRvSxP1dmowerIkWM8vKIoKHYPd80Ub7hgCLXk+Rl8c60i86Ekxpg Z19LtNNmpw+kRQcu6As3H4QN4Y+tQUXBFS0AURl7CiUsI834koVluZkEIyzHBO7c5rDz yIajbahUKJVfR4+XZYAMQrqF05jkAlRVoHwRXOZc17LDa9kV69qWJPauT3LWem7UJtu+ 8PxQ== X-Forwarded-Encrypted: i=1; AFNElJ8wcZXddfVFo4UZCE4G4W3+k8Lag/U/1uoKSyTmNtO64W4qzy8xM83zLUa8ruSu8+BaL6aUEjt69K0KSv4=@vger.kernel.org X-Gm-Message-State: AOJu0YyYc5x8foFqTUsElNgefJNuWxhSTW0XrIJLlMefbB0XHM0I6Qdk iSNFo+yuDgZDIzpWR4aFRRg7IrXERAt3bAXzmKJMtHBFNH5gUT4kxYdu X-Gm-Gg: Acq92OFOg0lkvFeaXD6H3sKZQAtCoRY+Is2nl7W5zioFqdd+pnB9wck6dSScrzszzVS yiZ+ESUrnod0QSNcwZ8divRsXv4xYzGPJ2wgCUrGp+X5wudKqGZXxdec3fDnDVbdf7xxafKQMsx /CWUeQIVeeb1Y4rYauQCQceLLTm0rQ42awbwjFjQ1/ZX4O9J8UQRpJD+nWjG8u70vR8Ayz/jxvu zTgaQJBNutsZ237drX2vKHItIscAS2Vh1wQKy1BKA12qnntKRBJV0nmHvBQ181G3QvHKmkZ+Q/x oI54YxpQVe1OdEBYQaZoI08EI3s1H8nUhyy8vrvnmX3Txi7l15AuZOoqjHPH8GT4FYjsExItAL6 Fwqfty5qKuAao+2nhvnVBEWEuiXaYl3r+Pyj/wPehLy8LvLWKMC5W1m6g2BPh8lP9i0NfgZc8uq 5OEld7Z9GZ5bQqfroI2OKsDY1tpWIuW1ElQnsSJDHHkAdDCjbrteYr7kaBOa5c8fRWnKnx X-Received: by 2002:a17:903:1905:b0:2bf:23c3:34b2 with SMTP id d9443c01a7336-2bf36867d31mr173447395ad.32.1780395417737; Tue, 02 Jun 2026 03:16:57 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239fd84fsm132766305ad.23.2026.06.02.03.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 03:16:57 -0700 (PDT) From: phucduc.bui@gmail.com To: Heiko Stuebner , Mark Brown , Liam Girdwood , Krzysztof Kozlowski Cc: Rob Herring , Conor Dooley , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc , Sashiko AI Review Subject: [PATCH v2 4/5] ASoC: rockchip: spdif: Restore regcache cache-only mode on sync failure Date: Tue, 2 Jun 2026 17:16:07 +0700 Message-ID: <20260602101608.45137-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260602101608.45137-1-phucduc.bui@gmail.com> References: <20260602101608.45137-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc If regcache_sync() fails during runtime resume, the driver disables the clocks and returns an error. However, the regmap cache-only mode is left disabled. Restore cache-only mode in the error path so subsequent register accesses continue to use the cache while the device is inactive. Reported-by: Sashiko AI Review Closes: https://lore.kernel.org/all/20260522103713.6C09D1F000E9@smtp.kernel= .org/ Signed-off-by: bui duc phuc --- NOTE: This patch is compile-tested only. Please help test if you have=20 the relevant Rockchip hardware. sound/soc/rockchip/rockchip_spdif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sound/soc/rockchip/rockc= hip_spdif.c index 8de5b76cfe79..7f15bc7f8f35 100644 --- a/sound/soc/rockchip/rockchip_spdif.c +++ b/sound/soc/rockchip/rockchip_spdif.c @@ -94,6 +94,7 @@ static int rk_spdif_runtime_resume(struct device *dev) =20 ret =3D regcache_sync(spdif->regmap); if (ret) { + regcache_cache_only(spdif->regmap, true); clk_disable_unprepare(spdif->mclk); clk_disable_unprepare(spdif->hclk); } --=20 2.43.0 From nobody Mon Jun 8 03:17:04 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B0A2C11E2 for ; Tue, 2 Jun 2026 10:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395426; cv=none; b=DkxvgP11gJCnO6offaNr7lZhAK94vSnjLFZq7/3BCcYnRQD4mGpFry0H8dvZLD2VVFWtTFj27JS+zp5f1JB0f47KfIbigfRiQfvBnHZbOqOVZaKfBuSs81l6VYoZzzsXcuT/DOdrHNoqiF8D6b5i4C8Kx0z5CsZH9zWJ9OEhrSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780395426; c=relaxed/simple; bh=FTgoAa+xu/joTesi8Jf6xXuDhGFQReh7G4WALnJ4OLw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JNBesrK/W5TrqAmZlsUZaJBRjpQjw16z6Pit2ha5jKceZTqlX26Aeka645ZXfKrFIzziKKk3yeC2VQHVVVherTsBlU98CDFcNUjMi7yxrZq/mg9ErzzDBCBwW1CMq8NSBvJcj2mN89ogUXcvDemSMjLOZhn4fgchOFpPpu1U7NA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s4w3B3nd; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s4w3B3nd" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2bf1cda2b17so31781185ad.1 for ; Tue, 02 Jun 2026 03:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780395424; x=1781000224; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lT+JLRZTXmUkizcf52XaQYhGVpogr5HSaG3W4C826mA=; b=s4w3B3ndAsTBMJgGpJqRtyTgA8iCBV6fHNIWsezzuCsvkeh/o6FsfvDPaBdT4g1f/s VOoFrenophzfqWGpU2BJXOSoEolOutg7nhwGOLtmWbfeUol+u7vkTOL/ArZBJhJ0pz5V AMOFuFuzjh8sDHnlKti8xEKAKUl3XH1Mxh/m/Lvn31SoLsZtaVoPIu1gi6znlYwUe102 rsFKtT70FVJb/2h3pjrNm4Dm6oUdJOtBnyu6KB/CHXBxfmr6nFXLHvIr53kRTLYLWVUG 2EswZi0H0p4hImdROVcCX7psy5CgqKNkOS1MFvG7J4eS/YHhW5d8h156LQkYRUDAEw8h 6pMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780395424; x=1781000224; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lT+JLRZTXmUkizcf52XaQYhGVpogr5HSaG3W4C826mA=; b=mrto6M0kc6A1fNmvu3HuLbIogEUOVrkI6b9Kiw9lJJrctftl6EX1MR4wcYuIdmBNcU 5IlHFadDPmrDom2xvc6EpNJe8nsxeNzW4+YApVPcLv7GdNdyd6GRdcKShz+mbLZRpP5n rRwavJrIp8RUrIg+luTCOYSeFapmWSnpQcA6ikB6XEtvrSbGoaHN3CGgiz3J1MBcICKZ WCnm+R4Iq6mrfsL7QW1v7fDiCKnS3/AxtFJFEM/s2GnQAyKakrU4h5PGdtilt4+6ae95 1jVoQMKll2GD4Mk1aQ0Fbpt+chd+l1d70Xs9OfQJgyMicsWTsiE6/a0P3yoPHOWeCXkW POiw== X-Forwarded-Encrypted: i=1; AFNElJ9ZLoTGlZeXtE2EkROGwXX7pIM6yu+r3ZXWlBDigfd8/1AbS6D+fuqJm4klF9iy+UKK7zIV6AyojqWZfe0=@vger.kernel.org X-Gm-Message-State: AOJu0YxPjRD8xGjHXdTpeltN++SrppwnMoJ9Ww/dCZfJqZQT5LWvLj8Q ryytoGy/r0zpVlO25yC8mzzcYq7I0Cke7abO7NO4/Qp+jebwS6pXz8O0 X-Gm-Gg: Acq92OF0KW15zYfzIK41Zws5hdjtby15NcO9SquR36rQDm4DfD3vZjy/NDaKAeEA2qs jMJHJvELH/0k7w57L+8VltlL6NyrmtD3aiW/DoeF8ThtTQVsqdfpxiBmy0U/WHmvut6JpxdThUH sC1tXFwWPjM/01gPjMEoHnl46YeS/ZUm7PjWORMB5TtP8UmkAm96MGskUa+ny/E9QwwzPom66ft lItQ4u5OQTA0mXrScmRr7Cd8vCOCEjBYZ5pQuPcVc13zDatjbHkoectC1QbNZ+B2QaYQUVauJd0 OuapG5hZnHyXxfw1z6/pC/jBnmiWu5f8cQAXbKO1dEqT4J0t3IFlALA5FN8suOMcuEdv5d6CEGD /M/eVrhRYRYWZ4usjezCaK/MZqA9c2idNmSaurY7augbP5f8Q+pzctutfHg0/60wNqthHQztJKn RTu4R5dWf2ePuzS88B1i1ys4LPHI2viC8fOtz4nJQMsed/bVykvsACCj0Bb1FyNXOu3sYK X-Received: by 2002:a17:903:3848:b0:2c0:a4c3:d7a with SMTP id d9443c01a7336-2c10ccfb095mr31503255ad.26.1780395423749; Tue, 02 Jun 2026 03:17:03 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239fd84fsm132766305ad.23.2026.06.02.03.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 03:17:03 -0700 (PDT) From: phucduc.bui@gmail.com To: Heiko Stuebner , Mark Brown , Liam Girdwood , Krzysztof Kozlowski Cc: Rob Herring , Conor Dooley , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc , Sashiko AI Review Subject: [PATCH v2 5/5] ASoC: rockchip: rockchip_pdm: Handle runtime PM resume failures in set_fmt Date: Tue, 2 Jun 2026 17:16:08 +0700 Message-ID: <20260602101608.45137-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260602101608.45137-1-phucduc.bui@gmail.com> References: <20260602101608.45137-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc rockchip_pdm_set_fmt() calls pm_runtime_get_sync() before accessing hardware registers, but ignores its return value. If the runtime resume fails, the function continues to perform register accesses while the device state is undefined. Replace pm_runtime_get_sync() with pm_runtime_resume_and_get() and return early on failure to avoid unpowered register accesses. Reported-by: Sashiko AI Review Closes: https://lore.kernel.org/all/20260522110302.349421F000E9@smtp.kernel= .org/ Signed-off-by: bui duc phuc --- NOTE: This patch is compile-tested only. Please help test if you have=20 the relevant Rockchip hardware. sound/soc/rockchip/rockchip_pdm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchi= p_pdm.c index 8f78f7bc1806..115e90d3bbfe 100644 --- a/sound/soc/rockchip/rockchip_pdm.c +++ b/sound/soc/rockchip/rockchip_pdm.c @@ -321,6 +321,7 @@ static int rockchip_pdm_set_fmt(struct snd_soc_dai *cpu= _dai, { struct rk_pdm_dev *pdm =3D to_info(cpu_dai); unsigned int mask =3D 0, val =3D 0; + int ret; =20 mask =3D PDM_CKP_MSK; switch (fmt & SND_SOC_DAIFMT_INV_MASK) { @@ -334,7 +335,10 @@ static int rockchip_pdm_set_fmt(struct snd_soc_dai *cp= u_dai, return -EINVAL; } =20 - pm_runtime_get_sync(cpu_dai->dev); + ret =3D pm_runtime_resume_and_get(cpu_dai->dev); + if (ret) + return ret; + regmap_update_bits(pdm->regmap, PDM_CLK_CTRL, mask, val); pm_runtime_put(cpu_dai->dev); =20 --=20 2.43.0