From nobody Mon Jun 8 04:25:04 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC9923822A2 for ; Tue, 2 Jun 2026 07:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780385668; cv=none; b=C8uLfyHnyk0/sMofZw5AQhikmH5MiiUgDTjFGdjjuI09JvBgGfnfaOVGZ6qtyzn7O3masDx1jg6u1642MOzITx6EdX8RWBVOReXbLjYnGwxBOiKjdFXeD1//7KiiSqz46SkT2B1ZCJAU7qd3mccvWUBBxm5Uek49WJvtmTQO/XM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780385668; c=relaxed/simple; bh=YVirmTDYaEkiYsJPJUV6u+ccJQzQNksQiW7zP4Dw14U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VEh9zJRD0pyu6kleZGs2ZoGt9r0rGOUOz+JY9hOA+TwmxuXGS0EbGreD5x0DJNaLRHMjxm5igwlQBKF1YdfZIsQGm/cN7z7/D5lk3HTDNQ/aZ8LUX/OWJquv8qm1cTuMRu3MUfm3BJK01aqgxlIpZy/UVXQ5r8HWaEHWLI5fmZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mCCwsyJC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YpaWI8l5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mCCwsyJC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YpaWI8l5" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6526Kuf32884626 for ; Tue, 2 Jun 2026 07:34:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=JjC88RteyMdNmZiiaQdoQEc/10QE+WI+V+C 6wyLn56Q=; b=mCCwsyJCStiVArdcAakihN+lVucb+RmIJ+esFp/Lm/ZZaBRBOu6 qOY/JkoG/OmdTPNQ4MSjGpspHTeLEPUhXfbVMS6F+5oWpFjEsZbrdURfzp1otOI/ 3T9pauBZz29MgxxlljYGnvdbLUUUIqG6sjn/tJj6TlPGfhiNZZhvWZqLCqY26h/y w0YSTceUkmpxzikPzKCrNV2WCvvzIjDV3PHvu/AbAUeLSECsrVg4aEtpYkvV5JlF cU593s5cNY9XexgMRLTxTbl2REErDsLlp3flxOTFC30m+o8sN8P0y0cQvMk8OzR/ bJ1iHW8enyFyn/9yW+eg+0+0GS777U6Ne7w== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehsu109f3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 07:34:22 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-516d6cf547bso44856161cf.3 for ; Tue, 02 Jun 2026 00:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780385662; x=1780990462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JjC88RteyMdNmZiiaQdoQEc/10QE+WI+V+C6wyLn56Q=; b=YpaWI8l5bYG5dP+5ojcB1/pgG8oUv235TSCdMTe2F3xV+T2zJm7GWFpry6XbvTnsmK 54ukSrzDVya1+mrRZgQTjaLbPg/8Tbf/THnyLqeacdYPTuLHOPhKzUfPEvunMV0K4UMg 8YktDv0kOFu7uIh+uD9uUY/1TP7ydcZx7QqiexaD4YUmMUEyg9HzJDeTqqYBV7h/niIP 96vFY22INf3o/kZ9mBQXJSl9uHaTHP0x4MMEM3wO6KnyIgz3i0DFoOkfNeI24TNNb5US V0R675aTvOwSASn+fSDYdkKKZNzNGSDSfx8EOT8uGyYcosFVhBvQ/dnc/cQhl/LRNbmF Dq3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780385662; x=1780990462; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JjC88RteyMdNmZiiaQdoQEc/10QE+WI+V+C6wyLn56Q=; b=sj2u/dwkJieZuMBziRksE5uSd5LgSDehz6vEEagclh1FLUJbdxgr7uoSyRR4Vd/kjR dl75d3hs3cd5q18KntNu6vgCMKtdUvgpjhHSCWE8NyNOF7XrCH9Xxgwc1cz8/27Z26Db fG9VaQQAPID/AgCTJJxWqgRI4LGwAB0C/RoXEhOxds7ppb52zRoH4nxASoo1pvuRZoaz WWRN30Zt8uwjrJ/z0um8+0ZZMumakEJb1aRGS5td4RZ8ExUArGfx5P2ylUhSxHc/yyY3 DeHewlkezRzo2E5QFG8FRUr/nsyKwxbeYM6wEzSR0j7INqUDLiw0sbH4PC5t9q3ThZbK WtSg== X-Forwarded-Encrypted: i=1; AFNElJ/csjEpQa8J6nV+JxT6JP7lYmX+CNOoHFRvYA/uQnwnhhES+KuixIU+GDKp5nnsi6VoFYaaDj4wglgEYwc=@vger.kernel.org X-Gm-Message-State: AOJu0YxAudwEo03e7Vw/UzGEc8YQNx6Krv3iaYkuU5hBV828B6DDf4Lx h0IbPO9eE+flrfzCqQb5s3xqWdgEjGvV8XK/rI6DJlgZyPYTyL1CF43iJjSwxJo7kh75HiF2Uo9 PBoAmFqSRAmWqsg/Cfm5HWtv378tkSgM/26i3GS6vWqOiLQkDq3trscmpfCYH2syfZi4= X-Gm-Gg: Acq92OHXP+5rCcGgedYno7yXVWUVbF6SSrmf71BukybDZ2rhT8XCd7oER5BZ3hsRGHl JRcaR+6mGTrqEGiZ6kGaCCKRTrocB/eslEgDMClYROPu8CIUh7YAAbnLLRtMreN3ZL93DS7+wam yNVWUVsz4vZ3RzaurcHKKrMTjvY0hfKnf6RPchcB67iNW1VZSCWOx3uWm9MpWpdIF91xdu1vZ28 3wjfwmGBNY6Bpw44O4a42qFH4/KV04ORjErg6jiB8kwoIYbbZ3kL5r5FjLk4MTYuqLMIER5myIc fyewx4F/9DEdfUBnDPPKW8UqKX86c2qPkGUqpx8sIKy4VS3vOJw7lr8Tu1jAGaqm1ZBkWdpLV4g l0W7ciSuAIVWIG0NL6yiczf/HeY7tEkOHcxQpdm15pJcKCuxUaeobgQoAcPDFvXqSmOa5K+jTm/ xPs72uZ+72NIVJ/A== X-Received: by 2002:ac8:5fd4:0:b0:516:daff:7f7e with SMTP id d75a77b69052e-5173a80ffb6mr203814411cf.48.1780385661978; Tue, 02 Jun 2026 00:34:21 -0700 (PDT) X-Received: by 2002:ac8:5fd4:0:b0:516:daff:7f7e with SMTP id d75a77b69052e-5173a80ffb6mr203814161cf.48.1780385661519; Tue, 02 Jun 2026 00:34:21 -0700 (PDT) Received: from brgl-qcom.local (2-228-54-83.ip190.fastwebnet.it. [2.228.54.83]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34a0403sm32453424f8f.6.2026.06.02.00.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 00:34:20 -0700 (PDT) From: Bartosz Golaszewski To: Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski , stable@vger.kernel.org Subject: [PATCH RESEND net] net: mv643xx: fix OF node refcount Date: Tue, 2 Jun 2026 09:34:14 +0200 Message-ID: <20260602073414.22500-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: MdBFkVQ5Rk--WjQyb0cFfUHabQWlOIVD X-Proofpoint-GUID: MdBFkVQ5Rk--WjQyb0cFfUHabQWlOIVD X-Authority-Analysis: v=2.4 cv=MKFQXsZl c=1 sm=1 tr=0 ts=6a1e877e cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=F4J0OHcPalsv3C1teIDEwQ==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=2glh-Q7MoEu8omcI7JcA:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA2OSBTYWx0ZWRfX95lT6SeHigZk LoFZllBpAxYxEajpm/cSqJMd5RIz7b+Jl38Q2ZxwuvUBQvtlEmIX1XY8jGXJrO1OJv0GkctUxD2 ku9ST1dhwpOy6X3ZarHyXBmZE3/8yZZFPaPNM+m1PVQy/N/ovkZj9DYEjoL16znbf1EeUt/Lnqc 1c7Kxi4wibLsTUjNnbTKRQuDDM5fTWEva0r711C0eGYZRhA/4JY19JbaJsvRIbzTDmen5oQYa9B 1MDFIVQgyf0vdsaX9OolE53VZZecwBL3avayipbpUZtd+npA01XHJ5LBgPvqbqDhn37cgsLLXQp A5Qva8AVnvY1BOG7CZrtcFSgBDd6Us2/h/dsCKn/GLJtDYXUaEVY0DqZ4VshHiGICHdEe2gcP4Z F/83plesOWEBIv9IOmR+7PHQME/rfXE8P77CeslQP004D3sJQ/GfDKgohsQ/zYFSdu3V0ATZ7lc ZtnJpb4MoToOU2Zf1+Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020069 Content-Type: text/plain; charset="utf-8" Platform devices created with platform_device_alloc() call platform_device_release() when the last reference to the device's kobject is dropped. This function calls of_node_put() unconditionally. This works fine for devices created with platform_device_register_full() but users of the split approach (platform_device_alloc() + platform_device_add()) must bump the reference of the of_node they assign manually. Add the missing call to of_node_get(). Cc: stable@vger.kernel.org Fixes: 76723bca2802 ("net: mv643xx_eth: add DT parsing support") Signed-off-by: Bartosz Golaszewski --- Resending separately as requested by Jakub drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ether= net/marvell/mv643xx_eth.c index f9055b3d6fb10..1881583be5ce2 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -2780,7 +2780,7 @@ static int mv643xx_eth_shared_of_add_port(struct plat= form_device *pdev, goto put_err; } ppdev->dev.coherent_dma_mask =3D DMA_BIT_MASK(32); - ppdev->dev.of_node =3D pnp; + ppdev->dev.of_node =3D of_node_get(pnp); =20 ret =3D platform_device_add_resources(ppdev, &res, 1); if (ret) --=20 2.47.3