From nobody Mon Jun 8 04:24:21 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1565F26FDBF for ; Tue, 2 Jun 2026 05:41:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780378903; cv=none; b=chY8crWT6eXDUykVvlMUcPHrEesILHU1diyt7I3I2e1kFZ/BI2oz5pBGrpD6MlutQTfpRUBqHZ6ZgYqb0p/bD5TepaFcoBARBDd9MHPa7ct585KC2uYPDiNRVN6Ht5GabM+DKR/VT791WAvoJZ96CpDMLatIQ6NJpnL1qV8cp00= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780378903; c=relaxed/simple; bh=n7V2vfC1JbI4WrA583Y6PpTcqWcjqmKB0sQIXUnDtEc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=S2AF+eMmhXC2bWsQdpGDN6p4+rjRKspo8JMFZMjSV6lfsJnDgYIZc+kosu2IV2inFoIAcn9t3MPa7LY3OmoXE6XhWnV2kxnkXthGbe3hfcYC4RMIx0GDuSKV2QvPVj1RsRAzI5IB/xwQw5rBDS0GbAbSf2PcEsESeoYsDV59+Ao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F4kx/Yrz; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F4kx/Yrz" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-8422c327755so1168602b3a.2 for ; Mon, 01 Jun 2026 22:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780378900; x=1780983700; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=b87cwHT2BrTigjVd+6bwq58aCoITji6mCL2XtGIvkXs=; b=F4kx/YrztuquMauH+60ndA5ypfuxlqfdZPjfAHjDcdCTIDEU60N1qzQPzbvihhxzl2 Jl++Er5WItmtWxzcepURJgCn3GlDsh03IVMuSTd77kW8oYf6jLbLsCIqA9QqQ0MC1qLR C1nwYLnExPKOGLmYvyGMBuBxgM8EQXfvG5Xlcgaw8w0RoB37zc8V5ZNRefM6a7GlQDNh +gS2vqPa18d0riFTC3rGCmtiNlYqswVktX2b0NSrFyq73vrokmdU0+6U40JyjQpzWV82 ptl8PdcWBrG6g72V+tklqOWkaZONIXYKy1C3dqCKvK+/Bz15r2pttNaOjkAx97vW7Tku 0i7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780378900; x=1780983700; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b87cwHT2BrTigjVd+6bwq58aCoITji6mCL2XtGIvkXs=; b=gNJCOwxHOCGr7fS7hIw3RDkvfIdEiJi/0tLvtEXCmSW9Oo+nxjqdbTV23xR9opAZ6k +3WhxripS2ZU0qdsSC4znjbcCu3dOvkp1BwnmJmNQ2cIrZVz6ij8gxa44FnyQ6VCLmSa tgIjJADlw9+T96Wox64h2aCOsB+n/SEdTG1HU7cAB9p379ynffGPshF78JyUHxn1PvcA eL+NtzSHdo63BFh1sfVtoRXr9o6Uu3Y1xhvOv8VhAX+1GbxpyU7qJLzHlKJXWbDlvHYv 4OL/GV4+rgvFZhRRdhUF39yCJpuJoJKP+1KK7/Exryr1AYCbww7Fseqt+MP8YsebBUOp 8SOQ== X-Forwarded-Encrypted: i=1; AFNElJ+nEAhLY3N3X8pYLW9/uWGg8fibkcA2yZnaB60PIW1QqVuztN5OuqcLXOSPs3EjfMI7FpUFHpZKi0IGl+s=@vger.kernel.org X-Gm-Message-State: AOJu0YyjNVb29TLW05kRka9PdBiOjkbmeclcnzbc1lgMKiS1W5hTpdhm GagTNESPJ4NdmfpgI6lwqkdIy9J6/K7u63mj/E0vg4j2SwiL1AF0UevE X-Gm-Gg: Acq92OHDeW4LIRZbi+BNFR8We/8dd86BIk5KcBsmJ0GFKNCXPHfXE2d7E7pp4WtCw/O 5a4iIi3kv9/ZtrVxDSUaionMTkiIpgfyMPnjSDqHkeqngeBIQ4lq7bkbpJ2IIIjxgHctf7gP3SM 8tKB3t+8pLVmtiVRQzyfc7YVvsI54pCJkhWTbm/9kdMmkRHjldz6BlCdoVJcLnRD/qnaZz3AQnp Hf8CiRxeQXWRCUDFmZvrIYzHzUWdphZ/cLLZXHWDiLAKA2NsKzqVkk0PzTbBmmWtglPAMtNm71m AQtnDxrrM9/6jXekwNxjy0YlQtm3rhqyIpQFyDFqfsva8lPHoxwkIBRNw4iOXo679fOiJdMa2eF EoQJqcS9aA+BcGbd9/ipEEpgwabBljcibBRgWt4BTBSyXMODoh64AkeF4agDTooGNj4KhyFChzg J+OoiSTdx+ZQYfsKjQ3rRSheUqPRq0MKQGzWr0ig== X-Received: by 2002:a05:6a00:301c:b0:842:6fce:6171 with SMTP id d2e1a72fcca58-8426fce6cadmr1818446b3a.3.1780378900295; Mon, 01 Jun 2026 22:41:40 -0700 (PDT) Received: from soyboi ([2402:8780:1073:19a3:f977:6a92:60c9:fc08]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842596e63f4sm4020138b3a.29.2026.06.01.22.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 22:41:39 -0700 (PDT) From: Robertus Diawan Chris To: alex.aring@gmail.com, stefan@datenfreihafen.org, miquel.raynal@bootlin.com Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: [PATCH] mac802154: Prevent overwrite return code in mac802154_perform_association() Date: Tue, 2 Jun 2026 12:41:33 +0700 Message-ID: <20260602054133.470293-1-robertusdchris@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL, the return value assigned to either "-ERANGE" or "-EPERM" but this return value will be overwritten to 0 after exiting the conditional scope. So, jump to clear_assoc label to preserve the return value when assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL. This is reported by Coverity Scan as "Unused value". Fixes: fefd19807fe9 ("mac802154: Handle associating") Signed-off-by: Robertus Diawan Chris Reviewed-by: Miquel Raynal --- I am still not sure how to test this change. I look around the function and use the previous error handler as a guidance to make this change, like error handler for "No ASSOC REQ ACK received" and "No ASSOC RESP received". Thank you. net/mac802154/scan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c index 0a31ac8d8415..300d4584533e 100644 --- a/net/mac802154/scan.c +++ b/net/mac802154/scan.c @@ -594,6 +594,7 @@ int mac802154_perform_association(struct ieee802154_sub= _if_data *sdata, "Negative ASSOC RESP received from %8phC: %s\n", &ceaddr, local->assoc_status =3D=3D IEEE802154_PAN_AT_CAPACITY ? "PAN at capacity" : "access denied"); + goto clear_assoc; } =20 ret =3D 0; base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8 --=20 2.54.0