From nobody Mon Jun 8 04:19:59 2026 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5F47356768 for ; Tue, 2 Jun 2026 04:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780372877; cv=none; b=LnB3/QIaIN+faVdXOCAUO7YRFOye0uJKDEd8CdcqZfBr9aTZa4XF4ECIJisuzdrT3rjIZ2LWxkAJvCVb8ly2Z2Vd8r26q3kzv9Th5OIE6JGwN+fkob8TrXxOOPjvkUlAfhAiEhNi1yYDJVIaeDGCD+qUjXseiU2w8LndqN/SBUQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780372877; c=relaxed/simple; bh=w4RrS/1X/Cdl103izoQ74z9z3K+9WPbGCMHByz3pGFk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=er+/GcqWhosiKY+pYT4O8WG2mGa4yp83B/tdFDcZYXDUsHAfLL6PpBT3j04W5I3fovTS/rZkHKnk/OFny6qBEzp0Jvb1BlX27/w01KdLfpr/okexpM9E3CKK4cL4iig7qjIoZGuzkOockzaNuirpmLjwRBb57AngAeaQOa2zzAI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CUeiHmsx; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CUeiHmsx" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-91564c3a968so157698385a.1 for ; Mon, 01 Jun 2026 21:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780372875; x=1780977675; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=A708eqRYyy4JW3JcLFUWL9EArqHUNZcp8V4wc4RJXSE=; b=CUeiHmsxVwpsMQJioi1ZbsJcUZZMsxfucQsAftGqMwZoba1k8YbbHKmjWBDW0sl6OF 56xHtIx6kZOOUWQTdlZKh0sgTXvbevMl3eT8NQd+xfZn/1xU9UtCI0tx3brfNl+oFyQj WWTIKMZjH7+XXRYIWCRjEjAx28TS0s+ATruVZlXjV1PQ4azSKHsy/HxhNj4F8be0lL+t FYLvRhRUTAUbvj2d0eRfmJocSEJBiI7zOxvCkxtgFUV8TCD4Cb00AO91CqyAI7fNv1Yo sqhmF1WMqkXmI4rQ88ojDfZieQNWf7JQUxdjT/BL0pC/cdFpWYUnkNdQs4/9seL9rhEM 3cuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780372875; x=1780977675; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A708eqRYyy4JW3JcLFUWL9EArqHUNZcp8V4wc4RJXSE=; b=efZILeyicgDAosHk3o+NtzbzXOlu0OOlCtnnMOIJDGmA2W4fiM1Wv07iHMto3fB1Lt LlhfPIo6hjuotovsOsQ/ugk5dJPH84ARrjvQWchHX4y1eMmknYeO5PXhIbxpc2ljBSdP ws3T5z3+KNcOBt/ndMYAzdT0b3/GtI+xesmsVHYdUQc8MeeugqC9yCFZmJLtVESjgX39 aVEGeDXXjLWXBDNYu8GcrvfiNCWLo8xIPlKCpbt5CDzGY+3u65k12l800lzyuQmg8EA+ 6vDjfOwxu0Uuby1SFT8p5snF8O6PtxH3wBB+MgBCFCV8CPAFzuuZqPZJ1EQ22uj56qY8 aAPg== X-Forwarded-Encrypted: i=1; AFNElJ+NCP/G9QuMkJGHnO4zgVmQ9mu+yQciyNSC2S83jqXq51N9BoPKF2SfB5QDgNxxF0dy8zxlPdIsyCN4lpM=@vger.kernel.org X-Gm-Message-State: AOJu0YwqlkPTqANAgykwx3cP5pnEqU+lhjqNY3GEBl+mEbFhmBkqKPFp GSXm1NxSPPZkvkI9EQVI8vkf5APa5vrpnJwh0dm0or4DtXGl/klXyq0lp2QKOA== X-Gm-Gg: Acq92OFPKrKdKBRb3ysehgLm96cWV53VABAKJnRBjYvVygeCqqd+XE1nPoFAi0t8JRq 2NmJMuCpKPNcKfyNQFdpsbGj0YWoqQYErwNM47g/tvck9y3zEQi1tG5hfRvuo8P5YzV9z5nY1No EKweXF1s4xLCDxAsqal1OpJJMRHz5e+kTGxofY1vuTQA/dZjb5YX0eMd4PNLidmh9QKMWMY5mAe uquIJpIGoJalJAtrjE2w/eMnzTsgGxkij60xu20SuCo/R1Xfy05ttuJ0fw05z2bmv8WSoDdLPtH x4IPwdpFjVC/T7MpLE64XMObnxfSA9V9M1zPe7szcxAqVv+pEZaA4LF+vKfSekI+U+X6m31Mczm xLuOo1lznpL2k848UiKcpszBXhCSOhTI+iab9JDuLKSQ47qTQENfYkm86dFBnMFNuQWVf/WJQRw xLFfScX3FXtk82itZWAKikGdR16I+31z9VN/xkAZL2wkRuTn+3nmxpuzsl3O9y4U4J0qSJBwu6C Ywp7H+6Dcf0eSbDjetdg2L9VG5EgPvQHv7CThKW3TT96w== X-Received: by 2002:a05:620a:608c:b0:90c:f935:490d with SMTP id af79cd13be357-915780456ccmr319020185a.43.1780372874581; Mon, 01 Jun 2026 21:01:14 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id af79cd13be357-91532473bb9sm1177794585a.11.2026.06.01.21.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 21:01:14 -0700 (PDT) From: Rosen Penev To: linux-rtc@vger.kernel.org Cc: Alexandre Belloni , chleroy@kernel.org, linux-kernel@vger.kernel.org (open list) Subject: [PATCH] rtc: mpc5121: replace in_8/out_8 with generic accessors Date: Mon, 1 Jun 2026 21:00:56 -0700 Message-ID: <20260602040056.623844-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert ppc4xx-specific in_8/out_8, in_be16/out_be16 and in_be32/ out_be32 to the portable ioread8/iowrite8, ioread16be/iowrite16be and ioread32be/iowrite32be respectively. Add COMPILE_TEST as a result for greater compile coverage. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/rtc/Kconfig | 2 +- drivers/rtc/rtc-mpc5121.c | 80 +++++++++++++++++++-------------------- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 364afc73f8ab..6d8935250c82 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1779,7 +1779,7 @@ config RTC_DRV_MC13XXX =20 config RTC_DRV_MPC5121 tristate "Freescale MPC5121 built-in RTC" - depends on PPC_MPC512x || PPC_MPC52xx + depends on PPC_MPC512x || PPC_MPC52xx || COMPILE_TEST help If you say yes here you will get support for the built-in RTC on MPC5121 or on MPC5200. diff --git a/drivers/rtc/rtc-mpc5121.c b/drivers/rtc/rtc-mpc5121.c index b90f8337a7e6..c038301fb86b 100644 --- a/drivers/rtc/rtc-mpc5121.c +++ b/drivers/rtc/rtc-mpc5121.c @@ -87,15 +87,15 @@ struct mpc5121_rtc_data { static void mpc5121_rtc_update_smh(struct mpc5121_rtc_regs __iomem *regs, struct rtc_time *tm) { - out_8(®s->second_set, tm->tm_sec); - out_8(®s->minute_set, tm->tm_min); - out_8(®s->hour_set, tm->tm_hour); + iowrite8(tm->tm_sec, ®s->second_set); + iowrite8(tm->tm_min, ®s->minute_set); + iowrite8(tm->tm_hour, ®s->hour_set); =20 /* set time sequence */ - out_8(®s->set_time, 0x1); - out_8(®s->set_time, 0x3); - out_8(®s->set_time, 0x1); - out_8(®s->set_time, 0x0); + iowrite8(0x1, ®s->set_time); + iowrite8(0x3, ®s->set_time); + iowrite8(0x1, ®s->set_time); + iowrite8(0x0, ®s->set_time); } =20 static int mpc5121_rtc_read_time(struct device *dev, struct rtc_time *tm) @@ -107,7 +107,7 @@ static int mpc5121_rtc_read_time(struct device *dev, st= ruct rtc_time *tm) /* * linux time is actual_time plus the offset saved in target_time */ - now =3D in_be32(®s->actual_time) + in_be32(®s->target_time); + now =3D ioread32be(®s->actual_time) + ioread32be(®s->target_time); =20 rtc_time64_to_tm(now, tm); =20 @@ -131,7 +131,7 @@ static int mpc5121_rtc_set_time(struct device *dev, str= uct rtc_time *tm) * between it and linux time to the target_time register. */ now =3D rtc_tm_to_time64(tm); - out_be32(®s->target_time, now - in_be32(®s->actual_time)); + iowrite32be(now - ioread32be(®s->actual_time), ®s->target_time); =20 /* * update second minute hour registers @@ -148,20 +148,20 @@ static int mpc5200_rtc_read_time(struct device *dev, = struct rtc_time *tm) struct mpc5121_rtc_regs __iomem *regs =3D rtc->regs; int tmp; =20 - tm->tm_sec =3D in_8(®s->second); - tm->tm_min =3D in_8(®s->minute); + tm->tm_sec =3D ioread8(®s->second); + tm->tm_min =3D ioread8(®s->minute); =20 /* 12 hour format? */ - if (in_8(®s->hour) & 0x20) - tm->tm_hour =3D (in_8(®s->hour) >> 1) + - (in_8(®s->hour) & 1 ? 12 : 0); + if (ioread8(®s->hour) & 0x20) + tm->tm_hour =3D (ioread8(®s->hour) >> 1) + + (ioread8(®s->hour) & 1 ? 12 : 0); else - tm->tm_hour =3D in_8(®s->hour); + tm->tm_hour =3D ioread8(®s->hour); =20 - tmp =3D in_8(®s->wday_mday); + tmp =3D ioread8(®s->wday_mday); tm->tm_mday =3D tmp & 0x1f; - tm->tm_mon =3D in_8(®s->month) - 1; - tm->tm_year =3D in_be16(®s->year) - 1900; + tm->tm_mon =3D ioread8(®s->month) - 1; + tm->tm_year =3D ioread16be(®s->year) - 1900; tm->tm_wday =3D (tmp >> 5) % 7; tm->tm_yday =3D rtc_year_days(tm->tm_mday, tm->tm_mon, tm->tm_year); tm->tm_isdst =3D 0; @@ -177,16 +177,16 @@ static int mpc5200_rtc_set_time(struct device *dev, s= truct rtc_time *tm) mpc5121_rtc_update_smh(regs, tm); =20 /* date */ - out_8(®s->month_set, tm->tm_mon + 1); - out_8(®s->weekday_set, tm->tm_wday ? tm->tm_wday : 7); - out_8(®s->date_set, tm->tm_mday); - out_be16(®s->year_set, tm->tm_year + 1900); + iowrite8(tm->tm_mon + 1, ®s->month_set); + iowrite8(tm->tm_wday ? tm->tm_wday : 7, ®s->weekday_set); + iowrite8(tm->tm_mday, ®s->date_set); + iowrite16be(tm->tm_year + 1900, ®s->year_set); =20 /* set date sequence */ - out_8(®s->set_date, 0x1); - out_8(®s->set_date, 0x3); - out_8(®s->set_date, 0x1); - out_8(®s->set_date, 0x0); + iowrite8(0x1, ®s->set_date); + iowrite8(0x3, ®s->set_date); + iowrite8(0x1, ®s->set_date); + iowrite8(0x0, ®s->set_date); =20 return 0; } @@ -198,7 +198,7 @@ static int mpc5121_rtc_read_alarm(struct device *dev, s= truct rtc_wkalrm *alarm) =20 *alarm =3D rtc->wkalarm; =20 - alarm->pending =3D in_8(®s->alm_status); + alarm->pending =3D ioread8(®s->alm_status); =20 return 0; } @@ -212,10 +212,10 @@ static int mpc5121_rtc_set_alarm(struct device *dev, = struct rtc_wkalrm *alarm) alarm->time.tm_mon =3D -1; alarm->time.tm_year =3D -1; =20 - out_8(®s->alm_min_set, alarm->time.tm_min); - out_8(®s->alm_hour_set, alarm->time.tm_hour); + iowrite8(alarm->time.tm_min, ®s->alm_min_set); + iowrite8(alarm->time.tm_hour, ®s->alm_hour_set); =20 - out_8(®s->alm_enable, alarm->enabled); + iowrite8(alarm->enabled, ®s->alm_enable); =20 rtc->wkalarm =3D *alarm; return 0; @@ -226,10 +226,10 @@ static irqreturn_t mpc5121_rtc_handler(int irq, void = *dev) struct mpc5121_rtc_data *rtc =3D dev_get_drvdata((struct device *)dev); struct mpc5121_rtc_regs __iomem *regs =3D rtc->regs; =20 - if (in_8(®s->int_alm)) { + if (ioread8(®s->int_alm)) { /* acknowledge and clear status */ - out_8(®s->int_alm, 1); - out_8(®s->alm_status, 1); + iowrite8(1, ®s->int_alm); + iowrite8(1, ®s->alm_status); =20 rtc_update_irq(rtc->rtc, 1, RTC_IRQF | RTC_AF); return IRQ_HANDLED; @@ -243,9 +243,9 @@ static irqreturn_t mpc5121_rtc_handler_upd(int irq, voi= d *dev) struct mpc5121_rtc_data *rtc =3D dev_get_drvdata((struct device *)dev); struct mpc5121_rtc_regs __iomem *regs =3D rtc->regs; =20 - if (in_8(®s->int_sec) && (in_8(®s->int_enable) & 0x1)) { + if (ioread8(®s->int_sec) && (ioread8(®s->int_enable) & 0x1)) { /* acknowledge */ - out_8(®s->int_sec, 1); + iowrite8(1, ®s->int_sec); =20 rtc_update_irq(rtc->rtc, 1, RTC_IRQF | RTC_UF); return IRQ_HANDLED; @@ -266,7 +266,7 @@ static int mpc5121_rtc_alarm_irq_enable(struct device *= dev, else val =3D 0; =20 - out_8(®s->alm_enable, val); + iowrite8(val, ®s->alm_enable); rtc->wkalarm.enabled =3D val; =20 return 0; @@ -340,11 +340,11 @@ static int mpc5121_rtc_probe(struct platform_device *= op) =20 if (of_device_is_compatible(op->dev.of_node, "fsl,mpc5121-rtc")) { u32 ka; - ka =3D in_be32(&rtc->regs->keep_alive); + ka =3D ioread32be(&rtc->regs->keep_alive); if (ka & 0x02) { dev_warn(&op->dev, "mpc5121-rtc: Battery or oscillator failure!\n"); - out_be32(&rtc->regs->keep_alive, ka); + iowrite32be(ka, &rtc->regs->keep_alive); } rtc->rtc->ops =3D &mpc5121_rtc_ops; /* @@ -376,8 +376,8 @@ static void mpc5121_rtc_remove(struct platform_device *= op) struct mpc5121_rtc_regs __iomem *regs =3D rtc->regs; =20 /* disable interrupt, so there are no nasty surprises */ - out_8(®s->alm_enable, 0); - out_8(®s->int_enable, in_8(®s->int_enable) & ~0x1); + iowrite8(0, ®s->alm_enable); + iowrite8(ioread8(®s->int_enable) & ~0x1, ®s->int_enable); =20 irq_dispose_mapping(rtc->irq); irq_dispose_mapping(rtc->irq_periodic); --=20 2.54.0