From nobody Mon Jun 8 04:24:23 2026 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E630F35DA78 for ; Tue, 2 Jun 2026 03:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780372340; cv=none; b=ktFt3LzfTZTYA/lAXFVkmrba7RJ8AwiMCxCLljZlX6PY/B76kWiBbSSJE6qLeexPSVN66y2zEWwN5g0tJadJ8g5UTLtB+RLHXMMLmKKQOmufnRi65SHsV0c+yb/th9dC8O5mzctTGpiBpB45yC0X6bv0Zqak6pzoYwhCvgPDLMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780372340; c=relaxed/simple; bh=tGrDj3iKsblvSxin9Z8SW2x/U8qJVNMBwnUNs9uT7Wk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hLh2/w+OQSZ+386jIgI0Ag7xHvEIViLenal2y95uvhKUbn/xH4NzUGjuyTqw2cM2gXFEvbfVXA7mJ/tlCJ8nzHf1752noehkg9qBAKZ4b+ySSy08PI7jFvQJNMFQ8qbC3iJYNCdBocqnS6JTvGeKidTL6RRFYziVTWu7rXwhegg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SLFB7cY0; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SLFB7cY0" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-304d555293aso7141006eec.0 for ; Mon, 01 Jun 2026 20:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780372338; x=1780977138; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=db4ZDp99XGdk8QVglDB5KTc3dov06pGrTY3LBK3e++o=; b=SLFB7cY0g5uxkHL5f7iNsCjM6WSQIL3GEKsgQGXbu5oeOcAGeyzFEXcFYyznd0Y8/E ag8nnOm7GazQdqXoa54gBmezAfiG4oauyuvx2leDwpjWoAUZdRqT1XlIyFH6IzkjxYAL APXcoQUgKLkm7fXfrQ6sbFJEPS6epXgfRiR6Ui4EqspxVpQuAu4ulFPzb6uCmycbuTyG F5xGTb919SQ9cg0WQxJmfsBCSlpLo62owfjtgR31m0Qp/FXHiyeTuUyEY/gm7DxmJJ1J nnCLUhlmktGkQAfgyie1O+S+mXE7/KnxMVOVRi5q//jcCIKOHmcdUboBoibfPBkDLpXs 38Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780372338; x=1780977138; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=db4ZDp99XGdk8QVglDB5KTc3dov06pGrTY3LBK3e++o=; b=lgRMCFdcmvocI6O/KBjrW2bV+p9Hj5gMkSVD+fmb8CFR7RaY1xAOA3AztFqybuI76z 50QnAdtLceZr/5f2DNnkWHULN9sWl1OELZFHQlkenOTB1b3QiqYuF5EUCEA60JsBl+ad MOY1TkUGwZ+vBtSNSKHjNb1hCHaItyn5Awbs00C3vLANc5PktlTYr5IHC3lgh0K1MYW9 +C2oMzTOHNOHiBw3jni+F/DRPh7rTwthiVCmwnpcEnZsVA55y4mq98hyJ+75VLM/LgXO EJiX8IA/3YmvhDfByW2sG09+7VundjGWyrQAnFmidJwB+NLWErs+TBgIbC5iN+8L15aw RPXQ== X-Forwarded-Encrypted: i=1; AFNElJ9uNyg+aNi8XTv10LsQj+QBobruxy1drL5XR3x+ey2WJF/aGN7aZe2daM6s0ElAPjDW5DYnk6uj9UelsDY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7r70k08Xp95fL4vVqTanN5e6YeJS7bj+d5JJ02AYoEMSip5+a 82rUZAarqr7tl0e3DeviUiR25oOiJ/svlD/RzGKnlnyZE2jDQGyGycEo X-Gm-Gg: Acq92OEDz2ZRG3ekGhKwjUkaKRtfgoysm3eLEYHpJtZs4jMAYzUtcNbU5dLpDbkE1Oz +0oOO6k22qT0nBGluD5cI7jtNL1e+RNcCP/NPXZEkbMizhgR+F0kRiyUjdu/ae5jnufLPHkMacL D2MMNcV7rQSjpyZBTgnBg0cLG1vCkJX6yrKsVI27QHqwrsWcWT1dtyXLhZesDZ8N9nl80GyvRrc QZN3SV7+pJl4QQGXpyv/nUu+vRwGHi8zeq3upzw1V3O9/okR4IcRhL+svMoY1ZYNV/2ZbT2GWTY ckahy/fw6x5HK3Dxksebszdo7AYY+5MFzdrw+tyuKNtGvikgixKrJleWctpTiEvWPU86TO/WrnL inHOYcaiI+e1dXScRgtvXHoPi82VrdiMRNBYTabC63yrttxvg1hjY+Hpfve2U0xoGxIT780Q6Q1 3I3a2I6YReZvoEuKgzk2p1FmOLHm8cJG2hXc0LgCqEDGeyAibMlXQeP+NttvtNkLncB6wFHYrX8 HlQfE09W/j/7qiAtSSvYyMBofqPM6R0HkoAYpsnaTKGsAHKZVhbQEKfd3J+2scpMuS01l3gvO9N A93QNXK+h1PnvgHstH8DX20C2R6sutL8FC5gnOkMS1acFUOTyS8BxLv2j6Jq5A20rwg= X-Received: by 2002:a05:7301:5803:b0:2c1:6676:5ebd with SMTP id 5a478bee46e88-304fa4fd14fmr5878983eec.10.1780372337755; Mon, 01 Jun 2026 20:52:17 -0700 (PDT) Received: from odroidn2.. (c-67-180-34-11.hsd1.ca.comcast.net. [67.180.34.11]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-304ed53d06asm11425664eec.14.2026.06.01.20.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 20:52:17 -0700 (PDT) From: Yi Ding To: Neil Armstrong , Kevin Hilman Cc: Jerome Brunet , Martin Blumenstingl , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Yi Ding Subject: [PATCH] soc: amlogic: meson-clk-measure: fix debugfs directory leak on unbind Date: Mon, 1 Jun 2026 20:52:09 -0700 Message-ID: <20260602035209.62335-1-yi.s.ding@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" meson_msr_probe() creates the "meson-clk-msr" debugfs directory (and its "clks" subdirectory) but keeps the dentry only in a local variable, and the driver has no remove callback. As it is registered with module_platform_driver(), unbinding or unloading the driver leaks the whole debugfs tree, and a subsequent probe then collides with the already-existing "meson-clk-msr" directory. Register a devm action that calls debugfs_remove_recursive() on the root dentry when the device is unbound, tearing down the directory, its "clks" subdirectory and all files. Fixes: 2b45ebef39a2 ("soc: amlogic: Add Meson Clock Measure driver") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Yi Ding --- Reproduced on an ODROID-N2 (Amlogic S922X, G12B), v6.18: the "meson-clk-msr" debugfs directory survives an unbind, and rebinding the device then warns: # echo ffd18000.clock-measure > /sys/bus/platform/drivers/meson_msr/unbind # echo ffd18000.clock-measure > /sys/bus/platform/drivers/meson_msr/bind debugfs: 'meson-clk-msr' already exists in '/' drivers/soc/amlogic/meson-clk-measure.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/soc/amlogic/meson-clk-measure.c b/drivers/soc/amlogic/= meson-clk-measure.c index d862e30a2..1bcaac7b7 100644 --- a/drivers/soc/amlogic/meson-clk-measure.c +++ b/drivers/soc/amlogic/meson-clk-measure.c @@ -902,6 +902,11 @@ static struct regmap_config meson_clk_msr_regmap_confi= g =3D { .reg_stride =3D 4, }; =20 +static void meson_msr_debugfs_remove(void *data) +{ + debugfs_remove_recursive(data); +} + static int meson_msr_probe(struct platform_device *pdev) { const struct meson_msr_data *match_data; @@ -967,7 +972,8 @@ static int meson_msr_probe(struct platform_device *pdev) &priv->data.msr_table[i], &clk_msr_fops); } =20 - return 0; + return devm_add_action_or_reset(&pdev->dev, meson_msr_debugfs_remove, + root); } =20 static const struct msr_reg_offset msr_reg_offset =3D { --=20 2.47.3