From nobody Mon Jun 8 04:24:36 2026 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 389E921E0BA for ; Tue, 2 Jun 2026 03:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780372318; cv=none; b=J9RcLTVCyo0ehse4ZL6HVPQX/DpaqlSUOOxAwcCq/T5PnAOVQGj2h5If9b3d4eQ0yTZkefVVt2+u15us/gaKhWgZBkJvifZSOVYs1r2Qd/peGESr9fbf+We8XUL0LcycZszkB2z0fzPFCLZHcz0a9l7azjuY8SMwyFVts+BB2Xc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780372318; c=relaxed/simple; bh=1YO2Q5tPHU0duhqz7IUetUZGgIMV4bPyoyR6VJI0MUY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HqK9RjBUuDsZp01GlIRPr2X7uZWUQ1LHroCPvz4ZWJLypAF8sBYXZ9vL4/C4Ji4XShBNTcsiYxhBNmy0jug+JYU0WAx/iiPJlfcC0lCQ/v0sLsWU8q8HcJ0kD6+2OrTinhBxcPXN9y9P9ps60c2OIqONcK6kJ5UbJS+6Hh+2t0U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DNt1eaE+; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DNt1eaE+" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-137dd5161feso1750258c88.1 for ; Mon, 01 Jun 2026 20:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780372315; x=1780977115; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=i+KNtW5JrHCEx2Gpp74agRibw3LqoXVEZ4zqVBpQiM8=; b=DNt1eaE+s9Dkne1Gy5zs+Ny1cnuG6Oa11UrVcgJAcA1bq7nQYrNzrWFVm2WRpyq8AT MOrMo4gZfXsUE1RrZkbQ22CemGZSFTK/360AY7XPM9GS8l1moym1UNmXDrOX2AHDE9mB w/QrFSv57RjVsOinYk9NNCzm7VYgSRQ2ouZdCkfQHSEiG0ktF0Qmc6xTg1hhPOzYtRT/ VcbWP52xH1jebBPODByMtPDVafAM3EY5uTqT6sYgHYIz3wjEgzdqpZQn4/2npZQl/L6P dxdVwPFPnBAyX7VjP35XDH3uBDBsfuJTdfT8THj+SaxO0acn7rshI/+p89teOidthhV0 KROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780372315; x=1780977115; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i+KNtW5JrHCEx2Gpp74agRibw3LqoXVEZ4zqVBpQiM8=; b=gWzZqMRnmoWzoT/bZ7fTMDmC7TxfAgnqlXRIRIR+dZBhZizrtrRkZ7WPhtm88RK+zR IyPPR6ODTVDJMNEefIp4EcPFb6EUz0Lsq/GFsF6TThphSBZO19f8vcZABzACjweZL9Gp cC4Puf5GqAinB6yTvw9KrG61K2RddU1NcSb4m394dqxrwrKSrk3dG6Xg5jd15F3i8d0S oHDtwp/4KeYglyX5KL7sM7jkv56R21yF/4+tvREUznQubGDmchwmKMkjfeFvVgaAIZep xEmdvaFQF02Dam8Op500efEfgQtmI9OUsGmbmfmzvUQuQKs12wPUkMqh/XIcYj7yHgiP Q18Q== X-Forwarded-Encrypted: i=1; AFNElJ8vDLyHalOfef1ZnPONHyu4awhFd/0YeTqm0C/dmEtO8dRa/WIjGWo1AGOoV3DFX1f/O5kGV1Ku24cxARk=@vger.kernel.org X-Gm-Message-State: AOJu0YxtJ2kLFpzjvy7HRXHn9VIlImTKvhkTRkmPTyWTMMXAcKAv8zvo GKUCK3wukJg9apj8YUkaTYyMo94WM0XtPYtd9vDY68k0uPLvmBBK5pTBkOsaFHMRHr0= X-Gm-Gg: Acq92OEaWwMPeol42U7tSoeOn/qoRuRHoU01neiDI24ZNLmAh1D2bZMzLm8Kh/pUa+M IirFg0DRsOZxeCzCJn3/s198fRCTUcLRJXiEIV2q9d+OU9edRZFjf0K35wAXOE2vPU9ipDXZcGu H3fYDW93x5gKrdAq02DePpRZfq16biJAIVa+M2CNzgV2nPOFEyY226Vgbt+3PRXKC0tNBaYYml5 RkE5mba+szdHbTqnSHtcdSHmIfYnaPhuIEBmfuBjmqt8ZeMtKafVIzFOlYk5Ew9qhOE+dmjODIa jJ5hRa1bDMfKsLkLbr070Aaa4WPjtppR72YBYCcyy0t8kTsGFDqo8NZhnMB0lzLB9CmNQbGDK9M 1Bk870grwcmsiQ7Q57DO3V0p0ZQ4VJOfi+qBYA7/DkZ95cNyjFzSfBqB/z+SNtzvuxxmdw01PM1 wPwOr6ih7e0ziwtyAnulfNg5LUDIZhufxK8FSPRe3KzjdFJrQXfFQr2u7/GLdpLh7Wm4AAAqmAO YOtJghLxvUNzjEqdDZpecX7kE3lwVen4HORZWPBnI4fQB/WN2IXM3aw6YbRtO+P3GbpTp/jeONC n4S3sx4FdtiWSmotORHFZATwVzksuc6ZELFeDWoQMCYTGCEOMNmqyZWiwrdWgK3Ex5I= X-Received: by 2002:a05:7300:e58b:b0:2ea:ed3e:13b7 with SMTP id 5a478bee46e88-304fa529392mr5686850eec.7.1780372315250; Mon, 01 Jun 2026 20:51:55 -0700 (PDT) Received: from odroidn2.. (c-67-180-34-11.hsd1.ca.comcast.net. [67.180.34.11]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-304ed53f002sm10969668eec.18.2026.06.01.20.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 20:51:54 -0700 (PDT) From: Yi Ding To: Alexandre Belloni Cc: Heiko Schocher , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Yi Ding Subject: [PATCH] rtc: pcf8563: fix clock provider leak on unbind Date: Mon, 1 Jun 2026 20:51:35 -0700 Message-ID: <20260602035135.62264-1-yi.s.ding@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pcf8563_clkout_register_clk() registers the CLKOUT clock provider with of_clk_add_provider(), but nothing ever unwinds it: there is no of_clk_del_provider() call and the driver has no remove callback. Each of_clk_add_provider() allocates a struct of_clk_provider, takes a reference on the OF node and adds an entry to the global of_clk_providers list, none of which is released when the device is unbound. Every bind/unbind (or module reload) therefore leaks a provider structure and an of_node reference. The clock itself is already device-managed (devm_clk_register()); only the provider registration was not. Use devm_of_clk_add_hw_provider() so the provider is removed automatically on unbind. Tie it to the parent i2c device, whose OF node carries the #clock-cells and clock-output-names properties (the RTC class device has no OF node of its own). Fixes: a39a6405d5f9 ("rtc: pcf8563: add CLKOUT to common clock framework") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Yi Ding --- drivers/rtc/rtc-pcf8563.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index b281e9489..7083d9278 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -449,7 +449,9 @@ static struct clk *pcf8563_clkout_register_clk(struct p= cf8563 *pcf8563) clk =3D devm_clk_register(&pcf8563->rtc->dev, &pcf8563->clkout_hw); =20 if (!IS_ERR(clk)) - of_clk_add_provider(node, of_clk_src_simple_get, clk); + devm_of_clk_add_hw_provider(pcf8563->rtc->dev.parent, + of_clk_hw_simple_get, + &pcf8563->clkout_hw); =20 return clk; } --=20 2.47.3