From nobody Mon Jun 8 05:24:55 2026 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6722364024 for ; Mon, 1 Jun 2026 19:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780343183; cv=none; b=gdkaqJfzrXwC1Gh0VrAdCUBm0BRxKPSxUq0KD/bid8BCL4u7j7NiYMF/1WTYsNOc3a5CsA2xmn8Ssyd4cHXsy6monNZE/YbKQwkTuqDha9MkVXCadgHPNVx7+PAECuXCZBlp2P0t+o8pZgZdWWQJf9b7T6VPnHMC0Ehfknxv94k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780343183; c=relaxed/simple; bh=SYbNicsBnsUkwiwBDS4klYYJHV9hzXRbOndaThKBeCA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BVJB0P0eWNm6MAE+NuVZ3S3isrgIEda9GvuVk+YM3zdNWxSiVDD0qqlBLq3hvQvLvLACEEdx6z3BIvOUlfI/5xkcpSTjRDUS42Z7MRZo6UTejlMdw0ytMhku64ggRLX9ZC5U7yTWqnDK76Xp+6llsT5vsfIHwS/9pQR9rX42WQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jb/LIvIQ; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jb/LIvIQ" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-91578122305so36870085a.0 for ; Mon, 01 Jun 2026 12:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780343181; x=1780947981; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=i0+VXzI7NS71oC73bVDjfQq/NKaDSZiH+AFXgAo6zc8=; b=jb/LIvIQiQO5KnxpoAuFZpix657rCNxqgFeZe0z4K8qxk9Te2nxDhZagO7bl09A5K8 GmH8NkVoNldRLyJQ6h+CHA5Qxjm05tbbWC8apGrDDixZb0QqLV/xsunaq7Ipw+LLgomq PLDq3sbgtCtllXjBjfBYvX6FqtZl/QnaMMkz04DqLzvHV4Ih6oSwHkGgmizrWjjsfz1S UKN6j6poKxXigYbiMrMeE1TiD73RxlFDh5tS3R1u8cFLPl/5+9yppXybkK14KfYh4koZ 62yTZ3qYrS3BUzFCOKoC7DisrKWazzEBMtguQlZax3mWSRY7MgzFf4CpYMncGxSjhMhn rEUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780343181; x=1780947981; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i0+VXzI7NS71oC73bVDjfQq/NKaDSZiH+AFXgAo6zc8=; b=HjkODPCzuKSYUwZjhfeJWe0/U1eqAjyDSC6wZQ9Pw8SL0rbO0vZ+JeHKry4xSMaDVp 0cCiAadwc327G4l7rdAHmjufBopqDxXYdeAAHjzMKO2cHIWa25nfY7ev5/zHmLXFj771 /ms6Sqg1I1P/jM3DKtkr5xTaxwyXBT4+AxbgBvyXONp2iIZ9/Y/dRXGDzYDj6+yy7hUZ UJLSQ+5TC/dRSbmOK9W1tpipm38hU8SdmiYIp+2ky1NGRmz/jW5zvdx6pxvTaE50vkjM JYjUWlzV7igh/txelwPAFzSVs13Sqo7CQqcsbv0yWwm+KpZSIMw4W9hTP3ymcgV0Mq/z 02Ww== X-Forwarded-Encrypted: i=1; AFNElJ9TaDwereOoOfiq/QxhiIL01t3LplS7jzvHhMu44O6RWbYsdF1xY1eH3WDtIs7BK3KYye1zBezkrxyYmKA=@vger.kernel.org X-Gm-Message-State: AOJu0YysHrEOw/DYOOzOLU3Y5G3dHyuqoRnmOGpK+uEoz/sBe/g1W7Gw zXfyqwZrckuFO9Ql3rX0wslyTbLR14xAQs6HdEe+yedcmVrwKKmlIBnQ X-Gm-Gg: Acq92OEloImYA7CuvPpkFABvc+LhTaCFJ9PNKiXlSWgct5L13+mIgq++kmV173K8+FL YlPmIJkOPvheKeXTwxocjPwQtQv3fbUovsG7VskUHqFWIK+I+C1dNh04qCTZwU/Y9ulEGn2H+nR mNGjGapTiQoNPRhwb0TLRWY7h9OJ0OER+UgpjE9tBhtWRfHmXQLrX3R/E86DnVuOcrQuHudcKBX yCTef/hCEr/J/xga/6+e9jVrfAJn4fdflBmRNulqB5XhMT5s77c5yfRDtmvEx7Pw0wFsNVIfwkK qNO9ycmsgUgn0qfvyk17PzhASi0xFsg3dp0gAVbcVqEkMaJyoMi8z7VriIFCrZNohq6RBokD7Y6 RppbHRqiNDsr8yJv9YfjwFMt53t9EOkyDU3PYtRefEZcmp/1XqsOzvxY/OmLxtZoxvO/Cj8pQvH Vp+pazqEot6qDvALADURVStAOACrOaHePs3XyFHyIuXZVhuqeKuSbQBEjq174z0w== X-Received: by 2002:a05:620a:4454:b0:915:75ba:17aa with SMTP id af79cd13be357-91575ba2b2emr316925485a.35.1780343180770; Mon, 01 Jun 2026 12:46:20 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-91532446403sm1070254785a.2.2026.06.01.12.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 12:46:20 -0700 (PDT) From: Yuho Choi To: Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] rtc: m41t80: clean up watchdog on probe failure Date: Mon, 1 Jun 2026 15:46:15 -0400 Message-ID: <20260601194615.1979101-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" m41t80_probe() registers the watchdog misc device and reboot notifier before registering the RTC device. If RTC device registration fails, probe returns without calling m41t80_remove(), leaving the watchdog misc device and reboot notifier registered. Both watchdog paths use the global save_client pointer, which can outlive the failed probe and point at driver state that has been released by devres. Unregister the watchdog misc device and reboot notifier before returning from the RTC registration failure path. Fixes: 10d0c768cc6d ("rtc: m41t80: fix race conditions") Signed-off-by: Yuho Choi --- drivers/rtc/rtc-m41t80.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index b26afef37d9c..f4a30320c6ed 100644 --- a/drivers/rtc/rtc-m41t80.c +++ b/drivers/rtc/rtc-m41t80.c @@ -1009,9 +1009,17 @@ static int m41t80_probe(struct i2c_client *client) =20 rc =3D devm_rtc_register_device(m41t80_data->rtc); if (rc) - return rc; + goto err_wdt; =20 return 0; +err_wdt: +#ifdef CONFIG_RTC_DRV_M41T80_WDT + if (m41t80_data->features & M41T80_FEATURE_HT) { + misc_deregister(&wdt_dev); + unregister_reboot_notifier(&wdt_notifier); + } +#endif + return rc; } =20 static void m41t80_remove(struct i2c_client *client) --=20 2.43.0