From nobody Mon Jun 8 05:24:53 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46ACE356742 for ; Mon, 1 Jun 2026 19:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780341689; cv=none; b=OkVnKNxzbLxNPzWrmlANU9Ly4xzHezat2qk5JfehiT8XC6wjtHief2NtLmHWmFWG9k0/jGQkfba3yqXpFsaF6L0CW7CH39pKSHAA9XDyDoMFbckozbw4Ki31DGAet2uRbNrONhQfwLAyTGdQw1KMzku88fAxHkVIbGjQcJFtqNc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780341689; c=relaxed/simple; bh=SMkFI++1OcZmW1b6oIZAzPZLgEZD/wZ/b/qHqus+Dm8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OdPJj+GNNtW9/aWJhJL0WC9IvFVB1PoVAuvjGFJfDHITeGuMvIHbX0Ao3D4rc7o0iQTQh/kewPVmwrFIK+kK85s6SspVrcNs0KqGkvjZnH+Sf/aVPTc6z/KZPoS6t8HjkJ7Jc8d39XeVy46TMr05eTL6j8md++oeJDaAgzGtB2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IIEwcuTu; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IIEwcuTu" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c8583b8fd89so1585643a12.0 for ; Mon, 01 Jun 2026 12:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780341687; x=1780946487; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rUhtVYrg48qb3KiaDyySI952AGcCHN+px951Lp59iZI=; b=IIEwcuTun4WwBXBveTgg6w6B/xPut7DKMdHGYVzuR+FEvilErQVy82l/GcILSbmu+e g74bpxOfYKMN8b5OUY5/Hz53NWrMF9Pa/JQv0FvtZVBzDe72YzqQyrSuEWvMP7SrsSbr KF58nSGHPYMi7bbXNUeIvY//Q3RRvwppNjGaAxjXrgkpJ6eWJhNpXdLzeBcQANgKPuhl bBLixkoSJ24vtADmkrhhv3ox81OQNNB5ivjxbsqXxxWnbIB3ArfHiEO3ZpMM3FE/UEWS 30j9iWu3wgrS85o3KxB4QOoKxp9aeAbKiPhJXeHJGkjJDqtwQ7U/5u2H1AVTbiB3+KQG 3VqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780341687; x=1780946487; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rUhtVYrg48qb3KiaDyySI952AGcCHN+px951Lp59iZI=; b=Bb8PNEuGY6h3eQWDI8xJa0AFiu8kEvS4fXbsRgeH9mpVhJs6Zz3CEiy26++qFEVm52 l3acVvZ63se9W4yz97fuyqjFN6wb4ysO3EP41ksyEH7AYn3y0d9sG2V5fVvmbz5gBnIy lfAQ1FhuqHBFLTaa9Yf6eCTqy36GgS0XH5iwV8mxM9rCYm0fRrBsGSRkAibe+GCGMLwi 7i4JXyymnK2kWU54P3kBkD8wFBxwmhOCn2vwHtvzI0ShFZGOea3T3Dp2M8XGbEum0v3q ZAiBLFxf8vhbv2VtMRBf+wwFpha9WgJqfTq6su3OZntuMt4O5ftXnmyjJeQDbxL9AbLw lmVA== X-Forwarded-Encrypted: i=1; AFNElJ8LgHQ3KtpzAsGyJqfNnIvAXfr5Gu17YKRMjpZhtisFKKLjNUPUvB8QZxvpJGsFxVAU2i3QjKmN5XjZy04=@vger.kernel.org X-Gm-Message-State: AOJu0YxKmmjsSBXs/q4AHFKilQrdz/lhSuU3DonqD8C5ZAJTCg64i9B2 9J5CGRn+Sg30F2XqFVRxZdYuA9f+sAZSkNFtMouaXgcHRHKgO+ta8P59 X-Gm-Gg: Acq92OHSwUBxp27pEonGn0XLinMYCPTqfvY0edJWGNwR/4btTd98YJWA2jXCSPGKPmh SkBlR1rbWlqyIsWsyA/H6l/3q+nyBgPGFXWKJ2hqefL3Hhe2QDbso36adFoLHn2peuzoyPOuD22 sDCNTUKH45DnkeplLYLn5RDjglt0citVUn2h4vfMBBeuYDaG6/bSqDIxAR4n6rhQ1DZbDtUDa4r Ni/gkPcLRz+qQRfgv3jbRpXAMZ4BUogwraplLeBkHvNSJ8HPlpoPisTe8KW7bJ1a2JRKtUQBnOJ 0Lu1UkAtoi8yzPK30wyE+/XeN7+WpDdKPwAO430eYNw+kbKJ6yN+S91VUywB2wuDmpieaSiAlrU mlEfQewWCHpLwiHZghIugCENcPaj5tdSkPC2LtwBx3v6orq4xaELeFpYT0YCIMIYEFgGPmFSR+T 9td139RVjzwur4aYI2HmmKTJDNJWQyX0a7FfJ9Lv3ru7rjyWNjXXCQI2CuXv7haWy88zB64pglN XrLtCh/ZGe6AcO7W2jrjkNcf7TW3VGSQBqPx7/A0lOOsA== X-Received: by 2002:a05:6a00:3924:b0:83b:905:c9fd with SMTP id d2e1a72fcca58-84225841280mr10637961b3a.24.1780341687288; Mon, 01 Jun 2026 12:21:27 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84234c99af5sm7477561b3a.53.2026.06.01.12.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 12:21:26 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ata: pata_ep93xx: fix incorrect return value in data_xfer Date: Mon, 1 Jun 2026 12:21:09 -0700 Message-ID: <20260601192109.21262-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The while (words--) loop post-decrements words, so it underflows from 0 to UINT_MAX on exit. The function then returns "words << 1", which is either 0 (for odd-length transfers after words++) or 0xFFFFFFFE (for even-length transfers). Callers like __atapi_pio_bytes() depend on the correct byte count to manage scatter-gather progress; a wrong value causes ATAPI PIO transfer errors. Fix by returning buflen instead of the corrupted words counter, matching what ata_sff_data_xfer() does. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/pata_ep93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c index 192f75636d18..5b79a7a019ce 100644 --- a/drivers/ata/pata_ep93xx.c +++ b/drivers/ata/pata_ep93xx.c @@ -506,7 +506,7 @@ static unsigned int ep93xx_pata_data_xfer(struct ata_qu= eued_cmd *qc, words++; } =20 - return words << 1; + return buflen; } =20 /* Note: original code is ata_devchk */ --=20 2.54.0