From nobody Mon Jun 8 05:24:54 2026 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC75233BBBA for ; Mon, 1 Jun 2026 19:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780341615; cv=none; b=V9OTegbTej+bTEZK257dNYw0cOGjW78Iq1cu1qYU78UuVyXa6d4AjNJNEfpG0gk66JBhscpdpaKRGDNbVTQ6JWR+e2j+1GR7RQCkAmCAzOHF2rdJozD12hv6mtqYs34/QKiBzkd3TcKG09NM5oBaMYnT3DKEIiafRKxRY3ZB7Vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780341615; c=relaxed/simple; bh=jOgJ83c10vyqCNtY2iWTtz9+bIiFdLMtkTch3qJ39ks=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IMqpKrHHAHyWm2eKOU9aX342jt9HXbFVQMTAUqB0dL6UMovI1Ckpr8q/ljzg/qEXjfAJ1ZgkFy6mFiFj5XGcEZ3Gqm5g0NXPaTgqJDezvg77S1olkGd481vvv2u2SzV4e0+pdTlBSnAEx5COq1KonDYQpE+AdUdxSgm1a8JBcIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VVXW9syO; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VVXW9syO" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-91550f68089so192272085a.2 for ; Mon, 01 Jun 2026 12:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780341614; x=1780946414; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DZKHLboCk6OHxzer0uEgo6LCbcjNpnRvCpbKSl1TcxM=; b=VVXW9syOzwOqiBxoPMeNNSR9FKZbZopuQ47V9jROrICA+V1GIbjyY4dlWn/JKMew6S dp1P2oltEc/nR0y404vpq6dk2nUlKEwQkmcPGlJU5A7nvZcc0ZFDjrbBBlqFPxET6l/u aF0VcR39uz2mGGmksRZuoTK7mXAtSxtHBXrjX3pHbeD0sGMQae5qjMsLQjvKom8lVRfR vZAYiAUnOSF6fQnU4pbb7SskW9YIamsAcMb6S+2T1DAHb+pdkzX4dUz5qxTsfPIEkWQi qFxsGJPIJlXlYNMSaf8U0nLlpmhhkv94z0OFuLUxT2lYP1t2IzSpoHxIOF6z0EsxQ3pd 1C8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780341614; x=1780946414; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DZKHLboCk6OHxzer0uEgo6LCbcjNpnRvCpbKSl1TcxM=; b=PVIDUy+5A8hJeU5je3ziGWQA1d6MjspLGBonV4Sn/7HzrxwFnrl9t436N338sHfOfk 7FDWIrkp9diNQHrKs3J+1p6L/mbE1z6TCCS/LRP9exSx9wbekuIfsMe5quKcFEwu5NPx z0SaSZxJ2jQF548U21LHIJ28ZHQnle2RP/EGB71QJvYsNef7e8+1yuld6fv67QDCcSB4 aoahn+Wwji1/feulku4NR9r0P9uhvbzWQMEChkymLBa4oNKaUVobAi3flAANnZJ7thY4 NNNl9NCaeRlyfyXbRgNDEijJWQsSR2Hoj8Lic53oDiBWL8cDdzNG4c5Djb2hQPVPE+hS aphg== X-Forwarded-Encrypted: i=1; AFNElJ8bNyJ/NSHyKTEJntFl5CincrAi7qBYlG6UrwRaxPBaPkv78VCzRfBkHbg/8ChogFKDuZI1RZTLF+ponQE=@vger.kernel.org X-Gm-Message-State: AOJu0YwT02vLTDhInE09tJSLnAP4QnoyLrFJ7b6551kAPumFqNVlk8u4 DewFTuXhhBZ1Ioq0uFKKx8rni5qgyTa2jUCXqk8DjltpqPIRo5WG72Z3 X-Gm-Gg: Acq92OFKeODP8WqXLavT+0Nv8JEOofbisXW/AihCT4bH4nLIRfPgAZ82w7MkbtuX9PS uqxWJg18ul8XQwAg1NNdfmHD7G3ZXN6YYZkI73TxMHO65UvIDlGvwsHB5ECPW0h2szNyEnl87gX YTHemK6aJtd+hTH3noHJLGZPkq8pxm6nRYGZgjMvy6nnnZCJ4K8hn9GRTD5FOgHKASSvtxPt+T2 REoJ7sFvxRtVy9PGKzqrXZKkyTMv54XDc60DjUZvjEU1bGf93/cnM9OhB1s1sN1xMkv/31BcOHl 85mkzuRWQyDX/tWP4yyJdqdrv2ZOFDSl+jf5W51o44Mlmcqn9UxtkZKnhbMElPCxAS9UDVy8KMw O3EnG61u9P/LAgcg1G6HELpYzEY8Hw9OyOAMiq4XoUIurAeV3kSvuBdfn5y4uuW93rF7jbiTtLU ygTMUPKDbLMePdwIfhgid08iPvTuMgrmKYkuwtBEdq5pY5nqFAcQ8= X-Received: by 2002:a05:620a:c4b:b0:914:bf8a:ba81 with SMTP id af79cd13be357-9153d9cc4c5mr2002069185a.27.1780341613562; Mon, 01 Jun 2026 12:20:13 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-915325fd899sm1079168485a.30.2026.06.01.12.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 12:20:12 -0700 (PDT) From: Yuho Choi To: Wim Van Sebroeck , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] watchdog: unregister PM notifier on watchdog unregister Date: Mon, 1 Jun 2026 15:20:05 -0400 Message-ID: <20260601192005.1970805-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" watchdog_register_device() registers wdd->pm_nb when WDOG_NO_PING_ON_SUSPEND is set, but watchdog_unregister_device() does not remove it. This leaves an embedded notifier block on the PM notifier chain after the watchdog device has been unregistered. A later suspend/resume notification can then call watchdog_pm_notifier() with a stale watchdog_device pointer, or at minimum after wdd->wd_data has been cleared by watchdog_dev_unregister(). Unregister the PM notifier before tearing down the watchdog device. Fixes: 60bcd91aafd2 ("watchdog: introduce watchdog_dev_suspend/resume") Signed-off-by: Yuho Choi --- drivers/watchdog/watchdog_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_c= ore.c index 8300520688d0..6c087b4ef5dd 100644 --- a/drivers/watchdog/watchdog_core.c +++ b/drivers/watchdog/watchdog_core.c @@ -391,6 +391,9 @@ static void __watchdog_unregister_device(struct watchdo= g_device *wdd) if (test_bit(WDOG_STOP_ON_REBOOT, &wdd->status)) unregister_reboot_notifier(&wdd->reboot_nb); =20 + if (test_bit(WDOG_NO_PING_ON_SUSPEND, &wdd->status)) + unregister_pm_notifier(&wdd->pm_nb); + watchdog_dev_unregister(wdd); ida_free(&watchdog_ida, wdd->id); } --=20 2.43.0