From nobody Mon Jun 8 06:36:19 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7DD2394474 for ; Mon, 1 Jun 2026 14:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780323937; cv=none; b=dRZfBOgUeid5M5ukNgV6KLu8ZeHemwa1RzDWcud7SlC1jF8Bz7uZLKcHGux67q539/lFCkOJcsuFUPXjz5i+ZlN+JLsTDxQ882rZ2FM4Kt4gXBygJwWrSUceJ0vT9ETuuckY7PvQbfQxdc4ImoXx8KVnO1FS6kDMyZIL0oc8Aik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780323937; c=relaxed/simple; bh=Ugm8WCGysL1TqNZ9kVuOjPA7o8an4dn2pNoHsUMf2pQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ntyuBbfRRqsnDtc1J6ELRl32jGvZV72Q2NCUKeG6dYSd4mUT10UizF//TmdP1eJ5Y+uiR7vIOzlgJqtUf1h5NmN7kVvOiBMDI2GSpc6VJ5oIistnUEUqutMFxPnnnWkGFiHgdlT19+ENqb6ffut6DhDNEtTRdA9oe2giAfnc3xI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JZWEzR9g; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JZWEzR9g" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490a765f47aso12601545e9.1 for ; Mon, 01 Jun 2026 07:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780323933; x=1780928733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MM4H2QoEUgarLx+0eAaW26X/5qxtOWLy6/mU6YWXbr0=; b=JZWEzR9gau4Rg5bKvXArsyhbLVT8PJTbYfepePyKINANoN0TyLE/JWsx7MoZc9SfnB YtYI++joWsaXasiQq2ESMrfX5kRtvWx4krAI3ktjWGW4bRbngmZMBhFyH9pek/ose/gT Q3wRpFhFNWEixhnGBPT9TSLz3nZnKJK+ulvgVR3KQtXjEd3Pq47r5FYj4xXGjuMaduxe cqb3oOl4NEfZcKRnNq/om8Aljz7t3T+FWXrib2NT6sYvgI0zQHAvv5RYH1Xcrt1d4SHA VegZDV+C7GArfwaNnarBkJap06eUbJIUk/A2mnJuq+HDtXT/piodR+c9xYuWPVDJhbbE dQfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780323933; x=1780928733; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MM4H2QoEUgarLx+0eAaW26X/5qxtOWLy6/mU6YWXbr0=; b=iQr+NOR5tF3A0nMYqxQdu3v8HWQnBzlJQnnvVbrf265IiCNpa+hXCqLI0yBgM+gMb1 iEhODjA9KzbdqUkiYJtavny32bhigtys4XAqDv0l7MsWNSKQTjLlwP9YkwaowECdJSYD rFbeIvk8DhhgGbVho8pAm4oL+CQ0Gf+M9plZqfhdYYae7GJb2tevh8iJD+tPbSbbMZlt Mno7xOQEFsYPRV9PEMKenjz8E/JJ5UChuRWiYDxQSFfLSELw5HpfwHPhSis4FUxBhtGt hLJO+2EsN9zrk77dfa5kBSrnUoTs3qaOjjy3OvKeUR8OlTXk49Qx3Lxa/xOsmlmg05ym VWwA== X-Forwarded-Encrypted: i=1; AFNElJ+vGGJzUxg3ROpd9QYZAaalGdkUL5BsQnkObjUjXw2S67h/A5ow409I0BTiQUWhsNMIbsYp8D+pxARRBMM=@vger.kernel.org X-Gm-Message-State: AOJu0YzGrzsXIpwcRwWZfxawJBTYyPd+fOiaVl/nyHHB49ODnZo3OTDb UmzRoqejD5sp6th4K99RE4IbXSA9wliPndquaoDlPW09SLWXk+PSpcJj X-Gm-Gg: Acq92OGUeSDIUNG6yh4MHAqEiPoqNxjLr5tztKpvM8Xw6D/wNew7A+CipwDY8fg/xAP 03TajspyKhGa0HvwQ0aDgmgPP0gnSnmDGF+VUmI1FSYFonuG2oVhMh89a6gmynpkZDtxG+yv6ZO U5EfoaNvNEPGdDJUDyLIXHl+jBwFLcxzaSxmb0K/4cnEWZJSN5aGXrGIjB3vRMlnYlOmR/Tqpsh bGGohC2NWNAZ7oMCnd3m0uU2mdiP2KQeeI4ucC6OZN0IlySrmD+ATNhTkHEYFj6YoqWmCK4BntT HhwJRb6C9WVVeOI5ONbi1qeQrDP8uBDSuEjrKcKm1ybMLOuA8vb8Z7ntLUALOvFODUlWtWOL7Co 6LjfVwalP+CzxIW0iovufz2LXWcWOi07M0bhAzo68MHZGMJYNffqKBJP6+HYzNSgpJukhMliCx5 q40YZvsKQDBExIL5RUeVIKcJ64xParlirLig0aADRdmq8l X-Received: by 2002:a05:600d:640f:10b0:489:2005:b36e with SMTP id 5b1f17b1804b1-490a2941d4emr154124805e9.19.1780323932800; Mon, 01 Jun 2026 07:25:32 -0700 (PDT) Received: from minipc ([185.128.9.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34b47eesm27898283f8f.9.2026.06.01.07.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 07:25:32 -0700 (PDT) From: Goncalo Gomes X-Google-Original-From: Goncalo Gomes To: amit@kernel.org Cc: arnd@arndb.de, gregkh@linuxfoundation.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Goncalo Gomes Subject: [PATCH] virtio_console: clean up port name sysfs attribute Date: Mon, 1 Jun 2026 15:25:08 +0100 Message-ID: <20260601142508.3740862-1-gomesgoncalo+linuxkernel@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix issues flagged by checkpatch.pl: Replace `sprintf` with `sysfs_emit` in the `name_show` callback. sysfs.rst states that `show` methods should only use `sysfs_emit` when formatting output for user space. Rename `show_port_name` to `name_show` to follow the naming convention for sysfs attribute callbacks, and replace the open-coded DEVICE_ATTR() with DEVICE_ATTR_RO(name) which encodes both the mode and the expected function name. Also fix a missing blank line after a declaration in free_buf(). Signed-off-by: Goncalo Gomes --- drivers/char/virtio_console.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 9a33217c68d9..56bf0f1b8a00 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -352,6 +352,7 @@ static void free_buf(struct port_buffer *buf, bool can_= sleep) =20 for (i =3D 0; i < buf->sgpages; i++) { struct page *page =3D sg_page(&buf->sg[i]); + if (!page) break; put_page(page); @@ -1237,17 +1238,17 @@ static int init_port_console(struct port *port) return 0; } =20 -static ssize_t show_port_name(struct device *dev, - struct device_attribute *attr, char *buffer) +static ssize_t name_show(struct device *dev, + struct device_attribute *attr, char *buffer) { struct port *port; =20 port =3D dev_get_drvdata(dev); =20 - return sprintf(buffer, "%s\n", port->name); + return sysfs_emit(buffer, "%s\n", port->name); } =20 -static DEVICE_ATTR(name, S_IRUGO, show_port_name, NULL); +static DEVICE_ATTR_RO(name); =20 static struct attribute *port_sysfs_entries[] =3D { &dev_attr_name.attr, --=20 2.54.0