From nobody Mon Jun 8 06:36:20 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBD4F39B947 for ; Mon, 1 Jun 2026 11:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312769; cv=none; b=eefAYPJ4atoDeekox8LH82quD1+oFpmLBtHvG4nJH2RuSD2Week13gdDl0mNqtP59BVtFc327O89cXaR9pvjlphW07F/a0loZjo896HtrvAwuehVT2LAaFBcfU0dRgAEB0bAATSAgUz0ZqNa8Tlt26TE9QtB0JF7a85nopLTrko= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312769; c=relaxed/simple; bh=r1b7vn+lGatrknXbAvVwotu7fWbwwO872DxkoS8HYHI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dtn4W1MFS3bzC9F/wLISinfjPkx0QY9yhwrVjPglW1MZEacWI33+YWlXsQrMJFRrh2pTUnxfC6CI11tdIjUZRibj1NKxAUIbtza1yeOH/myTXNh/2qtQNIhjsRuS3TIxO+O13zq48yl9i5ex0lPK480WtdBGy3Cq+0Wpya3G0kI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i5UcaovM; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i5UcaovM" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2c0c3546924so8140305ad.3 for ; Mon, 01 Jun 2026 04:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780312767; x=1780917567; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=trLwXz/lpaWzxovhRJBB3Gy3OOIDVqjW6QaVX3Vvw88=; b=i5UcaovMY3cJdrGsHLryoZIgg57B6S29B9TGaaenr8UwMilQAwPMVbu0aBao602gqs ksWsduen3voETBlz8ztjJQab6jE6bQfbWR6nI/xwoVVQcS9yJ9tGhG4H9KOPhRebYMbS /7U/7i2uOdIYWJ4rmAnDJHLQ8xaQABgpQriPfPSJrDvmjxcoV2+CbHLRE+7/pTFCZEB+ 9jGs+HTBtqBseJHd4zNV2Mi2XnYySdAuwLajhiFTLwjBNpVynnOu5vh+N9t4ihuH91Ef 9UOgDocun5chYGeStyBgWwK6g3SPPtCCT6vWEU+bfQQGUI5mH9o9C4KxXFt8C7oqsgoi 7yYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780312767; x=1780917567; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=trLwXz/lpaWzxovhRJBB3Gy3OOIDVqjW6QaVX3Vvw88=; b=TKja8wGwfSTR5f4UteSm3LPkqloT0AJIm5+3c5pqzfXHhDqR7hfnK+++I5fmp7OBjB oJJHMvIYuabecahHr+UYRSahL184J+PkjCnv0LUpJu+1FQ9G3k4jVcTbJrFfU/L+HLg4 qcz1ozATLfCTl7uUXKAIcddrT7sEWBZT5vTvnX42Zaw2RN5k3xVhKbJVfz0agw5vigGA ePAFf8J08x8BQMIa2LzL7RGSFpRo+VB1y0c5k5SLpA3VEJKEZ5snY2R9CT5x6kY7li5h fTpl04u8ot+LJ4EdQsFqogxTPrYVzA6in0423Oc90fFs1/N1gSb1jlaw/k2eE9uQURdf sGqg== X-Forwarded-Encrypted: i=1; AFNElJ+6EXZny0sCG6VuvfkqrWU8bfuZRjvBOwoRsh7bjTZy0z0p0NAm5vbTLwPxmYfHw3KzlUiFV3OYBAO8eK8=@vger.kernel.org X-Gm-Message-State: AOJu0YzOwegaaiaCp6F0L0UhkKqLbv2VNtrL6bgfi1F3rMWfr0M1Apaj xPmsnnmT41He+XDstyMu23FRcKPIvEEZhWmEukbfSUUW7r+kJVzOBHST X-Gm-Gg: Acq92OEm3yJZUURErAm+ePFBKowTHipikd72vOKaBOqO+S50kB+fyiPaxo/Y0bAv/yp sGstYPaQrTwrTvJ1upKtqm0Jx6bNLj2kA7vSMWkc1mdGEAvOq5bKpVtDgaZAckpE+nihanWJ9Og EUIdUnEChWHjb2HVmnDrI2g+Gotn4tiNsChBNFDofQJ3bNcbePMdKWg0Hz0E+i621oLPvfps50E VahjK2XZdxtZNXjMR2tYZMWCjqcb6lqYemsPxFmJTTw7V002l3tOPx7TtZFqMhb8WgTihUkQSmv WVmmQPxklXYSo2xaeDKjFGEUxYdKhUd0oexsXFxcXZHR/0DfrXCTpd1855e+fIiT5VrxxQjICpz delxK4mX+KGO3s5LjEt8Kqs7IixEK7JAMSP7T+tqizJiIOS7dtREy0ttYoalWBwRYasppxWf0JF Qwt3dZijnHb5uW/8t0ZOxT7ZWKbAyaVRng//5E0MpHgZTpaFZSEx53vSqnnQ== X-Received: by 2002:a17:903:28d:b0:2c0:a555:80d6 with SMTP id d9443c01a7336-2c0a5559517mr100032355ad.2.1780312767090; Mon, 01 Jun 2026 04:19:27 -0700 (PDT) Received: from fedora ([61.74.238.173]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm104225475ad.4.2026.06.01.04.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 04:19:26 -0700 (PDT) From: SeungJu Cheon To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, me@brighamcampbell.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, SeungJu Cheon Subject: [PATCH v2 1/2] Bluetooth: ISO: Fix data-race on iso_pi fields in hci_get_route calls Date: Mon, 1 Jun 2026 20:19:07 +0900 Message-ID: <20260601111908.232707-2-suunj1331@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260601111908.232707-1-suunj1331@gmail.com> References: <20260601111908.232707-1-suunj1331@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" iso_connect_bis(), iso_connect_cis(), iso_listen_bis(), and iso_conn_big_sync() call hci_get_route() using iso_pi(sk)->dst, iso_pi(sk)->src, and iso_pi(sk)->src_type without holding lock_sock(). These fields may be modified concurrently by connect() or setsockopt() on the same socket, resulting in data-races reported by KCSAN. Fix this by snapshotting the required fields under lock_sock() before calling hci_get_route(). BUG: KCSAN: data-race in memcmp+0x45/0xb0 race at unknown origin, with read to 0xffff8880122135cf of 1 bytes by task 333 on cpu 1: memcmp+0x45/0xb0 hci_get_route+0x27e/0x490 iso_connect_cis+0x4c/0xa10 iso_sock_connect+0x60e/0xb30 __sys_connect_file+0xbd/0xe0 __sys_connect+0xe0/0x110 __x64_sys_connect+0x40/0x50 x64_sys_call+0xcad/0x1c60 do_syscall_64+0x133/0x590 entry_SYSCALL_64_after_hwframe+0x77/0x7f Fixes: 241f51931c35 ("Bluetooth: ISO: Avoid circular locking dependency") Signed-off-by: SeungJu Cheon --- net/bluetooth/iso.c | 60 +++++++++++++++++++++++++++++++++------------ 1 file changed, 44 insertions(+), 16 deletions(-) diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c index d7af617cda45..b4196ccaf766 100644 --- a/net/bluetooth/iso.c +++ b/net/bluetooth/iso.c @@ -337,12 +337,20 @@ static int iso_connect_bis(struct sock *sk) struct iso_conn *conn; struct hci_conn *hcon; struct hci_dev *hdev; + bdaddr_t src, dst; + u8 src_type, bc_sid; int err; =20 - BT_DBG("%pMR (SID 0x%2.2x)", &iso_pi(sk)->src, iso_pi(sk)->bc_sid); + lock_sock(sk); + bacpy(&src, &iso_pi(sk)->src); + bacpy(&dst, &iso_pi(sk)->dst); + src_type =3D iso_pi(sk)->src_type; + bc_sid =3D iso_pi(sk)->bc_sid; + release_sock(sk); =20 - hdev =3D hci_get_route(&iso_pi(sk)->dst, &iso_pi(sk)->src, - iso_pi(sk)->src_type); + BT_DBG("%pMR (SID 0x%2.2x)", &src, bc_sid); + + hdev =3D hci_get_route(&dst, &src, src_type); if (!hdev) return -EHOSTUNREACH; =20 @@ -430,12 +438,19 @@ static int iso_connect_cis(struct sock *sk) struct iso_conn *conn; struct hci_conn *hcon; struct hci_dev *hdev; + bdaddr_t src, dst; + u8 src_type; int err; =20 - BT_DBG("%pMR -> %pMR", &iso_pi(sk)->src, &iso_pi(sk)->dst); + lock_sock(sk); + bacpy(&src, &iso_pi(sk)->src); + bacpy(&dst, &iso_pi(sk)->dst); + src_type =3D iso_pi(sk)->src_type; + release_sock(sk); + + BT_DBG("%pMR -> %pMR", &src, &dst); =20 - hdev =3D hci_get_route(&iso_pi(sk)->dst, &iso_pi(sk)->src, - iso_pi(sk)->src_type); + hdev =3D hci_get_route(&dst, &src, src_type); if (!hdev) return -EHOSTUNREACH; =20 @@ -1208,18 +1223,25 @@ static int iso_sock_connect(struct socket *sock, st= ruct sockaddr_unsized *addr, =20 static int iso_listen_bis(struct sock *sk) { - struct hci_dev *hdev; - int err =3D 0; struct iso_conn *conn; struct hci_conn *hcon; + struct hci_dev *hdev; + bdaddr_t src, dst; + u8 src_type, bc_sid; + int err =3D 0; + + lock_sock(sk); + bacpy(&src, &iso_pi(sk)->src); + bacpy(&dst, &iso_pi(sk)->dst); + src_type =3D iso_pi(sk)->src_type; + bc_sid =3D iso_pi(sk)->bc_sid; + release_sock(sk); =20 - BT_DBG("%pMR -> %pMR (SID 0x%2.2x)", &iso_pi(sk)->src, - &iso_pi(sk)->dst, iso_pi(sk)->bc_sid); + BT_DBG("%pMR -> %pMR (SID 0x%2.2x)", &src, &dst, bc_sid); =20 write_lock(&iso_sk_list.lock); =20 - if (__iso_get_sock_listen_by_sid(&iso_pi(sk)->src, &iso_pi(sk)->dst, - iso_pi(sk)->bc_sid)) + if (__iso_get_sock_listen_by_sid(&src, &dst, bc_sid)) err =3D -EADDRINUSE; =20 write_unlock(&iso_sk_list.lock); @@ -1227,8 +1249,7 @@ static int iso_listen_bis(struct sock *sk) if (err) return err; =20 - hdev =3D hci_get_route(&iso_pi(sk)->dst, &iso_pi(sk)->src, - iso_pi(sk)->src_type); + hdev =3D hci_get_route(&dst, &src, src_type); if (!hdev) return -EHOSTUNREACH; =20 @@ -1564,9 +1585,16 @@ static void iso_conn_big_sync(struct sock *sk) { int err; struct hci_dev *hdev; + bdaddr_t src, dst; + u8 src_type; + + lock_sock(sk); + bacpy(&src, &iso_pi(sk)->src); + bacpy(&dst, &iso_pi(sk)->dst); + src_type =3D iso_pi(sk)->src_type; + release_sock(sk); =20 - hdev =3D hci_get_route(&iso_pi(sk)->dst, &iso_pi(sk)->src, - iso_pi(sk)->src_type); + hdev =3D hci_get_route(&dst, &src, src_type); =20 if (!hdev) return; --=20 2.52.0 From nobody Mon Jun 8 06:36:20 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7200A3A2E3F for ; Mon, 1 Jun 2026 11:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312772; cv=none; b=BtXCOyQ09MxmfuNmmgp5a9fEw3GHkVcYJ9qQYLn/aQIjdFM/j6GQiuR8u7bAf6BxemH/du+Tt2lF0L2jvVHknBzab3BapgPl0f8pg7zPZtzwwcrZS0N8T7NGdQAduL0aJNrwuzcg4taWrB7sO/+ZCs6imL/X/QxotFPvwXtGioM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312772; c=relaxed/simple; bh=nLlwcEjDLyC35i9VEjYSXKxZ0ADnNQQjIajXHU0cpAs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HVYCLsWWo/J3Jq7qs+YgZV8ii0WFAO4jL8HE47zhpVMv/UtjzkUtcDVX+01ChatzgOlkDcGDkNvuPux2nVW0Dv1HFSenKpuJXKTWTUJ8W6mSe5fxL1OXI3WYV1dSJlG1An65CPD6jcqFz/reBCurUdltp0rpcyttisdhBoPvd/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ULRD0h8P; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ULRD0h8P" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2bf18c30bb2so24327755ad.0 for ; Mon, 01 Jun 2026 04:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780312771; x=1780917571; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ikdg5vb/DoCVKkC8Joypvv5J8aYetWNjGyB7PGOMDRs=; b=ULRD0h8PDiMe6dIQUki+UEtVQ8Fcwlnmsh3KJ9+fjMdHxCsRQU/45KsReeIj4Msy3/ Mq2ljw1mXNyUw5gvbqk+dMyvHPLgx/uLRcNBE5DXuw9PJQjCTHZXcSPYx19zg9mlsVv0 5fxwIirB9P2TEH7QcWjwOXIetIpKF2+GPAqUfHvUFLuxStBKrh0oVtgACtKkABXGJ8I4 I5DOkqZAaC8bYcv6ZPrUWBUhbXx5YFY3jyLYep1hz9zaUOZEAO4tHrR5DkjZJBoV5J/n SnC1ny5kk0UKJZ2Fy/+nUQWG85NeBn2buGt6uk6yOUgkShhYx6cOHtxQ+jkJBt8AMSv7 szxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780312771; x=1780917571; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ikdg5vb/DoCVKkC8Joypvv5J8aYetWNjGyB7PGOMDRs=; b=iPwPL7li+zHLQHv+vSFu+bIq+Iv8OhKPpCOhnQqekN3yfz+ZR3nW4oKhRx3O2FR3d9 HYJx9nlhzQSGF4FKilHDoY1XBsWJLn8rhe869Sml1H1U8pihDq6mk0iErDT95ewHkK/B 38jtNzswD0FtTUs5LMF38nd0wESgqqHbNluvAl+sG819du5nBvkQoA9vQnJ2S4fxzikR ghoH5N70P9vTa+RhPBB3C7uikWbJep7bZUQP6sQ1OsYGz3JnQHJoGdtkHT6rSOYgZnil Q/ICArjYV/Z9nWqhKaSI3F81LVuHgEzAYa2KssysGUF4narUu++OWmzPsiyG2dOJGGzA UlKQ== X-Forwarded-Encrypted: i=1; AFNElJ+7A0GzHpo8OQjD41GM/gmNAOMU3kz3zFHq8bAhHblcDUNuiS+YDnB6L9uY73rHjUMSPHJyK7UyxEFTDsE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8IFJUfn4IQEo+POBjWnpBdEit9gmgDpUG4c55ygz7aPi1csmZ IQqWB7bH7oMAkPE4f7YKKdILITAcEQ6ol2E/SDvVF1oR9Io2y51K1/zV X-Gm-Gg: Acq92OE7a/4MJt3N6Lsl+iy70gnewuFSh3l1fkdny5Biu0hpMwF5SiMIluSgfb1ydRK dfkWt/32IGIAZvlg7mLxM4WqlEMr+jn2uZVd55t80A4Rz8HLx1N/lvgoKGsrYe5bdCnV6g4vJZs 2EXq7PUfQ0P0YALnb1RS5e87aR/MqnEx+pRx6kHCSxj/NrGF6QGCPxJa33EoDXMDwROKokDloPI T0wts+I3ehegc8Aoso23rQLBFG/I3T0oUXQsM2olWKrHyq/u28F8SLQY6CYUsvJFbNG/0iBOYD6 5LftQ2wI7S2W4jICMgCEntF+wt+EsEdQEFdXyctjziHnSYoVgUHFm32zzM8GeEBOmL+ZhUwU6ZX s//L4lFtAApUvz4kcDsaKW2raPAzIZpJNksAMRBPZxDRR4th1sXFJWpn3Kde+bf6tEHlMOQA2h1 Iz06aXHiY327k5izTuTZp76itY6/aChyncUt2djtb3fFuXJRw1/qHzF8az6iZigeMB1weh X-Received: by 2002:a17:903:46cf:b0:2c0:c625:400d with SMTP id d9443c01a7336-2c0c6254383mr63119995ad.37.1780312770646; Mon, 01 Jun 2026 04:19:30 -0700 (PDT) Received: from fedora ([61.74.238.173]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e702fsm104225475ad.4.2026.06.01.04.19.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 04:19:30 -0700 (PDT) From: SeungJu Cheon To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, me@brighamcampbell.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, SeungJu Cheon Subject: [PATCH v2 2/2] Bluetooth: SCO: Fix data-race on sco_pi fields in sco_connect Date: Mon, 1 Jun 2026 20:19:08 +0900 Message-ID: <20260601111908.232707-3-suunj1331@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260601111908.232707-1-suunj1331@gmail.com> References: <20260601111908.232707-1-suunj1331@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sco_sock_connect() copies the destination address into sco_pi(sk)->dst under lock_sock(), then releases the lock and calls sco_connect(), which reads dst, src, setting, and codec without holding lock_sock() in hci_get_route() and hci_connect_sco(). These fields may be modified concurrently by connect(), bind(), or setsockopt() on the same socket, resulting in data-races reported by KCSAN. Fix this by snapshotting dst, src, setting, and codec under lock_sock() at the start of sco_connect() before passing them to hci_get_route() and hci_connect_sco(). BUG: KCSAN: data-race in memcmp+0x45/0xb0 race at unknown origin, with read to 0xffff88800e6b0dd0 of 1 bytes by task 315 on cpu 0: memcmp+0x45/0xb0 hci_connect_acl+0x1b7/0x6b0 hci_connect_sco+0x4d/0xb30 sco_sock_connect+0x27b/0xd60 __sys_connect_file+0xbd/0xe0 __sys_connect+0xe0/0x110 __x64_sys_connect+0x40/0x50 x64_sys_call+0xcad/0x1c60 do_syscall_64+0x133/0x590 entry_SYSCALL_64_after_hwframe+0x77/0x7f Fixes: 9a8ec9e8ebb5 ("Bluetooth: SCO: Fix possible circular locking depende= ncy on sco_connect_cfm") Signed-off-by: SeungJu Cheon --- net/bluetooth/sco.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c index f1799c6a6f87..140869e5b2df 100644 --- a/net/bluetooth/sco.c +++ b/net/bluetooth/sco.c @@ -312,11 +312,21 @@ static int sco_connect(struct sock *sk) struct sco_conn *conn; struct hci_conn *hcon; struct hci_dev *hdev; + bdaddr_t src, dst; + struct bt_codec codec; + __u16 setting; int err, type; =20 - BT_DBG("%pMR -> %pMR", &sco_pi(sk)->src, &sco_pi(sk)->dst); + lock_sock(sk); + bacpy(&src, &sco_pi(sk)->src); + bacpy(&dst, &sco_pi(sk)->dst); + setting =3D sco_pi(sk)->setting; + codec =3D sco_pi(sk)->codec; + release_sock(sk); + + BT_DBG("%pMR -> %pMR", &src, &dst); =20 - hdev =3D hci_get_route(&sco_pi(sk)->dst, &sco_pi(sk)->src, BDADDR_BREDR); + hdev =3D hci_get_route(&dst, &src, BDADDR_BREDR); if (!hdev) return -EHOSTUNREACH; =20 @@ -327,7 +337,7 @@ static int sco_connect(struct sock *sk) else type =3D SCO_LINK; =20 - switch (sco_pi(sk)->setting & SCO_AIRMODE_MASK) { + switch (setting & SCO_AIRMODE_MASK) { case SCO_AIRMODE_TRANSP: if (!lmp_transp_capable(hdev) || !lmp_esco_capable(hdev)) { err =3D -EOPNOTSUPP; @@ -336,8 +346,8 @@ static int sco_connect(struct sock *sk) break; } =20 - hcon =3D hci_connect_sco(hdev, type, &sco_pi(sk)->dst, - sco_pi(sk)->setting, &sco_pi(sk)->codec, + hcon =3D hci_connect_sco(hdev, type, &dst, + setting, &codec, READ_ONCE(sk->sk_sndtimeo)); if (IS_ERR(hcon)) { err =3D PTR_ERR(hcon); --=20 2.52.0