From nobody Mon Jun 8 06:38:58 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) by smtp.subspace.kernel.org (Postfix) with SMTP id 2AD7A37C0F3; Mon, 1 Jun 2026 07:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780299205; cv=none; b=bXT+0YakY3W0Ymy2mrKcIKeblxs1RhELqbN/TpTwrCl9Sqya0nP68DJ8GmptSE1vUKWW3KjS2A/6TJxJReDudwVZjS65yiDzJcHJ1XZQjjPavbD7Dcbvg17dBz0yBX96FTrZCCZwY2Z6FrBgljO8lkvu7mOK7gCzKcA+WaHj3HI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780299205; c=relaxed/simple; bh=xxxF1v+3v//o99hnLiqy2V4ZsWqh0ZmKYva8w6Tg1SY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eHePcg/Q4s2aNsOSCF+xWOignzray1zon+IBAd//i9372yYHYT69pHXAxy8NGq4wFvm7r+AqJTbXdrG8l4+XIiCh3TyxI1krzES1/lTz1Pa9mDs8WrROzwW4sWIKOVE2z+3QKPDJ+RFZWH2i+YARhGxi5Kr7nfFnJKiOhcHMCdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from edelgard.fodlan.icenowy.me (unknown [112.94.101.239]) by APP-01 (Coremail) with SMTP id qwCowABX+tKGNR1qGk9UAA--.1841S2; Mon, 01 Jun 2026 15:32:24 +0800 (CST) From: Icenowy Zheng To: Bin Liu , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Nicolas Dufresne , Fan Wu , Hans Verkuil , irui wang , kyrie wu Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Icenowy Zheng , stable@vger.kernel.org Subject: [PATCH] media: mtk-jpeg: only init/cancel work for multi-core variants Date: Mon, 1 Jun 2026 15:32:18 +0800 Message-ID: <20260601073218.1281840-1-zhengxingda@iscas.ac.cn> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowABX+tKGNR1qGk9UAA--.1841S2 X-Coremail-Antispam: 1UD129KBjvJXoW7AF4DZF4UCrWkKryrXF1rCrg_yoW8Aw4rpF WSq3yUCFW5Gr4qqFyDAa1UAFy5Kw1S9F47Wr1xuw1xZ343XFnrG34UC3W0qFWIyrn2kasI qr48t343CFWUZFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9j14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxa n2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4 AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE 17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMI IF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4l IxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvf C2KfnxnUUI43ZEXa7VUbGQ6JUUUUU== X-CM-SenderInfo: x2kh0wp0lqwv3d6l2u1dvotugofq/ Content-Type: text/plain; charset="utf-8" Single-core variants of this hardware do not use the work at all, and the worker function is set to NULL, which leads to warnings when cancelling the work in release callback. Skip the work init/cancel code when the JPEG hardware isn't multi-core. Cc: stable@vger.kernel.org Fixes: 34c519feef3e ("media: mtk-jpeg: fix use-after-free in release path d= ue to uncancelled work") Fixes: d40e95274925 ("media: mtk-jpeg: reconstructs the initialization mode= of worker") Signed-off-by: Icenowy Zheng --- drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers= /media/platform/mediatek/jpeg/mtk_jpeg_core.c index 8c684756d5fc2..83e54a7ef49c0 100644 --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c @@ -1160,7 +1160,8 @@ static int mtk_jpeg_open(struct file *file) goto free; } =20 - INIT_WORK(&ctx->jpeg_work, jpeg->variant->jpeg_worker); + if (jpeg->variant->multi_core) + INIT_WORK(&ctx->jpeg_work, jpeg->variant->jpeg_worker); INIT_LIST_HEAD(&ctx->dst_done_queue); spin_lock_init(&ctx->done_queue_lock); v4l2_fh_init(&ctx->fh, vfd); @@ -1202,7 +1203,8 @@ static int mtk_jpeg_release(struct file *file) struct mtk_jpeg_dev *jpeg =3D video_drvdata(file); struct mtk_jpeg_ctx *ctx =3D mtk_jpeg_file_to_ctx(file); =20 - cancel_work_sync(&ctx->jpeg_work); + if (jpeg->variant->multi_core) + cancel_work_sync(&ctx->jpeg_work); mutex_lock(&jpeg->lock); v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); v4l2_ctrl_handler_free(&ctx->ctrl_hdl); --=20 2.52.0