From nobody Mon Jun 8 07:22:05 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1E4731A572 for ; Mon, 1 Jun 2026 04:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780286594; cv=none; b=iCJpR1A7+EK13k+I7XwSZ9VY56sgqSzuaaMIq+f+SO9fLAXLOjntKT9m+vlCYC+sKBBN1LedVtbnt54cWF9XRO1nd9PvWmIbJw9DpIueSNA6s4JfOISyjhg/xmivkCpByKjuG7HVq/cc115vbGW/7plLl77D8SoIsIVD0aQhwUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780286594; c=relaxed/simple; bh=gT4/bA3mFwXtpHVo4W8EKkUsAtyQI2bYQnE9Nw/xqDg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bP0unzhNdWXcj29wqMxMgynd+S8ZyubjOKgPDOKAXwiKUEVVRZzxZc6ZzClaFuaNC1csx0cXy7eMMJr4MSETdbTnyVD0pNPrVoGv6/hASmySGAwDE4lRufaxJEnzuUKIRTc/Y4wc29HKnWsx6jjX4h3l98WE4z/+5etocvrC14Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rHHxUbMP; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rHHxUbMP" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2bf77d4a4e2so5923375ad.1 for ; Sun, 31 May 2026 21:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780286591; x=1780891391; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=owHuxPkmT7qUEBEcXysgUnbR9CByWLZ87e8T/EFLNtY=; b=rHHxUbMPvvLTyQyfvph/iLSS+Sh7QWiwTKO6O8NrzEvjQobohs2P3IemkTCeGKFYiH jsklLozcKK8Hxmji8uQoaBJPYZGo1Ne6Kh7Dqw/jJnMsON10PEzOciTc7I72V1IvI96K wLbaxb4Y2lPbtE6gf6kx0r34+mm4kGMYqkO/8ugiFHcThMffvOHtx4Xz7sdRILWJsgfN lm9OOkJQKhtwXYWCYxsC7mWNDEriN8q1zSC/+WHw4steCkv9YwNV25M3CcM4UyJiUuzl lXWeE7ehNChlJOtcsayqfK/CpzSaFz318SWzXXdTNTXQGEhDjwvYVLLOCrJILaMbGKx5 RyDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780286591; x=1780891391; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=owHuxPkmT7qUEBEcXysgUnbR9CByWLZ87e8T/EFLNtY=; b=VvXsp8Zk1fo6HVuTPaawXeYqzRYMCxwj+/vLaHJ4eJ0PWq4KfNv5h7Nxn+jy3v8sKg yaUdscdzQlXPeUX3tR7kreCcIil4HCvWBEkajL4CeM/IMsKWrZeEl6pya1IQQ4E4jPb/ wN0I5r5JIiNoOQUQwgTixwAOrWwLK3mWAEQ2XsIAD625+kMeedeDQikTijpIbpvd1cce E50Psmc9UHt7c9OBwnA7mDefKwmdmXuTObnw6edj5AfWYjkJivj8St4/lsfF5AcNrCyk O+IWA2csWHhVME6MsoVzP92CVUBivDZBMkzyuEUf9gEGX4WW1IBE1a2ves00vMDjFuM1 WstQ== X-Forwarded-Encrypted: i=1; AFNElJ8jaqvNiGTzmN+P31bN2WFluaGqBwMxo+y6KvAS++DM6jbPTPU2p6XCM8KbeTmEdpjH474s1LJJLTPO3mo=@vger.kernel.org X-Gm-Message-State: AOJu0YwPFFOoI7ffluLcJ0C82E45iwjbXH4fi8ytG1DRSIHdBYpWf9pv q7WmDQQI8UivbN6zjpZ3F7L3KmdpnorABsUu0i7ymaEu1OuoslEEXLjk X-Gm-Gg: Acq92OEFWpX7qCnYYYPkZKKkTNfP/DyX2FRKYHYZLUmeVASygZNGDKS4Ry6FMJL1hRe CtPSX78f+ct3QbRWFExeNcbawogIU2C8Su/lGP51ZSAqhZD3xmqL54Drjvm8ibuzKCU/vW2VUxg oeReA3wE5Z+HZP+Z4HXb9wmej6ZRSEYSnfo40D2Jr2byfjwvVXOJ8NuZGylWb8XdaoJu9uu1YQX tTz/TZDI5drVievHGoTI8VObWXY69J/GnoU9+YsUl7vrrslRjG/Nl4C7RwTb/Yb1uZJ3FuD6EtX cH0RL/Zqz/6fy0X+/o55JWqDdsbJABM5k61S4Af1yviIJiugcAHZPxRxD38gYh4PiE8mpfgjl4K tXz+Balx3wVDppEDYp4eUgkG2YtdOiT4NrLhxyNVNzgweV4kpEXAn+9VTobiqIHq0R9KXuzOtae Q0bj8o8wcFnYQ6NMWhCVwHXu5BhzWthKUQNyfNjcQ47fu6EsG1V/g/huc1HfhWX5RijvSewc39Q Wu9VTeyyrNH3xHt230qNK4u2EhNQyfI4INpm0VZUOA+5w== X-Received: by 2002:a17:902:ce8c:b0:2c0:b74f:a58c with SMTP id d9443c01a7336-2c0b74fa708mr49690175ad.16.1780286590607; Sun, 31 May 2026 21:03:10 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf23c0d727sm88051055ad.59.2026.05.31.21.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 21:03:10 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rosen Penev , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net] net: ibm: emac: mal: fix unchecked platform_get_irq return values Date: Sun, 31 May 2026 21:02:52 -0700 Message-ID: <20260601040252.103585-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" platform_get_irq() returns a negative errno on failure. Commit c4f5d0454cab5 moved the platform_get_irq() calls and explicitly removed the error checks that were previously present, claiming devm_request_irq() can handle it. However, a negative IRQ number passed to devm_request_irq() fails with -EINVAL instead of propagating the real error from platform_get_irq(). Restore the missing error checks with proper errno propagation. Fixes: c4f5d0454cab5 ("net: ibm: emac: mal: move irq maps down") Assisted-by: Opencode:Big-Pickle Signed-off-by: Rosen Penev Reviewed-by: Jacob Keller --- drivers/net/ethernet/ibm/emac/mal.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/ethernet/ibm/emac/mal.c b/drivers/net/ethernet/ibm= /emac/mal.c index 7d70056e9008..63a7a32aaf72 100644 --- a/drivers/net/ethernet/ibm/emac/mal.c +++ b/drivers/net/ethernet/ibm/emac/mal.c @@ -635,6 +635,12 @@ static int mal_probe(struct platform_device *ofdev) mal->txeob_irq =3D platform_get_irq(ofdev, 0); mal->rxeob_irq =3D platform_get_irq(ofdev, 1); mal->serr_irq =3D platform_get_irq(ofdev, 2); + if (mal->txeob_irq < 0 || mal->rxeob_irq < 0 || mal->serr_irq < 0) { + err =3D mal->txeob_irq < 0 ? mal->txeob_irq : + mal->rxeob_irq < 0 ? mal->rxeob_irq : mal->serr_irq; + dev_err_probe(&ofdev->dev, err, "failed to get IRQ\n"); + goto fail2; + } =20 if (mal_has_feature(mal, MAL_FTR_COMMON_ERR_INT)) { mal->txde_irq =3D mal->rxde_irq =3D mal->serr_irq; @@ -643,6 +649,11 @@ static int mal_probe(struct platform_device *ofdev) } else { mal->txde_irq =3D platform_get_irq(ofdev, 3); mal->rxde_irq =3D platform_get_irq(ofdev, 4); + if (mal->txde_irq < 0 || mal->rxde_irq < 0) { + err =3D mal->txde_irq < 0 ? mal->txde_irq : mal->rxde_irq; + dev_err_probe(&ofdev->dev, err, "failed to get IRQ\n"); + goto fail2; + } irqflags =3D 0; hdlr_serr =3D mal_serr; hdlr_txde =3D mal_txde; --=20 2.54.0