From nobody Mon Jun 8 07:22:04 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3677E30C34A for ; Mon, 1 Jun 2026 04:02:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780286542; cv=none; b=VsyWaz4KIkYrIxSGFS3KfzVzhjNq6LfatGSo2zD5UvAN7l3htAAH88+0AzqM8VXiVl02zrtD1rKw1qoiujdyDfttJcQIJg2I/540T0ch8JsBHvlgyX0ouhmdtELrJIhMxatApVWupZfN7Ck7taCrbApBVQDXW4BXbnhXw9OTjhI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780286542; c=relaxed/simple; bh=oBWlFqSYNupq4ewBKx8UZ2w1zhEz05NH6Rf/ECMAuD4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ct2iKN4mel8XsS0YO7r40B96Eo5EHoSXZh8fZtt5qH1eylXK10L50uFRrFEPfx/FmlBe/lOMiCK4GvzrbkUJed5aaiiNkR3SmvqmWNNTNr9AdTGH0Gexf6YarYF6dWPRs7CueKgHtsl7Hffi6YNxOyUC/wZacOjdbFbIVDCj/Fo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ldYhKrbs; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ldYhKrbs" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2c0bd02d97eso11476925ad.2 for ; Sun, 31 May 2026 21:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780286539; x=1780891339; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QihYH7Rm1RkNSAWcotfRWjgzTDwvvgHIgGXWTnmhaiE=; b=ldYhKrbsKXiHZoRaelilJ7TJnj0IXwX4wPNAARtMLOICBlPe3AUcxUPHDQiMFu2bsJ z9Cvbw6kmeoW7TL/zsqaZnPihSyTAP7BzCo58kBitNp9qtyIwobuixDqctrp4aisHKu9 ZEBMfFfsqc65uMtoPi1UB6VxT8wUzONVkSESgd7tEyyB/uKnd0VWcQYrzQr/FiaHJswC 8V4ZHWBAK98ifwU6Sy6Sf+JdGkPvMQVNC/ZBhZIMqBs79Ju+9dZISEbzo+Hslw2xjsb+ 1qSFbBVj58sPYwTHt2SSXI18Do0Zafu8xTVXOzCQUAbuE0Xam4ITL7/c/GAOZrkpMoHK Hq9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780286539; x=1780891339; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QihYH7Rm1RkNSAWcotfRWjgzTDwvvgHIgGXWTnmhaiE=; b=HKXbnCL0w/9ttxIYjXDrkZeeOaZAFcJTb+jYix8ERhhFqNoYpoELJnjnk0l2Tl4Jhr lMcMpMKRK5rASWKcc+V3E1EANDHFCcXD4sAm+iVBwaUDw2IKzU4PrmvBuTLG+4ZW36nN Yp0Z3yo+OrtXhRS9cl0msLMNS3h6tw5F5hVQrJ6eJAmKWLJwkihkPCHfRdy3QRrshL+w N3PdzE9M2jxGiULTmRH3budypuTNVry6EwOeYfNRPCHPeo39sO+ikzH7OW7jiJXOQYtf 3/EMioSJV/xhuBESZRCfULPV4dhDBm0fCySUTTURiqGLm9vTqM5ruNTGSZr1lX2WA4P/ yf5Q== X-Forwarded-Encrypted: i=1; AFNElJ8BcZp7N8wkplCVvwWKJ0ig6DraKKPb0/phA0F/112eoz38/h0ZRJtB3Z/rnhlvcY7Nnnfv469LhWpy+/w=@vger.kernel.org X-Gm-Message-State: AOJu0YxbsVvKYtBAG6oWUVssQ9YS7UNvK9HjnuDxNHaUo2jw4BjiC51C Jhj5paBtuFi5E3zcKpwycngxPZ7PpPbRoU5LPUxV9Kv0BqA9wBYMjwFV X-Gm-Gg: Acq92OEvgafz1NpymTTbHy9ktN2RkmMIwOWMbH1LW6DN/VBHtGYCDR8cmu239XqhkNR 8pH8hVAfoZxgRFs0c8eofAg7olmH/YVUBOp1y8CQdjvKLTZoLC1yEQ2RyaqISRbUxm9KlJIoIe2 M32KZyQYqL4Ioo3Dzf27KgIaSd0orrGSxPvIyxY0/jNl0Xzk1V3q9g9lWOoUJtcjWBHcrmLfh1X zQmttUJ7YJ2MfhWH6A8SUtw5BUIkQJRGwDjvtFuZ2a7eCfOuIdWAL244mpkXxPGTRIxqJEByCEw xUJlnjknxBbWc5vth96itpa+RhjIsNFG1/w1aa4eOKxM93L2QnNN4k0FQ7YMrBMYaeM4NwOinzs 1rla3O0UvwwkleJPTY0FCFfapofxqSrVjzGN/i1+ksTYmcOK4zSqyqNqvt0sR5BImsFVX0Cz3B0 SsbhaCb/zepTMaRJSnkCpaSEVCzE20AzBKbaQHx7hRIrlqVjdeQQ+XZ7JsPG+bDc0+OV9kKgHge YqTkGBb4xu0V2/PwS6edi3rpPYBYBfnPVyL7rcRKqSGsw== X-Received: by 2002:a17:902:e785:b0:2c0:d91d:c3e8 with SMTP id d9443c01a7336-2c0d91dc475mr30476015ad.4.1780286539433; Sun, 31 May 2026 21:02:19 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf23c580c6sm92091935ad.82.2026.05.31.21.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 21:02:17 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shannon Nelson , Simon Horman , Rosen Penev , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net] net: ibm: emac: fix unchecked platform_get_irq return value Date: Sun, 31 May 2026 21:02:00 -0700 Message-ID: <20260601040201.103481-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" platform_get_irq() returns a negative errno on failure. Commit a598f66d9169 replaced irq_of_parse_and_map() (which returns 0 on failure) with platform_get_irq() but dropped the error check. Without it, a negative IRQ number is passed to devm_request_irq(), which fails with -EINVAL instead of propagating the real error from platform_get_irq(). Add the missing error check and goto err_gone. Fixes: a598f66d9169 ("net: ibm: emac: use platform_get_irq") Assisted-by: Opencode:Big-Pickle Signed-off-by: Rosen Penev Reviewed-by: Jacob Keller --- drivers/net/ethernet/ibm/emac/core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ib= m/emac/core.c index e597e2ad434c..d2194b406c9e 100644 --- a/drivers/net/ethernet/ibm/emac/core.c +++ b/drivers/net/ethernet/ibm/emac/core.c @@ -3035,6 +3035,11 @@ static int emac_probe(struct platform_device *ofdev) =20 /* Setup error IRQ handler */ dev->emac_irq =3D platform_get_irq(ofdev, 0); + if (dev->emac_irq < 0) { + err =3D dev->emac_irq; + goto err_gone; + } + err =3D devm_request_irq(&ofdev->dev, dev->emac_irq, emac_irq, 0, "EMAC", dev); if (err) { --=20 2.54.0