From nobody Mon Jun 8 06:38:19 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD6EA3B0AE1 for ; Mon, 1 Jun 2026 13:55:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780322120; cv=none; b=N5R8bQnfH4KEkS1zFHRvm/SmwRHYplmoARHr7foPDBZezBVa33m/DZuID4oW6rGgFyw7PLBjBMgooc+gGS1cfHVeUDOvfkkL7J5/RKjQNnIvQeKAOz8RyJMtS9kqx2IvToVaidkt2VX6D4pdTa83z/4rYucjGKhq6syQswUXn4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780322120; c=relaxed/simple; bh=pcLLBYhd55OMdrR5lQY/SUwDurCQI0yLUgsM9xlx3jo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=VLs1R41AzjZij7xA1pghH+yTNsMS6tFI13j+1XKrJEKUhUiYQvnvWSSoaS50/EYhAPTZi67QDSB/TP0ORCzo5HinZDye0/ExNKHnd+wxcB1QT6yq8RpgdotixU6XzptTHG28iemdFSKAsP6EBI4Ms5gQV97K2t8rc17veQLP2nc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oPDk3QCB; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oPDk3QCB" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-46015dc517aso405604f8f.2 for ; Mon, 01 Jun 2026 06:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780322117; x=1780926917; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=szNmvRqcNNVrQ+k0EalWeikL/uP5KXrlLB2qyTZSbeQ=; b=oPDk3QCB0bbLOmrs7pcoteTSJh/htzJDnkNaIqgWuIEiWWxGwdxSQsYFL5VT3/BUSU Lq0YXmyQ4DBUNtj4mBYnUdUdSfhVU8fILP79wpUtzeRwyoZHi3eyJrA8xVlZA9RMGgqf jxnxJJmzgUQCIvNcztQoDtVru+UlBZWOXA7qlq+iE9pgRE5tzj8X7/q2T8p3AEQTigN6 hjnDES0CpE3f0Qw0nwVNvP0oqeCPECImW1bLdgIla4Zkc7YLFbK/JquSe40NYROAoFl6 cr1/77qxPGFL01vJL4aTu4+mYrDADMQle2uxmqWhEBkOUtdW+8SIJhNwA5emh/Edf4yP TjQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780322117; x=1780926917; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=szNmvRqcNNVrQ+k0EalWeikL/uP5KXrlLB2qyTZSbeQ=; b=ls75X4KIdOWK8APvXPbckUJprKsblWGyXWOqcm6WqKxOggM01mgZbxQVszGysxYhUt oE9oP++8ueVcKh2T7jrvnLE/fN1o60UF4eUsviPcI/LhK8S+CTA3hGJFjXOqJ4G7TrUe znzjZOUtdjPRnUYbWXnS4sp9dE1AzAOnT6SpunlQq01CPrzYBIM68X0w0fSLoD+QP/bD zZ+Ls6Ul12NKRD+ka09bAj9LXZgVV0odWmGdulxMjb58wQWmyRrlK3bs4gDlbuub9+Tx hZFxAjyH+OeUfgL1btqEXiI7ugMCAIvClmpUNh9oqcMSVPTlG6Zq/Rp542UeTn5HD2d8 iMog== X-Forwarded-Encrypted: i=1; AFNElJ8A9Oxb4hw+vZC7P/AAAU2HkSmz10td5tyzoz013sVY34SdHZ/ENPy9Qfjn01DY+6hHjllo5xejf1Z7ogg=@vger.kernel.org X-Gm-Message-State: AOJu0YxzFX9eJgIXdULQRNZ96cPdZkk1iC37KwIrDfGOa9+RtSBR6KkS Vr6ynZ8QxgJOHvjNSGA2YdPsAUnAjfkrY3pfNtKWzXR9aN18sDmJg3DaPl2t1csD0Y0875ppoXj /QRfnp08= X-Gm-Gg: Acq92OGV/rBlvDzV/lSw4KnPszoqPG6d9JeB1/3BRmhqcE3zeV4/Z5/PP63GPyscgl6 Nh2aisksy4FGgOJlTMzxY6aB5CXJoeOu5uPu/uRsrHFWMqb0jrVFe4RznOiFUaP1kC4ieEy3NEC kPBT8l24vlQmNrMuNP1T1eHZSHxQiKqc9zYaJ0r9q6bnD5851v+Bq07PjZOPmtYjkktu0vKwqQ9 FSTvd22c0rIbIBsMJsK2wGw2TW9AkVU5hM05FHc+Ot7ZfmP7Qnt545zOBKlssdV1GQ+FVHCdZKF kRnsFz2JlbFKrDRqF8NteDGHpXUrRVDbEmm7pgm2rMx5JEcJxpdJi9AyUcMMskTjuxppzBO13E1 bseo0aVqTUjQlAzPJ2JQpofk7Cn28UZ1woso+h+JZqT0qRMca83k+fVGbrhB3pCOUw3BYLzV4tj oWKtMJRODo3+dd3RdbNQDGPR4VtNnABaAVcQUbl6FyB6I42Uk= X-Received: by 2002:a05:6000:2812:b0:43c:f90b:5668 with SMTP id ffacd0b85a97d-45ef6b4f2b0mr16036177f8f.23.1780322117135; Mon, 01 Jun 2026 06:55:17 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff23:4410:4e6c:e715:40c0:8dfe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef35598e5sm23280289f8f.27.2026.06.01.06.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 06:55:16 -0700 (PDT) From: Stephan Gerhold Date: Mon, 01 Jun 2026 15:55:02 +0200 Subject: [PATCH] usb: typec: ps883x: Fix DP+USB3 configuration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-ps883x-usb3dp-fixes-v1-1-d19bec3a6d26@linaro.org> X-B4-Tracking: v=1; b=H4sIADWPHWoC/yXMQQqFMAxF0a1Ixj9QWyjqVsTBbxs1DrQ0KoK4d 6sOD4/7ThBKTAJNcUKinYWXOaP8FeDH/zwQcsgGrbRVVpUYparMgZs4EyL2fJCg0V7VVLtgewu 5jIneIYdt91k2N5Ffnyu4rhsXIy+ZdwAAAA== X-Change-ID: 20260601-ps883x-usb3dp-fixes-32c09e9bd6f6 To: Heikki Krogerus , Greg Kroah-Hartman Cc: Konrad Dybcio , Jack Pham , Abel Vesa , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 Commit 6bebd9b77726 ("usb: typec: ps883x: Rework ps883x_set()") introduced two regressions: 1. The CONN_STATUS_0_USB_3_1_CONNECTED bit is mistakenly written to the wrong configuration register (cfg1 instead of cfg0). This breaks USB3 when using USB3+DP adapters. 2. The switch-case fallthrough block is inverted: Currently, TYPEC_DP_STATE_C (DP-only) inherits the USB3 configuration, while TYPEC_DP_STATE_D (DP+USB3) is missing the necessary DP sink flags. Fix these by writing the USB3 bit to the correct register and swapping the case statement order so both states get their correct bits assigned. Cc: stable@vger.kernel.org Fixes: 6bebd9b77726 ("usb: typec: ps883x: Rework ps883x_set()") Signed-off-by: Stephan Gerhold Reviewed-by: Heikki Krogerus Tested-by: Jens Glathe --- drivers/usb/typec/mux/ps883x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/mux/ps883x.c b/drivers/usb/typec/mux/ps883x.c index 1256252eceed..c9bf4b4c2ba1 100644 --- a/drivers/usb/typec/mux/ps883x.c +++ b/drivers/usb/typec/mux/ps883x.c @@ -118,12 +118,12 @@ static int ps883x_set(struct ps883x_retimer *retimer,= struct typec_retimer_state CONN_STATUS_1_DP_HPD_LEVEL; =20 switch (state->mode) { + case TYPEC_DP_STATE_D: + cfg0 |=3D CONN_STATUS_0_USB_3_1_CONNECTED; + fallthrough; case TYPEC_DP_STATE_C: cfg1 |=3D CONN_STATUS_1_DP_SINK_REQUESTED | CONN_STATUS_1_DP_PIN_ASSIGNMENT_C_D; - fallthrough; - case TYPEC_DP_STATE_D: - cfg1 |=3D CONN_STATUS_0_USB_3_1_CONNECTED; break; default: /* MODE_E */ break; --- base-commit: 645d4eda1d0db0202ed8e4a2c3abb2ebce6b86ef change-id: 20260601-ps883x-usb3dp-fixes-32c09e9bd6f6 Best regards, -- =20 Stephan Gerhold