From nobody Mon Jun 8 05:30:46 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 345173D9DCF for ; Mon, 1 Jun 2026 15:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327511; cv=none; b=uk69Ikpy/b3+UESoE3YeMyCfIAFBffQOIV1BNZnDWcL/q9MgTpuSD7sM+dSg4mVGamaSeUPVkDc4r8Rg4NziJRGjeVy/XGC5mO1RkKb7/WOz6coY7Lroq+7WnUHfULjswwjOHJmLoinSvZH44sWBaLD0c430uvg5l5iLEmWqUJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327511; c=relaxed/simple; bh=rIK+8qwUbffbSCQ4JIm1hNQ6maO54VCXxjYbTZbIPiM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JWXoPiAIBigVDUruWcAa/oEQBX7A+iJamXJQm1KTRb/ZHdQdP3k7RMl4R7GcSDL3+ImaXM/CipYebDAiRraC3zIuLN0h9wxomM+IAJy4wNLS6e9P4a48I5Qo8PdgOhz8QbMKMCMkO616BDKg3BU+rW1SN5s4E7a2POtAUxwzwyQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DOB6pluO; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DOB6pluO" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490acbb0f89so5127225e9.0 for ; Mon, 01 Jun 2026 08:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780327502; x=1780932302; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bUz34f8AUlG0gLWcG1NhLV3GhNlUwZnNfPkE4XwZzQc=; b=DOB6pluOxeUX3Ir9YBxALM0EsOMygFW7rGUFJXizr5Zne/n7FhcYDCDqQyTxE9BJQJ ZIH6gKBW4GX9o86Owfl9b0MdVVK0cL07IhmaxqDXVYIsUnSDRh76KO4DkgkrQFkG8+tO /o+Ft92NBPMgHm2Inuclpxq9coURT4OSXEiR6qY2qK70yAfgggwNpWKewt6hRxVqIjpo 829iRiWITrNfcXob86qP9Ld6kuS5EGnqH5kbwMynQFVj8RMfX98ZXVf/b/F2xC0c77YT hnm8+uTFrOK/7oUWbr0i396s/qIZ3lJnVrENaPAcCvhWbHBQKnjcZCRzq2Ux9d42anc7 qlcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780327502; x=1780932302; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bUz34f8AUlG0gLWcG1NhLV3GhNlUwZnNfPkE4XwZzQc=; b=iYD0ofNAZFhnBVZwddMLu2+AQGrzAOaNOTLbZqW1UAAnG+KYXcqyiWHzKyjnxxX6wD VGaoarCIjnb8i6atvomt4oDAeqEk6SjOug9K7siLvqMKeWjMfiTVJ2Xda89YEWDbT26E 3ubiBTHcwML+cjjGtGI6pr8aF1mH+wlpumatW/H2sMab+2SdRtpvBPPugG4SmPco90KX hOdcuj2IWWCN2GijSx0VPvSPc2quhOvPXhUPV82Jhkbv4iRUjxI50AYL4S5FqYyad7YQ Ii4PeRzTeM4frzK90P2SGbdHxZOtvICMxweYmfWyikrC3UbRvYsQvHIDhjN38DcxHSJP ssoQ== X-Forwarded-Encrypted: i=1; AFNElJ/M73tQgPP9fwF/qYc63YpWehy3M82HgLb4uJLTX6xSUGg6S45gHwCFTIKZkwDwkzYVsYJpTPsNVHqzU5g=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9THyWT9uqVbPkexH9GcPoqGlf3uynYMmJ80H6/vS665k77fXf NVOeR1+u+T5naLPmJax2D6dpQPeMx0cKKZs6smiowZ4AE8Y0UQckfzI9 X-Gm-Gg: Acq92OGvz7mfYOCKnhIRYK7Nv/JFkMzZpK/N/OL5aBBKIBRhHfMofFPqTuEbCmwy/73 /B0RO4+ysKagrdQOtXA5HRlx3EbRSk+K/tigoQlfXFo7efzTslDgInUszno5Z8p+QStyfXh25ca hQ4G0BzpfRJTtGJJmCjPaCJKm1nZBYk4bdgNNkpE51dsqaKljZgCD9Zzivkz27PwOTanUAyU2cC gwKOVgRrN3mOBi1F8z0lOVfYZ0KuoWvpY6D7TgjbijtS3qnMKnIfKDh8Eq90dAtTs6el1dcLJTJ SNu9UgwpvbSVm+gccRwRaPOc7vHrVtLr8/TGonzc86eWkiBs2mjzt+cG0EyC0k09/TJJ1Q585ab ioowtmn7Hj09K4bD5G4kbVlOLcDwpRO8a1wjxTBqm2E2tc38tIMGqrFJCvYC+bR9JUlr500YKwt TbLV/BUjiWg2af9oQVeTu4iBnW3erY2WxHmPTncye3wYcZIwa0faQ2WuRRbT8v5aBfYedxR9F6X K5LfDQpbpCLC9kckZD7 X-Received: by 2002:a05:600c:8b01:b0:490:b06a:649e with SMTP id 5b1f17b1804b1-490b06a6547mr10113085e9.25.1780327502267; Mon, 01 Jun 2026 08:25:02 -0700 (PDT) Received: from [127.0.1.1] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b0e26050sm26035e9.9.2026.06.01.08.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 08:25:01 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Mon, 01 Jun 2026 17:19:55 +0200 Subject: [PATCH net-next v9 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-ksz87xx_errata_low_loss_connections-v9-1-fdbbb15592cb@exotec.com> References: <20260601-ksz87xx_errata_low_loss_connections-v9-0-fdbbb15592cb@exotec.com> In-Reply-To: <20260601-ksz87xx_errata_low_loss_connections-v9-0-fdbbb15592cb@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolai Buchwitz , Fidelio Lawson , Marek Vasut X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780327500; l=8207; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=rIK+8qwUbffbSCQ4JIm1hNQ6maO54VCXxjYbTZbIPiM=; b=6qpSaYGclTV5E2vuVNO0bzimLpsVJ9OfNNREUmK+pX2WBd99j/g2UZuDRt9WJUjIrkotZrfpL IcH/lNbJcXEA3l2xxyj/LSTlyfVlKmD+n6g4RFlpShxAsz/vS6ULcgl X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Implement the KSZ87xx short cable workaround. This patch implements the KSZ87xx short cable erratum described in Microchip document DS80000687C for KSZ87xx switches and the following support article: Link: https://support.microchip.com/s/article/Solution-for-Using-CAT-5E-or-= CAT-6-Short-Cable-with-a-Link-Issue-for-the-KSZ8795-Family The issue affects short or low-loss cable links (e.g. CAT5e/CAT6), where the PHY receiver equalizer may amplify high-amplitude signals excessively, resulting in internal distortion and link establishment failures. KSZ87xx devices require a workaround for the Module 3 low-loss cable condition, controlled through the switch TABLE_LINK_MD_V indirect registers. This change models the erratum handling as vendor-specific Clause 22 PHY registers, virtualized by the KSZ8 DSA driver and accessed via ksz8_r_phy() / ksz8_w_phy(). The following controls are provided: - A boolean =E2=80=9Cshort-cable=E2=80=9D preset, which applies a documente= d and conservative configuration (LPF 62 MHz bandwidth and DSP EQ initial value 0), and is the recommended interface for typical use cases. - Separate LPF bandwidth and DSP EQ initial value controls intended for advanced or experimental tuning. These are orthogonal and independent, and override the corresponding settings without requiring any specific ordering. The preset and tunables act as simple setters with no implicit state machine or invalid combinations, keeping the API predictable and aligned with the KISS principle. The erratum affects the shared PHY analog front-end and therefore applies globally to the switch. Reviewed-by: Nicolai Buchwitz Reviewed-by: Marek Vasut Signed-off-by: Fidelio Lawson --- drivers/net/dsa/microchip/ksz8.c | 89 ++++++++++++++++++++++++++++++= ++++ drivers/net/dsa/microchip/ksz8_reg.h | 23 ++++++++- drivers/net/dsa/microchip/ksz_common.h | 4 ++ 3 files changed, 115 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz8.c b/drivers/net/dsa/microchip/k= sz8.c index 0f84b2e7d25d..4ec2d5d2a1bc 100644 --- a/drivers/net/dsa/microchip/ksz8.c +++ b/drivers/net/dsa/microchip/ksz8.c @@ -798,6 +798,40 @@ static int ksz879x_set_loopback(struct ksz_device *dev= , u16 port, u16 val) stat3); } =20 +static int ksz87xx_apply_low_loss_preset(struct ksz_device *dev, bool enab= le) +{ + /* Apply the Microchip erratum short-cable preset (LPF 62 MHz, EQ init 0) + * providing a conservative configuration for short or low-loss cables. + */ + u8 lpf_bw, eq_init; + int ret; + + lpf_bw =3D KSZ87XX_PHY_LPF_62MHZ; + eq_init =3D KSZ87XX_DSP_EQ_INIT_LOW_LOSS; + + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + + if (!enable) { + /* Restore default values (LPF 90 MHz, EQ init 15). */ + lpf_bw =3D KSZ87XX_PHY_LPF_90MHZ; + eq_init =3D KSZ87XX_DSP_EQ_INIT_FACTORY; + } + + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_PHY_LPF, lpf_bw); + if (ret) + return ret; + + dev->lpf_bw =3D lpf_bw; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_DSP_EQ, eq_init); + if (ret) + return ret; + + dev->eq_init =3D eq_init; + + return ret; +} + /** * ksz8_r_phy_ctrl - Translates and reads from the SMI interface to a MIIM= PHY * Control register (Reg. 31). @@ -1046,6 +1080,22 @@ static int ksz8_r_phy(struct ksz_device *dev, u16 ph= y, u16 reg, u16 *val) if (ret) return ret; =20 + break; + case PHY_REG_KSZ87XX_SHORT_CABLE: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D !!(dev->lpf_bw =3D=3D KSZ87XX_PHY_LPF_62MHZ && + dev->eq_init =3D=3D KSZ87XX_DSP_EQ_INIT_LOW_LOSS); + break; + case PHY_REG_KSZ87XX_LPF_BW: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D dev->lpf_bw; + break; + case PHY_REG_KSZ87XX_EQ_INIT: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D dev->eq_init; break; default: processed =3D false; @@ -1272,6 +1322,41 @@ static int ksz8_w_phy(struct ksz_device *dev, u16 ph= y, u16 reg, u16 val) if (ret) return ret; break; + case PHY_REG_KSZ87XX_SHORT_CABLE: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + dev_info_once(dev->dev, + "KSZ87xx low-loss tuning is global, applied switch-wide\n"); + ret =3D ksz87xx_apply_low_loss_preset(dev, !!val); + if (ret) + return ret; + break; + case PHY_REG_KSZ87XX_LPF_BW: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + dev_info_once(dev->dev, + "KSZ87xx low-loss tuning is global, applied switch-wide\n"); + /* Only accept LPF bandwidth bits [7:6] */ + if (val & ~KSZ87XX_PHY_LPF_MASK) + return -EINVAL; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_PHY_LPF, (u8)val= ); + if (ret) + return ret; + dev->lpf_bw =3D val; + break; + case PHY_REG_KSZ87XX_EQ_INIT: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + dev_info_once(dev->dev, + "KSZ87xx low-loss tuning is global, applied switch-wide\n"); + /* Only accept DSP EQ initial value bits [5:0] */ + if (val & ~KSZ87XX_DSP_EQ_VALID_MASK) + return -EINVAL; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_DSP_EQ, (u8)val); + if (ret) + return ret; + dev->eq_init =3D val; + break; default: break; } @@ -2070,6 +2155,10 @@ static int ksz8_setup(struct dsa_switch *ds) return ret; } =20 + /* Initialize KSZ87xx short-cable preset control */ + dev->eq_init =3D KSZ87XX_DSP_EQ_INIT_FACTORY; + dev->lpf_bw =3D KSZ87XX_PHY_LPF_90MHZ; + ret =3D ksz8_handle_global_errata(ds); if (ret) return ret; diff --git a/drivers/net/dsa/microchip/ksz8_reg.h b/drivers/net/dsa/microch= ip/ksz8_reg.h index 332408567b47..981ab441d9b7 100644 --- a/drivers/net/dsa/microchip/ksz8_reg.h +++ b/drivers/net/dsa/microchip/ksz8_reg.h @@ -202,6 +202,10 @@ #define REG_PORT_3_STATUS_0 0x38 #define REG_PORT_4_STATUS_0 0x48 =20 +/* KSZ87xx LinkMD registers (TABLE_LINK_MD_V) */ +#define KSZ87XX_REG_DSP_EQ 0x08 /* DSP EQ initial value */ +#define KSZ87XX_REG_PHY_LPF 0x4C /* RX LPF bandwidth */ + /* For KSZ8765. */ #define PORT_REMOTE_ASYM_PAUSE BIT(5) #define PORT_REMOTE_SYM_PAUSE BIT(4) @@ -342,7 +346,7 @@ #define TABLE_EEE (TABLE_EEE_V << TABLE_EXT_SELECT_S) #define TABLE_ACL (TABLE_ACL_V << TABLE_EXT_SELECT_S) #define TABLE_PME (TABLE_PME_V << TABLE_EXT_SELECT_S) -#define TABLE_LINK_MD (TABLE_LINK_MD << TABLE_EXT_SELECT_S) +#define TABLE_LINK_MD (TABLE_LINK_MD_V << TABLE_EXT_SELECT_S) #define TABLE_READ BIT(4) #define TABLE_SELECT_S 2 #define TABLE_STATIC_MAC_V 0 @@ -729,6 +733,23 @@ #define PHY_POWER_SAVING_ENABLE BIT(2) #define PHY_REMOTE_LOOPBACK BIT(1) =20 +/* Vendor-specific Clause 22 PHY registers (virtualized) */ +#define PHY_REG_KSZ87XX_SHORT_CABLE 0x1A +#define PHY_REG_KSZ87XX_LPF_BW 0x1B +#define PHY_REG_KSZ87XX_EQ_INIT 0x1C + +/* LPF bandwidth bits [7:6]: 00 =3D 90MHz (default), 01 =3D 62MHz, 10 =3D = 55MHz, 11 =3D 44MHz */ +#define KSZ87XX_PHY_LPF_MASK GENMASK(7, 6) +#define KSZ87XX_PHY_LPF_90MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 0) +#define KSZ87XX_PHY_LPF_62MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 1) +#define KSZ87XX_PHY_LPF_55MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 2) +#define KSZ87XX_PHY_LPF_44MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 3) + +/* Low-loss workaround DSP EQ INIT VALUE */ +#define KSZ87XX_DSP_EQ_VALID_MASK GENMASK(5, 0) +#define KSZ87XX_DSP_EQ_INIT_LOW_LOSS 0x00 +#define KSZ87XX_DSP_EQ_INIT_FACTORY 0x0F + /* KSZ8463 specific registers. */ #define P1MBCR 0x4C #define P1MBSR 0x4E diff --git a/drivers/net/dsa/microchip/ksz_common.h b/drivers/net/dsa/micro= chip/ksz_common.h index b67038cf1bd0..45613b9aeb1e 100644 --- a/drivers/net/dsa/microchip/ksz_common.h +++ b/drivers/net/dsa/microchip/ksz_common.h @@ -222,6 +222,10 @@ struct ksz_device { * the switch=E2=80=99s internal PHYs, bypassing the main SPI interface. */ struct mii_bus *parent_mdio_bus; + + /* KSZ87xx low-loss tuning state */ + u8 lpf_bw; /* KSZ87XX_PHY_LPF_* */ + u8 eq_init; /* DSP EQ initial value */ }; =20 /* List of supported models */ --=20 2.54.0 From nobody Mon Jun 8 05:30:46 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 007183DB31D for ; Mon, 1 Jun 2026 15:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327509; cv=none; b=efEqYahnUXT9LaNqgj0yqLzXo4E8BpqmQPmjpjIJO6BffojofMYGXT+lqtI8zjrHNHOmo5rfrG815gJu1uBx4CR3ASml5DCGYRS3Uc/CHl89HzMimak7RtaWswfy/2W6zATPS3z+tfNkHqSK7YVqmQkneDTud8zt79N7BoIu1sM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327509; c=relaxed/simple; bh=52onxtZqZKJ077Jn2t4aGL/qYm9bdgzCixapPxXr94k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CGhh9KUyWIsGs6imxj+vWtjhwWAatgaJu7qEAvrZtooXNlyXjQVDV62QSfwftVvOP4fWHH8Fo6cqe6PaROj1nM/lkBxLTZvVA19CmctmlY6OEPrPID4jGLh7e2esHjWBGcdCGVaCKb3jgvBkbxZ+S0PCHrvM5/NzBiVH6urtqu4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nJ5iYbJF; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nJ5iYbJF" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-490a762db7aso10899665e9.0 for ; Mon, 01 Jun 2026 08:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780327503; x=1780932303; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TwdlyjOEGoLEOnu8PlPpT2qsoqG2kN0gtcCpk4MmNhk=; b=nJ5iYbJFey9HT9aFA9eN3yTf3VRDDZFdgqQGKr0alBWih1nfIHo+PiWL0pSkJRqiou FoOdFPvYvLaq8w615kua9vA9maeXFm38y5pbvfmOEj0dghJ4qLOoQ1yqn+1YO55Kbt7s QSWFHGtzqux/cnZZQStFPEcaYWBoul9D+NmT/YDsnHYHHeDX9LOykbv7s0NNqoIwSFKU WDCYVoTdoeVt/L6EWV2nwK26bHk50XL98u6pZ3rDYnMQ0G7QQojbGzwBonIq0VVMbnK9 rA9ssIXKe5Tg7J0zXRpLIpNmc4dt4FSgm6rssw6p27k2mGjrM6K2ia1zvfcrhQ2He9NV HArQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780327503; x=1780932303; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TwdlyjOEGoLEOnu8PlPpT2qsoqG2kN0gtcCpk4MmNhk=; b=GBo1rijLEdDf4pjNzUoRsMJIFQLu+B1zDMPkW0h51rWvyFy2DA+FEFWy7NIBEiPPcC n2mNbJpRScQ+yzAbRIoIL/OD3cvvasjw6MzmpySt62bX0a4bK8kZm+0m11zU6cc3jgwl Mz8GAso03BdUANJqSz9tpaADcofUKz8MNQ6yNSkAOM+3T5l1IhXF3J8MSAlH6xV3D7p/ TF3kNJF3poW+kKh2XirFmJbQdoayS60yGlHo4/bEZ+lWMmaK/8VWrVRpIE3zytY/FysR WsBuuT7ygW6HREGSg7YEd6VSfWHUUIFtBZBUI3rMRHK0H9evhK2Cb6QfFSythWYYu7WQ E+1g== X-Forwarded-Encrypted: i=1; AFNElJ8QHlKbHnnTEtvhUVB3QjcBt4mhsoXLDEihJIQXke03cfnP6kikJVjMgKTebJuLNLTs6r6RzRHHAIBTtrY=@vger.kernel.org X-Gm-Message-State: AOJu0YwHTWPtwdfXD/PBZQGosn5K6cq5HF6FVl889Wl6MpyFpKn9lUZy hVxVCgKu7hVQsTMQ5cdG7zL0cJ85oblH+/9hdNQhk1fTcx1261Hx9WOP X-Gm-Gg: Acq92OGQ2gXSeGTM/T84u4Vwp/by7KY1LGhG9haYTN8bwQxFozxIxd0F9hnzJVWD1iG 93Sk7et0CHONkNsmnICsCTaTy4zUcAXTbdoemFGz6wC7KK6HsoC4bTK4Dt5YFHJbjfoiW27Y42s lyUuii8Vkfusad8/o0YQ4KJD2IWH5VA74LRvFXTa+ir1jWMty1yaG2bSbYaV5hSqXDGq6uD1JJG Ya8efvnSmro1JNqaaYBS/VEheZoA0bmaCvp8k2E/P8tESpwyCcEpkaHfHVeAJMkV6N/P6GTy4sh tfkaIq2k2Mz+htvCpZc3K19qHLUQnXh4g1gi4IzKk6DwSSUjQy2WZpFe/Svp9eF+oI67XMoTVTw ZN//sJtMP9Gcx3HbhMbOzcz98uL+jNuw+hFEgiUWhUmPWb3QnfAIoxizNaCyG38mzNaqOPq6Vea jT86P7AvVNg+fjZSnTSFnZ/0YLTp5OgVVlq0kjlgLXeA7oPjiH8Vc1Hy8t8GzGyhNjZPGSx1iQe mO4RNn1x0QYmQZ5Eql4 X-Received: by 2002:a05:600c:6592:b0:490:a1dc:e542 with SMTP id 5b1f17b1804b1-490a2904ab0mr231921935e9.6.1780327503254; Mon, 01 Jun 2026 08:25:03 -0700 (PDT) Received: from [127.0.1.1] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b0e26050sm26035e9.9.2026.06.01.08.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 08:25:02 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Mon, 01 Jun 2026 17:19:56 +0200 Subject: [PATCH net-next v9 2/3] net: ethtool: add KSZ87xx low-loss cable PHY tunables Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-ksz87xx_errata_low_loss_connections-v9-2-fdbbb15592cb@exotec.com> References: <20260601-ksz87xx_errata_low_loss_connections-v9-0-fdbbb15592cb@exotec.com> In-Reply-To: <20260601-ksz87xx_errata_low_loss_connections-v9-0-fdbbb15592cb@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolai Buchwitz , Fidelio Lawson , Marek Vasut X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780327500; l=2676; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=52onxtZqZKJ077Jn2t4aGL/qYm9bdgzCixapPxXr94k=; b=84q6A1cCirRAqZTuX0NHOBQerjgJ5Vtn5lqw7hTHKGi9bEPwHCXIOzbNK0d8Hj2j1RzWSEUNg zZD7lTyKlBzDjrbNeVgMD70rK4xf2vD0r0LxpUCLUEaQhSFwlNcSH2w X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Introduce vendor-specific PHY tunable identifiers to control the KSZ87xx low-loss cable erratum handling through the ethtool PHY tunable interface. The following tunables are added: - a boolean "short-cable" tunable, applying a documented and conservative preset intended for short or low-loss Ethernet cables; - an integer LPF bandwidth tunable, allowing advanced adjustment of the receiver low-pass filter bandwidth; - an integer DSP EQ initial value tunable, allowing advanced tuning of the PHY equalizer initialization. The actual behavior is implemented by the corresponding PHY and switch drivers. Reviewed-by: Marek Vasut Reviewed-by: Nicolai Buchwitz Signed-off-by: Fidelio Lawson --- include/uapi/linux/ethtool.h | 3 +++ net/ethtool/common.c | 3 +++ net/ethtool/ioctl.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 1cdfb8341df2..a2091d4e00f3 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -291,6 +291,9 @@ enum phy_tunable_id { ETHTOOL_PHY_DOWNSHIFT, ETHTOOL_PHY_FAST_LINK_DOWN, ETHTOOL_PHY_EDPD, + ETHTOOL_PHY_SHORT_CABLE_PRESET, + ETHTOOL_PHY_LPF_BW, + ETHTOOL_PHY_DSP_EQ_INIT_VALUE, /* * Add your fresh new phy tunable attribute above and remember to update * phy_tunable_strings[] in net/ethtool/common.c diff --git a/net/ethtool/common.c b/net/ethtool/common.c index 84ec88dee05c..a24d3a8a9ec1 100644 --- a/net/ethtool/common.c +++ b/net/ethtool/common.c @@ -101,6 +101,9 @@ phy_tunable_strings[__ETHTOOL_PHY_TUNABLE_COUNT][ETH_GS= TRING_LEN] =3D { [ETHTOOL_PHY_DOWNSHIFT] =3D "phy-downshift", [ETHTOOL_PHY_FAST_LINK_DOWN] =3D "phy-fast-link-down", [ETHTOOL_PHY_EDPD] =3D "phy-energy-detect-power-down", + [ETHTOOL_PHY_SHORT_CABLE_PRESET] =3D "phy-short-cable-preset", + [ETHTOOL_PHY_LPF_BW] =3D "phy-lpf-bandwidth", + [ETHTOOL_PHY_DSP_EQ_INIT_VALUE] =3D "phy-dsp-eq-init-value", }; =20 #define __LINK_MODE_NAME(speed, type, duplex) \ diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index bd97f9b9bf18..fc2542422824 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -3114,6 +3114,9 @@ static int ethtool_phy_tunable_valid(const struct eth= tool_tunable *tuna) switch (tuna->id) { case ETHTOOL_PHY_DOWNSHIFT: case ETHTOOL_PHY_FAST_LINK_DOWN: + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + case ETHTOOL_PHY_LPF_BW: + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: if (tuna->len !=3D sizeof(u8) || tuna->type_id !=3D ETHTOOL_TUNABLE_U8) return -EINVAL; --=20 2.54.0 From nobody Mon Jun 8 05:30:46 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBA5B3DB33E for ; Mon, 1 Jun 2026 15:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327510; cv=none; b=WX7Y0vp1qvq2sDNn9ynBF9Rqp4N5Z7vB2yofYvlTXKJLFrumoxJBnsB+4myGVl/g54xgrCK64mV+StelKzJQeJ5JsDDgB/bFj3e08uLTyYsTlJ2MF0/465k4DAUWcR8hOIAmhYtM3iQrGwbj5k/WIqDj44T0+GuH4vwgItbBQ1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327510; c=relaxed/simple; bh=zjoxIx46y8e3QGMsOJPRBZDqL8SBHdoXyjTLZD2h7K8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UNKfVLFzbBaCpNgJxV2IqlZGIrGBMKLFVLexVOGBOFucUFRZ0YXtdkLYwvreCkIjvVtoUyAkIsGyGOfXYKFyKGKfILtOHnPhoLAwYaDVD4rJMaW5jMmOulLY/jd/TaOUCKoUu1zqqbVZnh559b7fDEh0bma4gtV6r8pWwsdSMTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MaprHK22; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MaprHK22" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-490aebf33e9so3821475e9.3 for ; Mon, 01 Jun 2026 08:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780327505; x=1780932305; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=09FJYvxDkOz5j8LvOo37RoLQK56TcPEBDxr1UHNCmLc=; b=MaprHK22gVjFSxN5AIcOs9rzqZez0kYTijqpzaR4A60mDMpI+/e++oG9/FzxJ9UWpf kOXSdpfsl8SmI43Pe6tymS7nA6cijVFwPXFMZLoDk6BDT88HuEG9ZCovWMPmCuDrmcCt DhrSCK24ODk3coqZZm3X9xVSEQLbNOMcrkMhxqHG9HbTtlJ7ZPq6tNZp82M5rW+xgxXW Y7G0xoiGNyGaKzs4kBrYOnXfb/+ql0SdilELaawUBkJhRjCCmEoGxWXSFwi96sa5fwcf pIZwww9PezDMWH+3JFDpbptl92Xz90qA+sYG1xDcGJuIJaoUkp7yYXJFp5MPJXdPbbgY 1pZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780327505; x=1780932305; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=09FJYvxDkOz5j8LvOo37RoLQK56TcPEBDxr1UHNCmLc=; b=KSRQANkj2v8yNW5GMeFlddSPYUMb+D4AaLgXqE8vohdg1/YIKpEna1FUmKgsV56xg8 +QJPEuNkX91PcTs9fYiZDOZRgolPgp/n9vL7pw0l2/u6piO7+33CLSY7JQ0VgNaJrS/Y lMqeMw7XcNsUQKtyD/BCm2e/fpA4bcDpEPtZAe2aLh5g2UcD/lc4MGQKCs88OkAr9x0m AlBBVvXlhumHFnDAmYLWV5IldQ9YHFYcK69b8v2JABOXUGVr+e8nuGLRoBkXjbCJpZ1e 3O+cTUZP8Lj7RRcgXQAEm9gbRo413tiEWuVQ/6PqISj4/rNZ6YR+y5A0VRFQNpsU7+Yr UpAw== X-Forwarded-Encrypted: i=1; AFNElJ8uoO2qstHTnBPI+GNUzCWKppsPvsrTCJTv/6RMRLk4d6OorjzdiCXcyEVuSsOqn1PrGIUCjiMiiyEZx9w=@vger.kernel.org X-Gm-Message-State: AOJu0YzDdIhBoTisLLGOq5SqxNwYkeleQrseyI90Zx7fBfTcmT31OjsY 58euGn9zhNn5eUljCNCfO21dVHX8LvVvHYkWkqO1P634M6u2QaySk0HV X-Gm-Gg: Acq92OF1p9ZQ+5KjmDFLG9mc3Sr5emzELH1coCznZ2lGVsc3l97tDPDxb8YxPZIyVOM 71711fNOx/EnNGt8rUdPFnqRVXbrigNsklSilrHtEknEYWtFuEGVAyWElHtqq+5TS5GZVGeCysU /KfADYhBx+oqiVT9rf+hBaF4+PQUzr0quf5ScohX59iLBNrf3pcoM8lf6zDZqfM5wl4/HPSZh0e /yUat7dU7PspjsJtBBKY8HVrf3SpKOHYR1YLDE8Z4Sy3eST2tkeK6CvQ2ZMM1F6Ee8r7P8rL/CT dqctLczZq+/XVbqQIvJ5Vx/SwxMFe7UwNvpkI6Za9PDryLof6uHFWWtIRzgPIdqOkHuC3XUS6gB YfEmBh0HB+gFtSIkToCS0qGq/fgZnaeMm3qdhvBr4ZrOxeapb1rtIqyPg/1RHsnLQmuhsDro2Iq 6mMBb6tu7otMba+Dprxz17huooLZ1Srkqy/W1MFKpk6r7DtE/kYh3A4uhSJ9X12+0np6jCcMFhM gtFcKQ1zz8vKRUJNuft X-Received: by 2002:a05:600c:c285:b0:48e:5fb8:f80f with SMTP id 5b1f17b1804b1-490a2966ce7mr127618575e9.24.1780327505077; Mon, 01 Jun 2026 08:25:05 -0700 (PDT) Received: from [127.0.1.1] (cust-east-par-46-193-119-166.cust.wifirst.net. [46.193.119.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b0e26050sm26035e9.9.2026.06.01.08.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 08:25:03 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Mon, 01 Jun 2026 17:19:57 +0200 Subject: [PATCH net-next v9 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260601-ksz87xx_errata_low_loss_connections-v9-3-fdbbb15592cb@exotec.com> References: <20260601-ksz87xx_errata_low_loss_connections-v9-0-fdbbb15592cb@exotec.com> In-Reply-To: <20260601-ksz87xx_errata_low_loss_connections-v9-0-fdbbb15592cb@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolai Buchwitz , Fidelio Lawson , Marek Vasut X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1780327500; l=3475; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=zjoxIx46y8e3QGMsOJPRBZDqL8SBHdoXyjTLZD2h7K8=; b=PECfV7U8hmgqj7gRKVI6cAaQpYgjEmYIwY0885vRoI//497leFC4zZBFBa7NNk7YSEWw0Ioge axsnDEC5TN8Diz8F+OLnP5dqwMoaq+wgNM0G2VLqpGIQC0m7iBghvod X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Add support for the KSZ87xx low-loss cable PHY tunables in the Micrel PHY driver by implementing get_tunable and set_tunable callbacks. These callbacks expose vendor-specific PHY tunables used to control the KSZ87xx embedded PHY receiver behavior when operating with short or low-loss Ethernet cables. The tunables provide: - a boolean short-cable preset applying known good settings; - an integer LPF bandwidth control; - an integer DSP EQ initial value control. The Micrel PHY driver forwards these tunables via standard phy_read() / phy_write() operations, which are virtualized by the KSZ8 DSA driver and translated into the appropriate indirect switch register accesses. Reviewed-by: Marek Vasut Reviewed-by: Nicolai Buchwitz Signed-off-by: Fidelio Lawson --- drivers/net/phy/micrel.c | 54 ++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 54 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index e211a523c258..bb8f3054e257 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -287,6 +287,12 @@ /* PHY Control 2 / PHY Control (if no PHY Control 1) */ #define MII_KSZPHY_CTRL_2 0x1f #define MII_KSZPHY_CTRL MII_KSZPHY_CTRL_2 + +/* Vendor-specific Clause 22 register, virtualized by KSZ87xx embedded PHY= s DSA driver */ +#define MII_KSZ87XX_SHORT_CABLE 0x1a +#define MII_KSZ87XX_LPF_BW 0x1b +#define MII_KSZ87XX_EQ_INIT 0x1c + /* bitmap of PHY register to set interrupt mode */ #define KSZ8081_CTRL2_HP_MDIX BIT(15) #define KSZ8081_CTRL2_MDI_MDI_X_SELECT BIT(14) @@ -940,6 +946,52 @@ static int ksz8795_match_phy_device(struct phy_device = *phydev, return ksz8051_ksz8795_match_phy_device(phydev, false); } =20 +static int ksz8795_get_tunable(struct phy_device *phydev, + struct ethtool_tunable *tuna, void *data) +{ + int ret; + + switch (tuna->id) { + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + ret =3D phy_read(phydev, MII_KSZ87XX_SHORT_CABLE); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + case ETHTOOL_PHY_LPF_BW: + ret =3D phy_read(phydev, MII_KSZ87XX_LPF_BW); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: + ret =3D phy_read(phydev, MII_KSZ87XX_EQ_INIT); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int ksz8795_set_tunable(struct phy_device *phydev, + struct ethtool_tunable *tuna, const void *data) +{ + u8 val =3D *(const u8 *)data; + + switch (tuna->id) { + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + return phy_write(phydev, MII_KSZ87XX_SHORT_CABLE, val); + case ETHTOOL_PHY_LPF_BW: + return phy_write(phydev, MII_KSZ87XX_LPF_BW, val); + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: + return phy_write(phydev, MII_KSZ87XX_EQ_INIT, val); + default: + return -EOPNOTSUPP; + } +} + static int ksz9021_load_values_from_of(struct phy_device *phydev, const struct device_node *of_node, u16 reg, @@ -6961,6 +7013,8 @@ static struct phy_driver ksphy_driver[] =3D { /* PHY_BASIC_FEATURES */ .config_init =3D kszphy_config_init, .match_phy_device =3D ksz8795_match_phy_device, + .get_tunable =3D ksz8795_get_tunable, + .set_tunable =3D ksz8795_set_tunable, .suspend =3D genphy_suspend, .resume =3D genphy_resume, }, { --=20 2.54.0